PMD Results
The following document contains the results of PMD 7.3.0.
Violations By Priority
Priority 1
org/apache/turbine/Turbine.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 187 |
org/apache/turbine/annotation/AnnotationProcessor.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 56 |
| FieldNamingConventions | The constant name 'annotationCache' doesn't match '[A-Z][A-Z_0-9]*' | 59 |
org/apache/turbine/modules/GenericLoader.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'TURBINE_PACKAGES' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
org/apache/turbine/modules/ScheduledJobLoader.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 86 |
org/apache/turbine/modules/actions/AccessController.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 74 |
org/apache/turbine/modules/layouts/JspLayout.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 45 |
org/apache/turbine/modules/layouts/VelocityLayout.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
org/apache/turbine/modules/navigations/BaseJspNavigation.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 42 |
org/apache/turbine/modules/navigations/VelocityNavigation.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 48 |
org/apache/turbine/modules/screens/BaseJspScreen.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 43 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 74 |
org/apache/turbine/modules/screens/JSONScreen.java
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 130 |
| LocalVariableNamingConventions | The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' | 133 |
org/apache/turbine/modules/screens/PlainJSONScreen.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 78 |
| LocalVariableNamingConventions | The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' | 107 |
org/apache/turbine/modules/screens/RawScreen.java
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 92 |
org/apache/turbine/modules/screens/TemplateScreen.java
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 92 |
org/apache/turbine/modules/screens/VelocityCachedScreen.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 64 |
org/apache/turbine/modules/screens/VelocityDirectScreen.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 65 |
org/apache/turbine/modules/screens/VelocityScreen.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 52 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 120 |
org/apache/turbine/om/security/DefaultUserImpl.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultUserImpl.setCreateDate(Date) | 70 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultUserImpl.setHasLoggedIn(Boolean) | 72 |
org/apache/turbine/pipeline/DefaultSetEncodingValve.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 50 |
org/apache/turbine/pipeline/DetermineActionValve.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 46 |
org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 43 |
org/apache/turbine/pipeline/DetermineTargetValve.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 47 |
org/apache/turbine/services/BaseServiceBroker.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 109 |
| LocalVariableNamingConventions | The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' | 642 |
| LocalVariableNamingConventions | The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' | 671 |
org/apache/turbine/services/TurbineBaseService.java
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 92 |
org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java
| Rule | Violation | Line |
|---|---|---|
| LocalVariableNamingConventions | The local variable name '_servClass' doesn't match '[a-z][a-zA-Z0-9]*' | 90 |
org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 78 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 132 |
org/apache/turbine/services/intake/IntakeTool.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 56 |
org/apache/turbine/services/jsonrpc/JSONProcessor.java
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 51 |
| LocalVariableNamingConventions | The local variable name 'json_req' doesn't match '[a-z][a-zA-Z0-9]*' | 54 |
| LocalVariableNamingConventions | The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' | 55 |
| LocalVariableNamingConventions | The local variable name 'object_id' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
org/apache/turbine/services/jsonrpc/JsonRpcService.java
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 51 |
org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 46 |
| LocalVariableNamingConventions | The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
| LocalVariableNamingConventions | The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 67 |
org/apache/turbine/services/jsp/TurbineJspService.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 143 |
org/apache/turbine/services/localization/DateTimeFormatterService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 72 |
org/apache/turbine/services/localization/LocalizationTool.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: LocalizationTool.refresh() | 59 |
org/apache/turbine/services/localization/RundataLocalizationService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 45 |
org/apache/turbine/services/pull/TurbinePullService.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 837 |
org/apache/turbine/services/pull/tools/TemplateLink.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 95 |
org/apache/turbine/services/pull/tools/UITool.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 68 |
org/apache/turbine/services/pull/util/DateTimeFormatterTool.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 61 |
org/apache/turbine/services/rundata/DefaultTurbineRunData.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 154 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultPipelineData.put(Class<?>, Map<Class<?>, ? super Object>) | 207 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultTurbineRunData.recycle() | 208 |
org/apache/turbine/services/schedule/AbstractJobEntry.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 38 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 98 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setSecond(int) | 110 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setMinute(int) | 111 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setHour(int) | 112 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setWeekDay(int) | 113 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setDayOfMonth(int) | 114 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setTask(String) | 115 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.calcRunTime() | 117 |
org/apache/turbine/services/schedule/AbstractSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 44 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 118 |
org/apache/turbine/services/schedule/JobEntryNonPersistent.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 36 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 83 |
| LocalVariableNamingConventions | The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' | 119 |
org/apache/turbine/services/schedule/JobEntryQuartz.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: JobEntryQuartz.setTask(String) | 84 |
| LocalVariableNamingConventions | The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' | 95 |
org/apache/turbine/services/schedule/JobQueue.java
| Rule | Violation | Line |
|---|---|---|
| ReturnEmptyCollectionRatherThanNull | Return an empty collection rather than null. | 112 |
org/apache/turbine/services/schedule/QuartzSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 54 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 103 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 140 |
org/apache/turbine/services/schedule/ScheduleService.java
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 85 |
org/apache/turbine/services/schedule/SchedulerTool.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 41 |
org/apache/turbine/services/schedule/TorqueSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 71 |
org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 122 |
org/apache/turbine/services/schedule/WorkerThread.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 45 |
org/apache/turbine/services/security/DefaultSecurityService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 104 |
org/apache/turbine/services/security/DefaultUserManager.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 88 |
org/apache/turbine/services/servlet/TurbineServletService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 55 |
org/apache/turbine/services/template/TurbineTemplateService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 186 |
org/apache/turbine/services/template/mapper/ClassMapper.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 63 |
org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 55 |
org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 51 |
org/apache/turbine/services/ui/TurbineUIService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 62 |
org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
| FieldNamingConventions | The constant name 'counter' doesn't match '[A-Z][A-Z_0-9]*' | 56 |
org/apache/turbine/services/urlmapper/TurbineURLMapperService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 79 |
org/apache/turbine/services/velocity/TurbineVelocityService.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 95 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 228 |
org/apache/turbine/util/BrowserDetector.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BrowserDetector.getUserAgent() | 81 |
org/apache/turbine/util/FormMessage.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: FormMessage.setFormName(String) | 55 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: FormMessage.setFieldName(String) | 68 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: FormMessage.setMessage(String) | 83 |
org/apache/turbine/util/FormMessages.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name 'forms_messages' doesn't match '[a-z][a-zA-Z0-9]*' | 36 |
| FieldNamingConventions | The final field name 'fields_messages' doesn't match '[a-z][a-zA-Z0-9]*' | 38 |
| FieldNamingConventions | The final field name 'messages_fields' doesn't match '[a-z][a-zA-Z0-9]*' | 40 |
| FieldNamingConventions | The final field name 'forms_fields' doesn't match '[a-z][a-zA-Z0-9]*' | 42 |
| ReturnEmptyCollectionRatherThanNull | Return an empty collection rather than null. | 153 |
| ReturnEmptyCollectionRatherThanNull | Return an empty collection rather than null. | 181 |
org/apache/turbine/util/GenerateUniqueId.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The static field name 'session_count' doesn't match '[a-z][a-zA-Z0-9]*' | 50 |
| FieldNamingConventions | The public constant name 'maxRandomLen' doesn't match '[A-Z][A-Z_0-9]*' | 61 |
| FieldNamingConventions | The public constant name 'maxSessionLifespanTics' doesn't match '[A-Z][A-Z_0-9]*' | 69 |
| FieldNamingConventions | The public constant name 'ticDifference' doesn't match '[A-Z][A-Z_0-9]*' | 75 |
org/apache/turbine/util/LocaleUtils.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 64 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 174 |
org/apache/turbine/util/ObjectUtils.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 47 |
org/apache/turbine/util/ServerData.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 60 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerName(String) | 86 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerPort(int) | 87 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerScheme(String) | 88 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setScriptName(String) | 89 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setContextPath(String) | 90 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerName(String) | 102 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerPort(int) | 103 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerScheme(String) | 104 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setScriptName(String) | 105 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setContextPath(String) | 106 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerName(String) | 117 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerPort(int) | 118 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerScheme(String) | 119 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setScriptName(String) | 120 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setContextPath(String) | 121 |
org/apache/turbine/util/TurbineConfig.java
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 382 |
org/apache/turbine/util/template/HtmlPageAttributes.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: HtmlPageAttributes.init(Object) | 144 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: LinkTag.setRelation(String) | 525 |
org/apache/turbine/util/template/TemplateNavigation.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 97 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 108 |
org/apache/turbine/util/template/TemplateScreen.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 52 |
org/apache/turbine/util/template/TemplateSecurityCheck.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateSecurityCheck.setMessage(String) | 71 |
org/apache/turbine/util/uri/BaseURI.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 51 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 82 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 93 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 105 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setRedirect(boolean) | 106 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 117 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 129 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setRedirect(boolean) | 130 |
org/apache/turbine/util/uri/TemplateURI.java
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 84 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 97 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 110 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 124 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 157 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 170 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 183 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 197 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 209 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 210 |
org/apache/turbine/util/uri/TurbineURI.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 59 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 120 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 133 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 146 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 160 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 195 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 208 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 221 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 236 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 248 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 249 |
org/apache/turbine/util/velocity/VelocityEmail.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 107 |
org/apache/turbine/util/velocity/VelocityHtmlEmail.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 88 |
org/apache/turbine/services/schedule/BaseJobEntryTorque.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'peer' doesn't match '[A-Z][A-Z_0-9]*' | 719 |
org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The public constant name 'numColumns' doesn't match '[A-Z][A-Z_0-9]*' | 66 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1472 |
Priority 2
org/apache/turbine/Turbine.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 161 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 479–480 |
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 530 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 909 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 953 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 958 |
org/apache/turbine/annotation/AnnotationProcessor.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 257 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 310 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'manager' | 341 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 357 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 554 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 592 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 650 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'serviceName' | 688 |
org/apache/turbine/modules/ActionEvent.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 366 |
org/apache/turbine/modules/screens/BaseJspScreen.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 73 |
org/apache/turbine/modules/screens/VelocityCachedScreen.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 63 |
org/apache/turbine/modules/screens/VelocityDirectScreen.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 64 |
org/apache/turbine/modules/screens/VelocityScreen.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 119 |
org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 83 |
org/apache/turbine/services/BaseServiceBroker.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 487–488 |
org/apache/turbine/services/FieldAnnotatedTurbineBaseService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 56 |
org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 107 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 223 |
org/apache/turbine/services/intake/IntakeTool.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 463 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 529–530 |
org/apache/turbine/services/localization/DateTimeFormatterService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 111–113 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 152 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 159 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'incomingFormatPattern' | 184 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'incomingFormat' | 209 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'outgoingFormat' | 216 |
org/apache/turbine/services/localization/RundataLocalizationService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 50–51 |
org/apache/turbine/services/pull/TurbinePullService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 479–480 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 509–510 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 579 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 584 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 590–591 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 657 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 663 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 669–670 |
org/apache/turbine/services/pull/util/DateTimeFormatterTool.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 111 |
org/apache/turbine/services/schedule/WorkerThread.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 79–80 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 99–100 |
org/apache/turbine/services/security/DefaultSecurityService.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 101 |
org/apache/turbine/services/template/TurbineTemplateService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 295 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 785 |
org/apache/turbine/services/template/mapper/ClassMapper.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 91 |
org/apache/turbine/services/ui/TurbineUIService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 306 |
org/apache/turbine/services/urlmapper/TurbineURLMapperService.java
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'url' | 222 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 245 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 311 |
org/apache/turbine/services/velocity/TurbineVelocityService.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 224 |
org/apache/turbine/util/BrowserDetector.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 56 |
org/apache/turbine/util/GenerateUniqueId.java
| Rule | Violation | Line |
|---|---|---|
| SystemPrintln | Usage of System.out/err | 154 |
| SystemPrintln | Usage of System.out/err | 155 |
| SystemPrintln | Usage of System.out/err | 156 |
| SystemPrintln | Usage of System.out/err | 157 |
org/apache/turbine/util/ObjectUtils.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 71 |
org/apache/turbine/util/ServerData.java
| Rule | Violation | Line |
|---|---|---|
| ProperCloneImplementation | Object clone() should be implemented with super.clone() | 130 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 174 |
org/apache/turbine/util/uri/BaseURI.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 512 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 517 |
org/apache/turbine/util/uri/TurbineURI.java
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 278 |
Priority 3
org/apache/turbine/Turbine.java
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 1–1093 |
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 1–1093 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 118 |
| GodClass | Possible God Class (WMC=85, ATFD=57, TCC=11.694%) | 118 |
| CyclomaticComplexity | The class 'Turbine' has a total cyclomatic complexity of 85 (highest 12). | 118 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 119–1093 |
| LongVariable | Avoid excessively long variable names like REDIRECTED_PATHINFO_NAME | 130 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pipeline' | 148 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'initFailure' | 151 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverData' | 161 |
| SingularField | Perhaps 'webappRoot' could be replaced by a local variable. | 176 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'configuration' | 179 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 212 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 216 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 220 |
| ExceptionAsFlowControl | Exception thrown at line 223 is caught in this block. | 231–237 |
| ExceptionAsFlowControl | Exception thrown at line 228 is caught in this block. | 231–237 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 231 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 257 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 257 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 258 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 271 |
| LocalVariableCouldBeFinal | Local variable 'confPath' could be declared final | 309 |
| LocalVariableCouldBeFinal | Local variable 'jaxb' could be declared final | 354 |
| LocalVariableCouldBeFinal | Local variable 'unmarshaller' could be declared final | 355 |
| CyclomaticComplexity | The method 'configureApplication(ServletConfig, ServletContext)' has a cyclomatic complexity of 12. | 381 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 381 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 381 |
| LocalVariableCouldBeFinal | Local variable 'params' could be declared final | 417 |
| LongVariable | Avoid excessively long variable names like confFileRelativePath | 427 |
| LocalVariableCouldBeFinal | Local variable 'confFileRelativePath' could be declared final | 427 |
| LongVariable | Avoid excessively long variable names like targetPathDirectory | 433 |
| LocalVariableCouldBeFinal | Local variable 'targetPathDirectory' could be declared final | 433 |
| LocalVariableCouldBeFinal | Local variable 'targetFilePath' could be declared final | 439 |
| LocalVariableCouldBeFinal | Local variable 'combinedBuilder' could be declared final | 453 |
| LocalVariableCouldBeFinal | Local variable 'propertiesBuilder' could be declared final | 462 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 500 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 501 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 501 |
| MethodArgumentCouldBeFinal | Parameter 'defaultValue' is not assigned and could be declared final | 501 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 524 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 543 |
| LocalVariableCouldBeFinal | Local variable 'services' could be declared final | 557 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 559 |
| LocalVariableCouldBeFinal | Local variable 'serviceName' could be declared final | 561 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 562 |
| NonThreadSafeSingleton | Singleton is not thread safe | 658–677 |
| LocalVariableCouldBeFinal | Local variable 'serverName' could be declared final | 660 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 687 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 708 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 751 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 751 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 767 |
| LocalVariableCouldBeFinal | Local variable 'runDataMap' could be declared final | 767 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 785 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 790 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 810 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 810 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 842 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 842 |
| ShortVariable | Avoid variables with short names like t | 843 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 843 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 845 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 863 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 876 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 877 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 880 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 894 |
| ShortVariable | Avoid variables with short names like t | 894 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 894 |
| CloseResource | Ensure that resources like this PrintWriter object are closed after use | 900 |
| LocalVariableCouldBeFinal | Local variable 'writer' could be declared final | 900 |
| LawOfDemeter | Call to `println` on foreign value `writer` (degree 2) | 901 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 904 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 919 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 919 |
| LocalVariableCouldBeFinal | Local variable 'requestServerData' could be declared final | 928 |
| MethodArgumentCouldBeFinal | Parameter 'logConf' is not assigned and could be declared final | 941 |
| CloseResource | Ensure that resources like this LoggerContext object are closed after use | 943 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 943 |
| LawOfDemeter | Call to `getConfigurationSource` on foreign value `context.getConfiguration()` (degree 1) | 945 |
| LocalVariableCouldBeFinal | Local variable 'log4jFile' could be declared final | 947 |
| LocalVariableCouldBeFinal | Local variable 'ctxContext' could be declared final | 951 |
| LawOfDemeter | Call to `getConfigurationSource` on foreign value `context.getConfiguration()` (degree 1) | 953 |
| LawOfDemeter | Call to `getConfigurationSource` on foreign value `context.getConfiguration()` (degree 1) | 958 |
| CognitiveComplexity | The method 'resolveLog4j2(Path)' has a cognitive complexity of 21, current threshold is 15 | 970 |
| CyclomaticComplexity | The method 'resolveLog4j2(Path)' has a cyclomatic complexity of 12. | 970 |
| MethodArgumentCouldBeFinal | Parameter 'logConfPath' is not assigned and could be declared final | 970 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 980 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 985–1005 |
| LocalVariableCouldBeFinal | Local variable 'log4jFilePath' could be declared final | 987 |
| MethodArgumentCouldBeFinal | Parameter 'val' is not assigned and could be declared final | 1016 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 1049 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 1053 |
org/apache/turbine/TurbineConstants.java
| Rule | Violation | Line |
|---|---|---|
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 48 |
| LongVariable | Avoid excessively long variable names like LOG4J2_CONFIG_FILE | 51 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 51 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 53 |
| LongVariable | Avoid excessively long variable names like LOG4J2_CONFIG_FILE_DEFAULT | 56 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 56 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 59 |
| LongVariable | Avoid excessively long variable names like SCHEDULER_LOG_FACILITY | 62 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 62 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 65 |
| LongVariable | Avoid excessively long variable names like MAIL_SERVER_DEFAULT | 68 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 68 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 71 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 74 |
| LongVariable | Avoid excessively long variable names like MODULE_CACHE_DEFAULT | 77 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 77 |
| LongVariable | Avoid excessively long variable names like MODULE_CACHE_SIZE_KEY | 80 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 80 |
| LongVariable | Avoid excessively long variable names like MODULE_CACHE_SIZE_DEFAULT | 83 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 83 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 86 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 89 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 92 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_ERROR_KEY | 95 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 95 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_ERROR_JSP | 98 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 98 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 101 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 104 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 107 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 110 |
| LongVariable | Avoid excessively long variable names like SCREEN_ERROR_DEFAULT | 113 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 113 |
| LongVariable | Avoid excessively long variable names like SCREEN_INVALID_STATE | 116 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 116 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_INVALID_STATE | 119 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 119 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 122 |
| LongVariable | Avoid excessively long variable names like ACTION_LOGIN_DEFAULT | 125 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 125 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 128 |
| LongVariable | Avoid excessively long variable names like ACTION_LOGOUT_DEFAULT | 131 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 131 |
| LongVariable | Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_KEY | 134 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 134 |
| LongVariable | Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_DEFAULT | 137 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 137 |
| LongVariable | Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_KEY | 140 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 140 |
| LongVariable | Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_DEFAULT | 143 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 143 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_KEY | 146 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 146 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_DEFAULT | 149 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 149 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP | 152 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 152 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT | 155 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 155 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 158 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 161 |
| LongVariable | Avoid excessively long variable names like PAGE_DEFAULT_DEFAULT | 164 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 164 |
| LongVariable | Avoid excessively long variable names like SCREEN_DEFAULT_DEFAULT | 167 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 167 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 170 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 173 |
| LongVariable | Avoid excessively long variable names like LOGIN_MESSAGE_NOSCREEN | 176 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 176 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 179 |
| LongVariable | Avoid excessively long variable names like SESSION_TIMEOUT_KEY | 182 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 182 |
| LongVariable | Avoid excessively long variable names like SESSION_TIMEOUT_DEFAULT | 185 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 185 |
| LongVariable | Avoid excessively long variable names like SESSION_OBJECTINPUTFILTER | 191 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 191 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 194 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 197 |
| LongVariable | Avoid excessively long variable names like PP_URL_CASE_FOLDING | 203 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 203 |
| LongVariable | Avoid excessively long variable names like DEFAULT_DOCUMENT_TYPE_KEY | 206 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 206 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_KEY | 209 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 209 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_DEFAULT | 212 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 212 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_KEY | 215 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 215 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_DEFAULT | 218 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 218 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_KEY | 221 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 221 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_DEFAULT | 224 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 224 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_CONTENT_TYPE | 227 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 227 |
| LongVariable | Avoid excessively long variable names like DEFAULT_TEXT_CONTENT_TYPE | 228 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 228 |
| LongVariable | Avoid excessively long variable names like DEFAULT_CSS_CONTENT_TYPE | 229 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 229 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_KEY | 232 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 232 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_DEFAULT | 235 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 235 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_KEY | 238 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 238 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_DEFAULT | 241 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 241 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_KEY | 244 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 244 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_DEFAULT | 247 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 247 |
| LongVariable | Avoid excessively long variable names like LOCALE_OVERRIDE_CHARSET_KEY | 250 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 250 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 255 |
| LongVariable | Avoid excessively long variable names like APPLICATION_ROOT_KEY | 258 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 258 |
| LongVariable | Avoid excessively long variable names like APPLICATION_ROOT_DEFAULT | 261 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 261 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 268 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 271 |
| LongVariable | Avoid excessively long variable names like LOGGING_ROOT_DEFAULT | 274 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 274 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 277 |
| LongVariable | Avoid excessively long variable names like SCREEN_PLACEHOLDER | 280 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 280 |
| LongVariable | Avoid excessively long variable names like NAVIGATION_PLACEHOLDER | 283 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 283 |
| LongVariable | Avoid excessively long variable names like PROCESSING_EXCEPTION_PLACEHOLDER | 286 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 286 |
| LongVariable | Avoid excessively long variable names like STACK_TRACE_PLACEHOLDER | 289 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 289 |
| LongVariable | Avoid excessively long variable names like PARAMETER_ENCODING_KEY | 292 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 292 |
| LongVariable | Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT | 295 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 295 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SERVER_NAME_KEY | 298 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 298 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SERVER_PORT_KEY | 302 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 302 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SERVER_SCHEME_KEY | 306 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 306 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SCRIPT_NAME_KEY | 310 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 310 |
| LongVariable | Avoid excessively long variable names like DEFAULT_CONTEXT_PATH_KEY | 314 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 314 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 318 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 325 |
org/apache/turbine/annotation/AnnotationProcessor.java
| Rule | Violation | Line |
|---|---|---|
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 1–710 |
| GodClass | Possible God Class (WMC=106, ATFD=54, TCC=31.818%) | 53 |
| CyclomaticComplexity | The class 'AnnotationProcessor' has a total cyclomatic complexity of 106 (highest 27). | 53 |
| UseUtilityClass | This utility class has a non-private constructor | 53 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 54–710 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 68 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 70 |
| LocalVariableCouldBeFinal | Local variable 'newAnnotations' could be declared final | 74 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 101 |
| MethodArgumentCouldBeFinal | Parameter 'acl' is not assigned and could be declared final | 101 |
| NcssCount | The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a NCSS line count of 63. | 117 |
| CognitiveComplexity | The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a cognitive complexity of 100, current threshold is 15 | 117 |
| CyclomaticComplexity | The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a cyclomatic complexity of 27. | 117 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 117 |
| MethodArgumentCouldBeFinal | Parameter 'acl' is not assigned and could be declared final | 117 |
| MethodArgumentCouldBeFinal | Parameter 'conditonType' is not assigned and could be declared final | 117 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 119 |
| LocalVariableCouldBeFinal | Local variable 'annotation' could be declared final | 121 |
| LocalVariableCouldBeFinal | Local variable 'trr' could be declared final | 125 |
| LocalVariableCouldBeFinal | Local variable 'roleNames' could be declared final | 126 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 127 |
| LocalVariableCouldBeFinal | Local variable 'roleName' could be declared final | 131 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 134 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 137 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 143 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 149 |
| LocalVariableCouldBeFinal | Local variable 'roleName' could be declared final | 154 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 157 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 160 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 166 |
| LocalVariableCouldBeFinal | Local variable 'trp' could be declared final | 175 |
| LocalVariableCouldBeFinal | Local variable 'permissionNames' could be declared final | 176 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 177 |
| LocalVariableCouldBeFinal | Local variable 'permissionName' could be declared final | 181 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 184 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 187 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 193 |
| LocalVariableCouldBeFinal | Local variable 'permissionName' could be declared final | 201 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 204 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 207 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 213 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 233 |
| CognitiveComplexity | The method 'process(Object, Boolean)' has a cognitive complexity of 51, current threshold is 15 | 246 |
| CyclomaticComplexity | The method 'process(Object, Boolean)' has a cyclomatic complexity of 17. | 246 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 246 |
| LongVariable | Avoid excessively long variable names like hasTurbineServicesInMethodFields | 246 |
| MethodArgumentCouldBeFinal | Parameter 'hasTurbineServicesInMethodFields' is not assigned and could be declared final | 246 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 256 |
| LocalVariableCouldBeFinal | Local variable 'fields' could be declared final | 263 |
| LocalVariableCouldBeFinal | Local variable 'field' could be declared final | 265 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 267 |
| LocalVariableCouldBeFinal | Local variable 'a' could be declared final | 269 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 308–316 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 309 |
| CognitiveComplexity | The method 'processMethods(Object, ServiceManager, Class<?>, boolean)' has a cognitive complexity of 22, current threshold is 15 | 328 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 328 |
| MethodArgumentCouldBeFinal | Parameter 'clazz' is not assigned and could be declared final | 328 |
| MethodArgumentCouldBeFinal | Parameter 'isTurbineService' is not assigned and could be declared final | 328 |
| LocalVariableCouldBeFinal | Local variable 'methods' could be declared final | 329 |
| LocalVariableCouldBeFinal | Local variable 'method' could be declared final | 331 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 333 |
| LocalVariableCouldBeFinal | Local variable 'a' could be declared final | 334 |
| LocalVariableCouldBeFinal | Local variable 'classes' could be declared final | 352 |
| LocalVariableCouldBeFinal | Local variable 'c' could be declared final | 353 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 356 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 377 |
| MethodArgumentCouldBeFinal | Parameter 'assembler' is not assigned and could be declared final | 377 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 377 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 377 |
| LocalVariableCouldBeFinal | Local variable 'loader' could be declared final | 379 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 380 |
| AvoidDuplicateLiterals | The String literal "Injection of {} into object {}" appears 5 times in this file; the first occurrence is on line 384 | 384 |
| AvoidDuplicateLiterals | The String literal " into object " appears 6 times in this file; the first occurrence is on line 391 | 391 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 406 |
| MethodArgumentCouldBeFinal | Parameter 'pool' is not assigned and could be declared final | 406 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 406 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 406 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 415 |
| NcssCount | The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a NCSS line count of 81. | 438 |
| CognitiveComplexity | The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a cognitive complexity of 19, current threshold is 15 | 438 |
| CyclomaticComplexity | The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a cyclomatic complexity of 17. | 438 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 438 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 438 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 438 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 438 |
| LocalVariableCouldBeFinal | Local variable 'type' could be declared final | 440 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 441 |
| LongVariable | Avoid excessively long variable names like injectConfiguration | 447 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 460 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 467 |
| AvoidDuplicateLiterals | The String literal "Injection of key {} into object {}" appears 10 times in this file; the first occurrence is on line 468 | 468 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 470 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 475 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 478 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 483 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 486 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 491 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 494 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 499 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 502 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 507 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 510 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 515 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 518 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 523 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 526 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 531 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 534 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 539 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 542 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 550 |
| LocalVariableCouldBeFinal | Local variable 'defaultValue' could be declared final | 551 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 574 |
| MethodArgumentCouldBeFinal | Parameter 'manager' is not assigned and could be declared final | 574 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 574 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 574 |
| LocalVariableCouldBeFinal | Local variable 'typeFields' could be declared final | 586 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 589 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 591 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 605 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 606 |
| CyclomaticComplexity | The method 'injectTurbineService(Object, ServiceManager, Method, TurbineService)' has a cyclomatic complexity of 10. | 630 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 630 |
| MethodArgumentCouldBeFinal | Parameter 'manager' is not assigned and could be declared final | 630 |
| MethodArgumentCouldBeFinal | Parameter 'method' is not assigned and could be declared final | 630 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 630 |
| LocalVariableCouldBeFinal | Local variable 'classes' could be declared final | 640 |
| LocalVariableCouldBeFinal | Local variable 'c' could be declared final | 641 |
| LocalVariableCouldBeFinal | Local variable 'fields' could be declared final | 643 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 647 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 649 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 664 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 665 |
| LocalVariableCouldBeFinal | Local variable 'paramValues' could be declared final | 671 |
| MethodArgumentCouldBeFinal | Parameter 'fields' is not assigned and could be declared final | 682 |
| ControlStatementBraces | This statement should have braces | 683–707 |
| LocalVariableCouldBeFinal | Local variable 'f' could be declared final | 683 |
org/apache/turbine/annotation/TurbineService.java
| Rule | Violation | Line |
|---|---|---|
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 47 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 52 |
org/apache/turbine/modules/Action.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 41 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 53 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 62 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 62 |
org/apache/turbine/modules/ActionEvent.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 87 |
| LongVariable | Avoid excessively long variable names like METHOD_NAME_PREFIX | 99 |
| LongVariable | Avoid excessively long variable names like METHOD_NAME_LENGTH | 101 |
| ImmutableField | Field 'submitValueKey' may be declared final | 110 |
| ImmutableField | Field 'methodCache' may be declared final | 123 |
| CognitiveComplexity | The method 'getMethod(String, Class<?>[], ParameterParser)' has a cognitive complexity of 21, current threshold is 15 | 135 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 135 |
| MethodArgumentCouldBeFinal | Parameter 'signature' is not assigned and could be declared final | 135 |
| ShortVariable | Avoid variables with short names like pp | 135 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 135 |
| LocalVariableCouldBeFinal | Local variable 'cacheKey' could be declared final | 137 |
| LocalVariableCouldBeFinal | Local variable 'methods' could be declared final | 147 |
| LocalVariableCouldBeFinal | Local variable 'm' could be declared final | 150 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 152 |
| LocalVariableCouldBeFinal | Local variable 'a' could be declared final | 153 |
| LocalVariableCouldBeFinal | Local variable 'tae' could be declared final | 157 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 158–163 |
| LocalVariableCouldBeFinal | Local variable 'tmp' could be declared final | 171 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 171 |
| LocalVariableCouldBeFinal | Local variable 'oldMethod' could be declared final | 175 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 194 |
| ShortVariable | Avoid variables with short names like pp | 197 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 197 |
| CognitiveComplexity | The method 'executeEvents(ParameterParser, Class<?>[], Object[])' has a cognitive complexity of 17, current threshold is 15 | 210 |
| CyclomaticComplexity | The method 'executeEvents(ParameterParser, Class<?>[], Object[])' has a cyclomatic complexity of 12. | 210 |
| ShortVariable | Avoid variables with short names like pp | 210 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 210 |
| MethodArgumentCouldBeFinal | Parameter 'signature' is not assigned and could be declared final | 210 |
| MethodArgumentCouldBeFinal | Parameter 'parameters' is not assigned and could be declared final | 210 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 211 |
| LocalVariableCouldBeFinal | Local variable 'button' could be declared final | 216 |
| LocalVariableCouldBeFinal | Local variable 'k' could be declared final | 220 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 225–229 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 236 |
| UnusedAssignment | The initializer for variable 'method' is never used (overwritten on lines 244 and 248) | 240 |
| ShortVariable | Avoid variables with short names like t | 266 |
| LocalVariableCouldBeFinal | Local variable 't' could be declared final | 266 |
| MethodArgumentCouldBeFinal | Parameter 'input' is not assigned and could be declared final | 293 |
| ShortVariable | Avoid variables with short names like pp | 293 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 293 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 299 |
| LocalVariableCouldBeFinal | Local variable 'methodName' could be declared final | 302 |
| LawOfDemeter | Call to `getUrlFolding` on foreign value `pp` (degree 1) | 306 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 312 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 327 |
| ShortVariable | Avoid variables with short names like pp | 327 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 327 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 329–369 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 332 |
| LocalVariableCouldBeFinal | Local variable 'keyValue' could be declared final | 345 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 350 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 358 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 367 |
org/apache/turbine/modules/ActionLoader.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 59 |
org/apache/turbine/modules/GenericLoader.java
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like ab | 45 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'reload' | 54 |
| AvoidFieldNameMatchingMethodName | Field reload has the same name as a method | 54 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'TURBINE_PACKAGES' | 60 |
| MethodArgumentCouldBeFinal | Parameter 'assemblerClass' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'cacheSizeSupplier' is not assigned and could be declared final | 68 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 85 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReload' should not return any type except void linguistically | 109 |
| MethodArgumentCouldBeFinal | Parameter 'reload' is not assigned and could be declared final | 109 |
| NonThreadSafeSingleton | Singleton is not thread safe | 134–140 |
| LocalVariableCouldBeFinal | Local variable 'turbinePackages' could be declared final | 136 |
| LocalVariableCouldBeFinal | Local variable 'packages' could be declared final | 142 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 161 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 176 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 176 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 177 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 194 |
| LocalVariableCouldBeFinal | Local variable 'packages' could be declared final | 203 |
org/apache/turbine/modules/Layout.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 41 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 52 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 61 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 61 |
org/apache/turbine/modules/LayoutLoader.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 59 |
org/apache/turbine/modules/Loader.java
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 37 |
org/apache/turbine/modules/Navigation.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 42 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 57 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 67 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 68 |
org/apache/turbine/modules/NavigationLoader.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 63 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 63 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 64 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 78 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 78 |
org/apache/turbine/modules/Page.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 42 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 54 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 63 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 64 |
org/apache/turbine/modules/PageLoader.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 59 |
org/apache/turbine/modules/ScheduledJob.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 47 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 58 |
org/apache/turbine/modules/ScheduledJobLoader.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'job' is not assigned and could be declared final | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 59 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 60 |
org/apache/turbine/modules/Screen.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 45 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 59 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 69 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 70 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 89 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 91 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 91 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 101 |
| MethodArgumentCouldBeFinal | Parameter 'layout' is not assigned and could be declared final | 101 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 103 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 103 |
org/apache/turbine/modules/ScreenLoader.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 65 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 65 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 66 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 82 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 82 |
org/apache/turbine/modules/actions/AccessController.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 71 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 91 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 94 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 94 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 95 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 98 |
| LawOfDemeter | Call to `getAttribute` on foreign value `data.getSession()` (degree 2) | 102–103 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 102 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 108 |
org/apache/turbine/modules/actions/DefaultAction.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 45 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 48 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 48 |
org/apache/turbine/modules/actions/InitContextsAction.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 44 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 60 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 63 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 63 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 71 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 71 |
| LocalVariableCouldBeFinal | Local variable 'contextPropsList' could be declared final | 71 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 71 |
| LocalVariableCouldBeFinal | Local variable 'contextKeys' could be declared final | 72 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 74 |
| LocalVariableCouldBeFinal | Local variable 'start' could be declared final | 75 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 75 |
| LocalVariableCouldBeFinal | Local variable 'end' could be declared final | 76 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 76 |
| LocalVariableCouldBeFinal | Local variable 'contextName' could be declared final | 77 |
| UnusedAssignment | The initializer for variable 'contextProps' is never used (overwritten on lines 81 and 85) | 78 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 85 |
| LocalVariableCouldBeFinal | Local variable 'contextProps' could be declared final | 91 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 93 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 93 |
org/apache/turbine/modules/actions/LegacyVelocityAction.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 56 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 56 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 71 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 79 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 79 |
| ShortVariable | Avoid variables with short names like pp | 80 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 80 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 81 |
org/apache/turbine/modules/actions/LegacyVelocitySecureAction.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 41 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 51 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 68 |
org/apache/turbine/modules/actions/LoginUser.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 48 |
| ImmutableField | Field 'loginError' may be declared final | 64 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 85 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 88 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 88 |
| LocalVariableCouldBeFinal | Local variable 'username' could be declared final | 89 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 89 |
| LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 90 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 90 |
| LawOfDemeter | Call to `getAnonymousUser` on foreign value `security` (degree 1) | 99 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 105 |
| ExceptionAsFlowControl | Exception thrown at line 101 is caught in this block. | 132–154 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 132 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 134 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 142 |
org/apache/turbine/modules/actions/LogoutUser.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 41 |
| ImmutableField | Field 'actionLogout' may be declared final | 51 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 75 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 78 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 78 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 81 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 86 |
| LawOfDemeter | Call to `setHasLoggedIn` on foreign value `user` (degree 2) | 91 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 102 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 109 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 118 |
org/apache/turbine/modules/actions/VelocityAction.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 57 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 70 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 76 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 92 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 92 |
org/apache/turbine/modules/actions/VelocitySecureAction.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 52 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 69 |
org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 57 |
| LongVariable | Avoid excessively long variable names like loginMessageNoScreen | 70 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 84 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 87 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 87 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 95 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 101 |
org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 53 |
| LongVariable | Avoid excessively long variable names like templateInvalidState | 66 |
| LongVariable | Avoid excessively long variable names like screenInvalidState | 69 |
| CognitiveComplexity | The method 'handleFormCounterToken(RunData, boolean)' has a cognitive complexity of 20, current threshold is 15 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 79 |
| MethodArgumentCouldBeFinal | Parameter 'screenOnly' is not assigned and could be declared final | 79 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 81 |
| AvoidDuplicateLiterals | The String literal "_session_access_counter" appears 5 times in this file; the first occurrence is on line 81 | 81 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 85 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 86–87 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 86–87 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 86 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 89 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 90 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 98–117 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 98 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 99–100 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 99–100 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 99 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 102–114 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 102 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 104 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 105 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 107 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 111 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 115 |
org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 56 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 84 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 87 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 87 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 95 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 101 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 114 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 125 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 129 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 141 |
org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 60 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 62 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 62 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 70 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 77 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 81 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 93 |
org/apache/turbine/modules/layouts/DirectResponseLayout.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 37 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 46 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 49 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 49 |
org/apache/turbine/modules/layouts/JspLayout.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 58 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 61 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 61 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 62 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 66 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 71 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 76 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 76 |
org/apache/turbine/modules/layouts/VelocityCachedLayout.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 54 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 54 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 54 |
org/apache/turbine/modules/layouts/VelocityDirectLayout.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 48 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 48 |
org/apache/turbine/modules/layouts/VelocityLayout.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 43 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 63 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 66 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 66 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 68 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 76 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 76 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 79 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 80 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 97 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 108 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 108 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 108 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 109 |
org/apache/turbine/modules/layouts/VelocityOnlyLayout.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 65 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 75 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 75 |
| LocalVariableCouldBeFinal | Local variable 'screenName' could be declared final | 77 |
| LocalVariableCouldBeFinal | Local variable 'results' could be declared final | 83 |
| LocalVariableCouldBeFinal | Local variable 'returnValue' could be declared final | 84 |
org/apache/turbine/modules/layouts/VelocityXslLayout.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 55 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 73 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 76 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 76 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 78 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 80 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 88 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 88 |
| LocalVariableCouldBeFinal | Local variable 'temp' could be declared final | 93 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 99 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 100 |
org/apache/turbine/modules/navigations/BaseJspNavigation.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 69 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 72 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 72 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 74 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 74 |
org/apache/turbine/modules/navigations/LegacyVelocityNavigation.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 35 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 48 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 57 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 57 |
org/apache/turbine/modules/navigations/TemplateNavigation.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 34 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 44 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 52 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 62 |
org/apache/turbine/modules/navigations/VelocityNavigation.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 44 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 69 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 83 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 97 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 100 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 100 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 101 |
| LongVariable | Avoid excessively long variable names like navigationTemplate | 103 |
| LocalVariableCouldBeFinal | Local variable 'navigationTemplate' could be declared final | 103 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 103 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 104 |
org/apache/turbine/modules/pages/DefaultPage.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 92 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 116 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 119 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 119 |
| LocalVariableCouldBeFinal | Local variable 'screenName' could be declared final | 141 |
| LocalVariableCouldBeFinal | Local variable 'aScreen' could be declared final | 149 |
| LocalVariableCouldBeFinal | Local variable 'layout' could be declared final | 150 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 177 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 190 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 203 |
org/apache/turbine/modules/pages/JspPage.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 51 |
| LocalVariableCouldBeFinal | Local variable 'response' could be declared final | 58 |
| EmptyCatchBlock | Avoid empty catch blocks | 62–66 |
org/apache/turbine/modules/pages/TemplatePage.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 82 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 97 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 100 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 100 |
| LocalVariableCouldBeFinal | Local variable 'template' could be declared final | 110 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 110 |
| LocalVariableCouldBeFinal | Local variable 'layoutTemplate' could be declared final | 113 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 115 |
| LocalVariableCouldBeFinal | Local variable 'screen' could be declared final | 117 |
| LocalVariableCouldBeFinal | Local variable 'errMsg' could be declared final | 121 |
org/apache/turbine/modules/pages/VelocityPage.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 54 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 57 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 57 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 58 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 59 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 68 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 71 |
org/apache/turbine/modules/screens/BaseJspScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 61 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 64 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 64 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 65 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 65 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 67 |
org/apache/turbine/modules/screens/JSONScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 82 |
| LongVariable | Avoid excessively long variable names like JSONRPC_CONTENT_TYPE | 84 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 109 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 111 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 111 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 113 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 116 |
| ShortVariable | Avoid variables with short names like in | 117 |
| CloseResource | Ensure that resources like this BufferedReader object are closed after use | 117 |
| LocalVariableCouldBeFinal | Local variable 'in' could be declared final | 117 |
| LawOfDemeter | Call to `getInputStream` on foreign value `request` (degree 2) | 117 |
| LocalVariableCouldBeFinal | Local variable 'cdata' could be declared final | 120 |
| LocalVariableCouldBeFinal | Local variable 'buf' could be declared final | 121 |
| AssignmentInOperand | Avoid assignments in operands | 123 |
| LocalVariableCouldBeFinal | Local variable 'json_bridge' could be declared final | 130 |
| LocalVariableCouldBeFinal | Local variable 'json_res' could be declared final | 133 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 137 |
org/apache/turbine/modules/screens/JSONSecureScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 77 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 87 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 103 |
org/apache/turbine/modules/screens/JspErrorScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 34 |
| ImmutableField | Field 'templateError' may be declared final | 38 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 45 |
org/apache/turbine/modules/screens/LegacyVelocityScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 33 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 59 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 60 |
org/apache/turbine/modules/screens/LegacyVelocitySecureScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 34 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 56 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 76 |
org/apache/turbine/modules/screens/PlainJSONScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 72 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'log' | 78 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 101 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 103 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 103 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 105 |
| LocalVariableCouldBeFinal | Local variable 'json_res' could be declared final | 107 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 112 |
| StringToString | Avoid calling toString() on String objects; this is unnecessary. | 114 |
org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 32 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 43 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 60 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 60 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 61 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 61 |
| LocalVariableCouldBeFinal | Local variable 'methods' could be declared final | 62 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 65 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 70 |
org/apache/turbine/modules/screens/RawScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 45 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 56 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 59 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 59 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 60 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 83 |
org/apache/turbine/modules/screens/TemplateScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 52 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 72 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 83 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 106 |
| UnusedAssignment | The initializer for variable 'out' is never used (overwritten on line 114) | 109 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 135 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 135 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 137 |
| ShortVariable | Avoid variables with short names like ti | 138 |
| LocalVariableCouldBeFinal | Local variable 'ti' could be declared final | 138 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 138 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 139 |
| EmptyCatchBlock | Avoid empty catch blocks | 148–151 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 148 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 173 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 173 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 173 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 174 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 199 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 199 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 200 |
org/apache/turbine/modules/screens/VelocityCachedScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 50 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 53 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 53 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 54 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 56 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 56 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 57 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 71 |
org/apache/turbine/modules/screens/VelocityDirectScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 40 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 51 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 54 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 54 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 55 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 57 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 57 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 58 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 72 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 75 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 84 |
org/apache/turbine/modules/screens/VelocityErrorScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 47 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 47 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 50 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 50 |
| LawOfDemeter | Call to `getStackTraceException` on foreign value `data` (degree 1) | 52 |
org/apache/turbine/modules/screens/VelocityScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 48 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 76 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 90 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 104 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 107 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 107 |
| PrematureDeclaration | Declaration of 'screenData' can be moved closer to its usages | 108 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 110 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 112 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 112 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 113 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 131 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 139 |
org/apache/turbine/modules/screens/VelocitySecureScreen.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 41 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 64 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 84 |
org/apache/turbine/modules/screens/error/InvalidState.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 55 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 58 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 58 |
| LocalVariableCouldBeFinal | Local variable 'body' could be declared final | 59 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 62 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 65 characters appended. | 62 |
| ShortVariable | Avoid variables with short names like sb | 63 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 63 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 166 characters appended. | 63 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 7 consecutive times with literals. Use a single append with a single combined String. | 64 |
| ShortVariable | Avoid variables with short names like pp | 73 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 73 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 74 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 74 |
| LocalVariableCouldBeFinal | Local variable 'back' could be declared final | 77 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 77 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 77 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 79 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 79 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 82 |
org/apache/turbine/om/OMTool.java
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Field 'pullMap' may be declared final | 49 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 62 |
| LocalVariableCouldBeFinal | Local variable 'className' could be declared final | 65 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'omName' | 95 |
| MethodArgumentCouldBeFinal | Parameter 'omName' is not assigned and could be declared final | 97 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically | 102 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 102 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 103 |
| ShortVariable | Avoid variables with short names like om | 105 |
| UnusedAssignment | The initializer for variable 'om' is never used (overwritten on lines 110 and 114) | 105 |
| LocalVariableCouldBeFinal | Local variable 'inputKey' could be declared final | 106 |
| MethodArgumentCouldBeFinal | Parameter 'omName' is not assigned and could be declared final | 128 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 128 |
| ShortVariable | Avoid variables with short names like ph | 130 |
| LocalVariableCouldBeFinal | Local variable 'ph' could be declared final | 130 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 133 |
| MethodArgumentCouldBeFinal | Parameter 'omName' is not assigned and could be declared final | 146 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 146 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 146 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 153 |
org/apache/turbine/om/Retrievable.java
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 52 |
org/apache/turbine/om/Retriever.java
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 44 |
org/apache/turbine/om/RetrieverFactory.java
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 43 |
org/apache/turbine/om/security/DefaultUserImpl.java
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=67, ATFD=17, TCC=15.137%) | 44 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 44 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 45–758 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'lastAccessDate' | 50 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'permStorage' | 53 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'tempStorage' | 56 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'userDelegate' | 59 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 66 |
| LocalVariableCouldBeFinal | Local variable 'securityService' could be declared final | 100 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 106 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 135 |
| ShortVariable | Avoid variables with short names like id | 158 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 158 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 189 |
| MethodArgumentCouldBeFinal | Parameter 'firstName' is not assigned and could be declared final | 211 |
| MethodArgumentCouldBeFinal | Parameter 'lastName' is not assigned and could be declared final | 233 |
| MethodArgumentCouldBeFinal | Parameter 'address' is not assigned and could be declared final | 255 |
| MethodArgumentCouldBeFinal | Parameter 'objectdata' is not assigned and could be declared final | 280 |
| MethodArgumentCouldBeFinal | Parameter 'userGroupRoleSet' is not assigned and could be declared final | 305 |
| MethodArgumentCouldBeFinal | Parameter 'userGroupRole' is not assigned and could be declared final | 319 |
| MethodArgumentCouldBeFinal | Parameter 'userGroupRole' is not assigned and could be declared final | 333 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 348 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 348 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 350 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 366 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 366 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 368 |
| MethodArgumentCouldBeFinal | Parameter 'cnt' is not assigned and could be declared final | 399 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 401 |
| MethodArgumentCouldBeFinal | Parameter 'cnt' is not assigned and could be declared final | 411 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 413 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 449 |
| LocalVariableCouldBeFinal | Local variable 'objectdata' could be declared final | 453 |
| MethodArgumentCouldBeFinal | Parameter 'permStorage' is not assigned and could be declared final | 476 |
| MethodArgumentCouldBeFinal | Parameter 'tempStorage' is not assigned and could be declared final | 507 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 522 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 536 |
| MethodArgumentCouldBeFinal | Parameter 'def' is not assigned and could be declared final | 536 |
| LocalVariableCouldBeFinal | Local variable 'val' could be declared final | 540 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 541 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 543 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 556 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 556 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 568 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 582 |
| MethodArgumentCouldBeFinal | Parameter 'def' is not assigned and could be declared final | 582 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 593 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 607 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 607 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 619 |
| MethodArgumentCouldBeFinal | Parameter 'confirm' is not assigned and could be declared final | 641 |
| MethodArgumentCouldBeFinal | Parameter 'createDate' is not assigned and could be declared final | 663 |
| MethodArgumentCouldBeFinal | Parameter 'lastLogin' is not assigned and could be declared final | 685 |
| LocalVariableCouldBeFinal | Local variable 'loggedIn' could be declared final | 698 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 699 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 709 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 725 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 726 |
| MethodArgumentCouldBeFinal | Parameter 'userDelegate' is not assigned and could be declared final | 754 |
org/apache/turbine/om/security/User.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like SESSION_ACCESS_COUNTER | 60 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 288 |
org/apache/turbine/pipeline/CleanUpValve.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 49 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 58 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 58 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 65 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 79 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 81 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 81 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 88 |
| EmptyCatchBlock | Avoid empty catch blocks | 91–95 |
| LongVariable | Avoid excessively long variable names like invalidatedSession | 91 |
org/apache/turbine/pipeline/DefaultACLCreationValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 41 |
| LongVariable | Avoid excessively long variable names like actionAccessController | 49 |
| ImmutableField | Field 'actionAccessController' may be declared final | 49 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 55 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 55 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 67 |
org/apache/turbine/pipeline/DefaultLoginValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 50 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 67 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 67 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 74 |
| CognitiveComplexity | The method 'process(PipelineData)' has a cognitive complexity of 21, current threshold is 15 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 91 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 92 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 94 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 94 |
| LocalVariableCouldBeFinal | Local variable 'actionName' could be declared final | 100 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 118 |
| LawOfDemeter | Call to `getAttributeNames` on foreign value `data.getSession()` (degree 2) | 118 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 118 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 119–141 |
| LocalVariableCouldBeFinal | Local variable 'nameList' could be declared final | 123 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 129 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 129 |
| LocalVariableCouldBeFinal | Local variable 'name' could be declared final | 130 |
| LongVariable | Avoid excessively long variable names like invalidatedSession | 136 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 155 |
| ShortVariable | Avoid variables with short names like ti | 160 |
| LocalVariableCouldBeFinal | Local variable 'ti' could be declared final | 160 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 160 |
org/apache/turbine/pipeline/DefaultPipelineData.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 44 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 46–47 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 56 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 56 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 82 |
| MethodArgumentCouldBeFinal | Parameter 'innerKey' is not assigned and could be declared final | 82 |
| LocalVariableCouldBeFinal | Local variable 'innerMap' could be declared final | 84 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 87 |
| LocalVariableCouldBeFinal | Local variable 'rds' could be declared final | 98 |
org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 43 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 53 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 53 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 56 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 56 |
| LawOfDemeter | Call to `getSession` on foreign value `runData` (degree 1) | 59 |
| LawOfDemeter | Call to `getSession` on foreign value `runData` (degree 1) | 61 |
org/apache/turbine/pipeline/DefaultSessionValidationValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 41 |
| LongVariable | Avoid excessively long variable names like actionSessionValidator | 49 |
| ImmutableField | Field 'actionSessionValidator' may be declared final | 49 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 55 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 55 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 70 |
org/apache/turbine/pipeline/DefaultSetEncodingValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 47 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 56 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 56 |
| LocalVariableCouldBeFinal | Local variable 'req' could be declared final | 59 |
org/apache/turbine/pipeline/DetermineActionValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 43 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 53 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 53 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 56 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 56 |
| LocalVariableCouldBeFinal | Local variable 'action' could be declared final | 59 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 60 |
| LocalVariableCouldBeFinal | Local variable 'testAction' could be declared final | 66 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 67 |
org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 48 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 57 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 57 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 73 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 76 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 76 |
| LocalVariableCouldBeFinal | Local variable 'requestRedirected' could be declared final | 78 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 81 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 87 |
org/apache/turbine/pipeline/DetermineTargetValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 45 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 54 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 54 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 57 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 57 |
| LocalVariableCouldBeFinal | Local variable 'target' could be declared final | 60 |
| LawOfDemeter | Call to `getParameters` on foreign value `runData` (degree 1) | 60 |
| LocalVariableCouldBeFinal | Local variable 'testAction' could be declared final | 66 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 67 |
org/apache/turbine/pipeline/ExecutePageValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 43 |
| ImmutableField | Field 'pageDefault' may be declared final | 55 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 61 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 61 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 68 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 84 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 85 |
org/apache/turbine/pipeline/Pipeline.java
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 60 |
org/apache/turbine/pipeline/TurbinePipeline.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 48 |
| LooseCoupling | Avoid using implementation types like 'CopyOnWriteArrayList'; use the interface instead | 66 |
| ImmutableField | Field 'state' may be declared final | 71 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 84 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 97 |
| MethodArgumentCouldBeFinal | Parameter 'valve' is not assigned and could be declared final | 116 |
| MethodArgumentCouldBeFinal | Parameter 'valves' is not assigned and could be declared final | 139 |
| MethodArgumentCouldBeFinal | Parameter 'valve' is not assigned and could be declared final | 148 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 157 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 171 |
| LocalVariableCouldBeFinal | Local variable 'current' could be declared final | 175 |
org/apache/turbine/pipeline/Valve.java
| Rule | Violation | Line |
|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 100 |
org/apache/turbine/pipeline/XmlValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 34 |
| MethodArgumentCouldBeFinal | Parameter 'clazz' is not assigned and could be declared final | 54 |
org/apache/turbine/pipeline/XmlValveAdapter.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 29 |
| MethodArgumentCouldBeFinal | Parameter 'xmlValve' is not assigned and could be declared final | 35 |
| LocalVariableCouldBeFinal | Local variable 'valveClass' could be declared final | 37 |
| MethodArgumentCouldBeFinal | Parameter 'valve' is not assigned and could be declared final | 45 |
| LocalVariableCouldBeFinal | Local variable 'xmlValve' could be declared final | 47 |
org/apache/turbine/services/BaseInitable.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'isInitialized' | 41 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 50 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 61 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 137 |
org/apache/turbine/services/BaseInitableBroker.java
| Rule | Violation | Line |
|---|---|---|
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 63 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 63 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 63 |
| LooseCoupling | Avoid using implementation types like 'Stack'; use the interface instead | 70 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 90 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 90 |
| LocalVariableCouldBeFinal | Local variable 'pos' could be declared final | 92 |
| LocalVariableCouldBeFinal | Local variable 'instance' could be declared final | 98 |
| LongVariable | Avoid excessively long variable names like instanceInitialized | 99 |
| LocalVariableCouldBeFinal | Local variable 'instanceInitialized' could be declared final | 99 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 117 |
| LongVariable | Avoid excessively long variable names like dependencyPosition | 117 |
| MethodArgumentCouldBeFinal | Parameter 'dependencyPosition' is not assigned and could be declared final | 117 |
| LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 118 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 64 characters appended. | 118 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 141 |
| LocalVariableCouldBeFinal | Local variable 'initable' could be declared final | 145 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 174 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 175 |
| LocalVariableCouldBeFinal | Local variable 'initable' could be declared final | 177 |
| ExceptionAsFlowControl | Exception thrown at line 196 is caught in this block. | 204–208 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 225 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 226 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 237–240 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 241 |
| UnusedAssignment | The initializer for variable 'msg' is never used (overwritten on lines 248, 253, 258 and 263) | 244 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 246 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 251 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 256 |
org/apache/turbine/services/BaseService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 37 |
| DataClass | The class 'BaseService' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=8) | 37 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 58 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 69 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 116 |
org/apache/turbine/services/BaseServiceBroker.java
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=84, ATFD=19, TCC=17.391%) | 59 |
| CyclomaticComplexity | The class 'BaseServiceBroker' has a total cyclomatic complexity of 84 (highest 16). | 59 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 60–785 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 64 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 69 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 106 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 120 |
| LongVariable | Avoid excessively long variable names like serviceProviderInstanceMap | 120 |
| MethodArgumentCouldBeFinal | Parameter 'configuration' is not assigned and could be declared final | 140 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 186 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 186 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 197 |
| MethodArgumentCouldBeFinal | Parameter 'checkIfc' is not assigned and could be declared final | 210 |
| MethodArgumentCouldBeFinal | Parameter 'interfaces' is not assigned and could be declared final | 210 |
| LocalVariableCouldBeFinal | Local variable 'ifc' could be declared final | 212 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 216 |
| LocalVariableCouldBeFinal | Local variable 'subInterfaces' could be declared final | 219 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 222 |
| CognitiveComplexity | The method 'initMapping()' has a cognitive complexity of 24, current threshold is 15 | 246 |
| CyclomaticComplexity | The method 'initMapping()' has a cyclomatic complexity of 14. | 246 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 250 |
| LocalVariableCouldBeFinal | Local variable 'earlyInitFlags' could be declared final | 250 |
| LocalVariableCouldBeFinal | Local variable 'keys' could be declared final | 257 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 259 |
| LocalVariableCouldBeFinal | Local variable 'keyParts' could be declared final | 260 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 263 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 264 |
| LocalVariableCouldBeFinal | Local variable 'serviceKey' could be declared final | 266 |
| LocalVariableCouldBeFinal | Local variable 'className' could be declared final | 271 |
| LocalVariableCouldBeFinal | Local variable 'clazz' could be declared final | 274 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 278–282 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 285–288 |
| IdenticalCatchBranches | 'catch' branch identical to 'ThreadDeath' branch | 289–292 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 289–292 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 302 |
| MethodArgumentCouldBeFinal | Parameter 'serviceName' is not assigned and could be declared final | 316 |
| MethodArgumentCouldBeFinal | Parameter 'prefix' is not assigned and could be declared final | 338 |
| LocalVariableCouldBeFinal | Local variable 'keys' could be declared final | 340 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 357 |
| LocalVariableCouldBeFinal | Local variable 'instance' could be declared final | 363 |
| MethodArgumentCouldBeFinal | Parameter 'report' is not assigned and could be declared final | 406 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 407 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 412 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 420 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 441 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 442 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 462 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 466 |
| UnusedAssignment | The initializer for variable 'serviceName' is never used (overwritten on lines 514 and 520) | 501 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 510 |
| LongVariable | Avoid excessively long variable names like reverseServicesList | 510 |
| LocalVariableCouldBeFinal | Local variable 'reverseServicesList' could be declared final | 510 |
| LocalVariableCouldBeFinal | Local variable 'serviceNames' could be declared final | 512 |
| LocalVariableCouldBeFinal | Local variable 's' could be declared final | 518 |
| CyclomaticComplexity | The method 'getService(String)' has a cyclomatic complexity of 10. | 535 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 535 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 535 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 537 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 567 |
| ExceptionAsFlowControl | Exception thrown at line 564 is caught in this block. | 569–573 |
| CognitiveComplexity | The method 'getServiceInstance(String)' has a cognitive complexity of 28, current threshold is 15 | 607 |
| CyclomaticComplexity | The method 'getServiceInstance(String)' has a cyclomatic complexity of 16. | 607 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 607 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 608 |
| LocalVariableCouldBeFinal | Local variable 'clazz' could be declared final | 632 |
| LocalVariableCouldBeFinal | Local variable '_service' could be declared final | 642 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 655–658 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 659 |
| ExceptionAsFlowControl | Exception thrown at line 652 is caught in this block. | 664–668 |
| ExceptionAsFlowControl | Exception thrown at line 661 is caught in this block. | 664–668 |
| LocalVariableCouldBeFinal | Local variable '_service' could be declared final | 671 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 694 |
| MethodArgumentCouldBeFinal | Parameter 'applicationRoot' is not assigned and could be declared final | 704 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 728 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 742 |
| LongVariable | Avoid excessively long variable names like turbineServiceProvider | 744 |
| UnusedAssignment | The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 748) | 744 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 746 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 752 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 766 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 767 |
| LongVariable | Avoid excessively long variable names like turbineServiceProvider | 769 |
| UnusedAssignment | The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 773) | 769 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 771 |
org/apache/turbine/services/BaseUnicastRemoteService.java
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 55 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 59 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 60 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 61 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 74 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 87 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 114 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 141 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 162 |
org/apache/turbine/services/FieldAnnotatedTurbineBaseService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 37 |
org/apache/turbine/services/InitableBroker.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 97 |
org/apache/turbine/services/InitializationException.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 47 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 60 |
| ShortVariable | Avoid variables with short names like t | 60 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 60 |
org/apache/turbine/services/InstantiationException.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 51 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 63 |
| ShortVariable | Avoid variables with short names like t | 63 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 63 |
org/apache/turbine/services/MethodAnnotatedTurbineBaseService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 34 |
org/apache/turbine/services/ServiceBroker.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 95 |
org/apache/turbine/services/ServiceManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setServiceObject': the method is declared in an interface type | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getServiceObject': the method is declared in an interface type | 87 |
org/apache/turbine/services/TurbineBaseService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 59 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 72 |
org/apache/turbine/services/TurbineServiceProvider.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 42 |
org/apache/turbine/services/TurbineServices.java
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 67 |
| MethodArgumentCouldBeFinal | Parameter 'manager' is not assigned and could be declared final | 67 |
| LocalVariableCouldBeFinal | Local variable 'previous' could be declared final | 69 |
org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 57 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'factories' | 66 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'assemblerCache' | 69 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'loaderCache' | 72 |
| AvoidDuplicateLiterals | The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 86 | 86 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 87 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 91 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 102 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 105 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 107 |
| LocalVariableCouldBeFinal | Local variable 'name2' could be declared final | 109 |
| LocalVariableCouldBeFinal | Local variable 'factory' could be declared final | 111 |
| ShortVariable | Avoid variables with short names like af | 115 |
| LocalVariableCouldBeFinal | Local variable 'af' could be declared final | 115 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 120–123 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 126 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 148 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 150 |
| LocalVariableCouldBeFinal | Local variable 'type' could be declared final | 152 |
| LocalVariableCouldBeFinal | Local variable 'cacheSize' could be declared final | 172 |
| MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 192 |
| CognitiveComplexity | The method 'getAssembler(Class<T>, String)' has a cognitive complexity of 22, current threshold is 15 | 213 |
| CyclomaticComplexity | The method 'getAssembler(Class<T>, String)' has a cyclomatic complexity of 12. | 213 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 213 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 213 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 216 |
| PrematureDeclaration | Declaration of 'assembler' can be moved closer to its usages | 217 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 222 |
| LocalVariableCouldBeFinal | Local variable 'facs' could be declared final | 235 |
| LocalVariableCouldBeFinal | Local variable 'it' could be declared final | 237 |
| LocalVariableCouldBeFinal | Local variable 'fac' could be declared final | 239 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 245 |
| LocalVariableCouldBeFinal | Local variable 'oldAssembler' could be declared final | 259 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 260–263 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 283 |
| LocalVariableCouldBeFinal | Local variable 'facs' could be declared final | 295 |
| LocalVariableCouldBeFinal | Local variable 'it' could be declared final | 297 |
| LocalVariableCouldBeFinal | Local variable 'fac' could be declared final | 299 |
org/apache/turbine/services/assemblerbroker/util/java/JavaActionFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 44 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 57 |
| CognitiveComplexity | The method 'getAssembler(String, String)' has a cognitive complexity of 19, current threshold is 15 | 67 |
| MethodArgumentCouldBeFinal | Parameter 'packageName' is not assigned and could be declared final | 67 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 67 |
| LocalVariableCouldBeFinal | Local variable 'p' could be declared final | 75 |
| ShortVariable | Avoid variables with short names like sb | 77 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 77 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 77 |
| LocalVariableCouldBeFinal | Local variable 'className' could be declared final | 80 |
| LocalVariableCouldBeFinal | Local variable '_servClass' could be declared final | 90 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 91–94 |
org/apache/turbine/services/assemblerbroker/util/java/JavaLayoutFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaNavigationFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaPageFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaScheduledJobFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaScreenFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 46 |
org/apache/turbine/services/assemblerbroker/util/python/PythonActionFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 48 |
| LongVariable | Avoid excessively long variable names like PYTHON_CONFIG_FILE | 55 |
| MethodArgumentCouldBeFinal | Parameter 'subDirectory' is not assigned and could be declared final | 71 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 71 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 72 |
| LocalVariableCouldBeFinal | Local variable 'path' could be declared final | 74 |
| LocalVariableCouldBeFinal | Local variable 'confName' could be declared final | 86 |
| LocalVariableCouldBeFinal | Local variable 'fName' could be declared final | 89 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 91 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 92 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 92 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 93 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 94 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 94 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 95 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 95 |
| ShortVariable | Avoid variables with short names like f | 98 |
| LocalVariableCouldBeFinal | Local variable 'f' could be declared final | 98 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 112 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 130 |
| PreserveStackTrace | Thrown exception does not preserve the stack trace of exception 'e' on all code paths | 132–138 |
| ShortVariable | Avoid variables with short names like t | 143 |
| LocalVariableCouldBeFinal | Local variable 't' could be declared final | 143 |
| ExceptionAsFlowControl | Exception thrown at line 132 is caught in this block. | 146–153 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 146 |
org/apache/turbine/services/assemblerbroker/util/python/PythonLayoutFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonNavigationFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonPageFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonScreenFactory.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 49 |
org/apache/turbine/services/avaloncomponent/AvalonComponentService.java
| Rule | Violation | Line |
|---|---|---|
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 37 |
| LongVariable | Avoid excessively long variable names like AVALON_LOG_CATEGORY | 40 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 40 |
| LongVariable | Avoid excessively long variable names like COMPONENT_CONFIG_KEY | 43 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 43 |
| LongVariable | Avoid excessively long variable names like COMPONENT_CONFIG_VALUE | 46 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 46 |
| LongVariable | Avoid excessively long variable names like COMPONENT_ROLE_KEY | 49 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 49 |
| LongVariable | Avoid excessively long variable names like COMPONENT_ROLE_VALUE | 52 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 52 |
| LongVariable | Avoid excessively long variable names like COMPONENT_LOOKUP_KEY | 55 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 55 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 58 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 58 |
org/apache/turbine/services/avaloncomponent/TurbineYaafiComponentService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 44 |
| LongVariable | Avoid excessively long variable names like CONTAINER_CONFIGURATION_KEY | 52 |
| LongVariable | Avoid excessively long variable names like CONTAINER_CONFIGURATION_VALUE | 55 |
| LongVariable | Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY | 58 |
| LongVariable | Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE | 61 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 81 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 114 |
| LocalVariableCouldBeFinal | Local variable 'home' could be declared final | 117 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 121 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 132 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 148 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 159 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 170 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 179 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 193 |
| MethodArgumentCouldBeFinal | Parameter 'applicationRoot' is not assigned and could be declared final | 193 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 196 |
| LongVariable | Avoid excessively long variable names like containerConfiguration | 207 |
| LocalVariableCouldBeFinal | Local variable 'containerConfiguration' could be declared final | 207 |
| LongVariable | Avoid excessively long variable names like roleConfigurationFileName | 217 |
| LocalVariableCouldBeFinal | Local variable 'roleConfigurationFileName' could be declared final | 217 |
| LongVariable | Avoid excessively long variable names like componentConfigurationFileName | 224 |
| LocalVariableCouldBeFinal | Local variable 'componentConfigurationFileName' could be declared final | 224 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 231 |
| LocalVariableCouldBeFinal | Local variable 'parametersFileName' could be declared final | 231 |
| LongVariable | Avoid excessively long variable names like containerConfiguration | 244 |
| LocalVariableCouldBeFinal | Local variable 'containerConfiguration' could be declared final | 244 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 272 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 281 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 281 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 287 |
| LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 289 |
org/apache/turbine/services/intake/IntakeTool.java
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 54–551 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 65 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'groups' | 65 |
| ShortVariable | Avoid variables with short names like pp | 68 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 70 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 71 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 72 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pullMap' | 75 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 86 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 94 |
| LocalVariableCouldBeFinal | Local variable 'groupNames' could be declared final | 98 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 109 |
| LawOfDemeter | Call to `getParameters` on foreign value `(RunData) runData` (degree 1) | 113 |
| LocalVariableCouldBeFinal | Local variable 'groupKeys' could be declared final | 115 |
| UnusedAssignment | The initializer for variable 'groupNames' is never used (overwritten on lines 119 and 123) | 116 |
| LawOfDemeter | Access to field `length` on foreign value `groupKeys` (degree 2) | 123 |
| LawOfDemeter | Access to field `length` on foreign value `groupKeys` (degree 2) | 124 |
| LocalVariableCouldBeFinal | Local variable 'foundGroups' could be declared final | 134 |
| ShortVariable | Avoid variables with short names like vp | 155 |
| MethodArgumentCouldBeFinal | Parameter 'vp' is not assigned and could be declared final | 155 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 157 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 183 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 197 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 210 |
| ShortVariable | Avoid variables with short names like sb | 210 |
| MethodArgumentCouldBeFinal | Parameter 'sb' is not assigned and could be declared final | 210 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 230 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'groupName' | 252 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 259 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically | 283 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 283 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically | 297 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 297 |
| MethodArgumentCouldBeFinal | Parameter 'create' is not assigned and could be declared final | 297 |
| ShortVariable | Avoid variables with short names like g | 300 |
| LocalVariableCouldBeFinal | Local variable 'inputKey' could be declared final | 302 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 323 |
| ShortVariable | Avoid variables with short names like g | 325 |
| UnusedAssignment | The initializer for variable 'g' is never used (overwritten on lines 333 and 337) | 325 |
| LocalVariableCouldBeFinal | Local variable 'inputKey' could be declared final | 329 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 341 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 357 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 370 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 384 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 398 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 398 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 413 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 413 |
| MethodArgumentCouldBeFinal | Parameter 'create' is not assigned and could be declared final | 413 |
| ShortVariable | Avoid variables with short names like ph | 425 |
| LocalVariableCouldBeFinal | Local variable 'ph' could be declared final | 425 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 435 |
| LocalVariableCouldBeFinal | Local variable 'groupKeys' could be declared final | 442 |
| LocalVariableCouldBeFinal | Local variable 'groupKey' could be declared final | 448 |
| LocalVariableCouldBeFinal | Local variable 'allGroups' could be declared final | 475 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 478 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 495 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 521 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 536 |
org/apache/turbine/services/jsonrpc/JSONProcessor.java
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 39 |
| MethodArgumentCouldBeFinal | Parameter 'cdata' is not assigned and could be declared final | 51 |
| MethodArgumentCouldBeFinal | Parameter 'json_bridge' is not assigned and could be declared final | 51 |
| MethodArgumentCouldBeFinal | Parameter 'request' is not assigned and could be declared final | 51 |
| UnusedAssignment | The initializer for variable 'json_req' is never used (overwritten on line 58) | 54 |
| UnusedAssignment | The initializer for variable 'json_res' is never used (overwritten on lines 75 and 80) | 55 |
| LocalVariableCouldBeFinal | Local variable 'methodName' could be declared final | 61 |
| LocalVariableCouldBeFinal | Local variable 'arguments' could be declared final | 62 |
| LocalVariableCouldBeFinal | Local variable 'object_id' could be declared final | 65 |
| ShortVariable | Avoid variables with short names like sb | 66 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 66 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 69 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 71 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 71 |
org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 37 |
| MethodArgumentCouldBeFinal | Parameter 'cdata' is not assigned and could be declared final | 45 |
| MethodArgumentCouldBeFinal | Parameter 'json_bridge' is not assigned and could be declared final | 46 |
| MethodArgumentCouldBeFinal | Parameter 'request' is not assigned and could be declared final | 46 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 52 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 52 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 58 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 58 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 58 |
| LocalVariableCouldBeFinal | Local variable 'json_bridge' could be declared final | 60 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 65 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 77 |
org/apache/turbine/services/jsp/JspService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like BUFFER_SIZE_DEFAULT | 56 |
org/apache/turbine/services/jsp/TurbineJspService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 53 |
| LongVariable | Avoid excessively long variable names like relativeTemplatePaths | 61 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 87 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 101 |
| LocalVariableCouldBeFinal | Local variable 'req' could be declared final | 103 |
| LocalVariableCouldBeFinal | Local variable 'templateLink' could be declared final | 110 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 138 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 138 |
| MethodArgumentCouldBeFinal | Parameter 'isForward' is not assigned and could be declared final | 138 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 146 |
| LongVariable | Avoid excessively long variable names like relativeTemplateName | 149 |
| LocalVariableCouldBeFinal | Local variable 'relativeTemplateName' could be declared final | 149 |
| LocalVariableCouldBeFinal | Local variable 'dispatcher' could be declared final | 158 |
| LawOfDemeter | Call to `getRequestDispatcher` on foreign value `data.getServletContext()` (degree 2) | 158–159 |
| LawOfDemeter | Call to `getServletContext` on foreign value `data` (degree 1) | 158 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 170 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 175 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 180 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 182 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 205 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 205 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 215 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 217 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 244 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 258 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 258 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 273 |
| LocalVariableCouldBeFinal | Local variable 'relativeTemplate' could be declared final | 275 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 284 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 296 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 301 |
org/apache/turbine/services/jsp/util/JspNavigation.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 60 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 69 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 71 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 75 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 79 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 81 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 86 |
| EmptyCatchBlock | Avoid empty catch blocks | 88–91 |
org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 64 |
| LocalVariableCouldBeFinal | Local variable 'abs' could be declared final | 67 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 81 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 82 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 86 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 88 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 93 |
| EmptyCatchBlock | Avoid empty catch blocks | 95–98 |
org/apache/turbine/services/localization/DateTimeFormatterInterface.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like DATE_TIME_FORMAT_KEY | 33 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_KEY': the field is declared in an interface type | 33 |
| LongVariable | Avoid excessively long variable names like DATE_TIME_ZONEID_KEY | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'DATE_TIME_ZONEID_KEY': the field is declared in an interface type | 35 |
| LongVariable | Avoid excessively long variable names like USE_TURBINE_LOCALE_KEY | 37 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'USE_TURBINE_LOCALE_KEY': the field is declared in an interface type | 37 |
| LongVariable | Avoid excessively long variable names like USE_REQUEST_LOCALE_KEY | 39 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'USE_REQUEST_LOCALE_KEY': the field is declared in an interface type | 39 |
| LongVariable | Avoid excessively long variable names like DATE_TIME_FORMAT_DEFAULT | 42 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_DEFAULT': the field is declared in an interface type | 42 |
org/apache/turbine/services/localization/DateTimeFormatterService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 49 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'formatPattern' | 53 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dateTimeFormat' | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'locale' | 57 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 72 |
| LocalVariableCouldBeFinal | Local variable 'useTurbineLocale' could be declared final | 94 |
| LocalVariableCouldBeFinal | Local variable 'localeSetter' could be declared final | 97 |
| LocalVariableCouldBeFinal | Local variable 'zoneIdStr' could be declared final | 102 |
| LocalVariableCouldBeFinal | Local variable 'zoneIdSet' could be declared final | 104 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 118 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 124 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 124 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 130 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 130 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 130 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 136 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 136 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 136 |
| MethodArgumentCouldBeFinal | Parameter 'zoneId' is not assigned and could be declared final | 137 |
| UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 142 and 165) | 138 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 176 |
| LongVariable | Avoid excessively long variable names like outgoingFormatPattern | 176 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormatPattern' is not assigned and could be declared final | 176 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 176 |
| LongVariable | Avoid excessively long variable names like incomingFormatPattern | 176 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 180 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 187 |
| LocalVariableCouldBeFinal | Local variable 'incomingFormat' could be declared final | 189 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 200 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 200 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 205 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 212 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 224 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 224 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 230 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormat' is not assigned and could be declared final | 230 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 236 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 236 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 236 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 245 |
| MethodArgumentCouldBeFinal | Parameter 'zoneId' is not assigned and could be declared final | 254 |
org/apache/turbine/services/localization/LocalizationTool.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like localizationService | 46 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 75 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 79 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 122 |
| MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 122 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 134 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 152 |
org/apache/turbine/services/localization/RundataLocalizationService.java
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 43 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 43 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 48 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 49 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 49 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 55 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 55 |
| LocalVariableCouldBeFinal | Local variable 'locale' could be declared final | 61 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 61 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 61 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 64 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 64 |
| LambdaCanBeMethodReference | Lambda expression could be written as a method reference: `locale::getLanguage` | 68 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 69 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 72 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 74 |
org/apache/turbine/services/naming/TurbineNamingService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 50 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'contextPropsList' | 61 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 64 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 81 |
| LocalVariableCouldBeFinal | Local variable 'contextKeys' could be declared final | 86 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 89 |
| LocalVariableCouldBeFinal | Local variable 'end' could be declared final | 90 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 90 |
| LocalVariableCouldBeFinal | Local variable 'contextName' could be declared final | 97 |
| UnusedAssignment | The initializer for variable 'contextProps' is never used (overwritten on lines 102 and 106) | 98 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 106 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 115 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 117 |
| LocalVariableCouldBeFinal | Local variable 'contextProps' could be declared final | 118 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 119 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 119 |
| PreserveStackTrace | Thrown exception does not preserve the stack trace of exception 'e' on all code paths | 129–130 |
| MethodArgumentCouldBeFinal | Parameter 'contextName' is not assigned and could be declared final | 146 |
| UnusedAssignment | The initializer for variable 'contextProps' is never used (overwritten on lines 154 and 158) | 150 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 164 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 166 |
org/apache/turbine/services/pull/PullService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like TOOL_RESOURCES_DIR_KEY | 82 |
| LongVariable | Avoid excessively long variable names like TOOL_RESOURCES_DIR_DEFAULT | 88 |
| LongVariable | Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_KEY | 94 |
| LongVariable | Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_DEFAULT | 97 |
| LongVariable | Avoid excessively long variable names like SESSION_TOOLS_ATTRIBUTE_PREFIX | 100 |
org/apache/turbine/services/pull/TurbinePullService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 121 |
| GodClass | Possible God Class (WMC=65, ATFD=44, TCC=27.485%) | 121 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 124–841 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pool' | 129 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'velocity' | 132 |
| ImmutableField | Field 'toolName' may be declared final | 151 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'toolName' | 151 |
| ImmutableField | Field 'toolClassName' may be declared final | 152 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'toolClassName' | 152 |
| ImmutableField | Field 'toolClass' may be declared final | 153 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'toolClass' | 153 |
| MethodArgumentCouldBeFinal | Parameter 'toolName' is not assigned and could be declared final | 155 |
| MethodArgumentCouldBeFinal | Parameter 'toolClassName' is not assigned and could be declared final | 155 |
| MethodArgumentCouldBeFinal | Parameter 'toolClass' is not assigned and could be declared final | 155 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 164 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 167 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 170 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 173 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 176 |
| LongVariable | Avoid excessively long variable names like resourcesDirectory | 179 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 179 |
| LongVariable | Avoid excessively long variable names like refreshToolsPerRequest | 182 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'refreshToolsPerRequest' | 182 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 182 |
| ExceptionAsFlowControl | Exception thrown at line 197 is caught in this block. | 219–222 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 219 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 231 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 234 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 266 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 272 |
| LawOfDemeter | Call to `getNewContext` on foreign value `velocity` (degree 1) | 304 |
| MethodArgumentCouldBeFinal | Parameter 'toolConfig' is not assigned and could be declared final | 316 |
| LocalVariableCouldBeFinal | Local variable 'tools' could be declared final | 318 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 324 |
| LocalVariableCouldBeFinal | Local variable 'it' could be declared final | 327 |
| LocalVariableCouldBeFinal | Local variable 'toolName' could be declared final | 329 |
| LocalVariableCouldBeFinal | Local variable 'toolClassName' could be declared final | 330 |
| LocalVariableCouldBeFinal | Local variable 'toolClass' could be declared final | 335 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 377 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 377 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 391 |
| LocalVariableCouldBeFinal | Local variable 'userManager' could be declared final | 400 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 405 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 422 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 422 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 424 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 424 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 437 |
| LocalVariableCouldBeFinal | Local variable 'userManager' could be declared final | 446 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 451 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 463 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 465 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 469 |
| LawOfDemeter | Access to field `toolClass` on foreign value `toolData` (degree 1) | 469 |
| LawOfDemeter | Call to `getDeclaredConstructor` on foreign value `toolData.toolClass` (degree 2) | 469 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 477 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 491 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 491 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 494 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 499 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 507 |
| MethodArgumentCouldBeFinal | Parameter 'tools' is not assigned and could be declared final | 524 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 524 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 525 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 525 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 528 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 534 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 538 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 556 |
| LawOfDemeter | Call to `getClass` on foreign value `tool` (degree 2) | 558 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 588 |
| MethodArgumentCouldBeFinal | Parameter 'tools' is not assigned and could be declared final | 606 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 606 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 607 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 607 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 610 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 667 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 712 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 714 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 727 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 741 |
| MethodArgumentCouldBeFinal | Parameter 'tools' is not assigned and could be declared final | 741 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 745 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 747 |
| MethodArgumentCouldBeFinal | Parameter 'tool' is not assigned and could be declared final | 765 |
| MethodArgumentCouldBeFinal | Parameter 'param' is not assigned and could be declared final | 765 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 766 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 778 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 778 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 783 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 783 |
| MethodArgumentCouldBeFinal | Parameter 'tool' is not assigned and could be declared final | 810 |
| MethodArgumentCouldBeFinal | Parameter 'dataObject' is not assigned and could be declared final | 810 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 812 |
| CloseResource | Ensure that resources like this PipelineData object are closed after use | 813 |
| UnusedAssignment | The initializer for variable 'pipelineData' is never used (overwritten on line 816) | 813 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 833 |
org/apache/turbine/services/pull/tools/ContentTool.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_PREFIX | 54 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_ENCODING_KEY | 62 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_ENCODING_DEFAULT | 65 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_KEY | 68 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_DEFAULT | 71 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantEncoding' | 74 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'wantEncoding' | 74 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantRelative' | 77 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'wantRelative' | 77 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dataURI' | 80 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 85 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 107 |
| LocalVariableCouldBeFinal | Local variable 'pipelineData' could be declared final | 114 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 115 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 115 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 124 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 158 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 175 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 191 |
org/apache/turbine/services/pull/tools/TemplateLink.java
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 61–633 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_PREFIX | 63 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_KEY | 66 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_DEFAULT | 69 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantRelative' | 72 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_KEY | 80 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_DEFAULT | 83 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantEncoding' | 86 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'wantEncoding' | 86 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'template' | 89 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'templateURI' | 92 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 102 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 124 |
| LocalVariableCouldBeFinal | Local variable 'pipelineData' could be declared final | 131 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 132 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 132 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 140 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setEncodeURLOff' should not return any type except void linguistically | 184 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setPage' should not return any type except void linguistically | 196 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 196 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setAction' should not return any type except void linguistically | 224 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 224 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setActionEvent' should not return any type except void linguistically | 241 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 241 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 241 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically | 257 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 257 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReference' should not return any type except void linguistically | 270 |
| MethodArgumentCouldBeFinal | Parameter 'reference' is not assigned and could be declared final | 270 |
| ShortVariable | Avoid variables with short names like pp | 302 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 302 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 315 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 315 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 328 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 328 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 341 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 341 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 354 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 354 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 367 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 367 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 380 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 380 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 393 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 393 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 406 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 406 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 419 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 419 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 432 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 432 |
| ShortVariable | Avoid variables with short names like pp | 445 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 445 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 468 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 491 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 521 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 556 |
org/apache/turbine/services/pull/tools/UITool.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 65 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 132 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 160 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 188 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 206 |
| MethodArgumentCouldBeFinal | Parameter 'skin' is not assigned and could be declared final | 206 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 225 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 225 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 243 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 243 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 255 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 274 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 292 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 322 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 322 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 340 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 340 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 352 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 364 |
| LocalVariableCouldBeFinal | Local variable 'pipelineData' could be declared final | 378 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 379 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 379 |
org/apache/turbine/services/pull/util/DateFormatter.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| LongVariable | Avoid excessively long variable names like DATE_FORMAT_DEFAULT | 42 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dateFormat' | 50 |
| MethodArgumentCouldBeFinal | Parameter 'theDate' is not assigned and could be declared final | 90 |
| MethodArgumentCouldBeFinal | Parameter 'theDate' is not assigned and could be declared final | 103 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 103 |
| UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 110 and 115) | 105 |
| LocalVariableCouldBeFinal | Local variable 'sdf' could be declared final | 106 |
org/apache/turbine/services/pull/util/DateTimeFormatterTool.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 54 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 56–218 |
| LongVariable | Avoid excessively long variable names like localizationService | 65 |
| LongVariable | Avoid excessively long variable names like overrideFromRequestLocale | 69 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'overrideFromRequestLocale' | 69 |
| SingularField | Perhaps 'overrideFromRequestLocale' could be replaced by a local variable. | 69 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 93 |
| LocalVariableCouldBeFinal | Local variable 'serviceManager' could be declared final | 99 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 151 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 157 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 157 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 163 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 163 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 163 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 169 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 169 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 169 |
| MethodArgumentCouldBeFinal | Parameter 'zoneId' is not assigned and could be declared final | 170 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 175 |
| LongVariable | Avoid excessively long variable names like outgoingFormatPattern | 175 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormatPattern' is not assigned and could be declared final | 175 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 175 |
| LongVariable | Avoid excessively long variable names like incomingFormatPattern | 175 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormatPattern' is not assigned and could be declared final | 175 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 181 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 181 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 182 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormat' is not assigned and could be declared final | 182 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 188 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 188 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 194 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormat' is not assigned and could be declared final | 194 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 200 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 200 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 200 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 209 |
| LawOfDemeter | Call to `getZoneId` on foreign value `getDtfs()` (degree 1) | 215 |
org/apache/turbine/services/pull/util/SessionData.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 39 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 73 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 84 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 96 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 96 |
org/apache/turbine/services/rundata/DefaultTurbineRunData.java
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 1–1384 |
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 1–1384 |
| GodClass | Possible God Class (WMC=118, ATFD=29, TCC=1.684%) | 80 |
| CyclomaticComplexity | The class 'DefaultTurbineRunData' has a total cyclomatic complexity of 118 (highest 4). | 80 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 80 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 83–1384 |
| TooManyFields | Too many fields | 83–1384 |
| LongVariable | Avoid excessively long variable names like stackTraceException | 144 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 151 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 166 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 171 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 172 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 186 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 192 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 194 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>()` | 207 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 229 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 230 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 231 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 232 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 233 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 235 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 236 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 238 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 241 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 242 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 243 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 244 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 245 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 246 |
| LocalVariableCouldBeFinal | Local variable 'parameters' could be declared final | 263 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 264 |
| LawOfDemeter | Call to `getRequest` on foreign value `parameters` (degree 1) | 266 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 266 |
| LocalVariableCouldBeFinal | Local variable 'cookies' could be declared final | 283 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 284 |
| LawOfDemeter | Call to `getRequest` on foreign value `cookies` (degree 1) | 286 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 286 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 358 |
| MethodArgumentCouldBeFinal | Parameter 'acl' is not assigned and could be declared final | 371 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 385 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 407 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 435 |
| MethodArgumentCouldBeFinal | Parameter 'layout' is not assigned and could be declared final | 453 |
| MethodArgumentCouldBeFinal | Parameter 'layout' is not assigned and could be declared final | 480 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 513 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 539 |
| MethodArgumentCouldBeFinal | Parameter 'encoding' is not assigned and could be declared final | 561 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 593 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 606 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 616 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 628 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 630 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 650 |
| MethodArgumentCouldBeFinal | Parameter 'msgs' is not assigned and could be declared final | 688 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 710 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 723 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 742 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 752 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 852 |
| LocalVariableCouldBeFinal | Local variable 'parameters' could be declared final | 857 |
| LocalVariableCouldBeFinal | Local variable 'cookies' could be declared final | 858 |
| MethodArgumentCouldBeFinal | Parameter 'charSet' is not assigned and could be declared final | 892 |
| MethodArgumentCouldBeFinal | Parameter 'charSet' is not assigned and could be declared final | 926 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 952 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 955 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 959 |
| MethodArgumentCouldBeFinal | Parameter 'contentType' is not assigned and could be declared final | 972 |
| MethodArgumentCouldBeFinal | Parameter 'ruri' is not assigned and could be declared final | 996 |
| MethodArgumentCouldBeFinal | Parameter 'statusCode' is not assigned and could be declared final | 1018 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 1031 |
| MethodArgumentCouldBeFinal | Parameter 'err' is not assigned and could be declared final | 1042 |
| MethodArgumentCouldBeFinal | Parameter 'contexts' is not assigned and could be declared final | 1068 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 1196 |
| MethodArgumentCouldBeFinal | Parameter 'trace' is not assigned and could be declared final | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'exp' is not assigned and could be declared final | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 1260 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 1260 |
| MethodArgumentCouldBeFinal | Parameter 'out' is not assigned and could be declared final | 1318 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 1328 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 1338 |
| MethodArgumentCouldBeFinal | Parameter 'port' is not assigned and could be declared final | 1348 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 1358 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 1368 |
org/apache/turbine/services/rundata/RunDataService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like PARAMETER_PARSER_KEY | 54 |
org/apache/turbine/services/rundata/TurbineRunDataService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like DEFAULT_PARAMETER_PARSER | 70 |
| LongVariable | Avoid excessively long variable names like DEFAULT_COOKIE_PARSER | 74 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pool' | 84 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parserService' | 87 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 92 |
| CognitiveComplexity | The method 'init()' has a cognitive complexity of 18, current threshold is 15 | 103 |
| CyclomaticComplexity | The method 'init()' has a cyclomatic complexity of 11. | 103 |
| UseShortArrayInitializer | Array initialization can be written shorter | 107–112 |
| LocalVariableCouldBeFinal | Local variable 'def' could be declared final | 107 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 116 |
| UseShortArrayInitializer | Array initialization can be written shorter | 121–126 |
| LocalVariableCouldBeFinal | Local variable 'plist' could be declared final | 121 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 127 |
| ShortVariable | Avoid variables with short names like j | 131 |
| LocalVariableCouldBeFinal | Local variable 'plistKey' could be declared final | 132 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 138–142 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 192 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 193 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 194 |
| CyclomaticComplexity | The method 'getRunData(String, HttpServletRequest, HttpServletResponse, ServletConfig)' has a cyclomatic complexity of 12. | 213 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 213 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 214 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 215 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 216 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 218 |
| LocalVariableCouldBeFinal | Local variable 'cfg' could be declared final | 233 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 239 |
| LocalVariableCouldBeFinal | Local variable 'runDataClazz' could be declared final | 242 |
| LongVariable | Avoid excessively long variable names like parameterParserClazz | 243 |
| LocalVariableCouldBeFinal | Local variable 'parameterParserClazz' could be declared final | 243 |
| LocalVariableCouldBeFinal | Local variable 'cookieParserClazz' could be declared final | 244 |
| ShortVariable | Avoid variables with short names like pp | 248 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 248 |
| ShortVariable | Avoid variables with short names like cp | 252 |
| LocalVariableCouldBeFinal | Local variable 'cp' could be declared final | 252 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 296 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 303 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 312 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 312 |
org/apache/turbine/services/schedule/AbstractJobEntry.java
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=54, ATFD=19, TCC=1.732%) | 35 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'jobIsActive' | 41 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'runtime' | 44 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 94 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 95 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 96 |
| ShortVariable | Avoid variables with short names like wd | 97 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 97 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 98 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 99 |
| ShortVariable | Avoid variables with short names like je | 129 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 129 |
| MethodArgumentCouldBeFinal | Parameter 'isActive' is not assigned and could be declared final | 140 |
| LocalVariableCouldBeFinal | Local variable 'schedrun' could be declared final | 210 |
| LocalVariableCouldBeFinal | Local variable 'now' could be declared final | 211 |
| CognitiveComplexity | The method 'evaluateJobType()' has a cognitive complexity of 37, current threshold is 15 | 304 |
| CyclomaticComplexity | The method 'evaluateJobType()' has a cyclomatic complexity of 21. | 304 |
| AvoidDuplicateLiterals | The String literal "Error in JobEntry. Bad Job parameter." appears 5 times in this file; the first occurrence is on line 323 | 323 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 326 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 337 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 349 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 361 |
| ShortVariable | Avoid variables with short names like v | 391 |
| ShortVariable | Avoid variables with short names like v | 405 |
| ShortVariable | Avoid variables with short names like v | 419 |
| ShortVariable | Avoid variables with short names like v | 433 |
| ShortVariable | Avoid variables with short names like v | 447 |
| ShortVariable | Avoid variables with short names like v | 461 |
| ShortVariable | Avoid variables with short names like v | 477 |
org/apache/turbine/services/schedule/AbstractSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 41 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 42–364 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'scheduleQueue' | 47 |
| ImmutableField | Field 'enabled' may be declared final | 50 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 53 |
| LongVariable | Avoid excessively long variable names like houseKeepingThread | 53 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 56 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 71–75 |
| LocalVariableCouldBeFinal | Local variable 'jobs' could be declared final | 78 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 84 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 111 |
| ShortVariable | Avoid variables with short names like wd | 118 |
| ShortVariable | Avoid variables with short names like je | 141 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 141 |
| ShortVariable | Avoid variables with short names like je | 155 |
| ShortVariable | Avoid variables with short names like je | 166 |
| MethodArgumentCouldBeFinal | Parameter 'enabled' is not assigned and could be declared final | 185 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 205 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 215 |
| LocalVariableCouldBeFinal | Local variable 'thread' could be declared final | 218 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 233 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 233 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 241 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 243 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 252 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 262 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 272 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 284 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 288 |
| ShortVariable | Avoid variables with short names like je | 292 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 292 |
| LocalVariableCouldBeFinal | Local variable 'now' could be declared final | 301 |
| LocalVariableCouldBeFinal | Local variable 'when' could be declared final | 302 |
| LawOfDemeter | Call to `getNextRuntime` on foreign value `je` (degree 2) | 302 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 314 |
| EmptyCatchBlock | Avoid empty catch blocks | 319–322 |
| ShortVariable | Avoid variables with short names like je | 340 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 340 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 346 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 346 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 354 |
org/apache/turbine/services/schedule/JobEntry.java
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like v | 74 |
| ShortVariable | Avoid variables with short names like v | 88 |
org/apache/turbine/services/schedule/JobEntryNonPersistent.java
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like wd | 35 |
| AvoidFieldNameMatchingMethodName | Field isnew has the same name as a method | 38 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 79 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 80 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 81 |
| ShortVariable | Avoid variables with short names like wd | 82 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 82 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 83 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 84 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 103 |
| SimplifyBooleanReturns | This if statement can be replaced by `return {condition} && {thenBranch};` | 105–108 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 107 |
| LocalVariableCouldBeFinal | Local variable '_isnew' could be declared final | 119 |
| ShortVariable | Avoid variables with short names like v | 141 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 141 |
| ShortVariable | Avoid variables with short names like v | 163 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 163 |
| ShortVariable | Avoid variables with short names like v | 185 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 185 |
| ShortVariable | Avoid variables with short names like v | 207 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 207 |
| ShortVariable | Avoid variables with short names like v | 229 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 229 |
| ShortVariable | Avoid variables with short names like v | 251 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 251 |
| ShortVariable | Avoid variables with short names like v | 273 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 273 |
org/apache/turbine/services/schedule/JobEntryQuartz.java
| Rule | Violation | Line |
|---|---|---|
| AvoidFieldNameMatchingMethodName | Field isnew has the same name as a method | 47 |
| ImmutableField | Field 'active' may be declared final | 48 |
| LongVariable | Avoid excessively long variable names like DEFAULT_JOB_GROUP_NAME | 53 |
| MethodArgumentCouldBeFinal | Parameter 'jobTrigger' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'jobTrigger' is not assigned and could be declared final | 81 |
| MethodArgumentCouldBeFinal | Parameter 'jobDetail' is not assigned and could be declared final | 81 |
| LocalVariableCouldBeFinal | Local variable '_isnew' could be declared final | 95 |
| ShortVariable | Avoid variables with short names like v | 117 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 117 |
| ShortVariable | Avoid variables with short names like v | 139 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 139 |
| MethodArgumentCouldBeFinal | Parameter 'jobTrigger' is not assigned and could be declared final | 155 |
| ShortVariable | Avoid variables with short names like o | 172 |
| MethodArgumentCouldBeFinal | Parameter 'o' is not assigned and could be declared final | 172 |
| MethodArgumentCouldBeFinal | Parameter 'isActive' is not assigned and could be declared final | 181 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 235 |
| SimplifyBooleanExpressions | Avoid unnecessary comparisons in boolean expressions | 237 |
| LawOfDemeter | Call to `getJobDetail` on foreign value `context` (degree 1) | 248 |
| LawOfDemeter | Call to `getKey` on foreign value `context.getJobDetail()` (degree 2) | 248 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 252 |
org/apache/turbine/services/schedule/JobQueue.java
| Rule | Violation | Line |
|---|---|---|
| LooseCoupling | Avoid using implementation types like 'ConcurrentSkipListSet'; use the interface instead | 41 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'queue' | 41 |
| ImmutableField | Field 'queue' may be declared final | 41 |
| UnusedAssignment | The field initializer for 'queue' is never used (overwritten on line 48) | 41 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ConcurrentSkipListSet<>(...)` | 48 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 70 |
| ShortVariable | Avoid variables with short names like je | 79 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 79 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 83 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 86 |
| LocalVariableCouldBeFinal | Local variable 'jobEntry' could be declared final | 88 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 92 |
| LooseCoupling | Avoid using implementation types like 'Vector'; use the interface instead | 104 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 104 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 106–113 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 108 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 108 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 108 |
| ShortVariable | Avoid variables with short names like je | 121 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 121 |
| MethodArgumentCouldBeFinal | Parameter 'jobEntries' is not assigned and could be declared final | 132 |
| ShortVariable | Avoid variables with short names like je | 145 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 145 |
| ShortVariable | Avoid variables with short names like je | 156 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 156 |
| ShortVariable | Avoid variables with short names like je | 169 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 169 |
org/apache/turbine/services/schedule/QuartzSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 49 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–413 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'enabled' | 57 |
| ShortVariable | Avoid variables with short names like qs | 73 |
| LocalVariableCouldBeFinal | Local variable 'qs' could be declared final | 73 |
| LawOfDemeter | Call to `getScheduler` on foreign value `qs` (degree 1) | 75 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 103 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 103 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 103 |
| ShortVariable | Avoid variables with short names like wd | 103 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 103 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 103 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 103 |
| ShortVariable | Avoid variables with short names like jd | 107 |
| LocalVariableCouldBeFinal | Local variable 'jd' could be declared final | 107 |
| LocalVariableCouldBeFinal | Local variable 'csb' could be declared final | 111 |
| ShortVariable | Avoid variables with short names like t | 113 |
| LocalVariableCouldBeFinal | Local variable 't' could be declared final | 113 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'jeq' | 119 |
| LocalVariableCouldBeFinal | Local variable 'jeq' could be declared final | 119 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 140 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 140 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 140 |
| ShortVariable | Avoid variables with short names like wd | 140 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 140 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 140 |
| ShortVariable | Avoid variables with short names like sb | 142 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 142 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 17 characters appended. | 142 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 143 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 144 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 161 |
| MethodArgumentCouldBeFinal | Parameter 'oid' is not assigned and could be declared final | 175 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 178 |
| ShortVariable | Avoid variables with short names like je | 196 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 196 |
| ShortVariable | Avoid variables with short names like jq | 202 |
| LocalVariableCouldBeFinal | Local variable 'jq' could be declared final | 202 |
| ShortVariable | Avoid variables with short names like je | 218 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 218 |
| ShortVariable | Avoid variables with short names like jq | 223 |
| LocalVariableCouldBeFinal | Local variable 'jq' could be declared final | 223 |
| LawOfDemeter | Call to `getJobTrigger` on foreign value `jq` (degree 1) | 224 |
| ShortVariable | Avoid variables with short names like je | 240 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 240 |
| ShortVariable | Avoid variables with short names like jq | 246 |
| LocalVariableCouldBeFinal | Local variable 'jq' could be declared final | 246 |
| LawOfDemeter | Call to `getJobTrigger` on foreign value `jq` (degree 1) | 247 |
| LocalVariableCouldBeFinal | Local variable 'jobs' could be declared final | 263 |
| LocalVariableCouldBeFinal | Local variable 'groupMatcher' could be declared final | 267 |
| LocalVariableCouldBeFinal | Local variable 'jobKeys' could be declared final | 268 |
| LocalVariableCouldBeFinal | Local variable 'jk' could be declared final | 269 |
| LocalVariableCouldBeFinal | Local variable 'triggers' could be declared final | 271 |
| ShortVariable | Avoid variables with short names like jd | 277 |
| LocalVariableCouldBeFinal | Local variable 'jd' could be declared final | 277 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 278 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 278 |
| MethodArgumentCouldBeFinal | Parameter 'enabled' is not assigned and could be declared final | 298 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 318 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 328 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 348 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 355–362 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 361 |
| ShortVariable | Avoid variables with short names like je | 377 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 377 |
| MethodArgumentCouldBeFinal | Parameter 'trigger' is not assigned and could be declared final | 409 |
| ShortVariable | Avoid variables with short names like jd | 409 |
| MethodArgumentCouldBeFinal | Parameter 'jd' is not assigned and could be declared final | 409 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'job' | 410 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 410 |
org/apache/turbine/services/schedule/ScheduleService.java
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like wd | 84 |
| ShortVariable | Avoid variables with short names like je | 104 |
| ShortVariable | Avoid variables with short names like je | 113 |
| ShortVariable | Avoid variables with short names like je | 122 |
org/apache/turbine/services/schedule/SchedulerTool.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| MethodArgumentCouldBeFinal | Parameter 'jobId' is not assigned and could be declared final | 97 |
| ShortVariable | Avoid variables with short names like je | 99 |
org/apache/turbine/services/schedule/TorqueSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| LocalVariableCouldBeFinal | Local variable 'jobsTorque' could be declared final | 52 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 54 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 71 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 71 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 71 |
| ShortVariable | Avoid variables with short names like wd | 71 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 71 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 71 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 71 |
| LocalVariableCouldBeFinal | Local variable 'jet' could be declared final | 73 |
| MethodArgumentCouldBeFinal | Parameter 'oid' is not assigned and could be declared final | 94 |
| ShortVariable | Avoid variables with short names like je | 98 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 98 |
| ShortVariable | Avoid variables with short names like je | 116 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 116 |
| ShortVariable | Avoid variables with short names like c | 121 |
| LocalVariableCouldBeFinal | Local variable 'c' could be declared final | 121 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 121 |
| ShortVariable | Avoid variables with short names like je | 145 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 145 |
org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 68 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 76 |
| LocalVariableCouldBeFinal | Local variable 'jobProps' could be declared final | 77 |
| LocalVariableCouldBeFinal | Local variable 'jobs' could be declared final | 78 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 84–112 |
| LocalVariableCouldBeFinal | Local variable 'jobName' could be declared final | 86 |
| LocalVariableCouldBeFinal | Local variable 'jobPrefix' could be declared final | 87 |
| LocalVariableCouldBeFinal | Local variable 'jobId' could be declared final | 89 |
| LocalVariableCouldBeFinal | Local variable 'sec' could be declared final | 97 |
| LocalVariableCouldBeFinal | Local variable 'min' could be declared final | 98 |
| ShortVariable | Avoid variables with short names like hr | 99 |
| LocalVariableCouldBeFinal | Local variable 'hr' could be declared final | 99 |
| LocalVariableCouldBeFinal | Local variable 'wkday' could be declared final | 100 |
| LocalVariableCouldBeFinal | Local variable 'dayOfMonth' could be declared final | 101 |
| ShortVariable | Avoid variables with short names like je | 103 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 103 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 122 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 122 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 122 |
| ShortVariable | Avoid variables with short names like wd | 122 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 122 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 122 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 122 |
| MethodArgumentCouldBeFinal | Parameter 'oid' is not assigned and could be declared final | 135 |
| ShortVariable | Avoid variables with short names like je | 138 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 138 |
| ShortVariable | Avoid variables with short names like je | 149 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 149 |
| ShortVariable | Avoid variables with short names like je | 163 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 174 |
org/apache/turbine/services/schedule/WorkerThread.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'je' | 42 |
| ShortVariable | Avoid variables with short names like je | 42 |
| ImmutableField | Field 'je' may be declared final | 42 |
| UnusedAssignment | The field initializer for 'je' is never used (overwritten on line 54) | 42 |
| ShortVariable | Avoid variables with short names like je | 52 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 52 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 77 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 80 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'logStateChange': private methods cannot be overridden | 97 |
| MethodArgumentCouldBeFinal | Parameter 'state' is not assigned and could be declared final | 97 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 100 |
org/apache/turbine/services/security/DefaultSecurityService.java
| Rule | Violation | Line |
|---|---|---|
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 1–1127 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 74 |
| GodClass | Possible God Class (WMC=88, ATFD=18, TCC=11.246%) | 74 |
| CyclomaticComplexity | The class 'DefaultSecurityService' has a total cyclomatic complexity of 88 (highest 4). | 74 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 74 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 77–1127 |
| ImmutableField | Field 'readerCount' may be declared final | 79 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'userManager' | 82 |
| UnusedPrivateField | Avoid unused private fields such as 'backend'. | 96 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'globalGroup' | 101 |
| LocalVariableCouldBeFinal | Local variable 'manager' could be declared final | 117 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 126 |
| LongVariable | Avoid excessively long variable names like userManagerClassName | 128 |
| LocalVariableCouldBeFinal | Local variable 'userManagerClassName' could be declared final | 128 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 139 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 157 |
| LawOfDemeter | Call to `getUserInstance` on foreign value `getUserManager()` (degree 1) | 160 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 180 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 183 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 206 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 211 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 228 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 231 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 236 |
| LocalVariableCouldBeFinal | Local variable 'permission' could be declared final | 253 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 258 |
| MethodArgumentCouldBeFinal | Parameter 'permName' is not assigned and could be declared final | 274 |
| LocalVariableCouldBeFinal | Local variable 'permission' could be declared final | 277 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 282 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 299 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 304 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 321 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 324 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 329 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 358 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 375 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 395 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 395 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 413 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 444 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 459 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 478 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 495 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 495 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 510 |
| AvoidDuplicateLiterals | The String literal "user is null" appears 4 times in this file; the first occurrence is on line 514 | 514 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 533 |
| MethodArgumentCouldBeFinal | Parameter 'oldPassword' is not assigned and could be declared final | 533 |
| MethodArgumentCouldBeFinal | Parameter 'newPassword' is not assigned and could be declared final | 534 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 556 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 556 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 582 |
| EmptyCatchBlock | Avoid empty catch blocks | 600–603 |
| ShortVariable | Avoid variables with short names like g | 646 |
| LocalVariableCouldBeFinal | Local variable 'g' could be declared final | 646 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 660 |
| ShortVariable | Avoid variables with short names like id | 677 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 677 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 680 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 693 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 696 |
| ShortVariable | Avoid variables with short names like id | 714 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 714 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 718 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 718 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 736 |
| ShortVariable | Avoid variables with short names like id | 753 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 753 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 757 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 813 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 835 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 835 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 835 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 856 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 856 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 856 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 878 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 878 |
| MethodArgumentCouldBeFinal | Parameter 'newRole' is not assigned and could be declared final | 878 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 895 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 914 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 914 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 930 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 930 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 947 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 969 |
| MethodArgumentCouldBeFinal | Parameter 'cascadeDelete' is not assigned and could be declared final | 969 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 985 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 1000 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 1015 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 1030 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 1045 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 1059 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 1074 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 1090 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 1090 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 1106 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 1106 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 1122 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 1122 |
org/apache/turbine/services/security/DefaultUserManager.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 76 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 77–537 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'umDelegate' | 79 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'factoryService' | 81 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 98 |
| ShortVariable | Avoid variables with short names like u | 101 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 101 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 113 |
| UseShortArrayInitializer | Array initialization can be written shorter | 117 |
| LocalVariableCouldBeFinal | Local variable 'params' could be declared final | 117 |
| UseShortArrayInitializer | Array initialization can be written shorter | 118 |
| LocalVariableCouldBeFinal | Local variable 'signature' could be declared final | 118 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 119 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 121 |
| MethodArgumentCouldBeFinal | Parameter 'userWrapperClass2' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 154 |
| LocalVariableCouldBeFinal | Local variable 'manager' could be declared final | 156 |
| LocalVariableCouldBeFinal | Local variable 'userWrapperClass' could be declared final | 159 |
| LocalVariableCouldBeFinal | Local variable 'turbineUser' could be declared final | 169 |
| UseShortArrayInitializer | Array initialization can be written shorter | 171 |
| LocalVariableCouldBeFinal | Local variable 'params' could be declared final | 171 |
| UseShortArrayInitializer | Array initialization can be written shorter | 172 |
| LocalVariableCouldBeFinal | Local variable 'signature' could be declared final | 172 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 179 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 196 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 216 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 234 |
| ShortVariable | Avoid variables with short names like u | 237 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 237 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 256 |
| LooseCoupling | Avoid using implementation types like 'UserSet'; use the interface instead | 259 |
| LocalVariableCouldBeFinal | Local variable 'uset' could be declared final | 259 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'userList' | 261 |
| LocalVariableCouldBeFinal | Local variable 'userList' could be declared final | 261 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 287 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 287 |
| ShortVariable | Avoid variables with short names like u | 291 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 291 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 306 |
| AvoidDuplicateLiterals | The String literal "user is null" appears 6 times in this file; the first occurrence is on line 310 | 310 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 316 |
| UnnecessaryCast | Unnecessary cast (TurbineUserDelegate) | 321 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 337 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 358 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 358 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 375 |
| MethodArgumentCouldBeFinal | Parameter 'initialPassword' is not assigned and could be declared final | 375 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 392 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 415 |
| MethodArgumentCouldBeFinal | Parameter 'oldPassword' is not assigned and could be declared final | 415 |
| MethodArgumentCouldBeFinal | Parameter 'newPassword' is not assigned and could be declared final | 416 |
| UnnecessaryCast | Unnecessary cast (TurbineUserDelegate) | 424 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 444 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 444 |
| ShortVariable | Avoid variables with short names like u | 464 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 464 |
| ShortVariable | Avoid variables with short names like u | 478 |
| MethodArgumentCouldBeFinal | Parameter 'u' is not assigned and could be declared final | 478 |
| ShortVariable | Avoid variables with short names like u | 496 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 496 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 514 |
| ShortVariable | Avoid variables with short names like u | 516 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 516 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 530 |
org/apache/turbine/services/security/SecurityService.java
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 64 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 66–757 |
| LongVariable | Avoid excessively long variable names like USER_MANAGER_DEFAULT | 80 |
| LongVariable | Avoid excessively long variable names like USER_WRAPPER_DEFAULT | 93 |
| ShortVariable | Avoid variables with short names like u | 272 |
| LooseCoupling | Avoid using implementation types like 'PermissionSet'; use the interface instead | 396 |
| ShortVariable | Avoid variables with short names like id | 538 |
| ShortVariable | Avoid variables with short names like id | 568 |
| ShortVariable | Avoid variables with short names like id | 598 |
| LooseCoupling | Avoid using implementation types like 'GroupSet'; use the interface instead | 609 |
| LooseCoupling | Avoid using implementation types like 'RoleSet'; use the interface instead | 619 |
| LooseCoupling | Avoid using implementation types like 'PermissionSet'; use the interface instead | 629 |
org/apache/turbine/services/security/UserManager.java
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–301 |
| ShortVariable | Avoid variables with short names like u | 258 |
org/apache/turbine/services/security/passive/PassiveUserManager.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 46 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 47–365 |
| AvoidDuplicateLiterals | The String literal "PassiveUserManager knows no users" appears 10 times in this file; the first occurrence is on line 72 | 72 |
| ShortVariable | Avoid variables with short names like u | 311 |
org/apache/turbine/services/servlet/TurbineServletService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 51 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'servletContext' | 58 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'servletConfig' | 61 |
| LawOfDemeter | Call to `getServletContext` on foreign value `servletConfig` (degree 1) | 74 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 78 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 95 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 99 |
| EmptyCatchBlock | Avoid empty catch blocks | 117–120 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 133 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 137 |
| ShortVariable | Avoid variables with short names like is | 140 |
| UnusedAssignment | The initializer for variable 'is' is never used (overwritten on line 141) | 140 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 154 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 158 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 250 |
org/apache/turbine/services/session/SessionListener.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 61 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 98 |
| LawOfDemeter | Call to `getSession` on foreign value `event` (degree 1) | 101 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 110 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 125 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 137 |
org/apache/turbine/services/session/SessionTool.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| ShortVariable | Avoid variables with short names like o | 48 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 75 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 86 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 102 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 125 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 137 |
org/apache/turbine/services/session/TurbineSessionService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 55 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 80 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 92 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 109 |
| LocalVariableCouldBeFinal | Local variable 'users' could be declared final | 124 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 128 |
| ShortVariable | Avoid variables with short names like u | 130 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 130 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 147 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 154 |
| MethodArgumentCouldBeFinal | Parameter 'sessionId' is not assigned and could be declared final | 169 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 182 |
| LocalVariableCouldBeFinal | Local variable 'sessions' could be declared final | 184 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 185 |
| ShortVariable | Avoid variables with short names like u | 187 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 187 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 217 |
org/apache/turbine/services/template/BaseTemplateEngineService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 38 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 53 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 53 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 53 |
| MethodArgumentCouldBeFinal | Parameter 'defaultExt' is not assigned and could be declared final | 59 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 62 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 70 |
| MethodArgumentCouldBeFinal | Parameter 'defaultExt' is not assigned and could be declared final | 97 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 99 |
| LongVariable | Avoid excessively long variable names like fileExtensionAssociations | 105 |
| LocalVariableCouldBeFinal | Local variable 'copyParams' could be declared final | 124 |
| LocalVariableCouldBeFinal | Local variable 'copyParam' could be declared final | 134 |
org/apache/turbine/services/template/TemplateEngineService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like TEMPLATE_EXTENSIONS | 35 |
| LongVariable | Avoid excessively long variable names like DEFAULT_TEMPLATE_EXTENSION | 37 |
| LongVariable | Avoid excessively long variable names like DEFAULT_NAVIGATION | 45 |
| LongVariable | Avoid excessively long variable names like DEFAULT_ERROR_SCREEN | 47 |
| LongVariable | Avoid excessively long variable names like DEFAULT_LAYOUT_TEMPLATE | 49 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SCREEN_TEMPLATE | 51 |
| LongVariable | Avoid excessively long variable names like DEFAULT_NAVIGATION_TEMPLATE | 53 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 60 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 60 |
org/apache/turbine/services/template/TemplateService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like DEFAULT_TEMPLATE_KEY | 49 |
| LongVariable | Avoid excessively long variable names like DEFAULT_TEMPLATE_VALUE | 52 |
| LongVariable | Avoid excessively long variable names like DEFAULT_EXTENSION_KEY | 55 |
| LongVariable | Avoid excessively long variable names like DEFAULT_EXTENSION_VALUE | 58 |
| LongVariable | Avoid excessively long variable names like EXTENSION_SEPARATOR | 61 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_PARTS_SEPARATOR | 64 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 218 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 229 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 240 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 251 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 262 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 273 |
org/apache/turbine/services/template/TurbineTemplateService.java
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 1–817 |
| GodClass | Possible God Class (WMC=47, ATFD=23, TCC=21.675%) | 181 |
| LongVariable | Avoid excessively long variable names like LAYOUT_TEMPLATE_KEY | 201 |
| LongVariable | Avoid excessively long variable names like LAYOUT_TEMPLATE_NAME | 204 |
| LongVariable | Avoid excessively long variable names like SCREEN_TEMPLATE_KEY | 207 |
| LongVariable | Avoid excessively long variable names like SCREEN_TEMPLATE_NAME | 210 |
| LongVariable | Avoid excessively long variable names like NAVIGATION_TEMPLATE_KEY | 213 |
| LongVariable | Avoid excessively long variable names like NAVIGATION_TEMPLATE_NAME | 216 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'mapperRegistry' | 222 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'useCache' | 235 |
| LongVariable | Avoid excessively long variable names like templateEngineRegistry | 256 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'templateEngineRegistry' | 256 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 261 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 261 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 277 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 295 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 335 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 339 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 342 |
| ShortVariable | Avoid variables with short names like sb | 357 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 357 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 361 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 436 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 450 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 464 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 478 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 492 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 505 |
| ShortVariable | Avoid variables with short names like pp | 507 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 507 |
| LocalVariableCouldBeFinal | Local variable 'template' could be declared final | 508 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 520 |
| ShortVariable | Avoid variables with short names like pp | 522 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 522 |
| LocalVariableCouldBeFinal | Local variable 'template' could be declared final | 523 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 536 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 551 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 566 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 582 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 597 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 613 |
| MethodArgumentCouldBeFinal | Parameter 'templatePaths' is not assigned and could be declared final | 632 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 652 |
| MethodArgumentCouldBeFinal | Parameter 'templatePaths' is not assigned and could be declared final | 652 |
| MethodArgumentCouldBeFinal | Parameter 'service' is not assigned and could be declared final | 666 |
| LocalVariableCouldBeFinal | Local variable 'exts' could be declared final | 668 |
| LocalVariableCouldBeFinal | Local variable 'ext' could be declared final | 670 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 684 |
| MethodArgumentCouldBeFinal | Parameter 'templateKey' is not assigned and could be declared final | 697 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 697 |
| CyclomaticComplexity | The method 'initMapper(Configuration)' has a cyclomatic complexity of 10. | 711 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 711 |
| UseShortArrayInitializer | Array initialization can be written shorter | 720–723 |
| LocalVariableCouldBeFinal | Local variable 'mapperNames' could be declared final | 720 |
| UseShortArrayInitializer | Array initialization can be written shorter | 725–728 |
| LocalVariableCouldBeFinal | Local variable 'mapperKeys' could be declared final | 725 |
| UseShortArrayInitializer | Array initialization can be written shorter | 730–738 |
| LocalVariableCouldBeFinal | Local variable 'mapperClasses' could be declared final | 730 |
| ShortVariable | Avoid variables with short names like ab | 740 |
| LocalVariableCouldBeFinal | Local variable 'ab' could be declared final | 740 |
| LocalVariableCouldBeFinal | Local variable 'mapperCacheSize' could be declared final | 743 |
| LocalVariableCouldBeFinal | Local variable 'mapperLoader' could be declared final | 744 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 753 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 754 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 755 |
| UseShortArrayInitializer | Array initialization can be written shorter | 757–765 |
| LongVariable | Avoid excessively long variable names like mapperDefaultProperty | 757 |
| LocalVariableCouldBeFinal | Local variable 'mapperDefaultProperty' could be declared final | 757 |
| UseShortArrayInitializer | Array initialization can be written shorter | 767 |
| LocalVariableCouldBeFinal | Local variable 'mapperSeparator' could be declared final | 767 |
| UseShortArrayInitializer | Array initialization can be written shorter | 769–773 |
| LocalVariableCouldBeFinal | Local variable 'mapperPrefix' could be declared final | 769 |
| LocalVariableCouldBeFinal | Local variable 'mapperProperty' could be declared final | 777 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 777 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 778 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 779 |
| LocalVariableCouldBeFinal | Local variable 'mapperClass' could be declared final | 782 |
| ShortVariable | Avoid variables with short names like tm | 787 |
| UnusedAssignment | The initializer for variable 'tm' is never used (overwritten on line 792) | 787 |
| LocalVariableCouldBeFinal | Local variable 'factory' could be declared final | 791 |
org/apache/turbine/services/template/mapper/BaseMapper.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'useCache' | 43 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'templateCache' | 49 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 66 |
| MethodArgumentCouldBeFinal | Parameter 'cacheSize' is not assigned and could be declared final | 84 |
| MethodArgumentCouldBeFinal | Parameter 'useCache' is not assigned and could be declared final | 102 |
| MethodArgumentCouldBeFinal | Parameter 'defaultProperty' is not assigned and could be declared final | 120 |
| MethodArgumentCouldBeFinal | Parameter 'separator' is not assigned and could be declared final | 138 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 166 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 170 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 171 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 175 |
| LocalVariableCouldBeFinal | Local variable 'defaultName' could be declared final | 178 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 193 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 197 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 202 |
| LocalVariableCouldBeFinal | Local variable 'res' could be declared final | 205 |
org/apache/turbine/services/template/mapper/BaseTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 48 |
| MethodArgumentCouldBeFinal | Parameter 'prefix' is not assigned and could be declared final | 66 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 83 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 88 |
| LocalVariableCouldBeFinal | Local variable 'resBuf' could be declared final | 93 |
| LongVariable | Avoid excessively long variable names like templateComponents | 95 |
| LocalVariableCouldBeFinal | Local variable 'templateComponents' could be declared final | 95 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 98 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 101 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 105 |
org/apache/turbine/services/template/mapper/ClassMapper.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'loader' | 60 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 70 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 70 |
| MethodArgumentCouldBeFinal | Parameter 'loader' is not assigned and could be declared final | 88 |
| CognitiveComplexity | The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 | 102 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 102 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 107 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 121 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 127 |
| LocalVariableCouldBeFinal | Local variable 'pkg' could be declared final | 131 |
| LocalVariableCouldBeFinal | Local variable 'testName' could be declared final | 132 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 132 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 138 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 151 |
| EmptyCatchBlock | Avoid empty catch blocks | 157–160 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 157 |
org/apache/turbine/services/template/mapper/DirectMapper.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 43 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 57 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 59 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 65 |
org/apache/turbine/services/template/mapper/DirectTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 44 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 58 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 60 |
org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 62 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 62 |
| CognitiveComplexity | The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 | 75 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 75 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 79 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 87 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 93 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 94 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 98 |
| LocalVariableCouldBeFinal | Local variable 'defaultName' could be declared final | 102 |
| LocalVariableCouldBeFinal | Local variable 'templatePackage' could be declared final | 111 |
| LocalVariableCouldBeFinal | Local variable 'testName' could be declared final | 115 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 115 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 119 |
| LocalVariableCouldBeFinal | Local variable 'templatePath' could be declared final | 128 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 128 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 131 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 141 |
org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 58 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 71 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 75 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 83 |
| UnusedAssignment | The updated value of variable 'componentSize' is never used | 84 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 89 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 90 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 94 |
| LocalVariableCouldBeFinal | Local variable 'defaultName' could be declared final | 97 |
| LocalVariableCouldBeFinal | Local variable 'templatePackage' could be declared final | 106 |
| LocalVariableCouldBeFinal | Local variable 'testName' could be declared final | 110 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 110 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 114 |
| LocalVariableCouldBeFinal | Local variable 'templatePath' could be declared final | 123 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 123 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 126 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 136 |
org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 47 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 60 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 62 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 65 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 66 |
| LocalVariableCouldBeFinal | Local variable 'templatePackage' could be declared final | 68 |
| LocalVariableCouldBeFinal | Local variable 'testPath' could be declared final | 71 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 74 |
org/apache/turbine/services/ui/TurbineUIService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 57 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 60–531 |
| LongVariable | Avoid excessively long variable names like SKIN_PROPERTY_DEFAULT | 108 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SKIN_CSS_FILE | 126 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantRelative' | 147 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 152 |
| ImmutableField | Field 'skins' may be declared final | 152 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 169 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 187 |
| LocalVariableCouldBeFinal | Local variable 'skinProperties' could be declared final | 189 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 208 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 208 |
| LocalVariableCouldBeFinal | Local variable 'skinProperties' could be declared final | 210 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 227 |
| LocalVariableCouldBeFinal | Local variable 'skinsDir' could be declared final | 240 |
| LocalVariableCouldBeFinal | Local variable 'directory' could be declared final | 242 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 261 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 263 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 280 |
| LongVariable | Avoid excessively long variable names like defaultSkinProperties | 282 |
| LocalVariableCouldBeFinal | Local variable 'skinProperties' could be declared final | 290 |
| ShortVariable | Avoid variables with short names like sb | 292 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 292 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 293 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 294 |
| ShortVariable | Avoid variables with short names like is | 298 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 304 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 307–322 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 311 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 313–322 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 316 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 321 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 361 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 361 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 361 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 374 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 374 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 393 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 393 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 406 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 425 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 425 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 426 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 439 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 439 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 448 |
| LocalVariableCouldBeFinal | Local variable 'len' could be declared final | 452 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 454 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 477 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 477 |
| MethodArgumentCouldBeFinal | Parameter 'subDir' is not assigned and could be declared final | 478 |
| MethodArgumentCouldBeFinal | Parameter 'resourceName' is not assigned and could be declared final | 478 |
| ShortVariable | Avoid variables with short names like sb | 480 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 480 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 481 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 484 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 486 |
| ShortVariable | Avoid variables with short names like du | 488 |
| LocalVariableCouldBeFinal | Local variable 'du' could be declared final | 488 |
| LocalVariableCouldBeFinal | Local variable 'cfg' could be declared final | 501 |
| LocalVariableCouldBeFinal | Local variable 'pullService' could be declared final | 504 |
| ShortVariable | Avoid variables with short names like sb | 507 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 507 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 508 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 509 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 509 |
org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 44 |
| ShortVariable | Avoid variables with short names like md | 79 |
| LocalVariableCouldBeFinal | Local variable 'md' could be declared final | 79 |
| LocalVariableCouldBeFinal | Local variable 'bytesId' could be declared final | 80 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 88 |
| LocalVariableCouldBeFinal | Local variable 'current' could be declared final | 130 |
| ShortVariable | Avoid variables with short names like id | 131 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 135 |
| UseUnderscoresInNumericLiterals | Number 100000000 should separate every third digit with an underscore | 135 |
org/apache/turbine/services/urlmapper/MappedTemplateLink.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 50 |
org/apache/turbine/services/urlmapper/TurbineURLMapperService.java
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 1–325 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 72 |
| LongVariable | Avoid excessively long variable names like DEFAULT_CONFIGURATION_FILE | 84 |
| LongVariable | Avoid excessively long variable names like CONFIGURATION_FILE_KEY | 89 |
| LongVariable | Avoid excessively long variable names like NAMED_GROUPS_PATTERN | 99 |
| LongVariable | Avoid excessively long variable names like MULTI_SLASH_PATTERN | 104 |
| LongVariable | Avoid excessively long variable names like CONTEXT_PATH_PARAMETER | 109 |
| LongVariable | Avoid excessively long variable names like WEBAPP_ROOT_PARAMETER | 114 |
| LongVariable | Avoid excessively long variable names like DEFAULT_PARAMETERS | 119 |
| CognitiveComplexity | The method 'mapToURL(TurbineURI)' has a cognitive complexity of 20, current threshold is 15 | 131 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 131 |
| LocalVariableCouldBeFinal | Local variable 'pathInfo' could be declared final | 138 |
| LocalVariableCouldBeFinal | Local variable 'queryData' could be declared final | 139 |
| LocalVariableCouldBeFinal | Local variable 'uriParameterMap' could be declared final | 143 |
| LocalVariableCouldBeFinal | Local variable 'urlMap' could be declared final | 151 |
| LocalVariableCouldBeFinal | Local variable 'keys' could be declared final | 153 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 153 |
| LocalVariableCouldBeFinal | Local variable 'entryKeys' could be declared final | 156 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 156 |
| LocalVariableCouldBeFinal | Local variable 'implicitKeysFound' could be declared final | 158 |
| LocalVariableCouldBeFinal | Local variable 'matcher' could be declared final | 167 |
| LawOfDemeter | Call to `getUrlPattern` on foreign value `urlMap` (degree 1) | 167 |
| ShortVariable | Avoid variables with short names like sb | 168 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 168 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 168 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 172 |
| LocalVariableCouldBeFinal | Local variable 'ignore' could be declared final | 183 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 187 |
| ShortVariable | Avoid variables with short names like pp | 218 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 218 |
| LocalVariableCouldBeFinal | Local variable 'urlMap' could be declared final | 220 |
| LocalVariableCouldBeFinal | Local variable 'matcher' could be declared final | 223 |
| LawOfDemeter | Call to `getUrlPattern` on foreign value `urlMap` (degree 1) | 223 |
| LawOfDemeter | Call to `matcher` on foreign value `urlMap.getUrlPattern()` (degree 2) | 223 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 231 |
| LocalVariableCouldBeFinal | Local variable 'cfg' could be declared final | 260 |
| LocalVariableCouldBeFinal | Local variable 'servletService' could be declared final | 271 |
| LocalVariableCouldBeFinal | Local variable 'jaxb' could be declared final | 277 |
| LocalVariableCouldBeFinal | Local variable 'unmarshaller' could be declared final | 278 |
| LocalVariableCouldBeFinal | Local variable 'mapper' could be declared final | 284 |
| LocalVariableCouldBeFinal | Local variable 'mapper' could be declared final | 288 |
| LocalVariableCouldBeFinal | Local variable 'urlMap' could be declared final | 298 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 301 |
| LocalVariableCouldBeFinal | Local variable 'groupNamesMap' could be declared final | 301 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 301 |
| LocalVariableCouldBeFinal | Local variable 'matcher' could be declared final | 302 |
| LawOfDemeter | Call to `getUrlPattern` on foreign value `urlMap` (degree 1) | 302 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 306 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 311 |
org/apache/turbine/services/urlmapper/URLMapperService.java
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like pp | 57 |
org/apache/turbine/services/urlmapper/URLMapperValve.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 50 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 50 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 53 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 53 |
| LocalVariableCouldBeFinal | Local variable 'uri' could be declared final | 54 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 54 |
org/apache/turbine/services/urlmapper/model/URLMapEntry.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 44 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 47 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 48 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 49 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'relevantKeys' | 52 |
| MethodArgumentCouldBeFinal | Parameter 'urlPattern' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'implicit' is not assigned and could be declared final | 87 |
| MethodArgumentCouldBeFinal | Parameter 'ignore' is not assigned and could be declared final | 106 |
| MethodArgumentCouldBeFinal | Parameter 'override' is not assigned and could be declared final | 125 |
| MethodArgumentCouldBeFinal | Parameter 'groupNamesMap' is not assigned and could be declared final | 145 |
| MethodArgumentCouldBeFinal | Parameter 'relevantKeys' is not assigned and could be declared final | 165 |
org/apache/turbine/services/urlmapper/model/URLMappingContainer.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 43 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 64 |
| MethodArgumentCouldBeFinal | Parameter 'newURLMapEntries' is not assigned and could be declared final | 94 |
org/apache/turbine/services/urlmapper/model/XmlParameterAdapter.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 35 |
| MethodArgumentCouldBeFinal | Parameter 'xmlList' is not assigned and could be declared final | 41 |
| MethodArgumentCouldBeFinal | Parameter 'map' is not assigned and could be declared final | 53 |
| LocalVariableCouldBeFinal | Local variable 'xmlList' could be declared final | 55 |
org/apache/turbine/services/urlmapper/model/XmlParameterList.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 55 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 79 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 79 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 86 |
| MethodArgumentCouldBeFinal | Parameter 'xmlParameters' is not assigned and could be declared final | 104 |
org/apache/turbine/services/urlmapper/model/XmlPatternAdapter.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 31 |
| MethodArgumentCouldBeFinal | Parameter 'urlPattern' is not assigned and could be declared final | 37 |
| MethodArgumentCouldBeFinal | Parameter 'pattern' is not assigned and could be declared final | 46 |
org/apache/turbine/services/velocity/TurbineVelocityService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 80 |
| GodClass | Possible God Class (WMC=52, ATFD=17, TCC=15.833%) | 80 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 84–615 |
| LongVariable | Avoid excessively long variable names like RESOURCE_LOADER_PATH | 86 |
| LongVariable | Avoid excessively long variable names like defaultInputEncoding | 98 |
| LongVariable | Avoid excessively long variable names like defaultOutputEncoding | 101 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pullModelActive' | 104 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'velocity' | 110 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pullService' | 113 |
| LocalVariableCouldBeFinal | Local variable 'inputEncoding' could be declared final | 146 |
| LongVariable | Avoid excessively long variable names like outputEncodingString | 149 |
| LocalVariableCouldBeFinal | Local variable 'outputEncodingString' could be declared final | 149 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 167 |
| LocalVariableCouldBeFinal | Local variable 'globalContext' could be declared final | 182 |
| LawOfDemeter | Call to `getGlobalContext` on foreign value `pullService` (degree 1) | 183 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'ctx' | 185 |
| LocalVariableCouldBeFinal | Local variable 'ctx' could be declared final | 185 |
| LocalVariableCouldBeFinal | Local variable 'ctx' could be declared final | 197 |
| ShortVariable | Avoid variables with short names like ec | 201 |
| LocalVariableCouldBeFinal | Local variable 'ec' could be declared final | 201 |
| MethodArgumentCouldBeFinal | Parameter 'clazz' is not assigned and could be declared final | 222 |
| MethodArgumentCouldBeFinal | Parameter 'method' is not assigned and could be declared final | 222 |
| ShortVariable | Avoid variables with short names like e | 222 |
| MethodArgumentCouldBeFinal | Parameter 'e' is not assigned and could be declared final | 222 |
| MethodArgumentCouldBeFinal | Parameter 'info' is not assigned and could be declared final | 222 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 246 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 249 |
| LawOfDemeter | Call to `getTemplateContext` on foreign value `data.getTemplateInfo()` (degree 2) | 253 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 253 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 271 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 289 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 289 |
| CloseResource | Ensure that resources like this OutputStreamWriter object are closed after use | 293 |
| UnusedAssignment | The initializer for variable 'writer' is never used (overwritten on line 298) | 293 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 294 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 304 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 325 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 325 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 326 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 329 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 335 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 354 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 354 |
| MethodArgumentCouldBeFinal | Parameter 'writer' is not assigned and could be declared final | 354 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 361 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 374 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 394 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 394 |
| MethodArgumentCouldBeFinal | Parameter 'writer' is not assigned and could be declared final | 395 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 396 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 414 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 418 |
| SimplifyConditional | No need to check for null before an instanceof | 419 |
| LawOfDemeter | Call to `getCharset` on foreign value `(RunData) data` (degree 1) | 421 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 433 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 437 |
| SimplifyConditional | No need to check for null before an instanceof | 438 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'renderingError': private methods cannot be overridden | 455 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 455 |
| ShortVariable | Avoid variables with short names like e | 455 |
| MethodArgumentCouldBeFinal | Parameter 'e' is not assigned and could be declared final | 455 |
| LocalVariableCouldBeFinal | Local variable 'err' could be declared final | 458 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 471 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 474 |
| LocalVariableCouldBeFinal | Local variable 'velocity' could be declared final | 481 |
| CognitiveComplexity | The method 'setVelocityProperties(VelocityEngine, Configuration)' has a cognitive complexity of 29, current threshold is 15 | 500 |
| CyclomaticComplexity | The method 'setVelocityProperties(VelocityEngine, Configuration)' has a cyclomatic complexity of 12. | 500 |
| MethodArgumentCouldBeFinal | Parameter 'velocity' is not assigned and could be declared final | 500 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 500 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 501 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 507 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 509 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 512 |
| LocalVariableCouldBeFinal | Local variable 'name2' could be declared final | 515 |
| LocalVariableCouldBeFinal | Local variable 'paths' could be declared final | 528 |
| LocalVariableCouldBeFinal | Local variable 'p' could be declared final | 543 |
| LocalVariableCouldBeFinal | Local variable 'jarSepIndex' could be declared final | 554 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 596 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 608 |
org/apache/turbine/services/velocity/VelocityService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like VELOCITY_EXTENSION | 52 |
| LongVariable | Avoid excessively long variable names like CATCH_ERRORS_DEFAULT | 64 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 76 |
org/apache/turbine/util/BrowserDetector.java
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'BrowserDetector' is suspected to be a Data Class (WOC=20.000%, NOPA=0, NOAM=4, WMC=9) | 41 |
| MethodArgumentCouldBeFinal | Parameter 'userAgentString' is not assigned and could be declared final | 78 |
| LocalVariableCouldBeFinal | Local variable 'userAgent' could be declared final | 81 |
| LocalVariableCouldBeFinal | Local variable 'version' could be declared final | 85 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 97 |
| MethodArgumentCouldBeFinal | Parameter 'userAgentString' is not assigned and could be declared final | 157 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'toFloat': private methods cannot be overridden | 168 |
| ShortVariable | Avoid variables with short names like s | 168 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 168 |
org/apache/turbine/util/FormMessage.java
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'FormMessage' is suspected to be a Data Class (WOC=28.571%, NOPA=0, NOAM=5, WMC=12) | 33 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 52 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 64 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 65 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 78 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 79 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 80 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 113 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 121 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 131 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 141 |
| ShortVariable | Avoid variables with short names like sb | 153 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 153 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 153 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 155 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 157 |
org/apache/turbine/util/FormMessages.java
| Rule | Violation | Line |
|---|---|---|
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 36 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 36 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 38 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 38 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 40 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 40 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 42 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 42 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 49 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 50 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 51 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 52 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 62 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 62 |
| MethodArgumentCouldBeFinal | Parameter 'returnCode' is not assigned and could be declared final | 62 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 74 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 74 |
| MethodArgumentCouldBeFinal | Parameter 'messageName' is not assigned and could be declared final | 74 |
| LocalVariableCouldBeFinal | Local variable 'formFieldName' could be declared final | 76 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 90 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 90 |
| MethodArgumentCouldBeFinal | Parameter 'table' is not assigned and could be declared final | 90 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 90 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 90 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 92 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 94–107 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getValues': private methods cannot be overridden | 117 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 117 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 117 |
| MethodArgumentCouldBeFinal | Parameter 'table' is not assigned and could be declared final | 117 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 117 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 128 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 135 |
| LocalVariableCouldBeFinal | Local variable 'field' could be declared final | 142 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 151 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 163 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 163 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 165 |
| LocalVariableCouldBeFinal | Local variable 'messages' could be declared final | 167 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 172 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 179 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 191 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 191 |
| LocalVariableCouldBeFinal | Local variable 'fields' could be declared final | 193 |
| LocalVariableCouldBeFinal | Local variable 'field' could be declared final | 194 |
| StringToString | Avoid calling toString() on String objects; this is unnecessary. | 196 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 198 |
org/apache/turbine/util/GenerateUniqueId.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 40 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'session_count' | 50 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'lastTimeVal' | 51 |
| UseUnderscoresInNumericLiterals | Number 2176782336L should separate every third digit with an underscore | 61 |
| LongVariable | Avoid excessively long variable names like maxSessionLifespanTics | 69 |
| UseUnderscoresInNumericLiterals | Number 46656 should separate every third digit with an underscore | 69 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 85 |
| LocalVariableCouldBeFinal | Local variable 'sessionId' could be declared final | 87 |
| ShortVariable | Avoid variables with short names like n | 90 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 138 |
| MethodArgumentCouldBeFinal | Parameter 'jsIdent' is not assigned and could be declared final | 138 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 142 |
org/apache/turbine/util/HttpUtils.java
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 41 |
| LongVariable | Avoid excessively long variable names like CHARACTERS_NOT_ALLOWED_IN_KEY | 47 |
| MethodArgumentCouldBeFinal | Parameter 'date' is not assigned and could be declared final | 65 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 79 |
| MethodArgumentCouldBeFinal | Parameter 'expiry' is not assigned and could be declared final | 79 |
| LocalVariableCouldBeFinal | Local variable 'response' could be declared final | 81 |
| MethodArgumentCouldBeFinal | Parameter 'parameter' is not assigned and could be declared final | 102 |
| LocalVariableCouldBeFinal | Local variable 'testMatcher' could be declared final | 103 |
| MethodArgumentCouldBeFinal | Parameter 'parameter' is not assigned and could be declared final | 113 |
org/apache/turbine/util/InputFilterUtils.java
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 35 |
| ShortVariable | Avoid variables with short names like s | 45 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 45 |
| ShortVariable | Avoid variables with short names like s | 58 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 58 |
org/apache/turbine/util/LocaleUtils.java
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 61 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'defaultLocale' | 67 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'defaultCharSet' | 70 |
| LocalVariableCouldBeFinal | Local variable 'inputEncoding' could be declared final | 80 |
| NonThreadSafeSingleton | Singleton is not thread safe | 100–113 |
| LocalVariableCouldBeFinal | Local variable 'lang' could be declared final | 103 |
| LocalVariableCouldBeFinal | Local variable 'country' could be declared final | 107 |
| CognitiveComplexity | The method 'getDefaultCharset()' has a cognitive complexity of 15, current threshold is 15 | 136 |
| NonThreadSafeSingleton | Singleton is not thread safe | 138–150 |
| LocalVariableCouldBeFinal | Local variable 'charSet' could be declared final | 141 |
| LocalVariableCouldBeFinal | Local variable 'locale' could be declared final | 158 |
| LocalVariableCouldBeFinal | Local variable 'serviceManager' could be declared final | 164 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 165–178 |
| LocalVariableCouldBeFinal | Local variable 'mimeTypeService' could be declared final | 169 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 172 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 215 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 220 |
| MethodArgumentCouldBeFinal | Parameter 'charSet' is not assigned and could be declared final | 234 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 238 |
org/apache/turbine/util/ObjectUtils.java
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 45 |
| MethodArgumentCouldBeFinal | Parameter 'map' is not assigned and could be declared final | 58 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 59 |
| UnusedAssignment | The initializer for variable 'byteArray' is never used (overwritten on line 81) | 61 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 62 |
| LocalVariableCouldBeFinal | Local variable 'mapCopy' could be declared final | 62 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 65 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 67 |
| MethodArgumentCouldBeFinal | Parameter 'objectData' is not assigned and could be declared final | 96 |
| ShortVariable | Avoid variables with short names like in | 105 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 117 |
org/apache/turbine/util/RunData.java
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 58 |
| ShortVariable | Avoid variables with short names like ct | 464 |
| ShortVariable | Avoid variables with short names like sc | 494 |
org/apache/turbine/util/SecurityCheck.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'data' | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'securityService' | 57 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 72 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 73 |
| MethodArgumentCouldBeFinal | Parameter 'failedScreen' is not assigned and could be declared final | 74 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 91 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 91 |
| MethodArgumentCouldBeFinal | Parameter 'failedScreen' is not assigned and could be declared final | 91 |
| MethodArgumentCouldBeFinal | Parameter 'initialize' is not assigned and could be declared final | 91 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 109 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 110 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 113 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 113 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 136 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 136 |
| UnusedAssignment | The initializer for variable 'roleObject' is never used (overwritten on lines 142 and 148) | 138 |
| LawOfDemeter | Call to `getRoleByName` on foreign value `securityService.getRoleManager()` (degree 2) | 142 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 142 |
| LawOfDemeter | Call to `getRoleInstance` on foreign value `securityService.getRoleManager()` (degree 2) | 148 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 148 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 149 |
| PrematureDeclaration | Declaration of 'modelManager' can be moved closer to its usages | 150 |
| LocalVariableCouldBeFinal | Local variable 'modelManager' could be declared final | 150 |
| LawOfDemeter | Call to `getModelManager` on foreign value `securityService` (degree 1) | 150 |
| PreserveStackTrace | Thrown exception does not preserve the stack trace of exception 'e' on all code paths | 152 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 154 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 172 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 173 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 176 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 176 |
| CognitiveComplexity | The method 'hasPermission(String)' has a cognitive complexity of 17, current threshold is 15 | 204 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 204 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 205 |
| UnusedAssignment | The initializer for variable 'permissionObject' is never used (overwritten on lines 210 and 216) | 207 |
| LawOfDemeter | Call to `getPermissionByName` on foreign value `securityService.getPermissionManager()` (degree 2) | 210 |
| LawOfDemeter | Call to `getPermissionManager` on foreign value `securityService` (degree 1) | 210 |
| LawOfDemeter | Call to `getPermissionInstance` on foreign value `securityService.getPermissionManager()` (degree 2) | 216 |
| LawOfDemeter | Call to `getPermissionManager` on foreign value `securityService` (degree 1) | 216 |
| LawOfDemeter | Call to `getPermissionManager` on foreign value `securityService` (degree 1) | 217 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 220 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 220 |
| LooseCoupling | Avoid using implementation types like 'RoleSet'; use the interface instead | 221 |
| LawOfDemeter | Call to `getRoles` on foreign value `acl` (degree 2) | 221 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 222 |
| LawOfDemeter | Call to `toArray` on foreign value `roles` (degree 2) | 224 |
| LawOfDemeter | Call to `getAllRoles` on foreign value `securityService.getRoleManager()` (degree 2) | 233 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 233 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 234 |
| LawOfDemeter | Call to `toArray` on foreign value `roles` (degree 2) | 236 |
| LocalVariableCouldBeFinal | Local variable 'modelManager' could be declared final | 246 |
| LawOfDemeter | Call to `getModelManager` on foreign value `securityService` (degree 1) | 246 |
org/apache/turbine/util/ServerData.java
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'ServerData' is suspected to be a Data Class (WOC=23.077%, NOPA=0, NOAM=10, WMC=22) | 42 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverName' | 45 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverPort' | 48 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverScheme' | 51 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'scriptName' | 54 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'contextPath' | 57 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 71 |
| MethodArgumentCouldBeFinal | Parameter 'serverPort' is not assigned and could be declared final | 72 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 73 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 74 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 75 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 80 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 98 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 115 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 130 |
| CloneMethodMustImplementCloneable | clone() method should be implemented only if implementing Cloneable interface | 130 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 151 |
| MethodArgumentCouldBeFinal | Parameter 'serverPort' is not assigned and could be declared final | 172 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 174 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 193 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 214 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 235 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHostUrl' should not return void linguistically | 246 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 246 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 248 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 249 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 251 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 254 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 258 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 258 |
| LocalVariableCouldBeFinal | Local variable 'url' could be declared final | 271 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 275 |
org/apache/turbine/util/ServletUtils.java
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 42 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 54 |
| MethodArgumentCouldBeFinal | Parameter 'text' is not assigned and could be declared final | 55 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 59 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 64 |
| ShortVariable | Avoid variables with short names like sb | 72 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 72 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 73 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 82 |
| LawOfDemeter | Call to `getServletContext` on foreign value `config` (degree 1) | 82 |
| LocalVariableCouldBeFinal | Local variable 'base' could be declared final | 83 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 88 |
| LocalVariableCouldBeFinal | Local variable 'tokenizer' could be declared final | 91 |
| LocalVariableCouldBeFinal | Local variable 'buffer' could be declared final | 92 |
org/apache/turbine/util/SystemError.java
| Rule | Violation | Line |
|---|---|---|
| DoNotExtendJavaLangError | Exceptions should not extend java.lang.Error | 33 |
| MethodArgumentCouldBeFinal | Parameter 'cause' is not assigned and could be declared final | 43 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 53 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 64 |
| MethodArgumentCouldBeFinal | Parameter 'cause' is not assigned and could be declared final | 64 |
org/apache/turbine/util/TurbineConfig.java
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 1–926 |
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 1–926 |
| CyclomaticComplexity | The class 'TurbineConfig' has a total cyclomatic complexity of 108 (highest 4). | 98 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 98 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 100–926 |
| LongVariable | Avoid excessively long variable names like CONFIGURATION_PATH_KEY | 109 |
| LongVariable | Avoid excessively long variable names like PROPERTIES_PATH_KEY | 115 |
| LongVariable | Avoid excessively long variable names like PROPERTIES_PATH_DEFAULT | 121 |
| AvoidFieldNameMatchingMethodName | Field log has the same name as a method | 137 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 153 |
| MethodArgumentCouldBeFinal | Parameter 'attributes' is not assigned and could be declared final | 153 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 154 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 174 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 174 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 190 |
| MethodArgumentCouldBeFinal | Parameter 'properties' is not assigned and could be declared final | 190 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>(1)` | 192 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 208 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 218 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 269 |
| ShortVariable | Avoid variables with short names like f | 272 |
| LocalVariableCouldBeFinal | Local variable 'f' could be declared final | 272 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 299 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 312 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 312 |
| ShortVariable | Avoid variables with short names like s | 364 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 364 |
| ShortVariable | Avoid variables with short names like s | 378 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 378 |
| LocalVariableCouldBeFinal | Local variable 'fis' could be declared final | 382 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 383 |
| ShortVariable | Avoid variables with short names like m | 397 |
| MethodArgumentCouldBeFinal | Parameter 'm' is not assigned and could be declared final | 397 |
| ShortVariable | Avoid variables with short names like m | 409 |
| MethodArgumentCouldBeFinal | Parameter 'm' is not assigned and could be declared final | 409 |
| ShortVariable | Avoid variables with short names like t | 409 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 409 |
| ShortVariable | Avoid variables with short names like s | 419 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 419 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 431 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 431 |
| ShortVariable | Avoid variables with short names like s | 444 |
| ShortVariable | Avoid variables with short names like s | 470 |
| ShortVariable | Avoid variables with short names like s | 496 |
| ShortVariable | Avoid variables with short names like s | 509 |
| ShortVariable | Avoid variables with short names like s | 521 |
| ShortVariable | Avoid variables with short names like s | 545 |
| ShortVariable | Avoid variables with short names like s | 557 |
| ShortVariable | Avoid variables with short names like o | 557 |
| LongVariable | Avoid excessively long variable names like sessionTrackingModes | 761 |
| ShortVariable | Avoid variables with short names like t | 809 |
org/apache/turbine/util/TurbineException.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 112 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 124 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 137 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 137 |
org/apache/turbine/util/TurbineRuntimeException.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 55 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 67 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 80 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 80 |
org/apache/turbine/util/TurbineXmlConfig.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 76 |
| MethodArgumentCouldBeFinal | Parameter 'attributes' is not assigned and could be declared final | 76 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 77 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 95 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 95 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>(0)` | 97 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 109 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 109 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>(1)` | 111 |
org/apache/turbine/util/template/HtmlPageAttributes.java
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 105–690 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 110 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 125 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'doctype' | 128 |
| LongVariable | Avoid excessively long variable names like defaultHtmlDoctypeRootElement | 131 |
| ImmutableField | Field 'defaultHtmlDoctypeRootElement' may be declared final | 131 |
| LongVariable | Avoid excessively long variable names like defaultHtmlDoctypeIdentifier | 134 |
| LongVariable | Avoid excessively long variable names like defaultHtmlDoctypeUri | 137 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 156 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTitle' should not return any type except void linguistically | 183 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 183 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 200 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 212 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 212 |
| MethodArgumentCouldBeFinal | Parameter 'scriptURL' is not assigned and could be declared final | 234 |
| MethodArgumentCouldBeFinal | Parameter 'styleSheetURL' is not assigned and could be declared final | 257 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 272 |
| MethodArgumentCouldBeFinal | Parameter 'styleSheetURL' is not assigned and could be declared final | 272 |
| MethodArgumentCouldBeFinal | Parameter 'media' is not assigned and could be declared final | 273 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 273 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 273 |
| ShortVariable | Avoid variables with short names like ss | 275 |
| LocalVariableCouldBeFinal | Local variable 'ss' could be declared final | 275 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 290 |
| MethodArgumentCouldBeFinal | Parameter 'linkURL' is not assigned and could be declared final | 290 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 303 |
| MethodArgumentCouldBeFinal | Parameter 'linkURL' is not assigned and could be declared final | 303 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 303 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 317 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 317 |
| MethodArgumentCouldBeFinal | Parameter 'linkURL' is not assigned and could be declared final | 317 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 317 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 318 |
| ShortVariable | Avoid variables with short names like ss | 320 |
| LocalVariableCouldBeFinal | Local variable 'ss' could be declared final | 320 |
| MethodArgumentCouldBeFinal | Parameter 'styleText' is not assigned and could be declared final | 343 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKeywords' should not return any type except void linguistically | 365 |
| MethodArgumentCouldBeFinal | Parameter 'keywords' is not assigned and could be declared final | 365 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setHttpEquiv' should not return any type except void linguistically | 380 |
| MethodArgumentCouldBeFinal | Parameter 'httpEquiv' is not assigned and could be declared final | 380 |
| MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 380 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setDescription' should not return any type except void linguistically | 392 |
| MethodArgumentCouldBeFinal | Parameter 'description' is not assigned and could be declared final | 392 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setBackground' should not return any type except void linguistically | 404 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 404 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setBgColor' should not return any type except void linguistically | 418 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 418 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTextColor' should not return any type except void linguistically | 431 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 431 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setLinkColor' should not return any type except void linguistically | 444 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 444 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setVlinkColor' should not return any type except void linguistically | 456 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 456 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setAlinkColor' should not return any type except void linguistically | 468 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 468 |
| DataClass | The class 'LinkTag' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=10, WMC=15) | 508 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 523 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 523 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 544 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 562 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 582 |
| MethodArgumentCouldBeFinal | Parameter 'media' is not assigned and could be declared final | 602 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 622 |
| LocalVariableCouldBeFinal | Local variable 'tag' could be declared final | 643 |
| MethodArgumentCouldBeFinal | Parameter 'tag' is not assigned and could be declared final | 666 |
| MethodArgumentCouldBeFinal | Parameter 'identifier' is not assigned and could be declared final | 666 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 666 |
| LocalVariableCouldBeFinal | Local variable 'doctypeBuf' could be declared final | 668 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 673 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 674 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 675 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 676 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 681 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 682 |
org/apache/turbine/util/template/TemplateInfo.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like NAVIGATION_TEMPLATE | 47 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'data' | 54 |
| ImmutableField | Field 'data' may be declared final | 54 |
| UnusedAssignment | The field initializer for 'data' is never used (overwritten on line 66) | 54 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'tempStorage' | 57 |
| ImmutableField | Field 'tempStorage' may be declared final | 57 |
| UnusedAssignment | The field initializer for 'tempStorage' is never used (overwritten on line 67) | 57 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 64 |
| ShortVariable | Avoid variables with short names like v | 85 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 85 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 98 |
| ShortVariable | Avoid variables with short names like v | 107 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 107 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 109 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 117 |
| EmptyCatchBlock | Avoid empty catch blocks | 120–125 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 120 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'value' | 135 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 135 |
| ShortVariable | Avoid variables with short names like v | 144 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 144 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 156 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 167 |
| ShortVariable | Avoid variables with short names like v | 167 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 167 |
| ShortVariable | Avoid variables with short names like v | 187 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 187 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 198 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 210 |
| MethodArgumentCouldBeFinal | Parameter 'def' is not assigned and could be declared final | 210 |
| LocalVariableCouldBeFinal | Local variable 'val' could be declared final | 214 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 215 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 217 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 229 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 229 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 240 |
| LocalVariableCouldBeFinal | Local variable 'object' could be declared final | 243 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 257 |
| LocalVariableCouldBeFinal | Local variable 'object' could be declared final | 260 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 275 |
org/apache/turbine/util/template/TemplateNavigation.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'template' | 55 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 62 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically | 74 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 74 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `pipelineData.getRunData()` (degree 1) | 100 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 101 |
| ExceptionAsFlowControl | Exception thrown at line 108 is caught in this block. | 113–121 |
| ExceptionAsFlowControl | Exception thrown at line 97 is caught in this block. | 113–121 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 113 |
org/apache/turbine/util/template/TemplateScreen.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 65 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically | 77 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 77 |
| LocalVariableCouldBeFinal | Local variable 'results' could be declared final | 95 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 102 |
org/apache/turbine/util/template/TemplateSecurityCheck.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 79 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 82 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 94 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 95 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 99 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 102 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 102 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 106 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 108 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 121 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 122 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 125 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 125 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 129 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 144 |
| LocalVariableCouldBeFinal | Local variable 'userManager' could be declared final | 149 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 155 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 160 |
| ShortVariable | Avoid variables with short names like v | 173 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 173 |
| ShortVariable | Avoid variables with short names like v | 204 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 204 |
| ShortVariable | Avoid variables with short names like v | 224 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 224 |
org/apache/turbine/util/uri/BaseURI.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'redirect' | 58 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'response' | 61 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'reference' | 64 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 90 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 102 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 102 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 114 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 126 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 126 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 148 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 164 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 181 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 213 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 234 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 255 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 272 |
| MethodArgumentCouldBeFinal | Parameter 'serverPort' is not assigned and could be declared final | 289 |
| MethodArgumentCouldBeFinal | Parameter 'port' is not assigned and could be declared final | 311 |
| LocalVariableCouldBeFinal | Local variable 'useSSL' could be declared final | 313 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 327 |
| LocalVariableCouldBeFinal | Local variable 'serverScheme' could be declared final | 342 |
| MethodArgumentCouldBeFinal | Parameter 'reference' is not assigned and could be declared final | 352 |
| MethodArgumentCouldBeFinal | Parameter 'response' is not assigned and could be declared final | 393 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getContextAndScript' should not return void linguistically | 421 |
| ShortVariable | Avoid variables with short names like sb | 421 |
| MethodArgumentCouldBeFinal | Parameter 'sb' is not assigned and could be declared final | 421 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 423 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 427 |
| LocalVariableCouldBeFinal | Local variable 'script' could be declared final | 435 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 439 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSchemeAndPort' should not return void linguistically | 459 |
| ShortVariable | Avoid variables with short names like sb | 459 |
| MethodArgumentCouldBeFinal | Parameter 'sb' is not assigned and could be declared final | 459 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 462 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 463 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 467 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 469 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 472 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 486 |
| LocalVariableCouldBeFinal | Local variable 'response' could be declared final | 490 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 510 |
org/apache/turbine/util/uri/DataURI.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 57 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 68 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 78 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 89 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 89 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 126 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 133 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 164 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 170 |
org/apache/turbine/util/uri/TemplateURI.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 59 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 70 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 70 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 81 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 81 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 94 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 94 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 94 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 107 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 107 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 107 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 121 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 121 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 121 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 121 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 132 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 154 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 154 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 167 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 167 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 167 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 194 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 194 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 194 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 194 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 206 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 206 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 222 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 266 |
| ShortVariable | Avoid variables with short names like pp | 267 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 267 |
| LocalVariableCouldBeFinal | Local variable 'name' could be declared final | 269 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 271 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 275 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 278 |
org/apache/turbine/util/uri/TurbineURI.java
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=74, ATFD=9, TCC=9.725%) | 55 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 55 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 57–916 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dataVectors' | 62 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 93 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 105 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 105 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 117 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 117 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 130 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 130 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 130 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 157 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 157 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 157 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 157 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 168 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 192 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 192 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 205 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 205 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 205 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 218 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 218 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 218 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 232 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 232 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 232 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 233 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 245 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 245 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 291 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 309 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 325 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 325 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 351 |
| ShortVariable | Avoid variables with short names like pp | 386 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 386 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 397 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 408 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 408 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 419 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 419 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 430 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 430 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 441 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 441 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 452 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 452 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 463 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 463 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 474 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 474 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 485 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 485 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 496 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 496 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 507 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 507 |
| ShortVariable | Avoid variables with short names like pp | 518 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 518 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 528 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 556 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 584 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 622 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 655 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 670 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 682 |
| MethodArgumentCouldBeFinal | Parameter 'pathInfo' is not assigned and could be declared final | 712 |
| MethodArgumentCouldBeFinal | Parameter 'queryData' is not assigned and could be declared final | 736 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getPathInfoAsString' should not return void linguistically | 768 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 768 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getQueryDataAsString' should not return void linguistically | 778 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 778 |
| MethodArgumentCouldBeFinal | Parameter 'string' is not assigned and could be declared final | 789 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 794 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 812 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 812 |
| MethodArgumentCouldBeFinal | Parameter 'fieldDelim' is not assigned and could be declared final | 812 |
| MethodArgumentCouldBeFinal | Parameter 'valueDelim' is not assigned and could be declared final | 812 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 837 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 838 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 839 |
| LocalVariableCouldBeFinal | Local variable 'uriParam' could be declared final | 841 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 858 |
| ShortVariable | Avoid variables with short names like pp | 859 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 859 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 861 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 863 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 864 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 866 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 869 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 895 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 895 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 910 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 910 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 912 |
org/apache/turbine/util/uri/URIConstants.java
| Rule | Violation | Line |
|---|---|---|
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 36 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 39 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 42 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 45 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 48 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 51 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 54 |
| LongVariable | Avoid excessively long variable names like URI_SCHEME_SEPARATOR | 60 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 60 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 63 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 66 |
| LongVariable | Avoid excessively long variable names like CGI_TEMPLATE_PARAM | 69 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 69 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 72 |
org/apache/turbine/util/uri/URIParam.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'key' | 37 |
| ImmutableField | Field 'key' may be declared final | 37 |
| UnusedAssignment | The field initializer for 'key' is never used (overwritten on line 51) | 37 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'value' | 40 |
| ImmutableField | Field 'value' may be declared final | 40 |
| UnusedAssignment | The field initializer for 'value' is never used (overwritten on line 52) | 40 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 49 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 49 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 90 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 93 |
| ControlStatementBraces | This statement should have braces | 93 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 95 |
| ControlStatementBraces | This statement should have braces | 95 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 97 |
| ControlStatementBraces | This statement should have braces | 97 |
| LocalVariableCouldBeFinal | Local variable 'other' could be declared final | 98 |
org/apache/turbine/util/uri/URIUtils.java
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 34 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 47 |
| ShortVariable | Avoid variables with short names like du | 49 |
| LocalVariableCouldBeFinal | Local variable 'du' could be declared final | 49 |
org/apache/turbine/util/velocity/VelocityActionEvent.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 51 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'initialized' | 58 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 66 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 77 |
| ShortVariable | Avoid variables with short names like pp | 85 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 85 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 86 |
org/apache/turbine/util/velocity/VelocityEmail.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wordWrap' | 110 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'template' | 116 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'context' | 119 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 133 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTo' should not return any type except void linguistically | 149 |
| MethodArgumentCouldBeFinal | Parameter 'toName' is not assigned and could be declared final | 149 |
| MethodArgumentCouldBeFinal | Parameter 'toEmail' is not assigned and could be declared final | 149 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically | 164 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 164 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setWordWrap' should not return any type except void linguistically | 181 |
| MethodArgumentCouldBeFinal | Parameter 'wordWrap' is not assigned and could be declared final | 181 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setContext' should not return any type except void linguistically | 194 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 194 |
| MethodArgumentCouldBeFinal | Parameter 'serverAddress' is not assigned and could be declared final | 218 |
| UnusedAssignment | The initializer for variable 'body' is never used (overwritten on line 256) | 251 |
| LocalVariableCouldBeFinal | Local variable 'velocityService' could be declared final | 255 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 258 |
org/apache/turbine/util/velocity/VelocityEmailException.java
| Rule | Violation | Line |
|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 53 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 65 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 78 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 78 |
org/apache/turbine/util/velocity/VelocityHtmlEmail.java
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'htmlTemplate' | 94 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'textTemplate' | 100 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'context' | 103 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 106 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 106 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'embmap' | 106 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 124 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 128 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setHtmlTemplate' should not return any type except void linguistically | 139 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 139 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTextTemplate' should not return any type except void linguistically | 153 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 153 |
| MethodArgumentCouldBeFinal | Parameter 'serverAddress' is not assigned and could be declared final | 166 |
| LocalVariableCouldBeFinal | Local variable 'velocityService' could be declared final | 199 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 210 |
| MethodArgumentCouldBeFinal | Parameter 'surl' is not assigned and could be declared final | 243 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 243 |
| LocalVariableCouldBeFinal | Local variable 'url' could be declared final | 248 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 266 |
| LocalVariableCouldBeFinal | Local variable 'cid' could be declared final | 268 |
org/apache/turbine/services/schedule/BaseJobEntryTorque.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 25 |
| GodClass | Possible God Class (WMC=80, ATFD=31, TCC=5.867%) | 25 |
| CyclomaticComplexity | The class 'BaseJobEntryTorque' has a total cyclomatic complexity of 80 (highest 12). | 25 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 25 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 27–887 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'jobId' | 34 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'task' | 52 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'email' | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'property' | 58 |
| AvoidFieldNameMatchingMethodName | Field isNew has the same name as a method | 67 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'saving' | 70 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'loading' | 76 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'deleted' | 83 |
| MissingOverride | The method 'getJobId()' is missing an @Override annotation. | 94 |
| MissingOverride | The method 'setJobId(int)' is missing an @Override annotation. | 105 |
| ShortVariable | Avoid variables with short names like v | 105 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 105 |
| MissingOverride | The method 'getSecond()' is missing an @Override annotation. | 122 |
| MissingOverride | The method 'setSecond(int)' is missing an @Override annotation. | 133 |
| ShortVariable | Avoid variables with short names like v | 133 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 133 |
| MissingOverride | The method 'getMinute()' is missing an @Override annotation. | 150 |
| MissingOverride | The method 'setMinute(int)' is missing an @Override annotation. | 161 |
| ShortVariable | Avoid variables with short names like v | 161 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 161 |
| MissingOverride | The method 'getHour()' is missing an @Override annotation. | 178 |
| MissingOverride | The method 'setHour(int)' is missing an @Override annotation. | 189 |
| ShortVariable | Avoid variables with short names like v | 189 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 189 |
| MissingOverride | The method 'getWeekDay()' is missing an @Override annotation. | 206 |
| MissingOverride | The method 'setWeekDay(int)' is missing an @Override annotation. | 217 |
| ShortVariable | Avoid variables with short names like v | 217 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 217 |
| MissingOverride | The method 'getDayOfMonth()' is missing an @Override annotation. | 234 |
| MissingOverride | The method 'setDayOfMonth(int)' is missing an @Override annotation. | 245 |
| ShortVariable | Avoid variables with short names like v | 245 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 245 |
| MissingOverride | The method 'getTask()' is missing an @Override annotation. | 262 |
| MissingOverride | The method 'setTask(String)' is missing an @Override annotation. | 273 |
| ShortVariable | Avoid variables with short names like v | 273 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 273 |
| ShortVariable | Avoid variables with short names like v | 301 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 301 |
| MethodReturnsInternalArray | Returning 'property' may expose an internal array. | 321 |
| ShortVariable | Avoid variables with short names like v | 329 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 329 |
| ArrayIsStoredDirectly | The user-supplied array 'v' is stored directly. | 336 |
| MissingOverride | The method 'isNew()' is missing an @Override annotation. | 349 |
| MissingOverride | The method 'setNew(boolean)' is missing an @Override annotation. | 359 |
| MethodArgumentCouldBeFinal | Parameter 'isNew' is not assigned and could be declared final | 359 |
| MissingOverride | The method 'isModified()' is missing an @Override annotation. | 369 |
| MissingOverride | The method 'setModified(boolean)' is missing an @Override annotation. | 379 |
| MethodArgumentCouldBeFinal | Parameter 'modified' is not assigned and could be declared final | 379 |
| MethodArgumentCouldBeFinal | Parameter 'saving' is not assigned and could be declared final | 408 |
| MethodArgumentCouldBeFinal | Parameter 'loading' is not assigned and could be declared final | 429 |
| MethodArgumentCouldBeFinal | Parameter 'deleted' is not assigned and could be declared final | 456 |
| MissingOverride | The method 'save()' is missing an @Override annotation. | 474 |
| MissingOverride | The method 'save(String)' is missing an @Override annotation. | 488 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 488 |
| MissingOverride | The method 'save(Connection)' is missing an @Override annotation. | 509 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 509 |
| MissingOverride | The method 'setPrimaryKey(ObjectKey<?>)' is missing an @Override annotation. | 548 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 548 |
| MissingOverride | The method 'setPrimaryKey(String)' is missing an @Override annotation. | 559 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 559 |
| MissingOverride | The method 'getPrimaryKey()' is missing an @Override annotation. | 569 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 597 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 612 |
| LocalVariableCouldBeFinal | Local variable 'jobEntryTorque' could be declared final | 614 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 630 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 630 |
| LocalVariableCouldBeFinal | Local variable 'jobEntryTorque' could be declared final | 632 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 644 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 657 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 657 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 671 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 671 |
| EmptyControlStatement | Empty if statement | 683–685 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 700 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 700 |
| EmptyControlStatement | Empty if statement | 712–714 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 719 |
| MissingOverride | The method 'toString()' is missing an @Override annotation. | 747 |
| LocalVariableCouldBeFinal | Local variable 'str' could be declared final | 749 |
| InsufficientStringBufferDeclaration | StringBuffer has been initialized with size 16, but has at least 115 characters appended. | 749 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 750 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 750 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 751–753 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 753 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 753 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 754–756 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 756 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 756 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 757–759 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 759 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 759 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 760–762 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 762 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 762 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 763–765 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 765 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 765 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 766–768 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 768 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 768 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 769–771 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 771 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 771 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 772–774 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 774 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. | 774 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 777 |
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 788 |
| MethodArgumentCouldBeFinal | Parameter 'toCompare' is not assigned and could be declared final | 788 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 792 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 796 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 800 |
| LocalVariableCouldBeFinal | Local variable 'other' could be declared final | 802 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 805 |
| MissingOverride | The method 'hashCode()' is missing an @Override annotation. | 816 |
| ShortVariable | Avoid variables with short names like ok | 818 |
| LocalVariableCouldBeFinal | Local variable 'ok' could be declared final | 818 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 821 |
| CyclomaticComplexity | The method 'valueEquals(JobEntryTorque)' has a cyclomatic complexity of 12. | 836 |
| NPathComplexity | The method 'valueEquals(JobEntryTorque)' has an NPath complexity of 2048, current threshold is 200 | 836 |
| MethodArgumentCouldBeFinal | Parameter 'toCompare' is not assigned and could be declared final | 836 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 840 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 842 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 844 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 848 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 852 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 856 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 860 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 864 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 868 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 872 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 876 |
| SimplifyBooleanReturns | This if statement can be replaced by `return !{condition};` | 878–881 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 880 |
org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java
| Rule | Violation | Line |
|---|---|---|
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 1–1477 |
| GodClass | Possible God Class (WMC=68, ATFD=109, TCC=0.045%) | 36 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 36 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 36 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 37–1477 |
| LongVariable | Avoid excessively long variable names like jobEntryTorquePeerImpl | 70 |
| LocalVariableCouldBeFinal | Local variable 'dbMap' could be declared final | 75 |
| LawOfDemeter | Call to `getDatabaseMap` on foreign value `Torque.getOrCreateDatabase("default")` (degree 1) | 75–76 |
| AvoidDuplicateLiterals | The String literal "TURBINE_SCHEDULED_JOB" appears 5 times in this file; the first occurrence is on line 77 | 77 |
| LawOfDemeter | Call to `getTable` on foreign value `dbMap` (degree 2) | 84 |
| LawOfDemeter | Call to `setJavaName` on foreign value `TABLE` (degree 2) | 85 |
| LawOfDemeter | Call to `setOMClass` on foreign value `TABLE` (degree 2) | 86 |
| LawOfDemeter | Call to `setPeerClass` on foreign value `TABLE` (degree 2) | 87 |
| LawOfDemeter | Call to `setPrimaryKeyMethod` on foreign value `TABLE` (degree 2) | 88 |
| LawOfDemeter | Call to `setPrimaryKeyMethodInfo` on foreign value `TABLE` (degree 2) | 89 |
| LawOfDemeter | Call to `getName` on foreign value `TABLE` (degree 2) | 89 |
| LawOfDemeter | Call to `setPrimaryKeyMethodInfo` on foreign value `TABLE` (degree 2) | 90 |
| LawOfDemeter | Call to `setPrimaryKeyMethodInfo` on foreign value `TABLE` (degree 2) | 91 |
| LawOfDemeter | Call to `setUseInheritance` on foreign value `TABLE` (degree 2) | 92 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 97 |
| AvoidDuplicateLiterals | The String literal "INTEGER" appears 6 times in this file; the first occurrence is on line 98 | 98 |
| AvoidDuplicateLiterals | The String literal "int" appears 6 times in this file; the first occurrence is on line 105 | 105 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 107 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 110 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 121 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 124 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 135 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 138 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 149 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 152 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 163 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 166 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 177 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 191 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 205 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 218 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'instance' | 232 |
| LocalVariableCouldBeFinal | Local variable 'instance' could be declared final | 232 |
| MethodArgumentCouldBeFinal | Parameter 'peerImplInstance' is not assigned and could be declared final | 263 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 274 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 291 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 309 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 309 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 325 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 344 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 345 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 368 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 369 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 387 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 388 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 408 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 409 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 410 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 437 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 438 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 439 |
| MethodArgumentCouldBeFinal | Parameter 'query' is not assigned and could be declared final | 462 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 463 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 464 |
| MethodArgumentCouldBeFinal | Parameter 'query' is not assigned and could be declared final | 486 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 487 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 488 |
| MethodArgumentCouldBeFinal | Parameter 'query' is not assigned and could be declared final | 514 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 515 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 516 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 534 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 551 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 570 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 571 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 589 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 590 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 611 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 612 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 613 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 632 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 658 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 658 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 676 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 676 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 676 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 687 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 703 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 703 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 788 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 808 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 808 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 827 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 827 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 827 |
| MethodArgumentCouldBeFinal | Parameter 'selectCriteria' is not assigned and could be declared final | 846 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 847 |
| MethodArgumentCouldBeFinal | Parameter 'updateValues' is not assigned and could be declared final | 847 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 869 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 870 |
| MethodArgumentCouldBeFinal | Parameter 'updateValues' is not assigned and could be declared final | 870 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 871 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 891 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 908 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 908 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 927 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 949 |
| MethodArgumentCouldBeFinal | Parameter 'replacementValues' is not assigned and could be declared final | 950 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 976 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 977 |
| MethodArgumentCouldBeFinal | Parameter 'replacementValues' is not assigned and could be declared final | 978 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 1003 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1004 |
| MethodArgumentCouldBeFinal | Parameter 'replacementValues' is not assigned and could be declared final | 1005 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 1116 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 1135 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1135 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 1151 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 1170 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1170 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 1187 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 1209 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1210 |
| ShortVariable | Avoid variables with short names like pk | 1226 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 1226 |
| ShortVariable | Avoid variables with short names like pk | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1245 |
| ShortVariable | Avoid variables with short names like pk | 1257 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 1257 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 1269 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 1282 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 1292 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 1303 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 1314 |
| MethodArgumentCouldBeFinal | Parameter 'jobEntryTorque' is not assigned and could be declared final | 1314 |
| ShortVariable | Avoid variables with short names like pk | 1330 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 1330 |
| ShortVariable | Avoid variables with short names like pk | 1346 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 1346 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1346 |
| ShortVariable | Avoid variables with short names like pk | 1364 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 1364 |
| ShortVariable | Avoid variables with short names like pk | 1380 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 1380 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1380 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 1397 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 1415 |
| MethodArgumentCouldBeFinal | Parameter 'dbcon' is not assigned and could be declared final | 1416 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 1432 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 1449 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 1449 |
org/apache/turbine/services/schedule/BaseJobEntryTorquePeerImpl.java
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 38–552 |
| MethodArgumentCouldBeFinal | Parameter 'recordMapper' is not assigned and could be declared final | 64 |
| MethodArgumentCouldBeFinal | Parameter 'tableMap' is not assigned and could be declared final | 65 |
| MethodArgumentCouldBeFinal | Parameter 'databaseName' is not assigned and could be declared final | 66 |
| MissingOverride | The method 'doUpdate(ColumnValues, Connection)' is missing an @Override annotation. | 94 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 94 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 94 |
| LocalVariableCouldBeFinal | Local variable 'selectCriteria' could be declared final | 97 |
| LocalVariableCouldBeFinal | Local variable 'pkValue' could be declared final | 101 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'rowCount' | 125 |
| LocalVariableCouldBeFinal | Local variable 'rowCount' could be declared final | 125 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 139 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 141 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 159 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 159 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 162 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 178 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 181 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 202 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 203 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 206 |
| MissingOverride | The method 'buildCriteria(ObjectKey<?>)' is missing an @Override annotation. | 217 |
| ShortVariable | Avoid variables with short names like pk | 217 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 217 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 219 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 231 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 233 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 247 |
| LambdaCanBeMethodReference | Lambda expression could be written as a method reference: `BaseJobEntryTorque::getPrimaryKey` | 250 |
| MissingOverride | The method 'buildCriteria(JobEntryTorque)' is missing an @Override annotation. | 260 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 260 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 262 |
| MissingOverride | The method 'buildSelectCriteria(JobEntryTorque)' is missing an @Override annotation. | 284 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 284 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 286 |
| MissingOverride | The method 'buildColumnValues(JobEntryTorque)' is missing an @Override annotation. | 312 |
| MethodArgumentCouldBeFinal | Parameter 'jobEntryTorque' is not assigned and could be declared final | 312 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 315 |
| LocalVariableCouldBeFinal | Local variable 'columnValues' could be declared final | 315 |
| ShortVariable | Avoid variables with short names like pk | 377 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 377 |
| ShortVariable | Avoid variables with short names like pk | 393 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 393 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 393 |
| ShortVariable | Avoid variables with short names like pk | 411 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 411 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 416 |
| ShortVariable | Avoid variables with short names like pk | 432 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 432 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 432 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 435 |
| ShortVariable | Avoid variables with short names like v | 436 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 436 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 457 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 462 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 481 |
| MethodArgumentCouldBeFinal | Parameter 'dbcon' is not assigned and could be declared final | 482 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 485 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 487 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 487 |
| LocalVariableCouldBeFinal | Local variable 'objectKeyList' could be declared final | 489 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 489 |
| LocalVariableCouldBeFinal | Local variable 'pk' could be declared final | 490 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 494 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 495 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 495 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 510 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 515 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 534 |
| MethodArgumentCouldBeFinal | Parameter 'dbcon' is not assigned and could be declared final | 535 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 538 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 540 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 540 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 542 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 543 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 543 |
org/apache/turbine/services/schedule/BaseJobEntryTorqueRecordMapper.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 27 |
| GodClass | Possible God Class (WMC=62, ATFD=51, TCC=1.818%) | 27 |
| ProperLogger | Logger should be defined private static final and have the correct class | 33 |
| LongVariable | Avoid excessively long variable names like WEEK_DAY_EXPRESSION | 40 |
| LongVariable | Avoid excessively long variable names like DAY_OF_MONTH_EXPRESSION | 41 |
| LongVariable | Avoid excessively long variable names like PROPERTY_EXPRESSION | 44 |
| LongVariable | Avoid excessively long variable names like useMappingStrategy | 46 |
| ImmutableField | Field 'useMappingStrategy' may be declared final | 46 |
| NonSerializableClass | The field 'strategy' of serializable class 'org.apache.turbine.services.schedule.BaseJobEntryTorqueRecordMapper' is of non-serializable type 'org.apache.torque.om.mapper.MappingStrategy<org.apache.turbine.services.schedule.JobEntryTorque>'. | 48 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new MappingStrategy<>()` | 52 |
| NcssCount | The method 'processRow(ResultSet, int, Criteria)' has a NCSS line count of 96. | 77 |
| CognitiveComplexity | The method 'processRow(ResultSet, int, Criteria)' has a cognitive complexity of 103, current threshold is 15 | 77 |
| CyclomaticComplexity | The method 'processRow(ResultSet, int, Criteria)' has a cyclomatic complexity of 33. | 77 |
| NPathComplexity | The method 'processRow(ResultSet, int, Criteria)' has an NPath complexity of 234, current threshold is 200 | 77 |
| MissingOverride | The method 'processRow(ResultSet, int, Criteria)' is missing an @Override annotation. | 77 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 78 |
| MethodArgumentCouldBeFinal | Parameter 'offset' is not assigned and could be declared final | 79 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 80 |
| LocalVariableCouldBeFinal | Local variable 'jobEntryTorque' could be declared final | 83 |
| LocalVariableCouldBeFinal | Local variable 'selectColumns' could be declared final | 117 |
| LongVariable | Avoid excessively long variable names like columnsWithoutOffset | 118 |
| LocalVariableCouldBeFinal | Local variable 'columnsWithoutOffset' could be declared final | 118 |
| LocalVariableCouldBeFinal | Local variable 'columnsMapped' could be declared final | 121 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashSet<>()` | 121 |
| LocalVariableCouldBeFinal | Local variable 'column' could be declared final | 122 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 247 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 279 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 280 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 306 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 307 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 333 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 334 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 360 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 361 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 387 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 388 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 414 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 415 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 441 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 442 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 468 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 469 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 495 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 496 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 504 |
org/apache/turbine/services/schedule/JobEntryTorquePeer.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 13 |
Priority 4
org/apache/turbine/annotation/AnnotationProcessor.java
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 682 |
org/apache/turbine/modules/ActionEvent.java
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 210 |
org/apache/turbine/modules/GenericLoader.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenericLoader': 'getPackages' is already in scope | 203 |
org/apache/turbine/modules/Page.java
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Page | 33 |
org/apache/turbine/om/security/DefaultUserImpl.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 348 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'SESSION_ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 366 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 401 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'SESSION_ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 413 |
| UselessParentheses | Useless parentheses. | 541 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'CONFIRM_VALUE' is already in scope because it is inherited by an enclosing type | 632 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'CONFIRM_VALUE' is already in scope because it is inherited by an enclosing type | 643 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'LAST_LOGIN' is already in scope because it is inherited by an enclosing type | 676 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'LAST_LOGIN' is already in scope because it is inherited by an enclosing type | 687 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'HAS_LOGGED_IN' is already in scope because it is inherited by an enclosing type | 698 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'HAS_LOGGED_IN' is already in scope because it is inherited by an enclosing type | 711 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'CONFIRM_DATA' is already in scope because it is inherited by an enclosing type | 726 |
org/apache/turbine/om/security/User.java
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like User | 41 |
org/apache/turbine/pipeline/DetermineActionValve.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'java.util.regex.Matcher' | 25 |
| UnnecessaryImport | Unused import 'java.util.regex.Pattern' | 26 |
org/apache/turbine/pipeline/TurbinePipeline.java
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 139 |
org/apache/turbine/services/BaseServiceBroker.java
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 210 |
| UselessParentheses | Useless parentheses. | 318 |
org/apache/turbine/services/Initable.java
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 96 |
org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'org.apache.turbine.util.uri.URIConstants' | 45 |
org/apache/turbine/services/jsp/TurbineJspService.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JspService': 'JSP_EXTENSION' is already in scope because it is inherited by an enclosing type | 84 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JspService': 'BUFFER_SIZE_KEY' is already in scope because it is inherited by an enclosing type | 232 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JspService': 'BUFFER_SIZE_DEFAULT' is already in scope because it is inherited by an enclosing type | 233 |
org/apache/turbine/services/localization/RundataLocalizationService.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 51 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LocalizationService': 'ACCEPT_LANGUAGE' is already in scope because it is inherited by an enclosing type | 55 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LocalizationService': 'ACCEPT_LANGUAGE' is already in scope because it is inherited by an enclosing type | 64 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LocalizationService': 'ACCEPT_LANGUAGE' is already in scope because it is inherited by an enclosing type | 74 |
org/apache/turbine/services/pull/util/DateTimeFormatterTool.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.time.format': 'DateTimeFormatter' is already in scope because it is imported in this file | 181 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.time.format': 'DateTimeFormatter' is already in scope because it is imported in this file | 182 |
org/apache/turbine/services/rundata/DefaultTurbineRunData.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 728 |
| UselessParentheses | Useless parentheses. | 986 |
org/apache/turbine/services/rundata/TurbineRunDataService.java
| Rule | Violation | Line |
|---|---|---|
| OneDeclarationPerLine | Use one line for each declaration, it enhances code readability. | 119 |
org/apache/turbine/services/schedule/AbstractSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'ScheduleService': 'LOGGER_NAME' is already in scope because it is inherited by an enclosing type | 44 |
org/apache/turbine/services/schedule/QuartzSchedulerService.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'ScheduleService': 'LOGGER_NAME' is already in scope because it is inherited by an enclosing type | 54 |
org/apache/turbine/services/security/DefaultSecurityService.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SecurityService': 'USER_MANAGER_KEY' is already in scope because it is inherited by an enclosing type | 129 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SecurityService': 'USER_MANAGER_DEFAULT' is already in scope because it is inherited by an enclosing type | 130 |
org/apache/turbine/services/template/TemplateService.java
| Rule | Violation | Line |
|---|---|---|
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 285 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 299 |
org/apache/turbine/services/template/TurbineTemplateService.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_EXTENSION_VALUE' is already in scope because it is inherited by an enclosing type | 231 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_EXTENSION_KEY' is already in scope because it is inherited by an enclosing type | 282 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_EXTENSION_VALUE' is already in scope because it is inherited by an enclosing type | 283 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_TEMPLATE_KEY' is already in scope because it is inherited by an enclosing type | 285 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_TEMPLATE_VALUE' is already in scope because it is inherited by an enclosing type | 286 |
org/apache/turbine/services/template/mapper/ClassMapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 142 |
org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 123 |
org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 118 |
org/apache/turbine/services/velocity/TurbineVelocityService.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'VELOCITY_EXTENSION' is already in scope because it is inherited by an enclosing type | 144 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'CONTEXT' is already in scope because it is inherited by an enclosing type | 253 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'RUNDATA_KEY' is already in scope because it is inherited by an enclosing type | 258 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'PIPELINEDATA_KEY' is already in scope because it is inherited by an enclosing type | 260 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'CONTEXT' is already in scope because it is inherited by an enclosing type | 272 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'RUNDATA_KEY' is already in scope because it is inherited by an enclosing type | 418 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'RUNDATA_KEY' is already in scope because it is inherited by an enclosing type | 437 |
| UselessParentheses | Useless parentheses. | 515 |
org/apache/turbine/util/FormMessages.java
| Rule | Violation | Line |
|---|---|---|
| OneDeclarationPerLine | Use one line for each declaration, it enhances code readability. | 130 |
| OneDeclarationPerLine | Use one line for each declaration, it enhances code readability. | 131 |
org/apache/turbine/util/GenerateUniqueId.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Random' is already in scope because it is imported in this file | 52 |
| UselessParentheses | Useless parentheses. | 103 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 154 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 155 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 156 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 157 |
org/apache/turbine/util/SecurityCheck.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 158 |
| UselessParentheses | Useless parentheses. | 252 |
org/apache/turbine/util/TurbineConfig.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'jakarta.servlet': 'FilterRegistration' is already in scope because it is imported in this file | 677 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'jakarta.servlet': 'FilterRegistration' is already in scope because it is imported in this file | 689 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'jakarta.servlet': 'FilterRegistration' is already in scope because it is imported in this file | 701 |
org/apache/turbine/util/template/HtmlPageAttributes.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 536 |
| UselessParentheses | Useless parentheses. | 574 |
| UselessParentheses | Useless parentheses. | 594 |
| UselessParentheses | Useless parentheses. | 614 |
org/apache/turbine/util/template/TemplateInfo.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'NAVIGATION_TEMPLATE' is already in scope because it is declared in an enclosing type | 77 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'NAVIGATION_TEMPLATE' is already in scope because it is declared in an enclosing type | 87 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'LAYOUT_TEMPLATE' is already in scope because it is declared in an enclosing type | 135 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'LAYOUT_TEMPLATE' is already in scope because it is declared in an enclosing type | 146 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'SERVICE_NAME' is already in scope because it is declared in an enclosing type | 179 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'SERVICE_NAME' is already in scope because it is declared in an enclosing type | 189 |
org/apache/turbine/util/uri/BaseURI.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'URIConstants': 'URI_SCHEME_SEPARATOR' is already in scope because it is inherited by an enclosing type | 463 |
org/apache/turbine/util/uri/URI.java
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like URI | 32 |
org/apache/turbine/util/uri/URIParam.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 63 |
org/apache/turbine/services/schedule/BaseJobEntryTorque.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'AbstractJobEntry' is already in scope because it is declared in the same package | 25 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 719 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 720 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 728 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 742 |
| UselessParentheses | Useless parentheses. | 778 |
org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorque' is already in scope because it is declared in the same package | 86 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 87 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JobEntryTorquePeer': 'BaseJobEntryTorquePeer::createJobEntryTorquePeerImpl' is already in scope | 248 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.torque.criteria': 'Criteria' is already in scope because it is imported in this file | 589 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.torque.criteria': 'Criteria' is already in scope because it is imported in this file | 611 |
org/apache/turbine/services/schedule/BaseJobEntryTorquePeerImpl.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'java.util.Map' | 7 |
| UnnecessaryImport | Unused import 'java.util.Objects' | 8 |
org/apache/turbine/services/schedule/JobEntryTorque.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'BaseJobEntryTorque' is already in scope because it is declared in the same package | 15 |
org/apache/turbine/services/schedule/JobEntryTorquePeer.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'BaseJobEntryTorquePeer' is already in scope because it is declared in the same package | 14 |
org/apache/turbine/services/schedule/JobEntryTorquePeerImpl.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'BaseJobEntryTorquePeerImpl' is already in scope because it is declared in the same package | 14 |
Priority 5
org/apache/turbine/services/jsonrpc/JSONProcessor.java
| Rule | Violation | Line |
|---|---|---|
| InvalidLogMessageFormat | Too many arguments, expected 0 argument but found 1 | 83 |
Files
org/apache/turbine/Turbine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 1–1093 |
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 3 | 1–1093 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 118 |
| GodClass | Possible God Class (WMC=85, ATFD=57, TCC=11.694%) | 3 | 118 |
| CyclomaticComplexity | The class 'Turbine' has a total cyclomatic complexity of 85 (highest 12). | 3 | 118 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 119–1093 |
| LongVariable | Avoid excessively long variable names like REDIRECTED_PATHINFO_NAME | 3 | 130 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pipeline' | 3 | 148 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'initFailure' | 3 | 151 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverData' | 3 | 161 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 161 |
| SingularField | Perhaps 'webappRoot' could be replaced by a local variable. | 3 | 176 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'configuration' | 3 | 179 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 187 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 3 | 212 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 216 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 220 |
| ExceptionAsFlowControl | Exception thrown at line 223 is caught in this block. | 3 | 231–237 |
| ExceptionAsFlowControl | Exception thrown at line 228 is caught in this block. | 3 | 231–237 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 231 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 257 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 257 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 258 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 271 |
| LocalVariableCouldBeFinal | Local variable 'confPath' could be declared final | 3 | 309 |
| LocalVariableCouldBeFinal | Local variable 'jaxb' could be declared final | 3 | 354 |
| LocalVariableCouldBeFinal | Local variable 'unmarshaller' could be declared final | 3 | 355 |
| CyclomaticComplexity | The method 'configureApplication(ServletConfig, ServletContext)' has a cyclomatic complexity of 12. | 3 | 381 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 381 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 381 |
| LocalVariableCouldBeFinal | Local variable 'params' could be declared final | 3 | 417 |
| LongVariable | Avoid excessively long variable names like confFileRelativePath | 3 | 427 |
| LocalVariableCouldBeFinal | Local variable 'confFileRelativePath' could be declared final | 3 | 427 |
| LongVariable | Avoid excessively long variable names like targetPathDirectory | 3 | 433 |
| LocalVariableCouldBeFinal | Local variable 'targetPathDirectory' could be declared final | 3 | 433 |
| LocalVariableCouldBeFinal | Local variable 'targetFilePath' could be declared final | 3 | 439 |
| LocalVariableCouldBeFinal | Local variable 'combinedBuilder' could be declared final | 3 | 453 |
| LocalVariableCouldBeFinal | Local variable 'propertiesBuilder' could be declared final | 3 | 462 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 479–480 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 500 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 501 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 501 |
| MethodArgumentCouldBeFinal | Parameter 'defaultValue' is not assigned and could be declared final | 3 | 501 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 524 |
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 530 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 543 |
| LocalVariableCouldBeFinal | Local variable 'services' could be declared final | 3 | 557 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 3 | 559 |
| LocalVariableCouldBeFinal | Local variable 'serviceName' could be declared final | 3 | 561 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 562 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 658–677 |
| LocalVariableCouldBeFinal | Local variable 'serverName' could be declared final | 3 | 660 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 687 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 708 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 751 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 3 | 751 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 767 |
| LocalVariableCouldBeFinal | Local variable 'runDataMap' could be declared final | 3 | 767 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 785 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 790 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 810 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 3 | 810 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 842 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 3 | 842 |
| ShortVariable | Avoid variables with short names like t | 3 | 843 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 3 | 843 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 845 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 863 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 876 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 877 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 880 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 3 | 894 |
| ShortVariable | Avoid variables with short names like t | 3 | 894 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 3 | 894 |
| CloseResource | Ensure that resources like this PrintWriter object are closed after use | 3 | 900 |
| LocalVariableCouldBeFinal | Local variable 'writer' could be declared final | 3 | 900 |
| LawOfDemeter | Call to `println` on foreign value `writer` (degree 2) | 3 | 901 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 904 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 909 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 919 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 919 |
| LocalVariableCouldBeFinal | Local variable 'requestServerData' could be declared final | 3 | 928 |
| MethodArgumentCouldBeFinal | Parameter 'logConf' is not assigned and could be declared final | 3 | 941 |
| CloseResource | Ensure that resources like this LoggerContext object are closed after use | 3 | 943 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 943 |
| LawOfDemeter | Call to `getConfigurationSource` on foreign value `context.getConfiguration()` (degree 1) | 3 | 945 |
| LocalVariableCouldBeFinal | Local variable 'log4jFile' could be declared final | 3 | 947 |
| LocalVariableCouldBeFinal | Local variable 'ctxContext' could be declared final | 3 | 951 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 953 |
| LawOfDemeter | Call to `getConfigurationSource` on foreign value `context.getConfiguration()` (degree 1) | 3 | 953 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 958 |
| LawOfDemeter | Call to `getConfigurationSource` on foreign value `context.getConfiguration()` (degree 1) | 3 | 958 |
| CognitiveComplexity | The method 'resolveLog4j2(Path)' has a cognitive complexity of 21, current threshold is 15 | 3 | 970 |
| CyclomaticComplexity | The method 'resolveLog4j2(Path)' has a cyclomatic complexity of 12. | 3 | 970 |
| MethodArgumentCouldBeFinal | Parameter 'logConfPath' is not assigned and could be declared final | 3 | 970 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 980 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 985–1005 |
| LocalVariableCouldBeFinal | Local variable 'log4jFilePath' could be declared final | 3 | 987 |
| MethodArgumentCouldBeFinal | Parameter 'val' is not assigned and could be declared final | 3 | 1016 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 1049 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 1053 |
org/apache/turbine/TurbineConstants.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 48 |
| LongVariable | Avoid excessively long variable names like LOG4J2_CONFIG_FILE | 3 | 51 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 51 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 53 |
| LongVariable | Avoid excessively long variable names like LOG4J2_CONFIG_FILE_DEFAULT | 3 | 56 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 56 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 59 |
| LongVariable | Avoid excessively long variable names like SCHEDULER_LOG_FACILITY | 3 | 62 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 62 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 65 |
| LongVariable | Avoid excessively long variable names like MAIL_SERVER_DEFAULT | 3 | 68 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 68 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 71 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 74 |
| LongVariable | Avoid excessively long variable names like MODULE_CACHE_DEFAULT | 3 | 77 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 77 |
| LongVariable | Avoid excessively long variable names like MODULE_CACHE_SIZE_KEY | 3 | 80 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 80 |
| LongVariable | Avoid excessively long variable names like MODULE_CACHE_SIZE_DEFAULT | 3 | 83 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 83 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 86 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 89 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 92 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_ERROR_KEY | 3 | 95 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 95 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_ERROR_JSP | 3 | 98 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 98 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 101 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 104 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 107 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 110 |
| LongVariable | Avoid excessively long variable names like SCREEN_ERROR_DEFAULT | 3 | 113 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 113 |
| LongVariable | Avoid excessively long variable names like SCREEN_INVALID_STATE | 3 | 116 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 116 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_INVALID_STATE | 3 | 119 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 119 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 122 |
| LongVariable | Avoid excessively long variable names like ACTION_LOGIN_DEFAULT | 3 | 125 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 125 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 128 |
| LongVariable | Avoid excessively long variable names like ACTION_LOGOUT_DEFAULT | 3 | 131 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 131 |
| LongVariable | Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_KEY | 3 | 134 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 134 |
| LongVariable | Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_DEFAULT | 3 | 137 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 137 |
| LongVariable | Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_KEY | 3 | 140 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 140 |
| LongVariable | Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_DEFAULT | 3 | 143 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 143 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_KEY | 3 | 146 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 146 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_DEFAULT | 3 | 149 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 149 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP | 3 | 152 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 152 |
| LongVariable | Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT | 3 | 155 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 155 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 158 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 161 |
| LongVariable | Avoid excessively long variable names like PAGE_DEFAULT_DEFAULT | 3 | 164 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 164 |
| LongVariable | Avoid excessively long variable names like SCREEN_DEFAULT_DEFAULT | 3 | 167 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 167 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 170 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 173 |
| LongVariable | Avoid excessively long variable names like LOGIN_MESSAGE_NOSCREEN | 3 | 176 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 176 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 179 |
| LongVariable | Avoid excessively long variable names like SESSION_TIMEOUT_KEY | 3 | 182 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 182 |
| LongVariable | Avoid excessively long variable names like SESSION_TIMEOUT_DEFAULT | 3 | 185 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 185 |
| LongVariable | Avoid excessively long variable names like SESSION_OBJECTINPUTFILTER | 3 | 191 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 191 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 194 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 197 |
| LongVariable | Avoid excessively long variable names like PP_URL_CASE_FOLDING | 3 | 203 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 203 |
| LongVariable | Avoid excessively long variable names like DEFAULT_DOCUMENT_TYPE_KEY | 3 | 206 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 206 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_KEY | 3 | 209 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 209 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_DEFAULT | 3 | 212 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 212 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_KEY | 3 | 215 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 215 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_DEFAULT | 3 | 218 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 218 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_KEY | 3 | 221 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 221 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_DEFAULT | 3 | 224 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 224 |
| LongVariable | Avoid excessively long variable names like DEFAULT_HTML_CONTENT_TYPE | 3 | 227 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 227 |
| LongVariable | Avoid excessively long variable names like DEFAULT_TEXT_CONTENT_TYPE | 3 | 228 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 228 |
| LongVariable | Avoid excessively long variable names like DEFAULT_CSS_CONTENT_TYPE | 3 | 229 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 229 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_KEY | 3 | 232 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 232 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_DEFAULT | 3 | 235 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 235 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_KEY | 3 | 238 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 238 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_DEFAULT | 3 | 241 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 241 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_KEY | 3 | 244 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 244 |
| LongVariable | Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_DEFAULT | 3 | 247 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 247 |
| LongVariable | Avoid excessively long variable names like LOCALE_OVERRIDE_CHARSET_KEY | 3 | 250 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 250 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 255 |
| LongVariable | Avoid excessively long variable names like APPLICATION_ROOT_KEY | 3 | 258 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 258 |
| LongVariable | Avoid excessively long variable names like APPLICATION_ROOT_DEFAULT | 3 | 261 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 261 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 268 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 271 |
| LongVariable | Avoid excessively long variable names like LOGGING_ROOT_DEFAULT | 3 | 274 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 274 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 277 |
| LongVariable | Avoid excessively long variable names like SCREEN_PLACEHOLDER | 3 | 280 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 280 |
| LongVariable | Avoid excessively long variable names like NAVIGATION_PLACEHOLDER | 3 | 283 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 283 |
| LongVariable | Avoid excessively long variable names like PROCESSING_EXCEPTION_PLACEHOLDER | 3 | 286 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 286 |
| LongVariable | Avoid excessively long variable names like STACK_TRACE_PLACEHOLDER | 3 | 289 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 289 |
| LongVariable | Avoid excessively long variable names like PARAMETER_ENCODING_KEY | 3 | 292 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 292 |
| LongVariable | Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT | 3 | 295 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 295 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SERVER_NAME_KEY | 3 | 298 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 298 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SERVER_PORT_KEY | 3 | 302 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 302 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SERVER_SCHEME_KEY | 3 | 306 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 306 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SCRIPT_NAME_KEY | 3 | 310 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 310 |
| LongVariable | Avoid excessively long variable names like DEFAULT_CONTEXT_PATH_KEY | 3 | 314 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 314 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 318 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 325 |
org/apache/turbine/annotation/AnnotationProcessor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 3 | 1–710 |
| GodClass | Possible God Class (WMC=106, ATFD=54, TCC=31.818%) | 3 | 53 |
| CyclomaticComplexity | The class 'AnnotationProcessor' has a total cyclomatic complexity of 106 (highest 27). | 3 | 53 |
| UseUtilityClass | This utility class has a non-private constructor | 3 | 53 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 54–710 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 56 |
| FieldNamingConventions | The constant name 'annotationCache' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 68 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 70 |
| LocalVariableCouldBeFinal | Local variable 'newAnnotations' could be declared final | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 101 |
| MethodArgumentCouldBeFinal | Parameter 'acl' is not assigned and could be declared final | 3 | 101 |
| NcssCount | The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a NCSS line count of 63. | 3 | 117 |
| CognitiveComplexity | The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a cognitive complexity of 100, current threshold is 15 | 3 | 117 |
| CyclomaticComplexity | The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a cyclomatic complexity of 27. | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'acl' is not assigned and could be declared final | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'conditonType' is not assigned and could be declared final | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 3 | 119 |
| LocalVariableCouldBeFinal | Local variable 'annotation' could be declared final | 3 | 121 |
| LocalVariableCouldBeFinal | Local variable 'trr' could be declared final | 3 | 125 |
| LocalVariableCouldBeFinal | Local variable 'roleNames' could be declared final | 3 | 126 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 127 |
| LocalVariableCouldBeFinal | Local variable 'roleName' could be declared final | 3 | 131 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 3 | 134 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 137 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 143 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 149 |
| LocalVariableCouldBeFinal | Local variable 'roleName' could be declared final | 3 | 154 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 3 | 157 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 160 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 166 |
| LocalVariableCouldBeFinal | Local variable 'trp' could be declared final | 3 | 175 |
| LocalVariableCouldBeFinal | Local variable 'permissionNames' could be declared final | 3 | 176 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 177 |
| LocalVariableCouldBeFinal | Local variable 'permissionName' could be declared final | 3 | 181 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 3 | 184 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 187 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 193 |
| LocalVariableCouldBeFinal | Local variable 'permissionName' could be declared final | 3 | 201 |
| DefaultLabelNotLastInSwitchStmt | The default label should be the last label in a switch statement | 3 | 204 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 207 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 213 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 233 |
| CognitiveComplexity | The method 'process(Object, Boolean)' has a cognitive complexity of 51, current threshold is 15 | 3 | 246 |
| CyclomaticComplexity | The method 'process(Object, Boolean)' has a cyclomatic complexity of 17. | 3 | 246 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 246 |
| LongVariable | Avoid excessively long variable names like hasTurbineServicesInMethodFields | 3 | 246 |
| MethodArgumentCouldBeFinal | Parameter 'hasTurbineServicesInMethodFields' is not assigned and could be declared final | 3 | 246 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 256 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 257 |
| LocalVariableCouldBeFinal | Local variable 'fields' could be declared final | 3 | 263 |
| LocalVariableCouldBeFinal | Local variable 'field' could be declared final | 3 | 265 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 3 | 267 |
| LocalVariableCouldBeFinal | Local variable 'a' could be declared final | 3 | 269 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 308–316 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 309 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 310 |
| CognitiveComplexity | The method 'processMethods(Object, ServiceManager, Class<?>, boolean)' has a cognitive complexity of 22, current threshold is 15 | 3 | 328 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 328 |
| MethodArgumentCouldBeFinal | Parameter 'clazz' is not assigned and could be declared final | 3 | 328 |
| MethodArgumentCouldBeFinal | Parameter 'isTurbineService' is not assigned and could be declared final | 3 | 328 |
| LocalVariableCouldBeFinal | Local variable 'methods' could be declared final | 3 | 329 |
| LocalVariableCouldBeFinal | Local variable 'method' could be declared final | 3 | 331 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 3 | 333 |
| LocalVariableCouldBeFinal | Local variable 'a' could be declared final | 3 | 334 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'manager' | 2 | 341 |
| LocalVariableCouldBeFinal | Local variable 'classes' could be declared final | 3 | 352 |
| LocalVariableCouldBeFinal | Local variable 'c' could be declared final | 3 | 353 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 356 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 357 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 377 |
| MethodArgumentCouldBeFinal | Parameter 'assembler' is not assigned and could be declared final | 3 | 377 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 3 | 377 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 3 | 377 |
| LocalVariableCouldBeFinal | Local variable 'loader' could be declared final | 3 | 379 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 380 |
| AvoidDuplicateLiterals | The String literal "Injection of {} into object {}" appears 5 times in this file; the first occurrence is on line 384 | 3 | 384 |
| AvoidDuplicateLiterals | The String literal " into object " appears 6 times in this file; the first occurrence is on line 391 | 3 | 391 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 406 |
| MethodArgumentCouldBeFinal | Parameter 'pool' is not assigned and could be declared final | 3 | 406 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 3 | 406 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 3 | 406 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 415 |
| NcssCount | The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a NCSS line count of 81. | 3 | 438 |
| CognitiveComplexity | The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a cognitive complexity of 19, current threshold is 15 | 3 | 438 |
| CyclomaticComplexity | The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a cyclomatic complexity of 17. | 3 | 438 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 438 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 3 | 438 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 3 | 438 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 3 | 438 |
| LocalVariableCouldBeFinal | Local variable 'type' could be declared final | 3 | 440 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 441 |
| LongVariable | Avoid excessively long variable names like injectConfiguration | 3 | 447 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 460 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 467 |
| AvoidDuplicateLiterals | The String literal "Injection of key {} into object {}" appears 10 times in this file; the first occurrence is on line 468 | 3 | 468 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 470 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 475 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 478 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 483 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 486 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 491 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 494 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 499 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 502 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 507 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 510 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 515 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 518 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 523 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 526 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 531 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 534 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 3 | 539 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 542 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 550 |
| LocalVariableCouldBeFinal | Local variable 'defaultValue' could be declared final | 3 | 551 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 554 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 574 |
| MethodArgumentCouldBeFinal | Parameter 'manager' is not assigned and could be declared final | 3 | 574 |
| MethodArgumentCouldBeFinal | Parameter 'field' is not assigned and could be declared final | 3 | 574 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 3 | 574 |
| LocalVariableCouldBeFinal | Local variable 'typeFields' could be declared final | 3 | 586 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 589 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 591 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 592 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 605 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 606 |
| CyclomaticComplexity | The method 'injectTurbineService(Object, ServiceManager, Method, TurbineService)' has a cyclomatic complexity of 10. | 3 | 630 |
| MethodArgumentCouldBeFinal | Parameter 'object' is not assigned and could be declared final | 3 | 630 |
| MethodArgumentCouldBeFinal | Parameter 'manager' is not assigned and could be declared final | 3 | 630 |
| MethodArgumentCouldBeFinal | Parameter 'method' is not assigned and could be declared final | 3 | 630 |
| MethodArgumentCouldBeFinal | Parameter 'annotation' is not assigned and could be declared final | 3 | 630 |
| LocalVariableCouldBeFinal | Local variable 'classes' could be declared final | 3 | 640 |
| LocalVariableCouldBeFinal | Local variable 'c' could be declared final | 3 | 641 |
| LocalVariableCouldBeFinal | Local variable 'fields' could be declared final | 3 | 643 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 647 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 649 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 650 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 664 |
| AvoidAccessibilityAlteration | You should not modify visibility of constructors, methods or fields using setAccessible() | 3 | 665 |
| LocalVariableCouldBeFinal | Local variable 'paramValues' could be declared final | 3 | 671 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 682 |
| MethodArgumentCouldBeFinal | Parameter 'fields' is not assigned and could be declared final | 3 | 682 |
| ControlStatementBraces | This statement should have braces | 3 | 683–707 |
| LocalVariableCouldBeFinal | Local variable 'f' could be declared final | 3 | 683 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'serviceName' | 2 | 688 |
org/apache/turbine/annotation/TurbineService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 47 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 52 |
org/apache/turbine/modules/Action.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 3 | 41 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 53 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 62 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 62 |
org/apache/turbine/modules/ActionEvent.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 87 |
| LongVariable | Avoid excessively long variable names like METHOD_NAME_PREFIX | 3 | 99 |
| LongVariable | Avoid excessively long variable names like METHOD_NAME_LENGTH | 3 | 101 |
| ImmutableField | Field 'submitValueKey' may be declared final | 3 | 110 |
| ImmutableField | Field 'methodCache' may be declared final | 3 | 123 |
| CognitiveComplexity | The method 'getMethod(String, Class<?>[], ParameterParser)' has a cognitive complexity of 21, current threshold is 15 | 3 | 135 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 135 |
| MethodArgumentCouldBeFinal | Parameter 'signature' is not assigned and could be declared final | 3 | 135 |
| ShortVariable | Avoid variables with short names like pp | 3 | 135 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 135 |
| LocalVariableCouldBeFinal | Local variable 'cacheKey' could be declared final | 3 | 137 |
| LocalVariableCouldBeFinal | Local variable 'methods' could be declared final | 3 | 147 |
| LocalVariableCouldBeFinal | Local variable 'm' could be declared final | 3 | 150 |
| LocalVariableCouldBeFinal | Local variable 'annotations' could be declared final | 3 | 152 |
| LocalVariableCouldBeFinal | Local variable 'a' could be declared final | 3 | 153 |
| LocalVariableCouldBeFinal | Local variable 'tae' could be declared final | 3 | 157 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 158–163 |
| LocalVariableCouldBeFinal | Local variable 'tmp' could be declared final | 3 | 171 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 171 |
| LocalVariableCouldBeFinal | Local variable 'oldMethod' could be declared final | 3 | 175 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 194 |
| ShortVariable | Avoid variables with short names like pp | 3 | 197 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 3 | 197 |
| CognitiveComplexity | The method 'executeEvents(ParameterParser, Class<?>[], Object[])' has a cognitive complexity of 17, current threshold is 15 | 3 | 210 |
| CyclomaticComplexity | The method 'executeEvents(ParameterParser, Class<?>[], Object[])' has a cyclomatic complexity of 12. | 3 | 210 |
| ShortVariable | Avoid variables with short names like pp | 3 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'signature' is not assigned and could be declared final | 3 | 210 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'parameters' is not assigned and could be declared final | 3 | 210 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 211 |
| LocalVariableCouldBeFinal | Local variable 'button' could be declared final | 3 | 216 |
| LocalVariableCouldBeFinal | Local variable 'k' could be declared final | 3 | 220 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 225–229 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 236 |
| UnusedAssignment | The initializer for variable 'method' is never used (overwritten on lines 244 and 248) | 3 | 240 |
| ShortVariable | Avoid variables with short names like t | 3 | 266 |
| LocalVariableCouldBeFinal | Local variable 't' could be declared final | 3 | 266 |
| MethodArgumentCouldBeFinal | Parameter 'input' is not assigned and could be declared final | 3 | 293 |
| ShortVariable | Avoid variables with short names like pp | 3 | 293 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 293 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 299 |
| LocalVariableCouldBeFinal | Local variable 'methodName' could be declared final | 3 | 302 |
| LawOfDemeter | Call to `getUrlFolding` on foreign value `pp` (degree 1) | 3 | 306 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 312 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 327 |
| ShortVariable | Avoid variables with short names like pp | 3 | 327 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 327 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 329–369 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 332 |
| LocalVariableCouldBeFinal | Local variable 'keyValue' could be declared final | 3 | 345 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 350 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 358 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 366 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 367 |
org/apache/turbine/modules/ActionLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 59 |
org/apache/turbine/modules/GenericLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like ab | 3 | 45 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'reload' | 3 | 54 |
| AvoidFieldNameMatchingMethodName | Field reload has the same name as a method | 3 | 54 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'TURBINE_PACKAGES' | 3 | 60 |
| FieldNamingConventions | The static field name 'TURBINE_PACKAGES' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 60 |
| MethodArgumentCouldBeFinal | Parameter 'assemblerClass' is not assigned and could be declared final | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'cacheSizeSupplier' is not assigned and could be declared final | 3 | 68 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 85 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReload' should not return any type except void linguistically | 3 | 109 |
| MethodArgumentCouldBeFinal | Parameter 'reload' is not assigned and could be declared final | 3 | 109 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 134–140 |
| LocalVariableCouldBeFinal | Local variable 'turbinePackages' could be declared final | 3 | 136 |
| LocalVariableCouldBeFinal | Local variable 'packages' could be declared final | 3 | 142 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 161 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 176 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 176 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 177 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 194 |
| LocalVariableCouldBeFinal | Local variable 'packages' could be declared final | 3 | 203 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenericLoader': 'getPackages' is already in scope | 4 | 203 |
org/apache/turbine/modules/Layout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 3 | 41 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 61 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 61 |
org/apache/turbine/modules/LayoutLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 59 |
org/apache/turbine/modules/Loader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 37 |
org/apache/turbine/modules/Navigation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 3 | 42 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 67 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 68 |
org/apache/turbine/modules/NavigationLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 63 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 63 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 78 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 78 |
org/apache/turbine/modules/Page.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like Page | 4 | 33 |
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 3 | 42 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 54 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 63 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 64 |
org/apache/turbine/modules/PageLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 59 |
org/apache/turbine/modules/ScheduledJob.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 3 | 47 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 58 |
org/apache/turbine/modules/ScheduledJobLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'job' is not assigned and could be declared final | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 59 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 60 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 86 |
org/apache/turbine/modules/Screen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like CACHE_SIZE_DEFAULT | 3 | 45 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 69 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 70 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 89 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 91 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 101 |
| MethodArgumentCouldBeFinal | Parameter 'layout' is not assigned and could be declared final | 3 | 101 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 103 |
org/apache/turbine/modules/ScreenLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 65 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 65 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 66 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 82 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 82 |
org/apache/turbine/modules/actions/AccessController.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 71 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 91 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 95 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 3 | 98 |
| LawOfDemeter | Call to `getAttribute` on foreign value `data.getSession()` (degree 2) | 3 | 102–103 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 102 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 108 |
org/apache/turbine/modules/actions/DefaultAction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 45 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 48 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 48 |
org/apache/turbine/modules/actions/InitContextsAction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 44 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 60 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 63 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 63 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 71 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 71 |
| LocalVariableCouldBeFinal | Local variable 'contextPropsList' could be declared final | 3 | 71 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 71 |
| LocalVariableCouldBeFinal | Local variable 'contextKeys' could be declared final | 3 | 72 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 74 |
| LocalVariableCouldBeFinal | Local variable 'start' could be declared final | 3 | 75 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 75 |
| LocalVariableCouldBeFinal | Local variable 'end' could be declared final | 3 | 76 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 76 |
| LocalVariableCouldBeFinal | Local variable 'contextName' could be declared final | 3 | 77 |
| UnusedAssignment | The initializer for variable 'contextProps' is never used (overwritten on lines 81 and 85) | 3 | 78 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 85 |
| LocalVariableCouldBeFinal | Local variable 'contextProps' could be declared final | 3 | 91 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 93 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 93 |
org/apache/turbine/modules/actions/LegacyVelocityAction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 56 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 56 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 71 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 79 |
| ShortVariable | Avoid variables with short names like pp | 3 | 80 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 3 | 80 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 81 |
org/apache/turbine/modules/actions/LegacyVelocitySecureAction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 41 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 51 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 68 |
org/apache/turbine/modules/actions/LoginUser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 48 |
| ImmutableField | Field 'loginError' may be declared final | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 85 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 88 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 88 |
| LocalVariableCouldBeFinal | Local variable 'username' could be declared final | 3 | 89 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 89 |
| LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 3 | 90 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 90 |
| LawOfDemeter | Call to `getAnonymousUser` on foreign value `security` (degree 1) | 3 | 99 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 105 |
| ExceptionAsFlowControl | Exception thrown at line 101 is caught in this block. | 3 | 132–154 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 132 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 3 | 134 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 3 | 142 |
org/apache/turbine/modules/actions/LogoutUser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 41 |
| ImmutableField | Field 'actionLogout' may be declared final | 3 | 51 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 75 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 78 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 78 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 81 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 3 | 86 |
| LawOfDemeter | Call to `setHasLoggedIn` on foreign value `user` (degree 2) | 3 | 91 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 3 | 102 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 109 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 118 |
org/apache/turbine/modules/actions/VelocityAction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 70 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 76 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 92 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 92 |
org/apache/turbine/modules/actions/VelocitySecureAction.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 52 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 69 |
org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 57 |
| LongVariable | Avoid excessively long variable names like loginMessageNoScreen | 3 | 70 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 84 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 87 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 87 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 3 | 95 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 101 |
org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 53 |
| LongVariable | Avoid excessively long variable names like templateInvalidState | 3 | 66 |
| LongVariable | Avoid excessively long variable names like screenInvalidState | 3 | 69 |
| CognitiveComplexity | The method 'handleFormCounterToken(RunData, boolean)' has a cognitive complexity of 20, current threshold is 15 | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'screenOnly' is not assigned and could be declared final | 3 | 79 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 81 |
| AvoidDuplicateLiterals | The String literal "_session_access_counter" appears 5 times in this file; the first occurrence is on line 81 | 3 | 81 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 85 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 3 | 86–87 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 3 | 86–87 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 86 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 89 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 90 |
| CollapsibleIfStatements | This if statement could be combined with its parent | 3 | 98–117 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 98 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 3 | 99–100 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 3 | 99–100 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 99 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 102–114 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 102 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 104 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 105 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 107 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 111 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 115 |
org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 56 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 84 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 87 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 87 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 3 | 95 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 101 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 114 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 125 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 129 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 141 |
org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 60 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 62 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 62 |
| LocalVariableCouldBeFinal | Local variable 'anonymousUser' could be declared final | 3 | 70 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 77 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 81 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 93 |
org/apache/turbine/modules/layouts/DirectResponseLayout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 37 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 46 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 49 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 49 |
org/apache/turbine/modules/layouts/JspLayout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 42 |
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 45 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 58 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 61 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 61 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 62 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 3 | 66 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 3 | 71 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 76 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 76 |
org/apache/turbine/modules/layouts/VelocityCachedLayout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 54 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 54 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 3 | 54 |
org/apache/turbine/modules/layouts/VelocityDirectLayout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 48 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 48 |
org/apache/turbine/modules/layouts/VelocityLayout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 43 |
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 49 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 63 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 66 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 66 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 68 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 76 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 76 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 79 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 80 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 108 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 108 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 3 | 108 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 109 |
org/apache/turbine/modules/layouts/VelocityOnlyLayout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 65 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 75 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 75 |
| LocalVariableCouldBeFinal | Local variable 'screenName' could be declared final | 3 | 77 |
| LocalVariableCouldBeFinal | Local variable 'results' could be declared final | 3 | 83 |
| LocalVariableCouldBeFinal | Local variable 'returnValue' could be declared final | 3 | 84 |
org/apache/turbine/modules/layouts/VelocityXslLayout.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 73 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 76 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 76 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 78 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 80 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 88 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 88 |
| LocalVariableCouldBeFinal | Local variable 'temp' could be declared final | 3 | 93 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 99 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 100 |
org/apache/turbine/modules/navigations/BaseJspNavigation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 42 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 69 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 72 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 72 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 74 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 74 |
org/apache/turbine/modules/navigations/LegacyVelocityNavigation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 35 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 48 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 57 |
org/apache/turbine/modules/navigations/TemplateNavigation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 34 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 44 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 62 |
org/apache/turbine/modules/navigations/VelocityNavigation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 44 |
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 48 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 69 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 83 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 97 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 100 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 100 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 101 |
| LongVariable | Avoid excessively long variable names like navigationTemplate | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'navigationTemplate' could be declared final | 3 | 103 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 104 |
org/apache/turbine/modules/pages/DefaultPage.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 92 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 116 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 119 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 119 |
| LocalVariableCouldBeFinal | Local variable 'screenName' could be declared final | 3 | 141 |
| LocalVariableCouldBeFinal | Local variable 'aScreen' could be declared final | 3 | 149 |
| LocalVariableCouldBeFinal | Local variable 'layout' could be declared final | 3 | 150 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 177 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 190 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 203 |
org/apache/turbine/modules/pages/JspPage.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 51 |
| LocalVariableCouldBeFinal | Local variable 'response' could be declared final | 3 | 58 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 62–66 |
org/apache/turbine/modules/pages/TemplatePage.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 82 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 97 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 100 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 100 |
| LocalVariableCouldBeFinal | Local variable 'template' could be declared final | 3 | 110 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 110 |
| LocalVariableCouldBeFinal | Local variable 'layoutTemplate' could be declared final | 3 | 113 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 115 |
| LocalVariableCouldBeFinal | Local variable 'screen' could be declared final | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'errMsg' could be declared final | 3 | 121 |
org/apache/turbine/modules/pages/VelocityPage.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 54 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 57 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 57 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 58 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 68 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 71 |
org/apache/turbine/modules/screens/BaseJspScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 39 |
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 43 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 61 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 64 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 64 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 3 | 65 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 65 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 67 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 73 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 74 |
org/apache/turbine/modules/screens/JSONScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 82 |
| LongVariable | Avoid excessively long variable names like JSONRPC_CONTENT_TYPE | 3 | 84 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 109 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 111 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 111 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 3 | 113 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 3 | 116 |
| ShortVariable | Avoid variables with short names like in | 3 | 117 |
| CloseResource | Ensure that resources like this BufferedReader object are closed after use | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'in' could be declared final | 3 | 117 |
| LawOfDemeter | Call to `getInputStream` on foreign value `request` (degree 2) | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'cdata' could be declared final | 3 | 120 |
| LocalVariableCouldBeFinal | Local variable 'buf' could be declared final | 3 | 121 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 123 |
| LocalVariableCouldBeFinal | Local variable 'json_bridge' could be declared final | 3 | 130 |
| LocalVariableNamingConventions | The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 130 |
| LocalVariableCouldBeFinal | Local variable 'json_res' could be declared final | 3 | 133 |
| LocalVariableNamingConventions | The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 133 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 137 |
org/apache/turbine/modules/screens/JSONSecureScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 77 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 87 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 103 |
org/apache/turbine/modules/screens/JspErrorScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 34 |
| ImmutableField | Field 'templateError' may be declared final | 3 | 38 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 45 |
org/apache/turbine/modules/screens/LegacyVelocityScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 33 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 60 |
org/apache/turbine/modules/screens/LegacyVelocitySecureScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 34 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 56 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 76 |
org/apache/turbine/modules/screens/PlainJSONScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 72 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'log' | 3 | 78 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 78 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 101 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 3 | 105 |
| LocalVariableCouldBeFinal | Local variable 'json_res' could be declared final | 3 | 107 |
| LocalVariableNamingConventions | The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 107 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 112 |
| StringToString | Avoid calling toString() on String objects; this is unnecessary. | 3 | 114 |
org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 32 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 43 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 60 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 60 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 61 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 61 |
| LocalVariableCouldBeFinal | Local variable 'methods' could be declared final | 3 | 62 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 65 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 3 | 70 |
org/apache/turbine/modules/screens/RawScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 45 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 56 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 59 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 59 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 60 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 83 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 92 |
org/apache/turbine/modules/screens/TemplateScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 52 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 72 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 83 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 92 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 106 |
| UnusedAssignment | The initializer for variable 'out' is never used (overwritten on line 114) | 3 | 109 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 135 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 135 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 137 |
| ShortVariable | Avoid variables with short names like ti | 3 | 138 |
| LocalVariableCouldBeFinal | Local variable 'ti' could be declared final | 3 | 138 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 138 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 139 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 148–151 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 148 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 173 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 173 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 173 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 174 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 199 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 199 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 200 |
org/apache/turbine/modules/screens/VelocityCachedScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 50 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 53 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 53 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 54 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 3 | 56 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 56 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 57 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 63 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 64 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 71 |
org/apache/turbine/modules/screens/VelocityDirectScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 40 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 51 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 54 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 54 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 55 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 3 | 57 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 57 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 58 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 64 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 65 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 72 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 75 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 84 |
org/apache/turbine/modules/screens/VelocityErrorScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 47 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 47 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 50 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 50 |
| LawOfDemeter | Call to `getStackTraceException` on foreign value `data` (degree 1) | 3 | 52 |
org/apache/turbine/modules/screens/VelocityScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 48 |
| FieldNamingConventions | The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 52 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 76 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 90 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 104 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 107 |
| PrematureDeclaration | Declaration of 'screenData' can be moved closer to its usages | 3 | 108 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 110 |
| LocalVariableCouldBeFinal | Local variable 'screenTemplate' could be declared final | 3 | 112 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 112 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 113 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 119 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 120 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 131 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 139 |
org/apache/turbine/modules/screens/VelocitySecureScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 41 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 64 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 84 |
org/apache/turbine/modules/screens/error/InvalidState.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 55 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 58 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 58 |
| LocalVariableCouldBeFinal | Local variable 'body' could be declared final | 3 | 59 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 62 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 65 characters appended. | 3 | 62 |
| ShortVariable | Avoid variables with short names like sb | 3 | 63 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 63 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 166 characters appended. | 3 | 63 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 7 consecutive times with literals. Use a single append with a single combined String. | 3 | 64 |
| ShortVariable | Avoid variables with short names like pp | 3 | 73 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 3 | 73 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 3 | 74 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 74 |
| LocalVariableCouldBeFinal | Local variable 'back' could be declared final | 3 | 77 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 3 | 77 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 77 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 79 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 79 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 82 |
org/apache/turbine/om/OMTool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Field 'pullMap' may be declared final | 3 | 49 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 62 |
| LocalVariableCouldBeFinal | Local variable 'className' could be declared final | 3 | 65 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'omName' | 3 | 95 |
| MethodArgumentCouldBeFinal | Parameter 'omName' is not assigned and could be declared final | 3 | 97 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically | 3 | 102 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 102 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 103 |
| ShortVariable | Avoid variables with short names like om | 3 | 105 |
| UnusedAssignment | The initializer for variable 'om' is never used (overwritten on lines 110 and 114) | 3 | 105 |
| LocalVariableCouldBeFinal | Local variable 'inputKey' could be declared final | 3 | 106 |
| MethodArgumentCouldBeFinal | Parameter 'omName' is not assigned and could be declared final | 3 | 128 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 128 |
| ShortVariable | Avoid variables with short names like ph | 3 | 130 |
| LocalVariableCouldBeFinal | Local variable 'ph' could be declared final | 3 | 130 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 133 |
| MethodArgumentCouldBeFinal | Parameter 'omName' is not assigned and could be declared final | 3 | 146 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 146 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 146 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 153 |
org/apache/turbine/om/Retrievable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 52 |
org/apache/turbine/om/Retriever.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 44 |
org/apache/turbine/om/RetrieverFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 43 |
org/apache/turbine/om/security/DefaultUserImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=67, ATFD=17, TCC=15.137%) | 3 | 44 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 44 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 45–758 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'lastAccessDate' | 3 | 50 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'permStorage' | 3 | 53 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'tempStorage' | 3 | 56 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'userDelegate' | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 66 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultUserImpl.setCreateDate(Date) | 1 | 70 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultUserImpl.setHasLoggedIn(Boolean) | 1 | 72 |
| LocalVariableCouldBeFinal | Local variable 'securityService' could be declared final | 3 | 100 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 106 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 135 |
| ShortVariable | Avoid variables with short names like id | 3 | 158 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 3 | 158 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 189 |
| MethodArgumentCouldBeFinal | Parameter 'firstName' is not assigned and could be declared final | 3 | 211 |
| MethodArgumentCouldBeFinal | Parameter 'lastName' is not assigned and could be declared final | 3 | 233 |
| MethodArgumentCouldBeFinal | Parameter 'address' is not assigned and could be declared final | 3 | 255 |
| MethodArgumentCouldBeFinal | Parameter 'objectdata' is not assigned and could be declared final | 3 | 280 |
| MethodArgumentCouldBeFinal | Parameter 'userGroupRoleSet' is not assigned and could be declared final | 3 | 305 |
| MethodArgumentCouldBeFinal | Parameter 'userGroupRole' is not assigned and could be declared final | 3 | 319 |
| MethodArgumentCouldBeFinal | Parameter 'userGroupRole' is not assigned and could be declared final | 3 | 333 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 348 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 3 | 348 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 4 | 348 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 350 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 366 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 3 | 366 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'SESSION_ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 4 | 366 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 368 |
| MethodArgumentCouldBeFinal | Parameter 'cnt' is not assigned and could be declared final | 3 | 399 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 4 | 401 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 401 |
| MethodArgumentCouldBeFinal | Parameter 'cnt' is not assigned and could be declared final | 3 | 411 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'SESSION_ACCESS_COUNTER' is already in scope because it is inherited by an enclosing type | 4 | 413 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 413 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 449 |
| LocalVariableCouldBeFinal | Local variable 'objectdata' could be declared final | 3 | 453 |
| MethodArgumentCouldBeFinal | Parameter 'permStorage' is not assigned and could be declared final | 3 | 476 |
| MethodArgumentCouldBeFinal | Parameter 'tempStorage' is not assigned and could be declared final | 3 | 507 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 522 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 536 |
| MethodArgumentCouldBeFinal | Parameter 'def' is not assigned and could be declared final | 3 | 536 |
| LocalVariableCouldBeFinal | Local variable 'val' could be declared final | 3 | 540 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 541 |
| UselessParentheses | Useless parentheses. | 4 | 541 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 543 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 556 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 556 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 568 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 582 |
| MethodArgumentCouldBeFinal | Parameter 'def' is not assigned and could be declared final | 3 | 582 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 593 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 607 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 607 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 619 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'CONFIRM_VALUE' is already in scope because it is inherited by an enclosing type | 4 | 632 |
| MethodArgumentCouldBeFinal | Parameter 'confirm' is not assigned and could be declared final | 3 | 641 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'CONFIRM_VALUE' is already in scope because it is inherited by an enclosing type | 4 | 643 |
| MethodArgumentCouldBeFinal | Parameter 'createDate' is not assigned and could be declared final | 3 | 663 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'LAST_LOGIN' is already in scope because it is inherited by an enclosing type | 4 | 676 |
| MethodArgumentCouldBeFinal | Parameter 'lastLogin' is not assigned and could be declared final | 3 | 685 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'LAST_LOGIN' is already in scope because it is inherited by an enclosing type | 4 | 687 |
| LocalVariableCouldBeFinal | Local variable 'loggedIn' could be declared final | 3 | 698 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'HAS_LOGGED_IN' is already in scope because it is inherited by an enclosing type | 4 | 698 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 3 | 699 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 709 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'HAS_LOGGED_IN' is already in scope because it is inherited by an enclosing type | 4 | 711 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 725 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 726 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'User': 'CONFIRM_DATA' is already in scope because it is inherited by an enclosing type | 4 | 726 |
| MethodArgumentCouldBeFinal | Parameter 'userDelegate' is not assigned and could be declared final | 3 | 754 |
org/apache/turbine/om/security/User.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like User | 4 | 41 |
| LongVariable | Avoid excessively long variable names like SESSION_ACCESS_COUNTER | 3 | 60 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 288 |
org/apache/turbine/pipeline/CleanUpValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 49 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 58 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 58 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 65 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 79 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 81 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 81 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 88 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 91–95 |
| LongVariable | Avoid excessively long variable names like invalidatedSession | 3 | 91 |
org/apache/turbine/pipeline/DefaultACLCreationValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 41 |
| LongVariable | Avoid excessively long variable names like actionAccessController | 3 | 49 |
| ImmutableField | Field 'actionAccessController' may be declared final | 3 | 49 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 55 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 67 |
org/apache/turbine/pipeline/DefaultLoginValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 50 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 67 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 67 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 74 |
| CognitiveComplexity | The method 'process(PipelineData)' has a cognitive complexity of 21, current threshold is 15 | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 91 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 92 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'actionName' could be declared final | 3 | 100 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 3 | 118 |
| LawOfDemeter | Call to `getAttributeNames` on foreign value `data.getSession()` (degree 2) | 3 | 118 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 118 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 119–141 |
| LocalVariableCouldBeFinal | Local variable 'nameList' could be declared final | 3 | 123 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 3 | 129 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 129 |
| LocalVariableCouldBeFinal | Local variable 'name' could be declared final | 3 | 130 |
| LongVariable | Avoid excessively long variable names like invalidatedSession | 3 | 136 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 155 |
| ShortVariable | Avoid variables with short names like ti | 3 | 160 |
| LocalVariableCouldBeFinal | Local variable 'ti' could be declared final | 3 | 160 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 160 |
org/apache/turbine/pipeline/DefaultPipelineData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 44 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 46–47 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 56 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 56 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 82 |
| MethodArgumentCouldBeFinal | Parameter 'innerKey' is not assigned and could be declared final | 3 | 82 |
| LocalVariableCouldBeFinal | Local variable 'innerMap' could be declared final | 3 | 84 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 87 |
| LocalVariableCouldBeFinal | Local variable 'rds' could be declared final | 3 | 98 |
org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 43 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 53 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 53 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 56 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 3 | 56 |
| LawOfDemeter | Call to `getSession` on foreign value `runData` (degree 1) | 3 | 59 |
| LawOfDemeter | Call to `getSession` on foreign value `runData` (degree 1) | 3 | 61 |
org/apache/turbine/pipeline/DefaultSessionValidationValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 41 |
| LongVariable | Avoid excessively long variable names like actionSessionValidator | 3 | 49 |
| ImmutableField | Field 'actionSessionValidator' may be declared final | 3 | 49 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 55 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 70 |
org/apache/turbine/pipeline/DefaultSetEncodingValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 47 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 50 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 56 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 56 |
| LocalVariableCouldBeFinal | Local variable 'req' could be declared final | 3 | 59 |
org/apache/turbine/pipeline/DetermineActionValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'java.util.regex.Matcher' | 4 | 25 |
| UnnecessaryImport | Unused import 'java.util.regex.Pattern' | 4 | 26 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 43 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 46 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 53 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 53 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 56 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 56 |
| LocalVariableCouldBeFinal | Local variable 'action' could be declared final | 3 | 59 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 60 |
| LocalVariableCouldBeFinal | Local variable 'testAction' could be declared final | 3 | 66 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 67 |
org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 43 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 48 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 73 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 76 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 76 |
| LocalVariableCouldBeFinal | Local variable 'requestRedirected' could be declared final | 3 | 78 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 81 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 83 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 87 |
org/apache/turbine/pipeline/DetermineTargetValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 45 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 47 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 54 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 54 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 57 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 3 | 57 |
| LocalVariableCouldBeFinal | Local variable 'target' could be declared final | 3 | 60 |
| LawOfDemeter | Call to `getParameters` on foreign value `runData` (degree 1) | 3 | 60 |
| LocalVariableCouldBeFinal | Local variable 'testAction' could be declared final | 3 | 66 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 67 |
org/apache/turbine/pipeline/ExecutePageValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 43 |
| ImmutableField | Field 'pageDefault' may be declared final | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 61 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 61 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 84 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 85 |
org/apache/turbine/pipeline/Pipeline.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 60 |
org/apache/turbine/pipeline/TurbinePipeline.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 48 |
| LooseCoupling | Avoid using implementation types like 'CopyOnWriteArrayList'; use the interface instead | 3 | 66 |
| ImmutableField | Field 'state' may be declared final | 3 | 71 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 3 | 84 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'valve' is not assigned and could be declared final | 3 | 116 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 139 |
| MethodArgumentCouldBeFinal | Parameter 'valves' is not assigned and could be declared final | 3 | 139 |
| MethodArgumentCouldBeFinal | Parameter 'valve' is not assigned and could be declared final | 3 | 148 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 157 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 171 |
| LocalVariableCouldBeFinal | Local variable 'current' could be declared final | 3 | 175 |
org/apache/turbine/pipeline/Valve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 100 |
org/apache/turbine/pipeline/XmlValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 34 |
| MethodArgumentCouldBeFinal | Parameter 'clazz' is not assigned and could be declared final | 3 | 54 |
org/apache/turbine/pipeline/XmlValveAdapter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 29 |
| MethodArgumentCouldBeFinal | Parameter 'xmlValve' is not assigned and could be declared final | 3 | 35 |
| LocalVariableCouldBeFinal | Local variable 'valveClass' could be declared final | 3 | 37 |
| MethodArgumentCouldBeFinal | Parameter 'valve' is not assigned and could be declared final | 3 | 45 |
| LocalVariableCouldBeFinal | Local variable 'xmlValve' could be declared final | 3 | 47 |
org/apache/turbine/services/BaseInitable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'isInitialized' | 3 | 41 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 50 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 3 | 61 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 137 |
org/apache/turbine/services/BaseInitableBroker.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 63 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 63 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 63 |
| LooseCoupling | Avoid using implementation types like 'Stack'; use the interface instead | 3 | 70 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 3 | 90 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 90 |
| LocalVariableCouldBeFinal | Local variable 'pos' could be declared final | 3 | 92 |
| LocalVariableCouldBeFinal | Local variable 'instance' could be declared final | 3 | 98 |
| LongVariable | Avoid excessively long variable names like instanceInitialized | 3 | 99 |
| LocalVariableCouldBeFinal | Local variable 'instanceInitialized' could be declared final | 3 | 99 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 3 | 117 |
| LongVariable | Avoid excessively long variable names like dependencyPosition | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'dependencyPosition' is not assigned and could be declared final | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 3 | 118 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 64 characters appended. | 3 | 118 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 3 | 141 |
| LocalVariableCouldBeFinal | Local variable 'initable' could be declared final | 3 | 145 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 3 | 174 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 175 |
| LocalVariableCouldBeFinal | Local variable 'initable' could be declared final | 3 | 177 |
| ExceptionAsFlowControl | Exception thrown at line 196 is caught in this block. | 3 | 204–208 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 3 | 225 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 226 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 3 | 237–240 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 241 |
| UnusedAssignment | The initializer for variable 'msg' is never used (overwritten on lines 248, 253, 258 and 263) | 3 | 244 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 3 | 246 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 3 | 251 |
| AvoidInstanceofChecksInCatchClause | An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. | 3 | 256 |
org/apache/turbine/services/BaseService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 37 |
| DataClass | The class 'BaseService' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=8) | 3 | 37 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 3 | 58 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 69 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 116 |
org/apache/turbine/services/BaseServiceBroker.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=84, ATFD=19, TCC=17.391%) | 3 | 59 |
| CyclomaticComplexity | The class 'BaseServiceBroker' has a total cyclomatic complexity of 84 (highest 16). | 3 | 59 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 60–785 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 64 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 3 | 69 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 3 | 106 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 109 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 3 | 120 |
| LongVariable | Avoid excessively long variable names like serviceProviderInstanceMap | 3 | 120 |
| MethodArgumentCouldBeFinal | Parameter 'configuration' is not assigned and could be declared final | 3 | 140 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 186 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 186 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 197 |
| MethodArgumentCouldBeFinal | Parameter 'checkIfc' is not assigned and could be declared final | 3 | 210 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'interfaces' is not assigned and could be declared final | 3 | 210 |
| LocalVariableCouldBeFinal | Local variable 'ifc' could be declared final | 3 | 212 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 216 |
| LocalVariableCouldBeFinal | Local variable 'subInterfaces' could be declared final | 3 | 219 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 222 |
| CognitiveComplexity | The method 'initMapping()' has a cognitive complexity of 24, current threshold is 15 | 3 | 246 |
| CyclomaticComplexity | The method 'initMapping()' has a cyclomatic complexity of 14. | 3 | 246 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 250 |
| LocalVariableCouldBeFinal | Local variable 'earlyInitFlags' could be declared final | 3 | 250 |
| LocalVariableCouldBeFinal | Local variable 'keys' could be declared final | 3 | 257 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 259 |
| LocalVariableCouldBeFinal | Local variable 'keyParts' could be declared final | 3 | 260 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 263 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 264 |
| LocalVariableCouldBeFinal | Local variable 'serviceKey' could be declared final | 3 | 266 |
| LocalVariableCouldBeFinal | Local variable 'className' could be declared final | 3 | 271 |
| LocalVariableCouldBeFinal | Local variable 'clazz' could be declared final | 3 | 274 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 278–282 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 3 | 285–288 |
| IdenticalCatchBranches | 'catch' branch identical to 'ThreadDeath' branch | 3 | 289–292 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 3 | 289–292 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 3 | 302 |
| MethodArgumentCouldBeFinal | Parameter 'serviceName' is not assigned and could be declared final | 3 | 316 |
| UselessParentheses | Useless parentheses. | 4 | 318 |
| MethodArgumentCouldBeFinal | Parameter 'prefix' is not assigned and could be declared final | 3 | 338 |
| LocalVariableCouldBeFinal | Local variable 'keys' could be declared final | 3 | 340 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 357 |
| LocalVariableCouldBeFinal | Local variable 'instance' could be declared final | 3 | 363 |
| MethodArgumentCouldBeFinal | Parameter 'report' is not assigned and could be declared final | 3 | 406 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 407 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 3 | 412 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 3 | 420 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 441 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 442 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 462 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 466 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 487–488 |
| UnusedAssignment | The initializer for variable 'serviceName' is never used (overwritten on lines 514 and 520) | 3 | 501 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 3 | 510 |
| LongVariable | Avoid excessively long variable names like reverseServicesList | 3 | 510 |
| LocalVariableCouldBeFinal | Local variable 'reverseServicesList' could be declared final | 3 | 510 |
| LocalVariableCouldBeFinal | Local variable 'serviceNames' could be declared final | 3 | 512 |
| LocalVariableCouldBeFinal | Local variable 's' could be declared final | 3 | 518 |
| CyclomaticComplexity | The method 'getService(String)' has a cyclomatic complexity of 10. | 3 | 535 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 535 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 535 |
| LocalVariableCouldBeFinal | Local variable 'service' could be declared final | 3 | 537 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 567 |
| ExceptionAsFlowControl | Exception thrown at line 564 is caught in this block. | 3 | 569–573 |
| CognitiveComplexity | The method 'getServiceInstance(String)' has a cognitive complexity of 28, current threshold is 15 | 3 | 607 |
| CyclomaticComplexity | The method 'getServiceInstance(String)' has a cyclomatic complexity of 16. | 3 | 607 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 607 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 608 |
| LocalVariableCouldBeFinal | Local variable 'clazz' could be declared final | 3 | 632 |
| LocalVariableCouldBeFinal | Local variable '_service' could be declared final | 3 | 642 |
| LocalVariableNamingConventions | The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 642 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 3 | 655–658 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 659 |
| ExceptionAsFlowControl | Exception thrown at line 652 is caught in this block. | 3 | 664–668 |
| ExceptionAsFlowControl | Exception thrown at line 661 is caught in this block. | 3 | 664–668 |
| LocalVariableCouldBeFinal | Local variable '_service' could be declared final | 3 | 671 |
| LocalVariableNamingConventions | The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 671 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 694 |
| MethodArgumentCouldBeFinal | Parameter 'applicationRoot' is not assigned and could be declared final | 3 | 704 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 728 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 742 |
| LongVariable | Avoid excessively long variable names like turbineServiceProvider | 3 | 744 |
| UnusedAssignment | The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 748) | 3 | 744 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 3 | 746 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 752 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 766 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 767 |
| LongVariable | Avoid excessively long variable names like turbineServiceProvider | 3 | 769 |
| UnusedAssignment | The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 773) | 3 | 769 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 3 | 771 |
org/apache/turbine/services/BaseUnicastRemoteService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 55 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 59 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 60 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 61 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 3 | 87 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 114 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 141 |
| MethodArgumentCouldBeFinal | Parameter 'broker' is not assigned and could be declared final | 3 | 162 |
org/apache/turbine/services/FieldAnnotatedTurbineBaseService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 37 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 56 |
org/apache/turbine/services/Initable.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 96 |
org/apache/turbine/services/InitableBroker.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 97 |
org/apache/turbine/services/InitializationException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 47 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 60 |
| ShortVariable | Avoid variables with short names like t | 3 | 60 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 3 | 60 |
org/apache/turbine/services/InstantiationException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 51 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 63 |
| ShortVariable | Avoid variables with short names like t | 3 | 63 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 3 | 63 |
org/apache/turbine/services/MethodAnnotatedTurbineBaseService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 34 |
org/apache/turbine/services/ServiceBroker.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 95 |
org/apache/turbine/services/ServiceManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'setServiceObject': the method is declared in an interface type | 3 | 79 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getServiceObject': the method is declared in an interface type | 3 | 87 |
org/apache/turbine/services/TurbineBaseService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 72 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 92 |
org/apache/turbine/services/TurbineServiceProvider.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 42 |
org/apache/turbine/services/TurbineServices.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 67 |
| MethodArgumentCouldBeFinal | Parameter 'manager' is not assigned and could be declared final | 3 | 67 |
| LocalVariableCouldBeFinal | Local variable 'previous' could be declared final | 3 | 69 |
org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'org.apache.turbine.util.uri.URIConstants' | 4 | 45 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 57 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'factories' | 3 | 66 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'assemblerCache' | 3 | 69 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'loaderCache' | 3 | 72 |
| AvoidDuplicateLiterals | The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 86 | 3 | 86 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 87 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 102 |
| LocalVariableCouldBeFinal | Local variable 'names' could be declared final | 3 | 105 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 107 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable 'name2' could be declared final | 3 | 109 |
| LocalVariableCouldBeFinal | Local variable 'factory' could be declared final | 3 | 111 |
| ShortVariable | Avoid variables with short names like af | 3 | 115 |
| LocalVariableCouldBeFinal | Local variable 'af' could be declared final | 3 | 115 |
| AvoidRethrowingException | A catch statement that catches an exception only to rethrow it should be avoided. | 3 | 120–123 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 126 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 148 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 3 | 150 |
| LocalVariableCouldBeFinal | Local variable 'type' could be declared final | 3 | 152 |
| LocalVariableCouldBeFinal | Local variable 'cacheSize' could be declared final | 3 | 172 |
| MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 192 |
| CognitiveComplexity | The method 'getAssembler(Class<T>, String)' has a cognitive complexity of 22, current threshold is 15 | 3 | 213 |
| CyclomaticComplexity | The method 'getAssembler(Class<T>, String)' has a cyclomatic complexity of 12. | 3 | 213 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 213 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 213 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 216 |
| PrematureDeclaration | Declaration of 'assembler' can be moved closer to its usages | 3 | 217 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 222 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 223 |
| LocalVariableCouldBeFinal | Local variable 'facs' could be declared final | 3 | 235 |
| LocalVariableCouldBeFinal | Local variable 'it' could be declared final | 3 | 237 |
| LocalVariableCouldBeFinal | Local variable 'fac' could be declared final | 3 | 239 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 245 |
| LocalVariableCouldBeFinal | Local variable 'oldAssembler' could be declared final | 3 | 259 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 260–263 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 283 |
| LocalVariableCouldBeFinal | Local variable 'facs' could be declared final | 3 | 295 |
| LocalVariableCouldBeFinal | Local variable 'it' could be declared final | 3 | 297 |
| LocalVariableCouldBeFinal | Local variable 'fac' could be declared final | 3 | 299 |
org/apache/turbine/services/assemblerbroker/util/java/JavaActionFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 44 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 3 | 57 |
| CognitiveComplexity | The method 'getAssembler(String, String)' has a cognitive complexity of 19, current threshold is 15 | 3 | 67 |
| MethodArgumentCouldBeFinal | Parameter 'packageName' is not assigned and could be declared final | 3 | 67 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 67 |
| LocalVariableCouldBeFinal | Local variable 'p' could be declared final | 3 | 75 |
| ShortVariable | Avoid variables with short names like sb | 3 | 77 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 77 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 77 |
| LocalVariableCouldBeFinal | Local variable 'className' could be declared final | 3 | 80 |
| LocalVariableCouldBeFinal | Local variable '_servClass' could be declared final | 3 | 90 |
| LocalVariableNamingConventions | The local variable name '_servClass' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 90 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 91–94 |
org/apache/turbine/services/assemblerbroker/util/java/JavaLayoutFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaNavigationFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaPageFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaScheduledJobFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 46 |
org/apache/turbine/services/assemblerbroker/util/java/JavaScreenFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 36 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 46 |
org/apache/turbine/services/assemblerbroker/util/python/PythonActionFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 48 |
| LongVariable | Avoid excessively long variable names like PYTHON_CONFIG_FILE | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'subDirectory' is not assigned and could be declared final | 3 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 71 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 72 |
| LocalVariableCouldBeFinal | Local variable 'path' could be declared final | 3 | 74 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 78 |
| LocalVariableCouldBeFinal | Local variable 'confName' could be declared final | 3 | 86 |
| LocalVariableCouldBeFinal | Local variable 'fName' could be declared final | 3 | 89 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 91 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 92 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 92 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 93 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 94 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 94 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 95 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 3 | 95 |
| ShortVariable | Avoid variables with short names like f | 3 | 98 |
| LocalVariableCouldBeFinal | Local variable 'f' could be declared final | 3 | 98 |
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 3 | 112 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 130 |
| PreserveStackTrace | Thrown exception does not preserve the stack trace of exception 'e' on all code paths | 3 | 132–138 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 132 |
| ShortVariable | Avoid variables with short names like t | 3 | 143 |
| LocalVariableCouldBeFinal | Local variable 't' could be declared final | 3 | 143 |
| ExceptionAsFlowControl | Exception thrown at line 132 is caught in this block. | 3 | 146–153 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 146 |
org/apache/turbine/services/assemblerbroker/util/python/PythonLayoutFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonNavigationFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonPageFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 49 |
org/apache/turbine/services/assemblerbroker/util/python/PythonScreenFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 49 |
org/apache/turbine/services/avaloncomponent/AvalonComponentService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 37 |
| LongVariable | Avoid excessively long variable names like AVALON_LOG_CATEGORY | 3 | 40 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 40 |
| LongVariable | Avoid excessively long variable names like COMPONENT_CONFIG_KEY | 3 | 43 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 43 |
| LongVariable | Avoid excessively long variable names like COMPONENT_CONFIG_VALUE | 3 | 46 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 46 |
| LongVariable | Avoid excessively long variable names like COMPONENT_ROLE_KEY | 3 | 49 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 49 |
| LongVariable | Avoid excessively long variable names like COMPONENT_ROLE_VALUE | 3 | 52 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 52 |
| LongVariable | Avoid excessively long variable names like COMPONENT_LOOKUP_KEY | 3 | 55 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 55 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 3 | 58 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 58 |
org/apache/turbine/services/avaloncomponent/TurbineYaafiComponentService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 44 |
| LongVariable | Avoid excessively long variable names like CONTAINER_CONFIGURATION_KEY | 3 | 52 |
| LongVariable | Avoid excessively long variable names like CONTAINER_CONFIGURATION_VALUE | 3 | 55 |
| LongVariable | Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY | 3 | 58 |
| LongVariable | Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE | 3 | 61 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 81 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 114 |
| LocalVariableCouldBeFinal | Local variable 'home' could be declared final | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 3 | 121 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 132 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 148 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 159 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 170 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 179 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 3 | 193 |
| MethodArgumentCouldBeFinal | Parameter 'applicationRoot' is not assigned and could be declared final | 3 | 193 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 196 |
| LongVariable | Avoid excessively long variable names like containerConfiguration | 3 | 207 |
| LocalVariableCouldBeFinal | Local variable 'containerConfiguration' could be declared final | 3 | 207 |
| LongVariable | Avoid excessively long variable names like roleConfigurationFileName | 3 | 217 |
| LocalVariableCouldBeFinal | Local variable 'roleConfigurationFileName' could be declared final | 3 | 217 |
| LongVariable | Avoid excessively long variable names like componentConfigurationFileName | 3 | 224 |
| LocalVariableCouldBeFinal | Local variable 'componentConfigurationFileName' could be declared final | 3 | 224 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 3 | 231 |
| LocalVariableCouldBeFinal | Local variable 'parametersFileName' could be declared final | 3 | 231 |
| LongVariable | Avoid excessively long variable names like containerConfiguration | 3 | 244 |
| LocalVariableCouldBeFinal | Local variable 'containerConfiguration' could be declared final | 3 | 244 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 272 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 281 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 281 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 3 | 287 |
| LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 3 | 289 |
org/apache/turbine/services/intake/IntakeTool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 54–551 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 56 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 65 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'groups' | 3 | 65 |
| ShortVariable | Avoid variables with short names like pp | 3 | 68 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 3 | 70 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 3 | 71 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 3 | 72 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pullMap' | 3 | 75 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 86 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'groupNames' could be declared final | 3 | 98 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 109 |
| LawOfDemeter | Call to `getParameters` on foreign value `(RunData) runData` (degree 1) | 3 | 113 |
| LocalVariableCouldBeFinal | Local variable 'groupKeys' could be declared final | 3 | 115 |
| UnusedAssignment | The initializer for variable 'groupNames' is never used (overwritten on lines 119 and 123) | 3 | 116 |
| LawOfDemeter | Access to field `length` on foreign value `groupKeys` (degree 2) | 3 | 123 |
| LawOfDemeter | Access to field `length` on foreign value `groupKeys` (degree 2) | 3 | 124 |
| LocalVariableCouldBeFinal | Local variable 'foundGroups' could be declared final | 3 | 134 |
| ShortVariable | Avoid variables with short names like vp | 3 | 155 |
| MethodArgumentCouldBeFinal | Parameter 'vp' is not assigned and could be declared final | 3 | 155 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 157 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 183 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 197 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 210 |
| ShortVariable | Avoid variables with short names like sb | 3 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'sb' is not assigned and could be declared final | 3 | 210 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 230 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'groupName' | 3 | 252 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 3 | 259 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically | 3 | 283 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 283 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically | 3 | 297 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 297 |
| MethodArgumentCouldBeFinal | Parameter 'create' is not assigned and could be declared final | 3 | 297 |
| ShortVariable | Avoid variables with short names like g | 3 | 300 |
| LocalVariableCouldBeFinal | Local variable 'inputKey' could be declared final | 3 | 302 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 323 |
| ShortVariable | Avoid variables with short names like g | 3 | 325 |
| UnusedAssignment | The initializer for variable 'g' is never used (overwritten on lines 333 and 337) | 3 | 325 |
| LocalVariableCouldBeFinal | Local variable 'inputKey' could be declared final | 3 | 329 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 341 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 3 | 357 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 3 | 370 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 384 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 3 | 398 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 398 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 3 | 413 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 413 |
| MethodArgumentCouldBeFinal | Parameter 'create' is not assigned and could be declared final | 3 | 413 |
| ShortVariable | Avoid variables with short names like ph | 3 | 425 |
| LocalVariableCouldBeFinal | Local variable 'ph' could be declared final | 3 | 425 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 435 |
| LocalVariableCouldBeFinal | Local variable 'groupKeys' could be declared final | 3 | 442 |
| LocalVariableCouldBeFinal | Local variable 'groupKey' could be declared final | 3 | 448 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 463 |
| LocalVariableCouldBeFinal | Local variable 'allGroups' could be declared final | 3 | 475 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 478 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 495 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 521 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 529–530 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 536 |
org/apache/turbine/services/jsonrpc/JSONProcessor.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 3 | 39 |
| MethodArgumentCouldBeFinal | Parameter 'cdata' is not assigned and could be declared final | 3 | 51 |
| MethodArgumentCouldBeFinal | Parameter 'json_bridge' is not assigned and could be declared final | 3 | 51 |
| FormalParameterNamingConventions | The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 51 |
| MethodArgumentCouldBeFinal | Parameter 'request' is not assigned and could be declared final | 3 | 51 |
| LocalVariableNamingConventions | The local variable name 'json_req' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 54 |
| UnusedAssignment | The initializer for variable 'json_req' is never used (overwritten on line 58) | 3 | 54 |
| LocalVariableNamingConventions | The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 55 |
| UnusedAssignment | The initializer for variable 'json_res' is never used (overwritten on lines 75 and 80) | 3 | 55 |
| LocalVariableCouldBeFinal | Local variable 'methodName' could be declared final | 3 | 61 |
| LocalVariableCouldBeFinal | Local variable 'arguments' could be declared final | 3 | 62 |
| LocalVariableCouldBeFinal | Local variable 'object_id' could be declared final | 3 | 65 |
| LocalVariableNamingConventions | The local variable name 'object_id' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 65 |
| ShortVariable | Avoid variables with short names like sb | 3 | 66 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 66 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 69 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 71 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 71 |
| InvalidLogMessageFormat | Too many arguments, expected 0 argument but found 1 | 5 | 83 |
org/apache/turbine/services/jsonrpc/JsonRpcService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 51 |
org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 37 |
| MethodArgumentCouldBeFinal | Parameter 'cdata' is not assigned and could be declared final | 3 | 45 |
| MethodArgumentCouldBeFinal | Parameter 'json_bridge' is not assigned and could be declared final | 3 | 46 |
| FormalParameterNamingConventions | The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 46 |
| MethodArgumentCouldBeFinal | Parameter 'request' is not assigned and could be declared final | 3 | 46 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 58 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 58 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 58 |
| LocalVariableCouldBeFinal | Local variable 'json_bridge' could be declared final | 3 | 60 |
| LocalVariableNamingConventions | The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 60 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 65 |
| LocalVariableNamingConventions | The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 67 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 77 |
org/apache/turbine/services/jsp/JspService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like BUFFER_SIZE_DEFAULT | 3 | 56 |
org/apache/turbine/services/jsp/TurbineJspService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 53 |
| LongVariable | Avoid excessively long variable names like relativeTemplatePaths | 3 | 61 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JspService': 'JSP_EXTENSION' is already in scope because it is inherited by an enclosing type | 4 | 84 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 87 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 101 |
| LocalVariableCouldBeFinal | Local variable 'req' could be declared final | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'templateLink' could be declared final | 3 | 110 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 138 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 3 | 138 |
| MethodArgumentCouldBeFinal | Parameter 'isForward' is not assigned and could be declared final | 3 | 138 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 143 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 146 |
| LongVariable | Avoid excessively long variable names like relativeTemplateName | 3 | 149 |
| LocalVariableCouldBeFinal | Local variable 'relativeTemplateName' could be declared final | 3 | 149 |
| LocalVariableCouldBeFinal | Local variable 'dispatcher' could be declared final | 3 | 158 |
| LawOfDemeter | Call to `getRequestDispatcher` on foreign value `data.getServletContext()` (degree 2) | 3 | 158–159 |
| LawOfDemeter | Call to `getServletContext` on foreign value `data` (degree 1) | 3 | 158 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 170 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 175 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 180 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 182 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 205 |
| MethodArgumentCouldBeFinal | Parameter 'templateName' is not assigned and could be declared final | 3 | 205 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 215 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 3 | 217 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JspService': 'BUFFER_SIZE_KEY' is already in scope because it is inherited by an enclosing type | 4 | 232 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JspService': 'BUFFER_SIZE_DEFAULT' is already in scope because it is inherited by an enclosing type | 4 | 233 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 244 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 258 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 258 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 273 |
| LocalVariableCouldBeFinal | Local variable 'relativeTemplate' could be declared final | 3 | 275 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 284 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 296 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 301 |
org/apache/turbine/services/jsp/util/JspNavigation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 60 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 69 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 71 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 75 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 81 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 86 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 88–91 |
org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 64 |
| LocalVariableCouldBeFinal | Local variable 'abs' could be declared final | 3 | 67 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 81 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 82 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 86 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 88 |
| LawOfDemeter | Call to `getResponse` on foreign value `data` (degree 1) | 3 | 93 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 95–98 |
org/apache/turbine/services/localization/DateTimeFormatterInterface.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like DATE_TIME_FORMAT_KEY | 3 | 33 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_KEY': the field is declared in an interface type | 3 | 33 |
| LongVariable | Avoid excessively long variable names like DATE_TIME_ZONEID_KEY | 3 | 35 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'DATE_TIME_ZONEID_KEY': the field is declared in an interface type | 3 | 35 |
| LongVariable | Avoid excessively long variable names like USE_TURBINE_LOCALE_KEY | 3 | 37 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'USE_TURBINE_LOCALE_KEY': the field is declared in an interface type | 3 | 37 |
| LongVariable | Avoid excessively long variable names like USE_REQUEST_LOCALE_KEY | 3 | 39 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'USE_REQUEST_LOCALE_KEY': the field is declared in an interface type | 3 | 39 |
| LongVariable | Avoid excessively long variable names like DATE_TIME_FORMAT_DEFAULT | 3 | 42 |
| UnnecessaryModifier | Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_DEFAULT': the field is declared in an interface type | 3 | 42 |
org/apache/turbine/services/localization/DateTimeFormatterService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 49 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'formatPattern' | 3 | 53 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dateTimeFormat' | 3 | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'locale' | 3 | 57 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 72 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 72 |
| LocalVariableCouldBeFinal | Local variable 'useTurbineLocale' could be declared final | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'localeSetter' could be declared final | 3 | 97 |
| LocalVariableCouldBeFinal | Local variable 'zoneIdStr' could be declared final | 3 | 102 |
| LocalVariableCouldBeFinal | Local variable 'zoneIdSet' could be declared final | 3 | 104 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 111–113 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 118 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 124 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 3 | 124 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 3 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 136 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 3 | 136 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 136 |
| MethodArgumentCouldBeFinal | Parameter 'zoneId' is not assigned and could be declared final | 3 | 137 |
| UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 142 and 165) | 3 | 138 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 152 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 159 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 176 |
| LongVariable | Avoid excessively long variable names like outgoingFormatPattern | 3 | 176 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormatPattern' is not assigned and could be declared final | 3 | 176 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 176 |
| LongVariable | Avoid excessively long variable names like incomingFormatPattern | 3 | 176 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 180 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'incomingFormatPattern' | 2 | 184 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 187 |
| LocalVariableCouldBeFinal | Local variable 'incomingFormat' could be declared final | 3 | 189 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 200 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 200 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 205 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'incomingFormat' | 2 | 209 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 212 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'outgoingFormat' | 2 | 216 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 224 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 3 | 224 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 230 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormat' is not assigned and could be declared final | 3 | 230 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 236 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 3 | 236 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 236 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 245 |
| MethodArgumentCouldBeFinal | Parameter 'zoneId' is not assigned and could be declared final | 3 | 254 |
org/apache/turbine/services/localization/LocalizationTool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like localizationService | 3 | 46 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: LocalizationTool.refresh() | 1 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 75 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 3 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 134 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 152 |
org/apache/turbine/services/localization/RundataLocalizationService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 43 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 43 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 45 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 48 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 49 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 49 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 50–51 |
| UselessParentheses | Useless parentheses. | 4 | 51 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 55 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 3 | 55 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LocalizationService': 'ACCEPT_LANGUAGE' is already in scope because it is inherited by an enclosing type | 4 | 55 |
| LocalVariableCouldBeFinal | Local variable 'locale' could be declared final | 3 | 61 |
| LawOfDemeter | Call to `getTemp` on foreign value `data.getUser()` (degree 2) | 3 | 61 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 61 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 64 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 3 | 64 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LocalizationService': 'ACCEPT_LANGUAGE' is already in scope because it is inherited by an enclosing type | 4 | 64 |
| LambdaCanBeMethodReference | Lambda expression could be written as a method reference: `locale::getLanguage` | 3 | 68 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 69 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 72 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 3 | 74 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'LocalizationService': 'ACCEPT_LANGUAGE' is already in scope because it is inherited by an enclosing type | 4 | 74 |
org/apache/turbine/services/naming/TurbineNamingService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 50 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'contextPropsList' | 3 | 61 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 64 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 81 |
| LocalVariableCouldBeFinal | Local variable 'contextKeys' could be declared final | 3 | 86 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 89 |
| LocalVariableCouldBeFinal | Local variable 'end' could be declared final | 3 | 90 |
| UseIndexOfChar | String.indexOf(char) is faster than String.indexOf(String). | 3 | 90 |
| LocalVariableCouldBeFinal | Local variable 'contextName' could be declared final | 3 | 97 |
| UnusedAssignment | The initializer for variable 'contextProps' is never used (overwritten on lines 102 and 106) | 3 | 98 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 106 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 3 | 115 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'contextProps' could be declared final | 3 | 118 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 119 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 119 |
| PreserveStackTrace | Thrown exception does not preserve the stack trace of exception 'e' on all code paths | 3 | 129–130 |
| MethodArgumentCouldBeFinal | Parameter 'contextName' is not assigned and could be declared final | 3 | 146 |
| UnusedAssignment | The initializer for variable 'contextProps' is never used (overwritten on lines 154 and 158) | 3 | 150 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 164 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 166 |
org/apache/turbine/services/pull/PullService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like TOOL_RESOURCES_DIR_KEY | 3 | 82 |
| LongVariable | Avoid excessively long variable names like TOOL_RESOURCES_DIR_DEFAULT | 3 | 88 |
| LongVariable | Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_KEY | 3 | 94 |
| LongVariable | Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_DEFAULT | 3 | 97 |
| LongVariable | Avoid excessively long variable names like SESSION_TOOLS_ATTRIBUTE_PREFIX | 3 | 100 |
org/apache/turbine/services/pull/TurbinePullService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 121 |
| GodClass | Possible God Class (WMC=65, ATFD=44, TCC=27.485%) | 3 | 121 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 124–841 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pool' | 3 | 129 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'velocity' | 3 | 132 |
| ImmutableField | Field 'toolName' may be declared final | 3 | 151 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'toolName' | 3 | 151 |
| ImmutableField | Field 'toolClassName' may be declared final | 3 | 152 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'toolClassName' | 3 | 152 |
| ImmutableField | Field 'toolClass' may be declared final | 3 | 153 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'toolClass' | 3 | 153 |
| MethodArgumentCouldBeFinal | Parameter 'toolName' is not assigned and could be declared final | 3 | 155 |
| MethodArgumentCouldBeFinal | Parameter 'toolClassName' is not assigned and could be declared final | 3 | 155 |
| MethodArgumentCouldBeFinal | Parameter 'toolClass' is not assigned and could be declared final | 3 | 155 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 164 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 167 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 170 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 173 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 176 |
| LongVariable | Avoid excessively long variable names like resourcesDirectory | 3 | 179 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 179 |
| LongVariable | Avoid excessively long variable names like refreshToolsPerRequest | 3 | 182 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'refreshToolsPerRequest' | 3 | 182 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 182 |
| ExceptionAsFlowControl | Exception thrown at line 197 is caught in this block. | 3 | 219–222 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 219 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 231 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 234 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 266 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 272 |
| LawOfDemeter | Call to `getNewContext` on foreign value `velocity` (degree 1) | 3 | 304 |
| MethodArgumentCouldBeFinal | Parameter 'toolConfig' is not assigned and could be declared final | 3 | 316 |
| LocalVariableCouldBeFinal | Local variable 'tools' could be declared final | 3 | 318 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 324 |
| LocalVariableCouldBeFinal | Local variable 'it' could be declared final | 3 | 327 |
| LocalVariableCouldBeFinal | Local variable 'toolName' could be declared final | 3 | 329 |
| LocalVariableCouldBeFinal | Local variable 'toolClassName' could be declared final | 3 | 330 |
| LocalVariableCouldBeFinal | Local variable 'toolClass' could be declared final | 3 | 335 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 377 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 377 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 391 |
| LocalVariableCouldBeFinal | Local variable 'userManager' could be declared final | 3 | 400 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 3 | 405 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 422 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 422 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 424 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 424 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 437 |
| LocalVariableCouldBeFinal | Local variable 'userManager' could be declared final | 3 | 446 |
| LawOfDemeter | Call to `hasLoggedIn` on foreign value `user` (degree 2) | 3 | 451 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 463 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 3 | 465 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 3 | 469 |
| LawOfDemeter | Access to field `toolClass` on foreign value `toolData` (degree 1) | 3 | 469 |
| LawOfDemeter | Call to `getDeclaredConstructor` on foreign value `toolData.toolClass` (degree 2) | 3 | 469 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 477 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 479–480 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 491 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 491 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 3 | 494 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 3 | 499 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 507 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 509–510 |
| MethodArgumentCouldBeFinal | Parameter 'tools' is not assigned and could be declared final | 3 | 524 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 524 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 525 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 525 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 3 | 528 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 534 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 538 |
| LawOfDemeter | Call to `getSession` on foreign value `data` (degree 1) | 3 | 556 |
| LawOfDemeter | Call to `getClass` on foreign value `tool` (degree 2) | 3 | 558 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 579 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 584 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 588 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 590–591 |
| MethodArgumentCouldBeFinal | Parameter 'tools' is not assigned and could be declared final | 3 | 606 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 606 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 607 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 607 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 3 | 610 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 657 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 663 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 667 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 669–670 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 3 | 712 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 3 | 714 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 727 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 741 |
| MethodArgumentCouldBeFinal | Parameter 'tools' is not assigned and could be declared final | 3 | 741 |
| LocalVariableCouldBeFinal | Local variable 'toolData' could be declared final | 3 | 745 |
| LocalVariableCouldBeFinal | Local variable 'tool' could be declared final | 3 | 747 |
| MethodArgumentCouldBeFinal | Parameter 'tool' is not assigned and could be declared final | 3 | 765 |
| MethodArgumentCouldBeFinal | Parameter 'param' is not assigned and could be declared final | 3 | 765 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 766 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 778 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 778 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 783 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 783 |
| MethodArgumentCouldBeFinal | Parameter 'tool' is not assigned and could be declared final | 3 | 810 |
| MethodArgumentCouldBeFinal | Parameter 'dataObject' is not assigned and could be declared final | 3 | 810 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 812 |
| CloseResource | Ensure that resources like this PipelineData object are closed after use | 3 | 813 |
| UnusedAssignment | The initializer for variable 'pipelineData' is never used (overwritten on line 816) | 3 | 813 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 833 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 837 |
org/apache/turbine/services/pull/tools/ContentTool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_PREFIX | 3 | 54 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_ENCODING_KEY | 3 | 62 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_ENCODING_DEFAULT | 3 | 65 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_KEY | 3 | 68 |
| LongVariable | Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_DEFAULT | 3 | 71 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantEncoding' | 3 | 74 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'wantEncoding' | 3 | 74 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantRelative' | 3 | 77 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'wantRelative' | 3 | 77 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dataURI' | 3 | 80 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 85 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable 'pipelineData' could be declared final | 3 | 114 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 115 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 3 | 115 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 124 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 158 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 175 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 191 |
org/apache/turbine/services/pull/tools/TemplateLink.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 61–633 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_PREFIX | 3 | 63 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_KEY | 3 | 66 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_DEFAULT | 3 | 69 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantRelative' | 3 | 72 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_KEY | 3 | 80 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_DEFAULT | 3 | 83 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantEncoding' | 3 | 86 |
| CommentDefaultAccessModifier | Missing commented default access modifier on field 'wantEncoding' | 3 | 86 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'template' | 3 | 89 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'templateURI' | 3 | 92 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 95 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 102 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 124 |
| LocalVariableCouldBeFinal | Local variable 'pipelineData' could be declared final | 3 | 131 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 132 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 3 | 132 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 140 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setEncodeURLOff' should not return any type except void linguistically | 3 | 184 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setPage' should not return any type except void linguistically | 3 | 196 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 196 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setAction' should not return any type except void linguistically | 3 | 224 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 224 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setActionEvent' should not return any type except void linguistically | 3 | 241 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 241 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 3 | 241 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically | 3 | 257 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 257 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setReference' should not return any type except void linguistically | 3 | 270 |
| MethodArgumentCouldBeFinal | Parameter 'reference' is not assigned and could be declared final | 3 | 270 |
| ShortVariable | Avoid variables with short names like pp | 3 | 302 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 302 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 315 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 315 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 328 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 328 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 341 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 341 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 354 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 354 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 367 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 367 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 380 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 380 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 393 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 393 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 406 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 406 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 419 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 419 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 432 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 432 |
| ShortVariable | Avoid variables with short names like pp | 3 | 445 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 445 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 468 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 491 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 3 | 521 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 3 | 556 |
org/apache/turbine/services/pull/tools/UITool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 65 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 132 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 160 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 188 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 206 |
| MethodArgumentCouldBeFinal | Parameter 'skin' is not assigned and could be declared final | 3 | 206 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 3 | 225 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 225 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 3 | 243 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 243 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 3 | 255 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 274 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 292 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 322 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 322 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 340 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 340 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 352 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 364 |
| LocalVariableCouldBeFinal | Local variable 'pipelineData' could be declared final | 3 | 378 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 379 |
| LocalVariableCouldBeFinal | Local variable 'runData' could be declared final | 3 | 379 |
org/apache/turbine/services/pull/util/DateFormatter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| LongVariable | Avoid excessively long variable names like DATE_FORMAT_DEFAULT | 3 | 42 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dateFormat' | 3 | 50 |
| MethodArgumentCouldBeFinal | Parameter 'theDate' is not assigned and could be declared final | 3 | 90 |
| MethodArgumentCouldBeFinal | Parameter 'theDate' is not assigned and could be declared final | 3 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 3 | 103 |
| UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 110 and 115) | 3 | 105 |
| LocalVariableCouldBeFinal | Local variable 'sdf' could be declared final | 3 | 106 |
org/apache/turbine/services/pull/util/DateTimeFormatterTool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 54 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 56–218 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 61 |
| LongVariable | Avoid excessively long variable names like localizationService | 3 | 65 |
| LongVariable | Avoid excessively long variable names like overrideFromRequestLocale | 3 | 69 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'overrideFromRequestLocale' | 3 | 69 |
| SingularField | Perhaps 'overrideFromRequestLocale' could be replaced by a local variable. | 3 | 69 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 93 |
| LocalVariableCouldBeFinal | Local variable 'serviceManager' could be declared final | 3 | 99 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 111 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 151 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 157 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 3 | 157 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 163 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 3 | 163 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 163 |
| MethodArgumentCouldBeFinal | Parameter 'temporalAccessor' is not assigned and could be declared final | 3 | 169 |
| MethodArgumentCouldBeFinal | Parameter 'dateFormatString' is not assigned and could be declared final | 3 | 169 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 169 |
| MethodArgumentCouldBeFinal | Parameter 'zoneId' is not assigned and could be declared final | 3 | 170 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 175 |
| LongVariable | Avoid excessively long variable names like outgoingFormatPattern | 3 | 175 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormatPattern' is not assigned and could be declared final | 3 | 175 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 175 |
| LongVariable | Avoid excessively long variable names like incomingFormatPattern | 3 | 175 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormatPattern' is not assigned and could be declared final | 3 | 175 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 181 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.time.format': 'DateTimeFormatter' is already in scope because it is imported in this file | 4 | 181 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 3 | 181 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 182 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.time.format': 'DateTimeFormatter' is already in scope because it is imported in this file | 4 | 182 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormat' is not assigned and could be declared final | 3 | 182 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 188 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 3 | 188 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 194 |
| MethodArgumentCouldBeFinal | Parameter 'incomingFormat' is not assigned and could be declared final | 3 | 194 |
| MethodArgumentCouldBeFinal | Parameter 'src' is not assigned and could be declared final | 3 | 200 |
| MethodArgumentCouldBeFinal | Parameter 'outgoingFormat' is not assigned and could be declared final | 3 | 200 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 200 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 209 |
| LawOfDemeter | Call to `getZoneId` on foreign value `getDtfs()` (degree 1) | 3 | 215 |
org/apache/turbine/services/pull/util/SessionData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 39 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 73 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 84 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 96 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 96 |
org/apache/turbine/services/rundata/DefaultTurbineRunData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 1–1384 |
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 3 | 1–1384 |
| GodClass | Possible God Class (WMC=118, ATFD=29, TCC=1.684%) | 3 | 80 |
| CyclomaticComplexity | The class 'DefaultTurbineRunData' has a total cyclomatic complexity of 118 (highest 4). | 3 | 80 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 80 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 83–1384 |
| TooManyFields | Too many fields | 3 | 83–1384 |
| LongVariable | Avoid excessively long variable names like stackTraceException | 3 | 144 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 151 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 154 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 166 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 171 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 172 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 186 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 192 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 194 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultPipelineData.put(Class<?>, Map<Class<?>, ? super Object>) | 1 | 207 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>()` | 3 | 207 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: DefaultTurbineRunData.recycle() | 1 | 208 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 229 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 230 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 231 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 232 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 233 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 235 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 236 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 238 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 241 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 242 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 243 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 244 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 245 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 246 |
| LocalVariableCouldBeFinal | Local variable 'parameters' could be declared final | 3 | 263 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 3 | 264 |
| LawOfDemeter | Call to `getRequest` on foreign value `parameters` (degree 1) | 3 | 266 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 266 |
| LocalVariableCouldBeFinal | Local variable 'cookies' could be declared final | 3 | 283 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 3 | 284 |
| LawOfDemeter | Call to `getRequest` on foreign value `cookies` (degree 1) | 3 | 286 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 286 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 3 | 358 |
| MethodArgumentCouldBeFinal | Parameter 'acl' is not assigned and could be declared final | 3 | 371 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 385 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 407 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 435 |
| MethodArgumentCouldBeFinal | Parameter 'layout' is not assigned and could be declared final | 3 | 453 |
| MethodArgumentCouldBeFinal | Parameter 'layout' is not assigned and could be declared final | 3 | 480 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 513 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 539 |
| MethodArgumentCouldBeFinal | Parameter 'encoding' is not assigned and could be declared final | 3 | 561 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 593 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 606 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 616 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 628 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 630 |
| LocalVariableCouldBeFinal | Local variable 'message' could be declared final | 3 | 650 |
| MethodArgumentCouldBeFinal | Parameter 'msgs' is not assigned and could be declared final | 3 | 688 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 3 | 710 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 723 |
| UselessParentheses | Useless parentheses. | 4 | 728 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 742 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 752 |
| MethodArgumentCouldBeFinal | Parameter 'locale' is not assigned and could be declared final | 3 | 852 |
| LocalVariableCouldBeFinal | Local variable 'parameters' could be declared final | 3 | 857 |
| LocalVariableCouldBeFinal | Local variable 'cookies' could be declared final | 3 | 858 |
| MethodArgumentCouldBeFinal | Parameter 'charSet' is not assigned and could be declared final | 3 | 892 |
| MethodArgumentCouldBeFinal | Parameter 'charSet' is not assigned and could be declared final | 3 | 926 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 952 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 955 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 959 |
| MethodArgumentCouldBeFinal | Parameter 'contentType' is not assigned and could be declared final | 3 | 972 |
| UselessParentheses | Useless parentheses. | 4 | 986 |
| MethodArgumentCouldBeFinal | Parameter 'ruri' is not assigned and could be declared final | 3 | 996 |
| MethodArgumentCouldBeFinal | Parameter 'statusCode' is not assigned and could be declared final | 3 | 1018 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 1031 |
| MethodArgumentCouldBeFinal | Parameter 'err' is not assigned and could be declared final | 3 | 1042 |
| MethodArgumentCouldBeFinal | Parameter 'contexts' is not assigned and could be declared final | 3 | 1068 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 1196 |
| MethodArgumentCouldBeFinal | Parameter 'trace' is not assigned and could be declared final | 3 | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'exp' is not assigned and could be declared final | 3 | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 1260 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 1260 |
| MethodArgumentCouldBeFinal | Parameter 'out' is not assigned and could be declared final | 3 | 1318 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 3 | 1328 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 3 | 1338 |
| MethodArgumentCouldBeFinal | Parameter 'port' is not assigned and could be declared final | 3 | 1348 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 3 | 1358 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 3 | 1368 |
org/apache/turbine/services/rundata/RunDataService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like PARAMETER_PARSER_KEY | 3 | 54 |
org/apache/turbine/services/rundata/TurbineRunDataService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like DEFAULT_PARAMETER_PARSER | 3 | 70 |
| LongVariable | Avoid excessively long variable names like DEFAULT_COOKIE_PARSER | 3 | 74 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pool' | 3 | 84 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parserService' | 3 | 87 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 92 |
| CognitiveComplexity | The method 'init()' has a cognitive complexity of 18, current threshold is 15 | 3 | 103 |
| CyclomaticComplexity | The method 'init()' has a cyclomatic complexity of 11. | 3 | 103 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 107–112 |
| LocalVariableCouldBeFinal | Local variable 'def' could be declared final | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 116 |
| OneDeclarationPerLine | Use one line for each declaration, it enhances code readability. | 4 | 119 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 121–126 |
| LocalVariableCouldBeFinal | Local variable 'plist' could be declared final | 3 | 121 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 3 | 127 |
| ShortVariable | Avoid variables with short names like j | 3 | 131 |
| LocalVariableCouldBeFinal | Local variable 'plistKey' could be declared final | 3 | 132 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 138–142 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 192 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 3 | 193 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 194 |
| CyclomaticComplexity | The method 'getRunData(String, HttpServletRequest, HttpServletResponse, ServletConfig)' has a cyclomatic complexity of 12. | 3 | 213 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 213 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 214 |
| MethodArgumentCouldBeFinal | Parameter 'res' is not assigned and could be declared final | 3 | 215 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 216 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 218 |
| LocalVariableCouldBeFinal | Local variable 'cfg' could be declared final | 3 | 233 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 239 |
| LocalVariableCouldBeFinal | Local variable 'runDataClazz' could be declared final | 3 | 242 |
| LongVariable | Avoid excessively long variable names like parameterParserClazz | 3 | 243 |
| LocalVariableCouldBeFinal | Local variable 'parameterParserClazz' could be declared final | 3 | 243 |
| LocalVariableCouldBeFinal | Local variable 'cookieParserClazz' could be declared final | 3 | 244 |
| ShortVariable | Avoid variables with short names like pp | 3 | 248 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 3 | 248 |
| ShortVariable | Avoid variables with short names like cp | 3 | 252 |
| LocalVariableCouldBeFinal | Local variable 'cp' could be declared final | 3 | 252 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 296 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 303 |
| MethodArgumentCouldBeFinal | Parameter 'className' is not assigned and could be declared final | 3 | 312 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 3 | 312 |
org/apache/turbine/services/schedule/AbstractJobEntry.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=54, ATFD=19, TCC=1.732%) | 3 | 35 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 38 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'jobIsActive' | 3 | 41 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'runtime' | 3 | 44 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 3 | 94 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 3 | 95 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 3 | 96 |
| ShortVariable | Avoid variables with short names like wd | 3 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 3 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 3 | 98 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 98 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 3 | 99 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setSecond(int) | 1 | 110 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setMinute(int) | 1 | 111 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setHour(int) | 1 | 112 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setWeekDay(int) | 1 | 113 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setDayOfMonth(int) | 1 | 114 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.setTask(String) | 1 | 115 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: AbstractJobEntry.calcRunTime() | 1 | 117 |
| ShortVariable | Avoid variables with short names like je | 3 | 129 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 129 |
| MethodArgumentCouldBeFinal | Parameter 'isActive' is not assigned and could be declared final | 3 | 140 |
| LocalVariableCouldBeFinal | Local variable 'schedrun' could be declared final | 3 | 210 |
| LocalVariableCouldBeFinal | Local variable 'now' could be declared final | 3 | 211 |
| CognitiveComplexity | The method 'evaluateJobType()' has a cognitive complexity of 37, current threshold is 15 | 3 | 304 |
| CyclomaticComplexity | The method 'evaluateJobType()' has a cyclomatic complexity of 21. | 3 | 304 |
| AvoidDuplicateLiterals | The String literal "Error in JobEntry. Bad Job parameter." appears 5 times in this file; the first occurrence is on line 323 | 3 | 323 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 326 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 337 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 349 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 361 |
| ShortVariable | Avoid variables with short names like v | 3 | 391 |
| ShortVariable | Avoid variables with short names like v | 3 | 405 |
| ShortVariable | Avoid variables with short names like v | 3 | 419 |
| ShortVariable | Avoid variables with short names like v | 3 | 433 |
| ShortVariable | Avoid variables with short names like v | 3 | 447 |
| ShortVariable | Avoid variables with short names like v | 3 | 461 |
| ShortVariable | Avoid variables with short names like v | 3 | 477 |
org/apache/turbine/services/schedule/AbstractSchedulerService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 41 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 42–364 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 44 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'ScheduleService': 'LOGGER_NAME' is already in scope because it is inherited by an enclosing type | 4 | 44 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'scheduleQueue' | 3 | 47 |
| ImmutableField | Field 'enabled' may be declared final | 3 | 50 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 53 |
| LongVariable | Avoid excessively long variable names like houseKeepingThread | 3 | 53 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 56 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 71–75 |
| LocalVariableCouldBeFinal | Local variable 'jobs' could be declared final | 3 | 78 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 84 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 111 |
| ShortVariable | Avoid variables with short names like wd | 3 | 118 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 118 |
| ShortVariable | Avoid variables with short names like je | 3 | 141 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 141 |
| ShortVariable | Avoid variables with short names like je | 3 | 155 |
| ShortVariable | Avoid variables with short names like je | 3 | 166 |
| MethodArgumentCouldBeFinal | Parameter 'enabled' is not assigned and could be declared final | 3 | 185 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 205 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 215 |
| LocalVariableCouldBeFinal | Local variable 'thread' could be declared final | 3 | 218 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 233 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 233 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 241 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 243 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 252 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 262 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 3 | 272 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 284 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 288 |
| ShortVariable | Avoid variables with short names like je | 3 | 292 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 3 | 292 |
| LocalVariableCouldBeFinal | Local variable 'now' could be declared final | 3 | 301 |
| LocalVariableCouldBeFinal | Local variable 'when' could be declared final | 3 | 302 |
| LawOfDemeter | Call to `getNextRuntime` on foreign value `je` (degree 2) | 3 | 302 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 314 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 319–322 |
| ShortVariable | Avoid variables with short names like je | 3 | 340 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 3 | 340 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 3 | 346 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 346 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 354 |
org/apache/turbine/services/schedule/JobEntry.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like v | 3 | 74 |
| ShortVariable | Avoid variables with short names like v | 3 | 88 |
org/apache/turbine/services/schedule/JobEntryNonPersistent.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like wd | 3 | 35 |
| FieldNamingConventions | The field name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 36 |
| AvoidFieldNameMatchingMethodName | Field isnew has the same name as a method | 3 | 38 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 3 | 80 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 3 | 81 |
| ShortVariable | Avoid variables with short names like wd | 3 | 82 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 3 | 82 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 3 | 83 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 83 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 3 | 84 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 103 |
| SimplifyBooleanReturns | This if statement can be replaced by `return {condition} && {thenBranch};` | 3 | 105–108 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable '_isnew' could be declared final | 3 | 119 |
| LocalVariableNamingConventions | The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 119 |
| ShortVariable | Avoid variables with short names like v | 3 | 141 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 141 |
| ShortVariable | Avoid variables with short names like v | 3 | 163 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 163 |
| ShortVariable | Avoid variables with short names like v | 3 | 185 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 185 |
| ShortVariable | Avoid variables with short names like v | 3 | 207 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 207 |
| ShortVariable | Avoid variables with short names like v | 3 | 229 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 229 |
| ShortVariable | Avoid variables with short names like v | 3 | 251 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 251 |
| ShortVariable | Avoid variables with short names like v | 3 | 273 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 273 |
org/apache/turbine/services/schedule/JobEntryQuartz.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidFieldNameMatchingMethodName | Field isnew has the same name as a method | 3 | 47 |
| ImmutableField | Field 'active' may be declared final | 3 | 48 |
| LongVariable | Avoid excessively long variable names like DEFAULT_JOB_GROUP_NAME | 3 | 53 |
| MethodArgumentCouldBeFinal | Parameter 'jobTrigger' is not assigned and could be declared final | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'jobTrigger' is not assigned and could be declared final | 3 | 81 |
| MethodArgumentCouldBeFinal | Parameter 'jobDetail' is not assigned and could be declared final | 3 | 81 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: JobEntryQuartz.setTask(String) | 1 | 84 |
| LocalVariableCouldBeFinal | Local variable '_isnew' could be declared final | 3 | 95 |
| LocalVariableNamingConventions | The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 95 |
| ShortVariable | Avoid variables with short names like v | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 117 |
| ShortVariable | Avoid variables with short names like v | 3 | 139 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 139 |
| MethodArgumentCouldBeFinal | Parameter 'jobTrigger' is not assigned and could be declared final | 3 | 155 |
| ShortVariable | Avoid variables with short names like o | 3 | 172 |
| MethodArgumentCouldBeFinal | Parameter 'o' is not assigned and could be declared final | 3 | 172 |
| MethodArgumentCouldBeFinal | Parameter 'isActive' is not assigned and could be declared final | 3 | 181 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 235 |
| SimplifyBooleanExpressions | Avoid unnecessary comparisons in boolean expressions | 3 | 237 |
| LawOfDemeter | Call to `getJobDetail` on foreign value `context` (degree 1) | 3 | 248 |
| LawOfDemeter | Call to `getKey` on foreign value `context.getJobDetail()` (degree 2) | 3 | 248 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 252 |
org/apache/turbine/services/schedule/JobQueue.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LooseCoupling | Avoid using implementation types like 'ConcurrentSkipListSet'; use the interface instead | 3 | 41 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'queue' | 3 | 41 |
| ImmutableField | Field 'queue' may be declared final | 3 | 41 |
| UnusedAssignment | The field initializer for 'queue' is never used (overwritten on line 48) | 3 | 41 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ConcurrentSkipListSet<>(...)` | 3 | 48 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 70 |
| ShortVariable | Avoid variables with short names like je | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 3 | 83 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 86 |
| LocalVariableCouldBeFinal | Local variable 'jobEntry' could be declared final | 3 | 88 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 92 |
| LooseCoupling | Avoid using implementation types like 'Vector'; use the interface instead | 3 | 104 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 3 | 104 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 106–113 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 108 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 3 | 108 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 3 | 108 |
| ReturnEmptyCollectionRatherThanNull | Return an empty collection rather than null. | 1 | 112 |
| ShortVariable | Avoid variables with short names like je | 3 | 121 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 121 |
| MethodArgumentCouldBeFinal | Parameter 'jobEntries' is not assigned and could be declared final | 3 | 132 |
| ShortVariable | Avoid variables with short names like je | 3 | 145 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 145 |
| ShortVariable | Avoid variables with short names like je | 3 | 156 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 156 |
| ShortVariable | Avoid variables with short names like je | 3 | 169 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 169 |
org/apache/turbine/services/schedule/QuartzSchedulerService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 49 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 52–413 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 54 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'ScheduleService': 'LOGGER_NAME' is already in scope because it is inherited by an enclosing type | 4 | 54 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'enabled' | 3 | 57 |
| ShortVariable | Avoid variables with short names like qs | 3 | 73 |
| LocalVariableCouldBeFinal | Local variable 'qs' could be declared final | 3 | 73 |
| LawOfDemeter | Call to `getScheduler` on foreign value `qs` (degree 1) | 3 | 75 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 3 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 3 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 3 | 103 |
| ShortVariable | Avoid variables with short names like wd | 3 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 3 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 3 | 103 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 3 | 103 |
| ShortVariable | Avoid variables with short names like jd | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable 'jd' could be declared final | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable 'csb' could be declared final | 3 | 111 |
| ShortVariable | Avoid variables with short names like t | 3 | 113 |
| LocalVariableCouldBeFinal | Local variable 't' could be declared final | 3 | 113 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'jeq' | 3 | 119 |
| LocalVariableCouldBeFinal | Local variable 'jeq' could be declared final | 3 | 119 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 3 | 140 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 3 | 140 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 3 | 140 |
| ShortVariable | Avoid variables with short names like wd | 3 | 140 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 3 | 140 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 3 | 140 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 140 |
| ShortVariable | Avoid variables with short names like sb | 3 | 142 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 142 |
| InsufficientStringBufferDeclaration | StringBuilder has been initialized with size 16, but has at least 17 characters appended. | 3 | 142 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 143 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 144 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 161 |
| MethodArgumentCouldBeFinal | Parameter 'oid' is not assigned and could be declared final | 3 | 175 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 3 | 178 |
| ShortVariable | Avoid variables with short names like je | 3 | 196 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 196 |
| ShortVariable | Avoid variables with short names like jq | 3 | 202 |
| LocalVariableCouldBeFinal | Local variable 'jq' could be declared final | 3 | 202 |
| ShortVariable | Avoid variables with short names like je | 3 | 218 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 218 |
| ShortVariable | Avoid variables with short names like jq | 3 | 223 |
| LocalVariableCouldBeFinal | Local variable 'jq' could be declared final | 3 | 223 |
| LawOfDemeter | Call to `getJobTrigger` on foreign value `jq` (degree 1) | 3 | 224 |
| ShortVariable | Avoid variables with short names like je | 3 | 240 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 240 |
| ShortVariable | Avoid variables with short names like jq | 3 | 246 |
| LocalVariableCouldBeFinal | Local variable 'jq' could be declared final | 3 | 246 |
| LawOfDemeter | Call to `getJobTrigger` on foreign value `jq` (degree 1) | 3 | 247 |
| LocalVariableCouldBeFinal | Local variable 'jobs' could be declared final | 3 | 263 |
| LocalVariableCouldBeFinal | Local variable 'groupMatcher' could be declared final | 3 | 267 |
| LocalVariableCouldBeFinal | Local variable 'jobKeys' could be declared final | 3 | 268 |
| LocalVariableCouldBeFinal | Local variable 'jk' could be declared final | 3 | 269 |
| LocalVariableCouldBeFinal | Local variable 'triggers' could be declared final | 3 | 271 |
| ShortVariable | Avoid variables with short names like jd | 3 | 277 |
| LocalVariableCouldBeFinal | Local variable 'jd' could be declared final | 3 | 277 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 3 | 278 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 278 |
| MethodArgumentCouldBeFinal | Parameter 'enabled' is not assigned and could be declared final | 3 | 298 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 318 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 328 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 348 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 355–362 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 3 | 361 |
| ShortVariable | Avoid variables with short names like je | 3 | 377 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 377 |
| MethodArgumentCouldBeFinal | Parameter 'trigger' is not assigned and could be declared final | 3 | 409 |
| ShortVariable | Avoid variables with short names like jd | 3 | 409 |
| MethodArgumentCouldBeFinal | Parameter 'jd' is not assigned and could be declared final | 3 | 409 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'job' | 3 | 410 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 3 | 410 |
org/apache/turbine/services/schedule/ScheduleService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like wd | 3 | 84 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 85 |
| ShortVariable | Avoid variables with short names like je | 3 | 104 |
| ShortVariable | Avoid variables with short names like je | 3 | 113 |
| ShortVariable | Avoid variables with short names like je | 3 | 122 |
org/apache/turbine/services/schedule/SchedulerTool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 41 |
| MethodArgumentCouldBeFinal | Parameter 'jobId' is not assigned and could be declared final | 3 | 97 |
| ShortVariable | Avoid variables with short names like je | 3 | 99 |
org/apache/turbine/services/schedule/TorqueSchedulerService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| LocalVariableCouldBeFinal | Local variable 'jobsTorque' could be declared final | 3 | 52 |
| LocalVariableCouldBeFinal | Local variable 'job' could be declared final | 3 | 54 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 3 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 3 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 3 | 71 |
| ShortVariable | Avoid variables with short names like wd | 3 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 3 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 3 | 71 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 3 | 71 |
| LocalVariableCouldBeFinal | Local variable 'jet' could be declared final | 3 | 73 |
| MethodArgumentCouldBeFinal | Parameter 'oid' is not assigned and could be declared final | 3 | 94 |
| ShortVariable | Avoid variables with short names like je | 3 | 98 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 3 | 98 |
| ShortVariable | Avoid variables with short names like je | 3 | 116 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 116 |
| ShortVariable | Avoid variables with short names like c | 3 | 121 |
| LocalVariableCouldBeFinal | Local variable 'c' could be declared final | 3 | 121 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 121 |
| ShortVariable | Avoid variables with short names like je | 3 | 145 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 145 |
org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 68 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 76 |
| LocalVariableCouldBeFinal | Local variable 'jobProps' could be declared final | 3 | 77 |
| LocalVariableCouldBeFinal | Local variable 'jobs' could be declared final | 3 | 78 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 84–112 |
| LocalVariableCouldBeFinal | Local variable 'jobName' could be declared final | 3 | 86 |
| LocalVariableCouldBeFinal | Local variable 'jobPrefix' could be declared final | 3 | 87 |
| LocalVariableCouldBeFinal | Local variable 'jobId' could be declared final | 3 | 89 |
| LocalVariableCouldBeFinal | Local variable 'sec' could be declared final | 3 | 97 |
| LocalVariableCouldBeFinal | Local variable 'min' could be declared final | 3 | 98 |
| ShortVariable | Avoid variables with short names like hr | 3 | 99 |
| LocalVariableCouldBeFinal | Local variable 'hr' could be declared final | 3 | 99 |
| LocalVariableCouldBeFinal | Local variable 'wkday' could be declared final | 3 | 100 |
| LocalVariableCouldBeFinal | Local variable 'dayOfMonth' could be declared final | 3 | 101 |
| ShortVariable | Avoid variables with short names like je | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 3 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'sec' is not assigned and could be declared final | 3 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'min' is not assigned and could be declared final | 3 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'hour' is not assigned and could be declared final | 3 | 122 |
| ShortVariable | Avoid variables with short names like wd | 3 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'wd' is not assigned and could be declared final | 3 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'day_mo' is not assigned and could be declared final | 3 | 122 |
| FormalParameterNamingConventions | The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'task' is not assigned and could be declared final | 3 | 122 |
| MethodArgumentCouldBeFinal | Parameter 'oid' is not assigned and could be declared final | 3 | 135 |
| ShortVariable | Avoid variables with short names like je | 3 | 138 |
| LocalVariableCouldBeFinal | Local variable 'je' could be declared final | 3 | 138 |
| ShortVariable | Avoid variables with short names like je | 3 | 149 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 149 |
| ShortVariable | Avoid variables with short names like je | 3 | 163 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 174 |
org/apache/turbine/services/schedule/WorkerThread.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'je' | 3 | 42 |
| ShortVariable | Avoid variables with short names like je | 3 | 42 |
| ImmutableField | Field 'je' may be declared final | 3 | 42 |
| UnusedAssignment | The field initializer for 'je' is never used (overwritten on line 54) | 3 | 42 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 45 |
| ShortVariable | Avoid variables with short names like je | 3 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'je' is not assigned and could be declared final | 3 | 52 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 77 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 79–80 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 80 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'logStateChange': private methods cannot be overridden | 3 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'state' is not assigned and could be declared final | 3 | 97 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 99–100 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 100 |
org/apache/turbine/services/security/DefaultSecurityService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 3 | 1–1127 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 74 |
| GodClass | Possible God Class (WMC=88, ATFD=18, TCC=11.246%) | 3 | 74 |
| CyclomaticComplexity | The class 'DefaultSecurityService' has a total cyclomatic complexity of 88 (highest 4). | 3 | 74 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 74 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 77–1127 |
| ImmutableField | Field 'readerCount' may be declared final | 3 | 79 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'userManager' | 3 | 82 |
| UnusedPrivateField | Avoid unused private fields such as 'backend'. | 3 | 96 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'globalGroup' | 3 | 101 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 101 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 104 |
| LocalVariableCouldBeFinal | Local variable 'manager' could be declared final | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 126 |
| LongVariable | Avoid excessively long variable names like userManagerClassName | 3 | 128 |
| LocalVariableCouldBeFinal | Local variable 'userManagerClassName' could be declared final | 3 | 128 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SecurityService': 'USER_MANAGER_KEY' is already in scope because it is inherited by an enclosing type | 4 | 129 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'SecurityService': 'USER_MANAGER_DEFAULT' is already in scope because it is inherited by an enclosing type | 4 | 130 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 139 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 157 |
| LawOfDemeter | Call to `getUserInstance` on foreign value `getUserManager()` (degree 1) | 3 | 160 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 3 | 180 |
| LocalVariableCouldBeFinal | Local variable 'user' could be declared final | 3 | 183 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 206 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 211 |
| MethodArgumentCouldBeFinal | Parameter 'groupName' is not assigned and could be declared final | 3 | 228 |
| LocalVariableCouldBeFinal | Local variable 'group' could be declared final | 3 | 231 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 236 |
| LocalVariableCouldBeFinal | Local variable 'permission' could be declared final | 3 | 253 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 258 |
| MethodArgumentCouldBeFinal | Parameter 'permName' is not assigned and could be declared final | 3 | 274 |
| LocalVariableCouldBeFinal | Local variable 'permission' could be declared final | 3 | 277 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 282 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 3 | 299 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 304 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 321 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 3 | 324 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 329 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 358 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 3 | 375 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 3 | 395 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 395 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 3 | 413 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 444 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 459 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 478 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 495 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 495 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 510 |
| AvoidDuplicateLiterals | The String literal "user is null" appears 4 times in this file; the first occurrence is on line 514 | 3 | 514 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 533 |
| MethodArgumentCouldBeFinal | Parameter 'oldPassword' is not assigned and could be declared final | 3 | 533 |
| MethodArgumentCouldBeFinal | Parameter 'newPassword' is not assigned and could be declared final | 3 | 534 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 556 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 556 |
| UseNotifyAllInsteadOfNotify | Call Thread.notifyAll() rather than Thread.notify() | 3 | 582 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 600–603 |
| ShortVariable | Avoid variables with short names like g | 3 | 646 |
| LocalVariableCouldBeFinal | Local variable 'g' could be declared final | 3 | 646 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 660 |
| ShortVariable | Avoid variables with short names like id | 3 | 677 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 3 | 677 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 680 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 693 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 3 | 696 |
| ShortVariable | Avoid variables with short names like id | 3 | 714 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 3 | 714 |
| LocalVariableCouldBeFinal | Local variable 'role' could be declared final | 3 | 718 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 718 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 736 |
| ShortVariable | Avoid variables with short names like id | 3 | 753 |
| MethodArgumentCouldBeFinal | Parameter 'id' is not assigned and could be declared final | 3 | 753 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 757 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 813 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 835 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 835 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 835 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 856 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 856 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 856 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 878 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 878 |
| MethodArgumentCouldBeFinal | Parameter 'newRole' is not assigned and could be declared final | 3 | 878 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 895 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 914 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 914 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 930 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 930 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 947 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 969 |
| MethodArgumentCouldBeFinal | Parameter 'cascadeDelete' is not assigned and could be declared final | 3 | 969 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 985 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 1000 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 1015 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 1030 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 1045 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 1059 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 1074 |
| MethodArgumentCouldBeFinal | Parameter 'group' is not assigned and could be declared final | 3 | 1090 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 1090 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 1106 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 1106 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 1122 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 1122 |
org/apache/turbine/services/security/DefaultUserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 76 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 77–537 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'umDelegate' | 3 | 79 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'factoryService' | 3 | 81 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 88 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 98 |
| ShortVariable | Avoid variables with short names like u | 3 | 101 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 101 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 113 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 117 |
| LocalVariableCouldBeFinal | Local variable 'params' could be declared final | 3 | 117 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 118 |
| LocalVariableCouldBeFinal | Local variable 'signature' could be declared final | 3 | 118 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 119 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 121 |
| MethodArgumentCouldBeFinal | Parameter 'userWrapperClass2' is not assigned and could be declared final | 3 | 143 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 3 | 154 |
| LocalVariableCouldBeFinal | Local variable 'manager' could be declared final | 3 | 156 |
| LocalVariableCouldBeFinal | Local variable 'userWrapperClass' could be declared final | 3 | 159 |
| LocalVariableCouldBeFinal | Local variable 'turbineUser' could be declared final | 3 | 169 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 171 |
| LocalVariableCouldBeFinal | Local variable 'params' could be declared final | 3 | 171 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 172 |
| LocalVariableCouldBeFinal | Local variable 'signature' could be declared final | 3 | 172 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 179 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 196 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 3 | 216 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 3 | 234 |
| ShortVariable | Avoid variables with short names like u | 3 | 237 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 237 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 256 |
| LooseCoupling | Avoid using implementation types like 'UserSet'; use the interface instead | 3 | 259 |
| LocalVariableCouldBeFinal | Local variable 'uset' could be declared final | 3 | 259 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'userList' | 3 | 261 |
| LocalVariableCouldBeFinal | Local variable 'userList' could be declared final | 3 | 261 |
| MethodArgumentCouldBeFinal | Parameter 'username' is not assigned and could be declared final | 3 | 287 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 287 |
| ShortVariable | Avoid variables with short names like u | 3 | 291 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 291 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 306 |
| AvoidDuplicateLiterals | The String literal "user is null" appears 6 times in this file; the first occurrence is on line 310 | 3 | 310 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 316 |
| UnnecessaryCast | Unnecessary cast (TurbineUserDelegate) | 3 | 321 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 337 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 358 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 358 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 375 |
| MethodArgumentCouldBeFinal | Parameter 'initialPassword' is not assigned and could be declared final | 3 | 375 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 392 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 415 |
| MethodArgumentCouldBeFinal | Parameter 'oldPassword' is not assigned and could be declared final | 3 | 415 |
| MethodArgumentCouldBeFinal | Parameter 'newPassword' is not assigned and could be declared final | 3 | 416 |
| UnnecessaryCast | Unnecessary cast (TurbineUserDelegate) | 3 | 424 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 444 |
| MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 444 |
| ShortVariable | Avoid variables with short names like u | 3 | 464 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 464 |
| ShortVariable | Avoid variables with short names like u | 3 | 478 |
| MethodArgumentCouldBeFinal | Parameter 'u' is not assigned and could be declared final | 3 | 478 |
| ShortVariable | Avoid variables with short names like u | 3 | 496 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 496 |
| MethodArgumentCouldBeFinal | Parameter 'userName' is not assigned and could be declared final | 3 | 514 |
| ShortVariable | Avoid variables with short names like u | 3 | 516 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 516 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 530 |
org/apache/turbine/services/security/SecurityService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 64 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 66–757 |
| LongVariable | Avoid excessively long variable names like USER_MANAGER_DEFAULT | 3 | 80 |
| LongVariable | Avoid excessively long variable names like USER_WRAPPER_DEFAULT | 3 | 93 |
| ShortVariable | Avoid variables with short names like u | 3 | 272 |
| LooseCoupling | Avoid using implementation types like 'PermissionSet'; use the interface instead | 3 | 396 |
| ShortVariable | Avoid variables with short names like id | 3 | 538 |
| ShortVariable | Avoid variables with short names like id | 3 | 568 |
| ShortVariable | Avoid variables with short names like id | 3 | 598 |
| LooseCoupling | Avoid using implementation types like 'GroupSet'; use the interface instead | 3 | 609 |
| LooseCoupling | Avoid using implementation types like 'RoleSet'; use the interface instead | 3 | 619 |
| LooseCoupling | Avoid using implementation types like 'PermissionSet'; use the interface instead | 3 | 629 |
org/apache/turbine/services/security/UserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–301 |
| ShortVariable | Avoid variables with short names like u | 3 | 258 |
org/apache/turbine/services/security/passive/PassiveUserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 46 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 47–365 |
| AvoidDuplicateLiterals | The String literal "PassiveUserManager knows no users" appears 10 times in this file; the first occurrence is on line 72 | 3 | 72 |
| ShortVariable | Avoid variables with short names like u | 3 | 311 |
org/apache/turbine/services/servlet/TurbineServletService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 51 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'servletContext' | 3 | 58 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'servletConfig' | 3 | 61 |
| LawOfDemeter | Call to `getServletContext` on foreign value `servletConfig` (degree 1) | 3 | 74 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 78 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 3 | 95 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 99 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 117–120 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 3 | 133 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 137 |
| ShortVariable | Avoid variables with short names like is | 3 | 140 |
| UnusedAssignment | The initializer for variable 'is' is never used (overwritten on line 141) | 3 | 140 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 3 | 154 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 158 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 250 |
org/apache/turbine/services/session/SessionListener.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 61 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 3 | 98 |
| LawOfDemeter | Call to `getSession` on foreign value `event` (degree 1) | 3 | 101 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 3 | 110 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 3 | 125 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 3 | 137 |
org/apache/turbine/services/session/SessionTool.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| ShortVariable | Avoid variables with short names like o | 3 | 48 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 75 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 86 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 102 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 125 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 137 |
org/apache/turbine/services/session/TurbineSessionService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 80 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 92 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 109 |
| LocalVariableCouldBeFinal | Local variable 'users' could be declared final | 3 | 124 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 3 | 128 |
| ShortVariable | Avoid variables with short names like u | 3 | 130 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'session' is not assigned and could be declared final | 3 | 147 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 154 |
| MethodArgumentCouldBeFinal | Parameter 'sessionId' is not assigned and could be declared final | 3 | 169 |
| MethodArgumentCouldBeFinal | Parameter 'user' is not assigned and could be declared final | 3 | 182 |
| LocalVariableCouldBeFinal | Local variable 'sessions' could be declared final | 3 | 184 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 3 | 185 |
| ShortVariable | Avoid variables with short names like u | 3 | 187 |
| LocalVariableCouldBeFinal | Local variable 'u' could be declared final | 3 | 187 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 217 |
org/apache/turbine/services/template/BaseTemplateEngineService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 38 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 53 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 53 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 53 |
| MethodArgumentCouldBeFinal | Parameter 'defaultExt' is not assigned and could be declared final | 3 | 59 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 62 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 70 |
| MethodArgumentCouldBeFinal | Parameter 'defaultExt' is not assigned and could be declared final | 3 | 97 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 3 | 99 |
| LongVariable | Avoid excessively long variable names like fileExtensionAssociations | 3 | 105 |
| LocalVariableCouldBeFinal | Local variable 'copyParams' could be declared final | 3 | 124 |
| LocalVariableCouldBeFinal | Local variable 'copyParam' could be declared final | 3 | 134 |
org/apache/turbine/services/template/TemplateEngineService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like TEMPLATE_EXTENSIONS | 3 | 35 |
| LongVariable | Avoid excessively long variable names like DEFAULT_TEMPLATE_EXTENSION | 3 | 37 |
| LongVariable | Avoid excessively long variable names like DEFAULT_NAVIGATION | 3 | 45 |
| LongVariable | Avoid excessively long variable names like DEFAULT_ERROR_SCREEN | 3 | 47 |
| LongVariable | Avoid excessively long variable names like DEFAULT_LAYOUT_TEMPLATE | 3 | 49 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SCREEN_TEMPLATE | 3 | 51 |
| LongVariable | Avoid excessively long variable names like DEFAULT_NAVIGATION_TEMPLATE | 3 | 53 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 60 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 60 |
org/apache/turbine/services/template/TemplateService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like DEFAULT_TEMPLATE_KEY | 3 | 49 |
| LongVariable | Avoid excessively long variable names like DEFAULT_TEMPLATE_VALUE | 3 | 52 |
| LongVariable | Avoid excessively long variable names like DEFAULT_EXTENSION_KEY | 3 | 55 |
| LongVariable | Avoid excessively long variable names like DEFAULT_EXTENSION_VALUE | 3 | 58 |
| LongVariable | Avoid excessively long variable names like EXTENSION_SEPARATOR | 3 | 61 |
| LongVariable | Avoid excessively long variable names like TEMPLATE_PARTS_SEPARATOR | 3 | 64 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 218 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 229 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 240 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 251 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 262 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 273 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 285 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 299 |
org/apache/turbine/services/template/TurbineTemplateService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 1–817 |
| GodClass | Possible God Class (WMC=47, ATFD=23, TCC=21.675%) | 3 | 181 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 186 |
| LongVariable | Avoid excessively long variable names like LAYOUT_TEMPLATE_KEY | 3 | 201 |
| LongVariable | Avoid excessively long variable names like LAYOUT_TEMPLATE_NAME | 3 | 204 |
| LongVariable | Avoid excessively long variable names like SCREEN_TEMPLATE_KEY | 3 | 207 |
| LongVariable | Avoid excessively long variable names like SCREEN_TEMPLATE_NAME | 3 | 210 |
| LongVariable | Avoid excessively long variable names like NAVIGATION_TEMPLATE_KEY | 3 | 213 |
| LongVariable | Avoid excessively long variable names like NAVIGATION_TEMPLATE_NAME | 3 | 216 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'mapperRegistry' | 3 | 222 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_EXTENSION_VALUE' is already in scope because it is inherited by an enclosing type | 4 | 231 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'useCache' | 3 | 235 |
| LongVariable | Avoid excessively long variable names like templateEngineRegistry | 3 | 256 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'templateEngineRegistry' | 3 | 256 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 261 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 261 |
| LocalVariableCouldBeFinal | Local variable 'config' could be declared final | 3 | 277 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_EXTENSION_KEY' is already in scope because it is inherited by an enclosing type | 4 | 282 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_EXTENSION_VALUE' is already in scope because it is inherited by an enclosing type | 4 | 283 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_TEMPLATE_KEY' is already in scope because it is inherited by an enclosing type | 4 | 285 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateService': 'DEFAULT_TEMPLATE_VALUE' is already in scope because it is inherited by an enclosing type | 4 | 286 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 295 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 295 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 335 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 339 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 3 | 342 |
| ShortVariable | Avoid variables with short names like sb | 3 | 357 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 357 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 361 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 436 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 450 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 464 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 478 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 492 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 505 |
| ShortVariable | Avoid variables with short names like pp | 3 | 507 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 3 | 507 |
| LocalVariableCouldBeFinal | Local variable 'template' could be declared final | 3 | 508 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 520 |
| ShortVariable | Avoid variables with short names like pp | 3 | 522 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 3 | 522 |
| LocalVariableCouldBeFinal | Local variable 'template' could be declared final | 3 | 523 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 536 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 551 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 566 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 582 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 597 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 613 |
| MethodArgumentCouldBeFinal | Parameter 'templatePaths' is not assigned and could be declared final | 3 | 632 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 652 |
| MethodArgumentCouldBeFinal | Parameter 'templatePaths' is not assigned and could be declared final | 3 | 652 |
| MethodArgumentCouldBeFinal | Parameter 'service' is not assigned and could be declared final | 3 | 666 |
| LocalVariableCouldBeFinal | Local variable 'exts' could be declared final | 3 | 668 |
| LocalVariableCouldBeFinal | Local variable 'ext' could be declared final | 3 | 670 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 684 |
| MethodArgumentCouldBeFinal | Parameter 'templateKey' is not assigned and could be declared final | 3 | 697 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 697 |
| CyclomaticComplexity | The method 'initMapper(Configuration)' has a cyclomatic complexity of 10. | 3 | 711 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 3 | 711 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 720–723 |
| LocalVariableCouldBeFinal | Local variable 'mapperNames' could be declared final | 3 | 720 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 725–728 |
| LocalVariableCouldBeFinal | Local variable 'mapperKeys' could be declared final | 3 | 725 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 730–738 |
| LocalVariableCouldBeFinal | Local variable 'mapperClasses' could be declared final | 3 | 730 |
| ShortVariable | Avoid variables with short names like ab | 3 | 740 |
| LocalVariableCouldBeFinal | Local variable 'ab' could be declared final | 3 | 740 |
| LocalVariableCouldBeFinal | Local variable 'mapperCacheSize' could be declared final | 3 | 743 |
| LocalVariableCouldBeFinal | Local variable 'mapperLoader' could be declared final | 3 | 744 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 753 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 754 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 755 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 757–765 |
| LongVariable | Avoid excessively long variable names like mapperDefaultProperty | 3 | 757 |
| LocalVariableCouldBeFinal | Local variable 'mapperDefaultProperty' could be declared final | 3 | 757 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 767 |
| LocalVariableCouldBeFinal | Local variable 'mapperSeparator' could be declared final | 3 | 767 |
| UseShortArrayInitializer | Array initialization can be written shorter | 3 | 769–773 |
| LocalVariableCouldBeFinal | Local variable 'mapperPrefix' could be declared final | 3 | 769 |
| LocalVariableCouldBeFinal | Local variable 'mapperProperty' could be declared final | 3 | 777 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 777 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 778 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 779 |
| LocalVariableCouldBeFinal | Local variable 'mapperClass' could be declared final | 3 | 782 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 785 |
| ShortVariable | Avoid variables with short names like tm | 3 | 787 |
| UnusedAssignment | The initializer for variable 'tm' is never used (overwritten on line 792) | 3 | 787 |
| LocalVariableCouldBeFinal | Local variable 'factory' could be declared final | 3 | 791 |
org/apache/turbine/services/template/mapper/BaseMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'useCache' | 3 | 43 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'templateCache' | 3 | 49 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 66 |
| MethodArgumentCouldBeFinal | Parameter 'cacheSize' is not assigned and could be declared final | 3 | 84 |
| MethodArgumentCouldBeFinal | Parameter 'useCache' is not assigned and could be declared final | 3 | 102 |
| MethodArgumentCouldBeFinal | Parameter 'defaultProperty' is not assigned and could be declared final | 3 | 120 |
| MethodArgumentCouldBeFinal | Parameter 'separator' is not assigned and could be declared final | 3 | 138 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 166 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 170 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 3 | 171 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 175 |
| LocalVariableCouldBeFinal | Local variable 'defaultName' could be declared final | 3 | 178 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 193 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 197 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 202 |
| LocalVariableCouldBeFinal | Local variable 'res' could be declared final | 3 | 205 |
org/apache/turbine/services/template/mapper/BaseTemplateMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 48 |
| MethodArgumentCouldBeFinal | Parameter 'prefix' is not assigned and could be declared final | 3 | 66 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 83 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 3 | 88 |
| LocalVariableCouldBeFinal | Local variable 'resBuf' could be declared final | 3 | 93 |
| LongVariable | Avoid excessively long variable names like templateComponents | 3 | 95 |
| LocalVariableCouldBeFinal | Local variable 'templateComponents' could be declared final | 3 | 95 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 3 | 98 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 101 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 105 |
org/apache/turbine/services/template/mapper/ClassMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'loader' | 3 | 60 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 63 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 70 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 70 |
| MethodArgumentCouldBeFinal | Parameter 'loader' is not assigned and could be declared final | 3 | 88 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 91 |
| CognitiveComplexity | The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 | 3 | 102 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 102 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 3 | 107 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 3 | 121 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 127 |
| LocalVariableCouldBeFinal | Local variable 'pkg' could be declared final | 3 | 131 |
| LocalVariableCouldBeFinal | Local variable 'testName' could be declared final | 3 | 132 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 132 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 138 |
| UselessParentheses | Useless parentheses. | 4 | 142 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 151 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 157–160 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 157 |
org/apache/turbine/services/template/mapper/DirectMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 43 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 57 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 3 | 59 |
| LocalVariableCouldBeFinal | Local variable 'dotIndex' could be declared final | 3 | 65 |
org/apache/turbine/services/template/mapper/DirectTemplateMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 44 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 58 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 3 | 60 |
org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 55 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 62 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 62 |
| CognitiveComplexity | The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 | 3 | 75 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 75 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 87 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 93 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 3 | 94 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 98 |
| LocalVariableCouldBeFinal | Local variable 'defaultName' could be declared final | 3 | 102 |
| LocalVariableCouldBeFinal | Local variable 'templatePackage' could be declared final | 3 | 111 |
| LocalVariableCouldBeFinal | Local variable 'testName' could be declared final | 3 | 115 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 115 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 119 |
| UselessParentheses | Useless parentheses. | 4 | 123 |
| LocalVariableCouldBeFinal | Local variable 'templatePath' could be declared final | 3 | 128 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 128 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 131 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 141 |
org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 51 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 58 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 71 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 3 | 75 |
| LocalVariableCouldBeFinal | Local variable 'templateName' could be declared final | 3 | 83 |
| UnusedAssignment | The updated value of variable 'componentSize' is never used | 3 | 84 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 89 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 3 | 90 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'defaultName' could be declared final | 3 | 97 |
| LocalVariableCouldBeFinal | Local variable 'templatePackage' could be declared final | 3 | 106 |
| LocalVariableCouldBeFinal | Local variable 'testName' could be declared final | 3 | 110 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 110 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 114 |
| UselessParentheses | Useless parentheses. | 4 | 118 |
| LocalVariableCouldBeFinal | Local variable 'templatePath' could be declared final | 3 | 123 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 123 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 126 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 136 |
org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 47 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 60 |
| LocalVariableCouldBeFinal | Local variable 'components' could be declared final | 3 | 62 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 65 |
| LocalVariableCouldBeFinal | Local variable 'tes' could be declared final | 3 | 66 |
| LocalVariableCouldBeFinal | Local variable 'templatePackage' could be declared final | 3 | 68 |
| LocalVariableCouldBeFinal | Local variable 'testPath' could be declared final | 3 | 71 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 74 |
org/apache/turbine/services/ui/TurbineUIService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 57 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 60–531 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 62 |
| LongVariable | Avoid excessively long variable names like SKIN_PROPERTY_DEFAULT | 3 | 108 |
| LongVariable | Avoid excessively long variable names like DEFAULT_SKIN_CSS_FILE | 3 | 126 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wantRelative' | 3 | 147 |
| LooseCoupling | Avoid using implementation types like 'ConcurrentHashMap'; use the interface instead | 3 | 152 |
| ImmutableField | Field 'skins' may be declared final | 3 | 152 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 169 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 187 |
| LocalVariableCouldBeFinal | Local variable 'skinProperties' could be declared final | 3 | 189 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 208 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 208 |
| LocalVariableCouldBeFinal | Local variable 'skinProperties' could be declared final | 3 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 227 |
| LocalVariableCouldBeFinal | Local variable 'skinsDir' could be declared final | 3 | 240 |
| LocalVariableCouldBeFinal | Local variable 'directory' could be declared final | 3 | 242 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 261 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 263 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 280 |
| LongVariable | Avoid excessively long variable names like defaultSkinProperties | 3 | 282 |
| LocalVariableCouldBeFinal | Local variable 'skinProperties' could be declared final | 3 | 290 |
| ShortVariable | Avoid variables with short names like sb | 3 | 292 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 292 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 293 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 294 |
| ShortVariable | Avoid variables with short names like is | 3 | 298 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 304 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 306 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 307–322 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 311 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 313–322 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 316 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 321 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 361 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 3 | 361 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 361 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 374 |
| MethodArgumentCouldBeFinal | Parameter 'imageId' is not assigned and could be declared final | 3 | 374 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 393 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 393 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 406 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 425 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 425 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 426 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 439 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 439 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 448 |
| LocalVariableCouldBeFinal | Local variable 'len' could be declared final | 3 | 452 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 3 | 454 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 477 |
| MethodArgumentCouldBeFinal | Parameter 'skinName' is not assigned and could be declared final | 3 | 477 |
| MethodArgumentCouldBeFinal | Parameter 'subDir' is not assigned and could be declared final | 3 | 478 |
| MethodArgumentCouldBeFinal | Parameter 'resourceName' is not assigned and could be declared final | 3 | 478 |
| ShortVariable | Avoid variables with short names like sb | 3 | 480 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 480 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 481 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 484 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 486 |
| ShortVariable | Avoid variables with short names like du | 3 | 488 |
| LocalVariableCouldBeFinal | Local variable 'du' could be declared final | 3 | 488 |
| LocalVariableCouldBeFinal | Local variable 'cfg' could be declared final | 3 | 501 |
| LocalVariableCouldBeFinal | Local variable 'pullService' could be declared final | 3 | 504 |
| ShortVariable | Avoid variables with short names like sb | 3 | 507 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 507 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 508 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 509 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 509 |
org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 44 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 49 |
| FieldNamingConventions | The constant name 'counter' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 56 |
| ShortVariable | Avoid variables with short names like md | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'md' could be declared final | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'bytesId' could be declared final | 3 | 80 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 88 |
| LocalVariableCouldBeFinal | Local variable 'current' could be declared final | 3 | 130 |
| ShortVariable | Avoid variables with short names like id | 3 | 131 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 3 | 135 |
| UseUnderscoresInNumericLiterals | Number 100000000 should separate every third digit with an underscore | 3 | 135 |
org/apache/turbine/services/urlmapper/MappedTemplateLink.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 50 |
org/apache/turbine/services/urlmapper/TurbineURLMapperService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 1–325 |
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 72 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 79 |
| LongVariable | Avoid excessively long variable names like DEFAULT_CONFIGURATION_FILE | 3 | 84 |
| LongVariable | Avoid excessively long variable names like CONFIGURATION_FILE_KEY | 3 | 89 |
| LongVariable | Avoid excessively long variable names like NAMED_GROUPS_PATTERN | 3 | 99 |
| LongVariable | Avoid excessively long variable names like MULTI_SLASH_PATTERN | 3 | 104 |
| LongVariable | Avoid excessively long variable names like CONTEXT_PATH_PARAMETER | 3 | 109 |
| LongVariable | Avoid excessively long variable names like WEBAPP_ROOT_PARAMETER | 3 | 114 |
| LongVariable | Avoid excessively long variable names like DEFAULT_PARAMETERS | 3 | 119 |
| CognitiveComplexity | The method 'mapToURL(TurbineURI)' has a cognitive complexity of 20, current threshold is 15 | 3 | 131 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 3 | 131 |
| LocalVariableCouldBeFinal | Local variable 'pathInfo' could be declared final | 3 | 138 |
| LocalVariableCouldBeFinal | Local variable 'queryData' could be declared final | 3 | 139 |
| LocalVariableCouldBeFinal | Local variable 'uriParameterMap' could be declared final | 3 | 143 |
| LocalVariableCouldBeFinal | Local variable 'urlMap' could be declared final | 3 | 151 |
| LocalVariableCouldBeFinal | Local variable 'keys' could be declared final | 3 | 153 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 153 |
| LocalVariableCouldBeFinal | Local variable 'entryKeys' could be declared final | 3 | 156 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 156 |
| LocalVariableCouldBeFinal | Local variable 'implicitKeysFound' could be declared final | 3 | 158 |
| LocalVariableCouldBeFinal | Local variable 'matcher' could be declared final | 3 | 167 |
| LawOfDemeter | Call to `getUrlPattern` on foreign value `urlMap` (degree 1) | 3 | 167 |
| ShortVariable | Avoid variables with short names like sb | 3 | 168 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 168 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 168 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 172 |
| LocalVariableCouldBeFinal | Local variable 'ignore' could be declared final | 3 | 183 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 187 |
| ShortVariable | Avoid variables with short names like pp | 3 | 218 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 218 |
| LocalVariableCouldBeFinal | Local variable 'urlMap' could be declared final | 3 | 220 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'url' | 2 | 222 |
| LocalVariableCouldBeFinal | Local variable 'matcher' could be declared final | 3 | 223 |
| LawOfDemeter | Call to `getUrlPattern` on foreign value `urlMap` (degree 1) | 3 | 223 |
| LawOfDemeter | Call to `matcher` on foreign value `urlMap.getUrlPattern()` (degree 2) | 3 | 223 |
| UnnecessaryBoxing | Unnecessary explicit unboxing | 3 | 231 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 245 |
| LocalVariableCouldBeFinal | Local variable 'cfg' could be declared final | 3 | 260 |
| LocalVariableCouldBeFinal | Local variable 'servletService' could be declared final | 3 | 271 |
| LocalVariableCouldBeFinal | Local variable 'jaxb' could be declared final | 3 | 277 |
| LocalVariableCouldBeFinal | Local variable 'unmarshaller' could be declared final | 3 | 278 |
| LocalVariableCouldBeFinal | Local variable 'mapper' could be declared final | 3 | 284 |
| LocalVariableCouldBeFinal | Local variable 'mapper' could be declared final | 3 | 288 |
| LocalVariableCouldBeFinal | Local variable 'urlMap' could be declared final | 3 | 298 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 301 |
| LocalVariableCouldBeFinal | Local variable 'groupNamesMap' could be declared final | 3 | 301 |
| AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 301 |
| LocalVariableCouldBeFinal | Local variable 'matcher' could be declared final | 3 | 302 |
| LawOfDemeter | Call to `getUrlPattern` on foreign value `urlMap` (degree 1) | 3 | 302 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 306 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 311 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 311 |
org/apache/turbine/services/urlmapper/URLMapperService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortVariable | Avoid variables with short names like pp | 3 | 57 |
org/apache/turbine/services/urlmapper/URLMapperValve.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 39 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 50 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 50 |
| CloseResource | Ensure that resources like this RunData object are closed after use | 3 | 53 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 53 |
| LocalVariableCouldBeFinal | Local variable 'uri' could be declared final | 3 | 54 |
| LawOfDemeter | Call to `getRequest` on foreign value `data` (degree 1) | 3 | 54 |
org/apache/turbine/services/urlmapper/model/URLMapEntry.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 44 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 47 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 48 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 49 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'relevantKeys' | 3 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'urlPattern' is not assigned and could be declared final | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'implicit' is not assigned and could be declared final | 3 | 87 |
| MethodArgumentCouldBeFinal | Parameter 'ignore' is not assigned and could be declared final | 3 | 106 |
| MethodArgumentCouldBeFinal | Parameter 'override' is not assigned and could be declared final | 3 | 125 |
| MethodArgumentCouldBeFinal | Parameter 'groupNamesMap' is not assigned and could be declared final | 3 | 145 |
| MethodArgumentCouldBeFinal | Parameter 'relevantKeys' is not assigned and could be declared final | 3 | 165 |
org/apache/turbine/services/urlmapper/model/URLMappingContainer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 43 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'newURLMapEntries' is not assigned and could be declared final | 3 | 94 |
org/apache/turbine/services/urlmapper/model/XmlParameterAdapter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 35 |
| MethodArgumentCouldBeFinal | Parameter 'xmlList' is not assigned and could be declared final | 3 | 41 |
| MethodArgumentCouldBeFinal | Parameter 'map' is not assigned and could be declared final | 3 | 53 |
| LocalVariableCouldBeFinal | Local variable 'xmlList' could be declared final | 3 | 55 |
org/apache/turbine/services/urlmapper/model/XmlParameterList.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 79 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 86 |
| MethodArgumentCouldBeFinal | Parameter 'xmlParameters' is not assigned and could be declared final | 3 | 104 |
org/apache/turbine/services/urlmapper/model/XmlPatternAdapter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 31 |
| MethodArgumentCouldBeFinal | Parameter 'urlPattern' is not assigned and could be declared final | 3 | 37 |
| MethodArgumentCouldBeFinal | Parameter 'pattern' is not assigned and could be declared final | 3 | 46 |
org/apache/turbine/services/velocity/TurbineVelocityService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 80 |
| GodClass | Possible God Class (WMC=52, ATFD=17, TCC=15.833%) | 3 | 80 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 84–615 |
| LongVariable | Avoid excessively long variable names like RESOURCE_LOADER_PATH | 3 | 86 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 95 |
| LongVariable | Avoid excessively long variable names like defaultInputEncoding | 3 | 98 |
| LongVariable | Avoid excessively long variable names like defaultOutputEncoding | 3 | 101 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pullModelActive' | 3 | 104 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'velocity' | 3 | 110 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'pullService' | 3 | 113 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'VELOCITY_EXTENSION' is already in scope because it is inherited by an enclosing type | 4 | 144 |
| LocalVariableCouldBeFinal | Local variable 'inputEncoding' could be declared final | 3 | 146 |
| LongVariable | Avoid excessively long variable names like outputEncodingString | 3 | 149 |
| LocalVariableCouldBeFinal | Local variable 'outputEncodingString' could be declared final | 3 | 149 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 167 |
| LocalVariableCouldBeFinal | Local variable 'globalContext' could be declared final | 3 | 182 |
| LawOfDemeter | Call to `getGlobalContext` on foreign value `pullService` (degree 1) | 3 | 183 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'ctx' | 3 | 185 |
| LocalVariableCouldBeFinal | Local variable 'ctx' could be declared final | 3 | 185 |
| LocalVariableCouldBeFinal | Local variable 'ctx' could be declared final | 3 | 197 |
| ShortVariable | Avoid variables with short names like ec | 3 | 201 |
| LocalVariableCouldBeFinal | Local variable 'ec' could be declared final | 3 | 201 |
| MethodArgumentCouldBeFinal | Parameter 'clazz' is not assigned and could be declared final | 3 | 222 |
| MethodArgumentCouldBeFinal | Parameter 'method' is not assigned and could be declared final | 3 | 222 |
| ShortVariable | Avoid variables with short names like e | 3 | 222 |
| MethodArgumentCouldBeFinal | Parameter 'e' is not assigned and could be declared final | 3 | 222 |
| MethodArgumentCouldBeFinal | Parameter 'info' is not assigned and could be declared final | 3 | 222 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 224 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 228 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 246 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 249 |
| LawOfDemeter | Call to `getTemplateContext` on foreign value `data.getTemplateInfo()` (degree 2) | 3 | 253 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 253 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'CONTEXT' is already in scope because it is inherited by an enclosing type | 4 | 253 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'RUNDATA_KEY' is already in scope because it is inherited by an enclosing type | 4 | 258 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'PIPELINEDATA_KEY' is already in scope because it is inherited by an enclosing type | 4 | 260 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 271 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'CONTEXT' is already in scope because it is inherited by an enclosing type | 4 | 272 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 289 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 289 |
| CloseResource | Ensure that resources like this OutputStreamWriter object are closed after use | 3 | 293 |
| UnusedAssignment | The initializer for variable 'writer' is never used (overwritten on line 298) | 3 | 293 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 3 | 294 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 304 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 325 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 325 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 3 | 326 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 3 | 329 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 335 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 354 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 354 |
| MethodArgumentCouldBeFinal | Parameter 'writer' is not assigned and could be declared final | 3 | 354 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 361 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 374 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 394 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 394 |
| MethodArgumentCouldBeFinal | Parameter 'writer' is not assigned and could be declared final | 3 | 395 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 396 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 414 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 418 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'RUNDATA_KEY' is already in scope because it is inherited by an enclosing type | 4 | 418 |
| SimplifyConditional | No need to check for null before an instanceof | 3 | 419 |
| LawOfDemeter | Call to `getCharset` on foreign value `(RunData) data` (degree 1) | 3 | 421 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 433 |
| LocalVariableCouldBeFinal | Local variable 'data' could be declared final | 3 | 437 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'VelocityService': 'RUNDATA_KEY' is already in scope because it is inherited by an enclosing type | 4 | 437 |
| SimplifyConditional | No need to check for null before an instanceof | 3 | 438 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'renderingError': private methods cannot be overridden | 3 | 455 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 455 |
| ShortVariable | Avoid variables with short names like e | 3 | 455 |
| MethodArgumentCouldBeFinal | Parameter 'e' is not assigned and could be declared final | 3 | 455 |
| LocalVariableCouldBeFinal | Local variable 'err' could be declared final | 3 | 458 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 471 |
| LocalVariableCouldBeFinal | Local variable 'conf' could be declared final | 3 | 474 |
| LocalVariableCouldBeFinal | Local variable 'velocity' could be declared final | 3 | 481 |
| CognitiveComplexity | The method 'setVelocityProperties(VelocityEngine, Configuration)' has a cognitive complexity of 29, current threshold is 15 | 3 | 500 |
| CyclomaticComplexity | The method 'setVelocityProperties(VelocityEngine, Configuration)' has a cyclomatic complexity of 12. | 3 | 500 |
| MethodArgumentCouldBeFinal | Parameter 'velocity' is not assigned and could be declared final | 3 | 500 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 3 | 500 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 501 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 3 | 507 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 509 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 512 |
| LocalVariableCouldBeFinal | Local variable 'name2' could be declared final | 3 | 515 |
| UselessParentheses | Useless parentheses. | 4 | 515 |
| LocalVariableCouldBeFinal | Local variable 'paths' could be declared final | 3 | 528 |
| LocalVariableCouldBeFinal | Local variable 'p' could be declared final | 3 | 543 |
| LocalVariableCouldBeFinal | Local variable 'jarSepIndex' could be declared final | 3 | 554 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 596 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 608 |
org/apache/turbine/services/velocity/VelocityService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like VELOCITY_EXTENSION | 3 | 52 |
| LongVariable | Avoid excessively long variable names like CATCH_ERRORS_DEFAULT | 3 | 64 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 76 |
org/apache/turbine/util/BrowserDetector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'BrowserDetector' is suspected to be a Data Class (WOC=20.000%, NOPA=0, NOAM=4, WMC=9) | 3 | 41 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 2 | 56 |
| MethodArgumentCouldBeFinal | Parameter 'userAgentString' is not assigned and could be declared final | 3 | 78 |
| LocalVariableCouldBeFinal | Local variable 'userAgent' could be declared final | 3 | 81 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BrowserDetector.getUserAgent() | 1 | 81 |
| LocalVariableCouldBeFinal | Local variable 'version' could be declared final | 3 | 85 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'userAgentString' is not assigned and could be declared final | 3 | 157 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'toFloat': private methods cannot be overridden | 3 | 168 |
| ShortVariable | Avoid variables with short names like s | 3 | 168 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 3 | 168 |
org/apache/turbine/util/FormMessage.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'FormMessage' is suspected to be a Data Class (WOC=28.571%, NOPA=0, NOAM=5, WMC=12) | 3 | 33 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 52 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: FormMessage.setFormName(String) | 1 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 3 | 65 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: FormMessage.setFieldName(String) | 1 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 78 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 3 | 80 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: FormMessage.setMessage(String) | 1 | 83 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 113 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 3 | 121 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 131 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 3 | 141 |
| ShortVariable | Avoid variables with short names like sb | 3 | 153 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 153 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 153 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 155 |
| InefficientStringBuffering | Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 3 | 157 |
org/apache/turbine/util/FormMessages.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 36 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 36 |
| FieldNamingConventions | The final field name 'forms_messages' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 36 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 38 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 38 |
| FieldNamingConventions | The final field name 'fields_messages' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 38 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 40 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 40 |
| FieldNamingConventions | The final field name 'messages_fields' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 40 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 42 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 42 |
| FieldNamingConventions | The final field name 'forms_fields' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 42 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 49 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 50 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 51 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 62 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 3 | 62 |
| MethodArgumentCouldBeFinal | Parameter 'returnCode' is not assigned and could be declared final | 3 | 62 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'messageName' is not assigned and could be declared final | 3 | 74 |
| LocalVariableCouldBeFinal | Local variable 'formFieldName' could be declared final | 3 | 76 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 90 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 90 |
| MethodArgumentCouldBeFinal | Parameter 'table' is not assigned and could be declared final | 3 | 90 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 90 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 90 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 3 | 92 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 94–107 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getValues': private methods cannot be overridden | 3 | 117 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 117 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'table' is not assigned and could be declared final | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 128 |
| OneDeclarationPerLine | Use one line for each declaration, it enhances code readability. | 4 | 130 |
| OneDeclarationPerLine | Use one line for each declaration, it enhances code readability. | 4 | 131 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 135 |
| LocalVariableCouldBeFinal | Local variable 'field' could be declared final | 3 | 142 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 151 |
| ReturnEmptyCollectionRatherThanNull | Return an empty collection rather than null. | 1 | 153 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 163 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 3 | 163 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 165 |
| LocalVariableCouldBeFinal | Local variable 'messages' could be declared final | 3 | 167 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 172 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 179 |
| ReturnEmptyCollectionRatherThanNull | Return an empty collection rather than null. | 1 | 181 |
| MethodArgumentCouldBeFinal | Parameter 'formName' is not assigned and could be declared final | 3 | 191 |
| MethodArgumentCouldBeFinal | Parameter 'fieldName' is not assigned and could be declared final | 3 | 191 |
| LocalVariableCouldBeFinal | Local variable 'fields' could be declared final | 3 | 193 |
| LocalVariableCouldBeFinal | Local variable 'field' could be declared final | 3 | 194 |
| StringToString | Avoid calling toString() on String objects; this is unnecessary. | 3 | 196 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 198 |
org/apache/turbine/util/GenerateUniqueId.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 40 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'session_count' | 3 | 50 |
| FieldNamingConventions | The static field name 'session_count' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 50 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'lastTimeVal' | 3 | 51 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'java.util': 'Random' is already in scope because it is imported in this file | 4 | 52 |
| FieldNamingConventions | The public constant name 'maxRandomLen' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 61 |
| UseUnderscoresInNumericLiterals | Number 2176782336L should separate every third digit with an underscore | 3 | 61 |
| LongVariable | Avoid excessively long variable names like maxSessionLifespanTics | 3 | 69 |
| FieldNamingConventions | The public constant name 'maxSessionLifespanTics' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 69 |
| UseUnderscoresInNumericLiterals | Number 46656 should separate every third digit with an underscore | 3 | 69 |
| FieldNamingConventions | The public constant name 'ticDifference' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 75 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 85 |
| LocalVariableCouldBeFinal | Local variable 'sessionId' could be declared final | 3 | 87 |
| ShortVariable | Avoid variables with short names like n | 3 | 90 |
| UselessParentheses | Useless parentheses. | 4 | 103 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 138 |
| MethodArgumentCouldBeFinal | Parameter 'jsIdent' is not assigned and could be declared final | 3 | 138 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 142 |
| SystemPrintln | Usage of System.out/err | 2 | 154 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 4 | 154 |
| SystemPrintln | Usage of System.out/err | 2 | 155 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 4 | 155 |
| SystemPrintln | Usage of System.out/err | 2 | 156 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 4 | 156 |
| SystemPrintln | Usage of System.out/err | 2 | 157 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GenerateUniqueId': 'getIdentifier' is already in scope | 4 | 157 |
org/apache/turbine/util/HttpUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 3 | 41 |
| LongVariable | Avoid excessively long variable names like CHARACTERS_NOT_ALLOWED_IN_KEY | 3 | 47 |
| MethodArgumentCouldBeFinal | Parameter 'date' is not assigned and could be declared final | 3 | 65 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'expiry' is not assigned and could be declared final | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'response' could be declared final | 3 | 81 |
| MethodArgumentCouldBeFinal | Parameter 'parameter' is not assigned and could be declared final | 3 | 102 |
| LocalVariableCouldBeFinal | Local variable 'testMatcher' could be declared final | 3 | 103 |
| MethodArgumentCouldBeFinal | Parameter 'parameter' is not assigned and could be declared final | 3 | 113 |
org/apache/turbine/util/InputFilterUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 35 |
| ShortVariable | Avoid variables with short names like s | 3 | 45 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 3 | 45 |
| ShortVariable | Avoid variables with short names like s | 3 | 58 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 3 | 58 |
org/apache/turbine/util/LocaleUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 3 | 61 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 64 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'defaultLocale' | 3 | 67 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'defaultCharSet' | 3 | 70 |
| LocalVariableCouldBeFinal | Local variable 'inputEncoding' could be declared final | 3 | 80 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 100–113 |
| LocalVariableCouldBeFinal | Local variable 'lang' could be declared final | 3 | 103 |
| LocalVariableCouldBeFinal | Local variable 'country' could be declared final | 3 | 107 |
| CognitiveComplexity | The method 'getDefaultCharset()' has a cognitive complexity of 15, current threshold is 15 | 3 | 136 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 138–150 |
| LocalVariableCouldBeFinal | Local variable 'charSet' could be declared final | 3 | 141 |
| LocalVariableCouldBeFinal | Local variable 'locale' could be declared final | 3 | 158 |
| LocalVariableCouldBeFinal | Local variable 'serviceManager' could be declared final | 3 | 164 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 165–178 |
| LocalVariableCouldBeFinal | Local variable 'mimeTypeService' could be declared final | 3 | 169 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 172 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 174 |
| LocalVariableCouldBeFinal | Local variable 'charset' could be declared final | 3 | 215 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 220 |
| MethodArgumentCouldBeFinal | Parameter 'charSet' is not assigned and could be declared final | 3 | 234 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 238 |
org/apache/turbine/util/ObjectUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 45 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 47 |
| MethodArgumentCouldBeFinal | Parameter 'map' is not assigned and could be declared final | 3 | 58 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 59 |
| UnusedAssignment | The initializer for variable 'byteArray' is never used (overwritten on line 81) | 3 | 61 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 62 |
| LocalVariableCouldBeFinal | Local variable 'mapCopy' could be declared final | 3 | 62 |
| LocalVariableCouldBeFinal | Local variable 'i' could be declared final | 3 | 65 |
| LocalVariableCouldBeFinal | Local variable 'entry' could be declared final | 3 | 67 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'objectData' is not assigned and could be declared final | 3 | 96 |
| ShortVariable | Avoid variables with short names like in | 3 | 105 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 117 |
org/apache/turbine/util/RunData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 58 |
| ShortVariable | Avoid variables with short names like ct | 3 | 464 |
| ShortVariable | Avoid variables with short names like sc | 3 | 494 |
org/apache/turbine/util/SecurityCheck.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'data' | 3 | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'securityService' | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 72 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 3 | 73 |
| MethodArgumentCouldBeFinal | Parameter 'failedScreen' is not assigned and could be declared final | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'failedScreen' is not assigned and could be declared final | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'initialize' is not assigned and could be declared final | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 109 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 110 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 3 | 113 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 3 | 113 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 136 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 136 |
| UnusedAssignment | The initializer for variable 'roleObject' is never used (overwritten on lines 142 and 148) | 3 | 138 |
| LawOfDemeter | Call to `getRoleByName` on foreign value `securityService.getRoleManager()` (degree 2) | 3 | 142 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 3 | 142 |
| LawOfDemeter | Call to `getRoleInstance` on foreign value `securityService.getRoleManager()` (degree 2) | 3 | 148 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 3 | 148 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 3 | 149 |
| PrematureDeclaration | Declaration of 'modelManager' can be moved closer to its usages | 3 | 150 |
| LocalVariableCouldBeFinal | Local variable 'modelManager' could be declared final | 3 | 150 |
| LawOfDemeter | Call to `getModelManager` on foreign value `securityService` (degree 1) | 3 | 150 |
| PreserveStackTrace | Thrown exception does not preserve the stack trace of exception 'e' on all code paths | 3 | 152 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 154 |
| UselessParentheses | Useless parentheses. | 4 | 158 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 172 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 173 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 3 | 176 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 3 | 176 |
| CognitiveComplexity | The method 'hasPermission(String)' has a cognitive complexity of 17, current threshold is 15 | 3 | 204 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 204 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 205 |
| UnusedAssignment | The initializer for variable 'permissionObject' is never used (overwritten on lines 210 and 216) | 3 | 207 |
| LawOfDemeter | Call to `getPermissionByName` on foreign value `securityService.getPermissionManager()` (degree 2) | 3 | 210 |
| LawOfDemeter | Call to `getPermissionManager` on foreign value `securityService` (degree 1) | 3 | 210 |
| LawOfDemeter | Call to `getPermissionInstance` on foreign value `securityService.getPermissionManager()` (degree 2) | 3 | 216 |
| LawOfDemeter | Call to `getPermissionManager` on foreign value `securityService` (degree 1) | 3 | 216 |
| LawOfDemeter | Call to `getPermissionManager` on foreign value `securityService` (degree 1) | 3 | 217 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 3 | 220 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 3 | 220 |
| LooseCoupling | Avoid using implementation types like 'RoleSet'; use the interface instead | 3 | 221 |
| LawOfDemeter | Call to `getRoles` on foreign value `acl` (degree 2) | 3 | 221 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 222 |
| LawOfDemeter | Call to `toArray` on foreign value `roles` (degree 2) | 3 | 224 |
| LawOfDemeter | Call to `getAllRoles` on foreign value `securityService.getRoleManager()` (degree 2) | 3 | 233 |
| LawOfDemeter | Call to `getRoleManager` on foreign value `securityService` (degree 1) | 3 | 233 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 234 |
| LawOfDemeter | Call to `toArray` on foreign value `roles` (degree 2) | 3 | 236 |
| LocalVariableCouldBeFinal | Local variable 'modelManager' could be declared final | 3 | 246 |
| LawOfDemeter | Call to `getModelManager` on foreign value `securityService` (degree 1) | 3 | 246 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
org/apache/turbine/util/ServerData.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DataClass | The class 'ServerData' is suspected to be a Data Class (WOC=23.077%, NOPA=0, NOAM=10, WMC=22) | 3 | 42 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverName' | 3 | 45 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverPort' | 3 | 48 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'serverScheme' | 3 | 51 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'scriptName' | 3 | 54 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'contextPath' | 3 | 57 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 60 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 3 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'serverPort' is not assigned and could be declared final | 3 | 72 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 3 | 73 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 3 | 75 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 80 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerName(String) | 1 | 86 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerPort(int) | 1 | 87 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerScheme(String) | 1 | 88 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setScriptName(String) | 1 | 89 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setContextPath(String) | 1 | 90 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 98 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerName(String) | 1 | 102 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerPort(int) | 1 | 103 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerScheme(String) | 1 | 104 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setScriptName(String) | 1 | 105 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setContextPath(String) | 1 | 106 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 115 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerName(String) | 1 | 117 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerPort(int) | 1 | 118 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setServerScheme(String) | 1 | 119 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setScriptName(String) | 1 | 120 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: ServerData.setContextPath(String) | 1 | 121 |
| ProperCloneImplementation | Object clone() should be implemented with super.clone() | 2 | 130 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 3 | 130 |
| CloneMethodMustImplementCloneable | clone() method should be implemented only if implementing Cloneable interface | 3 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 3 | 151 |
| MethodArgumentCouldBeFinal | Parameter 'serverPort' is not assigned and could be declared final | 3 | 172 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 174 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 174 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 3 | 193 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 3 | 214 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 3 | 235 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHostUrl' should not return void linguistically | 3 | 246 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 3 | 246 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 248 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 249 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 251 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 254 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 258 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 258 |
| LocalVariableCouldBeFinal | Local variable 'url' could be declared final | 3 | 271 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 275 |
org/apache/turbine/util/ServletUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | This utility class has a non-private constructor | 3 | 42 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 54 |
| MethodArgumentCouldBeFinal | Parameter 'text' is not assigned and could be declared final | 3 | 55 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 59 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 64 |
| ShortVariable | Avoid variables with short names like sb | 3 | 72 |
| LocalVariableCouldBeFinal | Local variable 'sb' could be declared final | 3 | 72 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 73 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 82 |
| LawOfDemeter | Call to `getServletContext` on foreign value `config` (degree 1) | 3 | 82 |
| LocalVariableCouldBeFinal | Local variable 'base' could be declared final | 3 | 83 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 88 |
| LocalVariableCouldBeFinal | Local variable 'tokenizer' could be declared final | 3 | 91 |
| LocalVariableCouldBeFinal | Local variable 'buffer' could be declared final | 3 | 92 |
org/apache/turbine/util/SystemError.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoNotExtendJavaLangError | Exceptions should not extend java.lang.Error | 3 | 33 |
| MethodArgumentCouldBeFinal | Parameter 'cause' is not assigned and could be declared final | 3 | 43 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 3 | 53 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'cause' is not assigned and could be declared final | 3 | 64 |
org/apache/turbine/util/TurbineConfig.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 1–926 |
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 3 | 1–926 |
| CyclomaticComplexity | The class 'TurbineConfig' has a total cyclomatic complexity of 108 (highest 4). | 3 | 98 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 98 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 100–926 |
| LongVariable | Avoid excessively long variable names like CONFIGURATION_PATH_KEY | 3 | 109 |
| LongVariable | Avoid excessively long variable names like PROPERTIES_PATH_KEY | 3 | 115 |
| LongVariable | Avoid excessively long variable names like PROPERTIES_PATH_DEFAULT | 3 | 121 |
| AvoidFieldNameMatchingMethodName | Field log has the same name as a method | 3 | 137 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 153 |
| MethodArgumentCouldBeFinal | Parameter 'attributes' is not assigned and could be declared final | 3 | 153 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 3 | 154 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 174 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 3 | 174 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 190 |
| MethodArgumentCouldBeFinal | Parameter 'properties' is not assigned and could be declared final | 3 | 190 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>(1)` | 3 | 192 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 208 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 218 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 269 |
| ShortVariable | Avoid variables with short names like f | 3 | 272 |
| LocalVariableCouldBeFinal | Local variable 'f' could be declared final | 3 | 272 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 299 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 3 | 312 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 3 | 312 |
| ShortVariable | Avoid variables with short names like s | 3 | 364 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 3 | 364 |
| ShortVariable | Avoid variables with short names like s | 3 | 378 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 3 | 378 |
| LocalVariableCouldBeFinal | Local variable 'fis' could be declared final | 3 | 382 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 382 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 383 |
| ShortVariable | Avoid variables with short names like m | 3 | 397 |
| MethodArgumentCouldBeFinal | Parameter 'm' is not assigned and could be declared final | 3 | 397 |
| ShortVariable | Avoid variables with short names like m | 3 | 409 |
| MethodArgumentCouldBeFinal | Parameter 'm' is not assigned and could be declared final | 3 | 409 |
| ShortVariable | Avoid variables with short names like t | 3 | 409 |
| MethodArgumentCouldBeFinal | Parameter 't' is not assigned and could be declared final | 3 | 409 |
| ShortVariable | Avoid variables with short names like s | 3 | 419 |
| MethodArgumentCouldBeFinal | Parameter 's' is not assigned and could be declared final | 3 | 419 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 3 | 431 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 3 | 431 |
| ShortVariable | Avoid variables with short names like s | 3 | 444 |
| ShortVariable | Avoid variables with short names like s | 3 | 470 |
| ShortVariable | Avoid variables with short names like s | 3 | 496 |
| ShortVariable | Avoid variables with short names like s | 3 | 509 |
| ShortVariable | Avoid variables with short names like s | 3 | 521 |
| ShortVariable | Avoid variables with short names like s | 3 | 545 |
| ShortVariable | Avoid variables with short names like s | 3 | 557 |
| ShortVariable | Avoid variables with short names like o | 3 | 557 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'jakarta.servlet': 'FilterRegistration' is already in scope because it is imported in this file | 4 | 677 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'jakarta.servlet': 'FilterRegistration' is already in scope because it is imported in this file | 4 | 689 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'jakarta.servlet': 'FilterRegistration' is already in scope because it is imported in this file | 4 | 701 |
| LongVariable | Avoid excessively long variable names like sessionTrackingModes | 3 | 761 |
| ShortVariable | Avoid variables with short names like t | 3 | 809 |
org/apache/turbine/util/TurbineException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 112 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 3 | 124 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 137 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 3 | 137 |
org/apache/turbine/util/TurbineRuntimeException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 3 | 67 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 80 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 3 | 80 |
org/apache/turbine/util/TurbineXmlConfig.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 76 |
| MethodArgumentCouldBeFinal | Parameter 'attributes' is not assigned and could be declared final | 3 | 76 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 3 | 77 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 95 |
| MethodArgumentCouldBeFinal | Parameter 'initParams' is not assigned and could be declared final | 3 | 95 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>(0)` | 3 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 109 |
| MethodArgumentCouldBeFinal | Parameter 'config' is not assigned and could be declared final | 3 | 109 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashMap<>(1)` | 3 | 111 |
org/apache/turbine/util/template/HtmlPageAttributes.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 105–690 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 110 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 125 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'doctype' | 3 | 128 |
| LongVariable | Avoid excessively long variable names like defaultHtmlDoctypeRootElement | 3 | 131 |
| ImmutableField | Field 'defaultHtmlDoctypeRootElement' may be declared final | 3 | 131 |
| LongVariable | Avoid excessively long variable names like defaultHtmlDoctypeIdentifier | 3 | 134 |
| LongVariable | Avoid excessively long variable names like defaultHtmlDoctypeUri | 3 | 137 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: HtmlPageAttributes.init(Object) | 1 | 144 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 156 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTitle' should not return any type except void linguistically | 3 | 183 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 3 | 183 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 200 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 212 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 212 |
| MethodArgumentCouldBeFinal | Parameter 'scriptURL' is not assigned and could be declared final | 3 | 234 |
| MethodArgumentCouldBeFinal | Parameter 'styleSheetURL' is not assigned and could be declared final | 3 | 257 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 272 |
| MethodArgumentCouldBeFinal | Parameter 'styleSheetURL' is not assigned and could be declared final | 3 | 272 |
| MethodArgumentCouldBeFinal | Parameter 'media' is not assigned and could be declared final | 3 | 273 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 3 | 273 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 273 |
| ShortVariable | Avoid variables with short names like ss | 3 | 275 |
| LocalVariableCouldBeFinal | Local variable 'ss' could be declared final | 3 | 275 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 3 | 290 |
| MethodArgumentCouldBeFinal | Parameter 'linkURL' is not assigned and could be declared final | 3 | 290 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 3 | 303 |
| MethodArgumentCouldBeFinal | Parameter 'linkURL' is not assigned and could be declared final | 3 | 303 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 3 | 303 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 317 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 3 | 317 |
| MethodArgumentCouldBeFinal | Parameter 'linkURL' is not assigned and could be declared final | 3 | 317 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 3 | 317 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 318 |
| ShortVariable | Avoid variables with short names like ss | 3 | 320 |
| LocalVariableCouldBeFinal | Local variable 'ss' could be declared final | 3 | 320 |
| MethodArgumentCouldBeFinal | Parameter 'styleText' is not assigned and could be declared final | 3 | 343 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setKeywords' should not return any type except void linguistically | 3 | 365 |
| MethodArgumentCouldBeFinal | Parameter 'keywords' is not assigned and could be declared final | 3 | 365 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setHttpEquiv' should not return any type except void linguistically | 3 | 380 |
| MethodArgumentCouldBeFinal | Parameter 'httpEquiv' is not assigned and could be declared final | 3 | 380 |
| MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 380 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setDescription' should not return any type except void linguistically | 3 | 392 |
| MethodArgumentCouldBeFinal | Parameter 'description' is not assigned and could be declared final | 3 | 392 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setBackground' should not return any type except void linguistically | 3 | 404 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 3 | 404 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setBgColor' should not return any type except void linguistically | 3 | 418 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 3 | 418 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTextColor' should not return any type except void linguistically | 3 | 431 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 3 | 431 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setLinkColor' should not return any type except void linguistically | 3 | 444 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 3 | 444 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setVlinkColor' should not return any type except void linguistically | 3 | 456 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 3 | 456 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setAlinkColor' should not return any type except void linguistically | 3 | 468 |
| MethodArgumentCouldBeFinal | Parameter 'color' is not assigned and could be declared final | 3 | 468 |
| DataClass | The class 'LinkTag' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=10, WMC=15) | 3 | 508 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 3 | 523 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 3 | 523 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: LinkTag.setRelation(String) | 1 | 525 |
| UselessParentheses | Useless parentheses. | 4 | 536 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 544 |
| MethodArgumentCouldBeFinal | Parameter 'url' is not assigned and could be declared final | 3 | 562 |
| UselessParentheses | Useless parentheses. | 4 | 574 |
| MethodArgumentCouldBeFinal | Parameter 'title' is not assigned and could be declared final | 3 | 582 |
| UselessParentheses | Useless parentheses. | 4 | 594 |
| MethodArgumentCouldBeFinal | Parameter 'media' is not assigned and could be declared final | 3 | 602 |
| UselessParentheses | Useless parentheses. | 4 | 614 |
| MethodArgumentCouldBeFinal | Parameter 'relation' is not assigned and could be declared final | 3 | 622 |
| LocalVariableCouldBeFinal | Local variable 'tag' could be declared final | 3 | 643 |
| MethodArgumentCouldBeFinal | Parameter 'tag' is not assigned and could be declared final | 3 | 666 |
| MethodArgumentCouldBeFinal | Parameter 'identifier' is not assigned and could be declared final | 3 | 666 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 3 | 666 |
| LocalVariableCouldBeFinal | Local variable 'doctypeBuf' could be declared final | 3 | 668 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 673 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 674 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 675 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 676 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 681 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 682 |
org/apache/turbine/util/template/TemplateInfo.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like NAVIGATION_TEMPLATE | 3 | 47 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'data' | 3 | 54 |
| ImmutableField | Field 'data' may be declared final | 3 | 54 |
| UnusedAssignment | The field initializer for 'data' is never used (overwritten on line 66) | 3 | 54 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'tempStorage' | 3 | 57 |
| ImmutableField | Field 'tempStorage' may be declared final | 3 | 57 |
| UnusedAssignment | The field initializer for 'tempStorage' is never used (overwritten on line 67) | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 64 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'NAVIGATION_TEMPLATE' is already in scope because it is declared in an enclosing type | 4 | 77 |
| ShortVariable | Avoid variables with short names like v | 3 | 85 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 85 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'NAVIGATION_TEMPLATE' is already in scope because it is declared in an enclosing type | 4 | 87 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 98 |
| ShortVariable | Avoid variables with short names like v | 3 | 107 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 107 |
| LawOfDemeter | Call to `getParameters` on foreign value `data` (degree 1) | 3 | 109 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 117 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 120–125 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 120 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'value' | 3 | 135 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 135 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'LAYOUT_TEMPLATE' is already in scope because it is declared in an enclosing type | 4 | 135 |
| ShortVariable | Avoid variables with short names like v | 3 | 144 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 144 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'LAYOUT_TEMPLATE' is already in scope because it is declared in an enclosing type | 4 | 146 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 156 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 167 |
| ShortVariable | Avoid variables with short names like v | 3 | 167 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 167 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'SERVICE_NAME' is already in scope because it is declared in an enclosing type | 4 | 179 |
| ShortVariable | Avoid variables with short names like v | 3 | 187 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 187 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'TemplateInfo': 'SERVICE_NAME' is already in scope because it is declared in an enclosing type | 4 | 189 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 198 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'def' is not assigned and could be declared final | 3 | 210 |
| LocalVariableCouldBeFinal | Local variable 'val' could be declared final | 3 | 214 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 215 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 217 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 229 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 229 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 240 |
| LocalVariableCouldBeFinal | Local variable 'object' could be declared final | 3 | 243 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 257 |
| LocalVariableCouldBeFinal | Local variable 'object' could be declared final | 3 | 260 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 275 |
org/apache/turbine/util/template/TemplateNavigation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 49 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'template' | 3 | 55 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 62 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 74 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 97 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `pipelineData.getRunData()` (degree 1) | 3 | 100 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 101 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 108 |
| ExceptionAsFlowControl | Exception thrown at line 108 is caught in this block. | 3 | 113–121 |
| ExceptionAsFlowControl | Exception thrown at line 97 is caught in this block. | 3 | 113–121 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 113 |
org/apache/turbine/util/template/TemplateScreen.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 52 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 65 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically | 3 | 77 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 77 |
| LocalVariableCouldBeFinal | Local variable 'results' could be declared final | 3 | 95 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 102 |
org/apache/turbine/util/template/TemplateSecurityCheck.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'message' is not assigned and could be declared final | 3 | 68 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateSecurityCheck.setMessage(String) | 1 | 71 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 79 |
| LocalVariableCouldBeFinal | Local variable 'templateService' could be declared final | 3 | 82 |
| MethodArgumentCouldBeFinal | Parameter 'role' is not assigned and could be declared final | 3 | 94 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 95 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 99 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 3 | 102 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 3 | 102 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 106 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 108 |
| MethodArgumentCouldBeFinal | Parameter 'permission' is not assigned and could be declared final | 3 | 121 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 122 |
| LocalVariableCouldBeFinal | Local variable 'acl' could be declared final | 3 | 125 |
| LawOfDemeter | Call to `getACL` on foreign value `data` (degree 1) | 3 | 125 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 129 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 144 |
| LocalVariableCouldBeFinal | Local variable 'userManager' could be declared final | 3 | 149 |
| LawOfDemeter | Call to `getUser` on foreign value `data` (degree 1) | 3 | 155 |
| LawOfDemeter | Call to `getTemplateInfo` on foreign value `data` (degree 1) | 3 | 160 |
| ShortVariable | Avoid variables with short names like v | 3 | 173 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 173 |
| ShortVariable | Avoid variables with short names like v | 3 | 204 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 204 |
| ShortVariable | Avoid variables with short names like v | 3 | 224 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 224 |
org/apache/turbine/util/uri/BaseURI.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 51 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'redirect' | 3 | 58 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'response' | 3 | 61 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'reference' | 3 | 64 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 1 | 82 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 90 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 1 | 93 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 102 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 102 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 1 | 105 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setRedirect(boolean) | 1 | 106 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 114 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 1 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 126 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 126 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setResponse(HttpServletResponse) | 1 | 129 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: BaseURI.setRedirect(boolean) | 1 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 148 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 164 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 181 |
| MethodArgumentCouldBeFinal | Parameter 'scriptName' is not assigned and could be declared final | 3 | 213 |
| MethodArgumentCouldBeFinal | Parameter 'contextPath' is not assigned and could be declared final | 3 | 234 |
| MethodArgumentCouldBeFinal | Parameter 'serverName' is not assigned and could be declared final | 3 | 255 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 272 |
| MethodArgumentCouldBeFinal | Parameter 'serverPort' is not assigned and could be declared final | 3 | 289 |
| MethodArgumentCouldBeFinal | Parameter 'port' is not assigned and could be declared final | 3 | 311 |
| LocalVariableCouldBeFinal | Local variable 'useSSL' could be declared final | 3 | 313 |
| MethodArgumentCouldBeFinal | Parameter 'serverScheme' is not assigned and could be declared final | 3 | 327 |
| LocalVariableCouldBeFinal | Local variable 'serverScheme' could be declared final | 3 | 342 |
| MethodArgumentCouldBeFinal | Parameter 'reference' is not assigned and could be declared final | 3 | 352 |
| MethodArgumentCouldBeFinal | Parameter 'response' is not assigned and could be declared final | 3 | 393 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getContextAndScript' should not return void linguistically | 3 | 421 |
| ShortVariable | Avoid variables with short names like sb | 3 | 421 |
| MethodArgumentCouldBeFinal | Parameter 'sb' is not assigned and could be declared final | 3 | 421 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 423 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 3 | 427 |
| LocalVariableCouldBeFinal | Local variable 'script' could be declared final | 3 | 435 |
| AvoidLiteralsInIfCondition | Avoid using literals in if statements | 3 | 439 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getSchemeAndPort' should not return void linguistically | 3 | 459 |
| ShortVariable | Avoid variables with short names like sb | 3 | 459 |
| MethodArgumentCouldBeFinal | Parameter 'sb' is not assigned and could be declared final | 3 | 459 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 462 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 463 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'URIConstants': 'URI_SCHEME_SEPARATOR' is already in scope because it is inherited by an enclosing type | 4 | 463 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 467 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 469 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 472 |
| MethodArgumentCouldBeFinal | Parameter 'uri' is not assigned and could be declared final | 3 | 486 |
| LocalVariableCouldBeFinal | Local variable 'response' could be declared final | 3 | 490 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 510 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 512 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 517 |
org/apache/turbine/util/uri/DataURI.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 57 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 68 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 78 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 89 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 89 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 3 | 126 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 133 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 3 | 164 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 170 |
org/apache/turbine/util/uri/TemplateURI.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 59 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 70 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 70 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 81 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 81 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 1 | 84 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 94 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 94 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 94 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 1 | 97 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 107 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 107 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 107 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 110 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 121 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 121 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 121 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 121 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 124 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 132 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 143 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 143 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 154 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 154 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 1 | 157 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 167 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 167 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 167 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 1 | 170 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 180 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 180 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 180 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 183 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 194 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 194 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 194 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 194 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 197 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 206 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 206 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TemplateURI.setTemplate(String) | 1 | 209 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 222 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 266 |
| ShortVariable | Avoid variables with short names like pp | 3 | 267 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 267 |
| LocalVariableCouldBeFinal | Local variable 'name' could be declared final | 3 | 269 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 271 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 3 | 275 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 278 |
org/apache/turbine/util/uri/TurbineURI.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| GodClass | Possible God Class (WMC=74, ATFD=9, TCC=9.725%) | 3 | 55 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 55 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 57–916 |
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 59 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'dataVectors' | 3 | 62 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 93 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 105 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 105 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 117 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 117 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 1 | 120 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 130 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 130 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 1 | 133 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 143 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 143 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 143 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 146 |
| MethodArgumentCouldBeFinal | Parameter 'runData' is not assigned and could be declared final | 3 | 157 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 157 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 157 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 157 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 160 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 168 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 180 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 180 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 192 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 192 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 1 | 195 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 205 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 205 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 205 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 1 | 208 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 218 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 218 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 218 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 221 |
| MethodArgumentCouldBeFinal | Parameter 'serverData' is not assigned and could be declared final | 3 | 232 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 232 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 232 |
| MethodArgumentCouldBeFinal | Parameter 'redirect' is not assigned and could be declared final | 3 | 233 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 236 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 245 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 245 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setScreen(String) | 1 | 248 |
| ConstructorCallsOverridableMethod | Overridable method called during object construction: TurbineURI.setAction(String) | 1 | 249 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 2 | 278 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 291 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 3 | 309 |
| MethodArgumentCouldBeFinal | Parameter 'action' is not assigned and could be declared final | 3 | 325 |
| MethodArgumentCouldBeFinal | Parameter 'event' is not assigned and could be declared final | 3 | 325 |
| MethodArgumentCouldBeFinal | Parameter 'screen' is not assigned and could be declared final | 3 | 351 |
| ShortVariable | Avoid variables with short names like pp | 3 | 386 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 386 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 3 | 397 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 408 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 408 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 419 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 419 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 430 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 430 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 441 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 441 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 452 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 452 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 463 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 463 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 474 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 474 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 485 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 485 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 496 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 496 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 507 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 507 |
| ShortVariable | Avoid variables with short names like pp | 3 | 518 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 518 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 3 | 528 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 556 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 584 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 3 | 622 |
| LocalVariableCouldBeFinal | Local variable 'output' could be declared final | 3 | 655 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 3 | 670 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 682 |
| MethodArgumentCouldBeFinal | Parameter 'pathInfo' is not assigned and could be declared final | 3 | 712 |
| MethodArgumentCouldBeFinal | Parameter 'queryData' is not assigned and could be declared final | 3 | 736 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getPathInfoAsString' should not return void linguistically | 3 | 768 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 3 | 768 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getQueryDataAsString' should not return void linguistically | 3 | 778 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 3 | 778 |
| MethodArgumentCouldBeFinal | Parameter 'string' is not assigned and could be declared final | 3 | 789 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 794 |
| MethodArgumentCouldBeFinal | Parameter 'output' is not assigned and could be declared final | 3 | 812 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 3 | 812 |
| MethodArgumentCouldBeFinal | Parameter 'fieldDelim' is not assigned and could be declared final | 3 | 812 |
| MethodArgumentCouldBeFinal | Parameter 'valueDelim' is not assigned and could be declared final | 3 | 812 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 837 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 838 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 839 |
| LocalVariableCouldBeFinal | Local variable 'uriParam' could be declared final | 3 | 841 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 858 |
| ShortVariable | Avoid variables with short names like pp | 3 | 859 |
| MethodArgumentCouldBeFinal | Parameter 'pp' is not assigned and could be declared final | 3 | 859 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 861 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 863 |
| LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 864 |
| LocalVariableCouldBeFinal | Local variable 'values' could be declared final | 3 | 866 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 869 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 895 |
| MethodArgumentCouldBeFinal | Parameter 'list' is not assigned and could be declared final | 3 | 895 |
| MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 910 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 910 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 912 |
org/apache/turbine/util/uri/URI.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like URI | 4 | 32 |
org/apache/turbine/util/uri/URIConstants.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 36 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 39 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 42 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 45 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 48 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 51 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 54 |
| LongVariable | Avoid excessively long variable names like URI_SCHEME_SEPARATOR | 3 | 60 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 60 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 63 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 66 |
| LongVariable | Avoid excessively long variable names like CGI_TEMPLATE_PARAM | 3 | 69 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 69 |
| ConstantsInInterface | Using constants in interfaces is a bad practice. | 3 | 72 |
org/apache/turbine/util/uri/URIParam.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'key' | 3 | 37 |
| ImmutableField | Field 'key' may be declared final | 3 | 37 |
| UnusedAssignment | The field initializer for 'key' is never used (overwritten on line 51) | 3 | 37 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'value' | 3 | 40 |
| ImmutableField | Field 'value' may be declared final | 3 | 40 |
| UnusedAssignment | The field initializer for 'value' is never used (overwritten on line 52) | 3 | 40 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 49 |
| MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 49 |
| UselessParentheses | Useless parentheses. | 4 | 63 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 90 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 93 |
| ControlStatementBraces | This statement should have braces | 3 | 93 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 95 |
| ControlStatementBraces | This statement should have braces | 3 | 95 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 97 |
| ControlStatementBraces | This statement should have braces | 3 | 97 |
| LocalVariableCouldBeFinal | Local variable 'other' could be declared final | 3 | 98 |
org/apache/turbine/util/uri/URIUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 34 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 47 |
| ShortVariable | Avoid variables with short names like du | 3 | 49 |
| LocalVariableCouldBeFinal | Local variable 'du' could be declared final | 3 | 49 |
org/apache/turbine/util/velocity/VelocityActionEvent.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 51 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'initialized' | 3 | 58 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 66 |
| MethodArgumentCouldBeFinal | Parameter 'pipelineData' is not assigned and could be declared final | 3 | 77 |
| ShortVariable | Avoid variables with short names like pp | 3 | 85 |
| LocalVariableCouldBeFinal | Local variable 'pp' could be declared final | 3 | 85 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 86 |
org/apache/turbine/util/velocity/VelocityEmail.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 107 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'wordWrap' | 3 | 110 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'template' | 3 | 116 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'context' | 3 | 119 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 133 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTo' should not return any type except void linguistically | 3 | 149 |
| MethodArgumentCouldBeFinal | Parameter 'toName' is not assigned and could be declared final | 3 | 149 |
| MethodArgumentCouldBeFinal | Parameter 'toEmail' is not assigned and could be declared final | 3 | 149 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically | 3 | 164 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 164 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setWordWrap' should not return any type except void linguistically | 3 | 181 |
| MethodArgumentCouldBeFinal | Parameter 'wordWrap' is not assigned and could be declared final | 3 | 181 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setContext' should not return any type except void linguistically | 3 | 194 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 194 |
| MethodArgumentCouldBeFinal | Parameter 'serverAddress' is not assigned and could be declared final | 3 | 218 |
| UnusedAssignment | The initializer for variable 'body' is never used (overwritten on line 256) | 3 | 251 |
| LocalVariableCouldBeFinal | Local variable 'velocityService' could be declared final | 3 | 255 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 258 |
org/apache/turbine/util/velocity/VelocityEmailException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 53 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 3 | 65 |
| MethodArgumentCouldBeFinal | Parameter 'msg' is not assigned and could be declared final | 3 | 78 |
| MethodArgumentCouldBeFinal | Parameter 'nested' is not assigned and could be declared final | 3 | 78 |
org/apache/turbine/util/velocity/VelocityHtmlEmail.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 88 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'htmlTemplate' | 3 | 94 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'textTemplate' | 3 | 100 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'context' | 3 | 103 |
| LooseCoupling | Avoid using implementation types like 'Hashtable'; use the interface instead | 3 | 106 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 106 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'embmap' | 3 | 106 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 124 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 3 | 128 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setHtmlTemplate' should not return any type except void linguistically | 3 | 139 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 139 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setTextTemplate' should not return any type except void linguistically | 3 | 153 |
| MethodArgumentCouldBeFinal | Parameter 'template' is not assigned and could be declared final | 3 | 153 |
| MethodArgumentCouldBeFinal | Parameter 'serverAddress' is not assigned and could be declared final | 3 | 166 |
| LocalVariableCouldBeFinal | Local variable 'velocityService' could be declared final | 3 | 199 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 210 |
| MethodArgumentCouldBeFinal | Parameter 'surl' is not assigned and could be declared final | 3 | 243 |
| MethodArgumentCouldBeFinal | Parameter 'name' is not assigned and could be declared final | 3 | 243 |
| LocalVariableCouldBeFinal | Local variable 'url' could be declared final | 3 | 248 |
| MethodArgumentCouldBeFinal | Parameter 'filename' is not assigned and could be declared final | 3 | 266 |
| LocalVariableCouldBeFinal | Local variable 'cid' could be declared final | 3 | 268 |
org/apache/turbine/services/schedule/BaseJobEntryTorque.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 25 |
| GodClass | Possible God Class (WMC=80, ATFD=31, TCC=5.867%) | 3 | 25 |
| CyclomaticComplexity | The class 'BaseJobEntryTorque' has a total cyclomatic complexity of 80 (highest 12). | 3 | 25 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 25 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'AbstractJobEntry' is already in scope because it is declared in the same package | 4 | 25 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 27–887 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'jobId' | 3 | 34 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'task' | 3 | 52 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'email' | 3 | 55 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'property' | 3 | 58 |
| AvoidFieldNameMatchingMethodName | Field isNew has the same name as a method | 3 | 67 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'saving' | 3 | 70 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'loading' | 3 | 76 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'deleted' | 3 | 83 |
| MissingOverride | The method 'getJobId()' is missing an @Override annotation. | 3 | 94 |
| MissingOverride | The method 'setJobId(int)' is missing an @Override annotation. | 3 | 105 |
| ShortVariable | Avoid variables with short names like v | 3 | 105 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 105 |
| MissingOverride | The method 'getSecond()' is missing an @Override annotation. | 3 | 122 |
| MissingOverride | The method 'setSecond(int)' is missing an @Override annotation. | 3 | 133 |
| ShortVariable | Avoid variables with short names like v | 3 | 133 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 133 |
| MissingOverride | The method 'getMinute()' is missing an @Override annotation. | 3 | 150 |
| MissingOverride | The method 'setMinute(int)' is missing an @Override annotation. | 3 | 161 |
| ShortVariable | Avoid variables with short names like v | 3 | 161 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 161 |
| MissingOverride | The method 'getHour()' is missing an @Override annotation. | 3 | 178 |
| MissingOverride | The method 'setHour(int)' is missing an @Override annotation. | 3 | 189 |
| ShortVariable | Avoid variables with short names like v | 3 | 189 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 189 |
| MissingOverride | The method 'getWeekDay()' is missing an @Override annotation. | 3 | 206 |
| MissingOverride | The method 'setWeekDay(int)' is missing an @Override annotation. | 3 | 217 |
| ShortVariable | Avoid variables with short names like v | 3 | 217 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 217 |
| MissingOverride | The method 'getDayOfMonth()' is missing an @Override annotation. | 3 | 234 |
| MissingOverride | The method 'setDayOfMonth(int)' is missing an @Override annotation. | 3 | 245 |
| ShortVariable | Avoid variables with short names like v | 3 | 245 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 245 |
| MissingOverride | The method 'getTask()' is missing an @Override annotation. | 3 | 262 |
| MissingOverride | The method 'setTask(String)' is missing an @Override annotation. | 3 | 273 |
| ShortVariable | Avoid variables with short names like v | 3 | 273 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 273 |
| ShortVariable | Avoid variables with short names like v | 3 | 301 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 301 |
| MethodReturnsInternalArray | Returning 'property' may expose an internal array. | 3 | 321 |
| ShortVariable | Avoid variables with short names like v | 3 | 329 |
| MethodArgumentCouldBeFinal | Parameter 'v' is not assigned and could be declared final | 3 | 329 |
| ArrayIsStoredDirectly | The user-supplied array 'v' is stored directly. | 3 | 336 |
| MissingOverride | The method 'isNew()' is missing an @Override annotation. | 3 | 349 |
| MissingOverride | The method 'setNew(boolean)' is missing an @Override annotation. | 3 | 359 |
| MethodArgumentCouldBeFinal | Parameter 'isNew' is not assigned and could be declared final | 3 | 359 |
| MissingOverride | The method 'isModified()' is missing an @Override annotation. | 3 | 369 |
| MissingOverride | The method 'setModified(boolean)' is missing an @Override annotation. | 3 | 379 |
| MethodArgumentCouldBeFinal | Parameter 'modified' is not assigned and could be declared final | 3 | 379 |
| MethodArgumentCouldBeFinal | Parameter 'saving' is not assigned and could be declared final | 3 | 408 |
| MethodArgumentCouldBeFinal | Parameter 'loading' is not assigned and could be declared final | 3 | 429 |
| MethodArgumentCouldBeFinal | Parameter 'deleted' is not assigned and could be declared final | 3 | 456 |
| MissingOverride | The method 'save()' is missing an @Override annotation. | 3 | 474 |
| MissingOverride | The method 'save(String)' is missing an @Override annotation. | 3 | 488 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 3 | 488 |
| MissingOverride | The method 'save(Connection)' is missing an @Override annotation. | 3 | 509 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 509 |
| MissingOverride | The method 'setPrimaryKey(ObjectKey<?>)' is missing an @Override annotation. | 3 | 548 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 548 |
| MissingOverride | The method 'setPrimaryKey(String)' is missing an @Override annotation. | 3 | 559 |
| MethodArgumentCouldBeFinal | Parameter 'key' is not assigned and could be declared final | 3 | 559 |
| MissingOverride | The method 'getPrimaryKey()' is missing an @Override annotation. | 3 | 569 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 597 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 3 | 612 |
| LocalVariableCouldBeFinal | Local variable 'jobEntryTorque' could be declared final | 3 | 614 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 3 | 630 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 630 |
| LocalVariableCouldBeFinal | Local variable 'jobEntryTorque' could be declared final | 3 | 632 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 3 | 644 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 3 | 657 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 657 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 3 | 671 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 3 | 671 |
| EmptyControlStatement | Empty if statement | 3 | 683–685 |
| MethodArgumentCouldBeFinal | Parameter 'copyObj' is not assigned and could be declared final | 3 | 700 |
| MethodArgumentCouldBeFinal | Parameter 'deepcopy' is not assigned and could be declared final | 3 | 700 |
| EmptyControlStatement | Empty if statement | 3 | 712–714 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 4 | 719 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 719 |
| FieldNamingConventions | The constant name 'peer' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 719 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 4 | 720 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 4 | 728 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 4 | 742 |
| MissingOverride | The method 'toString()' is missing an @Override annotation. | 3 | 747 |
| LocalVariableCouldBeFinal | Local variable 'str' could be declared final | 3 | 749 |
| InsufficientStringBufferDeclaration | StringBuffer has been initialized with size 16, but has at least 115 characters appended. | 3 | 749 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 750 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 750 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 751–753 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 753 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 753 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 754–756 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 756 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 756 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 757–759 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 759 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 759 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 760–762 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 762 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 762 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 763–765 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 765 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 765 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 766–768 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 768 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 768 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 769–771 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 771 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 3 | 771 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 772–774 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 774 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. | 3 | 774 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 777 |
| UselessParentheses | Useless parentheses. | 4 | 778 |
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 3 | 788 |
| MethodArgumentCouldBeFinal | Parameter 'toCompare' is not assigned and could be declared final | 3 | 788 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 792 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 796 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 800 |
| LocalVariableCouldBeFinal | Local variable 'other' could be declared final | 3 | 802 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 805 |
| MissingOverride | The method 'hashCode()' is missing an @Override annotation. | 3 | 816 |
| ShortVariable | Avoid variables with short names like ok | 3 | 818 |
| LocalVariableCouldBeFinal | Local variable 'ok' could be declared final | 3 | 818 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 821 |
| CyclomaticComplexity | The method 'valueEquals(JobEntryTorque)' has a cyclomatic complexity of 12. | 3 | 836 |
| NPathComplexity | The method 'valueEquals(JobEntryTorque)' has an NPath complexity of 2048, current threshold is 200 | 3 | 836 |
| MethodArgumentCouldBeFinal | Parameter 'toCompare' is not assigned and could be declared final | 3 | 836 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 840 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 3 | 842 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 844 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 848 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 852 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 856 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 860 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 864 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 868 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 872 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 876 |
| SimplifyBooleanReturns | This if statement can be replaced by `return !{condition};` | 3 | 878–881 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 880 |
org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CouplingBetweenObjects | High amount of different objects as members denotes a high coupling | 3 | 1–1477 |
| GodClass | Possible God Class (WMC=68, ATFD=109, TCC=0.045%) | 3 | 36 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3 | 36 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 36 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 37–1477 |
| FieldNamingConventions | The public constant name 'numColumns' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 66 |
| LongVariable | Avoid excessively long variable names like jobEntryTorquePeerImpl | 3 | 70 |
| LocalVariableCouldBeFinal | Local variable 'dbMap' could be declared final | 3 | 75 |
| LawOfDemeter | Call to `getDatabaseMap` on foreign value `Torque.getOrCreateDatabase("default")` (degree 1) | 3 | 75–76 |
| AvoidDuplicateLiterals | The String literal "TURBINE_SCHEDULED_JOB" appears 5 times in this file; the first occurrence is on line 77 | 3 | 77 |
| LawOfDemeter | Call to `getTable` on foreign value `dbMap` (degree 2) | 3 | 84 |
| LawOfDemeter | Call to `setJavaName` on foreign value `TABLE` (degree 2) | 3 | 85 |
| LawOfDemeter | Call to `setOMClass` on foreign value `TABLE` (degree 2) | 3 | 86 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorque' is already in scope because it is declared in the same package | 4 | 86 |
| LawOfDemeter | Call to `setPeerClass` on foreign value `TABLE` (degree 2) | 3 | 87 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'JobEntryTorquePeer' is already in scope because it is declared in the same package | 4 | 87 |
| LawOfDemeter | Call to `setPrimaryKeyMethod` on foreign value `TABLE` (degree 2) | 3 | 88 |
| LawOfDemeter | Call to `setPrimaryKeyMethodInfo` on foreign value `TABLE` (degree 2) | 3 | 89 |
| LawOfDemeter | Call to `getName` on foreign value `TABLE` (degree 2) | 3 | 89 |
| LawOfDemeter | Call to `setPrimaryKeyMethodInfo` on foreign value `TABLE` (degree 2) | 3 | 90 |
| LawOfDemeter | Call to `setPrimaryKeyMethodInfo` on foreign value `TABLE` (degree 2) | 3 | 91 |
| LawOfDemeter | Call to `setUseInheritance` on foreign value `TABLE` (degree 2) | 3 | 92 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 97 |
| AvoidDuplicateLiterals | The String literal "INTEGER" appears 6 times in this file; the first occurrence is on line 98 | 3 | 98 |
| AvoidDuplicateLiterals | The String literal "int" appears 6 times in this file; the first occurrence is on line 105 | 3 | 105 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 107 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 110 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 121 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 124 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 135 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 138 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 149 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 152 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 163 |
| UnnecessaryBoxing | Unnecessary explicit boxing | 3 | 166 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 177 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 191 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 205 |
| LawOfDemeter | Call to `addColumn` on foreign value `TABLE` (degree 2) | 3 | 218 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'instance' | 3 | 232 |
| LocalVariableCouldBeFinal | Local variable 'instance' could be declared final | 3 | 232 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'JobEntryTorquePeer': 'BaseJobEntryTorquePeer::createJobEntryTorquePeerImpl' is already in scope | 4 | 248 |
| MethodArgumentCouldBeFinal | Parameter 'peerImplInstance' is not assigned and could be declared final | 3 | 263 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 274 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 291 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 309 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 3 | 309 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 325 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 344 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 345 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 368 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 369 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 387 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 388 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 408 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 409 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 410 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 437 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 438 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 439 |
| MethodArgumentCouldBeFinal | Parameter 'query' is not assigned and could be declared final | 3 | 462 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 463 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 3 | 464 |
| MethodArgumentCouldBeFinal | Parameter 'query' is not assigned and could be declared final | 3 | 486 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 487 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 488 |
| MethodArgumentCouldBeFinal | Parameter 'query' is not assigned and could be declared final | 3 | 514 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 515 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 516 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 534 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 551 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 570 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 571 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.torque.criteria': 'Criteria' is already in scope because it is imported in this file | 4 | 589 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 589 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 590 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.torque.criteria': 'Criteria' is already in scope because it is imported in this file | 4 | 611 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 611 |
| MethodArgumentCouldBeFinal | Parameter 'mapper' is not assigned and could be declared final | 3 | 612 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 613 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 632 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 658 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 3 | 658 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 676 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 3 | 676 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 676 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 687 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 703 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 703 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 3 | 788 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 808 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 3 | 808 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 827 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 3 | 827 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 827 |
| MethodArgumentCouldBeFinal | Parameter 'selectCriteria' is not assigned and could be declared final | 3 | 846 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 847 |
| MethodArgumentCouldBeFinal | Parameter 'updateValues' is not assigned and could be declared final | 3 | 847 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 869 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 870 |
| MethodArgumentCouldBeFinal | Parameter 'updateValues' is not assigned and could be declared final | 3 | 870 |
| MethodArgumentCouldBeFinal | Parameter 'connection' is not assigned and could be declared final | 3 | 871 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 891 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 908 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 908 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 3 | 927 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 3 | 949 |
| MethodArgumentCouldBeFinal | Parameter 'replacementValues' is not assigned and could be declared final | 3 | 950 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 3 | 976 |
| MethodArgumentCouldBeFinal | Parameter 'dbName' is not assigned and could be declared final | 3 | 977 |
| MethodArgumentCouldBeFinal | Parameter 'replacementValues' is not assigned and could be declared final | 3 | 978 |
| MethodArgumentCouldBeFinal | Parameter 'statementString' is not assigned and could be declared final | 3 | 1003 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1004 |
| MethodArgumentCouldBeFinal | Parameter 'replacementValues' is not assigned and could be declared final | 3 | 1005 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 1116 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 1135 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1135 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 1151 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 1170 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1170 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 3 | 1187 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 3 | 1209 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1210 |
| ShortVariable | Avoid variables with short names like pk | 3 | 1226 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 1226 |
| ShortVariable | Avoid variables with short names like pk | 3 | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 1245 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1245 |
| ShortVariable | Avoid variables with short names like pk | 3 | 1257 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 1257 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 1269 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 3 | 1282 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 1292 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 1303 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 1314 |
| MethodArgumentCouldBeFinal | Parameter 'jobEntryTorque' is not assigned and could be declared final | 3 | 1314 |
| ShortVariable | Avoid variables with short names like pk | 3 | 1330 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 1330 |
| ShortVariable | Avoid variables with short names like pk | 3 | 1346 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 1346 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1346 |
| ShortVariable | Avoid variables with short names like pk | 3 | 1364 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 1364 |
| ShortVariable | Avoid variables with short names like pk | 3 | 1380 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 1380 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1380 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 1397 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 1415 |
| MethodArgumentCouldBeFinal | Parameter 'dbcon' is not assigned and could be declared final | 3 | 1416 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 1432 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 1449 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 1449 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1 | 1472 |
org/apache/turbine/services/schedule/BaseJobEntryTorquePeerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'java.util.Map' | 4 | 7 |
| UnnecessaryImport | Unused import 'java.util.Objects' | 4 | 8 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 38–552 |
| MethodArgumentCouldBeFinal | Parameter 'recordMapper' is not assigned and could be declared final | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'tableMap' is not assigned and could be declared final | 3 | 65 |
| MethodArgumentCouldBeFinal | Parameter 'databaseName' is not assigned and could be declared final | 3 | 66 |
| MissingOverride | The method 'doUpdate(ColumnValues, Connection)' is missing an @Override annotation. | 3 | 94 |
| MethodArgumentCouldBeFinal | Parameter 'columnValues' is not assigned and could be declared final | 3 | 94 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 94 |
| LocalVariableCouldBeFinal | Local variable 'selectCriteria' could be declared final | 3 | 97 |
| LocalVariableCouldBeFinal | Local variable 'pkValue' could be declared final | 3 | 101 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'rowCount' | 3 | 125 |
| LocalVariableCouldBeFinal | Local variable 'rowCount' could be declared final | 3 | 125 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 139 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 141 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 159 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 159 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 162 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 3 | 178 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 181 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 3 | 202 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 203 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 206 |
| MissingOverride | The method 'buildCriteria(ObjectKey<?>)' is missing an @Override annotation. | 3 | 217 |
| ShortVariable | Avoid variables with short names like pk | 3 | 217 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 217 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 3 | 219 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 231 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 3 | 233 |
| MethodArgumentCouldBeFinal | Parameter 'objects' is not assigned and could be declared final | 3 | 247 |
| LambdaCanBeMethodReference | Lambda expression could be written as a method reference: `BaseJobEntryTorque::getPrimaryKey` | 3 | 250 |
| MissingOverride | The method 'buildCriteria(JobEntryTorque)' is missing an @Override annotation. | 3 | 260 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 260 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 3 | 262 |
| MissingOverride | The method 'buildSelectCriteria(JobEntryTorque)' is missing an @Override annotation. | 3 | 284 |
| MethodArgumentCouldBeFinal | Parameter 'obj' is not assigned and could be declared final | 3 | 284 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 3 | 286 |
| MissingOverride | The method 'buildColumnValues(JobEntryTorque)' is missing an @Override annotation. | 3 | 312 |
| MethodArgumentCouldBeFinal | Parameter 'jobEntryTorque' is not assigned and could be declared final | 3 | 312 |
| LooseCoupling | Avoid using implementation types like 'ColumnValues'; use the interface instead | 3 | 315 |
| LocalVariableCouldBeFinal | Local variable 'columnValues' could be declared final | 3 | 315 |
| ShortVariable | Avoid variables with short names like pk | 3 | 377 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 377 |
| ShortVariable | Avoid variables with short names like pk | 3 | 393 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 393 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 393 |
| ShortVariable | Avoid variables with short names like pk | 3 | 411 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 411 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 416 |
| ShortVariable | Avoid variables with short names like pk | 3 | 432 |
| MethodArgumentCouldBeFinal | Parameter 'pk' is not assigned and could be declared final | 3 | 432 |
| MethodArgumentCouldBeFinal | Parameter 'con' is not assigned and could be declared final | 3 | 432 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 3 | 435 |
| ShortVariable | Avoid variables with short names like v | 3 | 436 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 3 | 436 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 457 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 462 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 481 |
| MethodArgumentCouldBeFinal | Parameter 'dbcon' is not assigned and could be declared final | 3 | 482 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 485 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 487 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 3 | 487 |
| LocalVariableCouldBeFinal | Local variable 'objectKeyList' could be declared final | 3 | 489 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 3 | 489 |
| LocalVariableCouldBeFinal | Local variable 'pk' could be declared final | 3 | 490 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 3 | 494 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 495 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 495 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 510 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 515 |
| MethodArgumentCouldBeFinal | Parameter 'pks' is not assigned and could be declared final | 3 | 534 |
| MethodArgumentCouldBeFinal | Parameter 'dbcon' is not assigned and could be declared final | 3 | 535 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 538 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 540 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new ArrayList<>()` | 3 | 540 |
| LocalVariableCouldBeFinal | Local variable 'criteria' could be declared final | 3 | 542 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'result' | 3 | 543 |
| LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 543 |
org/apache/turbine/services/schedule/BaseJobEntryTorqueRecordMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 27 |
| GodClass | Possible God Class (WMC=62, ATFD=51, TCC=1.818%) | 3 | 27 |
| ProperLogger | Logger should be defined private static final and have the correct class | 3 | 33 |
| LongVariable | Avoid excessively long variable names like WEEK_DAY_EXPRESSION | 3 | 40 |
| LongVariable | Avoid excessively long variable names like DAY_OF_MONTH_EXPRESSION | 3 | 41 |
| LongVariable | Avoid excessively long variable names like PROPERTY_EXPRESSION | 3 | 44 |
| LongVariable | Avoid excessively long variable names like useMappingStrategy | 3 | 46 |
| ImmutableField | Field 'useMappingStrategy' may be declared final | 3 | 46 |
| NonSerializableClass | The field 'strategy' of serializable class 'org.apache.turbine.services.schedule.BaseJobEntryTorqueRecordMapper' is of non-serializable type 'org.apache.torque.om.mapper.MappingStrategy<org.apache.turbine.services.schedule.JobEntryTorque>'. | 3 | 48 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new MappingStrategy<>()` | 3 | 52 |
| NcssCount | The method 'processRow(ResultSet, int, Criteria)' has a NCSS line count of 96. | 3 | 77 |
| CognitiveComplexity | The method 'processRow(ResultSet, int, Criteria)' has a cognitive complexity of 103, current threshold is 15 | 3 | 77 |
| CyclomaticComplexity | The method 'processRow(ResultSet, int, Criteria)' has a cyclomatic complexity of 33. | 3 | 77 |
| NPathComplexity | The method 'processRow(ResultSet, int, Criteria)' has an NPath complexity of 234, current threshold is 200 | 3 | 77 |
| MissingOverride | The method 'processRow(ResultSet, int, Criteria)' is missing an @Override annotation. | 3 | 77 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 78 |
| MethodArgumentCouldBeFinal | Parameter 'offset' is not assigned and could be declared final | 3 | 79 |
| MethodArgumentCouldBeFinal | Parameter 'criteria' is not assigned and could be declared final | 3 | 80 |
| LocalVariableCouldBeFinal | Local variable 'jobEntryTorque' could be declared final | 3 | 83 |
| LocalVariableCouldBeFinal | Local variable 'selectColumns' could be declared final | 3 | 117 |
| LongVariable | Avoid excessively long variable names like columnsWithoutOffset | 3 | 118 |
| LocalVariableCouldBeFinal | Local variable 'columnsWithoutOffset' could be declared final | 3 | 118 |
| LocalVariableCouldBeFinal | Local variable 'columnsMapped' could be declared final | 3 | 121 |
| UseDiamondOperator | Explicit type arguments can be replaced by a diamond: `new HashSet<>()` | 3 | 121 |
| LocalVariableCouldBeFinal | Local variable 'column' could be declared final | 3 | 122 |
| OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 247 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 279 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 280 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 306 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 307 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 333 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 334 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 360 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 361 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 387 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 388 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 414 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 415 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 441 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 442 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 468 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 469 |
| MethodArgumentCouldBeFinal | Parameter 'resultSet' is not assigned and could be declared final | 3 | 495 |
| MethodArgumentCouldBeFinal | Parameter 'columnIndex' is not assigned and could be declared final | 3 | 496 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 504 |
org/apache/turbine/services/schedule/JobEntryTorque.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'BaseJobEntryTorque' is already in scope because it is declared in the same package | 4 | 15 |
org/apache/turbine/services/schedule/JobEntryTorquePeer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 13 |
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'BaseJobEntryTorquePeer' is already in scope because it is declared in the same package | 4 | 14 |
org/apache/turbine/services/schedule/JobEntryTorquePeerImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'org.apache.turbine.services.schedule': 'BaseJobEntryTorquePeerImpl' is already in scope because it is declared in the same package | 4 | 14 |