PMD Results

The following document contains the results of PMD 5.1.2.

Files

org/apache/turbine/Turbine.java

Violation Line
Avoid using a branching statement as the last in a loop. 527
Avoid empty catch blocks 900–903
These nested if statements could be combined 977–997

org/apache/turbine/annotation/AnnotationProcessor.java

Violation Line
Avoid unused private methods such as 'injectTurbineLoader(Object,AssemblerBrokerService,Field,TurbineLoader)'. 287
Avoid unused private methods such as 'injectTurbineConfiguration(Object,Configuration,Field,TurbineConfiguration)'. 316
Avoid unused private methods such as 'injectTurbineService(Object,ServiceManager,Field,TurbineService)'. 442

org/apache/turbine/modules/ActionEvent.java

Violation Line
These nested if statements could be combined 225–229
Useless parentheses. 302

org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java

Violation Line
These nested if statements could be combined 98–117

org/apache/turbine/modules/layouts/VelocityXslLayout.java

Violation Line
Avoid unused private fields such as 'screenLoader'. 63

org/apache/turbine/modules/pages/JspPage.java

Violation Line
Avoid empty catch blocks 62–66

org/apache/turbine/modules/screens/TemplateScreen.java

Violation Line
Avoid empty catch blocks 148–151

org/apache/turbine/pipeline/CleanUpValve.java

Violation Line
Avoid empty catch blocks 91–95

org/apache/turbine/services/BaseServiceBroker.java

Violation Line
Useless parentheses. 262
Useless parentheses. 263
Useless parentheses. 317

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Violation Line
Useless parentheses. 227
Useless parentheses. 287

org/apache/turbine/services/jsp/TurbineJspService.java

Violation Line
Avoid empty catch blocks 183–186

org/apache/turbine/services/jsp/util/JspNavigation.java

Violation Line
Avoid empty catch blocks 88–91

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Violation Line
Avoid empty catch blocks 95–98

org/apache/turbine/services/pull/TurbinePullService.java

Violation Line
Avoid unused private methods such as 'populateWithRequestTools(Context,Object)'. 491
Avoid unused private methods such as 'populateWithPermTools(List,Context,Object,User)'. 606–607
Avoid unused private methods such as 'getRunData(PipelineData)'. 833

org/apache/turbine/services/rundata/DefaultTurbineRunData.java

Violation Line
Avoid unused imports such as 'org.apache.turbine.TurbineConstants' 45
Useless parentheses. 727

org/apache/turbine/services/servlet/TurbineServletService.java

Violation Line
Avoid empty catch blocks 117–120

org/apache/turbine/services/session/SessionListener.java

Violation Line
Avoid unused private methods such as 'getSessionService()'. 81

org/apache/turbine/services/template/mapper/BaseMapper.java

Violation Line
Useless parentheses. 173

org/apache/turbine/services/template/mapper/ClassMapper.java

Violation Line
Useless parentheses. 122
Useless parentheses. 142
Avoid empty catch blocks 157–160

org/apache/turbine/services/template/mapper/DirectMapper.java

Violation Line
Useless parentheses. 66

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Violation Line
Useless parentheses. 123

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Violation Line
Useless parentheses. 118

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Violation Line
Useless parentheses. 79

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Violation Line
Useless parentheses. 137

org/apache/turbine/services/velocity/TurbineVelocityService.java

Violation Line
Avoid empty catch blocks 364–367
Useless parentheses. 409
Useless parentheses. 409
Useless parentheses. 414
Useless parentheses. 428
Useless parentheses. 428
Useless parentheses. 546
Useless parentheses. 549

org/apache/turbine/util/BrowserDetector.java

Violation Line
Avoid unused private fields such as 'uaa'. 47

org/apache/turbine/util/GenerateUniqueId.java

Violation Line
Unnecessary use of fully qualified name 'java.util.Random' due to existing import 'java.util.Random' 52
Useless parentheses. 103

org/apache/turbine/util/ObjectUtils.java

Violation Line
Avoid empty catch blocks 94–97

org/apache/turbine/util/SecurityCheck.java

Violation Line
Useless parentheses. 158
Useless parentheses. 252

org/apache/turbine/util/ServerData.java

Violation Line
Useless parentheses. 251–252
Useless parentheses. 254–255

org/apache/turbine/util/TurbineConfig.java

Violation Line
Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 729
Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 741
Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 753

org/apache/turbine/util/template/TemplateInfo.java

Violation Line
Avoid empty catch blocks 120–125

org/apache/turbine/util/uri/BaseURI.java

Violation Line
Useless parentheses. 467–468
Useless parentheses. 469–470

org/apache/turbine/util/uri/TurbineURI.java

Violation Line
Avoid unused private methods such as 'doEncode(StringBuilder,Collection,char,char)'. 775

org/apache/turbine/util/uri/URIParam.java

Violation Line
Useless parentheses. 63