Built by Maven

PMD Results

The following document contains the results of PMD 6.29.0.

Violations By Priority

Priority 1

org/apache/turbine/Turbine.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 187
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 187

org/apache/turbine/annotation/AnnotationProcessor.java

Rule Violation Line
AvoidUsingShortType Do not use the short type 377

org/apache/turbine/modules/ActionLoader.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 34–74

org/apache/turbine/modules/GenericLoader.java

Rule Violation Line
FieldNamingConventions The static field name 'TURBINE_PACKAGES' doesn't match '[a-z][a-zA-Z0-9]*' 60
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'TURBINE_PACKAGES' is not final. 60
VariableNamingConventions Variables should start with a lowercase character, 'TURBINE_PACKAGES' starts with uppercase character. 60

org/apache/turbine/modules/LayoutLoader.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 34–74

org/apache/turbine/modules/NavigationLoader.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 34–93

org/apache/turbine/modules/PageLoader.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 34–75

org/apache/turbine/modules/ScheduledJobLoader.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 35–98
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 86

org/apache/turbine/modules/ScreenLoader.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 36–97

org/apache/turbine/modules/actions/AccessController.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 74
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 74

org/apache/turbine/modules/layouts/JspLayout.java

Rule Violation Line
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 45
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 45

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 49
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 49

org/apache/turbine/modules/navigations/BaseJspNavigation.java

Rule Violation Line
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 42
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 42

org/apache/turbine/modules/navigations/VelocityNavigation.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 48
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 48

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 43
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 43
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 74

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Line
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 130
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 130
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 133
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 133

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 78
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 78
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 107
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 107

org/apache/turbine/modules/screens/RawScreen.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 92–95

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 92–95

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 64

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 65

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 52
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 52
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 120

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setUserDelegate' called during object construction 69
ConstructorCallsOverridableMethod Overridable method 'setHasLoggedIn' called during object construction 72

org/apache/turbine/pipeline/DefaultSetEncodingValve.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 50
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 50

org/apache/turbine/pipeline/DetermineActionValve.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 43
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 43

org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 43
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 43

org/apache/turbine/pipeline/DetermineTargetValve.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 46
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 46

org/apache/turbine/services/BaseServiceBroker.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 108
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 108
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_service' is not final. 633
LocalVariableNamingConventions The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' 633
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_service' is not final. 666
LocalVariableNamingConventions The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' 666

org/apache/turbine/services/TurbineBaseService.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 92–95

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
LocalVariableNamingConventions The local variable name '_servClass' doesn't match '[a-z][a-zA-Z0-9]*' 88
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_servClass' is not final. 88

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 78
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 132

org/apache/turbine/services/avaloncomponent/Log4j2Logger.java

Rule Violation Line
FieldNamingConventions The final field name 'm_logger' doesn't match '[a-z][a-zA-Z0-9]*' 35

org/apache/turbine/services/intake/IntakeTool.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 56
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 56

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
ClassNamingConventions The utility class name 'JSONProcessor' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 39–87
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 51
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 51
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_req' is not final. 54
LocalVariableNamingConventions The local variable name 'json_req' doesn't match '[a-z][a-zA-Z0-9]*' 54
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 55
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 55
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'object_id' is not final. 65
LocalVariableNamingConventions The local variable name 'object_id' doesn't match '[a-z][a-zA-Z0-9]*' 65

org/apache/turbine/services/jsonrpc/JsonRpcService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 51
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 51

org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java

Rule Violation Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 46
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 46
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 60
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 60
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 67
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 67

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 142

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'refresh' called during object construction 59

org/apache/turbine/services/pull/TurbinePullService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 837

org/apache/turbine/services/pull/tools/TemplateLink.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 82
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 82

org/apache/turbine/services/pull/tools/UITool.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 68
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 68

org/apache/turbine/services/rundata/DefaultTurbineRunData.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 154
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 154
ConstructorCallsOverridableMethod Overridable method 'recycle' called during object construction 208

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 38
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 38
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 98
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 98
ConstructorCallsOverridableMethod Overridable method 'calcRunTime' called during object construction 117

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 40
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 40
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 117
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 117

org/apache/turbine/services/schedule/JobEntryNonPersistent.java

Rule Violation Line
FieldNamingConventions The field name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 36
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 36
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 83
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 83
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 119
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 119

org/apache/turbine/services/schedule/JobEntryQuartz.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setTask' called during object construction 84
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 95
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 95

org/apache/turbine/services/schedule/QuartzSchedulerService.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 54
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 54
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 103
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 103
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 140
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 140

org/apache/turbine/services/schedule/ScheduleService.java

Rule Violation Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 85
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 85

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 41
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 41

org/apache/turbine/services/schedule/TorqueSchedulerService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 71
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 71

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 122
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 122

org/apache/turbine/services/schedule/WorkerThread.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 45
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 45

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 102
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 102

org/apache/turbine/services/security/DefaultUserManager.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 88
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 88

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 55
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 55

org/apache/turbine/services/template/TurbineTemplateService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 185
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 185

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 63
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 63

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 55
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 55

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 51
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 51

org/apache/turbine/services/ui/TurbineUIService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 62
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 62

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 49
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 49
FieldNamingConventions The constant name 'counter' doesn't match '[A-Z][A-Z_0-9]*' 56
VariableNamingConventions Variables that are final and static should be all capitals, 'counter' is not all capitals. 56

org/apache/turbine/services/urlmapper/TurbineURLMapperService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 79
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 79

org/apache/turbine/services/velocity/TurbineVelocityService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 95
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 95
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 228

org/apache/turbine/util/BrowserDetector.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'getUserAgent' called during object construction 81

org/apache/turbine/util/FormMessage.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setFormName' called during object construction 55
ConstructorCallsOverridableMethod Overridable method 'setFieldName' called during object construction 68
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 83

org/apache/turbine/util/FormMessages.java

Rule Violation Line
FieldNamingConventions The final field name 'forms_messages' doesn't match '[a-z][a-zA-Z0-9]*' 36
FieldNamingConventions The final field name 'fields_messages' doesn't match '[a-z][a-zA-Z0-9]*' 38
FieldNamingConventions The final field name 'messages_fields' doesn't match '[a-z][a-zA-Z0-9]*' 40
FieldNamingConventions The final field name 'forms_fields' doesn't match '[a-z][a-zA-Z0-9]*' 42
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 128–154
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 163–182

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
FieldNamingConventions The static field name 'session_count' doesn't match '[a-z][a-zA-Z0-9]*' 50
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'session_count' is not final. 50
VariableNamingConventions Variables that are final and static should be all capitals, 'maxRandomLen' is not all capitals. 61
FieldNamingConventions The public constant name 'maxRandomLen' doesn't match '[A-Z][A-Z_0-9]*' 61
VariableNamingConventions Variables that are final and static should be all capitals, 'maxSessionLifespanTics' is not all capitals. 69
FieldNamingConventions The public constant name 'maxSessionLifespanTics' doesn't match '[A-Z][A-Z_0-9]*' 69
VariableNamingConventions Variables that are final and static should be all capitals, 'ticDifference' is not all capitals. 75
FieldNamingConventions The public constant name 'ticDifference' doesn't match '[A-Z][A-Z_0-9]*' 75

org/apache/turbine/util/LocaleUtils.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 64
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 64
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 174

org/apache/turbine/util/ObjectUtils.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 56

org/apache/turbine/util/ServerData.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 60
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 60
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 86
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 88
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 89
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 90
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 102
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 104
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 105
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 106
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 117
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 119
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 120
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 121

org/apache/turbine/util/TurbineConfig.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 380

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setRelation' called during object construction 525

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 49
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 49
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 97
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 108

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 52
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 52

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 71

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 51
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 51
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 93
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 105

org/apache/turbine/util/uri/TemplateURI.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 63
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 76
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 136
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 149
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 188

org/apache/turbine/util/uri/TurbineURI.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 59
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 59
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 120
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 133
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 146
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 160
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 195
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 208
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 221
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 236
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 248
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 249

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 107
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 107

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 88
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 88

Priority 2

org/apache/turbine/Turbine.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 161
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 530

org/apache/turbine/annotation/AnnotationProcessor.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 51

org/apache/turbine/modules/ActionEvent.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 89
GuardLogStatement Logger calls should be surrounded by log level guards. 366

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 57

org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 61

org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 60–61

org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 50

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 46

org/apache/turbine/modules/pages/DefaultPage.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 95

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 73

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 55

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 63

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 64

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 119

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 73

org/apache/turbine/services/BaseServiceBroker.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 480–481

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 60–61

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 49

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 58

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 42

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 66

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 50

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 52

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 42

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 55

org/apache/turbine/services/pull/TurbinePullService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 126

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 58–59

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 99

org/apache/turbine/services/urlmapper/TurbineURLMapperService.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'url' 218

org/apache/turbine/util/BrowserDetector.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 56–57

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
SystemPrintln System.out.println is used 154
SystemPrintln System.out.println is used 155
SystemPrintln System.out.println is used 156
SystemPrintln System.out.println is used 157

org/apache/turbine/util/ServerData.java

Rule Violation Line
ProperCloneImplementation Object clone() should be implemented with super.clone() 130–134

org/apache/turbine/util/TurbineConfig.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 135

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 512
GuardLogStatement Logger calls should be surrounded by log level guards. 517

Priority 3

org/apache/turbine/Turbine.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1–1088
StdCyclomaticComplexity The class 'Turbine' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 118–1088
CyclomaticComplexity The class 'Turbine' has a total cyclomatic complexity of 84 (highest 12). 118–1088
GodClass Possible God Class (WMC=84, ATFD=118, TCC=11.694%) 118–1088
AtLeastOneConstructor Each class should declare at least one constructor 118–1088
TooManyMethods This class has too many methods, consider refactoring it. 119–1088
LongVariable Avoid excessively long variable names like REDIRECTED_PATHINFO_NAME 130
RedundantFieldInitializer Avoid using redundant field initializer for 'pipeline' 148
RedundantFieldInitializer Avoid using redundant field initializer for 'initFailure' 151
RedundantFieldInitializer Avoid using redundant field initializer for 'serverData' 161
RedundantFieldInitializer Avoid using redundant field initializer for 'configuration' 179
LocalVariableCouldBeFinal Local variable 'config' could be declared final 212
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 216
LocalVariableCouldBeFinal Local variable 'context' could be declared final 216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 220
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 220
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 231–237
ExcessiveMethodLength Avoid really long methods. 257–362
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 257
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 257
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 258
LocalVariableCouldBeFinal Local variable 'confPath' could be declared final 309
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 319
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 329
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 335
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 347
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 347
LocalVariableCouldBeFinal Local variable 'jaxb' could be declared final 354
LocalVariableCouldBeFinal Local variable 'unmarshaller' could be declared final 355
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 355
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 356
ExcessiveMethodLength Avoid really long methods. 381–483
StdCyclomaticComplexity The method 'configureApplication' has a Standard Cyclomatic Complexity of 10. 381–483
CyclomaticComplexity The method 'configureApplication(ServletConfig, ServletContext)' has a cyclomatic complexity of 12. 381–483
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 381
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 381
LocalVariableCouldBeFinal Local variable 'params' could be declared final 417
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 420
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 420
LongVariable Avoid excessively long variable names like confFileRelativePath 427
LocalVariableCouldBeFinal Local variable 'confFileRelativePath' could be declared final 427
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 429
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 430
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 433
LocalVariableCouldBeFinal Local variable 'targetPathDirectory' could be declared final 433
LongVariable Avoid excessively long variable names like targetPathDirectory 433
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 437
LocalVariableCouldBeFinal Local variable 'targetFilePath' could be declared final 439
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 443
LocalVariableCouldBeFinal Local variable 'combinedBuilder' could be declared final 453–457
LocalVariableCouldBeFinal Local variable 'propertiesBuilder' could be declared final 462–467
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 500
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 501
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 501
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 501
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 507
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 524
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 543
LocalVariableCouldBeFinal Local variable 'services' could be declared final 557
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 559
LocalVariableCouldBeFinal Local variable 'i' could be declared final 559
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 559–575
LocalVariableCouldBeFinal Local variable 'serviceName' could be declared final 561
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 562
LocalVariableCouldBeFinal Local variable 'service' could be declared final 562
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 601
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 611
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 621
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 632
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 642
NonThreadSafeSingleton Singleton is not thread safe 658–677
LocalVariableCouldBeFinal Local variable 'serverName' could be declared final 660
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 687
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 708
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 731
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 751
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 751
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 762
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 767
LocalVariableCouldBeFinal Local variable 'runDataMap' could be declared final 767
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 785–788
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 790–793
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 809
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 809
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 841
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 841
ShortVariable Avoid variables with short names like t 842
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 842
LocalVariableCouldBeFinal Local variable 'data' could be declared final 844
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 862–865
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 871–873
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 875
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 876
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 879–882
ShortVariable Avoid variables with short names like t 893
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 893
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 893
CloseResource Ensure that resources like this PrintWriter object are closed after use 899
LocalVariableCouldBeFinal Local variable 'writer' could be declared final 899
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 900
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 903
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 918–929
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 918
LocalVariableCouldBeFinal Local variable 'requestServerData' could be declared final 927
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 928
MethodArgumentCouldBeFinal Parameter 'logConf' is not assigned and could be declared final 940
LocalVariableCouldBeFinal Local variable 'context' could be declared final 942
CloseResource Ensure that resources like this LoggerContext object are closed after use 942
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 944
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 944
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 944
LocalVariableCouldBeFinal Local variable 'log4jFile' could be declared final 946
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 950
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 953
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 953
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 953
MethodArgumentCouldBeFinal Parameter 'logConfPath' is not assigned and could be declared final 965
CyclomaticComplexity The method 'resolveLog4j2(Path)' has a cyclomatic complexity of 12. 965–1003
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 970
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 970
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 975
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 975
LiteralsFirstInComparisons Position literals first in String comparisons 975
CollapsibleIfStatements These nested if statements could be combined 980–1000
LocalVariableCouldBeFinal Local variable 'log4jFilePath' could be declared final 982
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 984
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 984
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 986
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 991
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 991
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 993
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 994
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 994
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 996
MethodArgumentCouldBeFinal Parameter 'val' is not assigned and could be declared final 1011
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 1044
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 1046
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 1048
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1086

org/apache/turbine/TurbineConstants.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 51
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 53
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 56
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE_DEFAULT 56
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 59
LongVariable Avoid excessively long variable names like SCHEDULER_LOG_FACILITY 62
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 62
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 65
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 68
LongVariable Avoid excessively long variable names like MAIL_SERVER_DEFAULT 68
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 71
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 74
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 77
LongVariable Avoid excessively long variable names like MODULE_CACHE_DEFAULT 77
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_KEY 80
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 80
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 83
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_DEFAULT 83
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 86
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 89
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 92
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_KEY 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 98
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_JSP 98
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 101
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 104
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 107
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 110
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 113
LongVariable Avoid excessively long variable names like SCREEN_ERROR_DEFAULT 113
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 116
LongVariable Avoid excessively long variable names like SCREEN_INVALID_STATE 116
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 119
LongVariable Avoid excessively long variable names like TEMPLATE_INVALID_STATE 119
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 122
LongVariable Avoid excessively long variable names like ACTION_LOGIN_DEFAULT 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 128
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 131
LongVariable Avoid excessively long variable names like ACTION_LOGOUT_DEFAULT 131
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_KEY 134
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 134
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_DEFAULT 137
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 137
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 140
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_KEY 140
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 143
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_DEFAULT 143
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_KEY 146
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 146
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 149
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_DEFAULT 149
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP 152
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 152
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 158
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 161
LongVariable Avoid excessively long variable names like PAGE_DEFAULT_DEFAULT 164
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 164
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 167
LongVariable Avoid excessively long variable names like SCREEN_DEFAULT_DEFAULT 167
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 170
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 173
LongVariable Avoid excessively long variable names like LOGIN_MESSAGE_NOSCREEN 176
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 176
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 179
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_KEY 182
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 182
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 185
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_DEFAULT 185
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 188
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 191
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 197
LongVariable Avoid excessively long variable names like PP_URL_CASE_FOLDING 197
LongVariable Avoid excessively long variable names like DEFAULT_DOCUMENT_TYPE_KEY 200
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 200
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_KEY 203
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 203
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_DEFAULT 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_KEY 209
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 209
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 212
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_DEFAULT 212
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_KEY 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_DEFAULT 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 221
LongVariable Avoid excessively long variable names like DEFAULT_HTML_CONTENT_TYPE 221
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 222
LongVariable Avoid excessively long variable names like DEFAULT_TEXT_CONTENT_TYPE 222
LongVariable Avoid excessively long variable names like DEFAULT_CSS_CONTENT_TYPE 223
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 223
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_KEY 226
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 226
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 229
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_DEFAULT 229
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 232
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_KEY 232
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 235
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_DEFAULT 235
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 238
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_KEY 238
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 241
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_DEFAULT 241
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 244
LongVariable Avoid excessively long variable names like LOCALE_OVERRIDE_CHARSET_KEY 244
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 249
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 252
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_KEY 252
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_DEFAULT 255
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 255
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 262
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 265
LongVariable Avoid excessively long variable names like LOGGING_ROOT_DEFAULT 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 271
LongVariable Avoid excessively long variable names like SCREEN_PLACEHOLDER 274
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 274
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 277
LongVariable Avoid excessively long variable names like NAVIGATION_PLACEHOLDER 277
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 280
LongVariable Avoid excessively long variable names like PROCESSING_EXCEPTION_PLACEHOLDER 280
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 283
LongVariable Avoid excessively long variable names like STACK_TRACE_PLACEHOLDER 283
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 286
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_KEY 286
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 289
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT 289
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 292–293
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_NAME_KEY 292
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 296–297
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_PORT_KEY 296
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 300–301
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_SCHEME_KEY 300
LongVariable Avoid excessively long variable names like DEFAULT_SCRIPT_NAME_KEY 304
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 304–305
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 308–309
LongVariable Avoid excessively long variable names like DEFAULT_CONTEXT_PATH_KEY 308
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 312
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 319

org/apache/turbine/annotation/AnnotationProcessor.java

Rule Violation Line
ModifiedCyclomaticComplexity The class 'AnnotationProcessor' has a Modified Cyclomatic Complexity of 9 (Highest = 23). 48–506
GodClass Possible God Class (WMC=70, ATFD=67, TCC=14.286%) 48–506
StdCyclomaticComplexity The class 'AnnotationProcessor' has a Standard Cyclomatic Complexity of 9 (Highest = 23). 48–506
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 49–506
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 63
LocalVariableCouldBeFinal Local variable 'key' could be declared final 65
LocalVariableCouldBeFinal Local variable 'newAnnotations' could be declared final 69
MethodArgumentCouldBeFinal Parameter 'acl' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 96
ExcessiveMethodLength Avoid really long methods. 112–219
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 112
MethodArgumentCouldBeFinal Parameter 'conditonType' is not assigned and could be declared final 112
ModifiedCyclomaticComplexity The method 'isAuthorized' has a Modified Cyclomatic Complexity of 23. 112–219
MethodArgumentCouldBeFinal Parameter 'acl' is not assigned and could be declared final 112
StdCyclomaticComplexity The method 'isAuthorized' has a Standard Cyclomatic Complexity of 23. 112–219
CyclomaticComplexity The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a cyclomatic complexity of 27. 112–219
NcssCount The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a NCSS line count of 68. 112–219
LocalVariableCouldBeFinal Local variable 'annotations' could be declared final 114
LocalVariableCouldBeFinal Local variable 'annotation' could be declared final 116
LocalVariableCouldBeFinal Local variable 'trr' could be declared final 120
LocalVariableCouldBeFinal Local variable 'roleNames' could be declared final 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 121
LocalVariableCouldBeFinal Local variable 'group' could be declared final 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
LocalVariableCouldBeFinal Local variable 'roleName' could be declared final 126
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 128–141
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 132
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 138
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 144
LocalVariableCouldBeFinal Local variable 'roleName' could be declared final 149
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 151–164
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 155
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 161
LocalVariableCouldBeFinal Local variable 'trp' could be declared final 170
LocalVariableCouldBeFinal Local variable 'permissionNames' could be declared final 171
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 171
LocalVariableCouldBeFinal Local variable 'group' could be declared final 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 172
LocalVariableCouldBeFinal Local variable 'permissionName' could be declared final 176
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 178–191
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 182
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 188
LocalVariableCouldBeFinal Local variable 'permissionName' could be declared final 196
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 198–211
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 202
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 208
StdCyclomaticComplexity The method 'process' has a Standard Cyclomatic Complexity of 10. 228–275
CyclomaticComplexity The method 'process(Object)' has a cyclomatic complexity of 10. 228–275
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 228
ModifiedCyclomaticComplexity The method 'process' has a Modified Cyclomatic Complexity of 10. 228–275
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 237
LocalVariableCouldBeFinal Local variable 'field' could be declared final 239
LocalVariableCouldBeFinal Local variable 'annotations' could be declared final 241
LocalVariableCouldBeFinal Local variable 'a' could be declared final 243
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 265–266
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 287
MethodArgumentCouldBeFinal Parameter 'assembler' is not assigned and could be declared final 287
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 287
MethodArgumentCouldBeFinal Parameter 'annotation' is not assigned and could be declared final 287
LocalVariableCouldBeFinal Local variable 'loader' could be declared final 289
AvoidDuplicateLiterals The String literal "Injection of {} into object {}" appears 13 times in this file; the first occurrence is on line 294 294
MethodArgumentCouldBeFinal Parameter 'annotation' is not assigned and could be declared final 316
ExcessiveMethodLength Avoid really long methods. 316–430
CyclomaticComplexity The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a cyclomatic complexity of 16. 316–430
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 316
ModifiedCyclomaticComplexity The method 'injectTurbineConfiguration' has a Modified Cyclomatic Complexity of 15. 316–430
NcssCount The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a NCSS line count of 75. 316–430
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 316
StdCyclomaticComplexity The method 'injectTurbineConfiguration' has a Standard Cyclomatic Complexity of 15. 316–430
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 316
LocalVariableCouldBeFinal Local variable 'type' could be declared final 318
LocalVariableCouldBeFinal Local variable 'key' could be declared final 319
LongVariable Avoid excessively long variable names like injectConfiguration 325
AvoidFinalLocalVariable Avoid using final local variables, turn them into fields 325
LocalVariableCouldBeFinal Local variable 'value' could be declared final 345
LawOfDemeter Potential violation of Law of Demeter (static property access) 351
LocalVariableCouldBeFinal Local variable 'value' could be declared final 353
LawOfDemeter Potential violation of Law of Demeter (static property access) 359
LocalVariableCouldBeFinal Local variable 'value' could be declared final 361
LawOfDemeter Potential violation of Law of Demeter (static property access) 367
LocalVariableCouldBeFinal Local variable 'value' could be declared final 369
LawOfDemeter Potential violation of Law of Demeter (static property access) 375
LocalVariableCouldBeFinal Local variable 'value' could be declared final 377
LawOfDemeter Potential violation of Law of Demeter (static property access) 383
LocalVariableCouldBeFinal Local variable 'value' could be declared final 385
LawOfDemeter Potential violation of Law of Demeter (static property access) 391
LocalVariableCouldBeFinal Local variable 'value' could be declared final 393
LawOfDemeter Potential violation of Law of Demeter (static property access) 399
LocalVariableCouldBeFinal Local variable 'value' could be declared final 401
LawOfDemeter Potential violation of Law of Demeter (static property access) 407
LocalVariableCouldBeFinal Local variable 'value' could be declared final 409
LocalVariableCouldBeFinal Local variable 'values' could be declared final 417
CyclomaticComplexity The method 'injectTurbineService(Object, ServiceManager, Field, TurbineService)' has a cyclomatic complexity of 10. 442–505
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 442
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 442
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 442
MethodArgumentCouldBeFinal Parameter 'annotation' is not assigned and could be declared final 442
LocalVariableCouldBeFinal Local variable 'typeFields' could be declared final 453
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 453
LocalVariableCouldBeFinal Local variable 'f' could be declared final 454
LawOfDemeter Potential violation of Law of Demeter (static property access) 456
LawOfDemeter Potential violation of Law of Demeter (static property access) 468
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 486
LocalVariableCouldBeFinal Local variable 'service' could be declared final 491

org/apache/turbine/modules/Action.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 53
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 62

org/apache/turbine/modules/ActionEvent.java

Rule Violation Line
StdCyclomaticComplexity The class 'ActionEvent' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 86–373
AbstractNaming Abstract classes should be named AbstractXXX 86–373
ModifiedCyclomaticComplexity The class 'ActionEvent' has a Modified Cyclomatic Complexity of 6 (Highest = 10). 86–373
AtLeastOneConstructor Each class should declare at least one constructor 86–373
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 89
LongVariable Avoid excessively long variable names like METHOD_NAME_PREFIX 98
LongVariable Avoid excessively long variable names like METHOD_NAME_LENGTH 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 109
ImmutableField Private field 'submitValueKey' could be made final; it is only initialized in the declaration or constructor. 109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 117
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 122
ImmutableField Private field 'methodCache' could be made final; it is only initialized in the declaration or constructor. 122
CyclomaticComplexity The method 'getMethod(String, Class, ParameterParser)' has a cyclomatic complexity of 10. 134–183
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 134
ShortVariable Avoid variables with short names like pp 134
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 134
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 134
LocalVariableCouldBeFinal Local variable 'cacheKey' could be declared final 136
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 137
LocalVariableCouldBeFinal Local variable 'methods' could be declared final 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 147
LocalVariableCouldBeFinal Local variable 'm' could be declared final 150
LocalVariableCouldBeFinal Local variable 'annotations' could be declared final 152
LocalVariableCouldBeFinal Local variable 'a' could be declared final 153
LocalVariableCouldBeFinal Local variable 'tae' could be declared final 157
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 158
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 158–163
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 171
LocalVariableCouldBeFinal Local variable 'tmp' could be declared final 171
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 171
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 172
LocalVariableCouldBeFinal Local variable 'oldMethod' could be declared final 175
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 194
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 197
ShortVariable Avoid variables with short names like pp 197
ModifiedCyclomaticComplexity The method 'executeEvents' has a Modified Cyclomatic Complexity of 10. 210–283
StdCyclomaticComplexity The method 'executeEvents' has a Standard Cyclomatic Complexity of 10. 210–283
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 210
CyclomaticComplexity The method 'executeEvents(ParameterParser, Class, Object)' has a cyclomatic complexity of 12. 210–283
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 210
ShortVariable Avoid variables with short names like pp 210
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 210
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 211
LocalVariableCouldBeFinal Local variable 'button' could be declared final 216
LocalVariableCouldBeFinal Local variable 'k' could be declared final 220
CollapsibleIfStatements These nested if statements could be combined 225–229
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 236
UnusedAssignment The initializer for variable 'method' is never used (overwritten on lines 244 and 248) 240
ShortVariable Avoid variables with short names like t 266
LocalVariableCouldBeFinal Local variable 't' could be declared final 266
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 293
ShortVariable Avoid variables with short names like pp 293
MethodArgumentCouldBeFinal Parameter 'input' is not assigned and could be declared final 293
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 299
LocalVariableCouldBeFinal Local variable 'methodName' could be declared final 302–304
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 308
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 312
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 312
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 312
ShortVariable Avoid variables with short names like pp 327
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 327
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 327
ConfusingTernary Avoid if (x != y) ..; else ..; 329–369
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 332
LocalVariableCouldBeFinal Local variable 'keyValue' could be declared final 345
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 350
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 358
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 367

org/apache/turbine/modules/ActionLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62

org/apache/turbine/modules/GenericLoader.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 42–222
ShortVariable Avoid variables with short names like ab 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
RedundantFieldInitializer Avoid using redundant field initializer for 'reload' 54
AvoidFieldNameMatchingMethodName Field reload has the same name as a method 54
RedundantFieldInitializer Avoid using redundant field initializer for 'TURBINE_PACKAGES' 60
SuspiciousConstantFieldName The field name indicates a constant but its modifiers do not 60
MethodArgumentCouldBeFinal Parameter 'cacheSizeSupplier' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'assemblerClass' is not assigned and could be declared final 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 85
MethodArgumentCouldBeFinal Parameter 'reload' is not assigned and could be declared final 109
LinguisticNaming Linguistics Antipattern - The setter 'setReload' should not return any type except void linguistically 109–113
NonThreadSafeSingleton Singleton is not thread safe 134–140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136–137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136–137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136–137
LocalVariableCouldBeFinal Local variable 'turbinePackages' could be declared final 136–137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136–137
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 142
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 161
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 176
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 177
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 194
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 208

org/apache/turbine/modules/Layout.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 61

org/apache/turbine/modules/LayoutLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62

org/apache/turbine/modules/Loader.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 37

org/apache/turbine/modules/Navigation.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 57
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 68

org/apache/turbine/modules/NavigationLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 67
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 78

org/apache/turbine/modules/Page.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 54
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 64

org/apache/turbine/modules/PageLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63

org/apache/turbine/modules/ScheduledJob.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 58

org/apache/turbine/modules/ScheduledJobLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'job' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 83

org/apache/turbine/modules/Screen.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 70
CloseResource Ensure that resources like this RunData object are closed after use 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 92
CloseResource Ensure that resources like this RunData object are closed after use 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 104

org/apache/turbine/modules/ScreenLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 65
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 66
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 82

org/apache/turbine/modules/actions/AccessController.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 71–119
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 91
CloseResource Ensure that resources like this RunData object are closed after use 94
LocalVariableCouldBeFinal Local variable 'data' could be declared final 94
LocalVariableCouldBeFinal Local variable 'user' could be declared final 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 102–103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 108–109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 117

org/apache/turbine/modules/actions/DefaultAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 45
LocalVariableCouldBeFinal Local variable 'data' could be declared final 48
CloseResource Ensure that resources like this RunData object are closed after use 48
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 49

org/apache/turbine/modules/actions/InitContextsAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44–97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 60
CloseResource Ensure that resources like this RunData object are closed after use 63
LocalVariableCouldBeFinal Local variable 'data' could be declared final 63
LocalVariableCouldBeFinal Local variable 'contextPropsList' could be declared final 71
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 71
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 72
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 72–89
LocalVariableCouldBeFinal Local variable 'key' could be declared final 74
LocalVariableCouldBeFinal Local variable 'start' could be declared final 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 75
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LocalVariableCouldBeFinal Local variable 'end' could be declared final 76
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 81 and 85) 78
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 85
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 87
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 91
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 93
LocalVariableCouldBeFinal Local variable 'context' could be declared final 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 94

org/apache/turbine/modules/actions/LegacyVelocityAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–85
AbstractNaming Abstract classes should be named AbstractXXX 36–85
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 46
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 71
LocalVariableCouldBeFinal Local variable 'data' could be declared final 79
CloseResource Ensure that resources like this RunData object are closed after use 79
ShortVariable Avoid variables with short names like pp 80
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 80
LocalVariableCouldBeFinal Local variable 'context' could be declared final 81

org/apache/turbine/modules/actions/LegacyVelocitySecureAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41–69
AbstractNaming Abstract classes should be named AbstractXXX 41–69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 51
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 68

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 48–157
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
ImmutableField Private field 'loginError' could be made final; it is only initialized in the declaration or constructor. 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 85
CloseResource Ensure that resources like this RunData object are closed after use 88
LocalVariableCouldBeFinal Local variable 'data' could be declared final 88
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 89
LocalVariableCouldBeFinal Local variable 'username' could be declared final 89
LocalVariableCouldBeFinal Local variable 'password' could be declared final 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 90
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LocalVariableCouldBeFinal Local variable 'user' could be declared final 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 114
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 132
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 134
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 142

org/apache/turbine/modules/actions/LogoutUser.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41–123
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
ImmutableField Private field 'actionLogout' could be made final; it is only initialized in the declaration or constructor. 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 75
CloseResource Ensure that resources like this RunData object are closed after use 78
LocalVariableCouldBeFinal Local variable 'data' could be declared final 78
LocalVariableCouldBeFinal Local variable 'user' could be declared final 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 99
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 104
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 109

org/apache/turbine/modules/actions/VelocityAction.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 36–96
AtLeastOneConstructor Each class should declare at least one constructor 36–96
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 70
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 76
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 92
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92

org/apache/turbine/modules/actions/VelocitySecureAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 42–70
AbstractNaming Abstract classes should be named AbstractXXX 42–70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 69

org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 57–129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
LongVariable Avoid excessively long variable names like loginMessageNoScreen 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 84
CloseResource Ensure that resources like this RunData object are closed after use 87
LocalVariableCouldBeFinal Local variable 'data' could be declared final 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 127
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 127

org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 53–124
AbstractNaming Abstract classes should be named AbstractXXX 53–124
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 66
LongVariable Avoid excessively long variable names like templateInvalidState 66
LongVariable Avoid excessively long variable names like screenInvalidState 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 69
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'screenOnly' is not assigned and could be declared final 79
AvoidDuplicateLiterals The String literal "_session_access_counter" appears 5 times in this file; the first occurrence is on line 81 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86–87
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98
CollapsibleIfStatements These nested if statements could be combined 98–117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99–100
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 102–114
ConfusingTernary Avoid if (x != y) ..; else ..; 102–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 104–106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105–106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105–106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111–112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 115

org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 56–149
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 84
LocalVariableCouldBeFinal Local variable 'data' could be declared final 87
CloseResource Ensure that resources like this RunData object are closed after use 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 124
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 125
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 129
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 141
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 147

org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 46–101
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 60
CloseResource Ensure that resources like this RunData object are closed after use 62
LocalVariableCouldBeFinal Local variable 'data' could be declared final 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 64
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 67
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 99

org/apache/turbine/modules/layouts/DirectResponseLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 37–56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 46
LocalVariableCouldBeFinal Local variable 'data' could be declared final 49
CloseResource Ensure that resources like this RunData object are closed after use 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 50

org/apache/turbine/modules/layouts/JspLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 42–80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 61
CloseResource Ensure that resources like this RunData object are closed after use 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 63
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 76

org/apache/turbine/modules/layouts/VelocityCachedLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 42–61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 59

org/apache/turbine/modules/layouts/VelocityDirectLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 42–58
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 48
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 48

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43–116
AbstractNaming Abstract classes should be named AbstractXXX 43–116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 63
CloseResource Ensure that resources like this RunData object are closed after use 66
LocalVariableCouldBeFinal Local variable 'data' could be declared final 66
LocalVariableCouldBeFinal Local variable 'context' could be declared final 68
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 97
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 108
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 108
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 108
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113–114

org/apache/turbine/modules/layouts/VelocityOnlyLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 65–93
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 69
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 75
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
LocalVariableCouldBeFinal Local variable 'results' could be declared final 83
LocalVariableCouldBeFinal Local variable 'returnValue' could be declared final 84

org/apache/turbine/modules/layouts/VelocityXslLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55–102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
UnusedPrivateField Avoid unused private fields such as 'screenLoader'. 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 73
CloseResource Ensure that resources like this RunData object are closed after use 76
LocalVariableCouldBeFinal Local variable 'data' could be declared final 76
LocalVariableCouldBeFinal Local variable 'context' could be declared final 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 88
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 88
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 88
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 93–94
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100

org/apache/turbine/modules/navigations/BaseJspNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 69
CloseResource Ensure that resources like this RunData object are closed after use 72
LocalVariableCouldBeFinal Local variable 'data' could be declared final 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 74
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 74

org/apache/turbine/modules/navigations/LegacyVelocityNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 35–61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 48
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 57

org/apache/turbine/modules/navigations/TemplateNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 34–68
AbstractNaming Abstract classes should be named AbstractXXX 34–68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 52
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 62

org/apache/turbine/modules/navigations/VelocityNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44–109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 97
CloseResource Ensure that resources like this RunData object are closed after use 100
LocalVariableCouldBeFinal Local variable 'data' could be declared final 100
LocalVariableCouldBeFinal Local variable 'context' could be declared final 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LongVariable Avoid excessively long variable names like navigationTemplate 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103
LocalVariableCouldBeFinal Local variable 'navigationTemplate' could be declared final 103
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 104–105

org/apache/turbine/modules/pages/DefaultPage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 92–207
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 99
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 107
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 116
CloseResource Ensure that resources like this RunData object are closed after use 119
LocalVariableCouldBeFinal Local variable 'data' could be declared final 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 132
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 141
LocalVariableCouldBeFinal Local variable 'aScreen' could be declared final 149
LocalVariableCouldBeFinal Local variable 'layout' could be declared final 150
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 150
ConfusingTernary Avoid if (x != y) ..; else ..; 154–161
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 177
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 189
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 190
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 202
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 203

org/apache/turbine/modules/pages/JspPage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 39–69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 51
LocalVariableCouldBeFinal Local variable 'response' could be declared final 58
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 60
EmptyCatchBlock Avoid empty catch blocks 62–66

org/apache/turbine/modules/pages/TemplatePage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 82–129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 87
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 97
LocalVariableCouldBeFinal Local variable 'data' could be declared final 100
CloseResource Ensure that resources like this RunData object are closed after use 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 105
LocalVariableCouldBeFinal Local variable 'template' could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 110
LocalVariableCouldBeFinal Local variable 'layoutTemplate' could be declared final 113–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 115
LocalVariableCouldBeFinal Local variable 'screen' could be declared final 117
LocalVariableCouldBeFinal Local variable 'errMsg' could be declared final 121–122

org/apache/turbine/modules/pages/VelocityPage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 39–74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 54
LocalVariableCouldBeFinal Local variable 'data' could be declared final 57
CloseResource Ensure that resources like this RunData object are closed after use 57
LocalVariableCouldBeFinal Local variable 'context' could be declared final 58
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 59–60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 59–60
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 68
LocalVariableCouldBeFinal Local variable 'context' could be declared final 71

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 39–96
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 61
CloseResource Ensure that resources like this RunData object are closed after use 64
LocalVariableCouldBeFinal Local variable 'data' could be declared final 64
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 65
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 67–68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 91

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 82–143
LongVariable Avoid excessively long variable names like JSONRPC_CONTENT_TYPE 84
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 109
LocalVariableCouldBeFinal Local variable 'data' could be declared final 111
CloseResource Ensure that resources like this RunData object are closed after use 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 113
LocalVariableCouldBeFinal Local variable 'request' could be declared final 113
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 116
CloseResource Ensure that resources like this InputStreamReader object are closed after use 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 117
LocalVariableCouldBeFinal Local variable 'in' could be declared final 117
ShortVariable Avoid variables with short names like in 117
LocalVariableCouldBeFinal Local variable 'cdata' could be declared final 120
LocalVariableCouldBeFinal Local variable 'buf' could be declared final 121
AssignmentInOperand Avoid assignments in operands 123
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 130
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 130
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 133
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 137

org/apache/turbine/modules/screens/JSONSecureScreen.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 77–104
AtLeastOneConstructor Each class should declare at least one constructor 77–104
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 87
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 103

org/apache/turbine/modules/screens/JspErrorScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 34–50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
ImmutableField Private field 'templateError' could be made final; it is only initialized in the declaration or constructor. 38
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 45

org/apache/turbine/modules/screens/LegacyVelocityScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 33–65
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 45
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 60

org/apache/turbine/modules/screens/LegacyVelocitySecureScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 34–77
AbstractNaming Abstract classes should be named AbstractXXX 34–77
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 76

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 72–118
DefaultPackage Use explicit scoping instead of the default package private level 78
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the log field if you want a default access modifier 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 101
CloseResource Ensure that resources like this RunData object are closed after use 103
LocalVariableCouldBeFinal Local variable 'data' could be declared final 103
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 107
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
StringToString Avoid calling toString() on String objects; this is unnecessary. 114

org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 31–70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 42
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 59
CloseResource Ensure that resources like this RunData object are closed after use 60
LocalVariableCouldBeFinal Local variable 'data' could be declared final 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 61
LocalVariableCouldBeFinal Local variable 'methods' could be declared final 61
LocalVariableCouldBeFinal Local variable 'm' could be declared final 62
LiteralsFirstInComparisons Position literals first in String comparisons 63
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 64
ControlStatementBraces This statement should have braces 64
IfStmtsMustUseBraces Avoid using if statements without curly braces 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 65

org/apache/turbine/modules/screens/RawScreen.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 45–96
AtLeastOneConstructor Each class should declare at least one constructor 45–96
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
LocalVariableCouldBeFinal Local variable 'data' could be declared final 59
CloseResource Ensure that resources like this RunData object are closed after use 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 61
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 52–204
AtLeastOneConstructor Each class should declare at least one constructor 52–204
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 72
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 106
UnusedAssignment The initializer for variable 'out' is never used (overwritten on line 114) 109
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 135
LocalVariableCouldBeFinal Local variable 'data' could be declared final 137
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 138
ShortVariable Avoid variables with short names like ti 138
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 138
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 139
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 139
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 141
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 148
EmptyCatchBlock Avoid empty catch blocks 148–151
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 173
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 174
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 199
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 199
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 200

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 39–84
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 53
CloseResource Ensure that resources like this RunData object are closed after use 53
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 56
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 56
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 57–58
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 71

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 40–89
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 51
CloseResource Ensure that resources like this RunData object are closed after use 54
LocalVariableCouldBeFinal Local variable 'data' could be declared final 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 55
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 55
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 57
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 57
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 58–59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 72
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 84

org/apache/turbine/modules/screens/VelocityErrorScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–58
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 47
LocalVariableCouldBeFinal Local variable 'data' could be declared final 50
CloseResource Ensure that resources like this RunData object are closed after use 50
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 52
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 52
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 54

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 48–152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 75
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 76
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 104
CloseResource Ensure that resources like this RunData object are closed after use 107
LocalVariableCouldBeFinal Local variable 'data' could be declared final 107
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 108
LocalVariableCouldBeFinal Local variable 'context' could be declared final 110
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 110
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 113–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 131
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 139

org/apache/turbine/modules/screens/VelocitySecureScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41–85
AbstractNaming Abstract classes should be named AbstractXXX 41–85
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 84

org/apache/turbine/modules/screens/error/InvalidState.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 46–86
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
CloseResource Ensure that resources like this RunData object are closed after use 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 58
LocalVariableCouldBeFinal Local variable 'body' could be declared final 59
LocalVariableCouldBeFinal Local variable 'message' could be declared final 62
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 63
ShortVariable Avoid variables with short names like sb 63
ShortVariable Avoid variables with short names like pp 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
LocalVariableCouldBeFinal Local variable 'back' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 79
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82

org/apache/turbine/om/OMTool.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
ImmutableField Private field 'pullMap' could be made final; it is only initialized in the declaration or constructor. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 62
LocalVariableCouldBeFinal Local variable 'className' could be declared final 65
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 75
DefaultPackage Use explicit scoping instead of the default package private level 95
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the omName field if you want a default access modifier 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 95
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 97
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 102
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 102–119
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 103
UnusedAssignment The initializer for variable 'om' is never used (overwritten on lines 110 and 114) 105
ShortVariable Avoid variables with short names like om 105
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 128
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 128
ShortVariable Avoid variables with short names like ph 130
LocalVariableCouldBeFinal Local variable 'ph' could be declared final 130
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 133
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 146
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 146
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 148
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 153
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 153

org/apache/turbine/om/Retrievable.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 52

org/apache/turbine/om/Retriever.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 44

org/apache/turbine/om/RetrieverFactory.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 43

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1–758
GodClass Possible God Class (WMC=67, ATFD=31, TCC=15.137%) 44–758
RedundantFieldInitializer Avoid using redundant field initializer for 'lastAccessDate' 50
RedundantFieldInitializer Avoid using redundant field initializer for 'permStorage' 53
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 71) 56
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 56
RedundantFieldInitializer Avoid using redundant field initializer for 'userDelegate' 59
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 94
LocalVariableCouldBeFinal Local variable 'securityService' could be declared final 100–102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101–102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 106
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 135
ShortVariable Avoid variables with short names like id 158
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 158
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 189
MethodArgumentCouldBeFinal Parameter 'firstName' is not assigned and could be declared final 211
MethodArgumentCouldBeFinal Parameter 'lastName' is not assigned and could be declared final 233
MethodArgumentCouldBeFinal Parameter 'address' is not assigned and could be declared final 255
MethodArgumentCouldBeFinal Parameter 'objectdata' is not assigned and could be declared final 280
MethodArgumentCouldBeFinal Parameter 'userGroupRoleSet' is not assigned and could be declared final 305
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 319
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 333
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 348
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 350
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 366
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 368
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 399
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 411
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 449–467
LocalVariableCouldBeFinal Local variable 'objectdata' could be declared final 453
MethodArgumentCouldBeFinal Parameter 'permStorage' is not assigned and could be declared final 476
MethodArgumentCouldBeFinal Parameter 'tempStorage' is not assigned and could be declared final 507
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 522
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 524
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 536
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 536
LocalVariableCouldBeFinal Local variable 'val' could be declared final 540
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 540
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 541
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 543
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 556
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 556
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 558
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 568
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 570
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 582
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 582
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 587
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 593
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 607
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 607
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 609
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 619
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 621
MethodArgumentCouldBeFinal Parameter 'confirm' is not assigned and could be declared final 641
MethodArgumentCouldBeFinal Parameter 'createDate' is not assigned and could be declared final 663
MethodArgumentCouldBeFinal Parameter 'lastLogin' is not assigned and could be declared final 685
LocalVariableCouldBeFinal Local variable 'loggedIn' could be declared final 698
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 699
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 709
LocalVariableCouldBeFinal Local variable 'value' could be declared final 725
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 726
MethodArgumentCouldBeFinal Parameter 'userDelegate' is not assigned and could be declared final 754

org/apache/turbine/om/security/User.java

Rule Violation Line
LongVariable Avoid excessively long variable names like SESSION_ACCESS_COUNTER 60
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 288

org/apache/turbine/pipeline/CleanUpValve.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 49–52
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 58
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 65
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 79
LocalVariableCouldBeFinal Local variable 'data' could be declared final 81
CloseResource Ensure that resources like this RunData object are closed after use 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 88–89
LongVariable Avoid excessively long variable names like invalidatedSession 91
EmptyCatchBlock Avoid empty catch blocks 91–95

org/apache/turbine/pipeline/DefaultACLCreationValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41–75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
LongVariable Avoid excessively long variable names like actionAccessController 49
ImmutableField Private field 'actionAccessController' could be made final; it is only initialized in the declaration or constructor. 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 67

org/apache/turbine/pipeline/DefaultLoginValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 50–166
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 67
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 74
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 91
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 92
LocalVariableCouldBeFinal Local variable 'data' could be declared final 94
CloseResource Ensure that resources like this RunData object are closed after use 94
LocalVariableCouldBeFinal Local variable 'actionName' could be declared final 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 118
LocalVariableCouldBeFinal Local variable 'names' could be declared final 118
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 119–141
LocalVariableCouldBeFinal Local variable 'nameList' could be declared final 123
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 126
LocalVariableCouldBeFinal Local variable 'session' could be declared final 129
LocalVariableCouldBeFinal Local variable 'name' could be declared final 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 134
LongVariable Avoid excessively long variable names like invalidatedSession 136
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 155
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 160
ShortVariable Avoid variables with short names like ti 160

org/apache/turbine/pipeline/DefaultPipelineData.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44–104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'innerKey' is not assigned and could be declared final 82
LocalVariableCouldBeFinal Local variable 'innerMap' could be declared final 84
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LocalVariableCouldBeFinal Local variable 'rds' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98

org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43–67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 53
CloseResource Ensure that resources like this RunData object are closed after use 56
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 61

org/apache/turbine/pipeline/DefaultSessionValidationValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41–78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
LongVariable Avoid excessively long variable names like actionSessionValidator 49
ImmutableField Private field 'actionSessionValidator' could be made final; it is only initialized in the declaration or constructor. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 70

org/apache/turbine/pipeline/DefaultSetEncodingValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 47–92
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
LocalVariableCouldBeFinal Local variable 'req' could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 63
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 87

org/apache/turbine/pipeline/DetermineActionValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 40–75
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 50
CloseResource Ensure that resources like this RunData object are closed after use 53
LocalVariableCouldBeFinal Local variable 'data' could be declared final 53
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 54
LocalVariableCouldBeFinal Local variable 'action' could be declared final 56–57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 57
ConfusingTernary Avoid if (x != y) ..; else ..; 59–67

org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 48–51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 73
LocalVariableCouldBeFinal Local variable 'data' could be declared final 76
CloseResource Ensure that resources like this RunData object are closed after use 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 78
LocalVariableCouldBeFinal Local variable 'requestRedirected' could be declared final 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 87

org/apache/turbine/pipeline/DetermineTargetValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44–77
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 53
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 56
CloseResource Ensure that resources like this RunData object are closed after use 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 57
LocalVariableCouldBeFinal Local variable 'target' could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 59
ConfusingTernary Avoid if (x != y) ..; else ..; 61–69

org/apache/turbine/pipeline/ExecutePageValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43–120
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
ImmutableField Private field 'pageDefault' could be made final; it is only initialized in the declaration or constructor. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 84
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 85

org/apache/turbine/pipeline/Pipeline.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 60

org/apache/turbine/pipeline/TurbinePipeline.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 47–183
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
ImmutableField Private field 'state' could be made final; it is only initialized in the declaration or constructor. 70
LocalVariableCouldBeFinal Local variable 'v' could be declared final 83
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 115
MethodArgumentCouldBeFinal Parameter 'valves' is not assigned and could be declared final 138
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 147
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 156
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 170
LocalVariableCouldBeFinal Local variable 'current' could be declared final 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 180

org/apache/turbine/pipeline/Valve.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 100

org/apache/turbine/pipeline/XmlValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 34–58
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 54

org/apache/turbine/pipeline/XmlValveAdapter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 29–52
MethodArgumentCouldBeFinal Parameter 'xmlValve' is not assigned and could be declared final 35
LocalVariableCouldBeFinal Local variable 'valveClass' could be declared final 37
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 38
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 45
LocalVariableCouldBeFinal Local variable 'xmlValve' could be declared final 47
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 48

org/apache/turbine/services/BaseInitable.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'isInitialized' 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 50–53
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 61
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 137

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 59–284
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 96
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 102
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 105–106
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 143
LocalVariableCouldBeFinal Local variable 'initable' could be declared final 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 150
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 176
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 177
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 227
CyclomaticComplexity The method 'getInitableInstance(String)' has a cyclomatic complexity of 11. 227–282
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 228
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 236
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 240–243
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 244–247
IdenticalCatchBranches 'catch' branch identical to 'ThreadDeath' branch 244–247
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 249–275
UnusedAssignment The initializer for variable 'msg' is never used (overwritten on lines 256, 261, 266 and 271) 252
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 254
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 259
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 264

org/apache/turbine/services/BaseService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 37–125
DataClass The class 'BaseService' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=8) 37–125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 69
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 121

org/apache/turbine/services/BaseServiceBroker.java

Rule Violation Line
CyclomaticComplexity The class 'BaseServiceBroker' has a total cyclomatic complexity of 88 (highest 18). 58–780
ModifiedCyclomaticComplexity The class 'BaseServiceBroker' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 58–780
StdCyclomaticComplexity The class 'BaseServiceBroker' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 58–780
GodClass Possible God Class (WMC=88, ATFD=29, TCC=15.580%) 58–780
AbstractNaming Abstract classes should be named AbstractXXX 58–780
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 105
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 119
LongVariable Avoid excessively long variable names like serviceProviderInstanceMap 119
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 139
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 185
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 185
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 196
MethodArgumentCouldBeFinal Parameter 'checkIfc' is not assigned and could be declared final 209
MethodArgumentCouldBeFinal Parameter 'interfaces' is not assigned and could be declared final 209
LocalVariableCouldBeFinal Local variable 'ifc' could be declared final 211
CompareObjectsWithEquals Use equals() to compare object references. 213
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 215
LocalVariableCouldBeFinal Local variable 'subInterfaces' could be declared final 218
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 221
CyclomaticComplexity The method 'initMapping()' has a cyclomatic complexity of 14. 245–305
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 249
LocalVariableCouldBeFinal Local variable 'earlyInitFlags' could be declared final 249
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 256–299
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 256
LocalVariableCouldBeFinal Local variable 'key' could be declared final 258
LocalVariableCouldBeFinal Local variable 'keyParts' could be declared final 259
LocalVariableCouldBeFinal Local variable 'serviceKey' could be declared final 265
LocalVariableCouldBeFinal Local variable 'className' could be declared final 270
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 273
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 277
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 277–281
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 284–287
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 288–291
IdenticalCatchBranches 'catch' branch identical to 'ThreadDeath' branch 288–291
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 301
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 315
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 327
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 337
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 339
LocalVariableCouldBeFinal Local variable 'key' could be declared final 340
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 342
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 361
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 361–374
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 367
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 369
MethodArgumentCouldBeFinal Parameter 'report' is not assigned and could be declared final 404
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 405
LocalVariableCouldBeFinal Local variable 'names' could be declared final 410
LocalVariableCouldBeFinal Local variable 'names' could be declared final 418
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 439
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 440
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 443
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 460–483
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 460
LocalVariableCouldBeFinal Local variable 'service' could be declared final 464
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 465
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 467
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 469
UnusedAssignment The initializer for variable 'serviceName' is never used (overwritten on lines 507 and 513) 494
LocalVariableCouldBeFinal Local variable 'reverseServicesList' could be declared final 503
LongVariable Avoid excessively long variable names like reverseServicesList 503
LocalVariableCouldBeFinal Local variable 'serviceNames' could be declared final 505
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 511–516
LocalVariableCouldBeFinal Local variable 'serviceNames' could be declared final 511
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 528
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 528
CyclomaticComplexity The method 'getService(String)' has a cyclomatic complexity of 10. 528–576
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 558
CyclomaticComplexity The method 'getServiceInstance(String)' has a cyclomatic complexity of 18. 598–680
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 598
StdCyclomaticComplexity The method 'getServiceInstance' has a Standard Cyclomatic Complexity of 12. 598–680
ModifiedCyclomaticComplexity The method 'getServiceInstance' has a Modified Cyclomatic Complexity of 12. 598–680
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 599
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 623
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 627
LocalVariableCouldBeFinal Local variable '_service' could be declared final 633
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 646–649
IdenticalCatchBranches 'catch' branch identical to 'ThreadDeath' branch 650–653
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 650–653
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 654–657
ExceptionAsFlowControl Avoid using exceptions as flow control. 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 659
LocalVariableCouldBeFinal Local variable '_service' could be declared final 666
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 689
MethodArgumentCouldBeFinal Parameter 'applicationRoot' is not assigned and could be declared final 699
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 723
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 737
LongVariable Avoid excessively long variable names like turbineServiceProvider 739
UnusedAssignment The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 743) 739
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 741
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 747
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 761
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 762
LongVariable Avoid excessively long variable names like turbineServiceProvider 764
UnusedAssignment The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 768) 764
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 766

org/apache/turbine/services/BaseUnicastRemoteService.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
CallSuperInConstructor It is a good practice to call super() in a constructor 55–62
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 60
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 114
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 141
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 162

org/apache/turbine/services/InitableBroker.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 97

org/apache/turbine/services/InitializationException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 60
ShortVariable Avoid variables with short names like t 60

org/apache/turbine/services/InstantiationException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 51
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 63
ShortVariable Avoid variables with short names like t 63
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 63

org/apache/turbine/services/ServiceBroker.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 95

org/apache/turbine/services/TurbineBaseService.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 59–124
AtLeastOneConstructor Each class should declare at least one constructor 59–124
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 72
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92

org/apache/turbine/services/TurbineServiceProvider.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 42

org/apache/turbine/services/TurbineServices.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 67–75
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 67
LocalVariableCouldBeFinal Local variable 'previous' could be declared final 69

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55–306
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
RedundantFieldInitializer Avoid using redundant field initializer for 'factories' 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
RedundantFieldInitializer Avoid using redundant field initializer for 'assemblerCache' 67
RedundantFieldInitializer Avoid using redundant field initializer for 'loaderCache' 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
AvoidDuplicateLiterals The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 84 84
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103
LocalVariableCouldBeFinal Local variable 'names' could be declared final 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 105
LocalVariableCouldBeFinal Local variable 'name2' could be declared final 107
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 109
ShortVariable Avoid variables with short names like af 113
LocalVariableCouldBeFinal Local variable 'af' could be declared final 113–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 118–121
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 124–128
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 146
LocalVariableCouldBeFinal Local variable 'i' could be declared final 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 148–156
LocalVariableCouldBeFinal Local variable 'type' could be declared final 150
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 164–166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 170–172
LocalVariableCouldBeFinal Local variable 'cacheSize' could be declared final 170–172
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 190
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 192
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 211
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 211
CyclomaticComplexity The method 'getAssembler(Class, String)' has a cyclomatic complexity of 10. 211–260
LocalVariableCouldBeFinal Local variable 'key' could be declared final 214
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 225
LocalVariableCouldBeFinal Local variable 'it' could be declared final 227
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 229
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 233
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 235
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 240
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 240
LocalVariableCouldBeFinal Local variable 'oldAssembler' could be declared final 249
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 250–253
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 273
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 285
LocalVariableCouldBeFinal Local variable 'it' could be declared final 287
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 289
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 290

org/apache/turbine/services/assemblerbroker/util/java/JavaActionFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 42–142
AbstractNaming Abstract classes should be named AbstractXXX 42–142
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'packageName' is not assigned and could be declared final 65
LocalVariableCouldBeFinal Local variable 'p' could be declared final 73
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 75
ShortVariable Avoid variables with short names like sb 75
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 75
LocalVariableCouldBeFinal Local variable 'className' could be declared final 78
LocalVariableCouldBeFinal Local variable '_servClass' could be declared final 88
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 89–92
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 94
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 140

org/apache/turbine/services/assemblerbroker/util/java/JavaLayoutFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaNavigationFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaPageFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScheduledJobFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScreenFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/python/PythonActionFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 48–177
AtLeastOneConstructor Each class should declare at least one constructor 48–177
LongVariable Avoid excessively long variable names like PYTHON_CONFIG_FILE 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'subDirectory' is not assigned and could be declared final 71
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 72
LocalVariableCouldBeFinal Local variable 'path' could be declared final 74
LocalVariableCouldBeFinal Local variable 'confName' could be declared final 86
LocalVariableCouldBeFinal Local variable 'fName' could be declared final 89
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 91
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 92
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 93
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 94
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 95
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 95
ShortVariable Avoid variables with short names like f 98
LocalVariableCouldBeFinal Local variable 'f' could be declared final 98
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 130–139
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 132–138
LocalVariableCouldBeFinal Local variable 't' could be declared final 143
ShortVariable Avoid variables with short names like t 143
ExceptionAsFlowControl Avoid using exceptions as flow control. 146
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 175

org/apache/turbine/services/assemblerbroker/util/python/PythonLayoutFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonNavigationFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonPageFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonScreenFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/avaloncomponent/AvalonComponentService.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 37
LongVariable Avoid excessively long variable names like AVALON_LOG_CATEGORY 40
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 40
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_KEY 43
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 43
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_VALUE 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 46
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_KEY 49
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 49
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_VALUE 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 55
LongVariable Avoid excessively long variable names like COMPONENT_LOOKUP_KEY 55
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 58
LongVariable Avoid excessively long variable names like COMPONENT_APP_ROOT 58

org/apache/turbine/services/avaloncomponent/Log4j2Logger.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 35

org/apache/turbine/services/avaloncomponent/TurbineYaafiComponentService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43–293
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_KEY 51
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_VALUE 54
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY 57
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 80
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 116
LocalVariableCouldBeFinal Local variable 'home' could be declared final 116
LocalVariableCouldBeFinal Local variable 'config' could be declared final 120–121
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 131
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 147
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 158
MethodArgumentCouldBeFinal Parameter 'component' is not assigned and could be declared final 169
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 178
MethodArgumentCouldBeFinal Parameter 'applicationRoot' is not assigned and could be declared final 192
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 192
LocalVariableCouldBeFinal Local variable 'result' could be declared final 195
LongVariable Avoid excessively long variable names like containerConfiguration 206
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 206–208
LongVariable Avoid excessively long variable names like roleConfigurationFileName 216
LocalVariableCouldBeFinal Local variable 'roleConfigurationFileName' could be declared final 216–219
LongVariable Avoid excessively long variable names like componentConfigurationFileName 223
LocalVariableCouldBeFinal Local variable 'componentConfigurationFileName' could be declared final 223–226
LocalVariableCouldBeFinal Local variable 'parametersFileName' could be declared final 230–233
LongVariable Avoid excessively long variable names like parametersFileName 230
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 243–246
LongVariable Avoid excessively long variable names like containerConfiguration 243
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 271
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 280
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 280
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 286–291
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 288

org/apache/turbine/services/intake/IntakeTool.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 54–551
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 65
RedundantFieldInitializer Avoid using redundant field initializer for 'groups' 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
ShortVariable Avoid variables with short names like pp 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 70
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 72
RedundantFieldInitializer Avoid using redundant field initializer for 'pullMap' 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 81
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 86–88
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 94
LocalVariableCouldBeFinal Local variable 'groupNames' could be declared final 98
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 109
LocalVariableCouldBeFinal Local variable 'groupKeys' could be declared final 115
UnusedAssignment The initializer for variable 'groupNames' is never used (overwritten on lines 119 and 123) 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 134–135
LocalVariableCouldBeFinal Local variable 'foundGroups' could be declared final 134–135
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 139–140
ShortVariable Avoid variables with short names like vp 155
MethodArgumentCouldBeFinal Parameter 'vp' is not assigned and could be declared final 155
LocalVariableCouldBeFinal Local variable 'group' could be declared final 157
LocalVariableCouldBeFinal Local variable 'group' could be declared final 183
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 197
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 210
ShortVariable Avoid variables with short names like sb 210
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 210
LocalVariableCouldBeFinal Local variable 'group' could be declared final 230
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 252
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the groupName field if you want a default access modifier 252
DefaultPackage Use explicit scoping instead of the default package private level 252
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 259
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 283–287
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 283
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 297
MethodArgumentCouldBeFinal Parameter 'create' is not assigned and could be declared final 297
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 297–315
ShortVariable Avoid variables with short names like g 300
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 302
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 323
UnusedAssignment The initializer for variable 'g' is never used (overwritten on lines 333 and 337) 325
ShortVariable Avoid variables with short names like g 325
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 329–330
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 341
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 357
MethodArgumentCouldBeFinal Parameter 'throwExceptions' is not assigned and could be declared final 370
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 370
LocalVariableCouldBeFinal Local variable 'group' could be declared final 384
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 398
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 398
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 413
MethodArgumentCouldBeFinal Parameter 'create' is not assigned and could be declared final 413
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 413
ShortVariable Avoid variables with short names like ph 425
LocalVariableCouldBeFinal Local variable 'ph' could be declared final 425
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 426
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 435
LocalVariableCouldBeFinal Local variable 'groupKeys' could be declared final 442
LocalVariableCouldBeFinal Local variable 'groupKey' could be declared final 448
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 475
LocalVariableCouldBeFinal Local variable 'allGroups' could be declared final 475
LocalVariableCouldBeFinal Local variable 'group' could be declared final 478
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 495
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 495
LocalVariableCouldBeFinal Local variable 'group' could be declared final 521
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 536

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 40–87
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 51
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 51
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 51
UnusedAssignment The initializer for variable 'json_req' is never used (overwritten on line 58) 54
UnusedAssignment The initializer for variable 'json_res' is never used (overwritten on lines 75 and 80) 55
LocalVariableCouldBeFinal Local variable 'methodName' could be declared final 61
LocalVariableCouldBeFinal Local variable 'arguments' could be declared final 62
LocalVariableCouldBeFinal Local variable 'object_id' could be declared final 65
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 66
ShortVariable Avoid variables with short names like sb 66

org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 37–102
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 45
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 46
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 46
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 52
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 54
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 58
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 61
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 77

org/apache/turbine/services/jsp/JspService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like BUFFER_SIZE_DEFAULT 56

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 52–311
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
LongVariable Avoid excessively long variable names like relativeTemplatePaths 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 86
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 100
LocalVariableCouldBeFinal Local variable 'req' could be declared final 102
LocalVariableCouldBeFinal Local variable 'templateLink' could be declared final 109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 113
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 137
MethodArgumentCouldBeFinal Parameter 'isForward' is not assigned and could be declared final 137
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 137
LocalVariableCouldBeFinal Local variable 'data' could be declared final 145
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 145
LongVariable Avoid excessively long variable names like relativeTemplateName 148
LocalVariableCouldBeFinal Local variable 'relativeTemplateName' could be declared final 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 157–158
LocalVariableCouldBeFinal Local variable 'dispatcher' could be declared final 157–158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 157–158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 169
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 169
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 179–180
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 179–180
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 181
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 204
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 204
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 214
LocalVariableCouldBeFinal Local variable 'config' could be declared final 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 220
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 231–232
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 243
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 245
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 249
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 264
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 264
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 279
LocalVariableCouldBeFinal Local variable 'relativeTemplate' could be declared final 281
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 290
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 302
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 304
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 307

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 75
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 79
LocalVariableCouldBeFinal Local variable 'message' could be declared final 81–82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
EmptyCatchBlock Avoid empty catch blocks 88–91

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 64
LocalVariableCouldBeFinal Local variable 'abs' could be declared final 67–68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 82
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 83
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 86
LocalVariableCouldBeFinal Local variable 'message' could be declared final 88–89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
EmptyCatchBlock Avoid empty catch blocks 95–98

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
LongVariable Avoid excessively long variable names like localizationService 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 75
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 79
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 109
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 134
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 150

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 50–171
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPropsList' 61
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 81
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 86–113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 86
LocalVariableCouldBeFinal Local variable 'key' could be declared final 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 90
LocalVariableCouldBeFinal Local variable 'end' could be declared final 90
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 97
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 102 and 106) 98
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 106
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 109–110
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 115
LocalVariableCouldBeFinal Local variable 'key' could be declared final 117
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 118
LocalVariableCouldBeFinal Local variable 'context' could be declared final 119
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 119
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 129–130
MethodArgumentCouldBeFinal Parameter 'contextName' is not assigned and could be declared final 146
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 154 and 158) 150
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 166

org/apache/turbine/services/pull/PullService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_KEY 82
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_DEFAULT 88
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_KEY 94
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_DEFAULT 97
LongVariable Avoid excessively long variable names like SESSION_TOOLS_ATTRIBUTE_PREFIX 100

org/apache/turbine/services/pull/TurbinePullService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 121–841
GodClass Possible God Class (WMC=65, ATFD=64, TCC=27.485%) 121–841
TooManyMethods This class has too many methods, consider refactoring it. 124–841
RedundantFieldInitializer Avoid using redundant field initializer for 'pool' 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 132
RedundantFieldInitializer Avoid using redundant field initializer for 'velocity' 132
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 142
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the toolName field if you want a default access modifier 151
DefaultPackage Use explicit scoping instead of the default package private level 151
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 151
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 152
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the toolClassName field if you want a default access modifier 152
DefaultPackage Use explicit scoping instead of the default package private level 152
DefaultPackage Use explicit scoping instead of the default package private level 153
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the toolClass field if you want a default access modifier 153
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 153
MethodArgumentCouldBeFinal Parameter 'toolClass' is not assigned and could be declared final 155
MethodArgumentCouldBeFinal Parameter 'toolName' is not assigned and could be declared final 155
MethodArgumentCouldBeFinal Parameter 'toolClassName' is not assigned and could be declared final 155
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 164
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 164
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 167
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 167
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 170
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 170
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 173
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 173
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 176
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 176
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 179
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 179
LongVariable Avoid excessively long variable names like resourcesDirectory 179
LongVariable Avoid excessively long variable names like refreshToolsPerRequest 182
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 182
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 182
RedundantFieldInitializer Avoid using redundant field initializer for 'refreshToolsPerRequest' 182
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 193
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 208
ConfusingTernary Avoid if (x != y) ..; else ..; 210–217
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 219
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 231
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 234
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 238–240
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 245–247
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 266
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 272
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 289
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 291
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 293
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 295
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 297
MethodArgumentCouldBeFinal Parameter 'toolConfig' is not assigned and could be declared final 316
LocalVariableCouldBeFinal Local variable 'tools' could be declared final 318
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 324
LocalVariableCouldBeFinal Local variable 'it' could be declared final 327
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 327–346
LocalVariableCouldBeFinal Local variable 'toolName' could be declared final 329
LocalVariableCouldBeFinal Local variable 'toolClassName' could be declared final 330
LocalVariableCouldBeFinal Local variable 'toolClass' could be declared final 335
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 338
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 377
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 377
LocalVariableCouldBeFinal Local variable 'user' could be declared final 391
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 400–403
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 401–403
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 405
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 405
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 422
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 422
LocalVariableCouldBeFinal Local variable 'data' could be declared final 424
CloseResource Ensure that resources like this RunData object are closed after use 424
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 437
LocalVariableCouldBeFinal Local variable 'user' could be declared final 437
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 446–449
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 447–449
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 451
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 451
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 463
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 465
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 469
LawOfDemeter Potential violation of Law of Demeter (static property access) 469
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 469
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 477
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 491
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 491
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 494
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 499
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 507
MethodArgumentCouldBeFinal Parameter 'tools' is not assigned and could be declared final 524
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 524
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 525
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 525
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 528
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 538–540
ConfusingTernary Avoid if (x != y) ..; else ..; 553–585
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 556–558
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 558
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 558
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 588
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 606
MethodArgumentCouldBeFinal Parameter 'tools' is not assigned and could be declared final 606
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 607
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 607
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 610
ConfusingTernary Avoid if (x != y) ..; else ..; 636–664
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 667
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 712
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 714
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 727
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 741
MethodArgumentCouldBeFinal Parameter 'tools' is not assigned and could be declared final 741
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 745
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 747
MethodArgumentCouldBeFinal Parameter 'param' is not assigned and could be declared final 765
MethodArgumentCouldBeFinal Parameter 'tool' is not assigned and could be declared final 765
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 766
LocalVariableCouldBeFinal Local variable 'data' could be declared final 778
CloseResource Ensure that resources like this RunData object are closed after use 778
CloseResource Ensure that resources like this RunData object are closed after use 783
LocalVariableCouldBeFinal Local variable 'data' could be declared final 783
MethodArgumentCouldBeFinal Parameter 'tool' is not assigned and could be declared final 810
MethodArgumentCouldBeFinal Parameter 'dataObject' is not assigned and could be declared final 810
CloseResource Ensure that resources like this RunData object are closed after use 812
CloseResource Ensure that resources like this PipelineData object are closed after use 813
UnusedAssignment The initializer for variable 'pipelineData' is never used (overwritten on line 816) 813
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 833

org/apache/turbine/services/pull/tools/ContentTool.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CONTENT_TOOL_PREFIX 54
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_KEY 62
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_DEFAULT 65
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_KEY 68
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_DEFAULT 71
RedundantFieldInitializer Avoid using redundant field initializer for 'wantEncoding' 74
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantEncoding field if you want a default access modifier 74
DefaultPackage Use explicit scoping instead of the default package private level 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 77
DefaultPackage Use explicit scoping instead of the default package private level 77
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantRelative field if you want a default access modifier 77
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 80
RedundantFieldInitializer Avoid using redundant field initializer for 'dataURI' 80
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 85–88
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 107
CloseResource Ensure that resources like this PipelineData object are closed after use 114
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 114
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 115
CloseResource Ensure that resources like this RunData object are closed after use 115
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 124–125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 125
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 158
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 175
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 191

org/apache/turbine/services/pull/tools/TemplateLink.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 61–613
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_PREFIX 63
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_KEY 66
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_DEFAULT 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 73
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 76
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 76
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 79
RedundantFieldInitializer Avoid using redundant field initializer for 'templateURI' 79
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 89–92
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 111
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 118
CloseResource Ensure that resources like this PipelineData object are closed after use 118
CloseResource Ensure that resources like this RunData object are closed after use 119
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 119
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 127–128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 128
LinguisticNaming Linguistics Antipattern - The setter 'setEncodeURLOff' should not return any type except void linguistically 164–168
LinguisticNaming Linguistics Antipattern - The setter 'setPage' should not return any type except void linguistically 176–182
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 176
LinguisticNaming Linguistics Antipattern - The setter 'setAction' should not return any type except void linguistically 204–209
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 204
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 221
LinguisticNaming Linguistics Antipattern - The setter 'setActionEvent' should not return any type except void linguistically 221–226
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 221
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 237–242
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 237
LinguisticNaming Linguistics Antipattern - The setter 'setReference' should not return any type except void linguistically 250–254
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 250
ShortVariable Avoid variables with short names like pp 282
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 282
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 295
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 295
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 308
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 308
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 321
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 321
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 334
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 334
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 347
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 347
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 360
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 360
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 373
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 373
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 386
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 386
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 399
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 399
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 412
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 412
ShortVariable Avoid variables with short names like pp 425
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 425
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 448
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 471
LocalVariableCouldBeFinal Local variable 'output' could be declared final 501
LocalVariableCouldBeFinal Local variable 'output' could be declared final 536

org/apache/turbine/services/pull/tools/UITool.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 65–390
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 132
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 160
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 174
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 188
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 206
MethodArgumentCouldBeFinal Parameter 'skin' is not assigned and could be declared final 206
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 225
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 225
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 243
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 243
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 255
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 274
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 292
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 322
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 322
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 340
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 340
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 352
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 364
CloseResource Ensure that resources like this PipelineData object are closed after use 378
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 378
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 379
CloseResource Ensure that resources like this RunData object are closed after use 379

org/apache/turbine/services/pull/util/DateFormatter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–119
LongVariable Avoid excessively long variable names like DATE_FORMAT_DEFAULT 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormat' 50
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 66–67
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 103
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 110 and 115) 105
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 106

org/apache/turbine/services/pull/util/SessionData.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 39–118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 116

org/apache/turbine/services/rundata/DefaultTurbineRunData.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1–1384
CouplingBetweenObjects High amount of different objects as members denotes a high coupling 1–1384
ExcessivePublicCount This class has a bunch of public methods and attributes 1–1384
GodClass Possible God Class (WMC=118, ATFD=78, TCC=1.417%) 80–1384
TooManyFields Too many fields 80–1384
CyclomaticComplexity The class 'DefaultTurbineRunData' has a total cyclomatic complexity of 118 (highest 4). 80–1384
ExcessiveClassLength Avoid really long classes. 80–1384
TooManyMethods This class has too many methods, consider refactoring it. 83–1384
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 105
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 126
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 132
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 135
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 138
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 144
LongVariable Avoid excessively long variable names like stackTraceException 144
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 151
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 166
LocalVariableCouldBeFinal Local variable 'user' could be declared final 171
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 172
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 186
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 192
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 194
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 227
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 229
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 230
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 231
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 232
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 233
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 235
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 236
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 238
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 241
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 242
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 243
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 244
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 245
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 246
LocalVariableCouldBeFinal Local variable 'parameters' could be declared final 263
LocalVariableCouldBeFinal Local variable 'request' could be declared final 264
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 266
LocalVariableCouldBeFinal Local variable 'cookies' could be declared final 283
LocalVariableCouldBeFinal Local variable 'request' could be declared final 284
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 286
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 324
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 358
MethodArgumentCouldBeFinal Parameter 'acl' is not assigned and could be declared final 371
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 373
LiteralsFirstInComparisons Position literals first in String comparisons 385
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 407
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 435
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 435
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 436
MethodArgumentCouldBeFinal Parameter 'layout' is not assigned and could be declared final 453
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 467
MethodArgumentCouldBeFinal Parameter 'layout' is not assigned and could be declared final 480
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 482
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 513
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 527
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 539
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 541
MethodArgumentCouldBeFinal Parameter 'encoding' is not assigned and could be declared final 561
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 579
LocalVariableCouldBeFinal Local variable 'message' could be declared final 593
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 594
LocalVariableCouldBeFinal Local variable 'message' could be declared final 606
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 607
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 616
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 628
LocalVariableCouldBeFinal Local variable 'message' could be declared final 630
LocalVariableCouldBeFinal Local variable 'message' could be declared final 650
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 660
MethodArgumentCouldBeFinal Parameter 'msgs' is not assigned and could be declared final 688
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 690
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 710
LocalVariableCouldBeFinal Local variable 'user' could be declared final 723
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 726
LocalVariableCouldBeFinal Local variable 'user' could be declared final 742
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 752
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 755
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 808
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 852
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 854
LocalVariableCouldBeFinal Local variable 'parameters' could be declared final 857
LocalVariableCouldBeFinal Local variable 'cookies' could be declared final 858
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 883
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 892
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 926
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 952
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 955
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 959
MethodArgumentCouldBeFinal Parameter 'contentType' is not assigned and could be declared final 972
MethodArgumentCouldBeFinal Parameter 'ruri' is not assigned and could be declared final 996
MethodArgumentCouldBeFinal Parameter 'statusCode' is not assigned and could be declared final 1018
LocalVariableCouldBeFinal Local variable 'result' could be declared final 1031
MethodArgumentCouldBeFinal Parameter 'err' is not assigned and could be declared final 1042
MethodArgumentCouldBeFinal Parameter 'contexts' is not assigned and could be declared final 1068
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1081
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1092
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1125
LocalVariableCouldBeFinal Local variable 'user' could be declared final 1196
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1197
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1213
MethodArgumentCouldBeFinal Parameter 'trace' is not assigned and could be declared final 1245
MethodArgumentCouldBeFinal Parameter 'exp' is not assigned and could be declared final 1245
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 1260
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1260
MethodArgumentCouldBeFinal Parameter 'out' is not assigned and could be declared final 1318
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 1328
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1330
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 1338
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1340
MethodArgumentCouldBeFinal Parameter 'port' is not assigned and could be declared final 1348
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1350
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 1358
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1360
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 1368
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1370

org/apache/turbine/services/rundata/RunDataService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like PARAMETER_PARSER_KEY 54

org/apache/turbine/services/rundata/TurbineRunDataService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like DEFAULT_PARAMETER_PARSER 70
LongVariable Avoid excessively long variable names like DEFAULT_COOKIE_PARSER 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 84
RedundantFieldInitializer Avoid using redundant field initializer for 'pool' 84
RedundantFieldInitializer Avoid using redundant field initializer for 'parserService' 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 87
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 92–95
CyclomaticComplexity The method 'init()' has a cyclomatic complexity of 11. 103–168
UseShortArrayInitializer Array initialization can be written shorter 107–112
LocalVariableCouldBeFinal Local variable 'def' could be declared final 107–112
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 116
UseShortArrayInitializer Array initialization can be written shorter 121–126
LocalVariableCouldBeFinal Local variable 'plist' could be declared final 121–126
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 127–148
LocalVariableCouldBeFinal Local variable 'i' could be declared final 127
ShortVariable Avoid variables with short names like j 131
LocalVariableCouldBeFinal Local variable 'plistKey' could be declared final 132
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 136
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 136
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 138–142
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 151
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 159
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 192
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 193
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 213
CyclomaticComplexity The method 'getRunData(String, HttpServletRequest, HttpServletResponse, ServletConfig)' has a cyclomatic complexity of 12. 213–287
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 214
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 215
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 216
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 218
LocalVariableCouldBeFinal Local variable 'cfg' could be declared final 233
LocalVariableCouldBeFinal Local variable 'runDataClazz' could be declared final 242
LocalVariableCouldBeFinal Local variable 'parameterParserClazz' could be declared final 243
LongVariable Avoid excessively long variable names like parameterParserClazz 243
LocalVariableCouldBeFinal Local variable 'cookieParserClazz' could be declared final 244
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 248
ShortVariable Avoid variables with short names like pp 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 249
LocalVariableCouldBeFinal Local variable 'cp' could be declared final 252
ShortVariable Avoid variables with short names like cp 252
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 253
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 276
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 277
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 277
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 280
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 280
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 281
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 281
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 296
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 303
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 312
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 312

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Line
StdCyclomaticComplexity The class 'AbstractJobEntry' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 35–478
ModifiedCyclomaticComplexity The class 'AbstractJobEntry' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 35–478
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
RedundantFieldInitializer Avoid using redundant field initializer for 'jobIsActive' 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
RedundantFieldInitializer Avoid using redundant field initializer for 'runtime' 44
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 94
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 95
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 96
ShortVariable Avoid variables with short names like wd 97
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 97
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 98
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 99
ShortVariable Avoid variables with short names like je 129
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 129
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 187
LocalVariableCouldBeFinal Local variable 'schedrun' could be declared final 210
LocalVariableCouldBeFinal Local variable 'now' could be declared final 211
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 225
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 238
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 244
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 258
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 264
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 277
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 283
StdCyclomaticComplexity The method 'evaluateJobType' has a Standard Cyclomatic Complexity of 10. 304–375
CyclomaticComplexity The method 'evaluateJobType()' has a cyclomatic complexity of 21. 304–375
ModifiedCyclomaticComplexity The method 'evaluateJobType' has a Modified Cyclomatic Complexity of 10. 304–375
AvoidDuplicateLiterals The String literal "Error in JobEntry. Bad Job parameter." appears 5 times in this file; the first occurrence is on line 323 323
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 326
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 337
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 349
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 361
ShortVariable Avoid variables with short names like v 391
ShortVariable Avoid variables with short names like v 405
ShortVariable Avoid variables with short names like v 419
ShortVariable Avoid variables with short names like v 433
ShortVariable Avoid variables with short names like v 447
ShortVariable Avoid variables with short names like v 461
ShortVariable Avoid variables with short names like v 477

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 38–371
RedundantFieldInitializer Avoid using redundant field initializer for 'scheduleQueue' 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 43
RedundantFieldInitializer Avoid using redundant field initializer for 'enabled' 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
CallSuperInConstructor It is a good practice to call super() in a constructor 57–61
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 79
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 109
ShortVariable Avoid variables with short names like wd 117
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 140
ShortVariable Avoid variables with short names like je 140
ShortVariable Avoid variables with short names like je 154
ShortVariable Avoid variables with short names like je 165
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 184
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 204–208
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 214–223
LocalVariableCouldBeFinal Local variable 'thread' could be declared final 217
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 217
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 232–235
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 232
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 240–243
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 242
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 251–274
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 261
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 271
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 283–324
LocalVariableCouldBeFinal Local variable 'je' could be declared final 290
ShortVariable Avoid variables with short names like je 290
LocalVariableCouldBeFinal Local variable 'now' could be declared final 299
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 300
LocalVariableCouldBeFinal Local variable 'when' could be declared final 300
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 312
AtLeastOneConstructor Each class should declare at least one constructor 331–370
ShortVariable Avoid variables with short names like je 344
LocalVariableCouldBeFinal Local variable 'je' could be declared final 344
ConfusingTernary Avoid if (x != y) ..; else ..; 345–357
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 347
ShortVariable Avoid variables with short names like wt 350
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 350
LocalVariableCouldBeFinal Local variable 'wt' could be declared final 350
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 351
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 351
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 351
LocalVariableCouldBeFinal Local variable 'helper' could be declared final 351
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 360

org/apache/turbine/services/schedule/JobEntry.java

Rule Violation Line
ShortVariable Avoid variables with short names like v 74
ShortVariable Avoid variables with short names like v 88

org/apache/turbine/services/schedule/JobEntryNonPersistent.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 32
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 33
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 35
ShortVariable Avoid variables with short names like wd 35
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 38
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 82
ShortVariable Avoid variables with short names like wd 82
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 83
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 96
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 103
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 107
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 119
ShortVariable Avoid variables with short names like v 141
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 141
ShortVariable Avoid variables with short names like v 163
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 163
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 185
ShortVariable Avoid variables with short names like v 185
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 207
ShortVariable Avoid variables with short names like v 207
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 229
ShortVariable Avoid variables with short names like v 229
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 251
ShortVariable Avoid variables with short names like v 251
ShortVariable Avoid variables with short names like v 273
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 273

org/apache/turbine/services/schedule/JobEntryQuartz.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 47
ImmutableField Private field 'active' could be made final; it is only initialized in the declaration or constructor. 48
LongVariable Avoid excessively long variable names like DEFAULT_JOB_GROUP_NAME 53
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'jobDetail' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 81
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 95
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 117
ShortVariable Avoid variables with short names like v 117
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 139
ShortVariable Avoid variables with short names like v 139
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 155
ShortVariable Avoid variables with short names like o 172
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 172
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 219
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 235
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 237
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 250
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 252

org/apache/turbine/services/schedule/JobQueue.java

Rule Violation Line
UnusedAssignment The field initializer for 'queue' is never used (overwritten on line 49) 42
RedundantFieldInitializer Avoid using redundant field initializer for 'queue' 42
ImmutableField Private field 'queue' could be made final; it is only initialized in the declaration or constructor. 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
LooseCoupling Avoid using implementation types like 'Vector'; use the interface instead 42
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 42
UseArrayListInsteadOfVector Use ArrayList instead of Vector 49
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 60
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 62
ShortVariable Avoid variables with short names like je 76
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 76
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 87
LooseCoupling Avoid using implementation types like 'Vector'; use the interface instead 101
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 101
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 103
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 105
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 105
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 118
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 118–122
ShortVariable Avoid variables with short names like je 118
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 130–138
MethodArgumentCouldBeFinal Parameter 'jobEntries' is not assigned and could be declared final 130
ShortVariable Avoid variables with short names like je 145
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 145–149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 145
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 157–163
ShortVariable Avoid variables with short names like je 157
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 157
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 171
ShortVariable Avoid variables with short names like je 171
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 171–176
LocalVariableCouldBeFinal Local variable 'aComparator' could be declared final 184–188

org/apache/turbine/services/schedule/QuartzSchedulerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 49–413
TooManyMethods This class has too many methods, consider refactoring it. 52–413
RedundantFieldInitializer Avoid using redundant field initializer for 'enabled' 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 72
ShortVariable Avoid variables with short names like qs 73
LocalVariableCouldBeFinal Local variable 'qs' could be declared final 73–74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 73–74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 103
ShortVariable Avoid variables with short names like wd 103
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107–109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107–109
ShortVariable Avoid variables with short names like jd 107
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 107–109
LocalVariableCouldBeFinal Local variable 'csb' could be declared final 111
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113–117
LocalVariableCouldBeFinal Local variable 't' could be declared final 113–117
ShortVariable Avoid variables with short names like t 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113–117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113–117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113–117
LocalVariableCouldBeFinal Local variable 'jeq' could be declared final 119
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'jeq' 121
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 140
ShortVariable Avoid variables with short names like wd 140
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 140
ShortVariable Avoid variables with short names like sb 142
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 142
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 143
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 144
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 175
LocalVariableCouldBeFinal Local variable 'je' could be declared final 178
ShortVariable Avoid variables with short names like je 196
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 196
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 202
ShortVariable Avoid variables with short names like jq 202
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 203
ShortVariable Avoid variables with short names like je 218
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 218
ShortVariable Avoid variables with short names like jq 223
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 224
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 224
ShortVariable Avoid variables with short names like je 240
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 240
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 246
ShortVariable Avoid variables with short names like jq 246
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 247
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 263
LocalVariableCouldBeFinal Local variable 'groupMatcher' could be declared final 267
LocalVariableCouldBeFinal Local variable 'jobKeys' could be declared final 268
LocalVariableCouldBeFinal Local variable 'jk' could be declared final 269
LocalVariableCouldBeFinal Local variable 'triggers' could be declared final 271
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 273
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 277
ShortVariable Avoid variables with short names like jd 277
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 278
LocalVariableCouldBeFinal Local variable 'job' could be declared final 278
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 298
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 318–322
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 328–340
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 348–369
ConfusingTernary Avoid if (x != y) ..; else ..; 355–362
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 361
ShortVariable Avoid variables with short names like je 377
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 377
MethodArgumentCouldBeFinal Parameter 'jd' is not assigned and could be declared final 409
MethodArgumentCouldBeFinal Parameter 'trigger' is not assigned and could be declared final 409
ShortVariable Avoid variables with short names like jd 409
LocalVariableCouldBeFinal Local variable 'job' could be declared final 410
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'job' 411

org/apache/turbine/services/schedule/ScheduleService.java

Rule Violation Line
ShortVariable Avoid variables with short names like wd 84
ShortVariable Avoid variables with short names like je 104
ShortVariable Avoid variables with short names like je 113
ShortVariable Avoid variables with short names like je 122

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–113
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'jobId' is not assigned and could be declared final 97
ShortVariable Avoid variables with short names like je 99

org/apache/turbine/services/schedule/TorqueSchedulerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–177
LocalVariableCouldBeFinal Local variable 'jobsTorque' could be declared final 52
LocalVariableCouldBeFinal Local variable 'job' could be declared final 54
ShortVariable Avoid variables with short names like wd 71
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 71
LocalVariableCouldBeFinal Local variable 'jet' could be declared final 73
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 94
LocalVariableCouldBeFinal Local variable 'je' could be declared final 98
ShortVariable Avoid variables with short names like je 98
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 116
ShortVariable Avoid variables with short names like je 116
LocalVariableCouldBeFinal Local variable 'c' could be declared final 121
ShortVariable Avoid variables with short names like c 121
ShortVariable Avoid variables with short names like je 145
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 145

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 68–179
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 76
LocalVariableCouldBeFinal Local variable 'jobProps' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 82
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 84–112
LocalVariableCouldBeFinal Local variable 'jobName' could be declared final 86
LocalVariableCouldBeFinal Local variable 'jobPrefix' could be declared final 87
LocalVariableCouldBeFinal Local variable 'jobId' could be declared final 89
LocalVariableCouldBeFinal Local variable 'sec' could be declared final 97
LocalVariableCouldBeFinal Local variable 'min' could be declared final 98
LocalVariableCouldBeFinal Local variable 'hr' could be declared final 99
ShortVariable Avoid variables with short names like hr 99
LocalVariableCouldBeFinal Local variable 'wkday' could be declared final 100
LocalVariableCouldBeFinal Local variable 'dayOfMonth' could be declared final 101
ShortVariable Avoid variables with short names like je 103
LocalVariableCouldBeFinal Local variable 'je' could be declared final 103–109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 110
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 122
ShortVariable Avoid variables with short names like wd 122
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 135
LocalVariableCouldBeFinal Local variable 'je' could be declared final 138
ShortVariable Avoid variables with short names like je 138
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 149
ShortVariable Avoid variables with short names like je 149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 163
ShortVariable Avoid variables with short names like je 163
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 174

org/apache/turbine/services/schedule/WorkerThread.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'je' 42
ImmutableField Private field 'je' could be made final; it is only initialized in the declaration or constructor. 42
UnusedAssignment The field initializer for 'je' is never used (overwritten on line 54) 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
ShortVariable Avoid variables with short names like je 42
ShortVariable Avoid variables with short names like je 52
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 77
MethodArgumentCouldBeFinal Parameter 'state' is not assigned and could be declared final 97
UnnecessaryModifier Unnecessary modifier 'final' on method 'logStateChange': private methods cannot be overridden 97–101

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1–1125
AtLeastOneConstructor Each class should declare at least one constructor 72–1125
ExcessiveClassLength Avoid really long classes. 72–1125
GodClass Possible God Class (WMC=88, ATFD=38, TCC=8.956%) 72–1125
CyclomaticComplexity The class 'DefaultSecurityService' has a total cyclomatic complexity of 88 (highest 4). 72–1125
TooManyMethods This class has too many methods, consider refactoring it. 75–1125
RedundantFieldInitializer Avoid using redundant field initializer for 'readerCount' 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 77
RedundantFieldInitializer Avoid using redundant field initializer for 'userManager' 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 83
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 92
SingularField Perhaps 'backend' could be replaced by a local variable. 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 94
UnusedPrivateField Avoid unused private fields such as 'backend'. 94
RedundantFieldInitializer Avoid using redundant field initializer for 'globalGroup' 99
LocalVariableCouldBeFinal Local variable 'manager' could be declared final 115
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 120
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 126–128
LongVariable Avoid excessively long variable names like userManagerClassName 126
LocalVariableCouldBeFinal Local variable 'userManagerClassName' could be declared final 126–128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 133
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 178
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 184
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 209
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 226
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 234
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 256
MethodArgumentCouldBeFinal Parameter 'permName' is not assigned and could be declared final 272
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 280
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 302
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 319
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 327
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 356
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 359
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 373
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 376
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 393
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 393
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 397
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 411
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 414
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 429
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 442
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 444
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 457
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 460
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 476
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 479
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 493
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 493
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 496
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 508
AvoidDuplicateLiterals The String literal "user is null" appears 4 times in this file; the first occurrence is on line 512 512
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 516
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 531
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 531
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 532
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 536
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 554
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 554
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 557
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 566–569
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 577–581
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 580
ShortVariable Avoid variables with short names like g 644
LocalVariableCouldBeFinal Local variable 'g' could be declared final 644
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 658
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 675
ShortVariable Avoid variables with short names like id 675
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 691
LocalVariableCouldBeFinal Local variable 'role' could be declared final 694
ShortVariable Avoid variables with short names like id 712
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 712
LocalVariableCouldBeFinal Local variable 'role' could be declared final 716
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 734
ShortVariable Avoid variables with short names like id 751
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 751
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 811
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 814
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 833
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 833
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 833
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 854
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 854
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 854
MethodArgumentCouldBeFinal Parameter 'newRole' is not assigned and could be declared final 876
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 876
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 876
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 893
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 912
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 912
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 928
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 928
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 945
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 967
MethodArgumentCouldBeFinal Parameter 'cascadeDelete' is not assigned and could be declared final 967
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 983
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 998
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 1013
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 1028
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 1043
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 1057
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 1072
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1088
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 1088
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 1104
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1104
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 1120
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1120

org/apache/turbine/services/security/DefaultUserManager.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 76–537
TooManyMethods This class has too many methods, consider refactoring it. 77–537
RedundantFieldInitializer Avoid using redundant field initializer for 'umDelegate' 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 79
RedundantFieldInitializer Avoid using redundant field initializer for 'factoryService' 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 81
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 98
ShortVariable Avoid variables with short names like u 101
LocalVariableCouldBeFinal Local variable 'u' could be declared final 101
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 113
UseShortArrayInitializer Array initialization can be written shorter 117
LocalVariableCouldBeFinal Local variable 'params' could be declared final 117
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 118
UseShortArrayInitializer Array initialization can be written shorter 118
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 119
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 121
MethodArgumentCouldBeFinal Parameter 'userWrapperClass2' is not assigned and could be declared final 143
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 154
LocalVariableCouldBeFinal Local variable 'manager' could be declared final 156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 157
LocalVariableCouldBeFinal Local variable 'userWrapperClass' could be declared final 159–161
LocalVariableCouldBeFinal Local variable 'turbineUser' could be declared final 169
UseShortArrayInitializer Array initialization can be written shorter 171
LocalVariableCouldBeFinal Local variable 'params' could be declared final 171
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 172
UseShortArrayInitializer Array initialization can be written shorter 172
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 179
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 196
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 200
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 215
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 233
ShortVariable Avoid variables with short names like u 236
LocalVariableCouldBeFinal Local variable 'u' could be declared final 236
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 255
LocalVariableCouldBeFinal Local variable 'uset' could be declared final 258
LocalVariableCouldBeFinal Local variable 'userList' could be declared final 259
LocalVariableCouldBeFinal Local variable 'u' could be declared final 261
ShortVariable Avoid variables with short names like tu 263
LocalVariableCouldBeFinal Local variable 'tu' could be declared final 263
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 287
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 287
LocalVariableCouldBeFinal Local variable 'u' could be declared final 291
ShortVariable Avoid variables with short names like u 291
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 306
AvoidDuplicateLiterals The String literal "user is null" appears 6 times in this file; the first occurrence is on line 310 310
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 316
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 337
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 358
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 358
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 375
MethodArgumentCouldBeFinal Parameter 'initialPassword' is not assigned and could be declared final 375
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 392
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 415
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 415
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 416
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 444
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 444
LocalVariableCouldBeFinal Local variable 'u' could be declared final 464
ShortVariable Avoid variables with short names like u 464
MethodArgumentCouldBeFinal Parameter 'u' is not assigned and could be declared final 478
ShortVariable Avoid variables with short names like u 478
ShortVariable Avoid variables with short names like u 496
LocalVariableCouldBeFinal Local variable 'u' could be declared final 496
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 514
ShortVariable Avoid variables with short names like u 516
LocalVariableCouldBeFinal Local variable 'u' could be declared final 516
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 530

org/apache/turbine/services/security/SecurityService.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1–757
TooManyMethods This class has too many methods, consider refactoring it. 66–757
LongVariable Avoid excessively long variable names like USER_MANAGER_DEFAULT 80
LongVariable Avoid excessively long variable names like USER_WRAPPER_DEFAULT 93
ShortVariable Avoid variables with short names like u 272
ShortVariable Avoid variables with short names like id 538
ShortVariable Avoid variables with short names like id 568
ShortVariable Avoid variables with short names like id 598

org/apache/turbine/services/security/UserManager.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48–301
ShortVariable Avoid variables with short names like u 258

org/apache/turbine/services/security/passive/PassiveUserManager.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 46–365
TooManyMethods This class has too many methods, consider refactoring it. 47–365
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 69
AvoidDuplicateLiterals The String literal "PassiveUserManager knows no users" appears 10 times in this file; the first occurrence is on line 72 72
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 124
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 147
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 147
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 165
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 184
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'initialPassword' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 237
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 257
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 257
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 258
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 281
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 281
ShortVariable Avoid variables with short names like u 311
MethodArgumentCouldBeFinal Parameter 'u' is not assigned and could be declared final 311
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 346
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 361

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 51–254
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
RedundantFieldInitializer Avoid using redundant field initializer for 'servletContext' 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
RedundantFieldInitializer Avoid using redundant field initializer for 'servletConfig' 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 78
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
EmptyCatchBlock Avoid empty catch blocks 117–120
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 133
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 137
ShortVariable Avoid variables with short names like is 140
UnusedAssignment The initializer for variable 'is' is never used (overwritten on line 141) 140
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 154
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 162
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 250

org/apache/turbine/services/session/SessionListener.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 61–141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 127
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 139

org/apache/turbine/services/session/SessionTool.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38–141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
ShortVariable Avoid variables with short names like o 48
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 48
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 125
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 137

org/apache/turbine/services/session/TurbineSessionService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55–222
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 92
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111
LocalVariableCouldBeFinal Local variable 'session' could be declared final 128
ShortVariable Avoid variables with short names like u 130
LocalVariableCouldBeFinal Local variable 'u' could be declared final 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 131
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 147
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 154
MethodArgumentCouldBeFinal Parameter 'sessionId' is not assigned and could be declared final 169
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 182
LocalVariableCouldBeFinal Local variable 'sessions' could be declared final 184
LocalVariableCouldBeFinal Local variable 'session' could be declared final 185
ShortVariable Avoid variables with short names like u 187
LocalVariableCouldBeFinal Local variable 'u' could be declared final 187
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 217

org/apache/turbine/services/template/BaseTemplateEngineService.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 38–145
AtLeastOneConstructor Each class should declare at least one constructor 38–145
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 53
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 59
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 70
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 97
LocalVariableCouldBeFinal Local variable 'config' could be declared final 99
LongVariable Avoid excessively long variable names like fileExtensionAssociations 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 106
LocalVariableCouldBeFinal Local variable 'copyParams' could be declared final 124–132
LocalVariableCouldBeFinal Local variable 'copyParam' could be declared final 134

org/apache/turbine/services/template/TemplateEngineService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like TEMPLATE_EXTENSIONS 35
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_EXTENSION 37
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION 45
LongVariable Avoid excessively long variable names like DEFAULT_ERROR_SCREEN 47
LongVariable Avoid excessively long variable names like DEFAULT_LAYOUT_TEMPLATE 49
LongVariable Avoid excessively long variable names like DEFAULT_SCREEN_TEMPLATE 51
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION_TEMPLATE 53
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 60
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 60

org/apache/turbine/services/template/TemplateService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_KEY 49
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_VALUE 52
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_KEY 55
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_VALUE 58
LongVariable Avoid excessively long variable names like EXTENSION_SEPARATOR 61
LongVariable Avoid excessively long variable names like TEMPLATE_PARTS_SEPARATOR 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 218
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 229
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 240
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 251
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 262
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 273

org/apache/turbine/services/template/TurbineTemplateService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1–821
GodClass Possible God Class (WMC=49, ATFD=74, TCC=21.675%) 180–821
LongVariable Avoid excessively long variable names like LAYOUT_TEMPLATE_KEY 200
LongVariable Avoid excessively long variable names like LAYOUT_TEMPLATE_NAME 203
LongVariable Avoid excessively long variable names like SCREEN_TEMPLATE_KEY 206
LongVariable Avoid excessively long variable names like SCREEN_TEMPLATE_NAME 209
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE_KEY 212
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE_NAME 215
RedundantFieldInitializer Avoid using redundant field initializer for 'mapperRegistry' 221
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 221
RedundantFieldInitializer Avoid using redundant field initializer for 'useCache' 234
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 234
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 237
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 240
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 245
LongVariable Avoid excessively long variable names like templateEngineRegistry 255
RedundantFieldInitializer Avoid using redundant field initializer for 'templateEngineRegistry' 255
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 255
CallSuperInConstructor It is a good practice to call super() in a constructor 260–263
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 260–263
LocalVariableCouldBeFinal Local variable 'config' could be declared final 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 281–282
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 284–285
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 289–290
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 334
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 338
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 341
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 356
ShortVariable Avoid variables with short names like sb 356
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 435
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 449
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 463
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 477
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 491
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 504
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 506
ShortVariable Avoid variables with short names like pp 506
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 507
LocalVariableCouldBeFinal Local variable 'template' could be declared final 507
ConfusingTernary Avoid if (x != y) ..; else ..; 508
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 519
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 521
ShortVariable Avoid variables with short names like pp 521
LocalVariableCouldBeFinal Local variable 'template' could be declared final 522
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 522
ConfusingTernary Avoid if (x != y) ..; else ..; 523
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 535
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 550
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 565
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 581
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 596
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 612
MethodArgumentCouldBeFinal Parameter 'templatePaths' is not assigned and could be declared final 651
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 651
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 653
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 655
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 657
MethodArgumentCouldBeFinal Parameter 'service' is not assigned and could be declared final 670
LocalVariableCouldBeFinal Local variable 'exts' could be declared final 672
LocalVariableCouldBeFinal Local variable 'ext' could be declared final 674
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 688
MethodArgumentCouldBeFinal Parameter 'templateKey' is not assigned and could be declared final 701
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 701
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 715
ExcessiveMethodLength Avoid really long methods. 715–820
CyclomaticComplexity The method 'initMapper(Configuration)' has a cyclomatic complexity of 10. 715–820
UseShortArrayInitializer Array initialization can be written shorter 724–727
LocalVariableCouldBeFinal Local variable 'mapperNames' could be declared final 724–727
LocalVariableCouldBeFinal Local variable 'mapperKeys' could be declared final 729–732
UseShortArrayInitializer Array initialization can be written shorter 729–732
UseShortArrayInitializer Array initialization can be written shorter 734–742
LocalVariableCouldBeFinal Local variable 'mapperClasses' could be declared final 734–742
ShortVariable Avoid variables with short names like ab 744
LocalVariableCouldBeFinal Local variable 'ab' could be declared final 744–745
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 744–745
ConfusingTernary Avoid if (x != y) ..; else ..; 753
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 757
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 758
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 759
LocalVariableCouldBeFinal Local variable 'mapperDefaultProperty' could be declared final 761–769
LongVariable Avoid excessively long variable names like mapperDefaultProperty 761
UseShortArrayInitializer Array initialization can be written shorter 761–769
UseShortArrayInitializer Array initialization can be written shorter 771
LocalVariableCouldBeFinal Local variable 'mapperSeparator' could be declared final 771
UseShortArrayInitializer Array initialization can be written shorter 773–777
LocalVariableCouldBeFinal Local variable 'mapperPrefix' could be declared final 773–777
LocalVariableCouldBeFinal Local variable 'mapperProperty' could be declared final 781
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 781
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 782
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 783
LocalVariableCouldBeFinal Local variable 'mapperClass' could be declared final 786–787
ShortVariable Avoid variables with short names like tm 791
UnusedAssignment The initializer for variable 'tm' is never used (overwritten on line 796) 791
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 795
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 795
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 803
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 804
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 805
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 806

org/apache/turbine/services/template/mapper/BaseMapper.java

Rule Violation Line
DataClass The class 'BaseMapper' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=8, WMC=21) 40–226
AbstractNaming Abstract classes should be named AbstractXXX 40–226
RedundantFieldInitializer Avoid using redundant field initializer for 'useCache' 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
RedundantFieldInitializer Avoid using redundant field initializer for 'templateCache' 49
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 66–69
MethodArgumentCouldBeFinal Parameter 'cacheSize' is not assigned and could be declared final 84
MethodArgumentCouldBeFinal Parameter 'useCache' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'defaultProperty' is not assigned and could be declared final 120
MethodArgumentCouldBeFinal Parameter 'separator' is not assigned and could be declared final 138
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 170
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 170
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 171
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 171
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 175
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 178–179
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 178–179
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 178–179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 182
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 193
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 197
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 202
LocalVariableCouldBeFinal Local variable 'res' could be declared final 205

org/apache/turbine/services/template/mapper/BaseTemplateMapper.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 37–117
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 48–51
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 83
LocalVariableCouldBeFinal Local variable 'components' could be declared final 88–89
LocalVariableCouldBeFinal Local variable 'resBuf' could be declared final 93
LongVariable Avoid excessively long variable names like templateComponents 95
LocalVariableCouldBeFinal Local variable 'templateComponents' could be declared final 95
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 106

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'loader' 60
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 70–73
CallSuperInConstructor It is a good practice to call super() in a constructor 70–73
MethodArgumentCouldBeFinal Parameter 'loader' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 102
LocalVariableCouldBeFinal Local variable 'components' could be declared final 107–110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 121
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 127
LocalVariableCouldBeFinal Local variable 'pkg' could be declared final 131
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 132
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 132
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 151
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 157
EmptyCatchBlock Avoid empty catch blocks 157–160

org/apache/turbine/services/template/mapper/DirectMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 43–46
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 57
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 65
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 66

org/apache/turbine/services/template/mapper/DirectTemplateMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 44–47
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 58
LocalVariableCouldBeFinal Local variable 'components' could be declared final 60–61

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 62–65
CallSuperInConstructor It is a good practice to call super() in a constructor 62–65
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 75
LocalVariableCouldBeFinal Local variable 'components' could be declared final 79–82
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 87
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 94
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 94
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 98
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 102
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 107
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 111
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 115
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 115
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 128
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 128
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 141

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 58–61
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 58–61
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 71
LocalVariableCouldBeFinal Local variable 'components' could be declared final 75–78
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 83
UnusedAssignment The updated value of variable 'componentSize' is never used 84
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 89
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 94
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 102
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 106
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 110
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 110
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 123
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 123
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 136

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 47–50
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 60
LocalVariableCouldBeFinal Local variable 'components' could be declared final 62
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 66
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 66
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 68
LocalVariableCouldBeFinal Local variable 'testPath' could be declared final 71
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 79

org/apache/turbine/services/ui/TurbineUIService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 57–531
LongVariable Avoid excessively long variable names like SKIN_PROPERTY_DEFAULT 108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 115
LongVariable Avoid excessively long variable names like DEFAULT_SKIN_CSS_FILE 126
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 131
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 136
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 141
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 147
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 147
ImmutableField Private field 'skins' could be made final; it is only initialized in the declaration or constructor. 152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 152
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 169
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 187
LocalVariableCouldBeFinal Local variable 'skinProperties' could be declared final 189
ConfusingTernary Avoid if (x != y) ..; else ..; 190
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 208
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 208
LocalVariableCouldBeFinal Local variable 'skinProperties' could be declared final 210
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 211
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 227
LocalVariableCouldBeFinal Local variable 'skinsDir' could be declared final 240
LocalVariableCouldBeFinal Local variable 'directory' could be declared final 242
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 261
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 280
LongVariable Avoid excessively long variable names like defaultSkinProperties 282
LocalVariableCouldBeFinal Local variable 'skinProperties' could be declared final 290
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 292
ShortVariable Avoid variables with short names like sb 292
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 293
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 294
ShortVariable Avoid variables with short names like is 298
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 304
ConfusingTernary Avoid if (x != y) ..; else ..; 307–322
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 311
ConfusingTernary Avoid if (x != y) ..; else ..; 313–322
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 316
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 321
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 343–344
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 361
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 361
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 361
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 374
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 374
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 393
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 393
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 406
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 425
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 425
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 426
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 439
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 439
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 448
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 452
LocalVariableCouldBeFinal Local variable 'len' could be declared final 452
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 454
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 454
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 459
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 477
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 477
MethodArgumentCouldBeFinal Parameter 'subDir' is not assigned and could be declared final 478
MethodArgumentCouldBeFinal Parameter 'resourceName' is not assigned and could be declared final 478
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 480
ShortVariable Avoid variables with short names like sb 480
ShortVariable Avoid variables with short names like du 488
LocalVariableCouldBeFinal Local variable 'du' could be declared final 488
LocalVariableCouldBeFinal Local variable 'cfg' could be declared final 501
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 503
LocalVariableCouldBeFinal Local variable 'pullService' could be declared final 504
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 504
ShortVariable Avoid variables with short names like sb 507
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 507
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 508
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 508
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 509
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 511
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 515
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 516
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 517

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44–152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
ShortVariable Avoid variables with short names like md 79
LocalVariableCouldBeFinal Local variable 'md' could be declared final 79
LocalVariableCouldBeFinal Local variable 'bytesId' could be declared final 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 88
LocalVariableCouldBeFinal Local variable 'current' could be declared final 130
ShortVariable Avoid variables with short names like id 131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 135
UseUnderscoresInNumericLiterals Number 100000000 should separate every third digit with an underscore 135

org/apache/turbine/services/urlmapper/MappedTemplateLink.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 50–118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56

org/apache/turbine/services/urlmapper/TurbineURLMapperService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1–325
AtLeastOneConstructor Each class should declare at least one constructor 72–325
LongVariable Avoid excessively long variable names like DEFAULT_CONFIGURATION_FILE 84
LongVariable Avoid excessively long variable names like CONFIGURATION_FILE_KEY 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 94
LongVariable Avoid excessively long variable names like NAMED_GROUPS_PATTERN 99
LongVariable Avoid excessively long variable names like MULTI_SLASH_PATTERN 104
LongVariable Avoid excessively long variable names like CONTEXT_PATH_PARAMETER 109
LongVariable Avoid excessively long variable names like WEBAPP_ROOT_PARAMETER 114
LongVariable Avoid excessively long variable names like DEFAULT_PARAMETERS 119
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 131
LocalVariableCouldBeFinal Local variable 'pathInfo' could be declared final 138
LocalVariableCouldBeFinal Local variable 'queryData' could be declared final 139
LocalVariableCouldBeFinal Local variable 'uriParameterMap' could be declared final 143–149
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 144
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 144–149
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 144
LocalVariableCouldBeFinal Local variable 'urlMap' could be declared final 151
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 153
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 156
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 156
LocalVariableCouldBeFinal Local variable 'entryKeys' could be declared final 156
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158–161
LocalVariableCouldBeFinal Local variable 'implicitKeysFound' could be declared final 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158–161
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 167
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 167
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 168
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 168
ShortVariable Avoid variables with short names like sb 168
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 170
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 172
LocalVariableCouldBeFinal Local variable 'key' could be declared final 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 177
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 180
LocalVariableCouldBeFinal Local variable 'ignore' could be declared final 183–184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 183–184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 183–184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 183–184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 185–187
ConfusingTernary Avoid if (x != y) ..; else ..; 187
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 194
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 196–199
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 202
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 202
ShortVariable Avoid variables with short names like pp 218
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 218
LocalVariableCouldBeFinal Local variable 'urlMap' could be declared final 220
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 223
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 224
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 234–235
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 234–235
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 238–239
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 238–239
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 242–243
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 242–243
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 245
LocalVariableCouldBeFinal Local variable 'cfg' could be declared final 260
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 262
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 266
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 266
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 271
LocalVariableCouldBeFinal Local variable 'servletService' could be declared final 271
LocalVariableCouldBeFinal Local variable 'jaxb' could be declared final 277
LocalVariableCouldBeFinal Local variable 'unmarshaller' could be declared final 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 279
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 284
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 285
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 288
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 288
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 289
LocalVariableCouldBeFinal Local variable 'urlMap' could be declared final 298
LocalVariableCouldBeFinal Local variable 'groupNamesMap' could be declared final 301
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 301
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 301
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 302
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 302
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 304
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 306
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 322

org/apache/turbine/services/urlmapper/URLMapperService.java

Rule Violation Line
ShortVariable Avoid variables with short names like pp 57

org/apache/turbine/services/urlmapper/URLMapperValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 39–61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 53
CloseResource Ensure that resources like this RunData object are closed after use 53
LocalVariableCouldBeFinal Local variable 'uri' could be declared final 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 54
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 54
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 56

org/apache/turbine/services/urlmapper/model/URLMapEntry.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44–175
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 48
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
RedundantFieldInitializer Avoid using redundant field initializer for 'relevantKeys' 52
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'implicit' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'ignore' is not assigned and could be declared final 106
MethodArgumentCouldBeFinal Parameter 'override' is not assigned and could be declared final 125
MethodArgumentCouldBeFinal Parameter 'groupNamesMap' is not assigned and could be declared final 145
MethodArgumentCouldBeFinal Parameter 'relevantKeys' is not assigned and could be declared final 165

org/apache/turbine/services/urlmapper/model/URLMappingContainer.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43–98
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'newURLMapEntries' is not assigned and could be declared final 94

org/apache/turbine/services/urlmapper/model/XmlParameterAdapter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 35–62
MethodArgumentCouldBeFinal Parameter 'xmlList' is not assigned and could be declared final 41
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 44–46
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 44–46
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 53
LocalVariableCouldBeFinal Local variable 'xmlList' could be declared final 55
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 56–58
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 56–58
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 56–58

org/apache/turbine/services/urlmapper/model/XmlParameterList.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55–108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 79
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 86
MethodArgumentCouldBeFinal Parameter 'xmlParameters' is not assigned and could be declared final 104

org/apache/turbine/services/urlmapper/model/XmlPatternAdapter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 31–50
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 37
MethodArgumentCouldBeFinal Parameter 'pattern' is not assigned and could be declared final 46

org/apache/turbine/services/velocity/TurbineVelocityService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 80–615
StdCyclomaticComplexity The class 'TurbineVelocityService' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 80–615
GodClass Possible God Class (WMC=52, ATFD=42, TCC=20.833%) 80–615
ModifiedCyclomaticComplexity The class 'TurbineVelocityService' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 80–615
LongVariable Avoid excessively long variable names like RESOURCE_LOADER_PATH 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 98
LongVariable Avoid excessively long variable names like defaultInputEncoding 98
LongVariable Avoid excessively long variable names like defaultOutputEncoding 101
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 101
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 104
RedundantFieldInitializer Avoid using redundant field initializer for 'pullModelActive' 104
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 107
RedundantFieldInitializer Avoid using redundant field initializer for 'velocity' 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 110
RedundantFieldInitializer Avoid using redundant field initializer for 'pullService' 113
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 138
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 146
LocalVariableCouldBeFinal Local variable 'inputEncoding' could be declared final 146
LongVariable Avoid excessively long variable names like outputEncodingString 149
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 149
LocalVariableCouldBeFinal Local variable 'outputEncodingString' could be declared final 149
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 167
LocalVariableCouldBeFinal Local variable 'globalContext' could be declared final 182–183
LocalVariableCouldBeFinal Local variable 'ctx' could be declared final 185
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'ctx' 186
LocalVariableCouldBeFinal Local variable 'ctx' could be declared final 197
ShortVariable Avoid variables with short names like ec 201
LocalVariableCouldBeFinal Local variable 'ec' could be declared final 201
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'info' is not assigned and could be declared final 222
ShortVariable Avoid variables with short names like e 222
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 246
LocalVariableCouldBeFinal Local variable 'data' could be declared final 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 253
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 253
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 271–272
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 289
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 289
CloseResource Ensure that resources like this OutputStreamWriter object are closed after use 293
UnusedAssignment The initializer for variable 'writer' is never used (overwritten on line 298) 293
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 294
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 304
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 325
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 325
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 326
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 329
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 335
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 354
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 354
MethodArgumentCouldBeFinal Parameter 'writer' is not assigned and could be declared final 354
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 361
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 374
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 394
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 394
MethodArgumentCouldBeFinal Parameter 'writer' is not assigned and could be declared final 395
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 396
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 405
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 414
LocalVariableCouldBeFinal Local variable 'data' could be declared final 418
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 433
LocalVariableCouldBeFinal Local variable 'data' could be declared final 437
ConfusingTernary Avoid if (x != y) ..; else ..; 443
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 455
ShortVariable Avoid variables with short names like e 455
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 455
UnnecessaryModifier Unnecessary modifier 'final' on method 'renderingError': private methods cannot be overridden 455–461
LocalVariableCouldBeFinal Local variable 'err' could be declared final 458
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 471
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 474
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 476
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 479
LocalVariableCouldBeFinal Local variable 'velocity' could be declared final 481
CyclomaticComplexity The method 'setVelocityProperties(VelocityEngine, Configuration)' has a cyclomatic complexity of 12. 500–585
ModifiedCyclomaticComplexity The method 'setVelocityProperties' has a Modified Cyclomatic Complexity of 12. 500–585
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 500
MethodArgumentCouldBeFinal Parameter 'velocity' is not assigned and could be declared final 500
StdCyclomaticComplexity The method 'setVelocityProperties' has a Standard Cyclomatic Complexity of 12. 500–585
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 501
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 507–584
LocalVariableCouldBeFinal Local variable 'i' could be declared final 507
LocalVariableCouldBeFinal Local variable 'key' could be declared final 509
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 510
LocalVariableCouldBeFinal Local variable 'value' could be declared final 512
LocalVariableCouldBeFinal Local variable 'name2' could be declared final 515
LocalVariableCouldBeFinal Local variable 'paths' could be declared final 528
LocalVariableCouldBeFinal Local variable 'p' could be declared final 543
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 548
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 551
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 551
LocalVariableCouldBeFinal Local variable 'jarSepIndex' could be declared final 554
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 554
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 558
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 560
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 560
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 565
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 568
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 573
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 596
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 608

org/apache/turbine/services/velocity/VelocityService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like VELOCITY_EXTENSION 52
LongVariable Avoid excessively long variable names like CATCH_ERRORS_DEFAULT 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 76

org/apache/turbine/util/BrowserDetector.java

Rule Violation Line
DataClass The class 'BrowserDetector' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=4, WMC=9) 41–172
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 78
LocalVariableCouldBeFinal Local variable 'userAgent' could be declared final 81
LocalVariableCouldBeFinal Local variable 'version' could be declared final 85
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 97
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 157
UnnecessaryModifier Unnecessary modifier 'final' on method 'toFloat': private methods cannot be overridden 168–171
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 168
ShortVariable Avoid variables with short names like s 168

org/apache/turbine/util/FormMessage.java

Rule Violation Line
DataClass The class 'FormMessage' is suspected to be a Data Class (WOC=18.182%, NOPA=0, NOAM=5, WMC=12) 33–161
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 52
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 80
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 113
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 131
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 141
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 153
ShortVariable Avoid variables with short names like sb 153
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 154

org/apache/turbine/util/FormMessages.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 36
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 36
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 38
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 38
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 40
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 40
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 42
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'returnCode' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'messageName' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 74
LocalVariableCouldBeFinal Local variable 'formFieldName' could be declared final 76
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 90
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 90
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 90
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 90
ConfusingTernary Avoid if (x != y) ..; else ..; 94–107
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 117
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 117
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 117
UnnecessaryModifier Unnecessary modifier 'final' on method 'getValues': private methods cannot be overridden 117–120
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 117
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 128
LocalVariableCouldBeFinal Local variable 'field' could be declared final 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 151
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 163
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 163
LocalVariableCouldBeFinal Local variable 'key' could be declared final 165
LocalVariableCouldBeFinal Local variable 'messages' could be declared final 167
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 179
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 191
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 191
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 193
LocalVariableCouldBeFinal Local variable 'field' could be declared final 194
StringToString Avoid calling toString() on String objects; this is unnecessary. 196
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 198

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 40–159
RedundantFieldInitializer Avoid using redundant field initializer for 'session_count' 50
RedundantFieldInitializer Avoid using redundant field initializer for 'lastTimeVal' 51
UseUnderscoresInNumericLiterals Number 2176782336L should separate every third digit with an underscore 61
UseUnderscoresInNumericLiterals Number 46656 should separate every third digit with an underscore 69
LongVariable Avoid excessively long variable names like maxSessionLifespanTics 69
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 85–130
LocalVariableCouldBeFinal Local variable 'sessionId' could be declared final 87
ShortVariable Avoid variables with short names like n 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100–101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111–112
MethodArgumentCouldBeFinal Parameter 'jsIdent' is not assigned and could be declared final 138
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 138–145
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 142
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 152

org/apache/turbine/util/HttpUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 40–85
MethodArgumentCouldBeFinal Parameter 'date' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 70
MethodArgumentCouldBeFinal Parameter 'expiry' is not assigned and could be declared final 70
LocalVariableCouldBeFinal Local variable 'response' could be declared final 72

org/apache/turbine/util/InputFilterUtils.java

Rule Violation Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 35–68
AbstractNaming Abstract classes should be named AbstractXXX 35–68
ShortVariable Avoid variables with short names like s 45
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 45
ShortVariable Avoid variables with short names like s 58
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 58

org/apache/turbine/util/LocaleUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 62–248
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultLocale' 67
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultCharSet' 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80–82
LocalVariableCouldBeFinal Local variable 'inputEncoding' could be declared final 80–82
NonThreadSafeSingleton Singleton is not thread safe 100–113
LocalVariableCouldBeFinal Local variable 'lang' could be declared final 103–105
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103–105
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107–109
LocalVariableCouldBeFinal Local variable 'country' could be declared final 107–109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 127
NonThreadSafeSingleton Singleton is not thread safe 138–150
LocalVariableCouldBeFinal Local variable 'charSet' could be declared final 141–143
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 141–143
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 161
LocalVariableCouldBeFinal Local variable 'serviceManager' could be declared final 164
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 165
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 165–178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 169
LocalVariableCouldBeFinal Local variable 'mimeTypeService' could be declared final 169
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 170
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 172
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 202–203
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 215–216
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 215–216
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 220
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 234
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 238

org/apache/turbine/util/ObjectUtils.java

Rule Violation Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 36–102
AbstractNaming Abstract classes should be named AbstractXXX 36–102
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 48
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 50
UnusedAssignment The initializer for variable 'byteArray' is never used (overwritten on line 66) 50
LocalVariableCouldBeFinal Local variable 'value' could be declared final 52
MethodArgumentCouldBeFinal Parameter 'objectData' is not assigned and could be declared final 81
ShortVariable Avoid variables with short names like in 88
EmptyCatchBlock Avoid empty catch blocks 94–97
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 94

org/apache/turbine/util/RunData.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1–637
ShortVariable Avoid variables with short names like ct 464
ShortVariable Avoid variables with short names like sc 494

org/apache/turbine/util/SecurityCheck.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
RedundantFieldInitializer Avoid using redundant field initializer for 'securityService' 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 72
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'initialize' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 109
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 110
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 115
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 136
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 136
UnusedAssignment The initializer for variable 'roleObject' is never used (overwritten on lines 142 and 148) 138
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 142
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 149
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 150
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 150
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 172
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 173
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 176
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 178
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 204
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 205
UnusedAssignment The initializer for variable 'permissionObject' is never used (overwritten on lines 210 and 216) 207
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 210
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 217
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 220
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 221
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 222
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 233
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 234
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 246
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 247

org/apache/turbine/util/ServerData.java

Rule Violation Line
DataClass The class 'ServerData' is suspected to be a Data Class (WOC=18.750%, NOPA=0, NOAM=10, WMC=22) 42–279
RedundantFieldInitializer Avoid using redundant field initializer for 'serverName' 45
RedundantFieldInitializer Avoid using redundant field initializer for 'serverPort' 48
RedundantFieldInitializer Avoid using redundant field initializer for 'serverScheme' 51
RedundantFieldInitializer Avoid using redundant field initializer for 'scriptName' 54
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPath' 57
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 72
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 98
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 115
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 130–134
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 130–134
CloneMethodMustImplementCloneable clone() method should be implemented only if implementing Cloneable interface 130–134
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 151
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 172
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 193
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 214
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 235
LinguisticNaming Linguistics Antipattern - The getter 'getHostUrl' should not return void linguistically 246–261
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 246
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 248
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 251
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 254
LocalVariableCouldBeFinal Local variable 'url' could be declared final 271
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 275

org/apache/turbine/util/ServletUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 42–103
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 53
CyclomaticComplexity The method 'expandRelative(ServletConfig, String)' has a cyclomatic complexity of 10. 53–102
MethodArgumentCouldBeFinal Parameter 'text' is not assigned and could be declared final 54
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 58
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 63
AvoidFinalLocalVariable Avoid using final local variables, turn them into fields 66
ConfusingTernary Avoid if (x != y) ..; else ..; 69–80
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 69
ShortVariable Avoid variables with short names like sb 72
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 72
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 73
LocalVariableCouldBeFinal Local variable 'context' could be declared final 82
LocalVariableCouldBeFinal Local variable 'base' could be declared final 83–84
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 83
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 88
LocalVariableCouldBeFinal Local variable 'tokenizer' could be declared final 91
LocalVariableCouldBeFinal Local variable 'buffer' could be declared final 92

org/apache/turbine/util/SystemError.java

Rule Violation Line
DoNotExtendJavaLangError Exceptions should not extend java.lang.Error 33
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 64

org/apache/turbine/util/TurbineConfig.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1–940
ExcessivePublicCount This class has a bunch of public methods and attributes 1–940
CyclomaticComplexity The class 'TurbineConfig' has a total cyclomatic complexity of 108 (highest 4). 96–940
TooManyMethods This class has too many methods, consider refactoring it. 98–940
LongVariable Avoid excessively long variable names like CONFIGURATION_PATH_KEY 107
LongVariable Avoid excessively long variable names like PROPERTIES_PATH_KEY 113
LongVariable Avoid excessively long variable names like PROPERTIES_PATH_DEFAULT 119
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 123
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 126
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 132
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 135
AvoidFieldNameMatchingMethodName Field log has the same name as a method 135
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 151
MethodArgumentCouldBeFinal Parameter 'attributes' is not assigned and could be declared final 151
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 152
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 172
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 172
MethodArgumentCouldBeFinal Parameter 'properties' is not assigned and could be declared final 188
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 188
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 206
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 216
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 267
LocalVariableCouldBeFinal Local variable 'f' could be declared final 270
ShortVariable Avoid variables with short names like f 270
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 297
UseArrayListInsteadOfVector Use ArrayList instead of Vector 310
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 362
ShortVariable Avoid variables with short names like s 362
ShortVariable Avoid variables with short names like s 376
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 376
LocalVariableCouldBeFinal Local variable 'fis' could be declared final 380
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 381
ShortVariable Avoid variables with short names like m 398
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 398
ShortVariable Avoid variables with short names like e 398
MethodArgumentCouldBeFinal Parameter 'm' is not assigned and could be declared final 398
MethodArgumentCouldBeFinal Parameter 'm' is not assigned and could be declared final 409
ShortVariable Avoid variables with short names like m 409
ShortVariable Avoid variables with short names like m 421
MethodArgumentCouldBeFinal Parameter 'm' is not assigned and could be declared final 421
ShortVariable Avoid variables with short names like t 421
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 421
ShortVariable Avoid variables with short names like s 431
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 431
UseArrayListInsteadOfVector Use ArrayList instead of Vector 443
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 456
ShortVariable Avoid variables with short names like s 456
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 482
ShortVariable Avoid variables with short names like s 482
ShortVariable Avoid variables with short names like s 508
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 508
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 521
ShortVariable Avoid variables with short names like s 521
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 533
ShortVariable Avoid variables with short names like s 533
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 559
ShortVariable Avoid variables with short names like s 559
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 599
ShortVariable Avoid variables with short names like s 599
ShortVariable Avoid variables with short names like o 611
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 611
ShortVariable Avoid variables with short names like s 611
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 611
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 647
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 647
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 659
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 659
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 671
MethodArgumentCouldBeFinal Parameter 'servlet' is not assigned and could be declared final 671
MethodArgumentCouldBeFinal Parameter 'servletClass' is not assigned and could be declared final 683
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 683
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 695
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 707
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 731
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 731
MethodArgumentCouldBeFinal Parameter 'filter' is not assigned and could be declared final 743
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 743
MethodArgumentCouldBeFinal Parameter 'filterClass' is not assigned and could be declared final 755
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 755
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 767
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 779
LongVariable Avoid excessively long variable names like sessionTrackingModes 815
MethodArgumentCouldBeFinal Parameter 'sessionTrackingModes' is not assigned and could be declared final 815
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 851
ShortVariable Avoid variables with short names like t 863
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 863
MethodArgumentCouldBeFinal Parameter 'listenerClass' is not assigned and could be declared final 875
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 887
MethodArgumentCouldBeFinal Parameter 'roleNames' is not assigned and could be declared final 923

org/apache/turbine/util/TurbineException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 112
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 124
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 137
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 137

org/apache/turbine/util/TurbineRuntimeException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 80

org/apache/turbine/util/TurbineXmlConfig.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'attributes' is not assigned and could be declared final 76
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 76
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 77
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 95
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 95
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 109
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 109

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 105–690
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 128
RedundantFieldInitializer Avoid using redundant field initializer for 'doctype' 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 131
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeRootElement 131
ImmutableField Private field 'defaultHtmlDoctypeRootElement' could be made final; it is only initialized in the declaration or constructor. 131
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 134
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeIdentifier 134
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeUri 137
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 137
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 154
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 156
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 183
LinguisticNaming Linguistics Antipattern - The setter 'setTitle' should not return any type except void linguistically 183–187
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 200
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 212
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 212
MethodArgumentCouldBeFinal Parameter 'scriptURL' is not assigned and could be declared final 234
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 257
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 272–273
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 272
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 273
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 273
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 273
ShortVariable Avoid variables with short names like ss 275
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 275
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 290
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 290
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 317
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 317–318
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 317
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 317
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 318
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 320
ShortVariable Avoid variables with short names like ss 320
MethodArgumentCouldBeFinal Parameter 'styleText' is not assigned and could be declared final 343
LinguisticNaming Linguistics Antipattern - The setter 'setKeywords' should not return any type except void linguistically 365–369
MethodArgumentCouldBeFinal Parameter 'keywords' is not assigned and could be declared final 365
LinguisticNaming Linguistics Antipattern - The setter 'setHttpEquiv' should not return any type except void linguistically 380–384
MethodArgumentCouldBeFinal Parameter 'httpEquiv' is not assigned and could be declared final 380
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 380
MethodArgumentCouldBeFinal Parameter 'description' is not assigned and could be declared final 392
LinguisticNaming Linguistics Antipattern - The setter 'setDescription' should not return any type except void linguistically 392–396
LinguisticNaming Linguistics Antipattern - The setter 'setBackground' should not return any type except void linguistically 404–408
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 404
LinguisticNaming Linguistics Antipattern - The setter 'setBgColor' should not return any type except void linguistically 418–422
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 418
LinguisticNaming Linguistics Antipattern - The setter 'setTextColor' should not return any type except void linguistically 431–435
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 431
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 444
LinguisticNaming Linguistics Antipattern - The setter 'setLinkColor' should not return any type except void linguistically 444–448
LinguisticNaming Linguistics Antipattern - The setter 'setVlinkColor' should not return any type except void linguistically 456–460
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 456
LinguisticNaming Linguistics Antipattern - The setter 'setAlinkColor' should not return any type except void linguistically 468–472
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 468
DataClass The class 'LinkTag' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=9, WMC=15) 508–626
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 523
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 523
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 544
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 562
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 582
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 602
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 622
LocalVariableCouldBeFinal Local variable 'tag' could be declared final 643
MethodArgumentCouldBeFinal Parameter 'tag' is not assigned and could be declared final 666
MethodArgumentCouldBeFinal Parameter 'identifier' is not assigned and could be declared final 666
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 666
LocalVariableCouldBeFinal Local variable 'doctypeBuf' could be declared final 668

org/apache/turbine/util/template/TemplateInfo.java

Rule Violation Line
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE 47
ImmutableField Private field 'data' could be made final; it is only initialized in the declaration or constructor. 54
UnusedAssignment The field initializer for 'data' is never used (overwritten on line 66) 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
ImmutableField Private field 'tempStorage' could be made final; it is only initialized in the declaration or constructor. 57
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 67) 57
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 64
ShortVariable Avoid variables with short names like v 85
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98
ShortVariable Avoid variables with short names like v 107
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 117
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 120
EmptyCatchBlock Avoid empty catch blocks 120–125
LocalVariableCouldBeFinal Local variable 'value' could be declared final 135
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'value' 136
ShortVariable Avoid variables with short names like v 144
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 156
ShortVariable Avoid variables with short names like v 167
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 167
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 167
ShortVariable Avoid variables with short names like v 187
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 187
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 198
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 210
LocalVariableCouldBeFinal Local variable 'val' could be declared final 214
ConfusingTernary Avoid if (x != y) ..; else ..; 215
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 215
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 217
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 240
LocalVariableCouldBeFinal Local variable 'object' could be declared final 243
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 257
LocalVariableCouldBeFinal Local variable 'object' could be declared final 260
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 275
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 287

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 62
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 74–79
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101–102
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 101–102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 113

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 77
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 77–81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 95
LocalVariableCouldBeFinal Local variable 'results' could be declared final 95
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 102

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Line
DataClass The class 'TemplateSecurityCheck' is suspected to be a Data Class (WOC=27.273%, NOPA=0, NOAM=6, WMC=18) 52–228
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 79
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 82–83
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 94
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 99
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 106
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 108
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 121
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 122
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 125
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 126
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 129
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 144
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 149–152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 150–152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 157–158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 160
ShortVariable Avoid variables with short names like v 173
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 204
ShortVariable Avoid variables with short names like v 204
ShortVariable Avoid variables with short names like v 224
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 224

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 46–520
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
RedundantFieldInitializer Avoid using redundant field initializer for 'redirect' 58
RedundantFieldInitializer Avoid using redundant field initializer for 'response' 61
RedundantFieldInitializer Avoid using redundant field initializer for 'reference' 64
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 114
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 126
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 126
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 148
ConfusingTernary Avoid if (x != y) ..; else ..; 152–163
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 164
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 181
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 213
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 234
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 272
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 289
MethodArgumentCouldBeFinal Parameter 'port' is not assigned and could be declared final 311
LocalVariableCouldBeFinal Local variable 'useSSL' could be declared final 313–316
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 314–316
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 327
LocalVariableCouldBeFinal Local variable 'serverScheme' could be declared final 342
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 352
MethodArgumentCouldBeFinal Parameter 'response' is not assigned and could be declared final 393
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 421
ShortVariable Avoid variables with short names like sb 421
LinguisticNaming Linguistics Antipattern - The getter 'getContextAndScript' should not return void linguistically 421–445
LocalVariableCouldBeFinal Local variable 'context' could be declared final 423
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 427
LocalVariableCouldBeFinal Local variable 'script' could be declared final 435
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 439
ShortVariable Avoid variables with short names like sb 459
LinguisticNaming Linguistics Antipattern - The getter 'getSchemeAndPort' should not return void linguistically 459–475
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 459
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 462
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 463
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 467
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 469
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 486
LocalVariableCouldBeFinal Local variable 'response' could be declared final 490
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 510

org/apache/turbine/util/uri/DataURI.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 89
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 89
LocalVariableCouldBeFinal Local variable 'output' could be declared final 126
LocalVariableCouldBeFinal Local variable 'output' could be declared final 164

org/apache/turbine/util/uri/TemplateURI.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 38
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 100
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 100
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 100
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 100
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 111
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 133
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 133
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 146
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 146
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 146
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 159
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 159
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 159
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 185
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 185
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 201
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 245
ShortVariable Avoid variables with short names like pp 246
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 246
LocalVariableCouldBeFinal Local variable 'name' could be declared final 248
LocalVariableCouldBeFinal Local variable 'key' could be declared final 250
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 252
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 253
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 254
LocalVariableCouldBeFinal Local variable 'values' could be declared final 256
ConfusingTernary Avoid if (x != y) ..; else ..; 257–267
LocalVariableCouldBeFinal Local variable 'value' could be declared final 259

org/apache/turbine/util/uri/TurbineURI.java

Rule Violation Line
GodClass Possible God Class (WMC=74, ATFD=16, TCC=9.725%) 55–916
TooManyMethods This class has too many methods, consider refactoring it. 57–916
RedundantFieldInitializer Avoid using redundant field initializer for 'dataVectors' 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 93
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 105
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 105
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 117
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 117
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 130
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 130
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 130
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 143
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 143
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 143
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 157
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 157
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 157
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 157
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 168
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 180
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 180
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 192
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 192
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 218
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 218
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 218
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 232
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 232
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 232
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 233
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 245
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 245
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 270
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 291
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 309
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 325
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 325
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 351
ShortVariable Avoid variables with short names like pp 386
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 386
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 397
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 408
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 408
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 419
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 419
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 430
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 430
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 441
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 441
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 452
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 452
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 463
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 463
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 474
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 474
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 485
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 485
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 496
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 496
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 507
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 507
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 518
ShortVariable Avoid variables with short names like pp 518
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 528
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 556
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 584
LocalVariableCouldBeFinal Local variable 'output' could be declared final 622
LocalVariableCouldBeFinal Local variable 'output' could be declared final 655
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 670
MethodArgumentCouldBeFinal Parameter 'pathInfo' is not assigned and could be declared final 712
MethodArgumentCouldBeFinal Parameter 'queryData' is not assigned and could be declared final 736
LinguisticNaming Linguistics Antipattern - The getter 'getPathInfoAsString' should not return void linguistically 768–771
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 768
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 778
LinguisticNaming Linguistics Antipattern - The getter 'getQueryDataAsString' should not return void linguistically 778–781
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 789
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 794
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 812
MethodArgumentCouldBeFinal Parameter 'valueDelim' is not assigned and could be declared final 812
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 812
MethodArgumentCouldBeFinal Parameter 'fieldDelim' is not assigned and could be declared final 812
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 816–822
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 816–822
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 837
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 838
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 839
LocalVariableCouldBeFinal Local variable 'uriParam' could be declared final 841
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 858
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 859
ShortVariable Avoid variables with short names like pp 859
LocalVariableCouldBeFinal Local variable 'key' could be declared final 861
LocalVariableCouldBeFinal Local variable 'values' could be declared final 866
ConfusingTernary Avoid if (x != y) ..; else ..; 867–877
LocalVariableCouldBeFinal Local variable 'value' could be declared final 869
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 895
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 895
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 910
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 910
LocalVariableCouldBeFinal Local variable 'key' could be declared final 912

org/apache/turbine/util/uri/URIConstants.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 36
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 39
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 42
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 45
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 54
LongVariable Avoid excessively long variable names like URI_SCHEME_SEPARATOR 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 63
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 66
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 69
LongVariable Avoid excessively long variable names like CGI_TEMPLATE_PARAM 69
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 72

org/apache/turbine/util/uri/URIParam.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 37
ImmutableField Private field 'key' could be made final; it is only initialized in the declaration or constructor. 37
UnusedAssignment The field initializer for 'key' is never used (overwritten on line 51) 37
RedundantFieldInitializer Avoid using redundant field initializer for 'key' 37
UnusedAssignment The field initializer for 'value' is never used (overwritten on line 52) 40
RedundantFieldInitializer Avoid using redundant field initializer for 'value' 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 40
ImmutableField Private field 'value' could be made final; it is only initialized in the declaration or constructor. 40
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 90
IfStmtsMustUseBraces Avoid using if statements without curly braces 92–93
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 93
ControlStatementBraces This statement should have braces 93
IfStmtsMustUseBraces Avoid using if statements without curly braces 94–95
ControlStatementBraces This statement should have braces 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 95
IfStmtsMustUseBraces Avoid using if statements without curly braces 96–97
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 97
ControlStatementBraces This statement should have braces 97
LocalVariableCouldBeFinal Local variable 'other' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101

org/apache/turbine/util/uri/URIUtils.java

Rule Violation Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 34–53
AbstractNaming Abstract classes should be named AbstractXXX 34–53
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 47
ShortVariable Avoid variables with short names like du 49
LocalVariableCouldBeFinal Local variable 'du' could be declared final 49

org/apache/turbine/util/velocity/VelocityActionEvent.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 51–90
AbstractNaming Abstract classes should be named AbstractXXX 51–90
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
RedundantFieldInitializer Avoid using redundant field initializer for 'initialized' 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 66
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 77
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 85
ShortVariable Avoid variables with short names like pp 85
LocalVariableCouldBeFinal Local variable 'context' could be declared final 86

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'wordWrap' 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 110
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 116
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 119
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 133
LinguisticNaming Linguistics Antipattern - The setter 'setTo' should not return any type except void linguistically 149–154
MethodArgumentCouldBeFinal Parameter 'toName' is not assigned and could be declared final 149
MethodArgumentCouldBeFinal Parameter 'toEmail' is not assigned and could be declared final 149
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 164
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 164–168
LinguisticNaming Linguistics Antipattern - The setter 'setWordWrap' should not return any type except void linguistically 181–185
MethodArgumentCouldBeFinal Parameter 'wordWrap' is not assigned and could be declared final 181
LinguisticNaming Linguistics Antipattern - The setter 'setContext' should not return any type except void linguistically 194–198
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 234–236
UnusedAssignment The initializer for variable 'body' is never used (overwritten on line 256) 251
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 255
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 258

org/apache/turbine/util/velocity/VelocityEmailException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 78

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 94
RedundantFieldInitializer Avoid using redundant field initializer for 'htmlTemplate' 94
RedundantFieldInitializer Avoid using redundant field initializer for 'textTemplate' 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 103
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 103
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 106
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 106
RedundantFieldInitializer Avoid using redundant field initializer for 'embmap' 106
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 106
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 124
LinguisticNaming Linguistics Antipattern - The setter 'setHtmlTemplate' should not return any type except void linguistically 139–143
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 139
LinguisticNaming Linguistics Antipattern - The setter 'setTextTemplate' should not return any type except void linguistically 153–157
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 153
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 182–184
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 199
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 199
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 207
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 243
MethodArgumentCouldBeFinal Parameter 'surl' is not assigned and could be declared final 243
LocalVariableCouldBeFinal Local variable 'url' could be declared final 248
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 266
LocalVariableCouldBeFinal Local variable 'cid' could be declared final 268

Priority 4

org/apache/turbine/modules/ActionEvent.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 210
UselessParentheses Useless parentheses. 302

org/apache/turbine/modules/Page.java

Rule Violation Line
ShortClassName Avoid short class names like Page 33–68

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 541

org/apache/turbine/om/security/User.java

Rule Violation Line
ShortClassName Avoid short class names like User 41–289

org/apache/turbine/pipeline/TurbinePipeline.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 138

org/apache/turbine/services/BaseServiceBroker.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 209
UselessParentheses Useless parentheses. 262
UselessParentheses Useless parentheses. 263
UselessParentheses Useless parentheses. 317

org/apache/turbine/services/Initable.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 96

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
UselessParentheses Useless parentheses. 227
UselessParentheses Useless parentheses. 287

org/apache/turbine/services/rundata/DefaultTurbineRunData.java

Rule Violation Line
UselessParentheses Useless parentheses. 728
UselessParentheses Useless parentheses. 986
AvoidPrefixingMethodParameters Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 1318

org/apache/turbine/services/rundata/TurbineRunDataService.java

Rule Violation Line
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 119

org/apache/turbine/services/template/TemplateService.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 285
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 299

org/apache/turbine/services/template/mapper/BaseMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 173

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 122
UselessParentheses Useless parentheses. 142

org/apache/turbine/services/template/mapper/DirectMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 66

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 123

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 118

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 79

org/apache/turbine/services/urlmapper/TurbineURLMapperService.java

Rule Violation Line
UselessParentheses Useless parentheses. 187

org/apache/turbine/services/velocity/TurbineVelocityService.java

Rule Violation Line
UselessParentheses Useless parentheses. 419
UselessParentheses Useless parentheses. 419
UselessParentheses Useless parentheses. 438
UselessParentheses Useless parentheses. 438
UselessParentheses Useless parentheses. 438
UselessParentheses Useless parentheses. 515
UselessParentheses Useless parentheses. 557
UselessParentheses Useless parentheses. 560

org/apache/turbine/services/velocity/VelocityService.java

Rule Violation Line
AvoidPrefixingMethodParameters Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 89

org/apache/turbine/util/FormMessages.java

Rule Violation Line
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 130
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 131

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Random' due to existing import 'java.util.Random' 52
UselessParentheses Useless parentheses. 103

org/apache/turbine/util/SecurityCheck.java

Rule Violation Line
UselessParentheses Useless parentheses. 158
UselessParentheses Useless parentheses. 252

org/apache/turbine/util/ServerData.java

Rule Violation Line
UselessParentheses Useless parentheses. 251–252
UselessParentheses Useless parentheses. 254–255

org/apache/turbine/util/TurbineConfig.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 731
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 743
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 755

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 536
UselessParentheses Useless parentheses. 574
UselessParentheses Useless parentheses. 594
UselessParentheses Useless parentheses. 614

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
UselessParentheses Useless parentheses. 467–468
UselessParentheses Useless parentheses. 469–470

org/apache/turbine/util/uri/URI.java

Rule Violation Line
ShortClassName Avoid short class names like URI 32–76

org/apache/turbine/util/uri/URIParam.java

Rule Violation Line
UselessParentheses Useless parentheses. 63

Priority 5

org/apache/turbine/Turbine.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'descriptorPath' (lines '349'-'362'). 349–362
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'confStyle' (lines '384'-'400'). 384–400
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'confStyle' (lines '384'-'391'). 384–391
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'params' (lines '417'-'483'). 417–483
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confPath' (lines '437'-'483'). 437–483
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confFile' (lines '443'-'483'). 443–483
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'path' (lines '503'-'510'). 503–510
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'usingNamespace' (lines '507'-'534'). 507–534
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'parameterName' (lines '524'-'534'). 524–534
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'usingNamespace' (lines '525'-'534'). 525–534
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'log4jTarget' (lines '974'-'996'). 974–996
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'log4jTarget' (lines '974'-'986'). 974–986

org/apache/turbine/annotation/AnnotationProcessor.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'config' (lines '231'-'275'). 231–275
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '232'-'275'). 232–275
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '444'-'472'). 444–472
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '444'-'448'). 444–448
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '444'-'460'). 444–460

org/apache/turbine/modules/ActionEvent.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'theButton' (lines '214'-'227'). 214–227
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'button' (lines '216'-'283'). 216–283
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '217'-'222'). 217–222
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '217'-'236'). 217–236
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'method' (lines '240'-'244'). 240–244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'method' (lines '244'-'248'). 244–248
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tmp' (lines '295'-'299'). 295–299

org/apache/turbine/modules/GenericLoader.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'194'). 179–194
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'186'). 179–186
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '186'-'194'). 186–194

org/apache/turbine/modules/actions/InitContextsAction.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '63'-'96'). 63–96
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'85'). 78–85
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'81'). 78–81

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'password' (lines '90'-'155'). 90–155

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'ret' (lines '123'-'142'). 123–142

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '105'-'117'). 105–117

org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '60'-'69'). 60–69

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'out' (lines '109'-'114'). 109–114

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '54'-'83'). 54–83

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '55'-'88'). 55–88

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'147'). 108–147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'135'). 108–135
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'screenData' (lines '108'-'151'). 108–151
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '110'-'151'). 110–151
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '135'-'147'). 135–147

org/apache/turbine/om/OMTool.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'110'). 105–110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'114'). 105–114

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '590'-'595'). 590–595

org/apache/turbine/pipeline/DefaultLoginValve.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'session' (lines '129'-'148'). 129–148

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'initable' (lines '236'-'282'). 236–282

org/apache/turbine/services/BaseServiceBroker.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'earlyInitFlags' (lines '249'-'305'). 249–305
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '494'-'507'). 494–507
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceName' (lines '494'-'517'). 494–517
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '494'-'513'). 494–513
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'service' (lines '636'-'680'). 636–680
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'turbineServiceProvider' (lines '739'-'752'). 739–752
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'turbineServiceProvider' (lines '739'-'743'). 739–743
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'turbineServiceProvider' (lines '764'-'779'). 764–779
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'turbineServiceProvider' (lines '764'-'768'). 764–768

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '215'-'219'). 215–219
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '233'-'260'). 233–260
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'loader' (lines '275'-'279'). 275–279

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '67'-'94'). 67–94

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '84'-'156'). 84–156
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confName' (lines '86'-'156'). 86–156

org/apache/turbine/services/intake/IntakeTool.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupCount' (lines '99'-'102'). 99–102
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '116'-'119'). 116–119
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '116'-'123'). 116–123
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '123'-'126'). 123–126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '126'-'126'). 126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '300'-'305'). 300–305
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '300'-'309'). 300–309
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '325'-'337'). 325–337
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '325'-'333'). 325–333

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_req' (lines '54'-'58'). 54–58
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '55'-'75'). 55–75
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '75'-'80'). 75–80
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 83
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 83

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '145'-'193'). 145–193
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'relativeTemplate' (lines '281'-'294'). 281–294

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '72'-'76'). 72–76

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'template' (lines '77'-'81'). 77–81
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '78'-'83'). 78–83

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'102'). 98–102
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'106'). 98–106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'154'). 150–154
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'158'). 150–158

org/apache/turbine/services/pull/TurbinePullService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'data' (lines '812'-'817'). 812–817
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '812'-'831'). 812–831
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'pipelineData' (lines '813'-'831'). 813–831
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pipelineData' (lines '813'-'816'). 813–816
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '817'-'831'). 817–831

org/apache/turbine/services/pull/util/DateFormatter.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'110'). 105–110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'115'). 105–115
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'sdf' (lines '106'-'118'). 106–118

org/apache/turbine/services/rundata/TurbineRunDataService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'plist' (lines '121'-'168'). 121–168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '130'-'130'). 130
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '130'-'168'). 130–168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '131'-'131'). 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '131'-'146'). 131–146
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'j' (lines '131'-'168'). 131–168
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'config' (lines '143'-'168'). 143–168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '146'-'131'). 146–131
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'j' (lines '146'-'168'). 146–168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '146'-'146'). 146

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'schedrun' (lines '210'-'292'). 210–292
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'now' (lines '211'-'292'). 211–292

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '339'-'347'). 339–347
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '347'-'347'). 347

org/apache/turbine/services/schedule/JobQueue.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'index' (lines '78'-'82'). 78–82
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'aComparator' (lines '184'-'191'). 184–191

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'je' (lines '99'-'103'). 99–103

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'jobs' (lines '78'-'116'). 78–116

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '158'-'166'). 158–166
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '184'-'192'). 184–192
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '207'-'214'). 207–214
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '232'-'239'). 232–239
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '254'-'261'). 254–261
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '278'-'285'). 278–285
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '300'-'307'). 300–307
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '325'-'332'). 325–332

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'url' (lines '102'-'106'). 102–106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '140'-'141'). 140–141

org/apache/turbine/services/template/BaseTemplateEngineService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fileExtensionAssociations' (lines '111'-'112'). 111–112

org/apache/turbine/services/template/TurbineTemplateService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperNames' (lines '724'-'820'). 724–820
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperClasses' (lines '734'-'820'). 734–820
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'ab' (lines '744'-'820'). 744–820
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperCacheSize' (lines '747'-'753'). 747–753
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperCacheSize' (lines '747'-'820'). 747–820
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '748'-'757'). 748–757
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '748'-'752'). 748–752
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperCacheSize' (lines '753'-'820'). 753–820
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperCacheSize' (lines '753'-'753'). 753
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '757'-'758'). 757–758
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '758'-'759'). 758–759
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperLoader' (lines '759'-'820'). 759–820
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperDefaultProperty' (lines '761'-'820'). 761–820
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperSeparator' (lines '771'-'820'). 771–820
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperPrefix' (lines '773'-'820'). 773–820
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tm' (lines '791'-'796'). 791–796
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'tm' (lines '796'-'820'). 796–820

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '127'-'178'). 127–178

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '107'-'166'). 107–166
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '146'-'166'). 146–166

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '102'-'155'). 102–155
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '141'-'155'). 141–155

org/apache/turbine/services/ui/TurbineUIService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'defaultSkinProperties' (lines '282'-'286'). 282–286

org/apache/turbine/services/urlmapper/TurbineURLMapperService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'uriParameterMap' (lines '143'-'209'). 143–209
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'servletService' (lines '271'-'314'). 271–314

org/apache/turbine/services/velocity/TurbineVelocityService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'results' (lines '292'-'302'). 292–302
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'writer' (lines '293'-'298'). 293–298
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '329'-'339'). 329–339
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'charset' (lines '416'-'421'). 416–421
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'encoding' (lines '435'-'440'). 435–440

org/apache/turbine/util/FormMessages.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '135'-'138'). 135–138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '172'-'175'). 172–175

org/apache/turbine/util/LocaleUtils.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '170'-'190'). 170–190

org/apache/turbine/util/ObjectUtils.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'byteArray' (lines '50'-'70'). 50–70
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'byteArray' (lines '50'-'66'). 50–66
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'object' (lines '83'-'92'). 83–92

org/apache/turbine/util/SecurityCheck.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '112'-'122'). 112–122
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '138'-'142'). 138–142
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleObject' (lines '142'-'163'). 142–163
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '142'-'148'). 142–148
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'modelManager' (lines '150'-'163'). 150–163
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '175'-'185'). 175–185
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '207'-'210'). 207–210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permissionObject' (lines '210'-'257'). 210–257
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '210'-'216'). 210–216
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'role' (lines '219'-'224'). 219–224

org/apache/turbine/util/TurbineConfig.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '269'-'280'). 269–280

org/apache/turbine/util/template/TemplateInfo.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '242'-'246'). 242–246
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '259'-'263'). 259–263

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'module' (lines '89'-'124'). 89–124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '89'-'103'). 89–103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'111'). 90–111
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'107'). 90–107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'96'). 90–96

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '91'-'99'). 91–99

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '124'-'131'). 124–131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '146'-'161'). 146–161

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'507'). 488–507
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'503'). 488–503

org/apache/turbine/util/uri/TurbineURI.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '912'-'915'). 912–915

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'body' (lines '251'-'256'). 251–256
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'body' (lines '256'-'274'). 256–274

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'velocityService' (lines '199'-'216'). 199–216
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'cid' (lines '245'-'249'). 245–249

Files

org/apache/turbine/Turbine.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1–1088
StdCyclomaticComplexity The class 'Turbine' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 3 118–1088
CyclomaticComplexity The class 'Turbine' has a total cyclomatic complexity of 84 (highest 12). 3 118–1088
GodClass Possible God Class (WMC=84, ATFD=118, TCC=11.694%) 3 118–1088
AtLeastOneConstructor Each class should declare at least one constructor 3 118–1088
TooManyMethods This class has too many methods, consider refactoring it. 3 119–1088
LongVariable Avoid excessively long variable names like REDIRECTED_PATHINFO_NAME 3 130
RedundantFieldInitializer Avoid using redundant field initializer for 'pipeline' 3 148
RedundantFieldInitializer Avoid using redundant field initializer for 'initFailure' 3 151
RedundantFieldInitializer Avoid using redundant field initializer for 'serverData' 3 161
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 161
RedundantFieldInitializer Avoid using redundant field initializer for 'configuration' 3 179
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 187
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 187
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 212
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 216
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 220
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 220
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 231–237
ExcessiveMethodLength Avoid really long methods. 3 257–362
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 257
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 257
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 258
LocalVariableCouldBeFinal Local variable 'confPath' could be declared final 3 309
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 319
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 329
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 335
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 347
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 347
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'descriptorPath' (lines '349'-'362'). 5 349–362
LocalVariableCouldBeFinal Local variable 'jaxb' could be declared final 3 354
LocalVariableCouldBeFinal Local variable 'unmarshaller' could be declared final 3 355
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 355
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 356
ExcessiveMethodLength Avoid really long methods. 3 381–483
StdCyclomaticComplexity The method 'configureApplication' has a Standard Cyclomatic Complexity of 10. 3 381–483
CyclomaticComplexity The method 'configureApplication(ServletConfig, ServletContext)' has a cyclomatic complexity of 12. 3 381–483
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 381
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 381
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'confStyle' (lines '384'-'400'). 5 384–400
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'confStyle' (lines '384'-'391'). 5 384–391
LocalVariableCouldBeFinal Local variable 'params' could be declared final 3 417
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'params' (lines '417'-'483'). 5 417–483
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 420
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 420
LongVariable Avoid excessively long variable names like confFileRelativePath 3 427
LocalVariableCouldBeFinal Local variable 'confFileRelativePath' could be declared final 3 427
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 429
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 430
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 433
LocalVariableCouldBeFinal Local variable 'targetPathDirectory' could be declared final 3 433
LongVariable Avoid excessively long variable names like targetPathDirectory 3 433
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 437
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confPath' (lines '437'-'483'). 5 437–483
LocalVariableCouldBeFinal Local variable 'targetFilePath' could be declared final 3 439
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 443
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confFile' (lines '443'-'483'). 5 443–483
LocalVariableCouldBeFinal Local variable 'combinedBuilder' could be declared final 3 453–457
LocalVariableCouldBeFinal Local variable 'propertiesBuilder' could be declared final 3 462–467
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 500
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 501
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 501
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 501
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'path' (lines '503'-'510'). 5 503–510
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 507
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'usingNamespace' (lines '507'-'534'). 5 507–534
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 3 524
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'parameterName' (lines '524'-'534'). 5 524–534
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'usingNamespace' (lines '525'-'534'). 5 525–534
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 530
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 543
LocalVariableCouldBeFinal Local variable 'services' could be declared final 3 557
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 559
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 559
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 559–575
LocalVariableCouldBeFinal Local variable 'serviceName' could be declared final 3 561
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 562
LocalVariableCouldBeFinal Local variable 'service' could be declared final 3 562
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 601
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 611
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 621
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 632
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 642
NonThreadSafeSingleton Singleton is not thread safe 3 658–677
LocalVariableCouldBeFinal Local variable 'serverName' could be declared final 3 660
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 687
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 708
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 731
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 3 751
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 3 751
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 762
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 767
LocalVariableCouldBeFinal Local variable 'runDataMap' could be declared final 3 767
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 785–788
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 790–793
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 3 809
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 3 809
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 3 841
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 841
ShortVariable Avoid variables with short names like t 3 842
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 842
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 844
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 862–865
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 871–873
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 875
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 876
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 879–882
ShortVariable Avoid variables with short names like t 3 893
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 3 893
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 893
CloseResource Ensure that resources like this PrintWriter object are closed after use 3 899
LocalVariableCouldBeFinal Local variable 'writer' could be declared final 3 899
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 900
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 903
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 918–929
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 918
LocalVariableCouldBeFinal Local variable 'requestServerData' could be declared final 3 927
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 928
MethodArgumentCouldBeFinal Parameter 'logConf' is not assigned and could be declared final 3 940
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 942
CloseResource Ensure that resources like this LoggerContext object are closed after use 3 942
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 944
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 944
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 944
LocalVariableCouldBeFinal Local variable 'log4jFile' could be declared final 3 946
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 950
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 953
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 953
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 953
MethodArgumentCouldBeFinal Parameter 'logConfPath' is not assigned and could be declared final 3 965
CyclomaticComplexity The method 'resolveLog4j2(Path)' has a cyclomatic complexity of 12. 3 965–1003
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 970
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 970
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'log4jTarget' (lines '974'-'996'). 5 974–996
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'log4jTarget' (lines '974'-'986'). 5 974–986
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 975
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 975
LiteralsFirstInComparisons Position literals first in String comparisons 3 975
CollapsibleIfStatements These nested if statements could be combined 3 980–1000
LocalVariableCouldBeFinal Local variable 'log4jFilePath' could be declared final 3 982
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 984
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 984
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 986
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 991
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 991
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 993
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 994
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 994
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 996
MethodArgumentCouldBeFinal Parameter 'val' is not assigned and could be declared final 3 1011
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 1044
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 1046
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 1048
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1086

org/apache/turbine/TurbineConstants.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 51
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE 3 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 53
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 56
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE_DEFAULT 3 56
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 59
LongVariable Avoid excessively long variable names like SCHEDULER_LOG_FACILITY 3 62
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 62
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 65
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 68
LongVariable Avoid excessively long variable names like MAIL_SERVER_DEFAULT 3 68
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 71
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 74
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 77
LongVariable Avoid excessively long variable names like MODULE_CACHE_DEFAULT 3 77
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_KEY 3 80
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 80
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 83
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_DEFAULT 3 83
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 86
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 89
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 92
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_KEY 3 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 98
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_JSP 3 98
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 101
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 104
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 107
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 110
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 113
LongVariable Avoid excessively long variable names like SCREEN_ERROR_DEFAULT 3 113
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 116
LongVariable Avoid excessively long variable names like SCREEN_INVALID_STATE 3 116
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 119
LongVariable Avoid excessively long variable names like TEMPLATE_INVALID_STATE 3 119
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 122
LongVariable Avoid excessively long variable names like ACTION_LOGIN_DEFAULT 3 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 128
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 131
LongVariable Avoid excessively long variable names like ACTION_LOGOUT_DEFAULT 3 131
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_KEY 3 134
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 134
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_DEFAULT 3 137
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 137
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 140
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_KEY 3 140
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 143
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_DEFAULT 3 143
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_KEY 3 146
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 146
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 149
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_DEFAULT 3 149
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP 3 152
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 152
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT 3 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 158
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 161
LongVariable Avoid excessively long variable names like PAGE_DEFAULT_DEFAULT 3 164
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 164
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 167
LongVariable Avoid excessively long variable names like SCREEN_DEFAULT_DEFAULT 3 167
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 170
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 173
LongVariable Avoid excessively long variable names like LOGIN_MESSAGE_NOSCREEN 3 176
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 176
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 179
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_KEY 3 182
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 182
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 185
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_DEFAULT 3 185
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 188
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 191
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 197
LongVariable Avoid excessively long variable names like PP_URL_CASE_FOLDING 3 197
LongVariable Avoid excessively long variable names like DEFAULT_DOCUMENT_TYPE_KEY 3 200
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 200
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_KEY 3 203
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 203
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_DEFAULT 3 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_KEY 3 209
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 209
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 212
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_DEFAULT 3 212
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_KEY 3 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_DEFAULT 3 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 221
LongVariable Avoid excessively long variable names like DEFAULT_HTML_CONTENT_TYPE 3 221
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 222
LongVariable Avoid excessively long variable names like DEFAULT_TEXT_CONTENT_TYPE 3 222
LongVariable Avoid excessively long variable names like DEFAULT_CSS_CONTENT_TYPE 3 223
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 223
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_KEY 3 226
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 226
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 229
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_DEFAULT 3 229
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 232
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_KEY 3 232
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 235
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_DEFAULT 3 235
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 238
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_KEY 3 238
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 241
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_DEFAULT 3 241
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 244
LongVariable Avoid excessively long variable names like LOCALE_OVERRIDE_CHARSET_KEY 3 244
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 249
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 252
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_KEY 3 252
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_DEFAULT 3 255
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 255
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 262
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 265
LongVariable Avoid excessively long variable names like LOGGING_ROOT_DEFAULT 3 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 271
LongVariable Avoid excessively long variable names like SCREEN_PLACEHOLDER 3 274
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 274
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 277
LongVariable Avoid excessively long variable names like NAVIGATION_PLACEHOLDER 3 277
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 280
LongVariable Avoid excessively long variable names like PROCESSING_EXCEPTION_PLACEHOLDER 3 280
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 283
LongVariable Avoid excessively long variable names like STACK_TRACE_PLACEHOLDER 3 283
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 286
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_KEY 3 286
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 289
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT 3 289
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 292–293
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_NAME_KEY 3 292
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 296–297
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_PORT_KEY 3 296
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 300–301
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_SCHEME_KEY 3 300
LongVariable Avoid excessively long variable names like DEFAULT_SCRIPT_NAME_KEY 3 304
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 304–305
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 308–309
LongVariable Avoid excessively long variable names like DEFAULT_CONTEXT_PATH_KEY 3 308
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 312
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 319

org/apache/turbine/annotation/AnnotationProcessor.java

Rule Violation Priority Line
ModifiedCyclomaticComplexity The class 'AnnotationProcessor' has a Modified Cyclomatic Complexity of 9 (Highest = 23). 3 48–506
GodClass Possible God Class (WMC=70, ATFD=67, TCC=14.286%) 3 48–506
StdCyclomaticComplexity The class 'AnnotationProcessor' has a Standard Cyclomatic Complexity of 9 (Highest = 23). 3 48–506
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 49–506
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 51
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 63
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 65
LocalVariableCouldBeFinal Local variable 'newAnnotations' could be declared final 3 69
MethodArgumentCouldBeFinal Parameter 'acl' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 96
ExcessiveMethodLength Avoid really long methods. 3 112–219
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 112
MethodArgumentCouldBeFinal Parameter 'conditonType' is not assigned and could be declared final 3 112
ModifiedCyclomaticComplexity The method 'isAuthorized' has a Modified Cyclomatic Complexity of 23. 3 112–219
MethodArgumentCouldBeFinal Parameter 'acl' is not assigned and could be declared final 3 112
StdCyclomaticComplexity The method 'isAuthorized' has a Standard Cyclomatic Complexity of 23. 3 112–219
CyclomaticComplexity The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a cyclomatic complexity of 27. 3 112–219
NcssCount The method 'isAuthorized(AccessibleObject, A, ConditionType)' has a NCSS line count of 68. 3 112–219
LocalVariableCouldBeFinal Local variable 'annotations' could be declared final 3 114
LocalVariableCouldBeFinal Local variable 'annotation' could be declared final 3 116
LocalVariableCouldBeFinal Local variable 'trr' could be declared final 3 120
LocalVariableCouldBeFinal Local variable 'roleNames' could be declared final 3 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 121
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
LocalVariableCouldBeFinal Local variable 'roleName' could be declared final 3 126
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 3 128–141
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 132
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 138
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 144
LocalVariableCouldBeFinal Local variable 'roleName' could be declared final 3 149
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 3 151–164
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 155
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 161
LocalVariableCouldBeFinal Local variable 'trp' could be declared final 3 170
LocalVariableCouldBeFinal Local variable 'permissionNames' could be declared final 3 171
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 171
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 172
LocalVariableCouldBeFinal Local variable 'permissionName' could be declared final 3 176
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 3 178–191
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 182
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 188
LocalVariableCouldBeFinal Local variable 'permissionName' could be declared final 3 196
DefaultLabelNotLastInSwitchStmt The default label should be the last label in a switch statement 3 198–211
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 202
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 208
StdCyclomaticComplexity The method 'process' has a Standard Cyclomatic Complexity of 10. 3 228–275
CyclomaticComplexity The method 'process(Object)' has a cyclomatic complexity of 10. 3 228–275
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 228
ModifiedCyclomaticComplexity The method 'process' has a Modified Cyclomatic Complexity of 10. 3 228–275
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'config' (lines '231'-'275'). 5 231–275
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '232'-'275'). 5 232–275
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 3 237
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 239
LocalVariableCouldBeFinal Local variable 'annotations' could be declared final 3 241
LocalVariableCouldBeFinal Local variable 'a' could be declared final 3 243
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 265–266
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 287
MethodArgumentCouldBeFinal Parameter 'assembler' is not assigned and could be declared final 3 287
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 287
MethodArgumentCouldBeFinal Parameter 'annotation' is not assigned and could be declared final 3 287
LocalVariableCouldBeFinal Local variable 'loader' could be declared final 3 289
AvoidDuplicateLiterals The String literal "Injection of {} into object {}" appears 13 times in this file; the first occurrence is on line 294 3 294
MethodArgumentCouldBeFinal Parameter 'annotation' is not assigned and could be declared final 3 316
ExcessiveMethodLength Avoid really long methods. 3 316–430
CyclomaticComplexity The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a cyclomatic complexity of 16. 3 316–430
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 316
ModifiedCyclomaticComplexity The method 'injectTurbineConfiguration' has a Modified Cyclomatic Complexity of 15. 3 316–430
NcssCount The method 'injectTurbineConfiguration(Object, Configuration, Field, TurbineConfiguration)' has a NCSS line count of 75. 3 316–430
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 316
StdCyclomaticComplexity The method 'injectTurbineConfiguration' has a Standard Cyclomatic Complexity of 15. 3 316–430
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 316
LocalVariableCouldBeFinal Local variable 'type' could be declared final 3 318
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 319
LongVariable Avoid excessively long variable names like injectConfiguration 3 325
AvoidFinalLocalVariable Avoid using final local variables, turn them into fields 3 325
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 345
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 351
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 353
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 359
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 361
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 367
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 369
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 375
AvoidUsingShortType Do not use the short type 1 377
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 377
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 383
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 385
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 391
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 393
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 399
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 401
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 407
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 409
LocalVariableCouldBeFinal Local variable 'values' could be declared final 3 417
CyclomaticComplexity The method 'injectTurbineService(Object, ServiceManager, Field, TurbineService)' has a cyclomatic complexity of 10. 3 442–505
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 442
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 442
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 3 442
MethodArgumentCouldBeFinal Parameter 'annotation' is not assigned and could be declared final 3 442
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '444'-'472'). 5 444–472
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '444'-'448'). 5 444–448
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '444'-'460'). 5 444–460
LocalVariableCouldBeFinal Local variable 'typeFields' could be declared final 3 453
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 453
LocalVariableCouldBeFinal Local variable 'f' could be declared final 3 454
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 456
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 468
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 486
LocalVariableCouldBeFinal Local variable 'service' could be declared final 3 491

org/apache/turbine/modules/Action.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 53
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 62

org/apache/turbine/modules/ActionEvent.java

Rule Violation Priority Line
StdCyclomaticComplexity The class 'ActionEvent' has a Standard Cyclomatic Complexity of 6 (Highest = 10). 3 86–373
AbstractNaming Abstract classes should be named AbstractXXX 3 86–373
ModifiedCyclomaticComplexity The class 'ActionEvent' has a Modified Cyclomatic Complexity of 6 (Highest = 10). 3 86–373
AtLeastOneConstructor Each class should declare at least one constructor 3 86–373
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 89
LongVariable Avoid excessively long variable names like METHOD_NAME_PREFIX 3 98
LongVariable Avoid excessively long variable names like METHOD_NAME_LENGTH 3 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 109
ImmutableField Private field 'submitValueKey' could be made final; it is only initialized in the declaration or constructor. 3 109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 117
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 122
ImmutableField Private field 'methodCache' could be made final; it is only initialized in the declaration or constructor. 3 122
CyclomaticComplexity The method 'getMethod(String, Class, ParameterParser)' has a cyclomatic complexity of 10. 3 134–183
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 134
ShortVariable Avoid variables with short names like pp 3 134
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 134
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 3 134
LocalVariableCouldBeFinal Local variable 'cacheKey' could be declared final 3 136
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 3 137
LocalVariableCouldBeFinal Local variable 'methods' could be declared final 3 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 147
LocalVariableCouldBeFinal Local variable 'm' could be declared final 3 150
LocalVariableCouldBeFinal Local variable 'annotations' could be declared final 3 152
LocalVariableCouldBeFinal Local variable 'a' could be declared final 3 153
LocalVariableCouldBeFinal Local variable 'tae' could be declared final 3 157
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 158
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 158–163
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 171
LocalVariableCouldBeFinal Local variable 'tmp' could be declared final 3 171
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 171
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 172
LocalVariableCouldBeFinal Local variable 'oldMethod' could be declared final 3 175
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 194
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 197
ShortVariable Avoid variables with short names like pp 3 197
ModifiedCyclomaticComplexity The method 'executeEvents' has a Modified Cyclomatic Complexity of 10. 3 210–283
StdCyclomaticComplexity The method 'executeEvents' has a Standard Cyclomatic Complexity of 10. 3 210–283
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 3 210
CyclomaticComplexity The method 'executeEvents(ParameterParser, Class, Object)' has a cyclomatic complexity of 12. 3 210–283
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 210
ShortVariable Avoid variables with short names like pp 3 210
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 3 210
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 210
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 211
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'theButton' (lines '214'-'227'). 5 214–227
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'button' (lines '216'-'283'). 5 216–283
LocalVariableCouldBeFinal Local variable 'button' could be declared final 3 216
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '217'-'222'). 5 217–222
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '217'-'236'). 5 217–236
LocalVariableCouldBeFinal Local variable 'k' could be declared final 3 220
CollapsibleIfStatements These nested if statements could be combined 3 225–229
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 236
UnusedAssignment The initializer for variable 'method' is never used (overwritten on lines 244 and 248) 3 240
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'method' (lines '240'-'244'). 5 240–244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'method' (lines '244'-'248'). 5 244–248
ShortVariable Avoid variables with short names like t 3 266
LocalVariableCouldBeFinal Local variable 't' could be declared final 3 266
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 293
ShortVariable Avoid variables with short names like pp 3 293
MethodArgumentCouldBeFinal Parameter 'input' is not assigned and could be declared final 3 293
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tmp' (lines '295'-'299'). 5 295–299
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 299
LocalVariableCouldBeFinal Local variable 'methodName' could be declared final 3 302–304
UselessParentheses Useless parentheses. 4 302
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 308
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 312
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 312
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 312
ShortVariable Avoid variables with short names like pp 3 327
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 327
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 327
ConfusingTernary Avoid if (x != y) ..; else ..; 3 329–369
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 332
LocalVariableCouldBeFinal Local variable 'keyValue' could be declared final 3 345
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 350
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 358
GuardLogStatement Logger calls should be surrounded by log level guards. 2 366
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 367

org/apache/turbine/modules/ActionLoader.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 34–74
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62

org/apache/turbine/modules/GenericLoader.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 42–222
ShortVariable Avoid variables with short names like ab 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'reload' 3 54
AvoidFieldNameMatchingMethodName Field reload has the same name as a method 3 54
FieldNamingConventions The static field name 'TURBINE_PACKAGES' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
RedundantFieldInitializer Avoid using redundant field initializer for 'TURBINE_PACKAGES' 3 60
SuspiciousConstantFieldName The field name indicates a constant but its modifiers do not 3 60
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'TURBINE_PACKAGES' is not final. 1 60
VariableNamingConventions Variables should start with a lowercase character, 'TURBINE_PACKAGES' starts with uppercase character. 1 60
MethodArgumentCouldBeFinal Parameter 'cacheSizeSupplier' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'assemblerClass' is not assigned and could be declared final 3 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 85
MethodArgumentCouldBeFinal Parameter 'reload' is not assigned and could be declared final 3 109
LinguisticNaming Linguistics Antipattern - The setter 'setReload' should not return any type except void linguistically 3 109–113
NonThreadSafeSingleton Singleton is not thread safe 3 134–140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136–137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136–137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136–137
LocalVariableCouldBeFinal Local variable 'turbinePackages' could be declared final 3 136–137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136–137
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 3 142
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 161
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 176
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 177
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'194'). 5 179–194
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'186'). 5 179–186
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '186'-'194'). 5 186–194
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 194
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 3 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 208

org/apache/turbine/modules/Layout.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 61

org/apache/turbine/modules/LayoutLoader.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 34–74
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62

org/apache/turbine/modules/Loader.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 37

org/apache/turbine/modules/Navigation.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 57
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 68

org/apache/turbine/modules/NavigationLoader.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 34–93
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 67
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 78

org/apache/turbine/modules/Page.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Page 4 33–68
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 54
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 64

org/apache/turbine/modules/PageLoader.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 34–75
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63

org/apache/turbine/modules/ScheduledJob.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 58

org/apache/turbine/modules/ScheduledJobLoader.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 35–98
MethodArgumentCouldBeFinal Parameter 'job' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 83
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 86

org/apache/turbine/modules/Screen.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 70
CloseResource Ensure that resources like this RunData object are closed after use 3 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 92
CloseResource Ensure that resources like this RunData object are closed after use 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 104

org/apache/turbine/modules/ScreenLoader.java

Rule Violation Priority Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 1 36–97
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 65
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 66
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 82

org/apache/turbine/modules/actions/AccessController.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 71–119
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 74
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 91
CloseResource Ensure that resources like this RunData object are closed after use 3 94
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 94
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 102–103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 108–109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 117

org/apache/turbine/modules/actions/DefaultAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 45
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 48
CloseResource Ensure that resources like this RunData object are closed after use 3 48
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 49

org/apache/turbine/modules/actions/InitContextsAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44–97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 60
CloseResource Ensure that resources like this RunData object are closed after use 3 63
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '63'-'96'). 5 63–96
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 63
LocalVariableCouldBeFinal Local variable 'contextPropsList' could be declared final 3 71
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 71
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 3 72
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 72–89
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 74
LocalVariableCouldBeFinal Local variable 'start' could be declared final 3 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 75
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LocalVariableCouldBeFinal Local variable 'end' could be declared final 3 76
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 81 and 85) 3 78
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'85'). 5 78–85
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'81'). 5 78–81
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 85
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 87
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 3 91
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 93
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 94

org/apache/turbine/modules/actions/LegacyVelocityAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–85
AbstractNaming Abstract classes should be named AbstractXXX 3 36–85
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 46
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 71
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 79
CloseResource Ensure that resources like this RunData object are closed after use 3 79
ShortVariable Avoid variables with short names like pp 3 80
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 80
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 81

org/apache/turbine/modules/actions/LegacyVelocitySecureAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 41–69
AbstractNaming Abstract classes should be named AbstractXXX 3 41–69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 51
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 68

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 48–157
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
ImmutableField Private field 'loginError' could be made final; it is only initialized in the declaration or constructor. 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 85
CloseResource Ensure that resources like this RunData object are closed after use 3 88
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 88
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 89
LocalVariableCouldBeFinal Local variable 'username' could be declared final 3 89
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'password' (lines '90'-'155'). 5 90–155
LocalVariableCouldBeFinal Local variable 'password' could be declared final 3 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 90
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 114
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 132
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 134
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 142

org/apache/turbine/modules/actions/LogoutUser.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 41–123
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
ImmutableField Private field 'actionLogout' could be made final; it is only initialized in the declaration or constructor. 3 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 75
CloseResource Ensure that resources like this RunData object are closed after use 3 78
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 78
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 99
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 104
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 109

org/apache/turbine/modules/actions/VelocityAction.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 36–96
AtLeastOneConstructor Each class should declare at least one constructor 3 36–96
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 70
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 76
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 92
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92

org/apache/turbine/modules/actions/VelocitySecureAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 42–70
AbstractNaming Abstract classes should be named AbstractXXX 3 42–70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 69

org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 57–129
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
LongVariable Avoid excessively long variable names like loginMessageNoScreen 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 84
CloseResource Ensure that resources like this RunData object are closed after use 3 87
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 127
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 127

org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 53–124
AbstractNaming Abstract classes should be named AbstractXXX 3 53–124
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 66
LongVariable Avoid excessively long variable names like templateInvalidState 3 66
LongVariable Avoid excessively long variable names like screenInvalidState 3 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 69
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'screenOnly' is not assigned and could be declared final 3 79
AvoidDuplicateLiterals The String literal "_session_access_counter" appears 5 times in this file; the first occurrence is on line 81 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86–87
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98
CollapsibleIfStatements These nested if statements could be combined 3 98–117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99–100
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 102–114
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 104–106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105–106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105–106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111–112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 115

org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 56–149
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 60–61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 84
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 87
CloseResource Ensure that resources like this RunData object are closed after use 3 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 124
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 125
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 129
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 141
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 147

org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 46–101
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 50
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 60
CloseResource Ensure that resources like this RunData object are closed after use 3 62
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 64
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 67
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 99

org/apache/turbine/modules/layouts/DirectResponseLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 37–56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 46
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 49
CloseResource Ensure that resources like this RunData object are closed after use 3 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 50

org/apache/turbine/modules/layouts/JspLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 42–80
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 45
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 61
CloseResource Ensure that resources like this RunData object are closed after use 3 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 63
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 76

org/apache/turbine/modules/layouts/VelocityCachedLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 42–61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 59

org/apache/turbine/modules/layouts/VelocityDirectLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 42–58
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 48
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 48

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43–116
AbstractNaming Abstract classes should be named AbstractXXX 3 43–116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 46
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 49
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 63
CloseResource Ensure that resources like this RunData object are closed after use 3 66
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 66
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 68
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 97
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 108
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 108
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 108
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113–114

org/apache/turbine/modules/layouts/VelocityOnlyLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 65–93
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 69
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 75
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 75
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
LocalVariableCouldBeFinal Local variable 'results' could be declared final 3 83
LocalVariableCouldBeFinal Local variable 'returnValue' could be declared final 3 84

org/apache/turbine/modules/layouts/VelocityXslLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55–102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
UnusedPrivateField Avoid unused private fields such as 'screenLoader'. 3 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 73
CloseResource Ensure that resources like this RunData object are closed after use 3 76
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 76
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 88
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 88
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 88
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 93–94
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100

org/apache/turbine/modules/navigations/BaseJspNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–80
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 42
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 69
CloseResource Ensure that resources like this RunData object are closed after use 3 72
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 74
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 74

org/apache/turbine/modules/navigations/LegacyVelocityNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 35–61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 48
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 57

org/apache/turbine/modules/navigations/TemplateNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 34–68
AbstractNaming Abstract classes should be named AbstractXXX 3 34–68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 52
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 62

org/apache/turbine/modules/navigations/VelocityNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44–109
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 48
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 97
CloseResource Ensure that resources like this RunData object are closed after use 3 100
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 100
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LongVariable Avoid excessively long variable names like navigationTemplate 3 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103
LocalVariableCouldBeFinal Local variable 'navigationTemplate' could be declared final 3 103
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 104–105

org/apache/turbine/modules/pages/DefaultPage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 92–207
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 95
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 99
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 107
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 116
CloseResource Ensure that resources like this RunData object are closed after use 3 119
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 132
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 3 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 141
LocalVariableCouldBeFinal Local variable 'aScreen' could be declared final 3 149
LocalVariableCouldBeFinal Local variable 'layout' could be declared final 3 150
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 150
ConfusingTernary Avoid if (x != y) ..; else ..; 3 154–161
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 177
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 189
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 190
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 202
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 203

org/apache/turbine/modules/pages/JspPage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 39–69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 51
LocalVariableCouldBeFinal Local variable 'response' could be declared final 3 58
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 60
EmptyCatchBlock Avoid empty catch blocks 3 62–66

org/apache/turbine/modules/pages/TemplatePage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 82–129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 87
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 97
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 100
CloseResource Ensure that resources like this RunData object are closed after use 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 105
LocalVariableCouldBeFinal Local variable 'template' could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 110
LocalVariableCouldBeFinal Local variable 'layoutTemplate' could be declared final 3 113–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 115
LocalVariableCouldBeFinal Local variable 'screen' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'errMsg' could be declared final 3 121–122

org/apache/turbine/modules/pages/VelocityPage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 39–74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 54
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 57
CloseResource Ensure that resources like this RunData object are closed after use 3 57
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 58
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 59–60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 59–60
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 68
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 71

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 39–96
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 43
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 61
CloseResource Ensure that resources like this RunData object are closed after use 3 64
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 64
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 65
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 67–68
GuardLogStatement Logger calls should be surrounded by log level guards. 2 73
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 74
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 91

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 82–143
LongVariable Avoid excessively long variable names like JSONRPC_CONTENT_TYPE 3 84
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 109
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 111
CloseResource Ensure that resources like this RunData object are closed after use 3 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 113
LocalVariableCouldBeFinal Local variable 'request' could be declared final 3 113
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 116
CloseResource Ensure that resources like this InputStreamReader object are closed after use 3 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 117
LocalVariableCouldBeFinal Local variable 'in' could be declared final 3 117
ShortVariable Avoid variables with short names like in 3 117
LocalVariableCouldBeFinal Local variable 'cdata' could be declared final 3 120
LocalVariableCouldBeFinal Local variable 'buf' could be declared final 3 121
AssignmentInOperand Avoid assignments in operands 3 123
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'ret' (lines '123'-'142'). 5 123–142
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 130
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 3 130
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 130
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 130
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 3 133
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 1 133
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 1 133
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 137

org/apache/turbine/modules/screens/JSONSecureScreen.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 77–104
AtLeastOneConstructor Each class should declare at least one constructor 3 77–104
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 87
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 103

org/apache/turbine/modules/screens/JspErrorScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 34–50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
ImmutableField Private field 'templateError' could be made final; it is only initialized in the declaration or constructor. 3 38
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 45

org/apache/turbine/modules/screens/LegacyVelocityScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 33–65
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 45
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 60

org/apache/turbine/modules/screens/LegacyVelocitySecureScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 34–77
AbstractNaming Abstract classes should be named AbstractXXX 3 34–77
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 76

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 72–118
DefaultPackage Use explicit scoping instead of the default package private level 3 78
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 78
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the log field if you want a default access modifier 3 78
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 101
CloseResource Ensure that resources like this RunData object are closed after use 3 103
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 103
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '105'-'117'). 5 105–117
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 107
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 1 107
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 3 107
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 1 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
StringToString Avoid calling toString() on String objects; this is unnecessary. 3 114

org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 31–70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 42
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 59
CloseResource Ensure that resources like this RunData object are closed after use 3 60
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '60'-'69'). 5 60–69
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 61
LocalVariableCouldBeFinal Local variable 'methods' could be declared final 3 61
LocalVariableCouldBeFinal Local variable 'm' could be declared final 3 62
LiteralsFirstInComparisons Position literals first in String comparisons 3 63
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 64
ControlStatementBraces This statement should have braces 3 64
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 65

org/apache/turbine/modules/screens/RawScreen.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 45–96
AtLeastOneConstructor Each class should declare at least one constructor 3 45–96
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 59
CloseResource Ensure that resources like this RunData object are closed after use 3 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 61
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 83
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 92–95
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 52–204
AtLeastOneConstructor Each class should declare at least one constructor 3 52–204
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 72
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 83
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 92–95
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'out' (lines '109'-'114'). 5 109–114
UnusedAssignment The initializer for variable 'out' is never used (overwritten on line 114) 3 109
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 135
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 137
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 138
ShortVariable Avoid variables with short names like ti 3 138
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 3 138
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 139
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 139
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 141
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 148
EmptyCatchBlock Avoid empty catch blocks 3 148–151
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 173
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 174
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 199
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 199
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 200

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 39–84
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 53
CloseResource Ensure that resources like this RunData object are closed after use 3 53
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '54'-'83'). 5 54–83
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 56
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 56
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 57–58
GuardLogStatement Logger calls should be surrounded by log level guards. 2 63
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 64
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 71

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 40–89
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 51
CloseResource Ensure that resources like this RunData object are closed after use 3 54
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 55
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '55'-'88'). 5 55–88
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 55
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 57
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 57
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 58–59
GuardLogStatement Logger calls should be surrounded by log level guards. 2 64
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 72
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 84

org/apache/turbine/modules/screens/VelocityErrorScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–58
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 47
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 50
CloseResource Ensure that resources like this RunData object are closed after use 3 50
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 52
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 52
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 54

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 48–152
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 52
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 75
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 76
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 104
CloseResource Ensure that resources like this RunData object are closed after use 3 107
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'147'). 5 108–147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'135'). 5 108–135
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 108
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'screenData' (lines '108'-'151'). 5 108–151
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 110
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '110'-'151'). 5 110–151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 110
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 113–114
GuardLogStatement Logger calls should be surrounded by log level guards. 2 119
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 120
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '135'-'147'). 5 135–147
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 139

org/apache/turbine/modules/screens/VelocitySecureScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 41–85
AbstractNaming Abstract classes should be named AbstractXXX 3 41–85
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 84

org/apache/turbine/modules/screens/error/InvalidState.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 46–86
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
CloseResource Ensure that resources like this RunData object are closed after use 3 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 58
LocalVariableCouldBeFinal Local variable 'body' could be declared final 3 59
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 62
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 63
ShortVariable Avoid variables with short names like sb 3 63
ShortVariable Avoid variables with short names like pp 3 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
LocalVariableCouldBeFinal Local variable 'back' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 79
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 82

org/apache/turbine/om/OMTool.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
ImmutableField Private field 'pullMap' could be made final; it is only initialized in the declaration or constructor. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 62
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 75
DefaultPackage Use explicit scoping instead of the default package private level 3 95
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the omName field if you want a default access modifier 3 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 95
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 3 97
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 102
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 3 102–119
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 103
UnusedAssignment The initializer for variable 'om' is never used (overwritten on lines 110 and 114) 3 105
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'110'). 5 105–110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'114'). 5 105–114
ShortVariable Avoid variables with short names like om 3 105
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 3 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 3 128
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 128
ShortVariable Avoid variables with short names like ph 3 130
LocalVariableCouldBeFinal Local variable 'ph' could be declared final 3 130
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 133
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 146
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 146
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 3 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 148
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 153
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 153

org/apache/turbine/om/Retrievable.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 52

org/apache/turbine/om/Retriever.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 44

org/apache/turbine/om/RetrieverFactory.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 43

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1–758
GodClass Possible God Class (WMC=67, ATFD=31, TCC=15.137%) 3 44–758
RedundantFieldInitializer Avoid using redundant field initializer for 'lastAccessDate' 3 50
RedundantFieldInitializer Avoid using redundant field initializer for 'permStorage' 3 53
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 71) 3 56
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 3 56
RedundantFieldInitializer Avoid using redundant field initializer for 'userDelegate' 3 59
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 66
ConstructorCallsOverridableMethod Overridable method 'setUserDelegate' called during object construction 1 69
ConstructorCallsOverridableMethod Overridable method 'setHasLoggedIn' called during object construction 1 72
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 3 94
LocalVariableCouldBeFinal Local variable 'securityService' could be declared final 3 100–102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101–102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 106
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 135
ShortVariable Avoid variables with short names like id 3 158
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 158
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 189
MethodArgumentCouldBeFinal Parameter 'firstName' is not assigned and could be declared final 3 211
MethodArgumentCouldBeFinal Parameter 'lastName' is not assigned and could be declared final 3 233
MethodArgumentCouldBeFinal Parameter 'address' is not assigned and could be declared final 3 255
MethodArgumentCouldBeFinal Parameter 'objectdata' is not assigned and could be declared final 3 280
MethodArgumentCouldBeFinal Parameter 'userGroupRoleSet' is not assigned and could be declared final 3 305
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 3 319
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 3 333
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 348
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 350
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 366
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 368
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 3 399
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 3 411
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 449–467
LocalVariableCouldBeFinal Local variable 'objectdata' could be declared final 3 453
MethodArgumentCouldBeFinal Parameter 'permStorage' is not assigned and could be declared final 3 476
MethodArgumentCouldBeFinal Parameter 'tempStorage' is not assigned and could be declared final 3 507
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 522
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 524
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 536
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 3 536
LocalVariableCouldBeFinal Local variable 'val' could be declared final 3 540
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 540
UselessParentheses Useless parentheses. 4 541
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 541
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 543
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 556
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 556
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 558
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 568
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 570
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 582
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 3 582
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 587
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '590'-'595'). 5 590–595
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 593
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 607
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 607
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 609
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 619
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 621
MethodArgumentCouldBeFinal Parameter 'confirm' is not assigned and could be declared final 3 641
MethodArgumentCouldBeFinal Parameter 'createDate' is not assigned and could be declared final 3 663
MethodArgumentCouldBeFinal Parameter 'lastLogin' is not assigned and could be declared final 3 685
LocalVariableCouldBeFinal Local variable 'loggedIn' could be declared final 3 698
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 699
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 709
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 725
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 726
MethodArgumentCouldBeFinal Parameter 'userDelegate' is not assigned and could be declared final 3 754

org/apache/turbine/om/security/User.java

Rule Violation Priority Line
ShortClassName Avoid short class names like User 4 41–289
LongVariable Avoid excessively long variable names like SESSION_ACCESS_COUNTER 3 60
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 288

org/apache/turbine/pipeline/CleanUpValve.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 49–52
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 58
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 65
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 79
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 81
CloseResource Ensure that resources like this RunData object are closed after use 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 88–89
LongVariable Avoid excessively long variable names like invalidatedSession 3 91
EmptyCatchBlock Avoid empty catch blocks 3 91–95

org/apache/turbine/pipeline/DefaultACLCreationValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 41–75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
LongVariable Avoid excessively long variable names like actionAccessController 3 49
ImmutableField Private field 'actionAccessController' could be made final; it is only initialized in the declaration or constructor. 3 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 67

org/apache/turbine/pipeline/DefaultLoginValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 50–166
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 67
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 74
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 91
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 92
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 94
CloseResource Ensure that resources like this RunData object are closed after use 3 94
LocalVariableCouldBeFinal Local variable 'actionName' could be declared final 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 118
LocalVariableCouldBeFinal Local variable 'names' could be declared final 3 118
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 119–141
LocalVariableCouldBeFinal Local variable 'nameList' could be declared final 3 123
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 126
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'session' (lines '129'-'148'). 5 129–148
LocalVariableCouldBeFinal Local variable 'session' could be declared final 3 129
LocalVariableCouldBeFinal Local variable 'name' could be declared final 3 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 134
LongVariable Avoid excessively long variable names like invalidatedSession 3 136
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 155
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 3 160
ShortVariable Avoid variables with short names like ti 3 160

org/apache/turbine/pipeline/DefaultPipelineData.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44–104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'innerKey' is not assigned and could be declared final 3 82
LocalVariableCouldBeFinal Local variable 'innerMap' could be declared final 3 84
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LocalVariableCouldBeFinal Local variable 'rds' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98

org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43–67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 53
CloseResource Ensure that resources like this RunData object are closed after use 3 56
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 61

org/apache/turbine/pipeline/DefaultSessionValidationValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 41–78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
LongVariable Avoid excessively long variable names like actionSessionValidator 3 49
ImmutableField Private field 'actionSessionValidator' could be made final; it is only initialized in the declaration or constructor. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 70

org/apache/turbine/pipeline/DefaultSetEncodingValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 47–92
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 50
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 50
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
LocalVariableCouldBeFinal Local variable 'req' could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 63
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 87

org/apache/turbine/pipeline/DetermineActionValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 40–75
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 43
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 43
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 50
CloseResource Ensure that resources like this RunData object are closed after use 3 53
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 53
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 54
LocalVariableCouldBeFinal Local variable 'action' could be declared final 3 56–57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 57
ConfusingTernary Avoid if (x != y) ..; else ..; 3 59–67

org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 43
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 43
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 48–51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 73
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 76
CloseResource Ensure that resources like this RunData object are closed after use 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 78
LocalVariableCouldBeFinal Local variable 'requestRedirected' could be declared final 3 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 87

org/apache/turbine/pipeline/DetermineTargetValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44–77
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 46
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 53
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 56
CloseResource Ensure that resources like this RunData object are closed after use 3 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 57
LocalVariableCouldBeFinal Local variable 'target' could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 59
ConfusingTernary Avoid if (x != y) ..; else ..; 3 61–69

org/apache/turbine/pipeline/ExecutePageValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43–120
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
ImmutableField Private field 'pageDefault' could be made final; it is only initialized in the declaration or constructor. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 84
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 85

org/apache/turbine/pipeline/Pipeline.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 60

org/apache/turbine/pipeline/TurbinePipeline.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 47–183
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
ImmutableField Private field 'state' could be made final; it is only initialized in the declaration or constructor. 3 70
LocalVariableCouldBeFinal Local variable 'v' could be declared final 3 83
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 3 115
MethodArgumentCouldBeFinal Parameter 'valves' is not assigned and could be declared final 3 138
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 138
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 3 147
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 156
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 170
LocalVariableCouldBeFinal Local variable 'current' could be declared final 3 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 180

org/apache/turbine/pipeline/Valve.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 100

org/apache/turbine/pipeline/XmlValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 34–58
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 54

org/apache/turbine/pipeline/XmlValveAdapter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 29–52
MethodArgumentCouldBeFinal Parameter 'xmlValve' is not assigned and could be declared final 3 35
LocalVariableCouldBeFinal Local variable 'valveClass' could be declared final 3 37
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 38
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 3 45
LocalVariableCouldBeFinal Local variable 'xmlValve' could be declared final 3 47
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 48

org/apache/turbine/services/BaseInitable.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'isInitialized' 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 50–53
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 61
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 137

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 59–284
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 96
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 3 102
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 105–106
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 3 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 143
LocalVariableCouldBeFinal Local variable 'initable' could be declared final 3 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 150
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 176
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 177
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 227
CyclomaticComplexity The method 'getInitableInstance(String)' has a cyclomatic complexity of 11. 3 227–282
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 228
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'initable' (lines '236'-'282'). 5 236–282
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 236
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 240–243
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 244–247
IdenticalCatchBranches 'catch' branch identical to 'ThreadDeath' branch 3 244–247
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 249–275
UnusedAssignment The initializer for variable 'msg' is never used (overwritten on lines 256, 261, 266 and 271) 3 252
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 254
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 259
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 264

org/apache/turbine/services/BaseService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 37–125
DataClass The class 'BaseService' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=8) 3 37–125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 69
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 121

org/apache/turbine/services/BaseServiceBroker.java

Rule Violation Priority Line
CyclomaticComplexity The class 'BaseServiceBroker' has a total cyclomatic complexity of 88 (highest 18). 3 58–780
ModifiedCyclomaticComplexity The class 'BaseServiceBroker' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 3 58–780
StdCyclomaticComplexity The class 'BaseServiceBroker' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 3 58–780
GodClass Possible God Class (WMC=88, ATFD=29, TCC=15.580%) 3 58–780
AbstractNaming Abstract classes should be named AbstractXXX 3 58–780
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 105
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 108
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 119
LongVariable Avoid excessively long variable names like serviceProviderInstanceMap 3 119
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 139
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 185
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 185
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 196
MethodArgumentCouldBeFinal Parameter 'checkIfc' is not assigned and could be declared final 3 209
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 209
MethodArgumentCouldBeFinal Parameter 'interfaces' is not assigned and could be declared final 3 209
LocalVariableCouldBeFinal Local variable 'ifc' could be declared final 3 211
CompareObjectsWithEquals Use equals() to compare object references. 3 213
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 215
LocalVariableCouldBeFinal Local variable 'subInterfaces' could be declared final 3 218
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 221
CyclomaticComplexity The method 'initMapping()' has a cyclomatic complexity of 14. 3 245–305
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 249
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'earlyInitFlags' (lines '249'-'305'). 5 249–305
LocalVariableCouldBeFinal Local variable 'earlyInitFlags' could be declared final 3 249
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 256–299
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 3 256
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 258
LocalVariableCouldBeFinal Local variable 'keyParts' could be declared final 3 259
UselessParentheses Useless parentheses. 4 262
UselessParentheses Useless parentheses. 4 263
LocalVariableCouldBeFinal Local variable 'serviceKey' could be declared final 3 265
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 270
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 3 273
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 277
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 277–281
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 284–287
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 288–291
IdenticalCatchBranches 'catch' branch identical to 'ThreadDeath' branch 3 288–291
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 301
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 315
UselessParentheses Useless parentheses. 4 317
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 327
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 3 337
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 3 339
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 340
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 342
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 361
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 361–374
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 3 367
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 369
MethodArgumentCouldBeFinal Parameter 'report' is not assigned and could be declared final 3 404
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 405
LocalVariableCouldBeFinal Local variable 'names' could be declared final 3 410
LocalVariableCouldBeFinal Local variable 'names' could be declared final 3 418
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 439
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 440
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 443
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 460–483
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 460
LocalVariableCouldBeFinal Local variable 'service' could be declared final 3 464
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 465
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 467
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 469
GuardLogStatement Logger calls should be surrounded by log level guards. 2 480–481
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '494'-'507'). 5 494–507
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceName' (lines '494'-'517'). 5 494–517
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '494'-'513'). 5 494–513
UnusedAssignment The initializer for variable 'serviceName' is never used (overwritten on lines 507 and 513) 3 494
LocalVariableCouldBeFinal Local variable 'reverseServicesList' could be declared final 3 503
LongVariable Avoid excessively long variable names like reverseServicesList 3 503
LocalVariableCouldBeFinal Local variable 'serviceNames' could be declared final 3 505
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 511–516
LocalVariableCouldBeFinal Local variable 'serviceNames' could be declared final 3 511
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 528
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 528
CyclomaticComplexity The method 'getService(String)' has a cyclomatic complexity of 10. 3 528–576
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 558
CyclomaticComplexity The method 'getServiceInstance(String)' has a cyclomatic complexity of 18. 3 598–680
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 598
StdCyclomaticComplexity The method 'getServiceInstance' has a Standard Cyclomatic Complexity of 12. 3 598–680
ModifiedCyclomaticComplexity The method 'getServiceInstance' has a Modified Cyclomatic Complexity of 12. 3 598–680
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 599
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 3 623
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 627
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_service' is not final. 1 633
LocalVariableCouldBeFinal Local variable '_service' could be declared final 3 633
LocalVariableNamingConventions The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' 1 633
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'service' (lines '636'-'680'). 5 636–680
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 646–649
IdenticalCatchBranches 'catch' branch identical to 'ThreadDeath' branch 3 650–653
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 650–653
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 654–657
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 659
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 659
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_service' is not final. 1 666
LocalVariableNamingConventions The local variable name '_service' doesn't match '[a-z][a-zA-Z0-9]*' 1 666
LocalVariableCouldBeFinal Local variable '_service' could be declared final 3 666
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 689
MethodArgumentCouldBeFinal Parameter 'applicationRoot' is not assigned and could be declared final 3 699
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 723
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 737
LongVariable Avoid excessively long variable names like turbineServiceProvider 3 739
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'turbineServiceProvider' (lines '739'-'752'). 5 739–752
UnusedAssignment The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 743) 3 739
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'turbineServiceProvider' (lines '739'-'743'). 5 739–743
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 741
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 747
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 761
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 762
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'turbineServiceProvider' (lines '764'-'779'). 5 764–779
LongVariable Avoid excessively long variable names like turbineServiceProvider 3 764
UnusedAssignment The initializer for variable 'turbineServiceProvider' is never used (overwritten on line 768) 3 764
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'turbineServiceProvider' (lines '764'-'768'). 5 764–768
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 766

org/apache/turbine/services/BaseUnicastRemoteService.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
CallSuperInConstructor It is a good practice to call super() in a constructor 3 55–62
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 60
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 114
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 141
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 162

org/apache/turbine/services/Initable.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 96

org/apache/turbine/services/InitableBroker.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 97

org/apache/turbine/services/InitializationException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 60
ShortVariable Avoid variables with short names like t 3 60

org/apache/turbine/services/InstantiationException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 51
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 63
ShortVariable Avoid variables with short names like t 3 63
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 63

org/apache/turbine/services/ServiceBroker.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 95

org/apache/turbine/services/TurbineBaseService.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 59–124
AtLeastOneConstructor Each class should declare at least one constructor 3 59–124
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 72
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 92–95

org/apache/turbine/services/TurbineServiceProvider.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 42

org/apache/turbine/services/TurbineServices.java

Rule Violation Priority Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 67–75
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 3 67
LocalVariableCouldBeFinal Local variable 'previous' could be declared final 3 69

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55–306
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 60–61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
RedundantFieldInitializer Avoid using redundant field initializer for 'factories' 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
RedundantFieldInitializer Avoid using redundant field initializer for 'assemblerCache' 3 67
RedundantFieldInitializer Avoid using redundant field initializer for 'loaderCache' 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
AvoidDuplicateLiterals The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 84 3 84
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103
LocalVariableCouldBeFinal Local variable 'names' could be declared final 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 105
LocalVariableCouldBeFinal Local variable 'name2' could be declared final 3 107
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 3 109
ShortVariable Avoid variables with short names like af 3 113
LocalVariableCouldBeFinal Local variable 'af' could be declared final 3 113–114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 118–121
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 124–128
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 146
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 148–156
LocalVariableCouldBeFinal Local variable 'type' could be declared final 3 150
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 164–166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 170–172
LocalVariableCouldBeFinal Local variable 'cacheSize' could be declared final 3 170–172
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 190
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 192
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 211
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 211
CyclomaticComplexity The method 'getAssembler(Class, String)' has a cyclomatic complexity of 10. 3 211–260
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 214
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '215'-'219'). 5 215–219
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 3 225
UselessParentheses Useless parentheses. 4 227
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 227
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 3 229
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 233
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '233'-'260'). 5 233–260
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 235
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 240
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 240
LocalVariableCouldBeFinal Local variable 'oldAssembler' could be declared final 3 249
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 250–253
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 273
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'loader' (lines '275'-'279'). 5 275–279
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 3 285
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 287
UselessParentheses Useless parentheses. 4 287
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 3 289
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 290

org/apache/turbine/services/assemblerbroker/util/java/JavaActionFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 42–142
AbstractNaming Abstract classes should be named AbstractXXX 3 42–142
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'packageName' is not assigned and could be declared final 3 65
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '67'-'94'). 5 67–94
LocalVariableCouldBeFinal Local variable 'p' could be declared final 3 73
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 75
ShortVariable Avoid variables with short names like sb 3 75
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 75
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 78
LocalVariableNamingConventions The local variable name '_servClass' doesn't match '[a-z][a-zA-Z0-9]*' 1 88
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_servClass' is not final. 1 88
LocalVariableCouldBeFinal Local variable '_servClass' could be declared final 3 88
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 89–92
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 94
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 140

org/apache/turbine/services/assemblerbroker/util/java/JavaLayoutFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaNavigationFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaPageFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScheduledJobFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScreenFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 36–72
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/python/PythonActionFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 48–177
AtLeastOneConstructor Each class should declare at least one constructor 3 48–177
LongVariable Avoid excessively long variable names like PYTHON_CONFIG_FILE 3 55
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'subDirectory' is not assigned and could be declared final 3 71
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 72
LocalVariableCouldBeFinal Local variable 'path' could be declared final 3 74
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 78
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '84'-'156'). 5 84–156
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confName' (lines '86'-'156'). 5 86–156
LocalVariableCouldBeFinal Local variable 'confName' could be declared final 3 86
LocalVariableCouldBeFinal Local variable 'fName' could be declared final 3 89
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 91
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 92
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 93
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 94
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 95
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 95
ShortVariable Avoid variables with short names like f 3 98
LocalVariableCouldBeFinal Local variable 'f' could be declared final 3 98
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 130–139
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 132–138
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 132
LocalVariableCouldBeFinal Local variable 't' could be declared final 3 143
ShortVariable Avoid variables with short names like t 3 143
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 146
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 175

org/apache/turbine/services/assemblerbroker/util/python/PythonLayoutFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonNavigationFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonPageFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonScreenFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–76
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/avaloncomponent/AvalonComponentService.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 37
LongVariable Avoid excessively long variable names like AVALON_LOG_CATEGORY 3 40
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 40
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_KEY 3 43
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 43
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_VALUE 3 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 46
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_KEY 3 49
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 49
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_VALUE 3 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 55
LongVariable Avoid excessively long variable names like COMPONENT_LOOKUP_KEY 3 55
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 58
LongVariable Avoid excessively long variable names like COMPONENT_APP_ROOT 3 58

org/apache/turbine/services/avaloncomponent/Log4j2Logger.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 35
FieldNamingConventions The final field name 'm_logger' doesn't match '[a-z][a-zA-Z0-9]*' 1 35

org/apache/turbine/services/avaloncomponent/TurbineYaafiComponentService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43–293
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_KEY 3 51
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_VALUE 3 54
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY 3 57
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 80
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 116
LocalVariableCouldBeFinal Local variable 'home' could be declared final 3 116
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 120–121
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 131
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 147
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 158
MethodArgumentCouldBeFinal Parameter 'component' is not assigned and could be declared final 3 169
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 178
MethodArgumentCouldBeFinal Parameter 'applicationRoot' is not assigned and could be declared final 3 192
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 192
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 195
LongVariable Avoid excessively long variable names like containerConfiguration 3 206
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 3 206–208
LongVariable Avoid excessively long variable names like roleConfigurationFileName 3 216
LocalVariableCouldBeFinal Local variable 'roleConfigurationFileName' could be declared final 3 216–219
LongVariable Avoid excessively long variable names like componentConfigurationFileName 3 223
LocalVariableCouldBeFinal Local variable 'componentConfigurationFileName' could be declared final 3 223–226
LocalVariableCouldBeFinal Local variable 'parametersFileName' could be declared final 3 230–233
LongVariable Avoid excessively long variable names like parametersFileName 3 230
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 3 243–246
LongVariable Avoid excessively long variable names like containerConfiguration 3 243
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 271
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 280
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 280
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 286–291
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 288

org/apache/turbine/services/intake/IntakeTool.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 54–551
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 56
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 56
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 65
RedundantFieldInitializer Avoid using redundant field initializer for 'groups' 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
ShortVariable Avoid variables with short names like pp 3 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 70
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 72
RedundantFieldInitializer Avoid using redundant field initializer for 'pullMap' 3 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 81
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 86–88
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 94
LocalVariableCouldBeFinal Local variable 'groupNames' could be declared final 3 98
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupCount' (lines '99'-'102'). 5 99–102
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 109
LocalVariableCouldBeFinal Local variable 'groupKeys' could be declared final 3 115
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '116'-'119'). 5 116–119
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '116'-'123'). 5 116–123
UnusedAssignment The initializer for variable 'groupNames' is never used (overwritten on lines 119 and 123) 3 116
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '123'-'126'). 5 123–126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'groupNames' (lines '126'-'126'). 5 126
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 134–135
LocalVariableCouldBeFinal Local variable 'foundGroups' could be declared final 3 134–135
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 139–140
ShortVariable Avoid variables with short names like vp 3 155
MethodArgumentCouldBeFinal Parameter 'vp' is not assigned and could be declared final 3 155
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 157
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 183
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 197
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 3 210
ShortVariable Avoid variables with short names like sb 3 210
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 210
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 230
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 252
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the groupName field if you want a default access modifier 3 252
DefaultPackage Use explicit scoping instead of the default package private level 3 252
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 259
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 3 283–287
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 283
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 297
MethodArgumentCouldBeFinal Parameter 'create' is not assigned and could be declared final 3 297
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 3 297–315
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '300'-'305'). 5 300–305
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '300'-'309'). 5 300–309
ShortVariable Avoid variables with short names like g 3 300
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 3 302
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 323
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '325'-'337'). 5 325–337
UnusedAssignment The initializer for variable 'g' is never used (overwritten on lines 333 and 337) 3 325
ShortVariable Avoid variables with short names like g 3 325
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'g' (lines '325'-'333'). 5 325–333
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 3 329–330
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 341
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 357
MethodArgumentCouldBeFinal Parameter 'throwExceptions' is not assigned and could be declared final 3 370
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 370
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 384
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 398
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 398
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 413
MethodArgumentCouldBeFinal Parameter 'create' is not assigned and could be declared final 3 413
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 413
ShortVariable Avoid variables with short names like ph 3 425
LocalVariableCouldBeFinal Local variable 'ph' could be declared final 3 425
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 426
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 435
LocalVariableCouldBeFinal Local variable 'groupKeys' could be declared final 3 442
LocalVariableCouldBeFinal Local variable 'groupKey' could be declared final 3 448
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 475
LocalVariableCouldBeFinal Local variable 'allGroups' could be declared final 3 475
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 478
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 495
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 495
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 521
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 536

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'JSONProcessor' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 1 39–87
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 40–87
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 42
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 51
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 3 51
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 3 51
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 51
UnusedAssignment The initializer for variable 'json_req' is never used (overwritten on line 58) 3 54
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_req' is not final. 1 54
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_req' (lines '54'-'58'). 5 54–58
LocalVariableNamingConventions The local variable name 'json_req' doesn't match '[a-z][a-zA-Z0-9]*' 1 54
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 1 55
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 1 55
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '55'-'75'). 5 55–75
UnusedAssignment The initializer for variable 'json_res' is never used (overwritten on lines 75 and 80) 3 55
LocalVariableCouldBeFinal Local variable 'methodName' could be declared final 3 61
LocalVariableCouldBeFinal Local variable 'arguments' could be declared final 3 62
LocalVariableCouldBeFinal Local variable 'object_id' could be declared final 3 65
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'object_id' is not final. 1 65
LocalVariableNamingConventions The local variable name 'object_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 66
ShortVariable Avoid variables with short names like sb 3 66
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '75'-'80'). 5 75–80
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 83
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 83

org/apache/turbine/services/jsonrpc/JsonRpcService.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 51

org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 37–102
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 3 45
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 3 46
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 46
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 46
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 46
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 52
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 54
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 58
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 3 60
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 61
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 65
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 67
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 67
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 77

org/apache/turbine/services/jsp/JspService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like BUFFER_SIZE_DEFAULT 3 56

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 52–311
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
LongVariable Avoid excessively long variable names like relativeTemplatePaths 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 66
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 86
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 100
LocalVariableCouldBeFinal Local variable 'req' could be declared final 3 102
LocalVariableCouldBeFinal Local variable 'templateLink' could be declared final 3 109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 113
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 137
MethodArgumentCouldBeFinal Parameter 'isForward' is not assigned and could be declared final 3 137
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 137
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 142
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 145
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 145
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '145'-'193'). 5 145–193
LongVariable Avoid excessively long variable names like relativeTemplateName 3 148
LocalVariableCouldBeFinal Local variable 'relativeTemplateName' could be declared final 3 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 157–158
LocalVariableCouldBeFinal Local variable 'dispatcher' could be declared final 3 157–158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 157–158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 169
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 169
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 179–180
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 179–180
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 181
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 204
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 204
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 214
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 220
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 231–232
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 243
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 3 245
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 249
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 264
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 264
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 279
LocalVariableCouldBeFinal Local variable 'relativeTemplate' could be declared final 3 281
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'relativeTemplate' (lines '281'-'294'). 5 281–294
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 290
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 302
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 304
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 307

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 71
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '72'-'76'). 5 72–76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 75
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 79
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 81–82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
EmptyCatchBlock Avoid empty catch blocks 3 88–91

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 64
LocalVariableCouldBeFinal Local variable 'abs' could be declared final 3 67–68
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'template' (lines '77'-'81'). 5 77–81
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '78'-'83'). 5 78–83
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 82
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 83
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 86
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 88–89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
EmptyCatchBlock Avoid empty catch blocks 3 95–98

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
LongVariable Avoid excessively long variable names like localizationService 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
ConstructorCallsOverridableMethod Overridable method 'refresh' called during object construction 1 59
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 75
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 79
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 109
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 134
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 150

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 50–171
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 55
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPropsList' 3 61
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 81
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 86–113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 3 86
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 90
LocalVariableCouldBeFinal Local variable 'end' could be declared final 3 90
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 3 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 97
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'102'). 5 98–102
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 102 and 106) 3 98
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'106'). 5 98–106
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 106
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 109–110
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 115
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 3 118
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 119
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 119
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 129–130
MethodArgumentCouldBeFinal Parameter 'contextName' is not assigned and could be declared final 3 146
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 154 and 158) 3 150
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'154'). 5 150–154
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'158'). 5 150–158
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 166

org/apache/turbine/services/pull/PullService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_KEY 3 82
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_DEFAULT 3 88
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_KEY 3 94
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_DEFAULT 3 97
LongVariable Avoid excessively long variable names like SESSION_TOOLS_ATTRIBUTE_PREFIX 3 100

org/apache/turbine/services/pull/TurbinePullService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 121–841
GodClass Possible God Class (WMC=65, ATFD=64, TCC=27.485%) 3 121–841
TooManyMethods This class has too many methods, consider refactoring it. 3 124–841
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 126
RedundantFieldInitializer Avoid using redundant field initializer for 'pool' 3 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 132
RedundantFieldInitializer Avoid using redundant field initializer for 'velocity' 3 132
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 142
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the toolName field if you want a default access modifier 3 151
DefaultPackage Use explicit scoping instead of the default package private level 3 151
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 151
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 152
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the toolClassName field if you want a default access modifier 3 152
DefaultPackage Use explicit scoping instead of the default package private level 3 152
DefaultPackage Use explicit scoping instead of the default package private level 3 153
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the toolClass field if you want a default access modifier 3 153
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 153
MethodArgumentCouldBeFinal Parameter 'toolClass' is not assigned and could be declared final 3 155
MethodArgumentCouldBeFinal Parameter 'toolName' is not assigned and could be declared final 3 155
MethodArgumentCouldBeFinal Parameter 'toolClassName' is not assigned and could be declared final 3 155
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 164
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 164
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 167
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 167
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 170
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 170
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 173
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 173
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 176
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 176
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 179
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 179
LongVariable Avoid excessively long variable names like resourcesDirectory 3 179
LongVariable Avoid excessively long variable names like refreshToolsPerRequest 3 182
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 182
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 182
RedundantFieldInitializer Avoid using redundant field initializer for 'refreshToolsPerRequest' 3 182
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 193
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 208
ConfusingTernary Avoid if (x != y) ..; else ..; 3 210–217
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 219
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 231
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 234
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 238–240
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 245–247
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 266
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 272
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 289
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 291
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 293
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 295
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 297
MethodArgumentCouldBeFinal Parameter 'toolConfig' is not assigned and could be declared final 3 316
LocalVariableCouldBeFinal Local variable 'tools' could be declared final 3 318
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 324
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 327
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 327–346
LocalVariableCouldBeFinal Local variable 'toolName' could be declared final 3 329
LocalVariableCouldBeFinal Local variable 'toolClassName' could be declared final 3 330
LocalVariableCouldBeFinal Local variable 'toolClass' could be declared final 3 335
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 338
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 377
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 377
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 391
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 3 400–403
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 401–403
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 405
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 405
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 422
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 422
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 424
CloseResource Ensure that resources like this RunData object are closed after use 3 424
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 437
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 437
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 3 446–449
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 447–449
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 451
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 451
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 463
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 3 465
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 469
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 469
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 3 469
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 477
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 491
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 491
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 3 494
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 3 499
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 507
MethodArgumentCouldBeFinal Parameter 'tools' is not assigned and could be declared final 3 524
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 524
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 525
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 525
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 3 528
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 538–540
ConfusingTernary Avoid if (x != y) ..; else ..; 3 553–585
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 556–558
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 558
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 558
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 588
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 606
MethodArgumentCouldBeFinal Parameter 'tools' is not assigned and could be declared final 3 606
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 607
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 607
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 3 610
ConfusingTernary Avoid if (x != y) ..; else ..; 3 636–664
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 667
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 3 712
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 3 714
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 727
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 741
MethodArgumentCouldBeFinal Parameter 'tools' is not assigned and could be declared final 3 741
LocalVariableCouldBeFinal Local variable 'toolData' could be declared final 3 745
LocalVariableCouldBeFinal Local variable 'tool' could be declared final 3 747
MethodArgumentCouldBeFinal Parameter 'param' is not assigned and could be declared final 3 765
MethodArgumentCouldBeFinal Parameter 'tool' is not assigned and could be declared final 3 765
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 766
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 778
CloseResource Ensure that resources like this RunData object are closed after use 3 778
CloseResource Ensure that resources like this RunData object are closed after use 3 783
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 783
MethodArgumentCouldBeFinal Parameter 'tool' is not assigned and could be declared final 3 810
MethodArgumentCouldBeFinal Parameter 'dataObject' is not assigned and could be declared final 3 810
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'data' (lines '812'-'817'). 5 812–817
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '812'-'831'). 5 812–831
CloseResource Ensure that resources like this RunData object are closed after use 3 812
CloseResource Ensure that resources like this PipelineData object are closed after use 3 813
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'pipelineData' (lines '813'-'831'). 5 813–831
UnusedAssignment The initializer for variable 'pipelineData' is never used (overwritten on line 816) 3 813
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pipelineData' (lines '813'-'816'). 5 813–816
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '817'-'831'). 5 817–831
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 833
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 837

org/apache/turbine/services/pull/tools/ContentTool.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CONTENT_TOOL_PREFIX 3 54
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_KEY 3 62
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_DEFAULT 3 65
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_KEY 3 68
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_DEFAULT 3 71
RedundantFieldInitializer Avoid using redundant field initializer for 'wantEncoding' 3 74
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantEncoding field if you want a default access modifier 3 74
DefaultPackage Use explicit scoping instead of the default package private level 3 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 77
DefaultPackage Use explicit scoping instead of the default package private level 3 77
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantRelative field if you want a default access modifier 3 77
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 3 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 80
RedundantFieldInitializer Avoid using redundant field initializer for 'dataURI' 3 80
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 85–88
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 107
CloseResource Ensure that resources like this PipelineData object are closed after use 3 114
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 3 114
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 115
CloseResource Ensure that resources like this RunData object are closed after use 3 115
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 124–125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 125
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 158
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 175
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 191

org/apache/turbine/services/pull/tools/TemplateLink.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 61–613
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_PREFIX 3 63
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_KEY 3 66
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_DEFAULT 3 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 3 73
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 3 76
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 76
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 79
RedundantFieldInitializer Avoid using redundant field initializer for 'templateURI' 3 79
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 82
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 82
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 89–92
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 111
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 3 118
CloseResource Ensure that resources like this PipelineData object are closed after use 3 118
CloseResource Ensure that resources like this RunData object are closed after use 3 119
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 119
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 127–128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 128
LinguisticNaming Linguistics Antipattern - The setter 'setEncodeURLOff' should not return any type except void linguistically 3 164–168
LinguisticNaming Linguistics Antipattern - The setter 'setPage' should not return any type except void linguistically 3 176–182
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 176
LinguisticNaming Linguistics Antipattern - The setter 'setAction' should not return any type except void linguistically 3 204–209
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 204
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 221
LinguisticNaming Linguistics Antipattern - The setter 'setActionEvent' should not return any type except void linguistically 3 221–226
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 221
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 3 237–242
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 237
LinguisticNaming Linguistics Antipattern - The setter 'setReference' should not return any type except void linguistically 3 250–254
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 3 250
ShortVariable Avoid variables with short names like pp 3 282
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 282
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 295
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 295
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 308
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 308
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 321
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 321
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 334
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 334
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 347
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 347
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 360
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 360
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 373
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 373
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 386
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 386
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 399
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 399
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 412
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 412
ShortVariable Avoid variables with short names like pp 3 425
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 425
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 448
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 471
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 501
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 536

org/apache/turbine/services/pull/tools/UITool.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 65–390
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 68
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 132
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 160
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 174
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 188
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 206
MethodArgumentCouldBeFinal Parameter 'skin' is not assigned and could be declared final 3 206
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 225
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 225
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 255
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 274
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 292
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 322
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 322
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 340
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 340
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 352
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 364
CloseResource Ensure that resources like this PipelineData object are closed after use 3 378
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 3 378
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 379
CloseResource Ensure that resources like this RunData object are closed after use 3 379

org/apache/turbine/services/pull/util/DateFormatter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–119
LongVariable Avoid excessively long variable names like DATE_FORMAT_DEFAULT 3 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormat' 3 50
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 66–67
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 3 103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'110'). 5 105–110
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 110 and 115) 3 105
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'115'). 5 105–115
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 3 106
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'sdf' (lines '106'-'118'). 5 106–118

org/apache/turbine/services/pull/util/SessionData.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 39–118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 116

org/apache/turbine/services/rundata/DefaultTurbineRunData.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1–1384
CouplingBetweenObjects High amount of different objects as members denotes a high coupling 3 1–1384
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1–1384
GodClass Possible God Class (WMC=118, ATFD=78, TCC=1.417%) 3 80–1384
TooManyFields Too many fields 3 80–1384
CyclomaticComplexity The class 'DefaultTurbineRunData' has a total cyclomatic complexity of 118 (highest 4). 3 80–1384
ExcessiveClassLength Avoid really long classes. 3 80–1384
TooManyMethods This class has too many methods, consider refactoring it. 3 83–1384
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 105
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 126
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 132
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 135
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 138
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 144
LongVariable Avoid excessively long variable names like stackTraceException 3 144
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 151
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 154
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 154
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 166
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 171
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 172
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 186
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 192
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 194
ConstructorCallsOverridableMethod Overridable method 'recycle' called during object construction 1 208
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 227
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 229
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 230
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 231
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 232
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 233
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 235
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 236
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 238
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 241
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 242
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 243
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 244
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 245
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 246
LocalVariableCouldBeFinal Local variable 'parameters' could be declared final 3 263
LocalVariableCouldBeFinal Local variable 'request' could be declared final 3 264
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 266
LocalVariableCouldBeFinal Local variable 'cookies' could be declared final 3 283
LocalVariableCouldBeFinal Local variable 'request' could be declared final 3 284
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 286
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 324
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 358
MethodArgumentCouldBeFinal Parameter 'acl' is not assigned and could be declared final 3 371
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 373
LiteralsFirstInComparisons Position literals first in String comparisons 3 385
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 407
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 435
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 435
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 436
MethodArgumentCouldBeFinal Parameter 'layout' is not assigned and could be declared final 3 453
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 467
MethodArgumentCouldBeFinal Parameter 'layout' is not assigned and could be declared final 3 480
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 482
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 513
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 527
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 539
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 541
MethodArgumentCouldBeFinal Parameter 'encoding' is not assigned and could be declared final 3 561
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 579
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 593
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 594
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 606
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 607
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 616
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 628
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 630
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 650
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 660
MethodArgumentCouldBeFinal Parameter 'msgs' is not assigned and could be declared final 3 688
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 690
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 710
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 723
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 726
UselessParentheses Useless parentheses. 4 728
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 742
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 752
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 755
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 808
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 852
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 854
LocalVariableCouldBeFinal Local variable 'parameters' could be declared final 3 857
LocalVariableCouldBeFinal Local variable 'cookies' could be declared final 3 858
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 883
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 3 892
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 3 926
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 952
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 955
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 959
MethodArgumentCouldBeFinal Parameter 'contentType' is not assigned and could be declared final 3 972
UselessParentheses Useless parentheses. 4 986
MethodArgumentCouldBeFinal Parameter 'ruri' is not assigned and could be declared final 3 996
MethodArgumentCouldBeFinal Parameter 'statusCode' is not assigned and could be declared final 3 1018
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 1031
MethodArgumentCouldBeFinal Parameter 'err' is not assigned and could be declared final 3 1042
MethodArgumentCouldBeFinal Parameter 'contexts' is not assigned and could be declared final 3 1068
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1081
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1092
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1125
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 1196
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1197
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1213
MethodArgumentCouldBeFinal Parameter 'trace' is not assigned and could be declared final 3 1245
MethodArgumentCouldBeFinal Parameter 'exp' is not assigned and could be declared final 3 1245
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 1260
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1260
AvoidPrefixingMethodParameters Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 4 1318
MethodArgumentCouldBeFinal Parameter 'out' is not assigned and could be declared final 3 1318
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 3 1328
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1330
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 3 1338
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1340
MethodArgumentCouldBeFinal Parameter 'port' is not assigned and could be declared final 3 1348
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1350
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 3 1358
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1360
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 3 1368
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1370

org/apache/turbine/services/rundata/RunDataService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like PARAMETER_PARSER_KEY 3 54

org/apache/turbine/services/rundata/TurbineRunDataService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like DEFAULT_PARAMETER_PARSER 3 70
LongVariable Avoid excessively long variable names like DEFAULT_COOKIE_PARSER 3 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 84
RedundantFieldInitializer Avoid using redundant field initializer for 'pool' 3 84
RedundantFieldInitializer Avoid using redundant field initializer for 'parserService' 3 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 87
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 92–95
CyclomaticComplexity The method 'init()' has a cyclomatic complexity of 11. 3 103–168
UseShortArrayInitializer Array initialization can be written shorter 3 107–112
LocalVariableCouldBeFinal Local variable 'def' could be declared final 3 107–112
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 116
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 4 119
UseShortArrayInitializer Array initialization can be written shorter 3 121–126
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'plist' (lines '121'-'168'). 5 121–168
LocalVariableCouldBeFinal Local variable 'plist' could be declared final 3 121–126
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 127–148
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 127
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '130'-'130'). 5 130
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '130'-'168'). 5 130–168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '131'-'131'). 5 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '131'-'146'). 5 131–146
ShortVariable Avoid variables with short names like j 3 131
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'j' (lines '131'-'168'). 5 131–168
LocalVariableCouldBeFinal Local variable 'plistKey' could be declared final 3 132
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 136
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 136
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 138–142
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'config' (lines '143'-'168'). 5 143–168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '146'-'131'). 5 146–131
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'j' (lines '146'-'168'). 5 146–168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'j' (lines '146'-'146'). 5 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 151
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 159
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 3 192
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 3 193
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 213
CyclomaticComplexity The method 'getRunData(String, HttpServletRequest, HttpServletResponse, ServletConfig)' has a cyclomatic complexity of 12. 3 213–287
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 3 214
MethodArgumentCouldBeFinal Parameter 'res' is not assigned and could be declared final 3 215
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 216
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 218
LocalVariableCouldBeFinal Local variable 'cfg' could be declared final 3 233
LocalVariableCouldBeFinal Local variable 'runDataClazz' could be declared final 3 242
LocalVariableCouldBeFinal Local variable 'parameterParserClazz' could be declared final 3 243
LongVariable Avoid excessively long variable names like parameterParserClazz 3 243
LocalVariableCouldBeFinal Local variable 'cookieParserClazz' could be declared final 3 244
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 248
ShortVariable Avoid variables with short names like pp 3 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 249
LocalVariableCouldBeFinal Local variable 'cp' could be declared final 3 252
ShortVariable Avoid variables with short names like cp 3 252
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 253
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 276
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 277
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 277
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 280
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 280
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 281
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 281
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 296
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 303
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 312
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 312

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Priority Line
StdCyclomaticComplexity The class 'AbstractJobEntry' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 3 35–478
ModifiedCyclomaticComplexity The class 'AbstractJobEntry' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 3 35–478
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 38
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
RedundantFieldInitializer Avoid using redundant field initializer for 'jobIsActive' 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
RedundantFieldInitializer Avoid using redundant field initializer for 'runtime' 3 44
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 94
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 95
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 96
ShortVariable Avoid variables with short names like wd 3 97
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 97
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 98
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 98
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 98
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 99
ConstructorCallsOverridableMethod Overridable method 'calcRunTime' called during object construction 1 117
ShortVariable Avoid variables with short names like je 3 129
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 129
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 3 140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 187
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'schedrun' (lines '210'-'292'). 5 210–292
LocalVariableCouldBeFinal Local variable 'schedrun' could be declared final 3 210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'now' (lines '211'-'292'). 5 211–292
LocalVariableCouldBeFinal Local variable 'now' could be declared final 3 211
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 225
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 238
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 244
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 258
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 264
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 277
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 283
StdCyclomaticComplexity The method 'evaluateJobType' has a Standard Cyclomatic Complexity of 10. 3 304–375
CyclomaticComplexity The method 'evaluateJobType()' has a cyclomatic complexity of 21. 3 304–375
ModifiedCyclomaticComplexity The method 'evaluateJobType' has a Modified Cyclomatic Complexity of 10. 3 304–375
AvoidDuplicateLiterals The String literal "Error in JobEntry. Bad Job parameter." appears 5 times in this file; the first occurrence is on line 323 3 323
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 326
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 337
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 349
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 361
ShortVariable Avoid variables with short names like v 3 391
ShortVariable Avoid variables with short names like v 3 405
ShortVariable Avoid variables with short names like v 3 419
ShortVariable Avoid variables with short names like v 3 433
ShortVariable Avoid variables with short names like v 3 447
ShortVariable Avoid variables with short names like v 3 461
ShortVariable Avoid variables with short names like v 3 477

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 38–371
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 40
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 40
RedundantFieldInitializer Avoid using redundant field initializer for 'scheduleQueue' 3 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 43
RedundantFieldInitializer Avoid using redundant field initializer for 'enabled' 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
CallSuperInConstructor It is a good practice to call super() in a constructor 3 57–61
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 3 79
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 109
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 117
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 117
ShortVariable Avoid variables with short names like wd 3 117
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 140
ShortVariable Avoid variables with short names like je 3 140
ShortVariable Avoid variables with short names like je 3 154
ShortVariable Avoid variables with short names like je 3 165
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 3 184
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 204–208
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 214–223
LocalVariableCouldBeFinal Local variable 'thread' could be declared final 3 217
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 217
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 232–235
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 232
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 240–243
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 242
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 251–274
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 261
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 3 271
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 283–324
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 290
ShortVariable Avoid variables with short names like je 3 290
LocalVariableCouldBeFinal Local variable 'now' could be declared final 3 299
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 300
LocalVariableCouldBeFinal Local variable 'when' could be declared final 3 300
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 312
AtLeastOneConstructor Each class should declare at least one constructor 3 331–370
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '339'-'347'). 5 339–347
ShortVariable Avoid variables with short names like je 3 344
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 344
ConfusingTernary Avoid if (x != y) ..; else ..; 3 345–357
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '347'-'347'). 5 347
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 347
ShortVariable Avoid variables with short names like wt 3 350
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 350
LocalVariableCouldBeFinal Local variable 'wt' could be declared final 3 350
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 351
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 351
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 351
LocalVariableCouldBeFinal Local variable 'helper' could be declared final 3 351
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 360

org/apache/turbine/services/schedule/JobEntry.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like v 3 74
ShortVariable Avoid variables with short names like v 3 88

org/apache/turbine/services/schedule/JobEntryNonPersistent.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 32
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 33
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 35
ShortVariable Avoid variables with short names like wd 3 35
FieldNamingConventions The field name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 36
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 3 38
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 81
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 82
ShortVariable Avoid variables with short names like wd 3 82
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 83
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 83
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 83
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 96
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 103
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 107
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 3 119
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 1 119
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 1 119
ShortVariable Avoid variables with short names like v 3 141
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 141
ShortVariable Avoid variables with short names like v 3 163
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 163
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 185
ShortVariable Avoid variables with short names like v 3 185
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 207
ShortVariable Avoid variables with short names like v 3 207
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 229
ShortVariable Avoid variables with short names like v 3 229
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 251
ShortVariable Avoid variables with short names like v 3 251
ShortVariable Avoid variables with short names like v 3 273
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 273

org/apache/turbine/services/schedule/JobEntryQuartz.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 3 47
ImmutableField Private field 'active' could be made final; it is only initialized in the declaration or constructor. 3 48
LongVariable Avoid excessively long variable names like DEFAULT_JOB_GROUP_NAME 3 53
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'jobDetail' is not assigned and could be declared final 3 81
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 3 81
ConstructorCallsOverridableMethod Overridable method 'setTask' called during object construction 1 84
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 1 95
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 3 95
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 1 95
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 117
ShortVariable Avoid variables with short names like v 3 117
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 139
ShortVariable Avoid variables with short names like v 3 139
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 3 155
ShortVariable Avoid variables with short names like o 3 172
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 3 172
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 3 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 219
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 235
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 237
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 250
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 252

org/apache/turbine/services/schedule/JobQueue.java

Rule Violation Priority Line
UnusedAssignment The field initializer for 'queue' is never used (overwritten on line 49) 3 42
RedundantFieldInitializer Avoid using redundant field initializer for 'queue' 3 42
ImmutableField Private field 'queue' could be made final; it is only initialized in the declaration or constructor. 3 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
LooseCoupling Avoid using implementation types like 'Vector'; use the interface instead 3 42
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 3 42
UseArrayListInsteadOfVector Use ArrayList instead of Vector 3 49
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 60
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 62
ShortVariable Avoid variables with short names like je 3 76
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 76
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'index' (lines '78'-'82'). 5 78–82
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 87
LooseCoupling Avoid using implementation types like 'Vector'; use the interface instead 3 101
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 3 101
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 103
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 3 105
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 105
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 118
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 118–122
ShortVariable Avoid variables with short names like je 3 118
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 130–138
MethodArgumentCouldBeFinal Parameter 'jobEntries' is not assigned and could be declared final 3 130
ShortVariable Avoid variables with short names like je 3 145
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 145–149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 145
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 157–163
ShortVariable Avoid variables with short names like je 3 157
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 157
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 171
ShortVariable Avoid variables with short names like je 3 171
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 171–176
LocalVariableCouldBeFinal Local variable 'aComparator' could be declared final 3 184–188
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'aComparator' (lines '184'-'191'). 5 184–191

org/apache/turbine/services/schedule/QuartzSchedulerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 49–413
TooManyMethods This class has too many methods, consider refactoring it. 3 52–413
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 54
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 54
RedundantFieldInitializer Avoid using redundant field initializer for 'enabled' 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 72
ShortVariable Avoid variables with short names like qs 3 73
LocalVariableCouldBeFinal Local variable 'qs' could be declared final 3 73–74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 73–74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 103
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 103
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 103
ShortVariable Avoid variables with short names like wd 3 103
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 103
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107–109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107–109
ShortVariable Avoid variables with short names like jd 3 107
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 3 107–109
LocalVariableCouldBeFinal Local variable 'csb' could be declared final 3 111
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113–117
LocalVariableCouldBeFinal Local variable 't' could be declared final 3 113–117
ShortVariable Avoid variables with short names like t 3 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113–117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113–117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113–117
LocalVariableCouldBeFinal Local variable 'jeq' could be declared final 3 119
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'jeq' 3 121
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 140
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 140
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 140
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 140
ShortVariable Avoid variables with short names like wd 3 140
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 140
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 140
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 140
ShortVariable Avoid variables with short names like sb 3 142
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 142
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 143
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 144
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 3 175
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 178
ShortVariable Avoid variables with short names like je 3 196
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 196
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 3 202
ShortVariable Avoid variables with short names like jq 3 202
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 203
ShortVariable Avoid variables with short names like je 3 218
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 218
ShortVariable Avoid variables with short names like jq 3 223
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 3 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 224
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 224
ShortVariable Avoid variables with short names like je 3 240
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 240
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 3 246
ShortVariable Avoid variables with short names like jq 3 246
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 247
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 3 263
LocalVariableCouldBeFinal Local variable 'groupMatcher' could be declared final 3 267
LocalVariableCouldBeFinal Local variable 'jobKeys' could be declared final 3 268
LocalVariableCouldBeFinal Local variable 'jk' could be declared final 3 269
LocalVariableCouldBeFinal Local variable 'triggers' could be declared final 3 271
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 273
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 3 277
ShortVariable Avoid variables with short names like jd 3 277
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 278
LocalVariableCouldBeFinal Local variable 'job' could be declared final 3 278
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 3 298
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 318–322
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 328–340
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 348–369
ConfusingTernary Avoid if (x != y) ..; else ..; 3 355–362
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 3 361
ShortVariable Avoid variables with short names like je 3 377
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 377
MethodArgumentCouldBeFinal Parameter 'jd' is not assigned and could be declared final 3 409
MethodArgumentCouldBeFinal Parameter 'trigger' is not assigned and could be declared final 3 409
ShortVariable Avoid variables with short names like jd 3 409
LocalVariableCouldBeFinal Local variable 'job' could be declared final 3 410
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'job' 3 411

org/apache/turbine/services/schedule/ScheduleService.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like wd 3 84
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 85
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 85
ShortVariable Avoid variables with short names like je 3 104
ShortVariable Avoid variables with short names like je 3 113
ShortVariable Avoid variables with short names like je 3 122

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–113
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 41
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 53
GuardLogStatement Logger calls should be surrounded by log level guards. 2 58–59
MethodArgumentCouldBeFinal Parameter 'jobId' is not assigned and could be declared final 3 97
ShortVariable Avoid variables with short names like je 3 99
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'je' (lines '99'-'103'). 5 99–103

org/apache/turbine/services/schedule/TorqueSchedulerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–177
LocalVariableCouldBeFinal Local variable 'jobsTorque' could be declared final 3 52
LocalVariableCouldBeFinal Local variable 'job' could be declared final 3 54
ShortVariable Avoid variables with short names like wd 3 71
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 71
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 71
LocalVariableCouldBeFinal Local variable 'jet' could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 3 94
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 98
ShortVariable Avoid variables with short names like je 3 98
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 116
ShortVariable Avoid variables with short names like je 3 116
LocalVariableCouldBeFinal Local variable 'c' could be declared final 3 121
ShortVariable Avoid variables with short names like c 3 121
ShortVariable Avoid variables with short names like je 3 145
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 145

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 68–179
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 76
LocalVariableCouldBeFinal Local variable 'jobProps' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'jobs' (lines '78'-'116'). 5 78–116
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 3 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 82
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 84–112
LocalVariableCouldBeFinal Local variable 'jobName' could be declared final 3 86
LocalVariableCouldBeFinal Local variable 'jobPrefix' could be declared final 3 87
LocalVariableCouldBeFinal Local variable 'jobId' could be declared final 3 89
LocalVariableCouldBeFinal Local variable 'sec' could be declared final 3 97
LocalVariableCouldBeFinal Local variable 'min' could be declared final 3 98
LocalVariableCouldBeFinal Local variable 'hr' could be declared final 3 99
ShortVariable Avoid variables with short names like hr 3 99
LocalVariableCouldBeFinal Local variable 'wkday' could be declared final 3 100
LocalVariableCouldBeFinal Local variable 'dayOfMonth' could be declared final 3 101
ShortVariable Avoid variables with short names like je 3 103
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 103–109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 110
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 122
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 122
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 122
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 122
ShortVariable Avoid variables with short names like wd 3 122
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 3 135
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 138
ShortVariable Avoid variables with short names like je 3 138
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 149
ShortVariable Avoid variables with short names like je 3 149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 163
ShortVariable Avoid variables with short names like je 3 163
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 174

org/apache/turbine/services/schedule/WorkerThread.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'je' 3 42
ImmutableField Private field 'je' could be made final; it is only initialized in the declaration or constructor. 3 42
UnusedAssignment The field initializer for 'je' is never used (overwritten on line 54) 3 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
ShortVariable Avoid variables with short names like je 3 42
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 45
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 45
ShortVariable Avoid variables with short names like je 3 52
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 77
MethodArgumentCouldBeFinal Parameter 'state' is not assigned and could be declared final 3 97
UnnecessaryModifier Unnecessary modifier 'final' on method 'logStateChange': private methods cannot be overridden 3 97–101

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1–1125
AtLeastOneConstructor Each class should declare at least one constructor 3 72–1125
ExcessiveClassLength Avoid really long classes. 3 72–1125
GodClass Possible God Class (WMC=88, ATFD=38, TCC=8.956%) 3 72–1125
CyclomaticComplexity The class 'DefaultSecurityService' has a total cyclomatic complexity of 88 (highest 4). 3 72–1125
TooManyMethods This class has too many methods, consider refactoring it. 3 75–1125
RedundantFieldInitializer Avoid using redundant field initializer for 'readerCount' 3 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 77
RedundantFieldInitializer Avoid using redundant field initializer for 'userManager' 3 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 83
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 92
SingularField Perhaps 'backend' could be replaced by a local variable. 3 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 94
UnusedPrivateField Avoid unused private fields such as 'backend'. 3 94
RedundantFieldInitializer Avoid using redundant field initializer for 'globalGroup' 3 99
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 99
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 102
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 102
LocalVariableCouldBeFinal Local variable 'manager' could be declared final 3 115
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 120
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 126–128
LongVariable Avoid excessively long variable names like userManagerClassName 3 126
LocalVariableCouldBeFinal Local variable 'userManagerClassName' could be declared final 3 126–128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 133
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '158'-'166'). 5 158–166
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 178
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 184
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '184'-'192'). 5 184–192
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '207'-'214'). 5 207–214
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 209
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 226
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '232'-'239'). 5 232–239
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 234
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '254'-'261'). 5 254–261
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 256
MethodArgumentCouldBeFinal Parameter 'permName' is not assigned and could be declared final 3 272
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '278'-'285'). 5 278–285
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 280
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '300'-'307'). 5 300–307
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 302
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 319
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '325'-'332'). 5 325–332
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 327
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 356
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 359
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 373
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 376
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 393
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 393
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 397
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 411
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 414
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 429
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 442
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 444
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 457
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 460
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 476
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 479
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 493
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 493
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 496
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 508
AvoidDuplicateLiterals The String literal "user is null" appears 4 times in this file; the first occurrence is on line 512 3 512
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 516
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 531
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 3 531
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 3 532
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 536
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 554
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 554
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 557
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 566–569
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 577–581
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 3 580
ShortVariable Avoid variables with short names like g 3 644
LocalVariableCouldBeFinal Local variable 'g' could be declared final 3 644
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 658
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 675
ShortVariable Avoid variables with short names like id 3 675
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 691
LocalVariableCouldBeFinal Local variable 'role' could be declared final 3 694
ShortVariable Avoid variables with short names like id 3 712
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 712
LocalVariableCouldBeFinal Local variable 'role' could be declared final 3 716
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 734
ShortVariable Avoid variables with short names like id 3 751
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 751
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 811
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 814
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 833
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 833
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 833
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 854
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 854
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 854
MethodArgumentCouldBeFinal Parameter 'newRole' is not assigned and could be declared final 3 876
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 876
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 876
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 893
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 912
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 912
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 928
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 928
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 945
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 967
MethodArgumentCouldBeFinal Parameter 'cascadeDelete' is not assigned and could be declared final 3 967
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 983
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 998
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 1013
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 1028
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 1043
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 1057
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 1072
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1088
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 1088
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 1104
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1104
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 1120
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1120

org/apache/turbine/services/security/DefaultUserManager.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 76–537
TooManyMethods This class has too many methods, consider refactoring it. 3 77–537
RedundantFieldInitializer Avoid using redundant field initializer for 'umDelegate' 3 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 79
RedundantFieldInitializer Avoid using redundant field initializer for 'factoryService' 3 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 81
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 88
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 88
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 98
ShortVariable Avoid variables with short names like u 3 101
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 101
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 113
UseShortArrayInitializer Array initialization can be written shorter 3 117
LocalVariableCouldBeFinal Local variable 'params' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 3 118
UseShortArrayInitializer Array initialization can be written shorter 3 118
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 119
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 121
MethodArgumentCouldBeFinal Parameter 'userWrapperClass2' is not assigned and could be declared final 3 143
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 154
LocalVariableCouldBeFinal Local variable 'manager' could be declared final 3 156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 157
LocalVariableCouldBeFinal Local variable 'userWrapperClass' could be declared final 3 159–161
LocalVariableCouldBeFinal Local variable 'turbineUser' could be declared final 3 169
UseShortArrayInitializer Array initialization can be written shorter 3 171
LocalVariableCouldBeFinal Local variable 'params' could be declared final 3 171
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 3 172
UseShortArrayInitializer Array initialization can be written shorter 3 172
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 179
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 196
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 200
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 215
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 233
ShortVariable Avoid variables with short names like u 3 236
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 236
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 255
LocalVariableCouldBeFinal Local variable 'uset' could be declared final 3 258
LocalVariableCouldBeFinal Local variable 'userList' could be declared final 3 259
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 261
ShortVariable Avoid variables with short names like tu 3 263
LocalVariableCouldBeFinal Local variable 'tu' could be declared final 3 263
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 287
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 287
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 291
ShortVariable Avoid variables with short names like u 3 291
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 306
AvoidDuplicateLiterals The String literal "user is null" appears 6 times in this file; the first occurrence is on line 310 3 310
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 316
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 337
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 358
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 358
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 375
MethodArgumentCouldBeFinal Parameter 'initialPassword' is not assigned and could be declared final 3 375
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 392
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 3 415
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 415
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 3 416
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 444
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 444
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 464
ShortVariable Avoid variables with short names like u 3 464
MethodArgumentCouldBeFinal Parameter 'u' is not assigned and could be declared final 3 478
ShortVariable Avoid variables with short names like u 3 478
ShortVariable Avoid variables with short names like u 3 496
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 496
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 514
ShortVariable Avoid variables with short names like u 3 516
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 516
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 530

org/apache/turbine/services/security/SecurityService.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1–757
TooManyMethods This class has too many methods, consider refactoring it. 3 66–757
LongVariable Avoid excessively long variable names like USER_MANAGER_DEFAULT 3 80
LongVariable Avoid excessively long variable names like USER_WRAPPER_DEFAULT 3 93
ShortVariable Avoid variables with short names like u 3 272
ShortVariable Avoid variables with short names like id 3 538
ShortVariable Avoid variables with short names like id 3 568
ShortVariable Avoid variables with short names like id 3 598

org/apache/turbine/services/security/UserManager.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48–301
ShortVariable Avoid variables with short names like u 3 258

org/apache/turbine/services/security/passive/PassiveUserManager.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 46–365
TooManyMethods This class has too many methods, consider refactoring it. 3 47–365
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 69
AvoidDuplicateLiterals The String literal "PassiveUserManager knows no users" appears 10 times in this file; the first occurrence is on line 72 3 72
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 124
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 147
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 147
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 165
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 184
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'initialPassword' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 237
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 3 257
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 257
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 3 258
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 281
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 281
ShortVariable Avoid variables with short names like u 3 311
MethodArgumentCouldBeFinal Parameter 'u' is not assigned and could be declared final 3 311
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 346
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 361

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 51–254
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 55
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
RedundantFieldInitializer Avoid using redundant field initializer for 'servletContext' 3 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
RedundantFieldInitializer Avoid using redundant field initializer for 'servletConfig' 3 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 78
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 99
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'url' (lines '102'-'106'). 5 102–106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
EmptyCatchBlock Avoid empty catch blocks 3 117–120
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 133
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 137
ShortVariable Avoid variables with short names like is 3 140
UnusedAssignment The initializer for variable 'is' is never used (overwritten on line 141) 3 140
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '140'-'141'). 5 140–141
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 154
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 162
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 250

org/apache/turbine/services/session/SessionListener.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 61–141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 127
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 139

org/apache/turbine/services/session/SessionTool.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38–141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
ShortVariable Avoid variables with short names like o 3 48
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 3 48
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 75
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 125
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 137

org/apache/turbine/services/session/TurbineSessionService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55–222
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 92
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111
LocalVariableCouldBeFinal Local variable 'session' could be declared final 3 128
ShortVariable Avoid variables with short names like u 3 130
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 131
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 147
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 154
MethodArgumentCouldBeFinal Parameter 'sessionId' is not assigned and could be declared final 3 169
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 182
LocalVariableCouldBeFinal Local variable 'sessions' could be declared final 3 184
LocalVariableCouldBeFinal Local variable 'session' could be declared final 3 185
ShortVariable Avoid variables with short names like u 3 187
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 187
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 217

org/apache/turbine/services/template/BaseTemplateEngineService.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 38–145
AtLeastOneConstructor Each class should declare at least one constructor 3 38–145
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 53
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 3 59
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 70
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 3 97
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 99
LongVariable Avoid excessively long variable names like fileExtensionAssociations 3 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fileExtensionAssociations' (lines '111'-'112'). 5 111–112
LocalVariableCouldBeFinal Local variable 'copyParams' could be declared final 3 124–132
LocalVariableCouldBeFinal Local variable 'copyParam' could be declared final 3 134

org/apache/turbine/services/template/TemplateEngineService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like TEMPLATE_EXTENSIONS 3 35
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_EXTENSION 3 37
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION 3 45
LongVariable Avoid excessively long variable names like DEFAULT_ERROR_SCREEN 3 47
LongVariable Avoid excessively long variable names like DEFAULT_LAYOUT_TEMPLATE 3 49
LongVariable Avoid excessively long variable names like DEFAULT_SCREEN_TEMPLATE 3 51
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION_TEMPLATE 3 53
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 60
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 60

org/apache/turbine/services/template/TemplateService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_KEY 3 49
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_VALUE 3 52
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_KEY 3 55
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_VALUE 3 58
LongVariable Avoid excessively long variable names like EXTENSION_SEPARATOR 3 61
LongVariable Avoid excessively long variable names like TEMPLATE_PARTS_SEPARATOR 3 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 218
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 229
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 240
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 251
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 262
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 273
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 285
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 299

org/apache/turbine/services/template/TurbineTemplateService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1–821
GodClass Possible God Class (WMC=49, ATFD=74, TCC=21.675%) 3 180–821
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 185
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 185
LongVariable Avoid excessively long variable names like LAYOUT_TEMPLATE_KEY 3 200
LongVariable Avoid excessively long variable names like LAYOUT_TEMPLATE_NAME 3 203
LongVariable Avoid excessively long variable names like SCREEN_TEMPLATE_KEY 3 206
LongVariable Avoid excessively long variable names like SCREEN_TEMPLATE_NAME 3 209
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE_KEY 3 212
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE_NAME 3 215
RedundantFieldInitializer Avoid using redundant field initializer for 'mapperRegistry' 3 221
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 221
RedundantFieldInitializer Avoid using redundant field initializer for 'useCache' 3 234
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 234
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 237
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 240
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 245
LongVariable Avoid excessively long variable names like templateEngineRegistry 3 255
RedundantFieldInitializer Avoid using redundant field initializer for 'templateEngineRegistry' 3 255
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 255
CallSuperInConstructor It is a good practice to call super() in a constructor 3 260–263
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 260–263
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 281–282
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 284–285
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 289–290
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 334
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 338
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 3 341
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 356
ShortVariable Avoid variables with short names like sb 3 356
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 435
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 449
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 463
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 477
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 491
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 504
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 506
ShortVariable Avoid variables with short names like pp 3 506
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 507
LocalVariableCouldBeFinal Local variable 'template' could be declared final 3 507
ConfusingTernary Avoid if (x != y) ..; else ..; 3 508
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 519
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 521
ShortVariable Avoid variables with short names like pp 3 521
LocalVariableCouldBeFinal Local variable 'template' could be declared final 3 522
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 522
ConfusingTernary Avoid if (x != y) ..; else ..; 3 523
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 535
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 550
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 565
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 581
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 596
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 612
MethodArgumentCouldBeFinal Parameter 'templatePaths' is not assigned and could be declared final 3 651
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 651
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 3 653
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 655
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 657
MethodArgumentCouldBeFinal Parameter 'service' is not assigned and could be declared final 3 670
LocalVariableCouldBeFinal Local variable 'exts' could be declared final 3 672
LocalVariableCouldBeFinal Local variable 'ext' could be declared final 3 674
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 688
MethodArgumentCouldBeFinal Parameter 'templateKey' is not assigned and could be declared final 3 701
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 701
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 715
ExcessiveMethodLength Avoid really long methods. 3 715–820
CyclomaticComplexity The method 'initMapper(Configuration)' has a cyclomatic complexity of 10. 3 715–820
UseShortArrayInitializer Array initialization can be written shorter 3 724–727
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperNames' (lines '724'-'820'). 5 724–820
LocalVariableCouldBeFinal Local variable 'mapperNames' could be declared final 3 724–727
LocalVariableCouldBeFinal Local variable 'mapperKeys' could be declared final 3 729–732
UseShortArrayInitializer Array initialization can be written shorter 3 729–732
UseShortArrayInitializer Array initialization can be written shorter 3 734–742
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperClasses' (lines '734'-'820'). 5 734–820
LocalVariableCouldBeFinal Local variable 'mapperClasses' could be declared final 3 734–742
ShortVariable Avoid variables with short names like ab 3 744
LocalVariableCouldBeFinal Local variable 'ab' could be declared final 3 744–745
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'ab' (lines '744'-'820'). 5 744–820
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 744–745
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperCacheSize' (lines '747'-'753'). 5 747–753
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperCacheSize' (lines '747'-'820'). 5 747–820
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '748'-'757'). 5 748–757
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '748'-'752'). 5 748–752
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperCacheSize' (lines '753'-'820'). 5 753–820
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperCacheSize' (lines '753'-'753'). 5 753
ConfusingTernary Avoid if (x != y) ..; else ..; 3 753
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '757'-'758'). 5 757–758
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 757
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'mapperLoader' (lines '758'-'759'). 5 758–759
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 758
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 759
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperLoader' (lines '759'-'820'). 5 759–820
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperDefaultProperty' (lines '761'-'820'). 5 761–820
LocalVariableCouldBeFinal Local variable 'mapperDefaultProperty' could be declared final 3 761–769
LongVariable Avoid excessively long variable names like mapperDefaultProperty 3 761
UseShortArrayInitializer Array initialization can be written shorter 3 761–769
UseShortArrayInitializer Array initialization can be written shorter 3 771
LocalVariableCouldBeFinal Local variable 'mapperSeparator' could be declared final 3 771
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperSeparator' (lines '771'-'820'). 5 771–820
UseShortArrayInitializer Array initialization can be written shorter 3 773–777
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'mapperPrefix' (lines '773'-'820'). 5 773–820
LocalVariableCouldBeFinal Local variable 'mapperPrefix' could be declared final 3 773–777
LocalVariableCouldBeFinal Local variable 'mapperProperty' could be declared final 3 781
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 781
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 782
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 783
LocalVariableCouldBeFinal Local variable 'mapperClass' could be declared final 3 786–787
ShortVariable Avoid variables with short names like tm 3 791
UnusedAssignment The initializer for variable 'tm' is never used (overwritten on line 796) 3 791
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tm' (lines '791'-'796'). 5 791–796
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 3 795
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 795
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'tm' (lines '796'-'820'). 5 796–820
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 803
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 804
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 805
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 806

org/apache/turbine/services/template/mapper/BaseMapper.java

Rule Violation Priority Line
DataClass The class 'BaseMapper' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=8, WMC=21) 3 40–226
AbstractNaming Abstract classes should be named AbstractXXX 3 40–226
RedundantFieldInitializer Avoid using redundant field initializer for 'useCache' 3 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
RedundantFieldInitializer Avoid using redundant field initializer for 'templateCache' 3 49
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 66–69
MethodArgumentCouldBeFinal Parameter 'cacheSize' is not assigned and could be declared final 3 84
MethodArgumentCouldBeFinal Parameter 'useCache' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'defaultProperty' is not assigned and could be declared final 3 120
MethodArgumentCouldBeFinal Parameter 'separator' is not assigned and could be declared final 3 138
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 170
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 170
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 171
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 171
UselessParentheses Useless parentheses. 4 173
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 175
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 178–179
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 178–179
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 3 178–179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 182
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 193
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 197
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 202
LocalVariableCouldBeFinal Local variable 'res' could be declared final 3 205

org/apache/turbine/services/template/mapper/BaseTemplateMapper.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 37–117
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 48–51
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 83
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 88–89
LocalVariableCouldBeFinal Local variable 'resBuf' could be declared final 3 93
LongVariable Avoid excessively long variable names like templateComponents 3 95
LocalVariableCouldBeFinal Local variable 'templateComponents' could be declared final 3 95
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 106

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'loader' 3 60
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 63
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 63
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 70–73
CallSuperInConstructor It is a good practice to call super() in a constructor 3 70–73
MethodArgumentCouldBeFinal Parameter 'loader' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 102
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 107–110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 121
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 3 121
UselessParentheses Useless parentheses. 4 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 127
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '127'-'178'). 5 127–178
LocalVariableCouldBeFinal Local variable 'pkg' could be declared final 3 131
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 3 132
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 132
UselessParentheses Useless parentheses. 4 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 151
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 157
EmptyCatchBlock Avoid empty catch blocks 3 157–160

org/apache/turbine/services/template/mapper/DirectMapper.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 43–46
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 57
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 65
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 3 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 66
UselessParentheses Useless parentheses. 4 66

org/apache/turbine/services/template/mapper/DirectTemplateMapper.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 44–47
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 58
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 60–61

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Priority Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 55
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 55
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 62–65
CallSuperInConstructor It is a good practice to call super() in a constructor 3 62–65
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 75
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 79–82
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 87
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 94
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 94
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 98
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 102
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 3 102
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '107'-'166'). 5 107–166
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 107
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 3 111
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 115
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 3 115
UselessParentheses Useless parentheses. 4 123
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 128
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 3 128
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 141
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '146'-'166'). 5 146–166

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Priority Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 51
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 51
CallSuperInConstructor It is a good practice to call super() in a constructor 3 58–61
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 58–61
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 71
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 75–78
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 83
UnusedAssignment The updated value of variable 'componentSize' is never used 3 84
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 89
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 94
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 3 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 102
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '102'-'155'). 5 102–155
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 3 106
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 3 110
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 110
UselessParentheses Useless parentheses. 4 118
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 123
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 3 123
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 136
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '141'-'155'). 5 141–155

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 47–50
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 60
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 62
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 66
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 66
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 3 68
LocalVariableCouldBeFinal Local variable 'testPath' could be declared final 3 71
UselessParentheses Useless parentheses. 4 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 79

org/apache/turbine/services/ui/TurbineUIService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 57–531
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 62
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 62
LongVariable Avoid excessively long variable names like SKIN_PROPERTY_DEFAULT 3 108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 115
LongVariable Avoid excessively long variable names like DEFAULT_SKIN_CSS_FILE 3 126
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 131
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 136
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 141
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 3 147
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 147
ImmutableField Private field 'skins' could be made final; it is only initialized in the declaration or constructor. 3 152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 152
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 169
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 187
LocalVariableCouldBeFinal Local variable 'skinProperties' could be declared final 3 189
ConfusingTernary Avoid if (x != y) ..; else ..; 3 190
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 208
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 208
LocalVariableCouldBeFinal Local variable 'skinProperties' could be declared final 3 210
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 211
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 227
LocalVariableCouldBeFinal Local variable 'skinsDir' could be declared final 3 240
LocalVariableCouldBeFinal Local variable 'directory' could be declared final 3 242
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 261
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 280
LongVariable Avoid excessively long variable names like defaultSkinProperties 3 282
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'defaultSkinProperties' (lines '282'-'286'). 5 282–286
LocalVariableCouldBeFinal Local variable 'skinProperties' could be declared final 3 290
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 292
ShortVariable Avoid variables with short names like sb 3 292
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 293
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 294
ShortVariable Avoid variables with short names like is 3 298
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 304
ConfusingTernary Avoid if (x != y) ..; else ..; 3 307–322
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 311
ConfusingTernary Avoid if (x != y) ..; else ..; 3 313–322
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 316
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 321
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 343–344
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 361
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 361
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 361
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 374
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 374
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 393
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 393
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 406
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 425
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 425
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 426
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 439
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 439
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 448
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 452
LocalVariableCouldBeFinal Local variable 'len' could be declared final 3 452
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 454
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 454
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 459
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 477
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 477
MethodArgumentCouldBeFinal Parameter 'subDir' is not assigned and could be declared final 3 478
MethodArgumentCouldBeFinal Parameter 'resourceName' is not assigned and could be declared final 3 478
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 480
ShortVariable Avoid variables with short names like sb 3 480
ShortVariable Avoid variables with short names like du 3 488
LocalVariableCouldBeFinal Local variable 'du' could be declared final 3 488
LocalVariableCouldBeFinal Local variable 'cfg' could be declared final 3 501
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 503
LocalVariableCouldBeFinal Local variable 'pullService' could be declared final 3 504
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 504
ShortVariable Avoid variables with short names like sb 3 507
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 507
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 508
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 508
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 509
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 511
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 515
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 516
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 517

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44–152
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 49
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 49
FieldNamingConventions The constant name 'counter' doesn't match '[A-Z][A-Z_0-9]*' 1 56
VariableNamingConventions Variables that are final and static should be all capitals, 'counter' is not all capitals. 1 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
ShortVariable Avoid variables with short names like md 3 79
LocalVariableCouldBeFinal Local variable 'md' could be declared final 3 79
LocalVariableCouldBeFinal Local variable 'bytesId' could be declared final 3 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 88
LocalVariableCouldBeFinal Local variable 'current' could be declared final 3 130
ShortVariable Avoid variables with short names like id 3 131
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 135
UseUnderscoresInNumericLiterals Number 100000000 should separate every third digit with an underscore 3 135

org/apache/turbine/services/urlmapper/MappedTemplateLink.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 50–118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56

org/apache/turbine/services/urlmapper/TurbineURLMapperService.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1–325
AtLeastOneConstructor Each class should declare at least one constructor 3 72–325
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 79
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 79
LongVariable Avoid excessively long variable names like DEFAULT_CONFIGURATION_FILE 3 84
LongVariable Avoid excessively long variable names like CONFIGURATION_FILE_KEY 3 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 94
LongVariable Avoid excessively long variable names like NAMED_GROUPS_PATTERN 3 99
LongVariable Avoid excessively long variable names like MULTI_SLASH_PATTERN 3 104
LongVariable Avoid excessively long variable names like CONTEXT_PATH_PARAMETER 3 109
LongVariable Avoid excessively long variable names like WEBAPP_ROOT_PARAMETER 3 114
LongVariable Avoid excessively long variable names like DEFAULT_PARAMETERS 3 119
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 131
LocalVariableCouldBeFinal Local variable 'pathInfo' could be declared final 3 138
LocalVariableCouldBeFinal Local variable 'queryData' could be declared final 3 139
LocalVariableCouldBeFinal Local variable 'uriParameterMap' could be declared final 3 143–149
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'uriParameterMap' (lines '143'-'209'). 5 143–209
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 144
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 144–149
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 144
LocalVariableCouldBeFinal Local variable 'urlMap' could be declared final 3 151
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 153
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 3 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 156
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 156
LocalVariableCouldBeFinal Local variable 'entryKeys' could be declared final 3 156
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158–161
LocalVariableCouldBeFinal Local variable 'implicitKeysFound' could be declared final 3 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158–161
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158–161
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 3 167
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 167
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 168
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 168
ShortVariable Avoid variables with short names like sb 3 168
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 170
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 172
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 177
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 180
LocalVariableCouldBeFinal Local variable 'ignore' could be declared final 3 183–184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 183–184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 183–184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 183–184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 185–187
ConfusingTernary Avoid if (x != y) ..; else ..; 3 187
UselessParentheses Useless parentheses. 4 187
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 194
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 196–199
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 202
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 202
ShortVariable Avoid variables with short names like pp 3 218
AvoidReassigningParameters Avoid reassigning parameters such as 'url' 2 218
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 218
LocalVariableCouldBeFinal Local variable 'urlMap' could be declared final 3 220
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 3 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 223
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 224
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 227–231
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 234–235
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 234–235
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 238–239
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 238–239
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 242–243
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 242–243
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 245
LocalVariableCouldBeFinal Local variable 'cfg' could be declared final 3 260
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 262
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 266
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 266
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'servletService' (lines '271'-'314'). 5 271–314
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 271
LocalVariableCouldBeFinal Local variable 'servletService' could be declared final 3 271
LocalVariableCouldBeFinal Local variable 'jaxb' could be declared final 3 277
LocalVariableCouldBeFinal Local variable 'unmarshaller' could be declared final 3 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 279
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 3 284
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 285
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 3 288
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 288
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 289
LocalVariableCouldBeFinal Local variable 'urlMap' could be declared final 3 298
LocalVariableCouldBeFinal Local variable 'groupNamesMap' could be declared final 3 301
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 301
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 301
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 302
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 3 302
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 304
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 306
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 322

org/apache/turbine/services/urlmapper/URLMapperService.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like pp 3 57

org/apache/turbine/services/urlmapper/URLMapperValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 39–61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 53
CloseResource Ensure that resources like this RunData object are closed after use 3 53
LocalVariableCouldBeFinal Local variable 'uri' could be declared final 3 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 54
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 54
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 56

org/apache/turbine/services/urlmapper/model/URLMapEntry.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44–175
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 48
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
RedundantFieldInitializer Avoid using redundant field initializer for 'relevantKeys' 3 52
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'implicit' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'ignore' is not assigned and could be declared final 3 106
MethodArgumentCouldBeFinal Parameter 'override' is not assigned and could be declared final 3 125
MethodArgumentCouldBeFinal Parameter 'groupNamesMap' is not assigned and could be declared final 3 145
MethodArgumentCouldBeFinal Parameter 'relevantKeys' is not assigned and could be declared final 3 165

org/apache/turbine/services/urlmapper/model/URLMappingContainer.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43–98
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'newURLMapEntries' is not assigned and could be declared final 3 94

org/apache/turbine/services/urlmapper/model/XmlParameterAdapter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 35–62
MethodArgumentCouldBeFinal Parameter 'xmlList' is not assigned and could be declared final 3 41
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 44–46
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 44–46
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 3 53
LocalVariableCouldBeFinal Local variable 'xmlList' could be declared final 3 55
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 56–58
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 56–58
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 56–58

org/apache/turbine/services/urlmapper/model/XmlParameterList.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55–108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 79
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 86
MethodArgumentCouldBeFinal Parameter 'xmlParameters' is not assigned and could be declared final 3 104

org/apache/turbine/services/urlmapper/model/XmlPatternAdapter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 31–50
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 3 37
MethodArgumentCouldBeFinal Parameter 'pattern' is not assigned and could be declared final 3 46

org/apache/turbine/services/velocity/TurbineVelocityService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 80–615
StdCyclomaticComplexity The class 'TurbineVelocityService' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 3 80–615
GodClass Possible God Class (WMC=52, ATFD=42, TCC=20.833%) 3 80–615
ModifiedCyclomaticComplexity The class 'TurbineVelocityService' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 3 80–615
LongVariable Avoid excessively long variable names like RESOURCE_LOADER_PATH 3 86
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 95
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 98
LongVariable Avoid excessively long variable names like defaultInputEncoding 3 98
LongVariable Avoid excessively long variable names like defaultOutputEncoding 3 101
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 101
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 104
RedundantFieldInitializer Avoid using redundant field initializer for 'pullModelActive' 3 104
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 107
RedundantFieldInitializer Avoid using redundant field initializer for 'velocity' 3 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 110
RedundantFieldInitializer Avoid using redundant field initializer for 'pullService' 3 113
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 138
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 146
LocalVariableCouldBeFinal Local variable 'inputEncoding' could be declared final 3 146
LongVariable Avoid excessively long variable names like outputEncodingString 3 149
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 149
LocalVariableCouldBeFinal Local variable 'outputEncodingString' could be declared final 3 149
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 167
LocalVariableCouldBeFinal Local variable 'globalContext' could be declared final 3 182–183
LocalVariableCouldBeFinal Local variable 'ctx' could be declared final 3 185
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'ctx' 3 186
LocalVariableCouldBeFinal Local variable 'ctx' could be declared final 3 197
ShortVariable Avoid variables with short names like ec 3 201
LocalVariableCouldBeFinal Local variable 'ec' could be declared final 3 201
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'info' is not assigned and could be declared final 3 222
ShortVariable Avoid variables with short names like e 3 222
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 228
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 246
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 253
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 253
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 271–272
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 289
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 289
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'results' (lines '292'-'302'). 5 292–302
CloseResource Ensure that resources like this OutputStreamWriter object are closed after use 3 293
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'writer' (lines '293'-'298'). 5 293–298
UnusedAssignment The initializer for variable 'writer' is never used (overwritten on line 298) 3 293
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 294
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 304
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 325
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 325
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 3 326
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '329'-'339'). 5 329–339
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 329
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 335
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 354
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 354
MethodArgumentCouldBeFinal Parameter 'writer' is not assigned and could be declared final 3 354
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 361
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 374
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 394
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 394
MethodArgumentCouldBeFinal Parameter 'writer' is not assigned and could be declared final 3 395
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 396
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 405
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 414
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'charset' (lines '416'-'421'). 5 416–421
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 418
UselessParentheses Useless parentheses. 4 419
UselessParentheses Useless parentheses. 4 419
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 433
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'encoding' (lines '435'-'440'). 5 435–440
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 437
UselessParentheses Useless parentheses. 4 438
UselessParentheses Useless parentheses. 4 438
UselessParentheses Useless parentheses. 4 438
ConfusingTernary Avoid if (x != y) ..; else ..; 3 443
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 455
ShortVariable Avoid variables with short names like e 3 455
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 3 455
UnnecessaryModifier Unnecessary modifier 'final' on method 'renderingError': private methods cannot be overridden 3 455–461
LocalVariableCouldBeFinal Local variable 'err' could be declared final 3 458
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 471
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 474
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 476
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 479
LocalVariableCouldBeFinal Local variable 'velocity' could be declared final 3 481
CyclomaticComplexity The method 'setVelocityProperties(VelocityEngine, Configuration)' has a cyclomatic complexity of 12. 3 500–585
ModifiedCyclomaticComplexity The method 'setVelocityProperties' has a Modified Cyclomatic Complexity of 12. 3 500–585
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 500
MethodArgumentCouldBeFinal Parameter 'velocity' is not assigned and could be declared final 3 500
StdCyclomaticComplexity The method 'setVelocityProperties' has a Standard Cyclomatic Complexity of 12. 3 500–585
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 501
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 507–584
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 507
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 509
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 510
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 512
UselessParentheses Useless parentheses. 4 515
LocalVariableCouldBeFinal Local variable 'name2' could be declared final 3 515
LocalVariableCouldBeFinal Local variable 'paths' could be declared final 3 528
LocalVariableCouldBeFinal Local variable 'p' could be declared final 3 543
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 548
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 551
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 551
LocalVariableCouldBeFinal Local variable 'jarSepIndex' could be declared final 3 554
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 554
UselessParentheses Useless parentheses. 4 557
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 558
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 560
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 560
UselessParentheses Useless parentheses. 4 560
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 565
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 568
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 573
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 596
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 608

org/apache/turbine/services/velocity/VelocityService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like VELOCITY_EXTENSION 3 52
LongVariable Avoid excessively long variable names like CATCH_ERRORS_DEFAULT 3 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 76
AvoidPrefixingMethodParameters Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 4 89

org/apache/turbine/util/BrowserDetector.java

Rule Violation Priority Line
DataClass The class 'BrowserDetector' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=4, WMC=9) 3 41–172
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 56–57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 3 78
ConstructorCallsOverridableMethod Overridable method 'getUserAgent' called during object construction 1 81
LocalVariableCouldBeFinal Local variable 'userAgent' could be declared final 3 81
LocalVariableCouldBeFinal Local variable 'version' could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 97
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 3 157
UnnecessaryModifier Unnecessary modifier 'final' on method 'toFloat': private methods cannot be overridden 3 168–171
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 168
ShortVariable Avoid variables with short names like s 3 168

org/apache/turbine/util/FormMessage.java

Rule Violation Priority Line
DataClass The class 'FormMessage' is suspected to be a Data Class (WOC=18.182%, NOPA=0, NOAM=5, WMC=12) 3 33–161
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 52
ConstructorCallsOverridableMethod Overridable method 'setFormName' called during object construction 1 55
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 65
ConstructorCallsOverridableMethod Overridable method 'setFieldName' called during object construction 1 68
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 80
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 1 83
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 113
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 131
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 141
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 153
ShortVariable Avoid variables with short names like sb 3 153
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 154

org/apache/turbine/util/FormMessages.java

Rule Violation Priority Line
FieldNamingConventions The final field name 'forms_messages' doesn't match '[a-z][a-zA-Z0-9]*' 1 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 36
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 36
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 38
FieldNamingConventions The final field name 'fields_messages' doesn't match '[a-z][a-zA-Z0-9]*' 1 38
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 38
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 40
FieldNamingConventions The final field name 'messages_fields' doesn't match '[a-z][a-zA-Z0-9]*' 1 40
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 40
FieldNamingConventions The final field name 'forms_fields' doesn't match '[a-z][a-zA-Z0-9]*' 1 42
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 42
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'returnCode' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'messageName' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 74
LocalVariableCouldBeFinal Local variable 'formFieldName' could be declared final 3 76
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 90
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 90
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 3 90
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 90
ConfusingTernary Avoid if (x != y) ..; else ..; 3 94–107
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 117
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 117
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 3 117
UnnecessaryModifier Unnecessary modifier 'final' on method 'getValues': private methods cannot be overridden 3 117–120
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 117
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 128
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 128–154
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 4 130
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 4 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '135'-'138'). 5 135–138
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 151
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 163
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 163
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 163–182
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 165
LocalVariableCouldBeFinal Local variable 'messages' could be declared final 3 167
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '172'-'175'). 5 172–175
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 179
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 191
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 191
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 3 193
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 194
StringToString Avoid calling toString() on String objects; this is unnecessary. 3 196
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 198

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 40–159
FieldNamingConventions The static field name 'session_count' doesn't match '[a-z][a-zA-Z0-9]*' 1 50
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'session_count' is not final. 1 50
RedundantFieldInitializer Avoid using redundant field initializer for 'session_count' 3 50
RedundantFieldInitializer Avoid using redundant field initializer for 'lastTimeVal' 3 51
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Random' due to existing import 'java.util.Random' 4 52
VariableNamingConventions Variables that are final and static should be all capitals, 'maxRandomLen' is not all capitals. 1 61
FieldNamingConventions The public constant name 'maxRandomLen' doesn't match '[A-Z][A-Z_0-9]*' 1 61
UseUnderscoresInNumericLiterals Number 2176782336L should separate every third digit with an underscore 3 61
VariableNamingConventions Variables that are final and static should be all capitals, 'maxSessionLifespanTics' is not all capitals. 1 69
UseUnderscoresInNumericLiterals Number 46656 should separate every third digit with an underscore 3 69
FieldNamingConventions The public constant name 'maxSessionLifespanTics' doesn't match '[A-Z][A-Z_0-9]*' 1 69
LongVariable Avoid excessively long variable names like maxSessionLifespanTics 3 69
VariableNamingConventions Variables that are final and static should be all capitals, 'ticDifference' is not all capitals. 1 75
FieldNamingConventions The public constant name 'ticDifference' doesn't match '[A-Z][A-Z_0-9]*' 1 75
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 85–130
LocalVariableCouldBeFinal Local variable 'sessionId' could be declared final 3 87
ShortVariable Avoid variables with short names like n 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100–101
UselessParentheses Useless parentheses. 4 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111–112
MethodArgumentCouldBeFinal Parameter 'jsIdent' is not assigned and could be declared final 3 138
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 138–145
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 142
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 152
SystemPrintln System.out.println is used 2 154
SystemPrintln System.out.println is used 2 155
SystemPrintln System.out.println is used 2 156
SystemPrintln System.out.println is used 2 157

org/apache/turbine/util/HttpUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 40–85
MethodArgumentCouldBeFinal Parameter 'date' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 70
MethodArgumentCouldBeFinal Parameter 'expiry' is not assigned and could be declared final 3 70
LocalVariableCouldBeFinal Local variable 'response' could be declared final 3 72

org/apache/turbine/util/InputFilterUtils.java

Rule Violation Priority Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 35–68
AbstractNaming Abstract classes should be named AbstractXXX 3 35–68
ShortVariable Avoid variables with short names like s 3 45
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 45
ShortVariable Avoid variables with short names like s 3 58
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 58

org/apache/turbine/util/LocaleUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 62–248
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 64
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 64
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultLocale' 3 67
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultCharSet' 3 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80–82
LocalVariableCouldBeFinal Local variable 'inputEncoding' could be declared final 3 80–82
NonThreadSafeSingleton Singleton is not thread safe 3 100–113
LocalVariableCouldBeFinal Local variable 'lang' could be declared final 3 103–105
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103–105
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107–109
LocalVariableCouldBeFinal Local variable 'country' could be declared final 3 107–109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 127
NonThreadSafeSingleton Singleton is not thread safe 3 138–150
LocalVariableCouldBeFinal Local variable 'charSet' could be declared final 3 141–143
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 141–143
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 3 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 161
LocalVariableCouldBeFinal Local variable 'serviceManager' could be declared final 3 164
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 165
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 165–178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 169
LocalVariableCouldBeFinal Local variable 'mimeTypeService' could be declared final 3 169
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 170
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '170'-'190'). 5 170–190
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 172
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 202–203
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 215–216
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 215–216
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 220
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 3 234
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 238

org/apache/turbine/util/ObjectUtils.java

Rule Violation Priority Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 36–102
AbstractNaming Abstract classes should be named AbstractXXX 3 36–102
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 3 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 48
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'byteArray' (lines '50'-'70'). 5 50–70
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 50
UnusedAssignment The initializer for variable 'byteArray' is never used (overwritten on line 66) 3 50
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'byteArray' (lines '50'-'66'). 5 50–66
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 52
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 56
MethodArgumentCouldBeFinal Parameter 'objectData' is not assigned and could be declared final 3 81
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'object' (lines '83'-'92'). 5 83–92
ShortVariable Avoid variables with short names like in 3 88
EmptyCatchBlock Avoid empty catch blocks 3 94–97
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 94

org/apache/turbine/util/RunData.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1–637
ShortVariable Avoid variables with short names like ct 3 464
ShortVariable Avoid variables with short names like sc 3 494

org/apache/turbine/util/SecurityCheck.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
RedundantFieldInitializer Avoid using redundant field initializer for 'securityService' 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 72
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'initialize' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 109
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '112'-'122'). 5 112–122
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 115
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 136
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 136
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '138'-'142'). 5 138–142
UnusedAssignment The initializer for variable 'roleObject' is never used (overwritten on lines 142 and 148) 3 138
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleObject' (lines '142'-'163'). 5 142–163
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 142
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '142'-'148'). 5 142–148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 149
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 3 150
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'modelManager' (lines '150'-'163'). 5 150–163
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 150
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
UselessParentheses Useless parentheses. 4 158
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 172
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 173
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '175'-'185'). 5 175–185
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 176
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 178
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 204
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 205
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '207'-'210'). 5 207–210
UnusedAssignment The initializer for variable 'permissionObject' is never used (overwritten on lines 210 and 216) 3 207
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permissionObject' (lines '210'-'257'). 5 210–257
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '210'-'216'). 5 210–216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 217
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'role' (lines '219'-'224'). 5 219–224
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 220
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 221
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 222
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 233
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 234
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 3 246
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 247
UselessParentheses Useless parentheses. 4 252

org/apache/turbine/util/ServerData.java

Rule Violation Priority Line
DataClass The class 'ServerData' is suspected to be a Data Class (WOC=18.750%, NOPA=0, NOAM=10, WMC=22) 3 42–279
RedundantFieldInitializer Avoid using redundant field initializer for 'serverName' 3 45
RedundantFieldInitializer Avoid using redundant field initializer for 'serverPort' 3 48
RedundantFieldInitializer Avoid using redundant field initializer for 'serverScheme' 3 51
RedundantFieldInitializer Avoid using redundant field initializer for 'scriptName' 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPath' 3 57
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 60
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 60
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 3 72
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 3 75
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 1 86
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 1 88
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 1 89
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 1 90
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 98
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 1 102
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 1 104
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 1 105
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 1 106
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 3 115
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 1 117
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 1 119
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 1 120
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 1 121
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 3 130–134
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 3 130–134
CloneMethodMustImplementCloneable clone() method should be implemented only if implementing Cloneable interface 3 130–134
ProperCloneImplementation Object clone() should be implemented with super.clone() 2 130–134
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 3 151
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 3 172
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 3 193
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 3 214
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 3 235
LinguisticNaming Linguistics Antipattern - The getter 'getHostUrl' should not return void linguistically 3 246–261
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 246
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 248
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 249
UselessParentheses Useless parentheses. 4 251–252
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 251
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 254
UselessParentheses Useless parentheses. 4 254–255
LocalVariableCouldBeFinal Local variable 'url' could be declared final 3 271
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 275

org/apache/turbine/util/ServletUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 42–103
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 53
CyclomaticComplexity The method 'expandRelative(ServletConfig, String)' has a cyclomatic complexity of 10. 3 53–102
MethodArgumentCouldBeFinal Parameter 'text' is not assigned and could be declared final 3 54
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 58
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 63
AvoidFinalLocalVariable Avoid using final local variables, turn them into fields 3 66
ConfusingTernary Avoid if (x != y) ..; else ..; 3 69–80
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 69
ShortVariable Avoid variables with short names like sb 3 72
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 72
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 73
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 82
LocalVariableCouldBeFinal Local variable 'base' could be declared final 3 83–84
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 83
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 88
LocalVariableCouldBeFinal Local variable 'tokenizer' could be declared final 3 91
LocalVariableCouldBeFinal Local variable 'buffer' could be declared final 3 92

org/apache/turbine/util/SystemError.java

Rule Violation Priority Line
DoNotExtendJavaLangError Exceptions should not extend java.lang.Error 3 33
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 3 64

org/apache/turbine/util/TurbineConfig.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1–940
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1–940
CyclomaticComplexity The class 'TurbineConfig' has a total cyclomatic complexity of 108 (highest 4). 3 96–940
TooManyMethods This class has too many methods, consider refactoring it. 3 98–940
LongVariable Avoid excessively long variable names like CONFIGURATION_PATH_KEY 3 107
LongVariable Avoid excessively long variable names like PROPERTIES_PATH_KEY 3 113
LongVariable Avoid excessively long variable names like PROPERTIES_PATH_DEFAULT 3 119
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 123
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 126
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 132
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 135
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 135
AvoidFieldNameMatchingMethodName Field log has the same name as a method 3 135
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 151
MethodArgumentCouldBeFinal Parameter 'attributes' is not assigned and could be declared final 3 151
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 3 152
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 3 172
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 172
MethodArgumentCouldBeFinal Parameter 'properties' is not assigned and could be declared final 3 188
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 188
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 206
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 216
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 267
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '269'-'280'). 5 269–280
LocalVariableCouldBeFinal Local variable 'f' could be declared final 3 270
ShortVariable Avoid variables with short names like f 3 270
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 297
UseArrayListInsteadOfVector Use ArrayList instead of Vector 3 310
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 362
ShortVariable Avoid variables with short names like s 3 362
ShortVariable Avoid variables with short names like s 3 376
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 376
LocalVariableCouldBeFinal Local variable 'fis' could be declared final 3 380
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 380
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 381
ShortVariable Avoid variables with short names like m 3 398
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 3 398
ShortVariable Avoid variables with short names like e 3 398
MethodArgumentCouldBeFinal Parameter 'm' is not assigned and could be declared final 3 398
MethodArgumentCouldBeFinal Parameter 'm' is not assigned and could be declared final 3 409
ShortVariable Avoid variables with short names like m 3 409
ShortVariable Avoid variables with short names like m 3 421
MethodArgumentCouldBeFinal Parameter 'm' is not assigned and could be declared final 3 421
ShortVariable Avoid variables with short names like t 3 421
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 421
ShortVariable Avoid variables with short names like s 3 431
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 431
UseArrayListInsteadOfVector Use ArrayList instead of Vector 3 443
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 456
ShortVariable Avoid variables with short names like s 3 456
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 482
ShortVariable Avoid variables with short names like s 3 482
ShortVariable Avoid variables with short names like s 3 508
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 508
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 521
ShortVariable Avoid variables with short names like s 3 521
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 533
ShortVariable Avoid variables with short names like s 3 533
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 559
ShortVariable Avoid variables with short names like s 3 559
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 599
ShortVariable Avoid variables with short names like s 3 599
ShortVariable Avoid variables with short names like o 3 611
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 3 611
ShortVariable Avoid variables with short names like s 3 611
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 611
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 647
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 647
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 659
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 3 659
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 3 671
MethodArgumentCouldBeFinal Parameter 'servlet' is not assigned and could be declared final 3 671
MethodArgumentCouldBeFinal Parameter 'servletClass' is not assigned and could be declared final 3 683
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 3 683
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 695
MethodArgumentCouldBeFinal Parameter 'servletName' is not assigned and could be declared final 3 707
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 3 731
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 4 731
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 731
MethodArgumentCouldBeFinal Parameter 'filter' is not assigned and could be declared final 3 743
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 3 743
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 4 743
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.servlet.FilterRegistration.Dynamic' due to existing import 'javax.servlet.FilterRegistration' 4 755
MethodArgumentCouldBeFinal Parameter 'filterClass' is not assigned and could be declared final 3 755
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 3 755
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 767
MethodArgumentCouldBeFinal Parameter 'filterName' is not assigned and could be declared final 3 779
LongVariable Avoid excessively long variable names like sessionTrackingModes 3 815
MethodArgumentCouldBeFinal Parameter 'sessionTrackingModes' is not assigned and could be declared final 3 815
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 851
ShortVariable Avoid variables with short names like t 3 863
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 863
MethodArgumentCouldBeFinal Parameter 'listenerClass' is not assigned and could be declared final 3 875
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 887
MethodArgumentCouldBeFinal Parameter 'roleNames' is not assigned and could be declared final 3 923

org/apache/turbine/util/TurbineException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 112
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 124
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 137
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 137

org/apache/turbine/util/TurbineRuntimeException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 80

org/apache/turbine/util/TurbineXmlConfig.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'attributes' is not assigned and could be declared final 3 76
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 76
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 3 77
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 95
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 3 95
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 109
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 109

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 105–690
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 128
RedundantFieldInitializer Avoid using redundant field initializer for 'doctype' 3 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 131
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeRootElement 3 131
ImmutableField Private field 'defaultHtmlDoctypeRootElement' could be made final; it is only initialized in the declaration or constructor. 3 131
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 134
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeIdentifier 3 134
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeUri 3 137
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 137
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 154
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 156
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 183
LinguisticNaming Linguistics Antipattern - The setter 'setTitle' should not return any type except void linguistically 3 183–187
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 200
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 212
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 212
MethodArgumentCouldBeFinal Parameter 'scriptURL' is not assigned and could be declared final 3 234
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 3 257
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 272–273
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 3 272
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 273
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 3 273
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 273
ShortVariable Avoid variables with short names like ss 3 275
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 3 275
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 290
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 3 290
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 317
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 317–318
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 3 317
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 317
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 318
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 3 320
ShortVariable Avoid variables with short names like ss 3 320
MethodArgumentCouldBeFinal Parameter 'styleText' is not assigned and could be declared final 3 343
LinguisticNaming Linguistics Antipattern - The setter 'setKeywords' should not return any type except void linguistically 3 365–369
MethodArgumentCouldBeFinal Parameter 'keywords' is not assigned and could be declared final 3 365
LinguisticNaming Linguistics Antipattern - The setter 'setHttpEquiv' should not return any type except void linguistically 3 380–384
MethodArgumentCouldBeFinal Parameter 'httpEquiv' is not assigned and could be declared final 3 380
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 3 380
MethodArgumentCouldBeFinal Parameter 'description' is not assigned and could be declared final 3 392
LinguisticNaming Linguistics Antipattern - The setter 'setDescription' should not return any type except void linguistically 3 392–396
LinguisticNaming Linguistics Antipattern - The setter 'setBackground' should not return any type except void linguistically 3 404–408
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 404
LinguisticNaming Linguistics Antipattern - The setter 'setBgColor' should not return any type except void linguistically 3 418–422
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 418
LinguisticNaming Linguistics Antipattern - The setter 'setTextColor' should not return any type except void linguistically 3 431–435
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 431
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 444
LinguisticNaming Linguistics Antipattern - The setter 'setLinkColor' should not return any type except void linguistically 3 444–448
LinguisticNaming Linguistics Antipattern - The setter 'setVlinkColor' should not return any type except void linguistically 3 456–460
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 456
LinguisticNaming Linguistics Antipattern - The setter 'setAlinkColor' should not return any type except void linguistically 3 468–472
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 468
DataClass The class 'LinkTag' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=9, WMC=15) 3 508–626
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 523
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 523
ConstructorCallsOverridableMethod Overridable method 'setRelation' called during object construction 1 525
UselessParentheses Useless parentheses. 4 536
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 544
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 562
UselessParentheses Useless parentheses. 4 574
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 582
UselessParentheses Useless parentheses. 4 594
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 3 602
UselessParentheses Useless parentheses. 4 614
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 622
LocalVariableCouldBeFinal Local variable 'tag' could be declared final 3 643
MethodArgumentCouldBeFinal Parameter 'tag' is not assigned and could be declared final 3 666
MethodArgumentCouldBeFinal Parameter 'identifier' is not assigned and could be declared final 3 666
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 666
LocalVariableCouldBeFinal Local variable 'doctypeBuf' could be declared final 3 668

org/apache/turbine/util/template/TemplateInfo.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE 3 47
ImmutableField Private field 'data' could be made final; it is only initialized in the declaration or constructor. 3 54
UnusedAssignment The field initializer for 'data' is never used (overwritten on line 66) 3 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 3 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
ImmutableField Private field 'tempStorage' could be made final; it is only initialized in the declaration or constructor. 3 57
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 67) 3 57
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 3 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 64
ShortVariable Avoid variables with short names like v 3 85
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98
ShortVariable Avoid variables with short names like v 3 107
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 117
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 120
EmptyCatchBlock Avoid empty catch blocks 3 120–125
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 135
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'value' 3 136
ShortVariable Avoid variables with short names like v 3 144
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 156
ShortVariable Avoid variables with short names like v 3 167
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 167
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 167
ShortVariable Avoid variables with short names like v 3 187
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 187
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 198
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 3 210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 210
LocalVariableCouldBeFinal Local variable 'val' could be declared final 3 214
ConfusingTernary Avoid if (x != y) ..; else ..; 3 215
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 215
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 217
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 240
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '242'-'246'). 5 242–246
LocalVariableCouldBeFinal Local variable 'object' could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 257
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '259'-'263'). 5 259–263
LocalVariableCouldBeFinal Local variable 'object' could be declared final 3 260
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 275
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 287

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 49
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 3 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 62
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 3 74–79
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 74
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'module' (lines '89'-'124'). 5 89–124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '89'-'103'). 5 89–103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'111'). 5 90–111
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'107'). 5 90–107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'96'). 5 90–96
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 97
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101–102
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 101–102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 113

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Priority Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 52
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 77
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 3 77–81
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '91'-'99'). 5 91–99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 95
LocalVariableCouldBeFinal Local variable 'results' could be declared final 3 95
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 102

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Priority Line
DataClass The class 'TemplateSecurityCheck' is suspected to be a Data Class (WOC=27.273%, NOPA=0, NOAM=6, WMC=18) 3 52–228
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 68
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 1 71
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 79
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 82–83
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 94
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 99
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 106
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 108
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 121
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 122
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '124'-'131'). 5 124–131
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 125
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 126
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 129
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 144
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '146'-'161'). 5 146–161
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 3 149–152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 150–152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 157–158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 160
ShortVariable Avoid variables with short names like v 3 173
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 204
ShortVariable Avoid variables with short names like v 3 204
ShortVariable Avoid variables with short names like v 3 224
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 224

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 46–520
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 51
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'redirect' 3 58
RedundantFieldInitializer Avoid using redundant field initializer for 'response' 3 61
RedundantFieldInitializer Avoid using redundant field initializer for 'reference' 3 64
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 90
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 1 93
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 102
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 1 105
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 114
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 126
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 126
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 148
ConfusingTernary Avoid if (x != y) ..; else ..; 3 152–163
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 164
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 181
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 3 213
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 3 234
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 3 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 272
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 3 289
MethodArgumentCouldBeFinal Parameter 'port' is not assigned and could be declared final 3 311
LocalVariableCouldBeFinal Local variable 'useSSL' could be declared final 3 313–316
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 314–316
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 3 327
LocalVariableCouldBeFinal Local variable 'serverScheme' could be declared final 3 342
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 3 352
MethodArgumentCouldBeFinal Parameter 'response' is not assigned and could be declared final 3 393
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 3 421
ShortVariable Avoid variables with short names like sb 3 421
LinguisticNaming Linguistics Antipattern - The getter 'getContextAndScript' should not return void linguistically 3 421–445
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 423
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 427
LocalVariableCouldBeFinal Local variable 'script' could be declared final 3 435
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 439
ShortVariable Avoid variables with short names like sb 3 459
LinguisticNaming Linguistics Antipattern - The getter 'getSchemeAndPort' should not return void linguistically 3 459–475
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 3 459
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 462
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 463
UselessParentheses Useless parentheses. 4 467–468
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 467
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 469
UselessParentheses Useless parentheses. 4 469–470
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 486
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'507'). 5 488–507
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'503'). 5 488–503
LocalVariableCouldBeFinal Local variable 'response' could be declared final 3 490
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 510
GuardLogStatement Logger calls should be surrounded by log level guards. 2 512
GuardLogStatement Logger calls should be surrounded by log level guards. 2 517

org/apache/turbine/util/uri/DataURI.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 89
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 89
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 126
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 164

org/apache/turbine/util/uri/TemplateURI.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 38
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 60
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 63
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 73
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 76
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 100
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 100
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 100
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 100
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 111
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 133
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 133
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 136
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 146
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 146
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 146
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 149
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 159
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 159
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 159
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 185
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 185
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 188
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 201
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 245
ShortVariable Avoid variables with short names like pp 3 246
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 246
LocalVariableCouldBeFinal Local variable 'name' could be declared final 3 248
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 250
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 252
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 253
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 254
LocalVariableCouldBeFinal Local variable 'values' could be declared final 3 256
ConfusingTernary Avoid if (x != y) ..; else ..; 3 257–267
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 259

org/apache/turbine/util/uri/TurbineURI.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=74, ATFD=16, TCC=9.725%) 3 55–916
TooManyMethods This class has too many methods, consider refactoring it. 3 57–916
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 59
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 59
RedundantFieldInitializer Avoid using redundant field initializer for 'dataVectors' 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 93
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 105
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 105
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 117
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 117
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 1 120
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 130
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 130
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 130
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 1 133
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 143
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 143
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 143
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 1 146
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 157
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 157
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 157
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 157
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 1 160
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 168
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 180
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 180
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 192
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 192
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 1 195
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 205
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 205
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 205
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 1 208
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 218
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 218
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 218
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 1 221
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 232
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 232
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 232
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 233
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 1 236
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 245
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 245
ConstructorCallsOverridableMethod Overridable method 'setScreen' called during object construction 1 248
ConstructorCallsOverridableMethod Overridable method 'setAction' called during object construction 1 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 270
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 291
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 309
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 325
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 325
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 351
ShortVariable Avoid variables with short names like pp 3 386
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 386
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 3 397
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 408
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 408
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 419
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 419
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 430
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 430
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 441
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 441
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 452
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 452
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 463
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 463
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 474
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 474
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 485
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 485
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 496
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 496
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 507
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 507
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 518
ShortVariable Avoid variables with short names like pp 3 518
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 3 528
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 556
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 584
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 622
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 655
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 3 670
MethodArgumentCouldBeFinal Parameter 'pathInfo' is not assigned and could be declared final 3 712
MethodArgumentCouldBeFinal Parameter 'queryData' is not assigned and could be declared final 3 736
LinguisticNaming Linguistics Antipattern - The getter 'getPathInfoAsString' should not return void linguistically 3 768–771
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 3 768
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 3 778
LinguisticNaming Linguistics Antipattern - The getter 'getQueryDataAsString' should not return void linguistically 3 778–781
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 789
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 794
MethodArgumentCouldBeFinal Parameter 'output' is not assigned and could be declared final 3 812
MethodArgumentCouldBeFinal Parameter 'valueDelim' is not assigned and could be declared final 3 812
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 3 812
MethodArgumentCouldBeFinal Parameter 'fieldDelim' is not assigned and could be declared final 3 812
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 816–822
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 816–822
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 837
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 838
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 839
LocalVariableCouldBeFinal Local variable 'uriParam' could be declared final 3 841
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 858
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 859
ShortVariable Avoid variables with short names like pp 3 859
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 861
LocalVariableCouldBeFinal Local variable 'values' could be declared final 3 866
ConfusingTernary Avoid if (x != y) ..; else ..; 3 867–877
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 869
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 3 895
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 895
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 910
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 910
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '912'-'915'). 5 912–915
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 912

org/apache/turbine/util/uri/URI.java

Rule Violation Priority Line
ShortClassName Avoid short class names like URI 4 32–76

org/apache/turbine/util/uri/URIConstants.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 36
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 39
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 42
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 45
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 54
LongVariable Avoid excessively long variable names like URI_SCHEME_SEPARATOR 3 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 63
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 66
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 69
LongVariable Avoid excessively long variable names like CGI_TEMPLATE_PARAM 3 69
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 72

org/apache/turbine/util/uri/URIParam.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 37
ImmutableField Private field 'key' could be made final; it is only initialized in the declaration or constructor. 3 37
UnusedAssignment The field initializer for 'key' is never used (overwritten on line 51) 3 37
RedundantFieldInitializer Avoid using redundant field initializer for 'key' 3 37
UnusedAssignment The field initializer for 'value' is never used (overwritten on line 52) 3 40
RedundantFieldInitializer Avoid using redundant field initializer for 'value' 3 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 40
ImmutableField Private field 'value' could be made final; it is only initialized in the declaration or constructor. 3 40
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 49
UselessParentheses Useless parentheses. 4 63
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 90
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 92–93
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 93
ControlStatementBraces This statement should have braces 3 93
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 94–95
ControlStatementBraces This statement should have braces 3 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 95
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 96–97
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 97
ControlStatementBraces This statement should have braces 3 97
LocalVariableCouldBeFinal Local variable 'other' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101

org/apache/turbine/util/uri/URIUtils.java

Rule Violation Priority Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 34–53
AbstractNaming Abstract classes should be named AbstractXXX 3 34–53
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 47
ShortVariable Avoid variables with short names like du 3 49
LocalVariableCouldBeFinal Local variable 'du' could be declared final 3 49

org/apache/turbine/util/velocity/VelocityActionEvent.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 51–90
AbstractNaming Abstract classes should be named AbstractXXX 3 51–90
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
RedundantFieldInitializer Avoid using redundant field initializer for 'initialized' 3 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 66
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 77
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 85
ShortVariable Avoid variables with short names like pp 3 85
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 86

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Priority Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 107
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 107
RedundantFieldInitializer Avoid using redundant field initializer for 'wordWrap' 3 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 110
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 3 116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 116
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 3 119
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 133
LinguisticNaming Linguistics Antipattern - The setter 'setTo' should not return any type except void linguistically 3 149–154
MethodArgumentCouldBeFinal Parameter 'toName' is not assigned and could be declared final 3 149
MethodArgumentCouldBeFinal Parameter 'toEmail' is not assigned and could be declared final 3 149
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 164
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 3 164–168
LinguisticNaming Linguistics Antipattern - The setter 'setWordWrap' should not return any type except void linguistically 3 181–185
MethodArgumentCouldBeFinal Parameter 'wordWrap' is not assigned and could be declared final 3 181
LinguisticNaming Linguistics Antipattern - The setter 'setContext' should not return any type except void linguistically 3 194–198
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 3 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 234–236
UnusedAssignment The initializer for variable 'body' is never used (overwritten on line 256) 3 251
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'body' (lines '251'-'256'). 5 251–256
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 3 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 255
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 256
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'body' (lines '256'-'274'). 5 256–274
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 258

org/apache/turbine/util/velocity/VelocityEmailException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 78

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 88
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 88
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 94
RedundantFieldInitializer Avoid using redundant field initializer for 'htmlTemplate' 3 94
RedundantFieldInitializer Avoid using redundant field initializer for 'textTemplate' 3 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 103
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 3 103
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 106
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 106
RedundantFieldInitializer Avoid using redundant field initializer for 'embmap' 3 106
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 106
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 124
LinguisticNaming Linguistics Antipattern - The setter 'setHtmlTemplate' should not return any type except void linguistically 3 139–143
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 139
LinguisticNaming Linguistics Antipattern - The setter 'setTextTemplate' should not return any type except void linguistically 3 153–157
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 153
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 3 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 182–184
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 3 199
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'velocityService' (lines '199'-'216'). 5 199–216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 199
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 207
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'surl' is not assigned and could be declared final 3 243
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'cid' (lines '245'-'249'). 5 245–249
LocalVariableCouldBeFinal Local variable 'url' could be declared final 3 248
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 266
LocalVariableCouldBeFinal Local variable 'cid' could be declared final 3 268