Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.38.0.

Violations By Priority

Priority 1

org/apache/turbine/modules/GenericLoader.java

Rule Violation Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'TURBINE_PACKAGES' is not final. 60
VariableNamingConventions Variables should start with a lowercase character, 'TURBINE_PACKAGES' starts with uppercase character. 60
FieldNamingConventions The static field name 'TURBINE_PACKAGES' doesn't match '[a-z][a-zA-Z0-9]*' 60

org/apache/turbine/modules/ScheduledJobLoader.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 86

org/apache/turbine/modules/actions/AccessController.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 74
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 74

org/apache/turbine/modules/layouts/JspLayout.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 45
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 45

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Line
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 49
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 49

org/apache/turbine/modules/navigations/BaseJspNavigation.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 42
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 42

org/apache/turbine/modules/navigations/VelocityNavigation.java

Rule Violation Line
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 48
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 48

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Line
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 43
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 43
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 74

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Line
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 130
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 130
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 133
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 133

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 78
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 78
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 107
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 107

org/apache/turbine/modules/screens/RawScreen.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 9295

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 9295

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 64

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 65

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 52
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 52
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 120

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setHasLoggedIn' called during object construction 72

org/apache/turbine/pipeline/DefaultSetEncodingValve.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 50
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 50

org/apache/turbine/pipeline/DetermineActionValve.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 43
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 43

org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 43
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 43

org/apache/turbine/pipeline/DetermineTargetValve.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 46
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 46

org/apache/turbine/services/TurbineBaseService.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 9295

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_servClass' is not final. 90
LocalVariableNamingConventions The local variable name '_servClass' doesn't match '[a-z][a-zA-Z0-9]*' 90

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 78
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 132

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
ClassNamingConventions The utility class name 'JSONProcessor' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 3987
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 51
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 51
LocalVariableNamingConventions The local variable name 'json_req' doesn't match '[a-z][a-zA-Z0-9]*' 54
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_req' is not final. 54
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 55
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 55
LocalVariableNamingConventions The local variable name 'object_id' doesn't match '[a-z][a-zA-Z0-9]*' 65
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'object_id' is not final. 65

org/apache/turbine/services/jsonrpc/JsonRpcService.java

Rule Violation Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 51
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 51

org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 46
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 46
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 60
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 60
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 67
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 67

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 143

org/apache/turbine/services/localization/DateTimeFormatterService.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 71
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 71

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'refresh' called during object construction 59

org/apache/turbine/services/localization/RundataLocalizationService.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 45
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 45

org/apache/turbine/services/pull/tools/TemplateLink.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 95
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 95

org/apache/turbine/services/pull/tools/UITool.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 68
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 68

org/apache/turbine/services/pull/util/DateTimeFormatterTool.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 61
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 61

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 38
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 38
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 98
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 98
ConstructorCallsOverridableMethod Overridable method 'calcRunTime' called during object construction 117

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 44
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 44
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 118
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 118

org/apache/turbine/services/schedule/JobEntryNonPersistent.java

Rule Violation Line
FieldNamingConventions The field name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 36
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 36
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 83
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 83
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 119
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 119

org/apache/turbine/services/schedule/JobEntryQuartz.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setTask' called during object construction 84
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 95
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 95

org/apache/turbine/services/schedule/QuartzSchedulerService.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 54
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 54
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 103
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 103
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 140
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 140

org/apache/turbine/services/schedule/ScheduleService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 85
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 85

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 41
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 41

org/apache/turbine/services/schedule/TorqueSchedulerService.java

Rule Violation Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 71
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 71

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 122
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 122

org/apache/turbine/services/schedule/WorkerThread.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 45
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 45

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 104
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 104

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 55
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 55

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 63
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 63

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 55
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 55

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 51
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 51

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 49
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 49
FieldNamingConventions The constant name 'counter' doesn't match '[A-Z][A-Z_0-9]*' 56
VariableNamingConventions Variables that are final and static should be all capitals, 'counter' is not all capitals. 56

org/apache/turbine/util/BrowserDetector.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'getUserAgent' called during object construction 81

org/apache/turbine/util/FormMessage.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setFormName' called during object construction 55
ConstructorCallsOverridableMethod Overridable method 'setFieldName' called during object construction 68
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 83

org/apache/turbine/util/FormMessages.java

Rule Violation Line
FieldNamingConventions The final field name 'forms_messages' doesn't match '[a-z][a-zA-Z0-9]*' 36
FieldNamingConventions The final field name 'fields_messages' doesn't match '[a-z][a-zA-Z0-9]*' 38
FieldNamingConventions The final field name 'messages_fields' doesn't match '[a-z][a-zA-Z0-9]*' 40
FieldNamingConventions The final field name 'forms_fields' doesn't match '[a-z][a-zA-Z0-9]*' 42
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 128154
ReturnEmptyCollectionRatherThanNull Return an empty collection rather than null. 128154
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 163182
ReturnEmptyCollectionRatherThanNull Return an empty collection rather than null. 163182

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'session_count' is not final. 50
FieldNamingConventions The static field name 'session_count' doesn't match '[a-z][a-zA-Z0-9]*' 50
FieldNamingConventions The public constant name 'maxRandomLen' doesn't match '[A-Z][A-Z_0-9]*' 61
VariableNamingConventions Variables that are final and static should be all capitals, 'maxRandomLen' is not all capitals. 61
VariableNamingConventions Variables that are final and static should be all capitals, 'maxSessionLifespanTics' is not all capitals. 69
FieldNamingConventions The public constant name 'maxSessionLifespanTics' doesn't match '[A-Z][A-Z_0-9]*' 69
FieldNamingConventions The public constant name 'ticDifference' doesn't match '[A-Z][A-Z_0-9]*' 75
VariableNamingConventions Variables that are final and static should be all capitals, 'ticDifference' is not all capitals. 75

org/apache/turbine/util/LocaleUtils.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 64
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 64
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 174

org/apache/turbine/util/ObjectUtils.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 56

org/apache/turbine/util/ServerData.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 60
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 60
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 86
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 88
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 89
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 90
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 102
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 104
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 105
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 106
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 117
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 119
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 120
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 121

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setRelation' called during object construction 525

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 49
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 49
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 97
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 108

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 52
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 52

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 71

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 51
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 51
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 93
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 105

org/apache/turbine/util/uri/TemplateURI.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 84
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 97
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 157
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 170
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 209

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 107
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 107

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 88
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 88

org/apache/turbine/services/schedule/BaseJobEntryTorque.java

Rule Violation Line
FieldNamingConventions The constant name 'peer' doesn't match '[A-Z][A-Z_0-9]*' 719
VariableNamingConventions Variables that are final and static should be all capitals, 'peer' is not all capitals. 719

org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java

Rule Violation Line
FieldNamingConventions The public constant name 'numColumns' doesn't match '[A-Z][A-Z_0-9]*' 66
VariableNamingConventions Variables that are final and static should be all capitals, 'numColumns' is not all capitals. 66
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 14721474

Priority 2

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 57

org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 61

org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 6061

org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 50

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 46

org/apache/turbine/modules/pages/DefaultPage.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 95

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 73

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 55

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 63

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 64

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 119

org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 83

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 73

org/apache/turbine/services/FieldAnnotatedTurbineBaseService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 41
GuardLogStatement Logger calls should be surrounded by log level guards. 56

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 6061
GuardLogStatement Logger calls should be surrounded by log level guards. 105

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 51

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 58

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 42

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 67

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 50

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 52

org/apache/turbine/services/localization/DateTimeFormatterService.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 110112
GuardLogStatement Logger calls should be surrounded by log level guards. 151
GuardLogStatement Logger calls should be surrounded by log level guards. 158
AvoidReassigningParameters Avoid reassigning parameters such as 'incomingFormatPattern' 183
AvoidReassigningParameters Avoid reassigning parameters such as 'incomingFormat' 208
AvoidReassigningParameters Avoid reassigning parameters such as 'outgoingFormat' 215

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 42

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 55

org/apache/turbine/services/pull/util/DateTimeFormatterTool.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 111

org/apache/turbine/services/schedule/WorkerThread.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 7980
GuardLogStatement Logger calls should be surrounded by log level guards. 99100

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 101

org/apache/turbine/util/BrowserDetector.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 5657

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
SystemPrintln System.out.println is used 154
SystemPrintln System.out.println is used 155
SystemPrintln System.out.println is used 156
SystemPrintln System.out.println is used 157

org/apache/turbine/util/ServerData.java

Rule Violation Line
ProperCloneImplementation Object clone() should be implemented with super.clone() 130134
GuardLogStatement Logger calls should be surrounded by log level guards. 174

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 512
GuardLogStatement Logger calls should be surrounded by log level guards. 517

Priority 3

org/apache/turbine/TurbineConstants.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 51
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 53
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE_DEFAULT 56
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 56
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 59
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 62
LongVariable Avoid excessively long variable names like SCHEDULER_LOG_FACILITY 62
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 65
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 68
LongVariable Avoid excessively long variable names like MAIL_SERVER_DEFAULT 68
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 71
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 74
LongVariable Avoid excessively long variable names like MODULE_CACHE_DEFAULT 77
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 77
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 80
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_KEY 80
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 83
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_DEFAULT 83
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 86
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 89
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 92
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_KEY 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 98
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_JSP 98
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 101
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 104
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 107
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 110
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 113
LongVariable Avoid excessively long variable names like SCREEN_ERROR_DEFAULT 113
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 116
LongVariable Avoid excessively long variable names like SCREEN_INVALID_STATE 116
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 119
LongVariable Avoid excessively long variable names like TEMPLATE_INVALID_STATE 119
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 122
LongVariable Avoid excessively long variable names like ACTION_LOGIN_DEFAULT 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 128
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 131
LongVariable Avoid excessively long variable names like ACTION_LOGOUT_DEFAULT 131
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_KEY 134
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 134
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_DEFAULT 137
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 137
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_KEY 140
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 140
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 143
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_DEFAULT 143
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_KEY 146
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 146
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_DEFAULT 149
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 149
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP 152
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 152
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 158
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 161
LongVariable Avoid excessively long variable names like PAGE_DEFAULT_DEFAULT 164
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 164
LongVariable Avoid excessively long variable names like SCREEN_DEFAULT_DEFAULT 167
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 167
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 170
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 173
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 176
LongVariable Avoid excessively long variable names like LOGIN_MESSAGE_NOSCREEN 176
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 179
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 182
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_KEY 182
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 185
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_DEFAULT 185
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 188
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 191
LongVariable Avoid excessively long variable names like PP_URL_CASE_FOLDING 197
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 197
LongVariable Avoid excessively long variable names like DEFAULT_DOCUMENT_TYPE_KEY 200
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 200
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 203
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_KEY 203
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_DEFAULT 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_KEY 209
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 209
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_DEFAULT 212
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 212
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_KEY 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_DEFAULT 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 221
LongVariable Avoid excessively long variable names like DEFAULT_HTML_CONTENT_TYPE 221
LongVariable Avoid excessively long variable names like DEFAULT_TEXT_CONTENT_TYPE 222
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 222
LongVariable Avoid excessively long variable names like DEFAULT_CSS_CONTENT_TYPE 223
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 223
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 226
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_KEY 226
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 229
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_DEFAULT 229
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_KEY 232
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 232
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 235
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_DEFAULT 235
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_KEY 238
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 238
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_DEFAULT 241
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 241
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 244
LongVariable Avoid excessively long variable names like LOCALE_OVERRIDE_CHARSET_KEY 244
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 249
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 252
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_KEY 252
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 255
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_DEFAULT 255
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 262
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 265
LongVariable Avoid excessively long variable names like LOGGING_ROOT_DEFAULT 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 271
LongVariable Avoid excessively long variable names like SCREEN_PLACEHOLDER 274
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 274
LongVariable Avoid excessively long variable names like NAVIGATION_PLACEHOLDER 277
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 277
LongVariable Avoid excessively long variable names like PROCESSING_EXCEPTION_PLACEHOLDER 280
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 280
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 283
LongVariable Avoid excessively long variable names like STACK_TRACE_PLACEHOLDER 283
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 286
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_KEY 286
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT 289
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 289
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 292293
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_NAME_KEY 292
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 296297
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_PORT_KEY 296
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 300301
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_SCHEME_KEY 300
LongVariable Avoid excessively long variable names like DEFAULT_SCRIPT_NAME_KEY 304
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 304305
LongVariable Avoid excessively long variable names like DEFAULT_CONTEXT_PATH_KEY 308
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 308309
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 312
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 319

org/apache/turbine/modules/Action.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 62
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 62

org/apache/turbine/modules/ActionLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62

org/apache/turbine/modules/GenericLoader.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 42222
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
ShortVariable Avoid variables with short names like ab 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
AvoidFieldNameMatchingMethodName Field reload has the same name as a method 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
RedundantFieldInitializer Avoid using redundant field initializer for 'reload' 54
SuspiciousConstantFieldName The field name indicates a constant but its modifiers do not 60
RedundantFieldInitializer Avoid using redundant field initializer for 'TURBINE_PACKAGES' 60
MethodArgumentCouldBeFinal Parameter 'assemblerClass' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'cacheSizeSupplier' is not assigned and could be declared final 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 85
MethodArgumentCouldBeFinal Parameter 'reload' is not assigned and could be declared final 109
LinguisticNaming Linguistics Antipattern - The setter 'setReload' should not return any type except void linguistically 109113
NonThreadSafeSingleton Singleton is not thread safe 134140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136137
LocalVariableCouldBeFinal Local variable 'turbinePackages' could be declared final 136137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136137
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 142
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 161
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 176
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 177
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 194
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 208

org/apache/turbine/modules/Layout.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 61
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 61

org/apache/turbine/modules/LayoutLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62

org/apache/turbine/modules/Loader.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 37

org/apache/turbine/modules/Navigation.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 67
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 68

org/apache/turbine/modules/NavigationLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 63
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 67
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 78

org/apache/turbine/modules/Page.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 64

org/apache/turbine/modules/PageLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63

org/apache/turbine/modules/ScheduledJob.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 58

org/apache/turbine/modules/ScheduledJobLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'job' is not assigned and could be declared final 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 83

org/apache/turbine/modules/Screen.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 69
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 89
CloseResource Ensure that resources like this RunData object are closed after use 91
LocalVariableCouldBeFinal Local variable 'data' could be declared final 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 92
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 101
MethodArgumentCouldBeFinal Parameter 'layout' is not assigned and could be declared final 101
LocalVariableCouldBeFinal Local variable 'data' could be declared final 103
CloseResource Ensure that resources like this RunData object are closed after use 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 104

org/apache/turbine/modules/ScreenLoader.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 65
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 66
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 82

org/apache/turbine/modules/actions/AccessController.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 71119
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 91
LocalVariableCouldBeFinal Local variable 'data' could be declared final 94
CloseResource Ensure that resources like this RunData object are closed after use 94
LocalVariableCouldBeFinal Local variable 'user' could be declared final 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 102103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 108109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 117

org/apache/turbine/modules/actions/DefaultAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3651
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 45
CloseResource Ensure that resources like this RunData object are closed after use 48
LocalVariableCouldBeFinal Local variable 'data' could be declared final 48
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 49

org/apache/turbine/modules/actions/InitContextsAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4497
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 60
LocalVariableCouldBeFinal Local variable 'data' could be declared final 63
CloseResource Ensure that resources like this RunData object are closed after use 63
LocalVariableCouldBeFinal Local variable 'contextPropsList' could be declared final 71
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 71
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 7289
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 72
LocalVariableCouldBeFinal Local variable 'key' could be declared final 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
LocalVariableCouldBeFinal Local variable 'start' could be declared final 75
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 76
LocalVariableCouldBeFinal Local variable 'end' could be declared final 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 77
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 81 and 85) 78
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 85
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 87
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 91
LocalVariableCouldBeFinal Local variable 'context' could be declared final 93
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 94

org/apache/turbine/modules/actions/LegacyVelocityAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3685
AbstractNaming Abstract classes should be named AbstractXXX 3685
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 71
LocalVariableCouldBeFinal Local variable 'data' could be declared final 79
CloseResource Ensure that resources like this RunData object are closed after use 79
ShortVariable Avoid variables with short names like pp 80
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 80
LocalVariableCouldBeFinal Local variable 'context' could be declared final 81

org/apache/turbine/modules/actions/LegacyVelocitySecureAction.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 4169
AtLeastOneConstructor Each class should declare at least one constructor 4169
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 51
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 68

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 48157
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
ImmutableField Private field 'loginError' could be made final; it is only initialized in the declaration or constructor. 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 85
CloseResource Ensure that resources like this RunData object are closed after use 88
LocalVariableCouldBeFinal Local variable 'data' could be declared final 88
LocalVariableCouldBeFinal Local variable 'username' could be declared final 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
LocalVariableCouldBeFinal Local variable 'password' could be declared final 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LocalVariableCouldBeFinal Local variable 'user' could be declared final 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 114
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 132
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 134
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 142

org/apache/turbine/modules/actions/LogoutUser.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41123
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
ImmutableField Private field 'actionLogout' could be made final; it is only initialized in the declaration or constructor. 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 75
CloseResource Ensure that resources like this RunData object are closed after use 78
LocalVariableCouldBeFinal Local variable 'data' could be declared final 78
LocalVariableCouldBeFinal Local variable 'user' could be declared final 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 99
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 109
LiteralsFirstInComparisons Position literals first in String comparisons 118

org/apache/turbine/modules/actions/VelocityAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3696
AbstractNaming Abstract classes should be named AbstractXXX 3696
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 70
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 76
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 92

org/apache/turbine/modules/actions/VelocitySecureAction.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4270
AbstractNaming Abstract classes should be named AbstractXXX 4270
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 69

org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 57129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
LongVariable Avoid excessively long variable names like loginMessageNoScreen 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 84
LocalVariableCouldBeFinal Local variable 'data' could be declared final 87
CloseResource Ensure that resources like this RunData object are closed after use 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 127
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 127

org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 53124
AtLeastOneConstructor Each class should declare at least one constructor 53124
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 66
LongVariable Avoid excessively long variable names like templateInvalidState 66
LongVariable Avoid excessively long variable names like screenInvalidState 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 69
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'screenOnly' is not assigned and could be declared final 79
CognitiveComplexity The method 'handleFormCounterToken(RunData, boolean)' has a cognitive complexity of 20, current threshold is 15 79122
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
AvoidDuplicateLiterals The String literal "_session_access_counter" appears 5 times in this file; the first occurrence is on line 81 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 8687
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 90
CollapsibleIfStatements These nested if statements could be combined 98117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99100
ConfusingTernary Avoid if (x != y) ..; else ..; 102114
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 102114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 104106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 115

org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 56149
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 84
CloseResource Ensure that resources like this RunData object are closed after use 87
LocalVariableCouldBeFinal Local variable 'data' could be declared final 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 129
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 141
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 147

org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 46101
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 60
CloseResource Ensure that resources like this RunData object are closed after use 62
LocalVariableCouldBeFinal Local variable 'data' could be declared final 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 64
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 67
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 99

org/apache/turbine/modules/layouts/DirectResponseLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3756
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 46
CloseResource Ensure that resources like this RunData object are closed after use 49
LocalVariableCouldBeFinal Local variable 'data' could be declared final 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 50

org/apache/turbine/modules/layouts/JspLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4280
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 61
CloseResource Ensure that resources like this RunData object are closed after use 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 76
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 76

org/apache/turbine/modules/layouts/VelocityCachedLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4261
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 59

org/apache/turbine/modules/layouts/VelocityDirectLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4258
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 48
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 48

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43116
AbstractNaming Abstract classes should be named AbstractXXX 43116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 63
LocalVariableCouldBeFinal Local variable 'data' could be declared final 66
CloseResource Ensure that resources like this RunData object are closed after use 66
LocalVariableCouldBeFinal Local variable 'context' could be declared final 68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 79
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 97
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 108
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 108
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 108
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113114

org/apache/turbine/modules/layouts/VelocityOnlyLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 6593
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 75
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
LocalVariableCouldBeFinal Local variable 'results' could be declared final 83
LocalVariableCouldBeFinal Local variable 'returnValue' could be declared final 84

org/apache/turbine/modules/layouts/VelocityXslLayout.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
UnusedPrivateField Avoid unused private fields such as 'screenLoader'. 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 73
CloseResource Ensure that resources like this RunData object are closed after use 76
LocalVariableCouldBeFinal Local variable 'data' could be declared final 76
LocalVariableCouldBeFinal Local variable 'context' could be declared final 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 88
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 88
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 88
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 9394
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 100

org/apache/turbine/modules/navigations/BaseJspNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3880
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 69
CloseResource Ensure that resources like this RunData object are closed after use 72
LocalVariableCouldBeFinal Local variable 'data' could be declared final 72
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 74

org/apache/turbine/modules/navigations/LegacyVelocityNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3561
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 48
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 57

org/apache/turbine/modules/navigations/TemplateNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3468
AbstractNaming Abstract classes should be named AbstractXXX 3468
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 52
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 62

org/apache/turbine/modules/navigations/VelocityNavigation.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 97
LocalVariableCouldBeFinal Local variable 'data' could be declared final 100
CloseResource Ensure that resources like this RunData object are closed after use 100
LocalVariableCouldBeFinal Local variable 'context' could be declared final 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LocalVariableCouldBeFinal Local variable 'navigationTemplate' could be declared final 103
LongVariable Avoid excessively long variable names like navigationTemplate 103
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 104105

org/apache/turbine/modules/pages/DefaultPage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 92207
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 99
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 107
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 116
CloseResource Ensure that resources like this RunData object are closed after use 119
LocalVariableCouldBeFinal Local variable 'data' could be declared final 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 132
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 141
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 141
LocalVariableCouldBeFinal Local variable 'aScreen' could be declared final 149
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 150
LocalVariableCouldBeFinal Local variable 'layout' could be declared final 150
ConfusingTernary Avoid if (x != y) ..; else ..; 154161
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 177
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 189
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 190
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 202
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 203

org/apache/turbine/modules/pages/JspPage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3969
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 51
LocalVariableCouldBeFinal Local variable 'response' could be declared final 58
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 60
EmptyCatchBlock Avoid empty catch blocks 6266

org/apache/turbine/modules/pages/TemplatePage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 82129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 87
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 97
LocalVariableCouldBeFinal Local variable 'data' could be declared final 100
CloseResource Ensure that resources like this RunData object are closed after use 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 105
LocalVariableCouldBeFinal Local variable 'template' could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 110
LocalVariableCouldBeFinal Local variable 'layoutTemplate' could be declared final 113114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 115
LocalVariableCouldBeFinal Local variable 'screen' could be declared final 117
LocalVariableCouldBeFinal Local variable 'errMsg' could be declared final 121122

org/apache/turbine/modules/pages/VelocityPage.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3974
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 54
CloseResource Ensure that resources like this RunData object are closed after use 57
LocalVariableCouldBeFinal Local variable 'data' could be declared final 57
LocalVariableCouldBeFinal Local variable 'context' could be declared final 58
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 5960
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 5960
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 68
LocalVariableCouldBeFinal Local variable 'context' could be declared final 71

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3996
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 61
LocalVariableCouldBeFinal Local variable 'data' could be declared final 64
CloseResource Ensure that resources like this RunData object are closed after use 64
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 65
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 65
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 6768
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 91

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 82143
LongVariable Avoid excessively long variable names like JSONRPC_CONTENT_TYPE 84
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 109
LocalVariableCouldBeFinal Local variable 'data' could be declared final 111
CloseResource Ensure that resources like this RunData object are closed after use 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112
LocalVariableCouldBeFinal Local variable 'request' could be declared final 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 113
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 116
CloseResource Ensure that resources like this InputStreamReader object are closed after use 117
ShortVariable Avoid variables with short names like in 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 117
LocalVariableCouldBeFinal Local variable 'in' could be declared final 117
LocalVariableCouldBeFinal Local variable 'cdata' could be declared final 120
LocalVariableCouldBeFinal Local variable 'buf' could be declared final 121
AssignmentInOperand Avoid assignments in operands 123
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 130
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 130
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 133
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 137

org/apache/turbine/modules/screens/JSONSecureScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 77104
AbstractNaming Abstract classes should be named AbstractXXX 77104
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 87
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 103

org/apache/turbine/modules/screens/JspErrorScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3450
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
ImmutableField Private field 'templateError' could be made final; it is only initialized in the declaration or constructor. 38
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 45

org/apache/turbine/modules/screens/LegacyVelocityScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3365
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 45
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 60

org/apache/turbine/modules/screens/LegacyVelocitySecureScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3477
AbstractNaming Abstract classes should be named AbstractXXX 3477
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 76

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 72118
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the log field if you want a default access modifier 78
DefaultPackage Use explicit scoping instead of the default package private level 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 101
CloseResource Ensure that resources like this RunData object are closed after use 103
LocalVariableCouldBeFinal Local variable 'data' could be declared final 103
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 107
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
StringToString Avoid calling toString() on String objects; this is unnecessary. 114

org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3273
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 43
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 60
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 60
CloseResource Ensure that resources like this RunData object are closed after use 61
LocalVariableCouldBeFinal Local variable 'data' could be declared final 61
LocalVariableCouldBeFinal Local variable 'methods' could be declared final 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 6471
LiteralsFirstInComparisons Position literals first in String comparisons 65

org/apache/turbine/modules/screens/RawScreen.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 4596
AtLeastOneConstructor Each class should declare at least one constructor 4596
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
CloseResource Ensure that resources like this RunData object are closed after use 59
LocalVariableCouldBeFinal Local variable 'data' could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 61
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 52204
AtLeastOneConstructor Each class should declare at least one constructor 52204
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 72
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 106
UnusedAssignment The initializer for variable 'out' is never used (overwritten on line 114) 109
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 135
LocalVariableCouldBeFinal Local variable 'data' could be declared final 137
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 138
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 138
ShortVariable Avoid variables with short names like ti 138
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 139
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 139
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 141
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 148
EmptyCatchBlock Avoid empty catch blocks 148151
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 173
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 174
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 199
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 199
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 200

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3984
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 50
CloseResource Ensure that resources like this RunData object are closed after use 53
LocalVariableCouldBeFinal Local variable 'data' could be declared final 53
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 56
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 56
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 5758
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 71

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4089
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 51
CloseResource Ensure that resources like this RunData object are closed after use 54
LocalVariableCouldBeFinal Local variable 'data' could be declared final 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 55
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 55
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 57
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 57
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 5859
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 72
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 84

org/apache/turbine/modules/screens/VelocityErrorScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3658
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 47
CloseResource Ensure that resources like this RunData object are closed after use 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 50
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 52
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 54

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 48152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 75
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 76
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 104
LocalVariableCouldBeFinal Local variable 'data' could be declared final 107
CloseResource Ensure that resources like this RunData object are closed after use 107
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 108
LocalVariableCouldBeFinal Local variable 'context' could be declared final 110
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 112
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 113114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 131
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 139

org/apache/turbine/modules/screens/VelocitySecureScreen.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4185
AbstractNaming Abstract classes should be named AbstractXXX 4185
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 84

org/apache/turbine/modules/screens/error/InvalidState.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4686
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
CloseResource Ensure that resources like this RunData object are closed after use 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 58
LocalVariableCouldBeFinal Local variable 'body' could be declared final 59
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 67 characters appended. 62
LocalVariableCouldBeFinal Local variable 'message' could be declared final 62
ShortVariable Avoid variables with short names like sb 63
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 170 characters appended. 63
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 63
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 7 consecutive times with literals. Use a single append with a single combined String. 64
ShortVariable Avoid variables with short names like pp 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
LocalVariableCouldBeFinal Local variable 'back' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 79
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 79
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 82

org/apache/turbine/om/OMTool.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
ImmutableField Private field 'pullMap' could be made final; it is only initialized in the declaration or constructor. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 62
LocalVariableCouldBeFinal Local variable 'className' could be declared final 65
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 95
DefaultPackage Use explicit scoping instead of the default package private level 95
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the omName field if you want a default access modifier 95
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 97
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 102
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 102119
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 103
UnusedAssignment The initializer for variable 'om' is never used (overwritten on lines 110 and 114) 105
ShortVariable Avoid variables with short names like om 105
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 128
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 128
LocalVariableCouldBeFinal Local variable 'ph' could be declared final 130
ShortVariable Avoid variables with short names like ph 130
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 133
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 146
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 146
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 148
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 153
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 153

org/apache/turbine/om/Retrievable.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 52

org/apache/turbine/om/Retriever.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 44

org/apache/turbine/om/RetrieverFactory.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 43

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1758
GodClass Possible God Class (WMC=67, ATFD=31, TCC=15.137%) 44758
RedundantFieldInitializer Avoid using redundant field initializer for 'lastAccessDate' 50
RedundantFieldInitializer Avoid using redundant field initializer for 'permStorage' 53
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 56
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 71) 56
RedundantFieldInitializer Avoid using redundant field initializer for 'userDelegate' 59
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 94
LocalVariableCouldBeFinal Local variable 'securityService' could be declared final 100102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 106
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 158
ShortVariable Avoid variables with short names like id 158
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 189
MethodArgumentCouldBeFinal Parameter 'firstName' is not assigned and could be declared final 211
MethodArgumentCouldBeFinal Parameter 'lastName' is not assigned and could be declared final 233
MethodArgumentCouldBeFinal Parameter 'address' is not assigned and could be declared final 255
MethodArgumentCouldBeFinal Parameter 'objectdata' is not assigned and could be declared final 280
MethodArgumentCouldBeFinal Parameter 'userGroupRoleSet' is not assigned and could be declared final 305
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 319
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 333
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 348
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 350
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 366
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 368
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 399
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 411
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 449467
LocalVariableCouldBeFinal Local variable 'objectdata' could be declared final 453
MethodArgumentCouldBeFinal Parameter 'permStorage' is not assigned and could be declared final 476
MethodArgumentCouldBeFinal Parameter 'tempStorage' is not assigned and could be declared final 507
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 522
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 524
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 536
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 536
LocalVariableCouldBeFinal Local variable 'val' could be declared final 540
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 540
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 541
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 543
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 556
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 556
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 558
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 568
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 570
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 582
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 582
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 587
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 593
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 607
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 607
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 609
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 619
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 621
MethodArgumentCouldBeFinal Parameter 'confirm' is not assigned and could be declared final 641
MethodArgumentCouldBeFinal Parameter 'createDate' is not assigned and could be declared final 663
MethodArgumentCouldBeFinal Parameter 'lastLogin' is not assigned and could be declared final 685
LocalVariableCouldBeFinal Local variable 'loggedIn' could be declared final 698
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 699
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 709
LocalVariableCouldBeFinal Local variable 'value' could be declared final 725
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 726
MethodArgumentCouldBeFinal Parameter 'userDelegate' is not assigned and could be declared final 754

org/apache/turbine/om/security/User.java

Rule Violation Line
LongVariable Avoid excessively long variable names like SESSION_ACCESS_COUNTER 60
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 288

org/apache/turbine/pipeline/CleanUpValve.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4952
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 58
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 65
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 79
LocalVariableCouldBeFinal Local variable 'data' could be declared final 81
CloseResource Ensure that resources like this RunData object are closed after use 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 8889
EmptyCatchBlock Avoid empty catch blocks 9195
LongVariable Avoid excessively long variable names like invalidatedSession 91

org/apache/turbine/pipeline/DefaultACLCreationValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4175
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
LongVariable Avoid excessively long variable names like actionAccessController 49
ImmutableField Private field 'actionAccessController' could be made final; it is only initialized in the declaration or constructor. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 67

org/apache/turbine/pipeline/DefaultLoginValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 50166
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 67
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 74
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 91
CognitiveComplexity The method 'process(PipelineData)' has a cognitive complexity of 21, current threshold is 15 91148
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 92
LocalVariableCouldBeFinal Local variable 'data' could be declared final 94
CloseResource Ensure that resources like this RunData object are closed after use 94
LocalVariableCouldBeFinal Local variable 'actionName' could be declared final 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 118
LocalVariableCouldBeFinal Local variable 'names' could be declared final 118
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 119141
LocalVariableCouldBeFinal Local variable 'nameList' could be declared final 123
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 126
LocalVariableCouldBeFinal Local variable 'session' could be declared final 129
LocalVariableCouldBeFinal Local variable 'name' could be declared final 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 134
LongVariable Avoid excessively long variable names like invalidatedSession 136
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 155
ShortVariable Avoid variables with short names like ti 160
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 160

org/apache/turbine/pipeline/DefaultPipelineData.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'innerKey' is not assigned and could be declared final 82
LocalVariableCouldBeFinal Local variable 'innerMap' could be declared final 84
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 89
LocalVariableCouldBeFinal Local variable 'rds' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98

org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4367
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 53
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 56
CloseResource Ensure that resources like this RunData object are closed after use 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 61

org/apache/turbine/pipeline/DefaultSessionValidationValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4178
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
LongVariable Avoid excessively long variable names like actionSessionValidator 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
ImmutableField Private field 'actionSessionValidator' could be made final; it is only initialized in the declaration or constructor. 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 70

org/apache/turbine/pipeline/DefaultSetEncodingValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4792
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 56
LocalVariableCouldBeFinal Local variable 'req' could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 63
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 87

org/apache/turbine/pipeline/DetermineActionValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4075
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 53
CloseResource Ensure that resources like this RunData object are closed after use 53
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 54
LocalVariableCouldBeFinal Local variable 'action' could be declared final 5657
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 57
ConfusingTernary Avoid if (x != y) ..; else ..; 5967

org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4851
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 73
CloseResource Ensure that resources like this RunData object are closed after use 76
LocalVariableCouldBeFinal Local variable 'data' could be declared final 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 78
LocalVariableCouldBeFinal Local variable 'requestRedirected' could be declared final 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 87

org/apache/turbine/pipeline/DetermineTargetValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4477
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 53
CloseResource Ensure that resources like this RunData object are closed after use 56
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 57
LocalVariableCouldBeFinal Local variable 'target' could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 59
ConfusingTernary Avoid if (x != y) ..; else ..; 6169

org/apache/turbine/pipeline/ExecutePageValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43120
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
ImmutableField Private field 'pageDefault' could be made final; it is only initialized in the declaration or constructor. 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 84
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 85

org/apache/turbine/pipeline/Pipeline.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 60

org/apache/turbine/pipeline/TurbinePipeline.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 48184
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
ImmutableField Private field 'state' could be made final; it is only initialized in the declaration or constructor. 71
LocalVariableCouldBeFinal Local variable 'v' could be declared final 84
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 97
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 116
MethodArgumentCouldBeFinal Parameter 'valves' is not assigned and could be declared final 139
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 148
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 157
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 161
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 171
LocalVariableCouldBeFinal Local variable 'current' could be declared final 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 181

org/apache/turbine/pipeline/Valve.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 100

org/apache/turbine/pipeline/XmlValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3458
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 54

org/apache/turbine/pipeline/XmlValveAdapter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 2952
MethodArgumentCouldBeFinal Parameter 'xmlValve' is not assigned and could be declared final 35
LocalVariableCouldBeFinal Local variable 'valveClass' could be declared final 37
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 38
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 38
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 45
LocalVariableCouldBeFinal Local variable 'xmlValve' could be declared final 47
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 48

org/apache/turbine/services/BaseInitable.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
RedundantFieldInitializer Avoid using redundant field initializer for 'isInitialized' 41
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5053
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 61
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 137

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 59278
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 63
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 96
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 102
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 105106
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 143
LocalVariableCouldBeFinal Local variable 'initable' could be declared final 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 150
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 176
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 177
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 227
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 228
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 236
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 236
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 239242
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 243269
UnusedAssignment The initializer for variable 'msg' is never used (overwritten on lines 250, 255, 260 and 265) 246
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 248
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 253
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 258

org/apache/turbine/services/BaseService.java

Rule Violation Line
DataClass The class 'BaseService' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=8) 37125
AtLeastOneConstructor Each class should declare at least one constructor 37125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 69
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 121

org/apache/turbine/services/BaseUnicastRemoteService.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
CallSuperInConstructor It is a good practice to call super() in a constructor 5562
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 60
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 114
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 141
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 162

org/apache/turbine/services/FieldAnnotatedTurbineBaseService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3763
AbstractNaming Abstract classes should be named AbstractXXX 3763

org/apache/turbine/services/InitableBroker.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 97

org/apache/turbine/services/InitializationException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 60
ShortVariable Avoid variables with short names like t 60

org/apache/turbine/services/InstantiationException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 51
ShortVariable Avoid variables with short names like t 63
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 63
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 63

org/apache/turbine/services/MethodAnnotatedTurbineBaseService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3459
AbstractNaming Abstract classes should be named AbstractXXX 3459

org/apache/turbine/services/ServiceBroker.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 95

org/apache/turbine/services/ServiceManager.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setServiceObject': the method is declared in an interface type 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'getServiceObject': the method is declared in an interface type 87

org/apache/turbine/services/TurbineBaseService.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 59124
AtLeastOneConstructor Each class should declare at least one constructor 59124
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 72
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 92

org/apache/turbine/services/TurbineServiceProvider.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 42

org/apache/turbine/services/TurbineServices.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 67
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6775
LocalVariableCouldBeFinal Local variable 'previous' could be declared final 69

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55306
RedundantFieldInitializer Avoid using redundant field initializer for 'factories' 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
RedundantFieldInitializer Avoid using redundant field initializer for 'assemblerCache' 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
RedundantFieldInitializer Avoid using redundant field initializer for 'loaderCache' 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
AvoidDuplicateLiterals The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 84 84
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103
LocalVariableCouldBeFinal Local variable 'names' could be declared final 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 105
LocalVariableCouldBeFinal Local variable 'name2' could be declared final 107
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 109
ShortVariable Avoid variables with short names like af 113
LocalVariableCouldBeFinal Local variable 'af' could be declared final 113114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 118121
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 124128
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 146
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LocalVariableCouldBeFinal Local variable 'i' could be declared final 148
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 148156
LocalVariableCouldBeFinal Local variable 'type' could be declared final 150
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 164166
LocalVariableCouldBeFinal Local variable 'cacheSize' could be declared final 170172
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 170172
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 190
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 192
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 211
CognitiveComplexity The method 'getAssembler(Class, String)' has a cognitive complexity of 21, current threshold is 15 211260
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 211
CyclomaticComplexity The method 'getAssembler(Class, String)' has a cyclomatic complexity of 10. 211260
LocalVariableCouldBeFinal Local variable 'key' could be declared final 214
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 225
LocalVariableCouldBeFinal Local variable 'it' could be declared final 227
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 229
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 233
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 235
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 240
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 240
LocalVariableCouldBeFinal Local variable 'oldAssembler' could be declared final 249
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 250253
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 273
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 285
LocalVariableCouldBeFinal Local variable 'it' could be declared final 287
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 289
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 290

org/apache/turbine/services/assemblerbroker/util/java/JavaActionFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44144
AbstractNaming Abstract classes should be named AbstractXXX 44144
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
MethodArgumentCouldBeFinal Parameter 'packageName' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 67
CognitiveComplexity The method 'getAssembler(String, String)' has a cognitive complexity of 19, current threshold is 15 67124
LocalVariableCouldBeFinal Local variable 'p' could be declared final 75
ShortVariable Avoid variables with short names like sb 77
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 77
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 77
LocalVariableCouldBeFinal Local variable 'className' could be declared final 80
LocalVariableCouldBeFinal Local variable '_servClass' could be declared final 90
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 9194
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 142

org/apache/turbine/services/assemblerbroker/util/java/JavaLayoutFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaNavigationFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaPageFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScheduledJobFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScreenFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 46

org/apache/turbine/services/assemblerbroker/util/python/PythonActionFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 48177
AbstractNaming Abstract classes should be named AbstractXXX 48177
LongVariable Avoid excessively long variable names like PYTHON_CONFIG_FILE 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
MethodArgumentCouldBeFinal Parameter 'subDirectory' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 71
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 72
LocalVariableCouldBeFinal Local variable 'path' could be declared final 74
LocalVariableCouldBeFinal Local variable 'confName' could be declared final 86
LocalVariableCouldBeFinal Local variable 'fName' could be declared final 89
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 91
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 92
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 92
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 93
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 94
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 94
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 95
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 95
ShortVariable Avoid variables with short names like f 98
LocalVariableCouldBeFinal Local variable 'f' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 112
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 130139
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 132138
LocalVariableCouldBeFinal Local variable 't' could be declared final 143
ShortVariable Avoid variables with short names like t 143
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 146
ExceptionAsFlowControl Avoid using exceptions as flow control. 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 175

org/apache/turbine/services/assemblerbroker/util/python/PythonLayoutFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonNavigationFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonPageFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/assemblerbroker/util/python/PythonScreenFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 49

org/apache/turbine/services/avaloncomponent/AvalonComponentService.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 37
LongVariable Avoid excessively long variable names like AVALON_LOG_CATEGORY 40
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 40
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_KEY 43
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 43
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_VALUE 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 49
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_KEY 49
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_VALUE 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 55
LongVariable Avoid excessively long variable names like COMPONENT_LOOKUP_KEY 55
LongVariable Avoid excessively long variable names like COMPONENT_APP_ROOT 58
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 58

org/apache/turbine/services/avaloncomponent/TurbineYaafiComponentService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44294
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_KEY 52
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_VALUE 55
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY 58
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 81
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 117
LocalVariableCouldBeFinal Local variable 'home' could be declared final 117
LocalVariableCouldBeFinal Local variable 'config' could be declared final 121122
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 132
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 148
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 159
MethodArgumentCouldBeFinal Parameter 'component' is not assigned and could be declared final 170
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 179
MethodArgumentCouldBeFinal Parameter 'applicationRoot' is not assigned and could be declared final 193
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 193
LocalVariableCouldBeFinal Local variable 'result' could be declared final 196
LongVariable Avoid excessively long variable names like containerConfiguration 207
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 207209
LocalVariableCouldBeFinal Local variable 'roleConfigurationFileName' could be declared final 217220
LongVariable Avoid excessively long variable names like roleConfigurationFileName 217
LongVariable Avoid excessively long variable names like componentConfigurationFileName 224
LocalVariableCouldBeFinal Local variable 'componentConfigurationFileName' could be declared final 224227
LongVariable Avoid excessively long variable names like parametersFileName 231
LocalVariableCouldBeFinal Local variable 'parametersFileName' could be declared final 231234
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 244247
LongVariable Avoid excessively long variable names like containerConfiguration 244
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 272
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 281
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 281
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 287292
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 289

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4087
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 51
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 51
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 51
UnusedAssignment The initializer for variable 'json_req' is never used (overwritten on line 58) 54
UnusedAssignment The initializer for variable 'json_res' is never used (overwritten on lines 75 and 80) 55
LocalVariableCouldBeFinal Local variable 'methodName' could be declared final 61
LocalVariableCouldBeFinal Local variable 'arguments' could be declared final 62
LocalVariableCouldBeFinal Local variable 'object_id' could be declared final 65
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 66
ShortVariable Avoid variables with short names like sb 66
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 69
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 71
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 71

org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 37102
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 45
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 46
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 46
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 52
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 54
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 58
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 58
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 61
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 77

org/apache/turbine/services/jsp/JspService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like BUFFER_SIZE_DEFAULT 56

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 53305
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
LongVariable Avoid excessively long variable names like relativeTemplatePaths 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 87
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 101
LocalVariableCouldBeFinal Local variable 'req' could be declared final 103
LocalVariableCouldBeFinal Local variable 'templateLink' could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 114
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 138
MethodArgumentCouldBeFinal Parameter 'isForward' is not assigned and could be declared final 138
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 138
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 146
LocalVariableCouldBeFinal Local variable 'data' could be declared final 146
LongVariable Avoid excessively long variable names like relativeTemplateName 149
LocalVariableCouldBeFinal Local variable 'relativeTemplateName' could be declared final 149
LocalVariableCouldBeFinal Local variable 'dispatcher' could be declared final 158159
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 158159
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 158159
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 170
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 180181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 180181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 182
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 205
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 215
LocalVariableCouldBeFinal Local variable 'config' could be declared final 217
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 221
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 232233
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 244
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 246
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 258
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 258
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 273
LocalVariableCouldBeFinal Local variable 'relativeTemplate' could be declared final 275
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 284
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 296
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 298
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 301

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 75
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 79
LocalVariableCouldBeFinal Local variable 'message' could be declared final 8182
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
EmptyCatchBlock Avoid empty catch blocks 8891

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 64
LocalVariableCouldBeFinal Local variable 'abs' could be declared final 6768
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 82
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 83
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 86
LocalVariableCouldBeFinal Local variable 'message' could be declared final 8889
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
EmptyCatchBlock Avoid empty catch blocks 9598

org/apache/turbine/services/localization/DateTimeFormatterInterface.java

Rule Violation Line
LongVariable Avoid excessively long variable names like DATE_TIME_FORMAT_KEY 33
UnnecessaryModifier Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_KEY': the field is declared in an interface type 33
UnnecessaryModifier Unnecessary modifier 'final' on field 'DATE_TIME_ZONEID_KEY': the field is declared in an interface type 35
LongVariable Avoid excessively long variable names like DATE_TIME_ZONEID_KEY 35
UnnecessaryModifier Unnecessary modifier 'final' on field 'USE_TURBINE_LOCALE_KEY': the field is declared in an interface type 37
LongVariable Avoid excessively long variable names like USE_TURBINE_LOCALE_KEY 37
LongVariable Avoid excessively long variable names like USE_REQUEST_LOCALE_KEY 39
UnnecessaryModifier Unnecessary modifier 'final' on field 'USE_REQUEST_LOCALE_KEY': the field is declared in an interface type 39
LongVariable Avoid excessively long variable names like DATE_TIME_FORMAT_DEFAULT 42
UnnecessaryModifier Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_DEFAULT': the field is declared in an interface type 42

org/apache/turbine/services/localization/DateTimeFormatterService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 48257
RedundantFieldInitializer Avoid using redundant field initializer for 'formatPattern' 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
RedundantFieldInitializer Avoid using redundant field initializer for 'dateTimeFormat' 54
RedundantFieldInitializer Avoid using redundant field initializer for 'locale' 56
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 9091
LocalVariableCouldBeFinal Local variable 'useTurbineLocale' could be declared final 9394
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 9394
LocalVariableCouldBeFinal Local variable 'localeSetter' could be declared final 9698
LocalVariableCouldBeFinal Local variable 'zoneIdStr' could be declared final 101102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101102
ConfusingTernary Avoid if (x != y) ..; else ..; 103104
LocalVariableCouldBeFinal Local variable 'zoneIdSet' could be declared final 103104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107108
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 117
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 123
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 123
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 129
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 129
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 129
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'zoneId' is not assigned and could be declared final 136
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 141 and 164) 137
ConfusingTernary Avoid if (x != y) ..; else ..; 147153
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 149
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 152
ConfusingTernary Avoid if (x != y) ..; else ..; 154160
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 159
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 164
LongVariable Avoid excessively long variable names like incomingFormatPattern 175
MethodArgumentCouldBeFinal Parameter 'outgoingFormatPattern' is not assigned and could be declared final 175
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 175
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 175
LongVariable Avoid excessively long variable names like outgoingFormatPattern 175
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 185
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 186
LocalVariableCouldBeFinal Local variable 'incomingFormat' could be declared final 188
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 199
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 199
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 204
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 210
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 211
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 218219
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 219
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 223
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 223
MethodArgumentCouldBeFinal Parameter 'incomingFormat' is not assigned and could be declared final 229
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 229
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 235
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 235
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 235
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 244
MethodArgumentCouldBeFinal Parameter 'zoneId' is not assigned and could be declared final 253

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
LongVariable Avoid excessively long variable names like localizationService 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 75
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 79
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 109
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 134
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 152

org/apache/turbine/services/localization/RundataLocalizationService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4379
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4379
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 48
LocalVariableCouldBeFinal Local variable 'user' could be declared final 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 51
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 55
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 55
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 69
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 50171
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPropsList' 61
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 86
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 86113
LocalVariableCouldBeFinal Local variable 'key' could be declared final 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
LocalVariableCouldBeFinal Local variable 'end' could be declared final 90
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 90
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 97
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 102 and 106) 98
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 106
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 109110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 109
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 115
LocalVariableCouldBeFinal Local variable 'key' could be declared final 117
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 118
LocalVariableCouldBeFinal Local variable 'context' could be declared final 119
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 119
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 129130
MethodArgumentCouldBeFinal Parameter 'contextName' is not assigned and could be declared final 146
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 154 and 158) 150
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 166

org/apache/turbine/services/pull/PullService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_KEY 82
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_DEFAULT 88
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_KEY 94
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_DEFAULT 97
LongVariable Avoid excessively long variable names like SESSION_TOOLS_ATTRIBUTE_PREFIX 100

org/apache/turbine/services/pull/tools/ContentTool.java

Rule Violation Line
LongVariable Avoid excessively long variable names like CONTENT_TOOL_PREFIX 54
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_KEY 62
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_DEFAULT 65
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_KEY 68
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_DEFAULT 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 74
DefaultPackage Use explicit scoping instead of the default package private level 74
RedundantFieldInitializer Avoid using redundant field initializer for 'wantEncoding' 74
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantEncoding field if you want a default access modifier 74
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantRelative field if you want a default access modifier 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 77
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 77
DefaultPackage Use explicit scoping instead of the default package private level 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 80
RedundantFieldInitializer Avoid using redundant field initializer for 'dataURI' 80
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8588
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 107
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 114
CloseResource Ensure that resources like this PipelineData object are closed after use 114
CloseResource Ensure that resources like this RunData object are closed after use 115
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 115
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 124125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 125
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 158
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 175
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 191

org/apache/turbine/services/pull/tools/TemplateLink.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 61633
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_PREFIX 63
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_KEY 66
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_DEFAULT 69
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 72
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_KEY 80
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_DEFAULT 83
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantEncoding field if you want a default access modifier 86
DefaultPackage Use explicit scoping instead of the default package private level 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 86
RedundantFieldInitializer Avoid using redundant field initializer for 'wantEncoding' 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 89
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 92
RedundantFieldInitializer Avoid using redundant field initializer for 'templateURI' 92
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 102105
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 124
CloseResource Ensure that resources like this PipelineData object are closed after use 131
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 131
CloseResource Ensure that resources like this RunData object are closed after use 132
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 132
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 140141
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 141
LinguisticNaming Linguistics Antipattern - The setter 'setEncodeURLOff' should not return any type except void linguistically 184188
LinguisticNaming Linguistics Antipattern - The setter 'setPage' should not return any type except void linguistically 196202
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 196
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 224
LinguisticNaming Linguistics Antipattern - The setter 'setAction' should not return any type except void linguistically 224229
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 241
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 241
LinguisticNaming Linguistics Antipattern - The setter 'setActionEvent' should not return any type except void linguistically 241246
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 257262
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 257
LinguisticNaming Linguistics Antipattern - The setter 'setReference' should not return any type except void linguistically 270274
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 270
ShortVariable Avoid variables with short names like pp 302
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 302
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 315
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 315
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 328
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 328
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 341
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 341
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 354
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 354
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 367
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 367
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 380
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 380
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 393
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 393
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 406
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 406
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 419
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 419
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 432
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 432
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 445
ShortVariable Avoid variables with short names like pp 445
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 468
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 491
LocalVariableCouldBeFinal Local variable 'output' could be declared final 521
LocalVariableCouldBeFinal Local variable 'output' could be declared final 556

org/apache/turbine/services/pull/tools/UITool.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 65390
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 132
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 160
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 174
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 188
MethodArgumentCouldBeFinal Parameter 'skin' is not assigned and could be declared final 206
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 206
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 225
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 225
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 243
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 243
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 255
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 274
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 292
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 322
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 322
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 340
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 340
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 352
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 364
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 378
CloseResource Ensure that resources like this PipelineData object are closed after use 378
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 379
CloseResource Ensure that resources like this RunData object are closed after use 379

org/apache/turbine/services/pull/util/DateFormatter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38119
LongVariable Avoid excessively long variable names like DATE_FORMAT_DEFAULT 42
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormat' 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 6667
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 103
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 110 and 115) 105
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 106

org/apache/turbine/services/pull/util/DateTimeFormatterTool.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 54218
TooManyMethods This class has too many methods, consider refactoring it. 56218
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
LongVariable Avoid excessively long variable names like localizationService 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
SingularField Perhaps 'overrideFromRequestLocale' could be replaced by a local variable. 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 69
RedundantFieldInitializer Avoid using redundant field initializer for 'overrideFromRequestLocale' 69
LongVariable Avoid excessively long variable names like overrideFromRequestLocale 69
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 93
LocalVariableCouldBeFinal Local variable 'serviceManager' could be declared final 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 140
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 151
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 153
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 157
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 157
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 159
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 163
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 163
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 163
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 165
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 169
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 169
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 169
MethodArgumentCouldBeFinal Parameter 'zoneId' is not assigned and could be declared final 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 171
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 175
LongVariable Avoid excessively long variable names like outgoingFormatPattern 175
MethodArgumentCouldBeFinal Parameter 'incomingFormatPattern' is not assigned and could be declared final 175
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 175
LongVariable Avoid excessively long variable names like incomingFormatPattern 175
MethodArgumentCouldBeFinal Parameter 'outgoingFormatPattern' is not assigned and could be declared final 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 177
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 181
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 181
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 182
MethodArgumentCouldBeFinal Parameter 'incomingFormat' is not assigned and could be declared final 182
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 184
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 188
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 188
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 190
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 190
MethodArgumentCouldBeFinal Parameter 'incomingFormat' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 194
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 196
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 196
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 200
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 200
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 200
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 202
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 202
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 209
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 215
ConfusingTernary Avoid if (x != y) ..; else ..; 215

org/apache/turbine/services/pull/util/SessionData.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 39118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 116

org/apache/turbine/services/rundata/RunDataService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like PARAMETER_PARSER_KEY 54

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Line
ModifiedCyclomaticComplexity The class 'AbstractJobEntry' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 35478
StdCyclomaticComplexity The class 'AbstractJobEntry' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 35478
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
RedundantFieldInitializer Avoid using redundant field initializer for 'jobIsActive' 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
RedundantFieldInitializer Avoid using redundant field initializer for 'runtime' 44
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 94
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 95
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 96
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 97
ShortVariable Avoid variables with short names like wd 97
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 98
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 99
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 129
ShortVariable Avoid variables with short names like je 129
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 187
LocalVariableCouldBeFinal Local variable 'schedrun' could be declared final 210
LocalVariableCouldBeFinal Local variable 'now' could be declared final 211
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 225
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 238
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 244
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 258
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 264
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 277
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 283
ModifiedCyclomaticComplexity The method 'evaluateJobType' has a Modified Cyclomatic Complexity of 10. 304375
CognitiveComplexity The method 'evaluateJobType()' has a cognitive complexity of 37, current threshold is 15 304375
StdCyclomaticComplexity The method 'evaluateJobType' has a Standard Cyclomatic Complexity of 10. 304375
CyclomaticComplexity The method 'evaluateJobType()' has a cyclomatic complexity of 21. 304375
AvoidDuplicateLiterals The String literal "Error in JobEntry. Bad Job parameter." appears 5 times in this file; the first occurrence is on line 323 323
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 326
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 337
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 349
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 361
ShortVariable Avoid variables with short names like v 391
ShortVariable Avoid variables with short names like v 405
ShortVariable Avoid variables with short names like v 419
ShortVariable Avoid variables with short names like v 433
ShortVariable Avoid variables with short names like v 447
ShortVariable Avoid variables with short names like v 461
ShortVariable Avoid variables with short names like v 477

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41364
TooManyMethods This class has too many methods, consider refactoring it. 42364
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
RedundantFieldInitializer Avoid using redundant field initializer for 'scheduleQueue' 47
ImmutableField Private field 'enabled' could be made final; it is only initialized in the declaration or constructor. 50
LongVariable Avoid excessively long variable names like houseKeepingThread 53
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 69
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 71
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 78
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 108
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 111
ShortVariable Avoid variables with short names like wd 118
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 141
ShortVariable Avoid variables with short names like je 141
ShortVariable Avoid variables with short names like je 155
ShortVariable Avoid variables with short names like je 166
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 185
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 205209
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 215224
LocalVariableCouldBeFinal Local variable 'thread' could be declared final 218
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 218
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 233
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 233236
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 241244
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 243
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 252275
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 262
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 272
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 284326
LocalVariableCouldBeFinal Local variable 'je' could be declared final 292
ShortVariable Avoid variables with short names like je 292
LocalVariableCouldBeFinal Local variable 'now' could be declared final 301
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 302
LocalVariableCouldBeFinal Local variable 'when' could be declared final 302
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 314
ShortVariable Avoid variables with short names like je 340
LocalVariableCouldBeFinal Local variable 'je' could be declared final 340
ConfusingTernary Avoid if (x != y) ..; else ..; 341351
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 343
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 346
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 346
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 354

org/apache/turbine/services/schedule/JobEntry.java

Rule Violation Line
ShortVariable Avoid variables with short names like v 74
ShortVariable Avoid variables with short names like v 88

org/apache/turbine/services/schedule/JobEntryNonPersistent.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 32
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 33
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 35
ShortVariable Avoid variables with short names like wd 35
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 36
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 81
ShortVariable Avoid variables with short names like wd 82
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 83
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 96
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 103
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 107
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 119
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 141
ShortVariable Avoid variables with short names like v 141
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 163
ShortVariable Avoid variables with short names like v 163
ShortVariable Avoid variables with short names like v 185
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 185
ShortVariable Avoid variables with short names like v 207
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 207
ShortVariable Avoid variables with short names like v 229
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 229
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 251
ShortVariable Avoid variables with short names like v 251
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 273
ShortVariable Avoid variables with short names like v 273

org/apache/turbine/services/schedule/JobEntryQuartz.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 47
ImmutableField Private field 'active' could be made final; it is only initialized in the declaration or constructor. 48
LongVariable Avoid excessively long variable names like DEFAULT_JOB_GROUP_NAME 53
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'jobDetail' is not assigned and could be declared final 81
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 95
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 117
ShortVariable Avoid variables with short names like v 117
ShortVariable Avoid variables with short names like v 139
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 139
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 155
ShortVariable Avoid variables with short names like o 172
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 172
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 219
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 235
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 237
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 250
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 252

org/apache/turbine/services/schedule/JobQueue.java

Rule Violation Line
UnusedAssignment The field initializer for 'queue' is never used (overwritten on line 48) 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
ImmutableField Private field 'queue' could be made final; it is only initialized in the declaration or constructor. 41
RedundantFieldInitializer Avoid using redundant field initializer for 'queue' 41
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 48
ConfusingTernary Avoid if (x != y) ..; else ..; 70
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 79
ShortVariable Avoid variables with short names like je 79
LocalVariableCouldBeFinal Local variable 'job' could be declared final 83
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 86
LocalVariableCouldBeFinal Local variable 'jobEntry' could be declared final 88
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 92
LooseCoupling Avoid using implementation types like 'Vector'; use the interface instead 104
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 104
ConfusingTernary Avoid if (x != y) ..; else ..; 106113
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 108
UseArrayListInsteadOfVector Use ArrayList instead of Vector 108
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 121
ShortVariable Avoid variables with short names like je 121
MethodArgumentCouldBeFinal Parameter 'jobEntries' is not assigned and could be declared final 132
ShortVariable Avoid variables with short names like je 145
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 145
ShortVariable Avoid variables with short names like je 156
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 156
ShortVariable Avoid variables with short names like je 169
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 169

org/apache/turbine/services/schedule/QuartzSchedulerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 49413
TooManyMethods This class has too many methods, consider refactoring it. 52413
RedundantFieldInitializer Avoid using redundant field initializer for 'enabled' 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 7374
LocalVariableCouldBeFinal Local variable 'qs' could be declared final 7374
ShortVariable Avoid variables with short names like qs 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 103
ShortVariable Avoid variables with short names like wd 103
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 103
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 107109
ShortVariable Avoid variables with short names like jd 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107109
LocalVariableCouldBeFinal Local variable 'csb' could be declared final 111
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113117
LocalVariableCouldBeFinal Local variable 't' could be declared final 113117
ShortVariable Avoid variables with short names like t 113
LocalVariableCouldBeFinal Local variable 'jeq' could be declared final 119
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'jeq' 121
ShortVariable Avoid variables with short names like wd 140
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 140
ShortVariable Avoid variables with short names like sb 142
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 142
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 143
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 144
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 161
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 175
LocalVariableCouldBeFinal Local variable 'je' could be declared final 178
ShortVariable Avoid variables with short names like je 196
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 196
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 202
ShortVariable Avoid variables with short names like jq 202
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 203
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 218
ShortVariable Avoid variables with short names like je 218
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 223
ShortVariable Avoid variables with short names like jq 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 224
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 224
ShortVariable Avoid variables with short names like je 240
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 240
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 246
ShortVariable Avoid variables with short names like jq 246
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 247
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 263
LocalVariableCouldBeFinal Local variable 'groupMatcher' could be declared final 267
LocalVariableCouldBeFinal Local variable 'jobKeys' could be declared final 268
LocalVariableCouldBeFinal Local variable 'jk' could be declared final 269
LocalVariableCouldBeFinal Local variable 'triggers' could be declared final 271
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 273
ShortVariable Avoid variables with short names like jd 277
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 277
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 278
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 278
LocalVariableCouldBeFinal Local variable 'job' could be declared final 278
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 298
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 318322
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 328340
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 348369
ConfusingTernary Avoid if (x != y) ..; else ..; 355362
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 361
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 377
ShortVariable Avoid variables with short names like je 377
MethodArgumentCouldBeFinal Parameter 'jd' is not assigned and could be declared final 409
ShortVariable Avoid variables with short names like jd 409
MethodArgumentCouldBeFinal Parameter 'trigger' is not assigned and could be declared final 409
LocalVariableCouldBeFinal Local variable 'job' could be declared final 410
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'job' 411

org/apache/turbine/services/schedule/ScheduleService.java

Rule Violation Line
ShortVariable Avoid variables with short names like wd 84
ShortVariable Avoid variables with short names like je 104
ShortVariable Avoid variables with short names like je 113
ShortVariable Avoid variables with short names like je 122

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38113
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'jobId' is not assigned and could be declared final 97
ShortVariable Avoid variables with short names like je 99

org/apache/turbine/services/schedule/TorqueSchedulerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38177
LocalVariableCouldBeFinal Local variable 'jobsTorque' could be declared final 52
LocalVariableCouldBeFinal Local variable 'job' could be declared final 54
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 71
ShortVariable Avoid variables with short names like wd 71
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 71
LocalVariableCouldBeFinal Local variable 'jet' could be declared final 73
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 94
ShortVariable Avoid variables with short names like je 98
LocalVariableCouldBeFinal Local variable 'je' could be declared final 98
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 116
ShortVariable Avoid variables with short names like je 116
LocalVariableCouldBeFinal Local variable 'c' could be declared final 121
ShortVariable Avoid variables with short names like c 121
ShortVariable Avoid variables with short names like je 145
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 145

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 68179
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 76
LocalVariableCouldBeFinal Local variable 'jobProps' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 77
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 82
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 84112
LocalVariableCouldBeFinal Local variable 'jobName' could be declared final 86
LocalVariableCouldBeFinal Local variable 'jobPrefix' could be declared final 87
LocalVariableCouldBeFinal Local variable 'jobId' could be declared final 89
LocalVariableCouldBeFinal Local variable 'sec' could be declared final 97
LocalVariableCouldBeFinal Local variable 'min' could be declared final 98
ShortVariable Avoid variables with short names like hr 99
LocalVariableCouldBeFinal Local variable 'hr' could be declared final 99
LocalVariableCouldBeFinal Local variable 'wkday' could be declared final 100
LocalVariableCouldBeFinal Local variable 'dayOfMonth' could be declared final 101
LocalVariableCouldBeFinal Local variable 'je' could be declared final 103109
ShortVariable Avoid variables with short names like je 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 110
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 122
ShortVariable Avoid variables with short names like wd 122
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 135
ShortVariable Avoid variables with short names like je 138
LocalVariableCouldBeFinal Local variable 'je' could be declared final 138
ShortVariable Avoid variables with short names like je 149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 163
ShortVariable Avoid variables with short names like je 163
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 174

org/apache/turbine/services/schedule/WorkerThread.java

Rule Violation Line
ShortVariable Avoid variables with short names like je 42
UnusedAssignment The field initializer for 'je' is never used (overwritten on line 54) 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
ImmutableField Private field 'je' could be made final; it is only initialized in the declaration or constructor. 42
RedundantFieldInitializer Avoid using redundant field initializer for 'je' 42
ShortVariable Avoid variables with short names like je 52
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 74
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 77
MethodArgumentCouldBeFinal Parameter 'state' is not assigned and could be declared final 97
UnnecessaryModifier Unnecessary modifier 'final' on method 'logStateChange': private methods cannot be overridden 97101

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 11127
GodClass Possible God Class (WMC=88, ATFD=39, TCC=8.956%) 741127
ExcessiveClassLength Avoid really long classes. 741127
CyclomaticComplexity The class 'DefaultSecurityService' has a total cyclomatic complexity of 88 (highest 4). 741127
AtLeastOneConstructor Each class should declare at least one constructor 741127
TooManyMethods This class has too many methods, consider refactoring it. 771127
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 79
ImmutableField Private field 'readerCount' could be made final; it is only initialized in the declaration or constructor. 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 82
RedundantFieldInitializer Avoid using redundant field initializer for 'userManager' 82
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 88
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 91
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 96
SingularField Perhaps 'backend' could be replaced by a local variable. 96
UnusedPrivateField Avoid unused private fields such as 'backend'. 96
RedundantFieldInitializer Avoid using redundant field initializer for 'globalGroup' 101
LocalVariableCouldBeFinal Local variable 'manager' could be declared final 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 120
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 124
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 128130
LocalVariableCouldBeFinal Local variable 'userManagerClassName' could be declared final 128130
LongVariable Avoid excessively long variable names like userManagerClassName 128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 139
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 160
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 180
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 186
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 211
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 228
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 236
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 258
MethodArgumentCouldBeFinal Parameter 'permName' is not assigned and could be declared final 274
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 282
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 304
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 321
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 329
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 358
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 361
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 375
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 378
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 395
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 395
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 399
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 413
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 416
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 431
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 444
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 446
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 459
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 462
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 478
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 481
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 495
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 495
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 498
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 510
AvoidDuplicateLiterals The String literal "user is null" appears 4 times in this file; the first occurrence is on line 514 514
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 518
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 533
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 533
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 534
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 538
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 556
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 556
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 559
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 582
ShortVariable Avoid variables with short names like g 646
LocalVariableCouldBeFinal Local variable 'g' could be declared final 646
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 660
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 677
ShortVariable Avoid variables with short names like id 677
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 693
LocalVariableCouldBeFinal Local variable 'role' could be declared final 696
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 714
ShortVariable Avoid variables with short names like id 714
LocalVariableCouldBeFinal Local variable 'role' could be declared final 718
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 736
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 753
ShortVariable Avoid variables with short names like id 753
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 813
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 816
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 835
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 835
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 835
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 856
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 856
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 856
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 878
MethodArgumentCouldBeFinal Parameter 'newRole' is not assigned and could be declared final 878
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 878
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 895
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 914
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 914
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 930
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 930
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 947
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 969
MethodArgumentCouldBeFinal Parameter 'cascadeDelete' is not assigned and could be declared final 969
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 985
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 1000
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 1015
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 1030
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 1045
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 1059
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 1074
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1090
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 1090
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1106
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 1106
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1122
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 1122

org/apache/turbine/services/security/SecurityService.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1757
TooManyMethods This class has too many methods, consider refactoring it. 66757
LongVariable Avoid excessively long variable names like USER_MANAGER_DEFAULT 80
LongVariable Avoid excessively long variable names like USER_WRAPPER_DEFAULT 93
ShortVariable Avoid variables with short names like u 272
ShortVariable Avoid variables with short names like id 538
ShortVariable Avoid variables with short names like id 568
ShortVariable Avoid variables with short names like id 598

org/apache/turbine/services/security/UserManager.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48301
ShortVariable Avoid variables with short names like u 258

org/apache/turbine/services/security/passive/PassiveUserManager.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 46365
TooManyMethods This class has too many methods, consider refactoring it. 47365
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 69
AvoidDuplicateLiterals The String literal "PassiveUserManager knows no users" appears 10 times in this file; the first occurrence is on line 72 72
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 124
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 147
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 147
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 165
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 184
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'initialPassword' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 237
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 257
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 257
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 258
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 281
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 281
MethodArgumentCouldBeFinal Parameter 'u' is not assigned and could be declared final 311
ShortVariable Avoid variables with short names like u 311
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 346
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 361

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 51254
RedundantFieldInitializer Avoid using redundant field initializer for 'servletContext' 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
RedundantFieldInitializer Avoid using redundant field initializer for 'servletConfig' 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 78
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 114
EmptyCatchBlock Avoid empty catch blocks 117120
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 133
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 137
UnusedAssignment The initializer for variable 'is' is never used (overwritten on line 141) 140
ShortVariable Avoid variables with short names like is 140
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 154
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 162
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 250

org/apache/turbine/services/session/SessionListener.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 61141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 86
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 127
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 139

org/apache/turbine/services/session/SessionTool.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 38141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 48
ShortVariable Avoid variables with short names like o 48
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 125
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 137

org/apache/turbine/services/session/TurbineSessionService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55222
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 92
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111
LocalVariableCouldBeFinal Local variable 'session' could be declared final 128
LocalVariableCouldBeFinal Local variable 'u' could be declared final 130
ShortVariable Avoid variables with short names like u 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 131
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 147
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 154
MethodArgumentCouldBeFinal Parameter 'sessionId' is not assigned and could be declared final 169
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 182
LocalVariableCouldBeFinal Local variable 'sessions' could be declared final 184
LocalVariableCouldBeFinal Local variable 'session' could be declared final 185
LocalVariableCouldBeFinal Local variable 'u' could be declared final 187
ShortVariable Avoid variables with short names like u 187
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 217

org/apache/turbine/services/template/BaseTemplateEngineService.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 38145
AtLeastOneConstructor Each class should declare at least one constructor 38145
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 53
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 53
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 70
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 97
LocalVariableCouldBeFinal Local variable 'config' could be declared final 99
LongVariable Avoid excessively long variable names like fileExtensionAssociations 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 106
LocalVariableCouldBeFinal Local variable 'copyParams' could be declared final 124132
LocalVariableCouldBeFinal Local variable 'copyParam' could be declared final 134

org/apache/turbine/services/template/TemplateEngineService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like TEMPLATE_EXTENSIONS 35
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_EXTENSION 37
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION 45
LongVariable Avoid excessively long variable names like DEFAULT_ERROR_SCREEN 47
LongVariable Avoid excessively long variable names like DEFAULT_LAYOUT_TEMPLATE 49
LongVariable Avoid excessively long variable names like DEFAULT_SCREEN_TEMPLATE 51
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION_TEMPLATE 53
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 60
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 60

org/apache/turbine/services/template/TemplateService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_KEY 49
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_VALUE 52
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_KEY 55
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_VALUE 58
LongVariable Avoid excessively long variable names like EXTENSION_SEPARATOR 61
LongVariable Avoid excessively long variable names like TEMPLATE_PARTS_SEPARATOR 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 218
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 229
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 240
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 251
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 262
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 273

org/apache/turbine/services/template/mapper/BaseMapper.java

Rule Violation Line
DataClass The class 'BaseMapper' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=8, WMC=21) 40226
AbstractNaming Abstract classes should be named AbstractXXX 40226
RedundantFieldInitializer Avoid using redundant field initializer for 'useCache' 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
RedundantFieldInitializer Avoid using redundant field initializer for 'templateCache' 49
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6669
MethodArgumentCouldBeFinal Parameter 'cacheSize' is not assigned and could be declared final 84
MethodArgumentCouldBeFinal Parameter 'useCache' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'defaultProperty' is not assigned and could be declared final 120
MethodArgumentCouldBeFinal Parameter 'separator' is not assigned and could be declared final 138
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 166
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 170
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 171
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 171
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 175
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 178179
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 178179
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 178179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 182
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 193
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 197
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 202
LocalVariableCouldBeFinal Local variable 'res' could be declared final 205

org/apache/turbine/services/template/mapper/BaseTemplateMapper.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 37117
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4851
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 83
LocalVariableCouldBeFinal Local variable 'components' could be declared final 8889
LocalVariableCouldBeFinal Local variable 'resBuf' could be declared final 93
LocalVariableCouldBeFinal Local variable 'templateComponents' could be declared final 95
LongVariable Avoid excessively long variable names like templateComponents 95
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 106

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'loader' 60
CallSuperInConstructor It is a good practice to call super() in a constructor 7073
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7073
MethodArgumentCouldBeFinal Parameter 'loader' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 102
CognitiveComplexity The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 102178
LocalVariableCouldBeFinal Local variable 'components' could be declared final 107110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 121
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
LiteralsFirstInComparisons Position literals first in String comparisons 127
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 127
LocalVariableCouldBeFinal Local variable 'pkg' could be declared final 131
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 132
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 132
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 151
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 157
EmptyCatchBlock Avoid empty catch blocks 157160

org/apache/turbine/services/template/mapper/DirectMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4346
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 57
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 65
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 66

org/apache/turbine/services/template/mapper/DirectTemplateMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4447
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 58
LocalVariableCouldBeFinal Local variable 'components' could be declared final 6061

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 6265
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6265
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 75
CognitiveComplexity The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 75166
LocalVariableCouldBeFinal Local variable 'components' could be declared final 7982
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 87
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 94
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 94
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 98
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 107
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 111
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 115
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 115
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 128
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 128
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 141

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5861
CallSuperInConstructor It is a good practice to call super() in a constructor 5861
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 71
LocalVariableCouldBeFinal Local variable 'components' could be declared final 7578
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 83
UnusedAssignment The updated value of variable 'componentSize' is never used 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 89
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 89
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 94
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 102
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 106
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 110
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 110
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 123
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 123
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 136

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4750
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 60
LocalVariableCouldBeFinal Local variable 'components' could be declared final 62
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 66
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 66
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 68
LocalVariableCouldBeFinal Local variable 'testPath' could be declared final 71
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 79

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
ShortVariable Avoid variables with short names like md 79
LocalVariableCouldBeFinal Local variable 'md' could be declared final 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LocalVariableCouldBeFinal Local variable 'bytesId' could be declared final 80
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 88
LocalVariableCouldBeFinal Local variable 'current' could be declared final 130
ShortVariable Avoid variables with short names like id 131
UseUnderscoresInNumericLiterals Number 100000000 should separate every third digit with an underscore 135
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 135

org/apache/turbine/services/urlmapper/MappedTemplateLink.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 50118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56

org/apache/turbine/services/urlmapper/URLMapperService.java

Rule Violation Line
ShortVariable Avoid variables with short names like pp 57

org/apache/turbine/services/urlmapper/URLMapperValve.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3961
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 53
CloseResource Ensure that resources like this RunData object are closed after use 53
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 54
LocalVariableCouldBeFinal Local variable 'uri' could be declared final 54
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 56

org/apache/turbine/services/urlmapper/model/URLMapEntry.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 44175
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
RedundantFieldInitializer Avoid using redundant field initializer for 'relevantKeys' 52
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'implicit' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'ignore' is not assigned and could be declared final 106
MethodArgumentCouldBeFinal Parameter 'override' is not assigned and could be declared final 125
MethodArgumentCouldBeFinal Parameter 'groupNamesMap' is not assigned and could be declared final 145
MethodArgumentCouldBeFinal Parameter 'relevantKeys' is not assigned and could be declared final 165

org/apache/turbine/services/urlmapper/model/URLMappingContainer.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 4398
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'newURLMapEntries' is not assigned and could be declared final 94

org/apache/turbine/services/urlmapper/model/XmlParameterAdapter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3562
MethodArgumentCouldBeFinal Parameter 'xmlList' is not assigned and could be declared final 41
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 4446
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 4446
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 53
LocalVariableCouldBeFinal Local variable 'xmlList' could be declared final 55
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 5658
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 5658
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 5658

org/apache/turbine/services/urlmapper/model/XmlParameterList.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 55108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 79
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 86
MethodArgumentCouldBeFinal Parameter 'xmlParameters' is not assigned and could be declared final 104

org/apache/turbine/services/urlmapper/model/XmlPatternAdapter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3150
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 37
MethodArgumentCouldBeFinal Parameter 'pattern' is not assigned and could be declared final 46

org/apache/turbine/services/velocity/VelocityService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like VELOCITY_EXTENSION 52
LongVariable Avoid excessively long variable names like CATCH_ERRORS_DEFAULT 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 76

org/apache/turbine/util/BrowserDetector.java

Rule Violation Line
DataClass The class 'BrowserDetector' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=4, WMC=9) 41172
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 78
LocalVariableCouldBeFinal Local variable 'userAgent' could be declared final 81
LocalVariableCouldBeFinal Local variable 'version' could be declared final 85
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 97
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 157
ShortVariable Avoid variables with short names like s 168
UnnecessaryModifier Unnecessary modifier 'final' on method 'toFloat': private methods cannot be overridden 168171
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 168

org/apache/turbine/util/FormMessage.java

Rule Violation Line
DataClass The class 'FormMessage' is suspected to be a Data Class (WOC=18.182%, NOPA=0, NOAM=5, WMC=12) 33161
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 52
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 80
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 113
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 131
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 141
ShortVariable Avoid variables with short names like sb 153
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 153
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 154
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 155
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 157

org/apache/turbine/util/FormMessages.java

Rule Violation Line
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 36
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 36
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 38
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 40
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 40
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 42
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
MethodArgumentCouldBeFinal Parameter 'returnCode' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'messageName' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 74
LocalVariableCouldBeFinal Local variable 'formFieldName' could be declared final 76
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 90
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 90
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 90
ConfusingTernary Avoid if (x != y) ..; else ..; 94107
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 117
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 117
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 117
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 117
UnnecessaryModifier Unnecessary modifier 'final' on method 'getValues': private methods cannot be overridden 117120
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 128
LocalVariableCouldBeFinal Local variable 'field' could be declared final 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 151
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 163
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 163
LocalVariableCouldBeFinal Local variable 'key' could be declared final 165
LocalVariableCouldBeFinal Local variable 'messages' could be declared final 167
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 179
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 191
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 191
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 193
LocalVariableCouldBeFinal Local variable 'field' could be declared final 194
StringToString Avoid calling toString() on String objects; this is unnecessary. 196
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 198

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 40159
RedundantFieldInitializer Avoid using redundant field initializer for 'session_count' 50
RedundantFieldInitializer Avoid using redundant field initializer for 'lastTimeVal' 51
UseUnderscoresInNumericLiterals Number 2176782336L should separate every third digit with an underscore 61
LongVariable Avoid excessively long variable names like maxSessionLifespanTics 69
UseUnderscoresInNumericLiterals Number 46656 should separate every third digit with an underscore 69
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 85130
LocalVariableCouldBeFinal Local variable 'sessionId' could be declared final 87
ShortVariable Avoid variables with short names like n 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111112
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 138145
MethodArgumentCouldBeFinal Parameter 'jsIdent' is not assigned and could be declared final 138
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 142
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 152

org/apache/turbine/util/HttpUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 4085
MethodArgumentCouldBeFinal Parameter 'date' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 70
MethodArgumentCouldBeFinal Parameter 'expiry' is not assigned and could be declared final 70
LocalVariableCouldBeFinal Local variable 'response' could be declared final 72

org/apache/turbine/util/InputFilterUtils.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 3568
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3568
ShortVariable Avoid variables with short names like s 45
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 45
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 58
ShortVariable Avoid variables with short names like s 58

org/apache/turbine/util/LocaleUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 62248
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultLocale' 67
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultCharSet' 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 8082
LocalVariableCouldBeFinal Local variable 'inputEncoding' could be declared final 8082
NonThreadSafeSingleton Singleton is not thread safe 100113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103105
LocalVariableCouldBeFinal Local variable 'lang' could be declared final 103105
LocalVariableCouldBeFinal Local variable 'country' could be declared final 107109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 127
CognitiveComplexity The method 'getDefaultCharset()' has a cognitive complexity of 15, current threshold is 15 136190
NonThreadSafeSingleton Singleton is not thread safe 138150
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 141143
LocalVariableCouldBeFinal Local variable 'charSet' could be declared final 141143
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 161
LocalVariableCouldBeFinal Local variable 'serviceManager' could be declared final 164
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 165
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 165178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 169
LocalVariableCouldBeFinal Local variable 'mimeTypeService' could be declared final 169
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 170
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 172
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 202203
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 215216
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 215216
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 220
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 234
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 238

org/apache/turbine/util/ObjectUtils.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 36102
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 36102
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 48
UnusedAssignment The initializer for variable 'byteArray' is never used (overwritten on line 66) 50
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 50
LocalVariableCouldBeFinal Local variable 'value' could be declared final 52
MethodArgumentCouldBeFinal Parameter 'objectData' is not assigned and could be declared final 81
ShortVariable Avoid variables with short names like in 88
EmptyCatchBlock Avoid empty catch blocks 9497
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 94

org/apache/turbine/util/RunData.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1637
ShortVariable Avoid variables with short names like ct 464
ShortVariable Avoid variables with short names like sc 494

org/apache/turbine/util/SecurityCheck.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 55
RedundantFieldInitializer Avoid using redundant field initializer for 'securityService' 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 72
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'initialize' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 91
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 109
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 110
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 115
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 136
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 136
UnusedAssignment The initializer for variable 'roleObject' is never used (overwritten on lines 142 and 148) 138
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 142
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 149
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 150
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 150
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 172
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 173
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 176
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 178
CognitiveComplexity The method 'hasPermission(String)' has a cognitive complexity of 17, current threshold is 15 204257
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 204
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 205
UnusedAssignment The initializer for variable 'permissionObject' is never used (overwritten on lines 210 and 216) 207
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 210
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 217
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 220
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 221
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 222
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 233
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 234
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 246
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 247

org/apache/turbine/util/ServerData.java

Rule Violation Line
DataClass The class 'ServerData' is suspected to be a Data Class (WOC=18.750%, NOPA=0, NOAM=10, WMC=22) 42279
RedundantFieldInitializer Avoid using redundant field initializer for 'serverName' 45
RedundantFieldInitializer Avoid using redundant field initializer for 'serverPort' 48
RedundantFieldInitializer Avoid using redundant field initializer for 'serverScheme' 51
RedundantFieldInitializer Avoid using redundant field initializer for 'scriptName' 54
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPath' 57
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 72
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 98
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 115
CloneMethodMustImplementCloneable clone() method should be implemented only if implementing Cloneable interface 130134
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 130134
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 130134
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 151
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 172
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 193
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 214
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 235
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 246
LinguisticNaming Linguistics Antipattern - The getter 'getHostUrl' should not return void linguistically 246261
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 248
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 251
LiteralsFirstInComparisons Position literals first in String comparisons 251
LiteralsFirstInComparisons Position literals first in String comparisons 254
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 254
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 258
LocalVariableCouldBeFinal Local variable 'url' could be declared final 271
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 275

org/apache/turbine/util/ServletUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 43103
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'text' is not assigned and could be declared final 55
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 59
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 64
AvoidFinalLocalVariable Avoid using final local variables, turn them into fields 67
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 70
ShortVariable Avoid variables with short names like sb 72
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 72
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 73
LocalVariableCouldBeFinal Local variable 'context' could be declared final 82
LocalVariableCouldBeFinal Local variable 'base' could be declared final 8384
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 83
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 88
LocalVariableCouldBeFinal Local variable 'tokenizer' could be declared final 91
LocalVariableCouldBeFinal Local variable 'buffer' could be declared final 92

org/apache/turbine/util/SystemError.java

Rule Violation Line
DoNotExtendJavaLangError Exceptions should not extend java.lang.Error 33
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 64

org/apache/turbine/util/TurbineException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 112
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 124
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 137
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 137

org/apache/turbine/util/TurbineRuntimeException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 80

org/apache/turbine/util/TurbineXmlConfig.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 76
MethodArgumentCouldBeFinal Parameter 'attributes' is not assigned and could be declared final 76
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 77
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 95
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 95
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 109
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 109

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 105690
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 128
RedundantFieldInitializer Avoid using redundant field initializer for 'doctype' 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 131
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeRootElement 131
ImmutableField Private field 'defaultHtmlDoctypeRootElement' could be made final; it is only initialized in the declaration or constructor. 131
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeIdentifier 134
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 134
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 137
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeUri 137
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 154
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 156
LinguisticNaming Linguistics Antipattern - The setter 'setTitle' should not return any type except void linguistically 183187
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 183
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 200
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 212
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 212
MethodArgumentCouldBeFinal Parameter 'scriptURL' is not assigned and could be declared final 234
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 257
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 272273
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 272
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 273
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 273
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 273
ShortVariable Avoid variables with short names like ss 275
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 275
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 290
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 290
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 317
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 317
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 317
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 317318
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 318
ShortVariable Avoid variables with short names like ss 320
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 320
MethodArgumentCouldBeFinal Parameter 'styleText' is not assigned and could be declared final 343
LinguisticNaming Linguistics Antipattern - The setter 'setKeywords' should not return any type except void linguistically 365369
MethodArgumentCouldBeFinal Parameter 'keywords' is not assigned and could be declared final 365
MethodArgumentCouldBeFinal Parameter 'httpEquiv' is not assigned and could be declared final 380
LinguisticNaming Linguistics Antipattern - The setter 'setHttpEquiv' should not return any type except void linguistically 380384
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 380
MethodArgumentCouldBeFinal Parameter 'description' is not assigned and could be declared final 392
LinguisticNaming Linguistics Antipattern - The setter 'setDescription' should not return any type except void linguistically 392396
LinguisticNaming Linguistics Antipattern - The setter 'setBackground' should not return any type except void linguistically 404408
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 404
LinguisticNaming Linguistics Antipattern - The setter 'setBgColor' should not return any type except void linguistically 418422
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 418
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 431
LinguisticNaming Linguistics Antipattern - The setter 'setTextColor' should not return any type except void linguistically 431435
LinguisticNaming Linguistics Antipattern - The setter 'setLinkColor' should not return any type except void linguistically 444448
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 444
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 456
LinguisticNaming Linguistics Antipattern - The setter 'setVlinkColor' should not return any type except void linguistically 456460
LinguisticNaming Linguistics Antipattern - The setter 'setAlinkColor' should not return any type except void linguistically 468472
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 468
DataClass The class 'LinkTag' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=9, WMC=15) 508626
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 523
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 523
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 544
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 562
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 582
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 602
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 622
LocalVariableCouldBeFinal Local variable 'tag' could be declared final 643
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 666
MethodArgumentCouldBeFinal Parameter 'identifier' is not assigned and could be declared final 666
MethodArgumentCouldBeFinal Parameter 'tag' is not assigned and could be declared final 666
LocalVariableCouldBeFinal Local variable 'doctypeBuf' could be declared final 668

org/apache/turbine/util/template/TemplateInfo.java

Rule Violation Line
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE 47
UnusedAssignment The field initializer for 'data' is never used (overwritten on line 66) 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
ImmutableField Private field 'data' could be made final; it is only initialized in the declaration or constructor. 54
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 54
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 67) 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
ImmutableField Private field 'tempStorage' could be made final; it is only initialized in the declaration or constructor. 57
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 64
ShortVariable Avoid variables with short names like v 85
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 107
ShortVariable Avoid variables with short names like v 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 109
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 120
EmptyCatchBlock Avoid empty catch blocks 120125
LocalVariableCouldBeFinal Local variable 'value' could be declared final 135
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'value' 136
ShortVariable Avoid variables with short names like v 144
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 156
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 167
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 167
ShortVariable Avoid variables with short names like v 167
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 187
ShortVariable Avoid variables with short names like v 187
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 198
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 210
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 210
LocalVariableCouldBeFinal Local variable 'val' could be declared final 214
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 215
ConfusingTernary Avoid if (x != y) ..; else ..; 215
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 217
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 240
LocalVariableCouldBeFinal Local variable 'object' could be declared final 243
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 257
LocalVariableCouldBeFinal Local variable 'object' could be declared final 260
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 275
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 287

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 62
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 7479
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 101102
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 101102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 111
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 113

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 77
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 7781
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 95
LocalVariableCouldBeFinal Local variable 'results' could be declared final 95
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 102

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Line
DataClass The class 'TemplateSecurityCheck' is suspected to be a Data Class (WOC=27.273%, NOPA=0, NOAM=6, WMC=18) 52228
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 79
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 8283
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 94
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 99
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 106
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 108
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 121
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 122
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 125
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 126
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 129
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 144
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 149152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 150152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 157158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 160
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 173
ShortVariable Avoid variables with short names like v 173
ShortVariable Avoid variables with short names like v 204
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 204
ShortVariable Avoid variables with short names like v 224
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 224

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 46520
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
RedundantFieldInitializer Avoid using redundant field initializer for 'redirect' 58
RedundantFieldInitializer Avoid using redundant field initializer for 'response' 61
RedundantFieldInitializer Avoid using redundant field initializer for 'reference' 64
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 102
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 114
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 126
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 126
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 148
ConfusingTernary Avoid if (x != y) ..; else ..; 152163
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 164
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 181
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 213
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 234
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 272
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 289
MethodArgumentCouldBeFinal Parameter 'port' is not assigned and could be declared final 311
LocalVariableCouldBeFinal Local variable 'useSSL' could be declared final 313316
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 314316
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 327
LocalVariableCouldBeFinal Local variable 'serverScheme' could be declared final 342
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 352
MethodArgumentCouldBeFinal Parameter 'response' is not assigned and could be declared final 393
ShortVariable Avoid variables with short names like sb 421
LinguisticNaming Linguistics Antipattern - The getter 'getContextAndScript' should not return void linguistically 421445
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 421
LocalVariableCouldBeFinal Local variable 'context' could be declared final 423
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 427
LocalVariableCouldBeFinal Local variable 'script' could be declared final 435
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 439
ShortVariable Avoid variables with short names like sb 459
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 459
LinguisticNaming Linguistics Antipattern - The getter 'getSchemeAndPort' should not return void linguistically 459475
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 462
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 463
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 467
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 469
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 486
LocalVariableCouldBeFinal Local variable 'response' could be declared final 490
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 510

org/apache/turbine/util/uri/DataURI.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 68
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 89
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 89
LocalVariableCouldBeFinal Local variable 'output' could be declared final 126
LocalVariableCouldBeFinal Local variable 'output' could be declared final 164

org/apache/turbine/util/uri/TemplateURI.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 70
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 70
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 94
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 94
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 94
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 107
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 107
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 107
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 132
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 143
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 143
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 154
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 154
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 167
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 167
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 167
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 180
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 180
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 180
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 206
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 206
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 266
ShortVariable Avoid variables with short names like pp 267
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 267
LocalVariableCouldBeFinal Local variable 'name' could be declared final 269
LocalVariableCouldBeFinal Local variable 'key' could be declared final 271
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 273
LocalVariableCouldBeFinal Local variable 'values' could be declared final 275
ConfusingTernary Avoid if (x != y) ..; else ..; 276286
LocalVariableCouldBeFinal Local variable 'value' could be declared final 278

org/apache/turbine/util/uri/URIConstants.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 36
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 39
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 42
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 45
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 54
LongVariable Avoid excessively long variable names like URI_SCHEME_SEPARATOR 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 63
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 66
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 69
LongVariable Avoid excessively long variable names like CGI_TEMPLATE_PARAM 69
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 72

org/apache/turbine/util/uri/URIParam.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'key' 37
ImmutableField Private field 'key' could be made final; it is only initialized in the declaration or constructor. 37
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 37
UnusedAssignment The field initializer for 'key' is never used (overwritten on line 51) 37
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 40
RedundantFieldInitializer Avoid using redundant field initializer for 'value' 40
ImmutableField Private field 'value' could be made final; it is only initialized in the declaration or constructor. 40
UnusedAssignment The field initializer for 'value' is never used (overwritten on line 52) 40
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 90
IfStmtsMustUseBraces Avoid using if statements without curly braces 9293
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 93
ControlStatementBraces This statement should have braces 93
IfStmtsMustUseBraces Avoid using if statements without curly braces 9495
ControlStatementBraces This statement should have braces 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 95
IfStmtsMustUseBraces Avoid using if statements without curly braces 9697
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 97
ControlStatementBraces This statement should have braces 97
LocalVariableCouldBeFinal Local variable 'other' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 101

org/apache/turbine/util/uri/URIUtils.java

Rule Violation Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3453
AbstractNaming Abstract classes should be named AbstractXXX 3453
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 47
LocalVariableCouldBeFinal Local variable 'du' could be declared final 49
ShortVariable Avoid variables with short names like du 49

org/apache/turbine/util/velocity/VelocityActionEvent.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 5190
AtLeastOneConstructor Each class should declare at least one constructor 5190
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
RedundantFieldInitializer Avoid using redundant field initializer for 'initialized' 58
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 66
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 77
ShortVariable Avoid variables with short names like pp 85
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 85
LocalVariableCouldBeFinal Local variable 'context' could be declared final 86

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'wordWrap' 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 116
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 116
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 119
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 133
LinguisticNaming Linguistics Antipattern - The setter 'setTo' should not return any type except void linguistically 149154
MethodArgumentCouldBeFinal Parameter 'toName' is not assigned and could be declared final 149
MethodArgumentCouldBeFinal Parameter 'toEmail' is not assigned and could be declared final 149
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 164168
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 164
LinguisticNaming Linguistics Antipattern - The setter 'setWordWrap' should not return any type except void linguistically 181185
MethodArgumentCouldBeFinal Parameter 'wordWrap' is not assigned and could be declared final 181
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 194
LinguisticNaming Linguistics Antipattern - The setter 'setContext' should not return any type except void linguistically 194198
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 234236
UnusedAssignment The initializer for variable 'body' is never used (overwritten on line 256) 251
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 255
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 256
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 258

org/apache/turbine/util/velocity/VelocityEmailException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 78

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'htmlTemplate' 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 94
RedundantFieldInitializer Avoid using redundant field initializer for 'textTemplate' 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 103
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 106
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 106
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 106
RedundantFieldInitializer Avoid using redundant field initializer for 'embmap' 106
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 124
LinguisticNaming Linguistics Antipattern - The setter 'setHtmlTemplate' should not return any type except void linguistically 139143
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 139
LinguisticNaming Linguistics Antipattern - The setter 'setTextTemplate' should not return any type except void linguistically 153157
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 153
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 182184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 199
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 199
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 207
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 243
MethodArgumentCouldBeFinal Parameter 'surl' is not assigned and could be declared final 243
LocalVariableCouldBeFinal Local variable 'url' could be declared final 248
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 266
LocalVariableCouldBeFinal Local variable 'cid' could be declared final 268

org/apache/turbine/services/schedule/BaseJobEntryTorque.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1887
AbstractNaming Abstract classes should be named AbstractXXX 25887
AtLeastOneConstructor Each class should declare at least one constructor 25887
ModifiedCyclomaticComplexity The class 'BaseJobEntryTorque' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 25887
StdCyclomaticComplexity The class 'BaseJobEntryTorque' has a Standard Cyclomatic Complexity of 2 (Highest = 12). 25887
CyclomaticComplexity The class 'BaseJobEntryTorque' has a total cyclomatic complexity of 80 (highest 12). 25887
GodClass Possible God Class (WMC=80, ATFD=31, TCC=2.211%) 25887
TooManyMethods This class has too many methods, consider refactoring it. 27887
RedundantFieldInitializer Avoid using redundant field initializer for 'jobId' 34
RedundantFieldInitializer Avoid using redundant field initializer for 'task' 52
RedundantFieldInitializer Avoid using redundant field initializer for 'email' 55
RedundantFieldInitializer Avoid using redundant field initializer for 'property' 58
AvoidFieldNameMatchingMethodName Field isNew has the same name as a method 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
RedundantFieldInitializer Avoid using redundant field initializer for 'saving' 70
RedundantFieldInitializer Avoid using redundant field initializer for 'loading' 76
RedundantFieldInitializer Avoid using redundant field initializer for 'deleted' 83
MissingOverride The method 'getJobId()' is missing an @Override annotation. 9498
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 105
ShortVariable Avoid variables with short names like v 105
MissingOverride The method 'setJobId(int)' is missing an @Override annotation. 105115
MissingOverride The method 'getSecond()' is missing an @Override annotation. 122126
MissingOverride The method 'setSecond(int)' is missing an @Override annotation. 133143
ShortVariable Avoid variables with short names like v 133
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 133
MissingOverride The method 'getMinute()' is missing an @Override annotation. 150154
MissingOverride The method 'setMinute(int)' is missing an @Override annotation. 161171
ShortVariable Avoid variables with short names like v 161
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 161
MissingOverride The method 'getHour()' is missing an @Override annotation. 178182
ShortVariable Avoid variables with short names like v 189
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 189
MissingOverride The method 'setHour(int)' is missing an @Override annotation. 189199
MissingOverride The method 'getWeekDay()' is missing an @Override annotation. 206210
ShortVariable Avoid variables with short names like v 217
MissingOverride The method 'setWeekDay(int)' is missing an @Override annotation. 217227
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 217
MissingOverride The method 'getDayOfMonth()' is missing an @Override annotation. 234238
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 245
MissingOverride The method 'setDayOfMonth(int)' is missing an @Override annotation. 245255
ShortVariable Avoid variables with short names like v 245
MissingOverride The method 'getTask()' is missing an @Override annotation. 262266
ShortVariable Avoid variables with short names like v 273
MissingOverride The method 'setTask(String)' is missing an @Override annotation. 273283
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 273
ShortVariable Avoid variables with short names like v 301
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 301
MethodReturnsInternalArray Returning 'property' may expose an internal array. 321
ArrayIsStoredDirectly The user-supplied array 'v' is stored directly. 329
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 329
ShortVariable Avoid variables with short names like v 329
MissingOverride The method 'isNew()' is missing an @Override annotation. 349352
MethodArgumentCouldBeFinal Parameter 'isNew' is not assigned and could be declared final 359
MissingOverride The method 'setNew(boolean)' is missing an @Override annotation. 359362
MissingOverride The method 'isModified()' is missing an @Override annotation. 369372
MissingOverride The method 'setModified(boolean)' is missing an @Override annotation. 379382
MethodArgumentCouldBeFinal Parameter 'modified' is not assigned and could be declared final 379
MethodArgumentCouldBeFinal Parameter 'saving' is not assigned and could be declared final 408
MethodArgumentCouldBeFinal Parameter 'loading' is not assigned and could be declared final 429
MethodArgumentCouldBeFinal Parameter 'deleted' is not assigned and could be declared final 456
MissingOverride The method 'save()' is missing an @Override annotation. 474477
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 488
MissingOverride The method 'save(String)' is missing an @Override annotation. 488496
MissingOverride The method 'save(Connection)' is missing an @Override annotation. 509538
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 509
MissingOverride The method 'setPrimaryKey(ObjectKey)' is missing an @Override annotation. 548552
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 548
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 559
MissingOverride The method 'setPrimaryKey(String)' is missing an @Override annotation. 559562
MissingOverride The method 'getPrimaryKey()' is missing an @Override annotation. 569572
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 597
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 612
LocalVariableCouldBeFinal Local variable 'jobEntryTorque' could be declared final 614
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 630
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 630
LocalVariableCouldBeFinal Local variable 'jobEntryTorque' could be declared final 632
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 644
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 657
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 657
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 671
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 671
EmptyIfStmt Avoid empty if statements 684685
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 700
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 700
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 700
EmptyIfStmt Avoid empty if statements 713714
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 719720
LawOfDemeter Potential violation of Law of Demeter (static property access) 742
MissingOverride The method 'toString()' is missing an @Override annotation. 747779
InsufficientStringBufferDeclaration StringBuffer has been initialized with size 16, but has at least 125 characters appended. 749
LocalVariableCouldBeFinal Local variable 'str' could be declared final 749
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 750
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 750
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 751753
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 753
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 753
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 754756
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 756
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 756
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 757759
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 759
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 759
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 760762
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 762
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 762
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 763765
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 765
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 765
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 766768
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 768
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 768
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 769771
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 771
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 771
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 772774
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. 774
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 774
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 777
MissingOverride The method 'equals(Object)' is missing an @Override annotation. 788808
MethodArgumentCouldBeFinal Parameter 'toCompare' is not assigned and could be declared final 788
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 792
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 796
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 798
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 800
LocalVariableCouldBeFinal Local variable 'other' could be declared final 802
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 803
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 805
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 807
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 807
MissingOverride The method 'hashCode()' is missing an @Override annotation. 816825
ShortVariable Avoid variables with short names like ok 818
LocalVariableCouldBeFinal Local variable 'ok' could be declared final 818
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 821
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 824
CyclomaticComplexity The method 'valueEquals(JobEntryTorque)' has a cyclomatic complexity of 12. 836883
StdCyclomaticComplexity The method 'valueEquals' has a Standard Cyclomatic Complexity of 12. 836883
NPathComplexity The method 'valueEquals(JobEntryTorque)' has an NPath complexity of 2048, current threshold is 200 836883
MethodArgumentCouldBeFinal Parameter 'toCompare' is not assigned and could be declared final 836
ModifiedCyclomaticComplexity The method 'valueEquals' has a Modified Cyclomatic Complexity of 12. 836883
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 840
CompareObjectsWithEquals Use equals() to compare object references. 842
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 844
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 848
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 852
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 856
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 860
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 864
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 868
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 872
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 876
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 878881
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 880

org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 11477
AbstractNaming Abstract classes should be named AbstractXXX 361477
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 361477
ExcessiveClassLength Avoid really long classes. 361477
TooManyMethods This class has too many methods, consider refactoring it. 371477
LongVariable Avoid excessively long variable names like jobEntryTorquePeerImpl 70
LocalVariableCouldBeFinal Local variable 'dbMap' could be declared final 7576
AvoidDuplicateLiterals The String literal "TURBINE_SCHEDULED_JOB" appears 5 times in this file; the first occurrence is on line 77 77
AvoidDuplicateLiterals The String literal "INTEGER" appears 6 times in this file; the first occurrence is on line 98 98
AvoidDuplicateLiterals The String literal "int" appears 6 times in this file; the first occurrence is on line 105 105
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 232
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'instance' 233
MethodArgumentCouldBeFinal Parameter 'peerImplInstance' is not assigned and could be declared final 263
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 274
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 276
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 291
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 293
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 309
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 312
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 325
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 328
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 344
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 345
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 348
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 368
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 369
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 372
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 387
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 388
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 391
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 408
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 409
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 410
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 413416
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 437
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 438
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 439
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 442445
MethodArgumentCouldBeFinal Parameter 'query' is not assigned and could be declared final 462
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 463
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 464
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 467470
MethodArgumentCouldBeFinal Parameter 'query' is not assigned and could be declared final 486
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 487
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 488
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 491494
MethodArgumentCouldBeFinal Parameter 'query' is not assigned and could be declared final 514
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 515
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 516
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 519522
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 534
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 537
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 551
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 554
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 570
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 571
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 574
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 589
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 590
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 593595
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 611
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 612
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 613
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 616619
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 632
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 635
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 644
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 658
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 661
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 676
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 676
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 679
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 687
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 690
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 703
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 703
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 706
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 725
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 747
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 768
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 788
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 792796
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 808
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 810
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 827
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 827
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 830
MethodArgumentCouldBeFinal Parameter 'selectCriteria' is not assigned and could be declared final 846
MethodArgumentCouldBeFinal Parameter 'updateValues' is not assigned and could be declared final 847
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 850852
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 869
MethodArgumentCouldBeFinal Parameter 'updateValues' is not assigned and could be declared final 870
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 871
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 874877
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 891
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 893
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 908
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 908
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 911
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 927
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 930
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 949
MethodArgumentCouldBeFinal Parameter 'replacementValues' is not assigned and could be declared final 950
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 953955
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 976
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 977
MethodArgumentCouldBeFinal Parameter 'replacementValues' is not assigned and could be declared final 978
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 981984
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 1003
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1004
MethodArgumentCouldBeFinal Parameter 'replacementValues' is not assigned and could be declared final 1005
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 10081011
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 10371039
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 10681071
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 10991102
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 1116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1118
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 1135
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1138
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 1151
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1153
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 1170
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1173
MethodArgumentCouldBeFinal Parameter 'objects' is not assigned and could be declared final 1187
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1190
MethodArgumentCouldBeFinal Parameter 'objects' is not assigned and could be declared final 1209
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1210
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1213
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 1226
ShortVariable Avoid variables with short names like pk 1226
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1228
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 1245
ShortVariable Avoid variables with short names like pk 1245
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1245
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1248
ShortVariable Avoid variables with short names like pk 1257
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 1257
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1259
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 1269
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1271
MethodArgumentCouldBeFinal Parameter 'objects' is not assigned and could be declared final 1282
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1284
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 1292
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1294
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 1303
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1305
MethodArgumentCouldBeFinal Parameter 'jobEntryTorque' is not assigned and could be declared final 1314
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1318
ShortVariable Avoid variables with short names like pk 1330
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 1330
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1333
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 1346
ShortVariable Avoid variables with short names like pk 1346
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1346
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1349
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 1364
ShortVariable Avoid variables with short names like pk 1364
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1367
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1380
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 1380
ShortVariable Avoid variables with short names like pk 1380
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1383
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 1397
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1400
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 1415
MethodArgumentCouldBeFinal Parameter 'dbcon' is not assigned and could be declared final 1416
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1419
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 1432
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1435
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 1449
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 1449
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1452
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1469

org/apache/turbine/services/schedule/BaseJobEntryTorqueRecordMapper.java

Rule Violation Line
StdCyclomaticComplexity The class 'BaseJobEntryTorqueRecordMapper' has a Standard Cyclomatic Complexity of 3 (Highest = 13). 24429
ModifiedCyclomaticComplexity The class 'BaseJobEntryTorqueRecordMapper' has a Modified Cyclomatic Complexity of 3 (Highest = 13). 24429
AtLeastOneConstructor Each class should declare at least one constructor 24429
ProperLogger Logger should be defined private static final and have the correct class 3031
NcssCount The method 'processRow(ResultSet, int, Criteria)' has a NCSS line count of 64. 54178
ModifiedCyclomaticComplexity The method 'processRow' has a Modified Cyclomatic Complexity of 13. 54178
StdCyclomaticComplexity The method 'processRow' has a Standard Cyclomatic Complexity of 13. 54178
CyclomaticComplexity The method 'processRow(ResultSet, int, Criteria)' has a cyclomatic complexity of 13. 54178
MissingOverride The method 'processRow(ResultSet, int, Criteria)' is missing an @Override annotation. 54178
ExcessiveMethodLength Avoid really long methods. 54178
CognitiveComplexity The method 'processRow(ResultSet, int, Criteria)' has a cognitive complexity of 17, current threshold is 15 54178
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'offset' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 57
LocalVariableCouldBeFinal Local variable 'jobEntryTorque' could be declared final 60
LocalVariableCouldBeFinal Local variable 'selectColumns' could be declared final 92
LocalVariableCouldBeFinal Local variable 'columnsWithoutOffset' could be declared final 9395
LongVariable Avoid excessively long variable names like columnsWithoutOffset 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 9395
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 95
LocalVariableCouldBeFinal Local variable 'column' could be declared final 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 9899
LawOfDemeter Potential violation of Law of Demeter (static property access) 9899
LawOfDemeter Potential violation of Law of Demeter (static property access) 105106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 112113
LawOfDemeter Potential violation of Law of Demeter (static property access) 112113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 119120
LawOfDemeter Potential violation of Law of Demeter (static property access) 119120
LawOfDemeter Potential violation of Law of Demeter (static property access) 126127
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 126127
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 133134
LawOfDemeter Potential violation of Law of Demeter (static property access) 133134
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 140141
LawOfDemeter Potential violation of Law of Demeter (static property access) 140141
LawOfDemeter Potential violation of Law of Demeter (static property access) 147148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 147148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 154155
LawOfDemeter Potential violation of Law of Demeter (static property access) 154155
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 167
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 194
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 195
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 221
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 222
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 248
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 249
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 275
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 276
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 302
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 329
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 330
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 356
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 357
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 383
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 384
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 410
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 411
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 419

org/apache/turbine/services/schedule/JobEntryTorquePeer.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 1317

Priority 4

org/apache/turbine/modules/Page.java

Rule Violation Line
ShortClassName Avoid short class names like Page 3368

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 541

org/apache/turbine/om/security/User.java

Rule Violation Line
ShortClassName Avoid short class names like User 41289

org/apache/turbine/pipeline/TurbinePipeline.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 139

org/apache/turbine/services/Initable.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 96

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
UselessParentheses Useless parentheses. 227
UselessParentheses Useless parentheses. 287

org/apache/turbine/services/localization/DateTimeFormatterService.java

Rule Violation Line
UselessParentheses Useless parentheses. 96

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Line
UselessParentheses Useless parentheses. 140

org/apache/turbine/services/localization/RundataLocalizationService.java

Rule Violation Line
UselessParentheses Useless parentheses. 51

org/apache/turbine/services/pull/util/DateTimeFormatterTool.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.time.format.DateTimeFormatter' due to existing import 'java.time.format.DateTimeFormatter' 181
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.time.format.DateTimeFormatter' due to existing import 'java.time.format.DateTimeFormatter' 182

org/apache/turbine/services/template/TemplateService.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 285
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 299

org/apache/turbine/services/template/mapper/BaseMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 173

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 122
UselessParentheses Useless parentheses. 142

org/apache/turbine/services/template/mapper/DirectMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 66

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 123

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 118

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 79

org/apache/turbine/services/velocity/VelocityService.java

Rule Violation Line
AvoidPrefixingMethodParameters Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 89

org/apache/turbine/util/FormMessages.java

Rule Violation Line
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 130
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 131

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Random' due to existing import 'java.util.Random' 52
UselessParentheses Useless parentheses. 103

org/apache/turbine/util/SecurityCheck.java

Rule Violation Line
UselessParentheses Useless parentheses. 158
UselessParentheses Useless parentheses. 252

org/apache/turbine/util/ServerData.java

Rule Violation Line
UselessParentheses Useless parentheses. 251252
UselessParentheses Useless parentheses. 254255

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Line
UselessParentheses Useless parentheses. 536
UselessParentheses Useless parentheses. 574
UselessParentheses Useless parentheses. 594
UselessParentheses Useless parentheses. 614

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
UselessParentheses Useless parentheses. 467468
UselessParentheses Useless parentheses. 469470

org/apache/turbine/util/uri/URI.java

Rule Violation Line
ShortClassName Avoid short class names like URI 3276

org/apache/turbine/util/uri/URIParam.java

Rule Violation Line
UselessParentheses Useless parentheses. 63

org/apache/turbine/services/schedule/BaseJobEntryTorque.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.AbstractJobEntry' due to existing same package import 'org.apache.turbine.services.schedule.*' 25
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 719
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 720
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 728
UselessParentheses Useless parentheses. 778

org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorque' due to existing same package import 'org.apache.turbine.services.schedule.*' 86
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 87
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.torque.criteria.Criteria' due to existing import 'org.apache.torque.criteria.Criteria' 589
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.torque.criteria.Criteria' due to existing import 'org.apache.torque.criteria.Criteria' 611

org/apache/turbine/services/schedule/JobEntryTorque.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.BaseJobEntryTorque' due to existing same package import 'org.apache.turbine.services.schedule.*' 15

org/apache/turbine/services/schedule/JobEntryTorquePeer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.BaseJobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 14

org/apache/turbine/services/schedule/JobEntryTorquePeerImpl.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.BaseJobEntryTorquePeerImpl' due to existing same package import 'org.apache.turbine.services.schedule.*' 14

Priority 5

org/apache/turbine/modules/GenericLoader.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'186'). 179186
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'194'). 179194
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '186'-'194'). 186194

org/apache/turbine/modules/actions/InitContextsAction.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '63'-'96'). 6396
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'85'). 7885
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'81'). 7881

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'password' (lines '90'-'155'). 90155

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'ret' (lines '123'-'142'). 123142

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '105'-'117'). 105117

org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '61'-'72'). 6172

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'out' (lines '109'-'114'). 109114

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '54'-'83'). 5483

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '55'-'88'). 5588

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'147'). 108147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'135'). 108135
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'screenData' (lines '108'-'151'). 108151
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '110'-'151'). 110151
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '135'-'147'). 135147

org/apache/turbine/om/OMTool.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'114'). 105114
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'110'). 105110

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '590'-'595'). 590595

org/apache/turbine/pipeline/DefaultLoginValve.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'session' (lines '129'-'148'). 129148

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'initable' (lines '236'-'276'). 236276

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '215'-'219'). 215219
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '233'-'260'). 233260
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'loader' (lines '275'-'279'). 275279

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '69'-'96'). 6996

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '84'-'156'). 84156
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confName' (lines '86'-'156'). 86156

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_req' (lines '54'-'58'). 5458
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '55'-'75'). 5575
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '75'-'80'). 7580
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 83
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 83

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '146'-'194'). 146194
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'relativeTemplate' (lines '275'-'288'). 275288

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '72'-'76'). 7276

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'template' (lines '77'-'81'). 7781
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '78'-'83'). 7883

org/apache/turbine/services/localization/DateTimeFormatterService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '137'-'163'). 137163
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '137'-'141'). 137141
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '163'-'172'). 163172

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'102'). 98102
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'106'). 98106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'158'). 150158
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'154'). 150154

org/apache/turbine/services/pull/util/DateFormatter.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'115'). 105115
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'110'). 105110
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'sdf' (lines '106'-'118'). 106118

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'schedrun' (lines '210'-'292'). 210292
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'now' (lines '211'-'292'). 211292

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '335'-'343'). 335343
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '343'-'343'). 343

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'je' (lines '99'-'103'). 99103

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'jobs' (lines '78'-'116'). 78116

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '160'-'168'). 160168
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '186'-'194'). 186194
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '209'-'216'). 209216
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '234'-'241'). 234241
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '256'-'263'). 256263
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '280'-'287'). 280287
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '302'-'309'). 302309
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '327'-'334'). 327334

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'url' (lines '102'-'106'). 102106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '140'-'141'). 140141

org/apache/turbine/services/template/BaseTemplateEngineService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fileExtensionAssociations' (lines '111'-'112'). 111112

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '127'-'178'). 127178

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '107'-'166'). 107166
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '146'-'166'). 146166

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '102'-'155'). 102155
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '141'-'155'). 141155

org/apache/turbine/util/FormMessages.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '135'-'138'). 135138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '172'-'175'). 172175

org/apache/turbine/util/LocaleUtils.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '170'-'190'). 170190

org/apache/turbine/util/ObjectUtils.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'byteArray' (lines '50'-'70'). 5070
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'byteArray' (lines '50'-'66'). 5066
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'object' (lines '83'-'92'). 8392

org/apache/turbine/util/SecurityCheck.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '112'-'122'). 112122
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '138'-'142'). 138142
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleObject' (lines '142'-'163'). 142163
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '142'-'148'). 142148
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'modelManager' (lines '150'-'163'). 150163
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '175'-'185'). 175185
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '207'-'210'). 207210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permissionObject' (lines '210'-'257'). 210257
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '210'-'216'). 210216
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'role' (lines '219'-'224'). 219224

org/apache/turbine/util/template/TemplateInfo.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '242'-'246'). 242246
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '259'-'263'). 259263

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '89'-'103'). 89103
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'module' (lines '89'-'124'). 89124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'96'). 9096
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'111'). 90111
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'107'). 90107

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '91'-'99'). 9199

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '124'-'131'). 124131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '146'-'161'). 146161

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'503'). 488503
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'507'). 488507

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'body' (lines '251'-'256'). 251256
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'body' (lines '256'-'274'). 256274

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'velocityService' (lines '199'-'216'). 199216
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'cid' (lines '245'-'249'). 245249

org/apache/turbine/services/schedule/BaseJobEntryTorqueRecordMapper.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'152'). 90152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'103'). 90103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'159'). 90159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'138'). 90138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'124'). 90124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'131'). 90131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'145'). 90145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'117'). 90117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'110'). 90110
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'totalOffset' (lines '91'-'178'). 91178
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'totalOffset' (lines '91'-'161'). 91161
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'159'). 103159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'117'). 103117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'124'). 103124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'152'). 103152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'110'). 103110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'103'). 103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'145'). 103145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'138'). 103138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'131'). 103131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'110'). 110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'145'). 110145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'159'). 110159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'152'). 110152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'138'). 110138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'131'). 110131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'117'). 110117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'103'). 110103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'124'). 110124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'152'). 117152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'110'). 117110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'103'). 117103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'145'). 117145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'159'). 117159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'138'). 117138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'131'). 117131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'117'). 117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'124'). 117124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'131'). 124131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'117'). 124117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'159'). 124159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'124'). 124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'110'). 124110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'138'). 124138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'103'). 124103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'152'). 124152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'145'). 124145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'152'). 131152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'124'). 131124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'138'). 131138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'131'). 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'110'). 131110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'159'). 131159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'145'). 131145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'103'). 131103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'117'). 131117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'103'). 138103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'124'). 138124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'152'). 138152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'110'). 138110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'145'). 138145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'159'). 138159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'117'). 138117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'131'). 138131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'138'). 138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'117'). 145117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'124'). 145124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'159'). 145159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'145'). 145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'131'). 145131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'110'). 145110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'152'). 145152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'138'). 145138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'103'). 145103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'131'). 152131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'110'). 152110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'159'). 152159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'103'). 152103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'124'). 152124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'138'). 152138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'145'). 152145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'117'). 152117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'152'). 152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'103'). 159103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'159'). 159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'124'). 159124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'117'). 159117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'138'). 159138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'145'). 159145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'131'). 159131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'152'). 159152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'110'). 159110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'totalOffset' (lines '161'-'161'). 161
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'totalOffset' (lines '161'-'178'). 161178
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '416'-'419'). 416419

Files

org/apache/turbine/TurbineConstants.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 51
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE 3 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 53
LongVariable Avoid excessively long variable names like LOG4J2_CONFIG_FILE_DEFAULT 3 56
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 56
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 59
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 62
LongVariable Avoid excessively long variable names like SCHEDULER_LOG_FACILITY 3 62
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 65
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 68
LongVariable Avoid excessively long variable names like MAIL_SERVER_DEFAULT 3 68
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 71
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 74
LongVariable Avoid excessively long variable names like MODULE_CACHE_DEFAULT 3 77
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 77
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 80
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_KEY 3 80
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 83
LongVariable Avoid excessively long variable names like MODULE_CACHE_SIZE_DEFAULT 3 83
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 86
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 89
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 92
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_KEY 3 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 98
LongVariable Avoid excessively long variable names like TEMPLATE_ERROR_JSP 3 98
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 101
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 104
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 107
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 110
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 113
LongVariable Avoid excessively long variable names like SCREEN_ERROR_DEFAULT 3 113
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 116
LongVariable Avoid excessively long variable names like SCREEN_INVALID_STATE 3 116
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 119
LongVariable Avoid excessively long variable names like TEMPLATE_INVALID_STATE 3 119
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 122
LongVariable Avoid excessively long variable names like ACTION_LOGIN_DEFAULT 3 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 125
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 128
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 131
LongVariable Avoid excessively long variable names like ACTION_LOGOUT_DEFAULT 3 131
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_KEY 3 134
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 134
LongVariable Avoid excessively long variable names like ACTION_SESSION_VALIDATOR_DEFAULT 3 137
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 137
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_KEY 3 140
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 140
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 143
LongVariable Avoid excessively long variable names like ACTION_ACCESS_CONTROLLER_DEFAULT 3 143
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_KEY 3 146
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 146
LongVariable Avoid excessively long variable names like ACTION_EVENTSUBMIT_NEEDSVALUE_DEFAULT 3 149
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 149
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP 3 152
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 152
LongVariable Avoid excessively long variable names like ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT 3 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 155
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 158
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 161
LongVariable Avoid excessively long variable names like PAGE_DEFAULT_DEFAULT 3 164
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 164
LongVariable Avoid excessively long variable names like SCREEN_DEFAULT_DEFAULT 3 167
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 167
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 170
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 173
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 176
LongVariable Avoid excessively long variable names like LOGIN_MESSAGE_NOSCREEN 3 176
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 179
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 182
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_KEY 3 182
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 185
LongVariable Avoid excessively long variable names like SESSION_TIMEOUT_DEFAULT 3 185
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 188
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 191
LongVariable Avoid excessively long variable names like PP_URL_CASE_FOLDING 3 197
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 197
LongVariable Avoid excessively long variable names like DEFAULT_DOCUMENT_TYPE_KEY 3 200
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 200
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 203
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_KEY 3 203
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_ROOT_ELEMENT_DEFAULT 3 206
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_KEY 3 209
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 209
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_IDENTIFIER_DEFAULT 3 212
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 212
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_KEY 3 215
LongVariable Avoid excessively long variable names like DEFAULT_HTML_DOCTYPE_URI_DEFAULT 3 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 218
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 221
LongVariable Avoid excessively long variable names like DEFAULT_HTML_CONTENT_TYPE 3 221
LongVariable Avoid excessively long variable names like DEFAULT_TEXT_CONTENT_TYPE 3 222
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 222
LongVariable Avoid excessively long variable names like DEFAULT_CSS_CONTENT_TYPE 3 223
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 223
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 226
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_KEY 3 226
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 229
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_LANGUAGE_DEFAULT 3 229
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_KEY 3 232
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 232
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 235
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_COUNTRY_DEFAULT 3 235
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_KEY 3 238
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 238
LongVariable Avoid excessively long variable names like LOCALE_DEFAULT_CHARSET_DEFAULT 3 241
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 241
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 244
LongVariable Avoid excessively long variable names like LOCALE_OVERRIDE_CHARSET_KEY 3 244
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 249
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 252
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_KEY 3 252
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 255
LongVariable Avoid excessively long variable names like APPLICATION_ROOT_DEFAULT 3 255
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 262
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 265
LongVariable Avoid excessively long variable names like LOGGING_ROOT_DEFAULT 3 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 268
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 271
LongVariable Avoid excessively long variable names like SCREEN_PLACEHOLDER 3 274
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 274
LongVariable Avoid excessively long variable names like NAVIGATION_PLACEHOLDER 3 277
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 277
LongVariable Avoid excessively long variable names like PROCESSING_EXCEPTION_PLACEHOLDER 3 280
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 280
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 283
LongVariable Avoid excessively long variable names like STACK_TRACE_PLACEHOLDER 3 283
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 286
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_KEY 3 286
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT 3 289
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 289
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 292293
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_NAME_KEY 3 292
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 296297
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_PORT_KEY 3 296
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 300301
LongVariable Avoid excessively long variable names like DEFAULT_SERVER_SCHEME_KEY 3 300
LongVariable Avoid excessively long variable names like DEFAULT_SCRIPT_NAME_KEY 3 304
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 304305
LongVariable Avoid excessively long variable names like DEFAULT_CONTEXT_PATH_KEY 3 308
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 308309
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 312
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 319

org/apache/turbine/modules/Action.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 62
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 62

org/apache/turbine/modules/ActionLoader.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62

org/apache/turbine/modules/GenericLoader.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 42222
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
ShortVariable Avoid variables with short names like ab 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
AvoidFieldNameMatchingMethodName Field reload has the same name as a method 3 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'reload' 3 54
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'TURBINE_PACKAGES' is not final. 1 60
SuspiciousConstantFieldName The field name indicates a constant but its modifiers do not 3 60
RedundantFieldInitializer Avoid using redundant field initializer for 'TURBINE_PACKAGES' 3 60
VariableNamingConventions Variables should start with a lowercase character, 'TURBINE_PACKAGES' starts with uppercase character. 1 60
FieldNamingConventions The static field name 'TURBINE_PACKAGES' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
MethodArgumentCouldBeFinal Parameter 'assemblerClass' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'cacheSizeSupplier' is not assigned and could be declared final 3 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 85
MethodArgumentCouldBeFinal Parameter 'reload' is not assigned and could be declared final 3 109
LinguisticNaming Linguistics Antipattern - The setter 'setReload' should not return any type except void linguistically 3 109113
NonThreadSafeSingleton Singleton is not thread safe 3 134140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136137
LocalVariableCouldBeFinal Local variable 'turbinePackages' could be declared final 3 136137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136137
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 3 142
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 161
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 176
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 177
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'186'). 5 179186
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '179'-'194'). 5 179194
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'asm' (lines '186'-'194'). 5 186194
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 194
LocalVariableCouldBeFinal Local variable 'packages' could be declared final 3 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 208

org/apache/turbine/modules/Layout.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 61
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 61

org/apache/turbine/modules/LayoutLoader.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62

org/apache/turbine/modules/Loader.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 37

org/apache/turbine/modules/Navigation.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 67
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 68

org/apache/turbine/modules/NavigationLoader.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 63
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 67
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 78

org/apache/turbine/modules/Page.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Page 4 3368
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 42
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 64

org/apache/turbine/modules/PageLoader.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63

org/apache/turbine/modules/ScheduledJob.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 58

org/apache/turbine/modules/ScheduledJobLoader.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'job' is not assigned and could be declared final 3 59
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 83
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 86

org/apache/turbine/modules/Screen.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CACHE_SIZE_DEFAULT 3 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 69
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 89
CloseResource Ensure that resources like this RunData object are closed after use 3 91
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 91
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 92
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 101
MethodArgumentCouldBeFinal Parameter 'layout' is not assigned and could be declared final 3 101
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 103
CloseResource Ensure that resources like this RunData object are closed after use 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 104

org/apache/turbine/modules/ScreenLoader.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 65
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 66
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 82

org/apache/turbine/modules/actions/AccessController.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 71119
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 74
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 91
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 94
CloseResource Ensure that resources like this RunData object are closed after use 3 94
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 102103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 108109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 117

org/apache/turbine/modules/actions/DefaultAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3651
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 45
CloseResource Ensure that resources like this RunData object are closed after use 3 48
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 48
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 49

org/apache/turbine/modules/actions/InitContextsAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4497
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 60
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 63
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '63'-'96'). 5 6396
CloseResource Ensure that resources like this RunData object are closed after use 3 63
LocalVariableCouldBeFinal Local variable 'contextPropsList' could be declared final 3 71
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 71
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 7289
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 3 72
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
LocalVariableCouldBeFinal Local variable 'start' could be declared final 3 75
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 76
LocalVariableCouldBeFinal Local variable 'end' could be declared final 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 3 77
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'85'). 5 7885
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 81 and 85) 3 78
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '78'-'81'). 5 7881
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 85
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 87
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 3 91
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 93
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 94

org/apache/turbine/modules/actions/LegacyVelocityAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3685
AbstractNaming Abstract classes should be named AbstractXXX 3 3685
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 71
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 79
CloseResource Ensure that resources like this RunData object are closed after use 3 79
ShortVariable Avoid variables with short names like pp 3 80
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 80
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 81

org/apache/turbine/modules/actions/LegacyVelocitySecureAction.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 4169
AtLeastOneConstructor Each class should declare at least one constructor 3 4169
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 51
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 68

org/apache/turbine/modules/actions/LoginUser.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 48157
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
ImmutableField Private field 'loginError' could be made final; it is only initialized in the declaration or constructor. 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 85
CloseResource Ensure that resources like this RunData object are closed after use 3 88
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 88
LocalVariableCouldBeFinal Local variable 'username' could be declared final 3 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'password' (lines '90'-'155'). 5 90155
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
LocalVariableCouldBeFinal Local variable 'password' could be declared final 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 114
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 132
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 134
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 142

org/apache/turbine/modules/actions/LogoutUser.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 41123
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
ImmutableField Private field 'actionLogout' could be made final; it is only initialized in the declaration or constructor. 3 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 75
CloseResource Ensure that resources like this RunData object are closed after use 3 78
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 78
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 99
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 109
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 109
LiteralsFirstInComparisons Position literals first in String comparisons 3 118

org/apache/turbine/modules/actions/VelocityAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3696
AbstractNaming Abstract classes should be named AbstractXXX 3 3696
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 70
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 76
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 92

org/apache/turbine/modules/actions/VelocitySecureAction.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4270
AbstractNaming Abstract classes should be named AbstractXXX 3 4270
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 52
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 69

org/apache/turbine/modules/actions/sessionvalidator/DefaultSessionValidator.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 57129
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
LongVariable Avoid excessively long variable names like loginMessageNoScreen 3 70
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 84
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 87
CloseResource Ensure that resources like this RunData object are closed after use 3 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 127
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 127

org/apache/turbine/modules/actions/sessionvalidator/SessionValidator.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 53124
AtLeastOneConstructor Each class should declare at least one constructor 3 53124
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 66
LongVariable Avoid excessively long variable names like templateInvalidState 3 66
LongVariable Avoid excessively long variable names like screenInvalidState 3 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 69
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'screenOnly' is not assigned and could be declared final 3 79
CognitiveComplexity The method 'handleFormCounterToken(RunData, boolean)' has a cognitive complexity of 20, current threshold is 15 3 79122
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
AvoidDuplicateLiterals The String literal "_session_access_counter" appears 5 times in this file; the first occurrence is on line 81 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 8687
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 90
CollapsibleIfStatements These nested if statements could be combined 3 98117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99100
ConfusingTernary Avoid if (x != y) ..; else ..; 3 102114
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 102114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 104106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 115

org/apache/turbine/modules/actions/sessionvalidator/TemplateSecureSessionValidator.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 56149
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 6061
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 84
CloseResource Ensure that resources like this RunData object are closed after use 3 87
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 92
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 95
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 129
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 141
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 147

org/apache/turbine/modules/actions/sessionvalidator/TemplateSessionValidator.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 46101
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 50
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 60
CloseResource Ensure that resources like this RunData object are closed after use 3 62
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 64
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 67
LocalVariableCouldBeFinal Local variable 'anonymousUser' could be declared final 3 70
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 99

org/apache/turbine/modules/layouts/DirectResponseLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3756
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 46
CloseResource Ensure that resources like this RunData object are closed after use 3 49
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 50

org/apache/turbine/modules/layouts/JspLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4280
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 45
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 61
CloseResource Ensure that resources like this RunData object are closed after use 3 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 76
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 76

org/apache/turbine/modules/layouts/VelocityCachedLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4261
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 59

org/apache/turbine/modules/layouts/VelocityDirectLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4258
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 48
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 48

org/apache/turbine/modules/layouts/VelocityLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43116
AbstractNaming Abstract classes should be named AbstractXXX 3 43116
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 49
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 63
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 66
CloseResource Ensure that resources like this RunData object are closed after use 3 66
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 79
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 97
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 108
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 108
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 108
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113114

org/apache/turbine/modules/layouts/VelocityOnlyLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 6593
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 75
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 75
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
LocalVariableCouldBeFinal Local variable 'results' could be declared final 3 83
LocalVariableCouldBeFinal Local variable 'returnValue' could be declared final 3 84

org/apache/turbine/modules/layouts/VelocityXslLayout.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
UnusedPrivateField Avoid unused private fields such as 'screenLoader'. 3 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 73
CloseResource Ensure that resources like this RunData object are closed after use 3 76
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 76
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 88
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 88
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 88
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 9394
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 100

org/apache/turbine/modules/navigations/BaseJspNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3880
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 42
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 69
CloseResource Ensure that resources like this RunData object are closed after use 3 72
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 72
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 74

org/apache/turbine/modules/navigations/LegacyVelocityNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3561
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 48
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 57

org/apache/turbine/modules/navigations/TemplateNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3468
AbstractNaming Abstract classes should be named AbstractXXX 3 3468
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 52
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 62

org/apache/turbine/modules/navigations/VelocityNavigation.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44109
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 48
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 68
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 69
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 97
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 100
CloseResource Ensure that resources like this RunData object are closed after use 3 100
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LocalVariableCouldBeFinal Local variable 'navigationTemplate' could be declared final 3 103
LongVariable Avoid excessively long variable names like navigationTemplate 3 103
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 104105

org/apache/turbine/modules/pages/DefaultPage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 92207
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 95
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 99
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 107
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 116
CloseResource Ensure that resources like this RunData object are closed after use 3 119
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 132
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 141
LocalVariableCouldBeFinal Local variable 'screenName' could be declared final 3 141
LocalVariableCouldBeFinal Local variable 'aScreen' could be declared final 3 149
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 150
LocalVariableCouldBeFinal Local variable 'layout' could be declared final 3 150
ConfusingTernary Avoid if (x != y) ..; else ..; 3 154161
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 176
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 177
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 189
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 190
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 202
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 203

org/apache/turbine/modules/pages/JspPage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3969
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 51
LocalVariableCouldBeFinal Local variable 'response' could be declared final 3 58
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 60
EmptyCatchBlock Avoid empty catch blocks 3 6266

org/apache/turbine/modules/pages/TemplatePage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 82129
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 87
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 97
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 100
CloseResource Ensure that resources like this RunData object are closed after use 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 105
LocalVariableCouldBeFinal Local variable 'template' could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 110
LocalVariableCouldBeFinal Local variable 'layoutTemplate' could be declared final 3 113114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 115
LocalVariableCouldBeFinal Local variable 'screen' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'errMsg' could be declared final 3 121122

org/apache/turbine/modules/pages/VelocityPage.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3974
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 54
CloseResource Ensure that resources like this RunData object are closed after use 3 57
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 57
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 58
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 5960
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 5960
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 68
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 71

org/apache/turbine/modules/screens/BaseJspScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3996
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 43
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 61
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 64
CloseResource Ensure that resources like this RunData object are closed after use 3 64
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 65
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 65
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 6768
GuardLogStatement Logger calls should be surrounded by log level guards. 2 73
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 74
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 91

org/apache/turbine/modules/screens/JSONScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 82143
LongVariable Avoid excessively long variable names like JSONRPC_CONTENT_TYPE 3 84
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 109
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 111
CloseResource Ensure that resources like this RunData object are closed after use 3 111
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112
LocalVariableCouldBeFinal Local variable 'request' could be declared final 3 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 113
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 116
CloseResource Ensure that resources like this InputStreamReader object are closed after use 3 117
ShortVariable Avoid variables with short names like in 3 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 117
LocalVariableCouldBeFinal Local variable 'in' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'cdata' could be declared final 3 120
LocalVariableCouldBeFinal Local variable 'buf' could be declared final 3 121
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'ret' (lines '123'-'142'). 5 123142
AssignmentInOperand Avoid assignments in operands 3 123
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 130
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 3 130
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 130
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 1 133
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 1 133
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 3 133
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 137

org/apache/turbine/modules/screens/JSONSecureScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 77104
AbstractNaming Abstract classes should be named AbstractXXX 3 77104
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 87
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 103

org/apache/turbine/modules/screens/JspErrorScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3450
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
ImmutableField Private field 'templateError' could be made final; it is only initialized in the declaration or constructor. 3 38
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 45

org/apache/turbine/modules/screens/LegacyVelocityScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3365
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 45
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 45
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 60

org/apache/turbine/modules/screens/LegacyVelocitySecureScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3477
AbstractNaming Abstract classes should be named AbstractXXX 3 3477
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 76

org/apache/turbine/modules/screens/PlainJSONScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 72118
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 78
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the log field if you want a default access modifier 3 78
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 78
DefaultPackage Use explicit scoping instead of the default package private level 3 78
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 101
CloseResource Ensure that resources like this RunData object are closed after use 3 103
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 103
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 105
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '105'-'117'). 5 105117
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 1 107
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 107
LocalVariableCouldBeFinal Local variable 'json_res' could be declared final 3 107
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 1 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
StringToString Avoid calling toString() on String objects; this is unnecessary. 3 114

org/apache/turbine/modules/screens/PlainJSONSecureAnnotatedScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3273
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 43
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 60
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 60
CloseResource Ensure that resources like this RunData object are closed after use 3 61
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 61
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '61'-'72'). 5 6172
LocalVariableCouldBeFinal Local variable 'methods' could be declared final 3 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 6471
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 6471
LiteralsFirstInComparisons Position literals first in String comparisons 3 65

org/apache/turbine/modules/screens/RawScreen.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 4596
AtLeastOneConstructor Each class should declare at least one constructor 3 4596
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
CloseResource Ensure that resources like this RunData object are closed after use 3 59
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 61
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 9295

org/apache/turbine/modules/screens/TemplateScreen.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 52204
AtLeastOneConstructor Each class should declare at least one constructor 3 52204
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 72
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 83
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 9295
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'out' (lines '109'-'114'). 5 109114
UnusedAssignment The initializer for variable 'out' is never used (overwritten on line 114) 3 109
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 135
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 137
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 138
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 3 138
ShortVariable Avoid variables with short names like ti 3 138
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 139
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 139
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 141
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 148
EmptyCatchBlock Avoid empty catch blocks 3 148151
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 173
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 174
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 199
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 199
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 200

org/apache/turbine/modules/screens/VelocityCachedScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3984
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 50
CloseResource Ensure that resources like this RunData object are closed after use 3 53
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 53
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 54
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '54'-'83'). 5 5483
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 56
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 56
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 5758
GuardLogStatement Logger calls should be surrounded by log level guards. 2 63
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 64
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 71

org/apache/turbine/modules/screens/VelocityDirectScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4089
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 51
CloseResource Ensure that resources like this RunData object are closed after use 3 54
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 54
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 55
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 55
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '55'-'88'). 5 5588
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 57
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 57
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 57
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 5859
GuardLogStatement Logger calls should be surrounded by log level guards. 2 64
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 72
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 84

org/apache/turbine/modules/screens/VelocityErrorScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3658
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 47
CloseResource Ensure that resources like this RunData object are closed after use 3 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 50
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 52
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 54

org/apache/turbine/modules/screens/VelocityScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 48152
VariableNamingConventions Variables that are final and static should be all capitals, 'prefix' is not all capitals. 1 52
FieldNamingConventions The constant name 'prefix' doesn't match '[A-Z][A-Z_0-9]*' 1 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 75
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 76
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 104
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 107
CloseResource Ensure that resources like this RunData object are closed after use 3 107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'147'). 5 108147
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 108
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '108'-'135'). 5 108135
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'screenData' (lines '108'-'151'). 5 108151
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 110
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'context' (lines '110'-'151'). 5 110151
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
LocalVariableCouldBeFinal Local variable 'screenTemplate' could be declared final 3 112
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 112
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 113114
GuardLogStatement Logger calls should be surrounded by log level guards. 2 119
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 120
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'screenData' (lines '135'-'147'). 5 135147
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 139

org/apache/turbine/modules/screens/VelocitySecureScreen.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4185
AbstractNaming Abstract classes should be named AbstractXXX 3 4185
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 84

org/apache/turbine/modules/screens/error/InvalidState.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4686
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
CloseResource Ensure that resources like this RunData object are closed after use 3 58
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 58
LocalVariableCouldBeFinal Local variable 'body' could be declared final 3 59
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 67 characters appended. 3 62
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 62
ShortVariable Avoid variables with short names like sb 3 63
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 170 characters appended. 3 63
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 63
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 7 consecutive times with literals. Use a single append with a single combined String. 3 64
ShortVariable Avoid variables with short names like pp 3 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
LocalVariableCouldBeFinal Local variable 'back' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 79
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 79
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 82

org/apache/turbine/om/OMTool.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
ImmutableField Private field 'pullMap' could be made final; it is only initialized in the declaration or constructor. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 62
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 95
DefaultPackage Use explicit scoping instead of the default package private level 3 95
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the omName field if you want a default access modifier 3 95
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 3 97
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 102
LinguisticNaming Linguistics Antipattern - The setter 'setKey' should not return any type except void linguistically 3 102119
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'114'). 5 105114
UnusedAssignment The initializer for variable 'om' is never used (overwritten on lines 110 and 114) 3 105
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'om' (lines '105'-'110'). 5 105110
ShortVariable Avoid variables with short names like om 3 105
LocalVariableCouldBeFinal Local variable 'inputKey' could be declared final 3 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 3 128
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 128
LocalVariableCouldBeFinal Local variable 'ph' could be declared final 3 130
ShortVariable Avoid variables with short names like ph 3 130
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 133
MethodArgumentCouldBeFinal Parameter 'omName' is not assigned and could be declared final 3 146
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 146
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 148
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 153
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 153

org/apache/turbine/om/Retrievable.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 52

org/apache/turbine/om/Retriever.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 44

org/apache/turbine/om/RetrieverFactory.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 43

org/apache/turbine/om/security/DefaultUserImpl.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1758
GodClass Possible God Class (WMC=67, ATFD=31, TCC=15.137%) 3 44758
RedundantFieldInitializer Avoid using redundant field initializer for 'lastAccessDate' 3 50
RedundantFieldInitializer Avoid using redundant field initializer for 'permStorage' 3 53
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 3 56
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 71) 3 56
RedundantFieldInitializer Avoid using redundant field initializer for 'userDelegate' 3 59
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 66
ConstructorCallsOverridableMethod Overridable method 'setHasLoggedIn' called during object construction 1 72
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'hsbe' is not assigned and could be declared final 3 94
LocalVariableCouldBeFinal Local variable 'securityService' could be declared final 3 100102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 106
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 158
ShortVariable Avoid variables with short names like id 3 158
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 189
MethodArgumentCouldBeFinal Parameter 'firstName' is not assigned and could be declared final 3 211
MethodArgumentCouldBeFinal Parameter 'lastName' is not assigned and could be declared final 3 233
MethodArgumentCouldBeFinal Parameter 'address' is not assigned and could be declared final 3 255
MethodArgumentCouldBeFinal Parameter 'objectdata' is not assigned and could be declared final 3 280
MethodArgumentCouldBeFinal Parameter 'userGroupRoleSet' is not assigned and could be declared final 3 305
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 3 319
MethodArgumentCouldBeFinal Parameter 'userGroupRole' is not assigned and could be declared final 3 333
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 348
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 350
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 366
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 368
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 3 399
MethodArgumentCouldBeFinal Parameter 'cnt' is not assigned and could be declared final 3 411
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 449467
LocalVariableCouldBeFinal Local variable 'objectdata' could be declared final 3 453
MethodArgumentCouldBeFinal Parameter 'permStorage' is not assigned and could be declared final 3 476
MethodArgumentCouldBeFinal Parameter 'tempStorage' is not assigned and could be declared final 3 507
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 522
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 524
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 3 536
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 536
LocalVariableCouldBeFinal Local variable 'val' could be declared final 3 540
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 540
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 541
UselessParentheses Useless parentheses. 4 541
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 543
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 556
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 556
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 558
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 568
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 570
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 3 582
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 582
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 587
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '590'-'595'). 5 590595
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 593
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 607
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 607
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 609
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 619
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 621
MethodArgumentCouldBeFinal Parameter 'confirm' is not assigned and could be declared final 3 641
MethodArgumentCouldBeFinal Parameter 'createDate' is not assigned and could be declared final 3 663
MethodArgumentCouldBeFinal Parameter 'lastLogin' is not assigned and could be declared final 3 685
LocalVariableCouldBeFinal Local variable 'loggedIn' could be declared final 3 698
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 699
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 709
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 725
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 726
MethodArgumentCouldBeFinal Parameter 'userDelegate' is not assigned and could be declared final 3 754

org/apache/turbine/om/security/User.java

Rule Violation Priority Line
ShortClassName Avoid short class names like User 4 41289
LongVariable Avoid excessively long variable names like SESSION_ACCESS_COUNTER 3 60
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 288

org/apache/turbine/pipeline/CleanUpValve.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4952
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 58
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 65
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 79
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 81
CloseResource Ensure that resources like this RunData object are closed after use 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 8889
EmptyCatchBlock Avoid empty catch blocks 3 9195
LongVariable Avoid excessively long variable names like invalidatedSession 3 91

org/apache/turbine/pipeline/DefaultACLCreationValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4175
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
LongVariable Avoid excessively long variable names like actionAccessController 3 49
ImmutableField Private field 'actionAccessController' could be made final; it is only initialized in the declaration or constructor. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 67

org/apache/turbine/pipeline/DefaultLoginValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 50166
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 67
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 74
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 91
CognitiveComplexity The method 'process(PipelineData)' has a cognitive complexity of 21, current threshold is 15 3 91148
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 92
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 94
CloseResource Ensure that resources like this RunData object are closed after use 3 94
LocalVariableCouldBeFinal Local variable 'actionName' could be declared final 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 118
LocalVariableCouldBeFinal Local variable 'names' could be declared final 3 118
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 119141
LocalVariableCouldBeFinal Local variable 'nameList' could be declared final 3 123
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 126
LocalVariableCouldBeFinal Local variable 'session' could be declared final 3 129
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'session' (lines '129'-'148'). 5 129148
LocalVariableCouldBeFinal Local variable 'name' could be declared final 3 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 134
LongVariable Avoid excessively long variable names like invalidatedSession 3 136
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 155
ShortVariable Avoid variables with short names like ti 3 160
LocalVariableCouldBeFinal Local variable 'ti' could be declared final 3 160

org/apache/turbine/pipeline/DefaultPipelineData.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44104
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'innerKey' is not assigned and could be declared final 3 82
LocalVariableCouldBeFinal Local variable 'innerMap' could be declared final 3 84
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 87
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 89
LocalVariableCouldBeFinal Local variable 'rds' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98

org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4367
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 53
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 56
CloseResource Ensure that resources like this RunData object are closed after use 3 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 61

org/apache/turbine/pipeline/DefaultSessionValidationValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4178
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
LongVariable Avoid excessively long variable names like actionSessionValidator 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
ImmutableField Private field 'actionSessionValidator' could be made final; it is only initialized in the declaration or constructor. 3 49
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 55
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 70

org/apache/turbine/pipeline/DefaultSetEncodingValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4792
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 50
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 50
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 56
LocalVariableCouldBeFinal Local variable 'req' could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 63
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 87

org/apache/turbine/pipeline/DetermineActionValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4075
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 43
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 43
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 53
CloseResource Ensure that resources like this RunData object are closed after use 3 53
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 54
LocalVariableCouldBeFinal Local variable 'action' could be declared final 3 5657
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 57
ConfusingTernary Avoid if (x != y) ..; else ..; 3 5967

org/apache/turbine/pipeline/DetermineRedirectRequestedValve.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 43
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 43
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4851
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 73
CloseResource Ensure that resources like this RunData object are closed after use 3 76
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 78
LocalVariableCouldBeFinal Local variable 'requestRedirected' could be declared final 3 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
GuardLogStatement Logger calls should be surrounded by log level guards. 2 83
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 87

org/apache/turbine/pipeline/DetermineTargetValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4477
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 46
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 46
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 53
CloseResource Ensure that resources like this RunData object are closed after use 3 56
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 56
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 57
LocalVariableCouldBeFinal Local variable 'target' could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 59
ConfusingTernary Avoid if (x != y) ..; else ..; 3 6169

org/apache/turbine/pipeline/ExecutePageValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43120
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
ImmutableField Private field 'pageDefault' could be made final; it is only initialized in the declaration or constructor. 3 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 61
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 68
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 84
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 85

org/apache/turbine/pipeline/Pipeline.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 60

org/apache/turbine/pipeline/TurbinePipeline.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 48184
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
ImmutableField Private field 'state' could be made final; it is only initialized in the declaration or constructor. 3 71
LocalVariableCouldBeFinal Local variable 'v' could be declared final 3 84
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 97
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 3 116
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 139
MethodArgumentCouldBeFinal Parameter 'valves' is not assigned and could be declared final 3 139
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 3 148
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 157
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 161
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 171
LocalVariableCouldBeFinal Local variable 'current' could be declared final 3 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 181

org/apache/turbine/pipeline/Valve.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 100

org/apache/turbine/pipeline/XmlValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3458
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 54

org/apache/turbine/pipeline/XmlValveAdapter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 2952
MethodArgumentCouldBeFinal Parameter 'xmlValve' is not assigned and could be declared final 3 35
LocalVariableCouldBeFinal Local variable 'valveClass' could be declared final 3 37
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 38
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 38
MethodArgumentCouldBeFinal Parameter 'valve' is not assigned and could be declared final 3 45
LocalVariableCouldBeFinal Local variable 'xmlValve' could be declared final 3 47
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 48

org/apache/turbine/services/BaseInitable.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
RedundantFieldInitializer Avoid using redundant field initializer for 'isInitialized' 3 41
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5053
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 61
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 137

org/apache/turbine/services/BaseInitableBroker.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 59278
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 63
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 96
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 3 102
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 105106
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 3 118
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 143
LocalVariableCouldBeFinal Local variable 'initable' could be declared final 3 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 150
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 176
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 177
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 227
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 228
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'initable' (lines '236'-'276'). 5 236276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 236
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 236
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 239242
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 243269
UnusedAssignment The initializer for variable 'msg' is never used (overwritten on lines 250, 255, 260 and 265) 3 246
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 248
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 253
AvoidInstanceofChecksInCatchClause An instanceof check is being performed on the caught exception. Create a separate catch clause for this exception type. 3 258

org/apache/turbine/services/BaseService.java

Rule Violation Priority Line
DataClass The class 'BaseService' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=8) 3 37125
AtLeastOneConstructor Each class should declare at least one constructor 3 37125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 69
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 121

org/apache/turbine/services/BaseUnicastRemoteService.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5562
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 59
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 60
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 114
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 141
MethodArgumentCouldBeFinal Parameter 'broker' is not assigned and could be declared final 3 162

org/apache/turbine/services/FieldAnnotatedTurbineBaseService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3763
AbstractNaming Abstract classes should be named AbstractXXX 3 3763
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 41
GuardLogStatement Logger calls should be surrounded by log level guards. 2 56

org/apache/turbine/services/Initable.java

Rule Violation Priority Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 96

org/apache/turbine/services/InitableBroker.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 97

org/apache/turbine/services/InitializationException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 60
ShortVariable Avoid variables with short names like t 3 60

org/apache/turbine/services/InstantiationException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 51
ShortVariable Avoid variables with short names like t 3 63
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 63
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 63

org/apache/turbine/services/MethodAnnotatedTurbineBaseService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3459
AbstractNaming Abstract classes should be named AbstractXXX 3 3459

org/apache/turbine/services/ServiceBroker.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 95

org/apache/turbine/services/ServiceManager.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setServiceObject': the method is declared in an interface type 3 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'getServiceObject': the method is declared in an interface type 3 87

org/apache/turbine/services/TurbineBaseService.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 59124
AtLeastOneConstructor Each class should declare at least one constructor 3 59124
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 72
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 9295
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 92

org/apache/turbine/services/TurbineServiceProvider.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 42

org/apache/turbine/services/TurbineServices.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 3 67
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 6775
LocalVariableCouldBeFinal Local variable 'previous' could be declared final 3 69

org/apache/turbine/services/assemblerbroker/TurbineAssemblerBrokerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55306
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 6061
RedundantFieldInitializer Avoid using redundant field initializer for 'factories' 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
RedundantFieldInitializer Avoid using redundant field initializer for 'assemblerCache' 3 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
RedundantFieldInitializer Avoid using redundant field initializer for 'loaderCache' 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
AvoidDuplicateLiterals The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 84 3 84
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103
LocalVariableCouldBeFinal Local variable 'names' could be declared final 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 105
GuardLogStatement Logger calls should be surrounded by log level guards. 2 105
LocalVariableCouldBeFinal Local variable 'name2' could be declared final 3 107
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 3 109
ShortVariable Avoid variables with short names like af 3 113
LocalVariableCouldBeFinal Local variable 'af' could be declared final 3 113114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
AvoidRethrowingException A catch statement that catches an exception only to rethrow it should be avoided. 3 118121
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 124128
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 146
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 148
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 148156
LocalVariableCouldBeFinal Local variable 'type' could be declared final 3 150
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 164166
LocalVariableCouldBeFinal Local variable 'cacheSize' could be declared final 3 170172
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 170172
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 190
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 192
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 211
CognitiveComplexity The method 'getAssembler(Class, String)' has a cognitive complexity of 21, current threshold is 15 3 211260
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 211
CyclomaticComplexity The method 'getAssembler(Class, String)' has a cyclomatic complexity of 10. 3 211260
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 214
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '215'-'219'). 5 215219
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 3 225
UselessParentheses Useless parentheses. 4 227
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 227
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 3 229
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '233'-'260'). 5 233260
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 233
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 235
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 240
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 240
LocalVariableCouldBeFinal Local variable 'oldAssembler' could be declared final 3 249
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 250253
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 273
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'loader' (lines '275'-'279'). 5 275279
LocalVariableCouldBeFinal Local variable 'facs' could be declared final 3 285
UselessParentheses Useless parentheses. 4 287
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 287
LocalVariableCouldBeFinal Local variable 'fac' could be declared final 3 289
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 290

org/apache/turbine/services/assemblerbroker/util/java/JavaActionFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaBaseFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44144
AbstractNaming Abstract classes should be named AbstractXXX 3 44144
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
MethodArgumentCouldBeFinal Parameter 'packageName' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 67
CognitiveComplexity The method 'getAssembler(String, String)' has a cognitive complexity of 19, current threshold is 15 3 67124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'assembler' (lines '69'-'96'). 5 6996
LocalVariableCouldBeFinal Local variable 'p' could be declared final 3 75
ShortVariable Avoid variables with short names like sb 3 77
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 77
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 77
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 80
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_servClass' is not final. 1 90
LocalVariableCouldBeFinal Local variable '_servClass' could be declared final 3 90
LocalVariableNamingConventions The local variable name '_servClass' doesn't match '[a-z][a-zA-Z0-9]*' 1 90
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 9194
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 142

org/apache/turbine/services/assemblerbroker/util/java/JavaLayoutFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaNavigationFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaPageFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScheduledJobFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/java/JavaScreenFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3672
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 46

org/apache/turbine/services/assemblerbroker/util/python/PythonActionFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonBaseFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 48177
AbstractNaming Abstract classes should be named AbstractXXX 3 48177
LongVariable Avoid excessively long variable names like PYTHON_CONFIG_FILE 3 55
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
MethodArgumentCouldBeFinal Parameter 'subDirectory' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 71
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 72
LocalVariableCouldBeFinal Local variable 'path' could be declared final 3 74
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 78
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'assembler' (lines '84'-'156'). 5 84156
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'confName' (lines '86'-'156'). 5 86156
LocalVariableCouldBeFinal Local variable 'confName' could be declared final 3 86
LocalVariableCouldBeFinal Local variable 'fName' could be declared final 3 89
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 91
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 92
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 92
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 93
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 94
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 94
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 95
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 95
ShortVariable Avoid variables with short names like f 3 98
LocalVariableCouldBeFinal Local variable 'f' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 112
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 130139
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 132
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 132138
LocalVariableCouldBeFinal Local variable 't' could be declared final 3 143
ShortVariable Avoid variables with short names like t 3 143
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 146
ExceptionAsFlowControl Avoid using exceptions as flow control. 3 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 175

org/apache/turbine/services/assemblerbroker/util/python/PythonLayoutFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonNavigationFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonPageFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/assemblerbroker/util/python/PythonScreenFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3876
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 49

org/apache/turbine/services/avaloncomponent/AvalonComponentService.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 37
LongVariable Avoid excessively long variable names like AVALON_LOG_CATEGORY 3 40
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 40
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_KEY 3 43
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 43
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_VALUE 3 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 49
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_KEY 3 49
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_VALUE 3 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 55
LongVariable Avoid excessively long variable names like COMPONENT_LOOKUP_KEY 3 55
LongVariable Avoid excessively long variable names like COMPONENT_APP_ROOT 3 58
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 58

org/apache/turbine/services/avaloncomponent/TurbineYaafiComponentService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44294
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_KEY 3 52
LongVariable Avoid excessively long variable names like CONTAINER_CONFIGURATION_VALUE 3 55
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY 3 58
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 81
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 114
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 117
LocalVariableCouldBeFinal Local variable 'home' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 121122
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 132
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 148
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 159
MethodArgumentCouldBeFinal Parameter 'component' is not assigned and could be declared final 3 170
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 179
MethodArgumentCouldBeFinal Parameter 'applicationRoot' is not assigned and could be declared final 3 193
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 193
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 196
LongVariable Avoid excessively long variable names like containerConfiguration 3 207
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 3 207209
LocalVariableCouldBeFinal Local variable 'roleConfigurationFileName' could be declared final 3 217220
LongVariable Avoid excessively long variable names like roleConfigurationFileName 3 217
LongVariable Avoid excessively long variable names like componentConfigurationFileName 3 224
LocalVariableCouldBeFinal Local variable 'componentConfigurationFileName' could be declared final 3 224227
LongVariable Avoid excessively long variable names like parametersFileName 3 231
LocalVariableCouldBeFinal Local variable 'parametersFileName' could be declared final 3 231234
LocalVariableCouldBeFinal Local variable 'containerConfiguration' could be declared final 3 244247
LongVariable Avoid excessively long variable names like containerConfiguration 3 244
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 272
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 281
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 281
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 287292
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 289

org/apache/turbine/services/jsonrpc/JSONProcessor.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'JSONProcessor' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 1 3987
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4087
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 42
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 51
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 3 51
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 51
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 51
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 3 51
LocalVariableNamingConventions The local variable name 'json_req' doesn't match '[a-z][a-zA-Z0-9]*' 1 54
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_req' (lines '54'-'58'). 5 5458
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_req' is not final. 1 54
UnusedAssignment The initializer for variable 'json_req' is never used (overwritten on line 58) 3 54
LocalVariableNamingConventions The local variable name 'json_res' doesn't match '[a-z][a-zA-Z0-9]*' 1 55
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_res' is not final. 1 55
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '55'-'75'). 5 5575
UnusedAssignment The initializer for variable 'json_res' is never used (overwritten on lines 75 and 80) 3 55
LocalVariableCouldBeFinal Local variable 'methodName' could be declared final 3 61
LocalVariableCouldBeFinal Local variable 'arguments' could be declared final 3 62
LocalVariableNamingConventions The local variable name 'object_id' doesn't match '[a-z][a-zA-Z0-9]*' 1 65
LocalVariableCouldBeFinal Local variable 'object_id' could be declared final 3 65
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'object_id' is not final. 1 65
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 66
ShortVariable Avoid variables with short names like sb 3 66
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 69
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 71
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 71
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'json_res' (lines '75'-'80'). 5 7580
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 83
InvalidLogMessageFormat Too many arguments, expected 0 argument but have 1 5 83

org/apache/turbine/services/jsonrpc/JsonRpcService.java

Rule Violation Priority Line
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 51
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 51

org/apache/turbine/services/jsonrpc/TurbineJsonRpcService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 37102
MethodArgumentCouldBeFinal Parameter 'cdata' is not assigned and could be declared final 3 45
FormalParameterNamingConventions The method parameter name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 46
MethodArgumentCouldBeFinal Parameter 'json_bridge' is not assigned and could be declared final 3 46
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 46
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 46
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 52
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 54
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 58
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 58
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 60
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 60
LocalVariableCouldBeFinal Local variable 'json_bridge' could be declared final 3 60
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 61
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 65
LocalVariableNamingConventions The local variable name 'json_bridge' doesn't match '[a-z][a-zA-Z0-9]*' 1 67
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'json_bridge' is not final. 1 67
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 77

org/apache/turbine/services/jsp/JspService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like BUFFER_SIZE_DEFAULT 3 56

org/apache/turbine/services/jsp/TurbineJspService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 53305
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
LongVariable Avoid excessively long variable names like relativeTemplatePaths 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 67
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 87
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 101
LocalVariableCouldBeFinal Local variable 'req' could be declared final 3 103
LocalVariableCouldBeFinal Local variable 'templateLink' could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 114
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 138
MethodArgumentCouldBeFinal Parameter 'isForward' is not assigned and could be declared final 3 138
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 138
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 143
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 146
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 146
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'data' (lines '146'-'194'). 5 146194
LongVariable Avoid excessively long variable names like relativeTemplateName 3 149
LocalVariableCouldBeFinal Local variable 'relativeTemplateName' could be declared final 3 149
LocalVariableCouldBeFinal Local variable 'dispatcher' could be declared final 3 158159
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 158159
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 158159
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 170
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 180181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 180181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 182
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 205
MethodArgumentCouldBeFinal Parameter 'templateName' is not assigned and could be declared final 3 205
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 215
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 217
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 221
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 232233
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 244
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 246
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 258
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 258
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 273
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'relativeTemplate' (lines '275'-'288'). 5 275288
LocalVariableCouldBeFinal Local variable 'relativeTemplate' could be declared final 3 275
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 284
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 296
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 298
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 301

org/apache/turbine/services/jsp/util/JspNavigation.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 71
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '72'-'76'). 5 7276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 75
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 75
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 79
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 8182
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
EmptyCatchBlock Avoid empty catch blocks 3 8891

org/apache/turbine/services/jsp/util/JspScreenPlaceholder.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 64
LocalVariableCouldBeFinal Local variable 'abs' could be declared final 3 6768
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'template' (lines '77'-'81'). 5 7781
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '78'-'83'). 5 7883
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 82
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 82
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 83
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 86
LocalVariableCouldBeFinal Local variable 'message' could be declared final 3 8889
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
EmptyCatchBlock Avoid empty catch blocks 3 9598

org/apache/turbine/services/localization/DateTimeFormatterInterface.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like DATE_TIME_FORMAT_KEY 3 33
UnnecessaryModifier Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_KEY': the field is declared in an interface type 3 33
UnnecessaryModifier Unnecessary modifier 'final' on field 'DATE_TIME_ZONEID_KEY': the field is declared in an interface type 3 35
LongVariable Avoid excessively long variable names like DATE_TIME_ZONEID_KEY 3 35
UnnecessaryModifier Unnecessary modifier 'final' on field 'USE_TURBINE_LOCALE_KEY': the field is declared in an interface type 3 37
LongVariable Avoid excessively long variable names like USE_TURBINE_LOCALE_KEY 3 37
LongVariable Avoid excessively long variable names like USE_REQUEST_LOCALE_KEY 3 39
UnnecessaryModifier Unnecessary modifier 'final' on field 'USE_REQUEST_LOCALE_KEY': the field is declared in an interface type 3 39
LongVariable Avoid excessively long variable names like DATE_TIME_FORMAT_DEFAULT 3 42
UnnecessaryModifier Unnecessary modifier 'final' on field 'DATE_TIME_FORMAT_DEFAULT': the field is declared in an interface type 3 42

org/apache/turbine/services/localization/DateTimeFormatterService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 48257
RedundantFieldInitializer Avoid using redundant field initializer for 'formatPattern' 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'dateTimeFormat' 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'locale' 3 56
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 71
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 71
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 71
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 9091
LocalVariableCouldBeFinal Local variable 'useTurbineLocale' could be declared final 3 9394
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 9394
UselessParentheses Useless parentheses. 4 96
LocalVariableCouldBeFinal Local variable 'localeSetter' could be declared final 3 9698
LocalVariableCouldBeFinal Local variable 'zoneIdStr' could be declared final 3 101102
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101102
ConfusingTernary Avoid if (x != y) ..; else ..; 3 103104
LocalVariableCouldBeFinal Local variable 'zoneIdSet' could be declared final 3 103104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107108
GuardLogStatement Logger calls should be surrounded by log level guards. 2 110112
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 117
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 123
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 123
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 129
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 129
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 129
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'zoneId' is not assigned and could be declared final 3 136
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 141 and 164) 3 137
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '137'-'163'). 5 137163
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '137'-'141'). 5 137141
ConfusingTernary Avoid if (x != y) ..; else ..; 3 147153
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 149
GuardLogStatement Logger calls should be surrounded by log level guards. 2 151
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 152
ConfusingTernary Avoid if (x != y) ..; else ..; 3 154160
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 156
GuardLogStatement Logger calls should be surrounded by log level guards. 2 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 159
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '163'-'172'). 5 163172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 164
LongVariable Avoid excessively long variable names like incomingFormatPattern 3 175
MethodArgumentCouldBeFinal Parameter 'outgoingFormatPattern' is not assigned and could be declared final 3 175
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 175
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 175
LongVariable Avoid excessively long variable names like outgoingFormatPattern 3 175
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 179
AvoidReassigningParameters Avoid reassigning parameters such as 'incomingFormatPattern' 2 183
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 185
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 186
LocalVariableCouldBeFinal Local variable 'incomingFormat' could be declared final 3 188
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 199
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 199
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 204
AvoidReassigningParameters Avoid reassigning parameters such as 'incomingFormat' 2 208
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 210
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 211
AvoidReassigningParameters Avoid reassigning parameters such as 'outgoingFormat' 2 215
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 218219
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 219
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 223
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 3 223
MethodArgumentCouldBeFinal Parameter 'incomingFormat' is not assigned and could be declared final 3 229
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 229
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 235
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 235
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 3 235
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 244
MethodArgumentCouldBeFinal Parameter 'zoneId' is not assigned and could be declared final 3 253

org/apache/turbine/services/localization/LocalizationTool.java

Rule Violation Priority Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
LongVariable Avoid excessively long variable names like localizationService 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
ConstructorCallsOverridableMethod Overridable method 'refresh' called during object construction 1 59
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 75
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 79
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 109
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 134
UselessParentheses Useless parentheses. 4 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 152

org/apache/turbine/services/localization/RundataLocalizationService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4379
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 4379
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 45
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 45
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 48
LocalVariableCouldBeFinal Local variable 'user' could be declared final 3 49
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 51
UselessParentheses Useless parentheses. 4 51
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 55
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 55
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 3 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 64
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 69
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74

org/apache/turbine/services/naming/TurbineNamingService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 50171
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 55
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPropsList' 3 61
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
LocalVariableCouldBeFinal Local variable 'contextKeys' could be declared final 3 86
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 86113
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
LocalVariableCouldBeFinal Local variable 'end' could be declared final 3 90
UseIndexOfChar String.indexOf(char) is faster than String.indexOf(String). 3 90
LocalVariableCouldBeFinal Local variable 'contextName' could be declared final 3 97
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 97
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'102'). 5 98102
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 102 and 106) 3 98
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '98'-'106'). 5 98106
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 106
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 109110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 109
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 115
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'contextProps' could be declared final 3 118
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 119
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 119
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 129130
MethodArgumentCouldBeFinal Parameter 'contextName' is not assigned and could be declared final 3 146
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'158'). 5 150158
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'contextProps' (lines '150'-'154'). 5 150154
UnusedAssignment The initializer for variable 'contextProps' is never used (overwritten on lines 154 and 158) 3 150
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 166

org/apache/turbine/services/pull/PullService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_KEY 3 82
LongVariable Avoid excessively long variable names like TOOL_RESOURCES_DIR_DEFAULT 3 88
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_KEY 3 94
LongVariable Avoid excessively long variable names like TOOLS_PER_REQUEST_REFRESH_DEFAULT 3 97
LongVariable Avoid excessively long variable names like SESSION_TOOLS_ATTRIBUTE_PREFIX 3 100

org/apache/turbine/services/pull/tools/ContentTool.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like CONTENT_TOOL_PREFIX 3 54
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_KEY 3 62
LongVariable Avoid excessively long variable names like CONTENT_TOOL_ENCODING_DEFAULT 3 65
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_KEY 3 68
LongVariable Avoid excessively long variable names like CONTENT_TOOL_RELATIVE_DEFAULT 3 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 74
DefaultPackage Use explicit scoping instead of the default package private level 3 74
RedundantFieldInitializer Avoid using redundant field initializer for 'wantEncoding' 3 74
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantEncoding field if you want a default access modifier 3 74
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantRelative field if you want a default access modifier 3 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 77
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 3 77
DefaultPackage Use explicit scoping instead of the default package private level 3 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 80
RedundantFieldInitializer Avoid using redundant field initializer for 'dataURI' 3 80
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 8588
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 107
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 3 114
CloseResource Ensure that resources like this PipelineData object are closed after use 3 114
CloseResource Ensure that resources like this RunData object are closed after use 3 115
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 115
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 124125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 125
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 158
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 175
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 191

org/apache/turbine/services/pull/tools/TemplateLink.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 61633
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_PREFIX 3 63
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_KEY 3 66
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_RELATIVE_DEFAULT 3 69
RedundantFieldInitializer Avoid using redundant field initializer for 'wantRelative' 3 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 72
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_KEY 3 80
LongVariable Avoid excessively long variable names like TEMPLATE_LINK_ENCODING_DEFAULT 3 83
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the wantEncoding field if you want a default access modifier 3 86
DefaultPackage Use explicit scoping instead of the default package private level 3 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 86
RedundantFieldInitializer Avoid using redundant field initializer for 'wantEncoding' 3 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 89
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 3 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 92
RedundantFieldInitializer Avoid using redundant field initializer for 'templateURI' 3 92
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 95
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 95
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 102105
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 124
CloseResource Ensure that resources like this PipelineData object are closed after use 3 131
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 3 131
CloseResource Ensure that resources like this RunData object are closed after use 3 132
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 132
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 140141
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 141
LinguisticNaming Linguistics Antipattern - The setter 'setEncodeURLOff' should not return any type except void linguistically 3 184188
LinguisticNaming Linguistics Antipattern - The setter 'setPage' should not return any type except void linguistically 3 196202
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 196
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 224
LinguisticNaming Linguistics Antipattern - The setter 'setAction' should not return any type except void linguistically 3 224229
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 241
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 241
LinguisticNaming Linguistics Antipattern - The setter 'setActionEvent' should not return any type except void linguistically 3 241246
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 3 257262
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 257
LinguisticNaming Linguistics Antipattern - The setter 'setReference' should not return any type except void linguistically 3 270274
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 3 270
ShortVariable Avoid variables with short names like pp 3 302
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 302
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 315
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 315
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 328
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 328
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 341
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 341
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 354
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 354
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 367
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 367
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 380
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 380
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 393
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 393
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 406
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 406
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 419
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 419
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 432
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 432
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 445
ShortVariable Avoid variables with short names like pp 3 445
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 468
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 491
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 521
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 556

org/apache/turbine/services/pull/tools/UITool.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 65390
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 68
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 132
MethodArgumentCouldBeFinal Parameter 'skinName' is not assigned and could be declared final 3 160
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 174
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 188
MethodArgumentCouldBeFinal Parameter 'skin' is not assigned and could be declared final 3 206
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 206
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 225
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 225
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'imageId' is not assigned and could be declared final 3 255
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 274
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 292
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 322
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 322
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 340
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 340
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 352
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 364
LocalVariableCouldBeFinal Local variable 'pipelineData' could be declared final 3 378
CloseResource Ensure that resources like this PipelineData object are closed after use 3 378
LocalVariableCouldBeFinal Local variable 'runData' could be declared final 3 379
CloseResource Ensure that resources like this RunData object are closed after use 3 379

org/apache/turbine/services/pull/util/DateFormatter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38119
LongVariable Avoid excessively long variable names like DATE_FORMAT_DEFAULT 3 42
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormat' 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 64
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 6667
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'theDate' is not assigned and could be declared final 3 103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'115'). 5 105115
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '105'-'110'). 5 105110
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 110 and 115) 3 105
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 3 106
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'sdf' (lines '106'-'118'). 5 106118

org/apache/turbine/services/pull/util/DateTimeFormatterTool.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 54218
TooManyMethods This class has too many methods, consider refactoring it. 3 56218
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 61
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 61
LongVariable Avoid excessively long variable names like localizationService 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
SingularField Perhaps 'overrideFromRequestLocale' could be replaced by a local variable. 3 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 69
RedundantFieldInitializer Avoid using redundant field initializer for 'overrideFromRequestLocale' 3 69
LongVariable Avoid excessively long variable names like overrideFromRequestLocale 3 69
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 93
LocalVariableCouldBeFinal Local variable 'serviceManager' could be declared final 3 99
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103104
GuardLogStatement Logger calls should be surrounded by log level guards. 2 111
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 140
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 151
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 153
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 157
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 157
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 159
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 163
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 163
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 163
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 165
MethodArgumentCouldBeFinal Parameter 'dateFormatString' is not assigned and could be declared final 3 169
MethodArgumentCouldBeFinal Parameter 'temporalAccessor' is not assigned and could be declared final 3 169
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 169
MethodArgumentCouldBeFinal Parameter 'zoneId' is not assigned and could be declared final 3 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 171
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 175
LongVariable Avoid excessively long variable names like outgoingFormatPattern 3 175
MethodArgumentCouldBeFinal Parameter 'incomingFormatPattern' is not assigned and could be declared final 3 175
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 175
LongVariable Avoid excessively long variable names like incomingFormatPattern 3 175
MethodArgumentCouldBeFinal Parameter 'outgoingFormatPattern' is not assigned and could be declared final 3 175
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 177
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.time.format.DateTimeFormatter' due to existing import 'java.time.format.DateTimeFormatter' 4 181
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 181
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 3 181
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 182
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.time.format.DateTimeFormatter' due to existing import 'java.time.format.DateTimeFormatter' 4 182
MethodArgumentCouldBeFinal Parameter 'incomingFormat' is not assigned and could be declared final 3 182
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 184
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 3 188
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 188
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 190
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 190
MethodArgumentCouldBeFinal Parameter 'incomingFormat' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 194
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 196
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 196
MethodArgumentCouldBeFinal Parameter 'src' is not assigned and could be declared final 3 200
MethodArgumentCouldBeFinal Parameter 'outgoingFormat' is not assigned and could be declared final 3 200
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 200
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 202
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 202
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 209
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 215
ConfusingTernary Avoid if (x != y) ..; else ..; 3 215

org/apache/turbine/services/pull/util/SessionData.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 39118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 116

org/apache/turbine/services/rundata/RunDataService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like PARAMETER_PARSER_KEY 3 54

org/apache/turbine/services/schedule/AbstractJobEntry.java

Rule Violation Priority Line
ModifiedCyclomaticComplexity The class 'AbstractJobEntry' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 3 35478
StdCyclomaticComplexity The class 'AbstractJobEntry' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 3 35478
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 38
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
RedundantFieldInitializer Avoid using redundant field initializer for 'jobIsActive' 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
RedundantFieldInitializer Avoid using redundant field initializer for 'runtime' 3 44
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 94
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 95
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 96
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 97
ShortVariable Avoid variables with short names like wd 3 97
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 98
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 98
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 98
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 99
ConstructorCallsOverridableMethod Overridable method 'calcRunTime' called during object construction 1 117
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 129
ShortVariable Avoid variables with short names like je 3 129
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 3 140
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 187
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'schedrun' (lines '210'-'292'). 5 210292
LocalVariableCouldBeFinal Local variable 'schedrun' could be declared final 3 210
LocalVariableCouldBeFinal Local variable 'now' could be declared final 3 211
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'now' (lines '211'-'292'). 5 211292
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 225
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 238
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 244
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 258
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 264
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 277
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 283
ModifiedCyclomaticComplexity The method 'evaluateJobType' has a Modified Cyclomatic Complexity of 10. 3 304375
CognitiveComplexity The method 'evaluateJobType()' has a cognitive complexity of 37, current threshold is 15 3 304375
StdCyclomaticComplexity The method 'evaluateJobType' has a Standard Cyclomatic Complexity of 10. 3 304375
CyclomaticComplexity The method 'evaluateJobType()' has a cyclomatic complexity of 21. 3 304375
AvoidDuplicateLiterals The String literal "Error in JobEntry. Bad Job parameter." appears 5 times in this file; the first occurrence is on line 323 3 323
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 326
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 337
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 349
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 361
ShortVariable Avoid variables with short names like v 3 391
ShortVariable Avoid variables with short names like v 3 405
ShortVariable Avoid variables with short names like v 3 419
ShortVariable Avoid variables with short names like v 3 433
ShortVariable Avoid variables with short names like v 3 447
ShortVariable Avoid variables with short names like v 3 461
ShortVariable Avoid variables with short names like v 3 477

org/apache/turbine/services/schedule/AbstractSchedulerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 41364
TooManyMethods This class has too many methods, consider refactoring it. 3 42364
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 44
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 44
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
RedundantFieldInitializer Avoid using redundant field initializer for 'scheduleQueue' 3 47
ImmutableField Private field 'enabled' could be made final; it is only initialized in the declaration or constructor. 3 50
LongVariable Avoid excessively long variable names like houseKeepingThread 3 53
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 69
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 71
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 3 78
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 108
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 111
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 118
ShortVariable Avoid variables with short names like wd 3 118
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 118
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 141
ShortVariable Avoid variables with short names like je 3 141
ShortVariable Avoid variables with short names like je 3 155
ShortVariable Avoid variables with short names like je 3 166
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 3 185
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 205209
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 215224
LocalVariableCouldBeFinal Local variable 'thread' could be declared final 3 218
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 218
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 233
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 233236
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 241244
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 243
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 252275
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 262
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 3 272
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 284326
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 292
ShortVariable Avoid variables with short names like je 3 292
LocalVariableCouldBeFinal Local variable 'now' could be declared final 3 301
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 302
LocalVariableCouldBeFinal Local variable 'when' could be declared final 3 302
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 314
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '335'-'343'). 5 335343
ShortVariable Avoid variables with short names like je 3 340
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 340
ConfusingTernary Avoid if (x != y) ..; else ..; 3 341351
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'taskName' (lines '343'-'343'). 5 343
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 343
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 346
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 346
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 354

org/apache/turbine/services/schedule/JobEntry.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like v 3 74
ShortVariable Avoid variables with short names like v 3 88

org/apache/turbine/services/schedule/JobEntryNonPersistent.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 32
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 33
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 35
ShortVariable Avoid variables with short names like wd 3 35
FieldNamingConventions The field name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 36
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 36
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 3 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 81
ShortVariable Avoid variables with short names like wd 3 82
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 83
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 83
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 83
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 96
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 103
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 107
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 1 119
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 3 119
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 1 119
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 141
ShortVariable Avoid variables with short names like v 3 141
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 163
ShortVariable Avoid variables with short names like v 3 163
ShortVariable Avoid variables with short names like v 3 185
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 185
ShortVariable Avoid variables with short names like v 3 207
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 207
ShortVariable Avoid variables with short names like v 3 229
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 229
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 251
ShortVariable Avoid variables with short names like v 3 251
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 273
ShortVariable Avoid variables with short names like v 3 273

org/apache/turbine/services/schedule/JobEntryQuartz.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
AvoidFieldNameMatchingMethodName Field isnew has the same name as a method 3 47
ImmutableField Private field 'active' could be made final; it is only initialized in the declaration or constructor. 3 48
LongVariable Avoid excessively long variable names like DEFAULT_JOB_GROUP_NAME 3 53
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 3 81
MethodArgumentCouldBeFinal Parameter 'jobDetail' is not assigned and could be declared final 3 81
ConstructorCallsOverridableMethod Overridable method 'setTask' called during object construction 1 84
LocalVariableNamingConventions The local variable name '_isnew' doesn't match '[a-z][a-zA-Z0-9]*' 1 95
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), '_isnew' is not final. 1 95
LocalVariableCouldBeFinal Local variable '_isnew' could be declared final 3 95
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 117
ShortVariable Avoid variables with short names like v 3 117
ShortVariable Avoid variables with short names like v 3 139
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 139
MethodArgumentCouldBeFinal Parameter 'jobTrigger' is not assigned and could be declared final 3 155
ShortVariable Avoid variables with short names like o 3 172
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 3 172
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 3 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 201
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 219
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 235
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 237
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 250
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 252

org/apache/turbine/services/schedule/JobQueue.java

Rule Violation Priority Line
UnusedAssignment The field initializer for 'queue' is never used (overwritten on line 48) 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
ImmutableField Private field 'queue' could be made final; it is only initialized in the declaration or constructor. 3 41
RedundantFieldInitializer Avoid using redundant field initializer for 'queue' 3 41
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 48
ConfusingTernary Avoid if (x != y) ..; else ..; 3 70
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 79
ShortVariable Avoid variables with short names like je 3 79
LocalVariableCouldBeFinal Local variable 'job' could be declared final 3 83
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 86
LocalVariableCouldBeFinal Local variable 'jobEntry' could be declared final 3 88
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 92
LooseCoupling Avoid using implementation types like 'Vector'; use the interface instead 3 104
ReplaceVectorWithList Consider replacing this Vector with the newer java.util.List 3 104
ConfusingTernary Avoid if (x != y) ..; else ..; 3 106113
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 108
UseArrayListInsteadOfVector Use ArrayList instead of Vector 3 108
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 121
ShortVariable Avoid variables with short names like je 3 121
MethodArgumentCouldBeFinal Parameter 'jobEntries' is not assigned and could be declared final 3 132
ShortVariable Avoid variables with short names like je 3 145
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 145
ShortVariable Avoid variables with short names like je 3 156
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 156
ShortVariable Avoid variables with short names like je 3 169
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 169

org/apache/turbine/services/schedule/QuartzSchedulerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 49413
TooManyMethods This class has too many methods, consider refactoring it. 3 52413
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 54
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 54
RedundantFieldInitializer Avoid using redundant field initializer for 'enabled' 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 72
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 7374
LocalVariableCouldBeFinal Local variable 'qs' could be declared final 3 7374
ShortVariable Avoid variables with short names like qs 3 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 103
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 103
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 103
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 103
ShortVariable Avoid variables with short names like wd 3 103
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 103
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 3 107109
ShortVariable Avoid variables with short names like jd 3 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107109
LocalVariableCouldBeFinal Local variable 'csb' could be declared final 3 111
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113117
LocalVariableCouldBeFinal Local variable 't' could be declared final 3 113117
ShortVariable Avoid variables with short names like t 3 113
LocalVariableCouldBeFinal Local variable 'jeq' could be declared final 3 119
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'jeq' 3 121
ShortVariable Avoid variables with short names like wd 3 140
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 140
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 140
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 140
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 140
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 140
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 140
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 140
ShortVariable Avoid variables with short names like sb 3 142
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 142
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 143
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 144
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 161
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 3 175
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 178
ShortVariable Avoid variables with short names like je 3 196
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 196
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 3 202
ShortVariable Avoid variables with short names like jq 3 202
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 203
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 218
ShortVariable Avoid variables with short names like je 3 218
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 3 223
ShortVariable Avoid variables with short names like jq 3 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 224
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 224
ShortVariable Avoid variables with short names like je 3 240
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 240
LocalVariableCouldBeFinal Local variable 'jq' could be declared final 3 246
ShortVariable Avoid variables with short names like jq 3 246
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 247
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 247
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 3 263
LocalVariableCouldBeFinal Local variable 'groupMatcher' could be declared final 3 267
LocalVariableCouldBeFinal Local variable 'jobKeys' could be declared final 3 268
LocalVariableCouldBeFinal Local variable 'jk' could be declared final 3 269
LocalVariableCouldBeFinal Local variable 'triggers' could be declared final 3 271
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 273
ShortVariable Avoid variables with short names like jd 3 277
LocalVariableCouldBeFinal Local variable 'jd' could be declared final 3 277
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 278
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 278
LocalVariableCouldBeFinal Local variable 'job' could be declared final 3 278
MethodArgumentCouldBeFinal Parameter 'enabled' is not assigned and could be declared final 3 298
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 318322
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 328340
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 348369
ConfusingTernary Avoid if (x != y) ..; else ..; 3 355362
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 3 361
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 377
ShortVariable Avoid variables with short names like je 3 377
MethodArgumentCouldBeFinal Parameter 'jd' is not assigned and could be declared final 3 409
ShortVariable Avoid variables with short names like jd 3 409
MethodArgumentCouldBeFinal Parameter 'trigger' is not assigned and could be declared final 3 409
LocalVariableCouldBeFinal Local variable 'job' could be declared final 3 410
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'job' 3 411

org/apache/turbine/services/schedule/ScheduleService.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like wd 3 84
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 85
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 85
ShortVariable Avoid variables with short names like je 3 104
ShortVariable Avoid variables with short names like je 3 113
ShortVariable Avoid variables with short names like je 3 122

org/apache/turbine/services/schedule/SchedulerTool.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38113
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 41
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'jobId' is not assigned and could be declared final 3 97
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'je' (lines '99'-'103'). 5 99103
ShortVariable Avoid variables with short names like je 3 99

org/apache/turbine/services/schedule/TorqueSchedulerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38177
LocalVariableCouldBeFinal Local variable 'jobsTorque' could be declared final 3 52
LocalVariableCouldBeFinal Local variable 'job' could be declared final 3 54
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 71
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 71
ShortVariable Avoid variables with short names like wd 3 71
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 71
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 71
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 71
LocalVariableCouldBeFinal Local variable 'jet' could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 3 94
ShortVariable Avoid variables with short names like je 3 98
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 98
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 116
ShortVariable Avoid variables with short names like je 3 116
LocalVariableCouldBeFinal Local variable 'c' could be declared final 3 121
ShortVariable Avoid variables with short names like c 3 121
ShortVariable Avoid variables with short names like je 3 145
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 145

org/apache/turbine/services/schedule/TurbineNonPersistentSchedulerService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 68179
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 76
LocalVariableCouldBeFinal Local variable 'jobProps' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 77
LocalVariableCouldBeFinal Local variable 'jobs' could be declared final 3 78
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'jobs' (lines '78'-'116'). 5 78116
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 82
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 84112
LocalVariableCouldBeFinal Local variable 'jobName' could be declared final 3 86
LocalVariableCouldBeFinal Local variable 'jobPrefix' could be declared final 3 87
LocalVariableCouldBeFinal Local variable 'jobId' could be declared final 3 89
LocalVariableCouldBeFinal Local variable 'sec' could be declared final 3 97
LocalVariableCouldBeFinal Local variable 'min' could be declared final 3 98
ShortVariable Avoid variables with short names like hr 3 99
LocalVariableCouldBeFinal Local variable 'hr' could be declared final 3 99
LocalVariableCouldBeFinal Local variable 'wkday' could be declared final 3 100
LocalVariableCouldBeFinal Local variable 'dayOfMonth' could be declared final 3 101
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 103109
ShortVariable Avoid variables with short names like je 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 110
MethodArgumentCouldBeFinal Parameter 'hour' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'sec' is not assigned and could be declared final 3 122
FormalParameterNamingConventions The method parameter name 'day_mo' doesn't match '[a-z][a-zA-Z0-9]*' 1 122
MethodArgumentCouldBeFinal Parameter 'wd' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'task' is not assigned and could be declared final 3 122
ShortVariable Avoid variables with short names like wd 3 122
MethodArgumentCouldBeFinal Parameter 'min' is not assigned and could be declared final 3 122
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'day_mo' is not final. 1 122
MethodArgumentCouldBeFinal Parameter 'day_mo' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'oid' is not assigned and could be declared final 3 135
ShortVariable Avoid variables with short names like je 3 138
LocalVariableCouldBeFinal Local variable 'je' could be declared final 3 138
ShortVariable Avoid variables with short names like je 3 149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 149
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 163
ShortVariable Avoid variables with short names like je 3 163
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 174

org/apache/turbine/services/schedule/WorkerThread.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like je 3 42
UnusedAssignment The field initializer for 'je' is never used (overwritten on line 54) 3 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
ImmutableField Private field 'je' could be made final; it is only initialized in the declaration or constructor. 3 42
RedundantFieldInitializer Avoid using redundant field initializer for 'je' 3 42
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 45
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 45
ShortVariable Avoid variables with short names like je 3 52
MethodArgumentCouldBeFinal Parameter 'je' is not assigned and could be declared final 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 74
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 77
GuardLogStatement Logger calls should be surrounded by log level guards. 2 7980
MethodArgumentCouldBeFinal Parameter 'state' is not assigned and could be declared final 3 97
UnnecessaryModifier Unnecessary modifier 'final' on method 'logStateChange': private methods cannot be overridden 3 97101
GuardLogStatement Logger calls should be surrounded by log level guards. 2 99100

org/apache/turbine/services/security/DefaultSecurityService.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 11127
GodClass Possible God Class (WMC=88, ATFD=39, TCC=8.956%) 3 741127
ExcessiveClassLength Avoid really long classes. 3 741127
CyclomaticComplexity The class 'DefaultSecurityService' has a total cyclomatic complexity of 88 (highest 4). 3 741127
AtLeastOneConstructor Each class should declare at least one constructor 3 741127
TooManyMethods This class has too many methods, consider refactoring it. 3 771127
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 79
ImmutableField Private field 'readerCount' could be made final; it is only initialized in the declaration or constructor. 3 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 82
RedundantFieldInitializer Avoid using redundant field initializer for 'userManager' 3 82
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 88
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 91
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 96
SingularField Perhaps 'backend' could be replaced by a local variable. 3 96
UnusedPrivateField Avoid unused private fields such as 'backend'. 3 96
RedundantFieldInitializer Avoid using redundant field initializer for 'globalGroup' 3 101
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 101
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 104
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 104
LocalVariableCouldBeFinal Local variable 'manager' could be declared final 3 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 119
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 120
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 124
LocalVariableCouldBeFinal Local variable 'conf' could be declared final 3 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 128130
LocalVariableCouldBeFinal Local variable 'userManagerClassName' could be declared final 3 128130
LongVariable Avoid excessively long variable names like userManagerClassName 3 128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 135
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 139
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 160
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '160'-'168'). 5 160168
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 180
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'user' (lines '186'-'194'). 5 186194
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 186
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '209'-'216'). 5 209216
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 211
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 228
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '234'-'241'). 5 234241
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 236
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '256'-'263'). 5 256263
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 258
MethodArgumentCouldBeFinal Parameter 'permName' is not assigned and could be declared final 3 274
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permission' (lines '280'-'287'). 5 280287
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 282
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '302'-'309'). 5 302309
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 304
MethodArgumentCouldBeFinal Parameter 'roleName' is not assigned and could be declared final 3 321
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'role' (lines '327'-'334'). 5 327334
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 329
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 358
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 361
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 375
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 378
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 395
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 395
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 399
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 413
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 416
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 431
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 444
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 446
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 459
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 462
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 478
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 481
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 495
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 495
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 498
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 510
AvoidDuplicateLiterals The String literal "user is null" appears 4 times in this file; the first occurrence is on line 514 3 514
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 518
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 3 533
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 533
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 3 534
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 538
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 556
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 556
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 559
UseNotifyAllInsteadOfNotify Call Thread.notifyAll() rather than Thread.notify() 3 582
ShortVariable Avoid variables with short names like g 3 646
LocalVariableCouldBeFinal Local variable 'g' could be declared final 3 646
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 660
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 677
ShortVariable Avoid variables with short names like id 3 677
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 693
LocalVariableCouldBeFinal Local variable 'role' could be declared final 3 696
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 714
ShortVariable Avoid variables with short names like id 3 714
LocalVariableCouldBeFinal Local variable 'role' could be declared final 3 718
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 736
MethodArgumentCouldBeFinal Parameter 'id' is not assigned and could be declared final 3 753
ShortVariable Avoid variables with short names like id 3 753
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 813
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 816
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 835
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 835
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 835
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 856
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 856
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 856
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 878
MethodArgumentCouldBeFinal Parameter 'newRole' is not assigned and could be declared final 3 878
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 878
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 895
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 914
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 914
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 930
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 930
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 947
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 969
MethodArgumentCouldBeFinal Parameter 'cascadeDelete' is not assigned and could be declared final 3 969
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 985
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 1000
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 1015
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 1030
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 1045
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 1059
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 1074
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1090
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 1090
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1106
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 1106
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1122
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 1122

org/apache/turbine/services/security/SecurityService.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1757
TooManyMethods This class has too many methods, consider refactoring it. 3 66757
LongVariable Avoid excessively long variable names like USER_MANAGER_DEFAULT 3 80
LongVariable Avoid excessively long variable names like USER_WRAPPER_DEFAULT 3 93
ShortVariable Avoid variables with short names like u 3 272
ShortVariable Avoid variables with short names like id 3 538
ShortVariable Avoid variables with short names like id 3 568
ShortVariable Avoid variables with short names like id 3 598

org/apache/turbine/services/security/UserManager.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48301
ShortVariable Avoid variables with short names like u 3 258

org/apache/turbine/services/security/passive/PassiveUserManager.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 46365
TooManyMethods This class has too many methods, consider refactoring it. 3 47365
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 69
AvoidDuplicateLiterals The String literal "PassiveUserManager knows no users" appears 10 times in this file; the first occurrence is on line 72 3 72
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 103
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 124
MethodArgumentCouldBeFinal Parameter 'username' is not assigned and could be declared final 3 147
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 147
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 165
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 184
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 205
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'initialPassword' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 237
MethodArgumentCouldBeFinal Parameter 'oldPassword' is not assigned and could be declared final 3 257
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 257
MethodArgumentCouldBeFinal Parameter 'newPassword' is not assigned and could be declared final 3 258
MethodArgumentCouldBeFinal Parameter 'password' is not assigned and could be declared final 3 281
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 281
MethodArgumentCouldBeFinal Parameter 'u' is not assigned and could be declared final 3 311
ShortVariable Avoid variables with short names like u 3 311
MethodArgumentCouldBeFinal Parameter 'userName' is not assigned and could be declared final 3 346
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 361

org/apache/turbine/services/servlet/TurbineServletService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 51254
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 55
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 55
RedundantFieldInitializer Avoid using redundant field initializer for 'servletContext' 3 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
RedundantFieldInitializer Avoid using redundant field initializer for 'servletConfig' 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 78
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 99
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'url' (lines '102'-'106'). 5 102106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 114
EmptyCatchBlock Avoid empty catch blocks 3 117120
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 133
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 137
UnusedAssignment The initializer for variable 'is' is never used (overwritten on line 141) 3 140
ShortVariable Avoid variables with short names like is 3 140
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '140'-'141'). 5 140141
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 154
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 162
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 250

org/apache/turbine/services/session/SessionListener.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 61141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 74
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 86
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 125
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 127
MethodArgumentCouldBeFinal Parameter 'event' is not assigned and could be declared final 3 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 139

org/apache/turbine/services/session/SessionTool.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 38141
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
MethodArgumentCouldBeFinal Parameter 'o' is not assigned and could be declared final 3 48
ShortVariable Avoid variables with short names like o 3 48
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 75
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 125
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 137

org/apache/turbine/services/session/TurbineSessionService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55222
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 92
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111
LocalVariableCouldBeFinal Local variable 'session' could be declared final 3 128
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 130
ShortVariable Avoid variables with short names like u 3 130
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 131
MethodArgumentCouldBeFinal Parameter 'session' is not assigned and could be declared final 3 147
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 154
MethodArgumentCouldBeFinal Parameter 'sessionId' is not assigned and could be declared final 3 169
MethodArgumentCouldBeFinal Parameter 'user' is not assigned and could be declared final 3 182
LocalVariableCouldBeFinal Local variable 'sessions' could be declared final 3 184
LocalVariableCouldBeFinal Local variable 'session' could be declared final 3 185
LocalVariableCouldBeFinal Local variable 'u' could be declared final 3 187
ShortVariable Avoid variables with short names like u 3 187
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 217

org/apache/turbine/services/template/BaseTemplateEngineService.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 38145
AtLeastOneConstructor Each class should declare at least one constructor 3 38145
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 53
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 53
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 3 59
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 62
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 63
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 70
MethodArgumentCouldBeFinal Parameter 'defaultExt' is not assigned and could be declared final 3 97
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 99
LongVariable Avoid excessively long variable names like fileExtensionAssociations 3 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fileExtensionAssociations' (lines '111'-'112'). 5 111112
LocalVariableCouldBeFinal Local variable 'copyParams' could be declared final 3 124132
LocalVariableCouldBeFinal Local variable 'copyParam' could be declared final 3 134

org/apache/turbine/services/template/TemplateEngineService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like TEMPLATE_EXTENSIONS 3 35
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_EXTENSION 3 37
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION 3 45
LongVariable Avoid excessively long variable names like DEFAULT_ERROR_SCREEN 3 47
LongVariable Avoid excessively long variable names like DEFAULT_LAYOUT_TEMPLATE 3 49
LongVariable Avoid excessively long variable names like DEFAULT_SCREEN_TEMPLATE 3 51
LongVariable Avoid excessively long variable names like DEFAULT_NAVIGATION_TEMPLATE 3 53
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 60
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 60

org/apache/turbine/services/template/TemplateService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_KEY 3 49
LongVariable Avoid excessively long variable names like DEFAULT_TEMPLATE_VALUE 3 52
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_KEY 3 55
LongVariable Avoid excessively long variable names like DEFAULT_EXTENSION_VALUE 3 58
LongVariable Avoid excessively long variable names like EXTENSION_SEPARATOR 3 61
LongVariable Avoid excessively long variable names like TEMPLATE_PARTS_SEPARATOR 3 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 218
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 229
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 240
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 251
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 262
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 273
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 285
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 299

org/apache/turbine/services/template/mapper/BaseMapper.java

Rule Violation Priority Line
DataClass The class 'BaseMapper' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=8, WMC=21) 3 40226
AbstractNaming Abstract classes should be named AbstractXXX 3 40226
RedundantFieldInitializer Avoid using redundant field initializer for 'useCache' 3 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
RedundantFieldInitializer Avoid using redundant field initializer for 'templateCache' 3 49
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 6669
MethodArgumentCouldBeFinal Parameter 'cacheSize' is not assigned and could be declared final 3 84
MethodArgumentCouldBeFinal Parameter 'useCache' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'defaultProperty' is not assigned and could be declared final 3 120
MethodArgumentCouldBeFinal Parameter 'separator' is not assigned and could be declared final 3 138
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 166
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 170
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 171
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 171
UselessParentheses Useless parentheses. 4 173
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 175
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 178179
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 3 178179
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 178179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 182
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 193
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 197
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 202
LocalVariableCouldBeFinal Local variable 'res' could be declared final 3 205

org/apache/turbine/services/template/mapper/BaseTemplateMapper.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 37117
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4851
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 83
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 8889
LocalVariableCouldBeFinal Local variable 'resBuf' could be declared final 3 93
LocalVariableCouldBeFinal Local variable 'templateComponents' could be declared final 3 95
LongVariable Avoid excessively long variable names like templateComponents 3 95
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 101
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 106

org/apache/turbine/services/template/mapper/ClassMapper.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'loader' 3 60
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 63
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 63
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7073
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7073
MethodArgumentCouldBeFinal Parameter 'loader' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 102
CognitiveComplexity The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 3 102178
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 107110
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 121
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 3 121
UselessParentheses Useless parentheses. 4 122
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
LiteralsFirstInComparisons Position literals first in String comparisons 3 127
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '127'-'178'). 5 127178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 127
LocalVariableCouldBeFinal Local variable 'pkg' could be declared final 3 131
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 132
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 3 132
UselessParentheses Useless parentheses. 4 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 151
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 157
EmptyCatchBlock Avoid empty catch blocks 3 157160

org/apache/turbine/services/template/mapper/DirectMapper.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4346
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 57
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 65
LocalVariableCouldBeFinal Local variable 'dotIndex' could be declared final 3 65
UselessParentheses Useless parentheses. 4 66
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 66

org/apache/turbine/services/template/mapper/DirectTemplateMapper.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4447
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 58
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 6061

org/apache/turbine/services/template/mapper/LayoutTemplateMapper.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 55
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 55
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6265
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 6265
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 75
CognitiveComplexity The method 'doMapping(String)' has a cognitive complexity of 16, current threshold is 15 3 75166
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 7982
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 87
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 93
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 94
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 94
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 98
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 107
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '107'-'166'). 5 107166
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 3 111
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 115
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 3 115
UselessParentheses Useless parentheses. 4 123
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 128
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 3 128
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 141
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '146'-'166'). 5 146166

org/apache/turbine/services/template/mapper/ScreenDefaultTemplateMapper.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 51
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 51
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5861
CallSuperInConstructor It is a good practice to call super() in a constructor 3 5861
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 71
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 7578
LocalVariableCouldBeFinal Local variable 'templateName' could be declared final 3 83
UnusedAssignment The updated value of variable 'componentSize' is never used 3 84
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 89
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 89
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 90
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 94
LocalVariableCouldBeFinal Local variable 'defaultName' could be declared final 3 97
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '102'-'155'). 5 102155
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 102
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 3 106
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 110
LocalVariableCouldBeFinal Local variable 'testName' could be declared final 3 110
UselessParentheses Useless parentheses. 4 118
LocalVariableCouldBeFinal Local variable 'templatePath' could be declared final 3 123
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 123
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 136
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'firstRun' (lines '141'-'155'). 5 141155

org/apache/turbine/services/template/mapper/ScreenTemplateMapper.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4750
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 60
LocalVariableCouldBeFinal Local variable 'components' could be declared final 3 62
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 66
LocalVariableCouldBeFinal Local variable 'tes' could be declared final 3 66
LocalVariableCouldBeFinal Local variable 'templatePackage' could be declared final 3 68
LocalVariableCouldBeFinal Local variable 'testPath' could be declared final 3 71
UselessParentheses Useless parentheses. 4 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 79

org/apache/turbine/services/uniqueid/TurbineUniqueIdService.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44152
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 49
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 49
FieldNamingConventions The constant name 'counter' doesn't match '[A-Z][A-Z_0-9]*' 1 56
VariableNamingConventions Variables that are final and static should be all capitals, 'counter' is not all capitals. 1 56
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
ShortVariable Avoid variables with short names like md 3 79
LocalVariableCouldBeFinal Local variable 'md' could be declared final 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LocalVariableCouldBeFinal Local variable 'bytesId' could be declared final 3 80
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 88
LocalVariableCouldBeFinal Local variable 'current' could be declared final 3 130
ShortVariable Avoid variables with short names like id 3 131
UseUnderscoresInNumericLiterals Number 100000000 should separate every third digit with an underscore 3 135
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 135

org/apache/turbine/services/urlmapper/MappedTemplateLink.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 50118
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56

org/apache/turbine/services/urlmapper/URLMapperService.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like pp 3 57

org/apache/turbine/services/urlmapper/URLMapperValve.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3961
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 50
LocalVariableCouldBeFinal Local variable 'data' could be declared final 3 53
CloseResource Ensure that resources like this RunData object are closed after use 3 53
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 54
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 54
LocalVariableCouldBeFinal Local variable 'uri' could be declared final 3 54
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 56

org/apache/turbine/services/urlmapper/model/URLMapEntry.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 44175
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
RedundantFieldInitializer Avoid using redundant field initializer for 'relevantKeys' 3 52
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'implicit' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'ignore' is not assigned and could be declared final 3 106
MethodArgumentCouldBeFinal Parameter 'override' is not assigned and could be declared final 3 125
MethodArgumentCouldBeFinal Parameter 'groupNamesMap' is not assigned and could be declared final 3 145
MethodArgumentCouldBeFinal Parameter 'relevantKeys' is not assigned and could be declared final 3 165

org/apache/turbine/services/urlmapper/model/URLMappingContainer.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 4398
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'newURLMapEntries' is not assigned and could be declared final 3 94

org/apache/turbine/services/urlmapper/model/XmlParameterAdapter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3562
MethodArgumentCouldBeFinal Parameter 'xmlList' is not assigned and could be declared final 3 41
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 4446
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 4446
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 3 53
LocalVariableCouldBeFinal Local variable 'xmlList' could be declared final 3 55
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 5658
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 5658
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 5658

org/apache/turbine/services/urlmapper/model/XmlParameterList.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 55108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 79
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 86
MethodArgumentCouldBeFinal Parameter 'xmlParameters' is not assigned and could be declared final 3 104

org/apache/turbine/services/urlmapper/model/XmlPatternAdapter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3150
MethodArgumentCouldBeFinal Parameter 'urlPattern' is not assigned and could be declared final 3 37
MethodArgumentCouldBeFinal Parameter 'pattern' is not assigned and could be declared final 3 46

org/apache/turbine/services/velocity/VelocityService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like VELOCITY_EXTENSION 3 52
LongVariable Avoid excessively long variable names like CATCH_ERRORS_DEFAULT 3 64
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 76
AvoidPrefixingMethodParameters Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. 4 89

org/apache/turbine/util/BrowserDetector.java

Rule Violation Priority Line
DataClass The class 'BrowserDetector' is suspected to be a Data Class (WOC=14.286%, NOPA=0, NOAM=4, WMC=9) 3 41172
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 5657
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 3 78
LocalVariableCouldBeFinal Local variable 'userAgent' could be declared final 3 81
ConstructorCallsOverridableMethod Overridable method 'getUserAgent' called during object construction 1 81
LocalVariableCouldBeFinal Local variable 'version' could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 97
MethodArgumentCouldBeFinal Parameter 'userAgentString' is not assigned and could be declared final 3 157
ShortVariable Avoid variables with short names like s 3 168
UnnecessaryModifier Unnecessary modifier 'final' on method 'toFloat': private methods cannot be overridden 3 168171
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 168

org/apache/turbine/util/FormMessage.java

Rule Violation Priority Line
DataClass The class 'FormMessage' is suspected to be a Data Class (WOC=18.182%, NOPA=0, NOAM=5, WMC=12) 3 33161
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 52
ConstructorCallsOverridableMethod Overridable method 'setFormName' called during object construction 1 55
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 65
ConstructorCallsOverridableMethod Overridable method 'setFieldName' called during object construction 1 68
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 80
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 1 83
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 113
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 131
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 141
ShortVariable Avoid variables with short names like sb 3 153
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 153
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 154
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 155
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 157

org/apache/turbine/util/FormMessages.java

Rule Violation Priority Line
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 36
FieldNamingConventions The final field name 'forms_messages' doesn't match '[a-z][a-zA-Z0-9]*' 1 36
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 36
FieldNamingConventions The final field name 'fields_messages' doesn't match '[a-z][a-zA-Z0-9]*' 1 38
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 38
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 40
FieldNamingConventions The final field name 'messages_fields' doesn't match '[a-z][a-zA-Z0-9]*' 1 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 40
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 40
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 42
FieldNamingConventions The final field name 'forms_fields' doesn't match '[a-z][a-zA-Z0-9]*' 1 42
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
MethodArgumentCouldBeFinal Parameter 'returnCode' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'messageName' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 74
LocalVariableCouldBeFinal Local variable 'formFieldName' could be declared final 3 76
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 90
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 90
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 90
ConfusingTernary Avoid if (x != y) ..; else ..; 3 94107
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 117
MethodArgumentCouldBeFinal Parameter 'table' is not assigned and could be declared final 3 117
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 117
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 117
UnnecessaryModifier Unnecessary modifier 'final' on method 'getValues': private methods cannot be overridden 3 117120
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 128154
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 128
ReturnEmptyCollectionRatherThanNull Return an empty collection rather than null. 1 128154
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 4 130
OneDeclarationPerLine Use one line for each declaration, it enhances code readability. 4 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '135'-'138'). 5 135138
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 151
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 163
ReturnEmptyArrayRatherThanNull Return an empty array rather than null. 1 163182
ReturnEmptyCollectionRatherThanNull Return an empty collection rather than null. 1 163182
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 163
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 165
LocalVariableCouldBeFinal Local variable 'messages' could be declared final 3 167
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '172'-'175'). 5 172175
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 179
MethodArgumentCouldBeFinal Parameter 'formName' is not assigned and could be declared final 3 191
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 191
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 3 193
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 194
StringToString Avoid calling toString() on String objects; this is unnecessary. 3 196
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 198

org/apache/turbine/util/GenerateUniqueId.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 40159
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'session_count' is not final. 1 50
FieldNamingConventions The static field name 'session_count' doesn't match '[a-z][a-zA-Z0-9]*' 1 50
RedundantFieldInitializer Avoid using redundant field initializer for 'session_count' 3 50
RedundantFieldInitializer Avoid using redundant field initializer for 'lastTimeVal' 3 51
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'java.util.Random' due to existing import 'java.util.Random' 4 52
UseUnderscoresInNumericLiterals Number 2176782336L should separate every third digit with an underscore 3 61
FieldNamingConventions The public constant name 'maxRandomLen' doesn't match '[A-Z][A-Z_0-9]*' 1 61
VariableNamingConventions Variables that are final and static should be all capitals, 'maxRandomLen' is not all capitals. 1 61
VariableNamingConventions Variables that are final and static should be all capitals, 'maxSessionLifespanTics' is not all capitals. 1 69
LongVariable Avoid excessively long variable names like maxSessionLifespanTics 3 69
FieldNamingConventions The public constant name 'maxSessionLifespanTics' doesn't match '[A-Z][A-Z_0-9]*' 1 69
UseUnderscoresInNumericLiterals Number 46656 should separate every third digit with an underscore 3 69
FieldNamingConventions The public constant name 'ticDifference' doesn't match '[A-Z][A-Z_0-9]*' 1 75
VariableNamingConventions Variables that are final and static should be all capitals, 'ticDifference' is not all capitals. 1 75
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 85130
LocalVariableCouldBeFinal Local variable 'sessionId' could be declared final 3 87
ShortVariable Avoid variables with short names like n 3 90
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100101
UselessParentheses Useless parentheses. 4 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111112
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 138145
MethodArgumentCouldBeFinal Parameter 'jsIdent' is not assigned and could be declared final 3 138
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 142
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 152
SystemPrintln System.out.println is used 2 154
SystemPrintln System.out.println is used 2 155
SystemPrintln System.out.println is used 2 156
SystemPrintln System.out.println is used 2 157

org/apache/turbine/util/HttpUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 4085
MethodArgumentCouldBeFinal Parameter 'date' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 70
MethodArgumentCouldBeFinal Parameter 'expiry' is not assigned and could be declared final 3 70
LocalVariableCouldBeFinal Local variable 'response' could be declared final 3 72

org/apache/turbine/util/InputFilterUtils.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 3568
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 3568
ShortVariable Avoid variables with short names like s 3 45
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 45
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 58
ShortVariable Avoid variables with short names like s 3 58

org/apache/turbine/util/LocaleUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 62248
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 64
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 64
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultLocale' 3 67
RedundantFieldInitializer Avoid using redundant field initializer for 'defaultCharSet' 3 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 8082
LocalVariableCouldBeFinal Local variable 'inputEncoding' could be declared final 3 8082
NonThreadSafeSingleton Singleton is not thread safe 3 100113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103105
LocalVariableCouldBeFinal Local variable 'lang' could be declared final 3 103105
LocalVariableCouldBeFinal Local variable 'country' could be declared final 3 107109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 127
CognitiveComplexity The method 'getDefaultCharset()' has a cognitive complexity of 15, current threshold is 15 3 136190
NonThreadSafeSingleton Singleton is not thread safe 3 138150
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 141143
LocalVariableCouldBeFinal Local variable 'charSet' could be declared final 3 141143
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 3 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 161
LocalVariableCouldBeFinal Local variable 'serviceManager' could be declared final 3 164
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 165
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 165178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 169
LocalVariableCouldBeFinal Local variable 'mimeTypeService' could be declared final 3 169
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 170
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '170'-'190'). 5 170190
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 172
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 202203
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 215216
LocalVariableCouldBeFinal Local variable 'charset' could be declared final 3 215216
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 220
MethodArgumentCouldBeFinal Parameter 'charSet' is not assigned and could be declared final 3 234
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 238

org/apache/turbine/util/ObjectUtils.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 36102
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 36102
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 3 47
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 48
UnusedAssignment The initializer for variable 'byteArray' is never used (overwritten on line 66) 3 50
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'byteArray' (lines '50'-'70'). 5 5070
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'byteArray' (lines '50'-'66'). 5 5066
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 50
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 52
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 56
MethodArgumentCouldBeFinal Parameter 'objectData' is not assigned and could be declared final 3 81
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'object' (lines '83'-'92'). 5 8392
ShortVariable Avoid variables with short names like in 3 88
EmptyCatchBlock Avoid empty catch blocks 3 9497
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 94

org/apache/turbine/util/RunData.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1637
ShortVariable Avoid variables with short names like ct 3 464
ShortVariable Avoid variables with short names like sc 3 494

org/apache/turbine/util/SecurityCheck.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 3 55
RedundantFieldInitializer Avoid using redundant field initializer for 'securityService' 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 72
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'failedScreen' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'initialize' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 91
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 109
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '112'-'122'). 5 112122
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 113
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 115
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 136
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 136
UnusedAssignment The initializer for variable 'roleObject' is never used (overwritten on lines 142 and 148) 3 138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '138'-'142'). 5 138142
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleObject' (lines '142'-'163'). 5 142163
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 142
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleObject' (lines '142'-'148'). 5 142148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 149
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'modelManager' (lines '150'-'163'). 5 150163
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 3 150
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 150
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
UselessParentheses Useless parentheses. 4 158
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 172
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 173
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '175'-'185'). 5 175185
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 176
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 178
CognitiveComplexity The method 'hasPermission(String)' has a cognitive complexity of 17, current threshold is 15 3 204257
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 204
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 205
UnusedAssignment The initializer for variable 'permissionObject' is never used (overwritten on lines 210 and 216) 3 207
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '207'-'210'). 5 207210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'permissionObject' (lines '210'-'257'). 5 210257
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 210
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'permissionObject' (lines '210'-'216'). 5 210216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 216
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 217
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'role' (lines '219'-'224'). 5 219224
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 220
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 221
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 222
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 233
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 234
LocalVariableCouldBeFinal Local variable 'modelManager' could be declared final 3 246
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 247
UselessParentheses Useless parentheses. 4 252

org/apache/turbine/util/ServerData.java

Rule Violation Priority Line
DataClass The class 'ServerData' is suspected to be a Data Class (WOC=18.750%, NOPA=0, NOAM=10, WMC=22) 3 42279
RedundantFieldInitializer Avoid using redundant field initializer for 'serverName' 3 45
RedundantFieldInitializer Avoid using redundant field initializer for 'serverPort' 3 48
RedundantFieldInitializer Avoid using redundant field initializer for 'serverScheme' 3 51
RedundantFieldInitializer Avoid using redundant field initializer for 'scriptName' 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'contextPath' 3 57
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 60
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 60
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 3 72
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 3 75
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 1 86
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 1 88
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 1 89
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 1 90
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 98
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 1 102
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 1 104
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 1 105
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 1 106
MethodArgumentCouldBeFinal Parameter 'req' is not assigned and could be declared final 3 115
ConstructorCallsOverridableMethod Overridable method 'setServerName' called during object construction 1 117
ConstructorCallsOverridableMethod Overridable method 'setServerScheme' called during object construction 1 119
ConstructorCallsOverridableMethod Overridable method 'setScriptName' called during object construction 1 120
ConstructorCallsOverridableMethod Overridable method 'setContextPath' called during object construction 1 121
CloneMethodMustImplementCloneable clone() method should be implemented only if implementing Cloneable interface 3 130134
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 3 130134
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 3 130134
ProperCloneImplementation Object clone() should be implemented with super.clone() 2 130134
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 3 151
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 3 172
GuardLogStatement Logger calls should be surrounded by log level guards. 2 174
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 3 193
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 3 214
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 3 235
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 246
LinguisticNaming Linguistics Antipattern - The getter 'getHostUrl' should not return void linguistically 3 246261
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 248
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 251
LiteralsFirstInComparisons Position literals first in String comparisons 3 251
UselessParentheses Useless parentheses. 4 251252
LiteralsFirstInComparisons Position literals first in String comparisons 3 254
UselessParentheses Useless parentheses. 4 254255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 254
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 258
LocalVariableCouldBeFinal Local variable 'url' could be declared final 3 271
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 275

org/apache/turbine/util/ServletUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 43103
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'text' is not assigned and could be declared final 3 55
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 59
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 64
AvoidFinalLocalVariable Avoid using final local variables, turn them into fields 3 67
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 70
ShortVariable Avoid variables with short names like sb 3 72
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 72
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 73
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 82
LocalVariableCouldBeFinal Local variable 'base' could be declared final 3 8384
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 83
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 88
LocalVariableCouldBeFinal Local variable 'tokenizer' could be declared final 3 91
LocalVariableCouldBeFinal Local variable 'buffer' could be declared final 3 92

org/apache/turbine/util/SystemError.java

Rule Violation Priority Line
DoNotExtendJavaLangError Exceptions should not extend java.lang.Error 3 33
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 3 64

org/apache/turbine/util/TurbineException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 112
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 124
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 137
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 137

org/apache/turbine/util/TurbineRuntimeException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 80

org/apache/turbine/util/TurbineXmlConfig.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 76
MethodArgumentCouldBeFinal Parameter 'attributes' is not assigned and could be declared final 3 76
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 3 77
MethodArgumentCouldBeFinal Parameter 'initParams' is not assigned and could be declared final 3 95
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 95
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 109
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 109

org/apache/turbine/util/template/HtmlPageAttributes.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 105690
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 122
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 128
RedundantFieldInitializer Avoid using redundant field initializer for 'doctype' 3 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 131
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeRootElement 3 131
ImmutableField Private field 'defaultHtmlDoctypeRootElement' could be made final; it is only initialized in the declaration or constructor. 3 131
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeIdentifier 3 134
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 134
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 137
LongVariable Avoid excessively long variable names like defaultHtmlDoctypeUri 3 137
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 154
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 156
LinguisticNaming Linguistics Antipattern - The setter 'setTitle' should not return any type except void linguistically 3 183187
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 183
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 200
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 212
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 212
MethodArgumentCouldBeFinal Parameter 'scriptURL' is not assigned and could be declared final 3 234
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 3 257
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 272273
MethodArgumentCouldBeFinal Parameter 'styleSheetURL' is not assigned and could be declared final 3 272
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 273
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 273
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 3 273
ShortVariable Avoid variables with short names like ss 3 275
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 3 275
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 3 290
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 290
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 317
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 317
MethodArgumentCouldBeFinal Parameter 'linkURL' is not assigned and could be declared final 3 317
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 3 317318
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 318
ShortVariable Avoid variables with short names like ss 3 320
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 3 320
MethodArgumentCouldBeFinal Parameter 'styleText' is not assigned and could be declared final 3 343
LinguisticNaming Linguistics Antipattern - The setter 'setKeywords' should not return any type except void linguistically 3 365369
MethodArgumentCouldBeFinal Parameter 'keywords' is not assigned and could be declared final 3 365
MethodArgumentCouldBeFinal Parameter 'httpEquiv' is not assigned and could be declared final 3 380
LinguisticNaming Linguistics Antipattern - The setter 'setHttpEquiv' should not return any type except void linguistically 3 380384
MethodArgumentCouldBeFinal Parameter 'content' is not assigned and could be declared final 3 380
MethodArgumentCouldBeFinal Parameter 'description' is not assigned and could be declared final 3 392
LinguisticNaming Linguistics Antipattern - The setter 'setDescription' should not return any type except void linguistically 3 392396
LinguisticNaming Linguistics Antipattern - The setter 'setBackground' should not return any type except void linguistically 3 404408
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 404
LinguisticNaming Linguistics Antipattern - The setter 'setBgColor' should not return any type except void linguistically 3 418422
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 418
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 431
LinguisticNaming Linguistics Antipattern - The setter 'setTextColor' should not return any type except void linguistically 3 431435
LinguisticNaming Linguistics Antipattern - The setter 'setLinkColor' should not return any type except void linguistically 3 444448
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 444
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 456
LinguisticNaming Linguistics Antipattern - The setter 'setVlinkColor' should not return any type except void linguistically 3 456460
LinguisticNaming Linguistics Antipattern - The setter 'setAlinkColor' should not return any type except void linguistically 3 468472
MethodArgumentCouldBeFinal Parameter 'color' is not assigned and could be declared final 3 468
DataClass The class 'LinkTag' is suspected to be a Data Class (WOC=0.000%, NOPA=0, NOAM=9, WMC=15) 3 508626
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 523
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 523
ConstructorCallsOverridableMethod Overridable method 'setRelation' called during object construction 1 525
UselessParentheses Useless parentheses. 4 536
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 544
MethodArgumentCouldBeFinal Parameter 'url' is not assigned and could be declared final 3 562
UselessParentheses Useless parentheses. 4 574
MethodArgumentCouldBeFinal Parameter 'title' is not assigned and could be declared final 3 582
UselessParentheses Useless parentheses. 4 594
MethodArgumentCouldBeFinal Parameter 'media' is not assigned and could be declared final 3 602
UselessParentheses Useless parentheses. 4 614
MethodArgumentCouldBeFinal Parameter 'relation' is not assigned and could be declared final 3 622
LocalVariableCouldBeFinal Local variable 'tag' could be declared final 3 643
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 666
MethodArgumentCouldBeFinal Parameter 'identifier' is not assigned and could be declared final 3 666
MethodArgumentCouldBeFinal Parameter 'tag' is not assigned and could be declared final 3 666
LocalVariableCouldBeFinal Local variable 'doctypeBuf' could be declared final 3 668

org/apache/turbine/util/template/TemplateInfo.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like NAVIGATION_TEMPLATE 3 47
UnusedAssignment The field initializer for 'data' is never used (overwritten on line 66) 3 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
ImmutableField Private field 'data' could be made final; it is only initialized in the declaration or constructor. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'data' 3 54
UnusedAssignment The field initializer for 'tempStorage' is never used (overwritten on line 67) 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
ImmutableField Private field 'tempStorage' could be made final; it is only initialized in the declaration or constructor. 3 57
RedundantFieldInitializer Avoid using redundant field initializer for 'tempStorage' 3 57
MethodArgumentCouldBeFinal Parameter 'data' is not assigned and could be declared final 3 64
ShortVariable Avoid variables with short names like v 3 85
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 85
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 107
ShortVariable Avoid variables with short names like v 3 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 109
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 117
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 118
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 120
EmptyCatchBlock Avoid empty catch blocks 3 120125
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 135
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'value' 3 136
ShortVariable Avoid variables with short names like v 3 144
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 144
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 156
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 167
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 167
ShortVariable Avoid variables with short names like v 3 167
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 187
ShortVariable Avoid variables with short names like v 3 187
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 198
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 210
MethodArgumentCouldBeFinal Parameter 'def' is not assigned and could be declared final 3 210
LocalVariableCouldBeFinal Local variable 'val' could be declared final 3 214
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 215
ConfusingTernary Avoid if (x != y) ..; else ..; 3 215
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 217
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 229
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 240
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '242'-'246'). 5 242246
LocalVariableCouldBeFinal Local variable 'object' could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 257
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '259'-'263'). 5 259263
LocalVariableCouldBeFinal Local variable 'object' could be declared final 3 260
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 275
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 287

org/apache/turbine/util/template/TemplateNavigation.java

Rule Violation Priority Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 49
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 3 55
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 62
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 3 7479
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 74
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'module' (lines '89'-'103'). 5 89103
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'module' (lines '89'-'124'). 5 89124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'96'). 5 9096
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'111'). 5 90111
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '90'-'107'). 5 90107
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 97
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 101102
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 101102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 108
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 111
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 113

org/apache/turbine/util/template/TemplateScreen.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 52
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'screen' is not assigned and could be declared final 3 77
LinguisticNaming Linguistics Antipattern - The setter 'setScreen' should not return any type except void linguistically 3 7781
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'returnValue' (lines '91'-'99'). 5 9199
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 95
LocalVariableCouldBeFinal Local variable 'results' could be declared final 3 95
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 102

org/apache/turbine/util/template/TemplateSecurityCheck.java

Rule Violation Priority Line
DataClass The class 'TemplateSecurityCheck' is suspected to be a Data Class (WOC=27.273%, NOPA=0, NOAM=6, WMC=18) 3 52228
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 68
ConstructorCallsOverridableMethod Overridable method 'setMessage' called during object construction 1 71
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 79
LocalVariableCouldBeFinal Local variable 'templateService' could be declared final 3 8283
MethodArgumentCouldBeFinal Parameter 'role' is not assigned and could be declared final 3 94
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 99
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 106
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 108
MethodArgumentCouldBeFinal Parameter 'permission' is not assigned and could be declared final 3 121
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 122
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '124'-'131'). 5 124131
LocalVariableCouldBeFinal Local variable 'acl' could be declared final 3 125
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 126
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 129
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 144
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '146'-'161'). 5 146161
LocalVariableCouldBeFinal Local variable 'userManager' could be declared final 3 149152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 150152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 157158
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 160
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 173
ShortVariable Avoid variables with short names like v 3 173
ShortVariable Avoid variables with short names like v 3 204
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 204
ShortVariable Avoid variables with short names like v 3 224
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 224

org/apache/turbine/util/uri/BaseURI.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 46520
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 51
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'redirect' 3 58
RedundantFieldInitializer Avoid using redundant field initializer for 'response' 3 61
RedundantFieldInitializer Avoid using redundant field initializer for 'reference' 3 64
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 90
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 1 93
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 102
ConstructorCallsOverridableMethod Overridable method 'setResponse' called during object construction 1 105
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 114
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 126
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 126
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 148
ConfusingTernary Avoid if (x != y) ..; else ..; 3 152163
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 164
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 181
MethodArgumentCouldBeFinal Parameter 'scriptName' is not assigned and could be declared final 3 213
MethodArgumentCouldBeFinal Parameter 'contextPath' is not assigned and could be declared final 3 234
MethodArgumentCouldBeFinal Parameter 'serverName' is not assigned and could be declared final 3 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 272
MethodArgumentCouldBeFinal Parameter 'serverPort' is not assigned and could be declared final 3 289
MethodArgumentCouldBeFinal Parameter 'port' is not assigned and could be declared final 3 311
LocalVariableCouldBeFinal Local variable 'useSSL' could be declared final 3 313316
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 314316
MethodArgumentCouldBeFinal Parameter 'serverScheme' is not assigned and could be declared final 3 327
LocalVariableCouldBeFinal Local variable 'serverScheme' could be declared final 3 342
MethodArgumentCouldBeFinal Parameter 'reference' is not assigned and could be declared final 3 352
MethodArgumentCouldBeFinal Parameter 'response' is not assigned and could be declared final 3 393
ShortVariable Avoid variables with short names like sb 3 421
LinguisticNaming Linguistics Antipattern - The getter 'getContextAndScript' should not return void linguistically 3 421445
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 3 421
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 423
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 427
LocalVariableCouldBeFinal Local variable 'script' could be declared final 3 435
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 439
ShortVariable Avoid variables with short names like sb 3 459
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 3 459
LinguisticNaming Linguistics Antipattern - The getter 'getSchemeAndPort' should not return void linguistically 3 459475
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 462
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 463
UselessParentheses Useless parentheses. 4 467468
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 467
UselessParentheses Useless parentheses. 4 469470
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 469
MethodArgumentCouldBeFinal Parameter 'uri' is not assigned and could be declared final 3 486
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'503'). 5 488503
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '488'-'507'). 5 488507
LocalVariableCouldBeFinal Local variable 'response' could be declared final 3 490
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 510
GuardLogStatement Logger calls should be surrounded by log level guards. 2 512
GuardLogStatement Logger calls should be surrounded by log level guards. 2 517

org/apache/turbine/util/uri/DataURI.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 68
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 89
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 89
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 126
LocalVariableCouldBeFinal Local variable 'output' could be declared final 3 164

org/apache/turbine/util/uri/TemplateURI.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 70
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 70
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 81
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 81
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 84
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 94
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 94
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 94
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 97
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'runData' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 132
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 143
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 143
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 154
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 154
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 157
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 167
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 167
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 167
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 170
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 180
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 180
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 180
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'redirect' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'serverData' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 206
MethodArgumentCouldBeFinal Parameter 'action' is not assigned and could be declared final 3 206
ConstructorCallsOverridableMethod Overridable method 'setTemplate' called during object construction 1 209
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 266
ShortVariable Avoid variables with short names like pp 3 267
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 267
LocalVariableCouldBeFinal Local variable 'name' could be declared final 3 269
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 271
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 273
LocalVariableCouldBeFinal Local variable 'values' could be declared final 3 275
ConfusingTernary Avoid if (x != y) ..; else ..; 3 276286
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 278

org/apache/turbine/util/uri/URI.java

Rule Violation Priority Line
ShortClassName Avoid short class names like URI 4 3276

org/apache/turbine/util/uri/URIConstants.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 36
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 39
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 42
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 45
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 54
LongVariable Avoid excessively long variable names like URI_SCHEME_SEPARATOR 3 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 60
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 63
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 66
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 69
LongVariable Avoid excessively long variable names like CGI_TEMPLATE_PARAM 3 69
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 72

org/apache/turbine/util/uri/URIParam.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'key' 3 37
ImmutableField Private field 'key' could be made final; it is only initialized in the declaration or constructor. 3 37
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 37
UnusedAssignment The field initializer for 'key' is never used (overwritten on line 51) 3 37
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 40
RedundantFieldInitializer Avoid using redundant field initializer for 'value' 3 40
ImmutableField Private field 'value' could be made final; it is only initialized in the declaration or constructor. 3 40
UnusedAssignment The field initializer for 'value' is never used (overwritten on line 52) 3 40
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 49
UselessParentheses Useless parentheses. 4 63
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 90
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 9293
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 93
ControlStatementBraces This statement should have braces 3 93
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 9495
ControlStatementBraces This statement should have braces 3 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 95
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 9697
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 97
ControlStatementBraces This statement should have braces 3 97
LocalVariableCouldBeFinal Local variable 'other' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 100
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 101

org/apache/turbine/util/uri/URIUtils.java

Rule Violation Priority Line
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 3453
AbstractNaming Abstract classes should be named AbstractXXX 3 3453
MethodArgumentCouldBeFinal Parameter 'path' is not assigned and could be declared final 3 47
LocalVariableCouldBeFinal Local variable 'du' could be declared final 3 49
ShortVariable Avoid variables with short names like du 3 49

org/apache/turbine/util/velocity/VelocityActionEvent.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 5190
AtLeastOneConstructor Each class should declare at least one constructor 3 5190
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
RedundantFieldInitializer Avoid using redundant field initializer for 'initialized' 3 58
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 66
MethodArgumentCouldBeFinal Parameter 'pipelineData' is not assigned and could be declared final 3 77
ShortVariable Avoid variables with short names like pp 3 85
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 85
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 86

org/apache/turbine/util/velocity/VelocityEmail.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 107
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 107
RedundantFieldInitializer Avoid using redundant field initializer for 'wordWrap' 3 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 116
RedundantFieldInitializer Avoid using redundant field initializer for 'template' 3 116
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 3 119
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 133
LinguisticNaming Linguistics Antipattern - The setter 'setTo' should not return any type except void linguistically 3 149154
MethodArgumentCouldBeFinal Parameter 'toName' is not assigned and could be declared final 3 149
MethodArgumentCouldBeFinal Parameter 'toEmail' is not assigned and could be declared final 3 149
LinguisticNaming Linguistics Antipattern - The setter 'setTemplate' should not return any type except void linguistically 3 164168
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 164
LinguisticNaming Linguistics Antipattern - The setter 'setWordWrap' should not return any type except void linguistically 3 181185
MethodArgumentCouldBeFinal Parameter 'wordWrap' is not assigned and could be declared final 3 181
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 194
LinguisticNaming Linguistics Antipattern - The setter 'setContext' should not return any type except void linguistically 3 194198
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 3 218
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 234236
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'body' (lines '251'-'256'). 5 251256
UnusedAssignment The initializer for variable 'body' is never used (overwritten on line 256) 3 251
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 3 255
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 255
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 256
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'body' (lines '256'-'274'). 5 256274
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 258

org/apache/turbine/util/velocity/VelocityEmailException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 78

org/apache/turbine/util/velocity/VelocityHtmlEmail.java

Rule Violation Priority Line
VariableNamingConventions Variables that are final and static should be all capitals, 'log' is not all capitals. 1 88
FieldNamingConventions The constant name 'log' doesn't match '[A-Z][A-Z_0-9]*' 1 88
RedundantFieldInitializer Avoid using redundant field initializer for 'htmlTemplate' 3 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 94
RedundantFieldInitializer Avoid using redundant field initializer for 'textTemplate' 3 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 103
RedundantFieldInitializer Avoid using redundant field initializer for 'context' 3 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 106
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 106
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 106
RedundantFieldInitializer Avoid using redundant field initializer for 'embmap' 3 106
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 124
LinguisticNaming Linguistics Antipattern - The setter 'setHtmlTemplate' should not return any type except void linguistically 3 139143
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 139
LinguisticNaming Linguistics Antipattern - The setter 'setTextTemplate' should not return any type except void linguistically 3 153157
MethodArgumentCouldBeFinal Parameter 'template' is not assigned and could be declared final 3 153
MethodArgumentCouldBeFinal Parameter 'serverAddress' is not assigned and could be declared final 3 166
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 182184
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 199
LocalVariableCouldBeFinal Local variable 'velocityService' could be declared final 3 199
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'velocityService' (lines '199'-'216'). 5 199216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 207
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 243
MethodArgumentCouldBeFinal Parameter 'surl' is not assigned and could be declared final 3 243
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'cid' (lines '245'-'249'). 5 245249
LocalVariableCouldBeFinal Local variable 'url' could be declared final 3 248
MethodArgumentCouldBeFinal Parameter 'filename' is not assigned and could be declared final 3 266
LocalVariableCouldBeFinal Local variable 'cid' could be declared final 3 268

org/apache/turbine/services/schedule/BaseJobEntryTorque.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1887
AbstractNaming Abstract classes should be named AbstractXXX 3 25887
AtLeastOneConstructor Each class should declare at least one constructor 3 25887
ModifiedCyclomaticComplexity The class 'BaseJobEntryTorque' has a Modified Cyclomatic Complexity of 2 (Highest = 12). 3 25887
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.AbstractJobEntry' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 25
StdCyclomaticComplexity The class 'BaseJobEntryTorque' has a Standard Cyclomatic Complexity of 2 (Highest = 12). 3 25887
CyclomaticComplexity The class 'BaseJobEntryTorque' has a total cyclomatic complexity of 80 (highest 12). 3 25887
GodClass Possible God Class (WMC=80, ATFD=31, TCC=2.211%) 3 25887
TooManyMethods This class has too many methods, consider refactoring it. 3 27887
RedundantFieldInitializer Avoid using redundant field initializer for 'jobId' 3 34
RedundantFieldInitializer Avoid using redundant field initializer for 'task' 3 52
RedundantFieldInitializer Avoid using redundant field initializer for 'email' 3 55
RedundantFieldInitializer Avoid using redundant field initializer for 'property' 3 58
AvoidFieldNameMatchingMethodName Field isNew has the same name as a method 3 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
RedundantFieldInitializer Avoid using redundant field initializer for 'saving' 3 70
RedundantFieldInitializer Avoid using redundant field initializer for 'loading' 3 76
RedundantFieldInitializer Avoid using redundant field initializer for 'deleted' 3 83
MissingOverride The method 'getJobId()' is missing an @Override annotation. 3 9498
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 105
ShortVariable Avoid variables with short names like v 3 105
MissingOverride The method 'setJobId(int)' is missing an @Override annotation. 3 105115
MissingOverride The method 'getSecond()' is missing an @Override annotation. 3 122126
MissingOverride The method 'setSecond(int)' is missing an @Override annotation. 3 133143
ShortVariable Avoid variables with short names like v 3 133
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 133
MissingOverride The method 'getMinute()' is missing an @Override annotation. 3 150154
MissingOverride The method 'setMinute(int)' is missing an @Override annotation. 3 161171
ShortVariable Avoid variables with short names like v 3 161
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 161
MissingOverride The method 'getHour()' is missing an @Override annotation. 3 178182
ShortVariable Avoid variables with short names like v 3 189
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 189
MissingOverride The method 'setHour(int)' is missing an @Override annotation. 3 189199
MissingOverride The method 'getWeekDay()' is missing an @Override annotation. 3 206210
ShortVariable Avoid variables with short names like v 3 217
MissingOverride The method 'setWeekDay(int)' is missing an @Override annotation. 3 217227
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 217
MissingOverride The method 'getDayOfMonth()' is missing an @Override annotation. 3 234238
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 245
MissingOverride The method 'setDayOfMonth(int)' is missing an @Override annotation. 3 245255
ShortVariable Avoid variables with short names like v 3 245
MissingOverride The method 'getTask()' is missing an @Override annotation. 3 262266
ShortVariable Avoid variables with short names like v 3 273
MissingOverride The method 'setTask(String)' is missing an @Override annotation. 3 273283
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 273
ShortVariable Avoid variables with short names like v 3 301
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 301
MethodReturnsInternalArray Returning 'property' may expose an internal array. 3 321
ArrayIsStoredDirectly The user-supplied array 'v' is stored directly. 3 329
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 329
ShortVariable Avoid variables with short names like v 3 329
MissingOverride The method 'isNew()' is missing an @Override annotation. 3 349352
MethodArgumentCouldBeFinal Parameter 'isNew' is not assigned and could be declared final 3 359
MissingOverride The method 'setNew(boolean)' is missing an @Override annotation. 3 359362
MissingOverride The method 'isModified()' is missing an @Override annotation. 3 369372
MissingOverride The method 'setModified(boolean)' is missing an @Override annotation. 3 379382
MethodArgumentCouldBeFinal Parameter 'modified' is not assigned and could be declared final 3 379
MethodArgumentCouldBeFinal Parameter 'saving' is not assigned and could be declared final 3 408
MethodArgumentCouldBeFinal Parameter 'loading' is not assigned and could be declared final 3 429
MethodArgumentCouldBeFinal Parameter 'deleted' is not assigned and could be declared final 3 456
MissingOverride The method 'save()' is missing an @Override annotation. 3 474477
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 3 488
MissingOverride The method 'save(String)' is missing an @Override annotation. 3 488496
MissingOverride The method 'save(Connection)' is missing an @Override annotation. 3 509538
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 509
MissingOverride The method 'setPrimaryKey(ObjectKey)' is missing an @Override annotation. 3 548552
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 548
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 559
MissingOverride The method 'setPrimaryKey(String)' is missing an @Override annotation. 3 559562
MissingOverride The method 'getPrimaryKey()' is missing an @Override annotation. 3 569572
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 597
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 3 612
LocalVariableCouldBeFinal Local variable 'jobEntryTorque' could be declared final 3 614
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 630
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 3 630
LocalVariableCouldBeFinal Local variable 'jobEntryTorque' could be declared final 3 632
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 3 644
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 3 657
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 657
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 3 671
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 3 671
EmptyIfStmt Avoid empty if statements 3 684685
MethodArgumentCouldBeFinal Parameter 'copyObj' is not assigned and could be declared final 3 700
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 700
MethodArgumentCouldBeFinal Parameter 'deepcopy' is not assigned and could be declared final 3 700
EmptyIfStmt Avoid empty if statements 3 713714
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 719720
FieldNamingConventions The constant name 'peer' doesn't match '[A-Z][A-Z_0-9]*' 1 719
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 719
VariableNamingConventions Variables that are final and static should be all capitals, 'peer' is not all capitals. 1 719
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 720
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 728
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 742
MissingOverride The method 'toString()' is missing an @Override annotation. 3 747779
InsufficientStringBufferDeclaration StringBuffer has been initialized with size 16, but has at least 125 characters appended. 3 749
LocalVariableCouldBeFinal Local variable 'str' could be declared final 3 749
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 750
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 750
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 751753
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 753
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 753
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 754756
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 756
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 756
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 757759
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 759
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 759
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 760762
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 762
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 762
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 763765
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 765
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 765
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 766768
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 768
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 768
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 769771
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 771
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 771
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 772774
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 4 consecutive times with literals. Use a single append with a single combined String. 3 774
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 774
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 777
UselessParentheses Useless parentheses. 4 778
MissingOverride The method 'equals(Object)' is missing an @Override annotation. 3 788808
MethodArgumentCouldBeFinal Parameter 'toCompare' is not assigned and could be declared final 3 788
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 792
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 796
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 798
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 800
LocalVariableCouldBeFinal Local variable 'other' could be declared final 3 802
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 803
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 805
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 807
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 807
MissingOverride The method 'hashCode()' is missing an @Override annotation. 3 816825
ShortVariable Avoid variables with short names like ok 3 818
LocalVariableCouldBeFinal Local variable 'ok' could be declared final 3 818
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 821
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 824
CyclomaticComplexity The method 'valueEquals(JobEntryTorque)' has a cyclomatic complexity of 12. 3 836883
StdCyclomaticComplexity The method 'valueEquals' has a Standard Cyclomatic Complexity of 12. 3 836883
NPathComplexity The method 'valueEquals(JobEntryTorque)' has an NPath complexity of 2048, current threshold is 200 3 836883
MethodArgumentCouldBeFinal Parameter 'toCompare' is not assigned and could be declared final 3 836
ModifiedCyclomaticComplexity The method 'valueEquals' has a Modified Cyclomatic Complexity of 12. 3 836883
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 840
CompareObjectsWithEquals Use equals() to compare object references. 3 842
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 844
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 848
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 852
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 856
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 860
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 864
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 868
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 872
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 876
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 878881
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 880

org/apache/turbine/services/schedule/BaseJobEntryTorquePeer.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 11477
AbstractNaming Abstract classes should be named AbstractXXX 3 361477
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 3 361477
ExcessiveClassLength Avoid really long classes. 3 361477
TooManyMethods This class has too many methods, consider refactoring it. 3 371477
FieldNamingConventions The public constant name 'numColumns' doesn't match '[A-Z][A-Z_0-9]*' 1 66
VariableNamingConventions Variables that are final and static should be all capitals, 'numColumns' is not all capitals. 1 66
LongVariable Avoid excessively long variable names like jobEntryTorquePeerImpl 3 70
LocalVariableCouldBeFinal Local variable 'dbMap' could be declared final 3 7576
AvoidDuplicateLiterals The String literal "TURBINE_SCHEDULED_JOB" appears 5 times in this file; the first occurrence is on line 77 3 77
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorque' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 86
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.JobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 87
AvoidDuplicateLiterals The String literal "INTEGER" appears 6 times in this file; the first occurrence is on line 98 3 98
AvoidDuplicateLiterals The String literal "int" appears 6 times in this file; the first occurrence is on line 105 3 105
LocalVariableCouldBeFinal Local variable 'instance' could be declared final 3 232
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'instance' 3 233
MethodArgumentCouldBeFinal Parameter 'peerImplInstance' is not assigned and could be declared final 3 263
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 274
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 276
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 291
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 293
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 3 309
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 312
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 325
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 328
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 344
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 345
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 348
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 368
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 369
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 372
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 387
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 388
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 391
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 408
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 409
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 410
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 413416
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 437
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 438
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 439
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 442445
MethodArgumentCouldBeFinal Parameter 'query' is not assigned and could be declared final 3 462
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 463
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 3 464
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 467470
MethodArgumentCouldBeFinal Parameter 'query' is not assigned and could be declared final 3 486
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 487
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 488
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 491494
MethodArgumentCouldBeFinal Parameter 'query' is not assigned and could be declared final 3 514
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 515
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 516
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 519522
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 534
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 537
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 551
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 554
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 570
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 571
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 574
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.torque.criteria.Criteria' due to existing import 'org.apache.torque.criteria.Criteria' 4 589
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 589
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 590
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 593595
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 611
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.torque.criteria.Criteria' due to existing import 'org.apache.torque.criteria.Criteria' 4 611
MethodArgumentCouldBeFinal Parameter 'mapper' is not assigned and could be declared final 3 612
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 613
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 616619
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 632
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 635
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 644
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 3 658
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 661
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 3 676
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 676
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 679
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 687
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 690
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 703
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 703
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 706
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 725
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 747
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 768
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 3 788
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 792796
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 3 808
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 810
MethodArgumentCouldBeFinal Parameter 'columnValues' is not assigned and could be declared final 3 827
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 827
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 830
MethodArgumentCouldBeFinal Parameter 'selectCriteria' is not assigned and could be declared final 3 846
MethodArgumentCouldBeFinal Parameter 'updateValues' is not assigned and could be declared final 3 847
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 850852
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 869
MethodArgumentCouldBeFinal Parameter 'updateValues' is not assigned and could be declared final 3 870
MethodArgumentCouldBeFinal Parameter 'connection' is not assigned and could be declared final 3 871
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 874877
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 891
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 893
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 908
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 908
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 911
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 3 927
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 930
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 3 949
MethodArgumentCouldBeFinal Parameter 'replacementValues' is not assigned and could be declared final 3 950
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 953955
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 3 976
MethodArgumentCouldBeFinal Parameter 'dbName' is not assigned and could be declared final 3 977
MethodArgumentCouldBeFinal Parameter 'replacementValues' is not assigned and could be declared final 3 978
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 981984
MethodArgumentCouldBeFinal Parameter 'statementString' is not assigned and could be declared final 3 1003
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1004
MethodArgumentCouldBeFinal Parameter 'replacementValues' is not assigned and could be declared final 3 1005
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 10081011
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 10371039
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 10681071
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 10991102
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 1116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1118
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 1135
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1138
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 1151
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1153
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 1170
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1173
MethodArgumentCouldBeFinal Parameter 'objects' is not assigned and could be declared final 3 1187
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1190
MethodArgumentCouldBeFinal Parameter 'objects' is not assigned and could be declared final 3 1209
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1210
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1213
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 3 1226
ShortVariable Avoid variables with short names like pk 3 1226
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1228
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 3 1245
ShortVariable Avoid variables with short names like pk 3 1245
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1245
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1248
ShortVariable Avoid variables with short names like pk 3 1257
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 3 1257
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1259
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 3 1269
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1271
MethodArgumentCouldBeFinal Parameter 'objects' is not assigned and could be declared final 3 1282
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1284
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 1292
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1294
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 1303
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1305
MethodArgumentCouldBeFinal Parameter 'jobEntryTorque' is not assigned and could be declared final 3 1314
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1318
ShortVariable Avoid variables with short names like pk 3 1330
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 3 1330
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1333
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 3 1346
ShortVariable Avoid variables with short names like pk 3 1346
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1346
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1349
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 3 1364
ShortVariable Avoid variables with short names like pk 3 1364
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1367
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1380
MethodArgumentCouldBeFinal Parameter 'pk' is not assigned and could be declared final 3 1380
ShortVariable Avoid variables with short names like pk 3 1380
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1383
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 3 1397
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1400
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 3 1415
MethodArgumentCouldBeFinal Parameter 'dbcon' is not assigned and could be declared final 3 1416
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1419
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 3 1432
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1435
MethodArgumentCouldBeFinal Parameter 'pks' is not assigned and could be declared final 3 1449
MethodArgumentCouldBeFinal Parameter 'con' is not assigned and could be declared final 3 1449
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1452
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1469
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 1 14721474

org/apache/turbine/services/schedule/BaseJobEntryTorqueRecordMapper.java

Rule Violation Priority Line
StdCyclomaticComplexity The class 'BaseJobEntryTorqueRecordMapper' has a Standard Cyclomatic Complexity of 3 (Highest = 13). 3 24429
ModifiedCyclomaticComplexity The class 'BaseJobEntryTorqueRecordMapper' has a Modified Cyclomatic Complexity of 3 (Highest = 13). 3 24429
AtLeastOneConstructor Each class should declare at least one constructor 3 24429
ProperLogger Logger should be defined private static final and have the correct class 3 3031
NcssCount The method 'processRow(ResultSet, int, Criteria)' has a NCSS line count of 64. 3 54178
ModifiedCyclomaticComplexity The method 'processRow' has a Modified Cyclomatic Complexity of 13. 3 54178
StdCyclomaticComplexity The method 'processRow' has a Standard Cyclomatic Complexity of 13. 3 54178
CyclomaticComplexity The method 'processRow(ResultSet, int, Criteria)' has a cyclomatic complexity of 13. 3 54178
MissingOverride The method 'processRow(ResultSet, int, Criteria)' is missing an @Override annotation. 3 54178
ExcessiveMethodLength Avoid really long methods. 3 54178
CognitiveComplexity The method 'processRow(ResultSet, int, Criteria)' has a cognitive complexity of 17, current threshold is 15 3 54178
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'offset' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'criteria' is not assigned and could be declared final 3 57
LocalVariableCouldBeFinal Local variable 'jobEntryTorque' could be declared final 3 60
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'152'). 5 90152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'103'). 5 90103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'159'). 5 90159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'138'). 5 90138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'124'). 5 90124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'131'). 5 90131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'145'). 5 90145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'117'). 5 90117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '90'-'110'). 5 90110
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'totalOffset' (lines '91'-'178'). 5 91178
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'totalOffset' (lines '91'-'161'). 5 91161
LocalVariableCouldBeFinal Local variable 'selectColumns' could be declared final 3 92
LocalVariableCouldBeFinal Local variable 'columnsWithoutOffset' could be declared final 3 9395
LongVariable Avoid excessively long variable names like columnsWithoutOffset 3 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 9395
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 95
LocalVariableCouldBeFinal Local variable 'column' could be declared final 3 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 9899
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 9899
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'159'). 5 103159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'117'). 5 103117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'124'). 5 103124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'152'). 5 103152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'110'). 5 103110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'103'). 5 103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'145'). 5 103145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'138'). 5 103138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '103'-'131'). 5 103131
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 105106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'110'). 5 110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'145'). 5 110145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'159'). 5 110159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'152'). 5 110152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'138'). 5 110138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'131'). 5 110131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'117'). 5 110117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'103'). 5 110103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '110'-'124'). 5 110124
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 112113
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 112113
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'152'). 5 117152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'110'). 5 117110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'103'). 5 117103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'145'). 5 117145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'159'). 5 117159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'138'). 5 117138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'131'). 5 117131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'117'). 5 117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '117'-'124'). 5 117124
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 119120
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 119120
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'131'). 5 124131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'117'). 5 124117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'159'). 5 124159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'124'). 5 124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'110'). 5 124110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'138'). 5 124138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'103'). 5 124103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'152'). 5 124152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '124'-'145'). 5 124145
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 126127
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 126127
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'152'). 5 131152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'124'). 5 131124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'138'). 5 131138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'131'). 5 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'110'). 5 131110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'159'). 5 131159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'145'). 5 131145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'103'). 5 131103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '131'-'117'). 5 131117
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 133134
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 133134
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'103'). 5 138103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'124'). 5 138124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'152'). 5 138152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'110'). 5 138110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'145'). 5 138145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'159'). 5 138159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'117'). 5 138117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'131'). 5 138131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '138'-'138'). 5 138
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 140141
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 140141
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'117'). 5 145117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'124'). 5 145124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'159'). 5 145159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'145'). 5 145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'131'). 5 145131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'110'). 5 145110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'152'). 5 145152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'138'). 5 145138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '145'-'103'). 5 145103
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 147148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 147148
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'131'). 5 152131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'110'). 5 152110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'159'). 5 152159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'103'). 5 152103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'124'). 5 152124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'138'). 5 152138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'145'). 5 152145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'117'). 5 152117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '152'-'152'). 5 152
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 154155
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 154155
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'103'). 5 159103
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'159'). 5 159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'124'). 5 159124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'117'). 5 159117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'138'). 5 159138
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'145'). 5 159145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'131'). 5 159131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'152'). 5 159152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'columnMapped' (lines '159'-'110'). 5 159110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'totalOffset' (lines '161'-'161'). 5 161
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'totalOffset' (lines '161'-'178'). 5 161178
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 167
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 194
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 195
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 221
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 222
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 248
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 249
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 275
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 276
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 302
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 329
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 330
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 356
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 357
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 383
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 384
MethodArgumentCouldBeFinal Parameter 'resultSet' is not assigned and could be declared final 3 410
MethodArgumentCouldBeFinal Parameter 'columnIndex' is not assigned and could be declared final 3 411
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '416'-'419'). 5 416419
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 419

org/apache/turbine/services/schedule/JobEntryTorque.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.BaseJobEntryTorque' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 15

org/apache/turbine/services/schedule/JobEntryTorquePeer.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 1317
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.BaseJobEntryTorquePeer' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 14

org/apache/turbine/services/schedule/JobEntryTorquePeerImpl.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'org.apache.turbine.services.schedule.BaseJobEntryTorquePeerImpl' due to existing same package import 'org.apache.turbine.services.schedule.*' 4 14

Processing Errors

Filename Problem
org/apache/turbine/Turbine.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\Turbine.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\Turbine.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 59388 out of bounds for length 20444
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/annotation/AnnotationProcessor.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\annotation\AnnotationProcessor.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\annotation\AnnotationProcessor.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 56519 out of bounds for length 17900
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/modules/ActionEvent.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\modules\ActionEvent.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\modules\ActionEvent.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 22594 out of bounds for length 9209
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/BaseServiceBroker.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\BaseServiceBroker.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\BaseServiceBroker.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 35251 out of bounds for length 13450
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/intake/IntakeTool.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\intake\IntakeTool.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\intake\IntakeTool.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 11936 out of bounds for length 9158
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/pull/TurbinePullService.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\pull\TurbinePullService.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\pull\TurbinePullService.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 22192 out of bounds for length 13579
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/rundata/DefaultTurbineRunData.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\rundata\DefaultTurbineRunData.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\rundata\DefaultTurbineRunData.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 54960 out of bounds for length 18320
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/rundata/TurbineRunDataService.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\rundata\TurbineRunDataService.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\rundata\TurbineRunDataService.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 16981 out of bounds for length 9023
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/security/DefaultUserManager.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\security\DefaultUserManager.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\security\DefaultUserManager.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 12430 out of bounds for length 10521
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/template/TurbineTemplateService.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\template\TurbineTemplateService.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\template\TurbineTemplateService.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 22054 out of bounds for length 13175
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/ui/TurbineUIService.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\ui\TurbineUIService.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\ui\TurbineUIService.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 20096 out of bounds for length 9585
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/urlmapper/TurbineURLMapperService.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\urlmapper\TurbineURLMapperService.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\urlmapper\TurbineURLMapperService.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 68209 out of bounds for length 14414
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/velocity/TurbineVelocityService.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\velocity\TurbineVelocityService.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\services\velocity\TurbineVelocityService.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 36315 out of bounds for length 12008
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/util/TurbineConfig.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\util\TurbineConfig.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\util\TurbineConfig.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 13539 out of bounds for length 13534
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/util/uri/TurbineURI.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\util\uri\TurbineURI.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\src\java\org\apache\turbine\util\uri\TurbineURI.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 60369 out of bounds for length 14372
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/turbine/services/schedule/BaseJobEntryTorquePeerImpl.java PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\target\generated-sources\org\apache\turbine\services\schedule\BaseJobEntryTorquePeerImpl.java
net.sourceforge.pmd.PMDException: Error while processing C:\dc\apache.org\turbine\git\tmp\turbine-core\target\generated-sources\org\apache\turbine\services\schedule\BaseJobEntryTorquePeerImpl.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:128)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:85)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 26026 out of bounds for length 13790
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at org.objectweb.asm.ClassReader.(Unknown Source)
	at net.sourceforge.pmd.lang.java.typeresolution.PMDASMClassLoader.getImportedClasses(PMDASMClassLoader.java:118)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.populateClassName(ClassTypeResolver.java:1617)
	at net.sourceforge.pmd.lang.java.typeresolution.ClassTypeResolver.visit(ClassTypeResolver.java:214)
	at net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit.jjtAccept(ASTCompilationUnit.java:44)
	at net.sourceforge.pmd.lang.java.typeresolution.TypeResolutionFacade.initializeWith(TypeResolutionFacade.java:21)
	at net.sourceforge.pmd.lang.java.AbstractJavaHandler$5.start(AbstractJavaHandler.java:121)
	at net.sourceforge.pmd.SourceCodeProcessor.usesTypeResolution(SourceCodeProcessor.java:178)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:205)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more