FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is min
Summary
Classes |
Bugs |
Errors |
Missing Classes |
258 |
21 |
0 |
109 |
org.apache.turbine.Turbine
org.apache.turbine.om.security.DefaultUserImpl
Bug |
Category |
Details |
Line |
Priority |
Inconsistent synchronization of org.apache.turbine.om.security.DefaultUserImpl.permStorage; locked 83% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
480 |
Medium |
org.apache.turbine.services.naming.TurbineNamingService
Bug |
Category |
Details |
Line |
Priority |
Write to static field org.apache.turbine.services.naming.TurbineNamingService.contextPropsList from instance method org.apache.turbine.services.naming.TurbineNamingService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
84 |
Medium |
org.apache.turbine.services.pull.TurbinePullService
Bug |
Category |
Details |
Line |
Priority |
Redundant nullcheck of tool, which is known to be non-null in org.apache.turbine.services.pull.TurbinePullService.populateWithPermTools(List, Context, Object, User) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
636 |
Medium |
Redundant nullcheck of tool, which is known to be non-null in org.apache.turbine.services.pull.TurbinePullService.populateWithSessionTools(List, Context, RunData, User) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
553 |
Medium |
org.apache.turbine.services.schedule.AbstractSchedulerService$MainLoop
Bug |
Category |
Details |
Line |
Priority |
org.apache.turbine.services.schedule.BaseJobEntryTorque
Bug |
Category |
Details |
Line |
Priority |
Using .equals to compare two byte[]'s, (equivalent to ==) in org.apache.turbine.services.schedule.BaseJobEntryTorque.setProperty(byte[]) |
CORRECTNESS |
EC_BAD_ARRAY_COMPARE |
331 |
Medium |
Using .equals to compare two byte[]'s, (equivalent to ==) in org.apache.turbine.services.schedule.BaseJobEntryTorque.valueEquals(JobEntryTorque) |
CORRECTNESS |
EC_BAD_ARRAY_COMPARE |
878 |
Medium |
org.apache.turbine.services.schedule.BaseJobEntryTorque.getProperty() may expose internal representation by returning BaseJobEntryTorque.property |
MALICIOUS_CODE |
EI_EXPOSE_REP |
321 |
Medium |
org.apache.turbine.services.schedule.BaseJobEntryTorque.setProperty(byte[]) may expose internal representation by storing an externally mutable object into BaseJobEntryTorque.property |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
336 |
Medium |
org.apache.turbine.services.schedule.JobEntryQuartz
Bug |
Category |
Details |
Line |
Priority |
org.apache.turbine.services.schedule.JobEntryQuartz defines compareTo(Object) and uses Object.equals() |
BAD_PRACTICE |
EQ_COMPARETO_USE_OBJECT_EQUALS |
41 |
Medium |
org.apache.turbine.services.template.BaseTemplateEngineService
Bug |
Category |
Details |
Line |
Priority |
org.apache.turbine.services.template.BaseTemplateEngineService.getTemplateEngineServiceConfiguration() may expose internal representation by returning BaseTemplateEngineService.configuration |
MALICIOUS_CODE |
EI_EXPOSE_REP |
72 |
Medium |
org.apache.turbine.services.template.mapper.ScreenDefaultTemplateMapper
Bug |
Category |
Details |
Line |
Priority |
Dead store to componentSize in org.apache.turbine.services.template.mapper.ScreenDefaultTemplateMapper.doMapping(String) |
STYLE |
DLS_DEAD_LOCAL_STORE |
84 |
Medium |
org.apache.turbine.services.uniqueid.TurbineUniqueIdService
Bug |
Category |
Details |
Line |
Priority |
Write to static field org.apache.turbine.services.uniqueid.TurbineUniqueIdService.turbineId from instance method org.apache.turbine.services.uniqueid.TurbineUniqueIdService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
81 |
Medium |
Write to static field org.apache.turbine.services.uniqueid.TurbineUniqueIdService.turbineURL from instance method org.apache.turbine.services.uniqueid.TurbineUniqueIdService.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
77 |
Medium |
org.apache.turbine.util.ServerData
org.apache.turbine.util.TurbineConfig