PMD Results
The following document contains the results of PMD 6.29.0.
Violations By Priority
Priority 3
org/apache/fulcrum/upload/DefaultUploadService.java
| Rule | Violation | Line |
|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 67–407 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 68–407 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 70 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 72 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 73 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 75 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 76 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 81 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 105 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 127 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 143 |
| MethodArgumentCouldBeFinal | Parameter 'sizeThreshold' is not assigned and could be declared final | 162 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 162 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 162 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 162 |
| MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 180 |
| LocalVariableCouldBeFinal | Local variable 'fileUpload' could be declared final | 183 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 207 |
| LocalVariableCouldBeFinal | Local variable 'upload' could be declared final | 208 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileUploadException' branch | 213–215 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 229 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 245 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 245 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 263 |
| MethodArgumentCouldBeFinal | Parameter 'sizeThreshold' is not assigned and could be declared final | 263 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 263 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 263 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 281 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 281 |
| MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 281 |
| LocalVariableCouldBeFinal | Local variable 'fileUpload' could be declared final | 284 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 308 |
| LocalVariableCouldBeFinal | Local variable 'upload' could be declared final | 309 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileUploadException' branch | 314–316 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 329 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 343 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 350 |
| UnusedAssignment | The initializer for variable 'absolutePath' is never used (overwritten on lines 353 and 355) | 351 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 366 |
| LocalVariableCouldBeFinal | Local variable 'testPath' could be declared final | 389 |
| LocalVariableCouldBeFinal | Local variable 'testDir' could be declared final | 390 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 395 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 404 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 405 |
org/apache/fulcrum/upload/UploadService.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like CONTENT_DISPOSITION | 56 |
| LongVariable | Avoid excessively long variable names like MULTIPART_FORM_DATA | 76 |
| LongVariable | Avoid excessively long variable names like REPOSITORY_PARAMETER | 86 |
| LongVariable | Avoid excessively long variable names like REPOSITORY_DEFAULT | 100 |
| UseUnderscoresInNumericLiterals | Number 1048576 should separate every third digit with an underscore | 116 |
| LongVariable | Avoid excessively long variable names like SIZE_THRESHOLD_KEY | 122 |
| LongVariable | Avoid excessively long variable names like SIZE_THRESHOLD_DEFAULT | 130 |
| UseUnderscoresInNumericLiterals | Number 10240 should separate every third digit with an underscore | 130 |
| LongVariable | Avoid excessively long variable names like HEADER_ENCODING_KEY | 136 |
| LongVariable | Avoid excessively long variable names like HEADER_ENCODING_DEFAULT | 143 |
Priority 5
org/apache/fulcrum/upload/DefaultUploadService.java
| Rule | Violation | Line |
|---|---|---|
| DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'absolutePath' (lines '351'-'353'). | 351–353 |
| DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'absolutePath' (lines '351'-'355'). | 351–355 |
Files
org/apache/fulcrum/upload/DefaultUploadService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 67–407 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 68–407 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 70 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 72 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 73 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 75 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 76 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 81 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 105 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 127 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 143 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 143 |
| MethodArgumentCouldBeFinal | Parameter 'sizeThreshold' is not assigned and could be declared final | 3 | 162 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 162 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 162 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 3 | 162 |
| MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 180 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 3 | 180 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 180 |
| LocalVariableCouldBeFinal | Local variable 'fileUpload' could be declared final | 3 | 183 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 207 |
| LocalVariableCouldBeFinal | Local variable 'upload' could be declared final | 3 | 208 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileUploadException' branch | 3 | 213–215 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 229 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 245 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 245 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 3 | 263 |
| MethodArgumentCouldBeFinal | Parameter 'sizeThreshold' is not assigned and could be declared final | 3 | 263 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 263 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 263 |
| MethodArgumentCouldBeFinal | Parameter 'sizeMax' is not assigned and could be declared final | 3 | 281 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 281 |
| MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 281 |
| LocalVariableCouldBeFinal | Local variable 'fileUpload' could be declared final | 3 | 284 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 308 |
| LocalVariableCouldBeFinal | Local variable 'upload' could be declared final | 3 | 309 |
| IdenticalCatchBranches | 'catch' branch identical to 'FileUploadException' branch | 3 | 314–316 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 329 |
| MethodArgumentCouldBeFinal | Parameter 'req' is not assigned and could be declared final | 3 | 343 |
| MethodArgumentCouldBeFinal | Parameter 'path' is not assigned and could be declared final | 3 | 350 |
| DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'absolutePath' (lines '351'-'353'). | 5 | 351–353 |
| UnusedAssignment | The initializer for variable 'absolutePath' is never used (overwritten on lines 353 and 355) | 3 | 351 |
| DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'absolutePath' (lines '351'-'355'). | 5 | 351–355 |
| MethodArgumentCouldBeFinal | Parameter 'conf' is not assigned and could be declared final | 3 | 366 |
| LocalVariableCouldBeFinal | Local variable 'testPath' could be declared final | 3 | 389 |
| LocalVariableCouldBeFinal | Local variable 'testDir' could be declared final | 3 | 390 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 395 |
| MethodArgumentCouldBeFinal | Parameter 'context' is not assigned and could be declared final | 3 | 404 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 405 |
org/apache/fulcrum/upload/UploadService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like CONTENT_DISPOSITION | 3 | 56 |
| LongVariable | Avoid excessively long variable names like MULTIPART_FORM_DATA | 3 | 76 |
| LongVariable | Avoid excessively long variable names like REPOSITORY_PARAMETER | 3 | 86 |
| LongVariable | Avoid excessively long variable names like REPOSITORY_DEFAULT | 3 | 100 |
| UseUnderscoresInNumericLiterals | Number 1048576 should separate every third digit with an underscore | 3 | 116 |
| LongVariable | Avoid excessively long variable names like SIZE_THRESHOLD_KEY | 3 | 122 |
| LongVariable | Avoid excessively long variable names like SIZE_THRESHOLD_DEFAULT | 3 | 130 |
| UseUnderscoresInNumericLiterals | Number 10240 should separate every third digit with an underscore | 3 | 130 |
| LongVariable | Avoid excessively long variable names like HEADER_ENCODING_KEY | 3 | 136 |
| LongVariable | Avoid excessively long variable names like HEADER_ENCODING_DEFAULT | 3 | 143 |