PMD Results
The following document contains the results of PMD 6.29.0.
Violations By Priority
Priority 1
org/apache/fulcrum/testcontainer/BaseUnit4Test.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The public constant name 'defaultLogLevel' doesn't match '[A-Z][A-Z_0-9]*' | 70 |
| VariableNamingConventions | Variables that are final and static should be all capitals, 'defaultLogLevel' is not all capitals. | 70 |
org/apache/fulcrum/testcontainer/BaseUnit5Test.java
| Rule | Violation | Line |
|---|---|---|
| VariableNamingConventions | Variables that are final and static should be all capitals, 'defaultLogLevel' is not all capitals. | 72 |
| FieldNamingConventions | The public constant name 'defaultLogLevel' doesn't match '[A-Z][A-Z_0-9]*' | 72 |
org/apache/fulcrum/testcontainer/BaseUnitTest.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The public constant name 'containerType' doesn't match '[A-Z][A-Z_0-9]*' | 48 |
| VariableNamingConventions | Variables that are final and static should be all capitals, 'containerType' is not all capitals. | 48 |
| VariableNamingConventions | Variables that are final and static should be all capitals, 'defaultLogLevel' is not all capitals. | 51 |
| FieldNamingConventions | The public constant name 'defaultLogLevel' doesn't match '[A-Z][A-Z_0-9]*' | 51 |
org/apache/fulcrum/testcontainer/ECMContainer.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 73 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 84 |
org/apache/fulcrum/testcontainer/YAAFIContainer.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 121 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 133 |
org/apache/fulcrum/testcontainer/avalon/logger/Log4J2Logger.java
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name 'm_logger' doesn't match '[a-z][a-zA-Z0-9]*' | 44 |
Priority 3
org/apache/fulcrum/testcontainer/BaseUnit4Test.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 1–298 |
| DataClass | The class 'BaseUnit4Test' is suspected to be a Data Class (WOC=25.000%, NOPA=6, NOAM=2, WMC=17) | 59–298 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 64 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 73 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 76 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 82 |
| ImmutableField | Private field 'parameterFileName' could be made final; it is only initialized in the declaration or constructor. | 82 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parameterFileName' | 82 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 85 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 88 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 88 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 88 |
| LongVariable | Avoid excessively long variable names like maxInactiveInterval | 91 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 91 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'maxInactiveInterval' | 91 |
| MethodArgumentCouldBeFinal | Parameter 'configurationFileName' is not assigned and could be declared final | 99 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 99 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 110 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 121 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 129–131 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 142 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 183 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 205 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 220 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 221 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 226 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 228 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 236 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 238 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 239 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 245 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 245 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 250 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 258 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 260 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 261 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 266 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 266 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 267 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 267 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 269 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 269 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 270 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 270 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 273 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 273 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 281 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 281 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 282 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 282 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 284 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 284 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 284 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 284 |
| ShortVariable | Avoid variables with short names like v | 284 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 285 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 285 |
| MethodArgumentCouldBeFinal | Parameter 'containerType' is not assigned and could be declared final | 294 |
org/apache/fulcrum/testcontainer/BaseUnit5Test.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 1–309 |
| DataClass | The class 'BaseUnit5Test' is suspected to be a Data Class (WOC=20.000%, NOPA=6, NOAM=3, WMC=18) | 61–309 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 66 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 75 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 78 |
| ImmutableField | Private field 'parameterFileName' could be made final; it is only initialized in the declaration or constructor. | 84 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parameterFileName' | 84 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 84 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 90 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 90 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 90 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'maxInactiveInterval' | 93 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 93 |
| LongVariable | Avoid excessively long variable names like maxInactiveInterval | 93 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 101 |
| MethodArgumentCouldBeFinal | Parameter 'configurationFileName' is not assigned and could be declared final | 101 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 112 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 123 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 136–138 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 150 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 191 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 213 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 228 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 229 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 234 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 235 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 243 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 244 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 245 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 251 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 251 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 256 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 264 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 265 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 266 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 276 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 276 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 280 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 280 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 282 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 282 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 283 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 283 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 284 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 284 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 286 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 286 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 287 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 287 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 289 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 289 |
| ShortVariable | Avoid variables with short names like v | 289 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 289 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 289 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 290 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 290 |
| MethodArgumentCouldBeFinal | Parameter 'containerType' is not assigned and could be declared final | 305 |
org/apache/fulcrum/testcontainer/BaseUnitTest.java
| Rule | Violation | Line |
|---|---|---|
| TestClassWithoutTestCases | This class name ends with Test but contains no test cases | 40–201 |
| DataClass | The class 'BaseUnitTest' is suspected to be a Data Class (WOC=0.000%, NOPA=5, NOAM=0, WMC=15) | 40–201 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 45 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 54 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 57 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 63 |
| ImmutableField | Private field 'parameterFileName' could be made final; it is only initialized in the declaration or constructor. | 63 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parameterFileName' | 63 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 66 |
| MethodArgumentCouldBeFinal | Parameter 'configurationFileName' is not assigned and could be declared final | 74 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 74 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 85 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 96 |
| MethodArgumentCouldBeFinal | Parameter 'testName' is not assigned and could be declared final | 106 |
| MissingOverride | The method 'tearDown()' is missing an @Override annotation. | 114–121 |
| JUnit4TestShouldUseAfterAnnotation | JUnit 4 tests that clean up tests should use the @After annotation, JUnit5 tests should use @AfterEach or @AfterAll | 114–121 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 120 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 161 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 184 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 194 |
org/apache/fulcrum/testcontainer/Container.java
| Rule | Violation | Line |
|---|---|---|
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 34 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 42 |
org/apache/fulcrum/testcontainer/ECMContainer.java
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field 'manager' could be made final; it is only initialized in the declaration or constructor. | 44 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 44 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 46 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
| ImmutableField | Private field 'lm' could be made final; it is only initialized in the declaration or constructor. | 50 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 50 |
| ShortVariable | Avoid variables with short names like lm | 50 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 54–57 |
| MethodArgumentCouldBeFinal | Parameter 'configFileName' is not assigned and could be declared final | 64 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 64 |
| MethodArgumentCouldBeFinal | Parameter 'parametersFileName' is not assigned and could be declared final | 64 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 64 |
| MissingOverride | The method 'startup(String, String, String)' is missing an @Override annotation. | 64–86 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 66 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 67 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 67 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 67 |
| LocalVariableCouldBeFinal | Local variable 'configFile' could be declared final | 70 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 79 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 81 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 83 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 84 |
| MissingOverride | The method 'initialize()' is missing an @Override annotation. | 95–128 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 95 |
| AddEmptyString | Do not add empty strings | 98 |
| LocalVariableCouldBeFinal | Local variable 'roleFile' could be declared final | 98 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 102 |
| LocalVariableCouldBeFinal | Local variable 'builder' could be declared final | 105 |
| LocalVariableCouldBeFinal | Local variable 'sysConfig' could be declared final | 106 |
| LocalVariableCouldBeFinal | Local variable 'roleConfig' could be declared final | 109 |
| LocalVariableCouldBeFinal | Local variable 'roles' could be declared final | 111 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 119 |
| LocalVariableCouldBeFinal | Local variable 'absolutePath' could be declared final | 120 |
| MissingOverride | The method 'dispose()' is missing an @Override annotation. | 132–137 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 134 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 136 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 144 |
| MissingOverride | The method 'lookup(String)' is missing an @Override annotation. | 144–147 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 154 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 159 |
| MissingOverride | The method 'release(Object)' is missing an @Override annotation. | 159–162 |
org/apache/fulcrum/testcontainer/YAAFIContainer.java
| Rule | Violation | Line |
|---|---|---|
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 45 |
| ImmutableField | Private field 'config' could be made final; it is only initialized in the declaration or constructor. | 45 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 52 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 54 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the logger field if you want a default access modifier | 54 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 54 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 59–66 |
| AvoidDuplicateLiterals | The String literal "avalon" appears 4 times in this file; the first occurrence is on line 62 | 62 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 73–96 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 73 |
| MissingOverride | The method 'startup(String, String, String)' is missing an @Override annotation. | 104–135 |
| MethodArgumentCouldBeFinal | Parameter 'configFileName' is not assigned and could be declared final | 105 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 106 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 107 |
| MethodArgumentCouldBeFinal | Parameter 'parametersFileName' is not assigned and could be declared final | 107 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 109 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 110 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 110 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 110 |
| LocalVariableCouldBeFinal | Local variable 'configFile' could be declared final | 117 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 128 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 130 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 132 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 133 |
| MissingOverride | The method 'initialize()' is missing an @Override annotation. | 146–151 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 146 |
| MissingOverride | The method 'dispose()' is missing an @Override annotation. | 156–164 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 158 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 163 |
| MissingOverride | The method 'lookup(String)' is missing an @Override annotation. | 172–183 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 172 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 178 |
| LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 180 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 191 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 201 |
| MissingOverride | The method 'release(Object)' is missing an @Override annotation. | 201–204 |
org/apache/fulcrum/testcontainer/avalon/logger/Log4J2Logger.java
| Rule | Violation | Line |
|---|---|---|
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 44 |
| MissingOverride | The method 'debug(String)' is missing an @Override annotation. | 62–65 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'debug': the method is already in a final class | 62–65 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'debug': the method is already in a final class | 73–76 |
| MissingOverride | The method 'debug(String, Throwable)' is missing an @Override annotation. | 73–76 |
| MissingOverride | The method 'isDebugEnabled()' is missing an @Override annotation. | 83–86 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isDebugEnabled': the method is already in a final class | 83–86 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'info': the method is already in a final class | 93–96 |
| MissingOverride | The method 'info(String)' is missing an @Override annotation. | 93–96 |
| MissingOverride | The method 'info(String, Throwable)' is missing an @Override annotation. | 104–107 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'info': the method is already in a final class | 104–107 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isInfoEnabled': the method is already in a final class | 114–117 |
| MissingOverride | The method 'isInfoEnabled()' is missing an @Override annotation. | 114–117 |
| MissingOverride | The method 'warn(String)' is missing an @Override annotation. | 124–127 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'warn': the method is already in a final class | 124–127 |
| MissingOverride | The method 'warn(String, Throwable)' is missing an @Override annotation. | 135–138 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'warn': the method is already in a final class | 135–138 |
| MissingOverride | The method 'isWarnEnabled()' is missing an @Override annotation. | 145–148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isWarnEnabled': the method is already in a final class | 145–148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'error': the method is already in a final class | 155–158 |
| MissingOverride | The method 'error(String)' is missing an @Override annotation. | 155–158 |
| MissingOverride | The method 'error(String, Throwable)' is missing an @Override annotation. | 166–169 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'error': the method is already in a final class | 166–169 |
| MissingOverride | The method 'isErrorEnabled()' is missing an @Override annotation. | 176–179 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isErrorEnabled': the method is already in a final class | 176–179 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'fatalError': the method is already in a final class | 186–189 |
| MissingOverride | The method 'fatalError(String)' is missing an @Override annotation. | 186–189 |
| MissingOverride | The method 'fatalError(String, Throwable)' is missing an @Override annotation. | 197–200 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'fatalError': the method is already in a final class | 197–200 |
| MissingOverride | The method 'isFatalErrorEnabled()' is missing an @Override annotation. | 207–210 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isFatalErrorEnabled': the method is already in a final class | 207–210 |
| MissingOverride | The method 'getChildLogger(String)' is missing an @Override annotation. | 220–223 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getChildLogger': the method is already in a final class | 220–223 |
Priority 4
org/apache/fulcrum/testcontainer/BaseUnit5Test.java
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'java.util.Objects' | 32 |
| UnusedImports | Avoid unused imports such as 'org.apache.avalon.framework.logger.AbstractLogEnabled' | 39 |
| UnusedImports | Avoid unused imports such as 'org.apache.avalon.framework.logger.Logger' | 41 |
Priority 5
org/apache/fulcrum/testcontainer/BaseUnit4Test.java
| Rule | Violation | Line |
|---|---|---|
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 220–287 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 220–287 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 220–287 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 220–287 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 220–287 |
org/apache/fulcrum/testcontainer/BaseUnit5Test.java
| Rule | Violation | Line |
|---|---|---|
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 228–292 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 228–292 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 228–292 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 228–292 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 228–292 |
org/apache/fulcrum/testcontainer/ECMContainer.java
| Rule | Violation | Line |
|---|---|---|
| DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'useRoles' (lines '97'-'101'). | 97–101 |
Files
org/apache/fulcrum/testcontainer/BaseUnit4Test.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 1–298 |
| DataClass | The class 'BaseUnit4Test' is suspected to be a Data Class (WOC=25.000%, NOPA=6, NOAM=2, WMC=17) | 3 | 59–298 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 3 | 64 |
| FieldNamingConventions | The public constant name 'defaultLogLevel' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 70 |
| VariableNamingConventions | Variables that are final and static should be all capitals, 'defaultLogLevel' is not all capitals. | 1 | 70 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 73 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 3 | 76 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 82 |
| ImmutableField | Private field 'parameterFileName' could be made final; it is only initialized in the declaration or constructor. | 3 | 82 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parameterFileName' | 3 | 82 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 85 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 88 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 88 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 88 |
| LongVariable | Avoid excessively long variable names like maxInactiveInterval | 3 | 91 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 91 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'maxInactiveInterval' | 3 | 91 |
| MethodArgumentCouldBeFinal | Parameter 'configurationFileName' is not assigned and could be declared final | 3 | 99 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 3 | 99 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 3 | 110 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 3 | 121 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 129–131 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 142 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 183 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 205 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 5 | 220–287 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 5 | 220–287 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 5 | 220–287 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 3 | 220 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 5 | 220–287 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '220'-'287'). | 5 | 220–287 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 3 | 221 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 226 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 228 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 236 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 238 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 239 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 245 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 245 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 250 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 258 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 260 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 261 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 266 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 266 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 267 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 267 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 269 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 269 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 270 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 270 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 273 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 273 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 281 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 281 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 282 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 282 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 3 | 284 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 284 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 3 | 284 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 3 | 284 |
| ShortVariable | Avoid variables with short names like v | 3 | 284 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 285 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 285 |
| MethodArgumentCouldBeFinal | Parameter 'containerType' is not assigned and could be declared final | 3 | 294 |
org/apache/fulcrum/testcontainer/BaseUnit5Test.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 1–309 |
| UnusedImports | Avoid unused imports such as 'java.util.Objects' | 4 | 32 |
| UnusedImports | Avoid unused imports such as 'org.apache.avalon.framework.logger.AbstractLogEnabled' | 4 | 39 |
| UnusedImports | Avoid unused imports such as 'org.apache.avalon.framework.logger.Logger' | 4 | 41 |
| DataClass | The class 'BaseUnit5Test' is suspected to be a Data Class (WOC=20.000%, NOPA=6, NOAM=3, WMC=18) | 3 | 61–309 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 3 | 66 |
| VariableNamingConventions | Variables that are final and static should be all capitals, 'defaultLogLevel' is not all capitals. | 1 | 72 |
| FieldNamingConventions | The public constant name 'defaultLogLevel' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 72 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 75 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 3 | 78 |
| ImmutableField | Private field 'parameterFileName' could be made final; it is only initialized in the declaration or constructor. | 3 | 84 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parameterFileName' | 3 | 84 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 84 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 90 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 90 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 90 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'maxInactiveInterval' | 3 | 93 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 93 |
| LongVariable | Avoid excessively long variable names like maxInactiveInterval | 3 | 93 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 3 | 101 |
| MethodArgumentCouldBeFinal | Parameter 'configurationFileName' is not assigned and could be declared final | 3 | 101 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 3 | 112 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 3 | 123 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 136–138 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 150 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 191 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 213 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 5 | 228–292 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 5 | 228–292 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 5 | 228–292 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 5 | 228–292 |
| LocalVariableCouldBeFinal | Local variable 'request' could be declared final | 3 | 228 |
| DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'request' (lines '228'-'292'). | 5 | 228–292 |
| LocalVariableCouldBeFinal | Local variable 'session' could be declared final | 3 | 229 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 234 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 235 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 243 |
| LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 244 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 245 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 251 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 251 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 256 |
| MethodArgumentCouldBeFinal | Parameter 'invocation' is not assigned and could be declared final | 3 | 264 |
| LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 265 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 266 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 271 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 272 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 274 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 275 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 276 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 276 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 277 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 278 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 279 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 280 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 280 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 282 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 282 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 283 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 283 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 284 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 284 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 286 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 286 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 287 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 287 |
| UseArrayListInsteadOfVector | Use ArrayList instead of Vector | 3 | 289 |
| ReplaceVectorWithList | Consider replacing this Vector with the newer java.util.List | 3 | 289 |
| ShortVariable | Avoid variables with short names like v | 3 | 289 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 289 |
| LocalVariableCouldBeFinal | Local variable 'v' could be declared final | 3 | 289 |
| LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 290 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 290 |
| MethodArgumentCouldBeFinal | Parameter 'containerType' is not assigned and could be declared final | 3 | 305 |
org/apache/fulcrum/testcontainer/BaseUnitTest.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TestClassWithoutTestCases | This class name ends with Test but contains no test cases | 3 | 40–201 |
| DataClass | The class 'BaseUnitTest' is suspected to be a Data Class (WOC=0.000%, NOPA=5, NOAM=0, WMC=15) | 3 | 40–201 |
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 3 | 45 |
| FieldNamingConventions | The public constant name 'containerType' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 48 |
| VariableNamingConventions | Variables that are final and static should be all capitals, 'containerType' is not all capitals. | 1 | 48 |
| VariableNamingConventions | Variables that are final and static should be all capitals, 'defaultLogLevel' is not all capitals. | 1 | 51 |
| FieldNamingConventions | The public constant name 'defaultLogLevel' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 51 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 54 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 3 | 57 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 63 |
| ImmutableField | Private field 'parameterFileName' could be made final; it is only initialized in the declaration or constructor. | 3 | 63 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'parameterFileName' | 3 | 63 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 66 |
| MethodArgumentCouldBeFinal | Parameter 'configurationFileName' is not assigned and could be declared final | 3 | 74 |
| LongVariable | Avoid excessively long variable names like configurationFileName | 3 | 74 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 3 | 85 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 3 | 96 |
| MethodArgumentCouldBeFinal | Parameter 'testName' is not assigned and could be declared final | 3 | 106 |
| MissingOverride | The method 'tearDown()' is missing an @Override annotation. | 3 | 114–121 |
| JUnit4TestShouldUseAfterAnnotation | JUnit 4 tests that clean up tests should use the @After annotation, JUnit5 tests should use @AfterEach or @AfterAll | 3 | 114–121 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 120 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 161 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 184 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 194 |
org/apache/fulcrum/testcontainer/Container.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LongVariable | Avoid excessively long variable names like COMPONENT_APP_ROOT | 3 | 34 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 3 | 42 |
org/apache/fulcrum/testcontainer/ECMContainer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field 'manager' could be made final; it is only initialized in the declaration or constructor. | 3 | 44 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 44 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 46 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 48 |
| ImmutableField | Private field 'lm' could be made final; it is only initialized in the declaration or constructor. | 3 | 50 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 50 |
| ShortVariable | Avoid variables with short names like lm | 3 | 50 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 54–57 |
| MethodArgumentCouldBeFinal | Parameter 'configFileName' is not assigned and could be declared final | 3 | 64 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'parametersFileName' is not assigned and could be declared final | 3 | 64 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 3 | 64 |
| MissingOverride | The method 'startup(String, String, String)' is missing an @Override annotation. | 3 | 64–86 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 66 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 67 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 67 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 67 |
| LocalVariableCouldBeFinal | Local variable 'configFile' could be declared final | 3 | 70 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 73 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 79 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 81 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 83 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 84 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 84 |
| MissingOverride | The method 'initialize()' is missing an @Override annotation. | 3 | 95–128 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 95 |
| DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'useRoles' (lines '97'-'101'). | 5 | 97–101 |
| AddEmptyString | Do not add empty strings | 3 | 98 |
| LocalVariableCouldBeFinal | Local variable 'roleFile' could be declared final | 3 | 98 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 102 |
| LocalVariableCouldBeFinal | Local variable 'builder' could be declared final | 3 | 105 |
| LocalVariableCouldBeFinal | Local variable 'sysConfig' could be declared final | 3 | 106 |
| LocalVariableCouldBeFinal | Local variable 'roleConfig' could be declared final | 3 | 109 |
| LocalVariableCouldBeFinal | Local variable 'roles' could be declared final | 3 | 111 |
| LocalVariableCouldBeFinal | Local variable 'context' could be declared final | 3 | 119 |
| LocalVariableCouldBeFinal | Local variable 'absolutePath' could be declared final | 3 | 120 |
| MissingOverride | The method 'dispose()' is missing an @Override annotation. | 3 | 132–137 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 134 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 136 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 144 |
| MissingOverride | The method 'lookup(String)' is missing an @Override annotation. | 3 | 144–147 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 154 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 159 |
| MissingOverride | The method 'release(Object)' is missing an @Override annotation. | 3 | 159–162 |
org/apache/fulcrum/testcontainer/YAAFIContainer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 45 |
| ImmutableField | Private field 'config' could be made final; it is only initialized in the declaration or constructor. | 3 | 45 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 48 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 52 |
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 54 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the logger field if you want a default access modifier | 3 | 54 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 54 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 59–66 |
| AvoidDuplicateLiterals | The String literal "avalon" appears 4 times in this file; the first occurrence is on line 62 | 3 | 62 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 73–96 |
| MethodArgumentCouldBeFinal | Parameter 'logLevel' is not assigned and could be declared final | 3 | 73 |
| MissingOverride | The method 'startup(String, String, String)' is missing an @Override annotation. | 3 | 104–135 |
| MethodArgumentCouldBeFinal | Parameter 'configFileName' is not assigned and could be declared final | 3 | 105 |
| MethodArgumentCouldBeFinal | Parameter 'roleFileName' is not assigned and could be declared final | 3 | 106 |
| LongVariable | Avoid excessively long variable names like parametersFileName | 3 | 107 |
| MethodArgumentCouldBeFinal | Parameter 'parametersFileName' is not assigned and could be declared final | 3 | 107 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 109 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 110 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 110 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 110 |
| LocalVariableCouldBeFinal | Local variable 'configFile' could be declared final | 3 | 117 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 121 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 128 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 130 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 132 |
| AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 133 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 133 |
| MissingOverride | The method 'initialize()' is missing an @Override annotation. | 3 | 146–151 |
| SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 146 |
| MissingOverride | The method 'dispose()' is missing an @Override annotation. | 3 | 156–164 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 158 |
| LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 163 |
| MissingOverride | The method 'lookup(String)' is missing an @Override annotation. | 3 | 172–183 |
| MethodArgumentCouldBeFinal | Parameter 'roleName' is not assigned and could be declared final | 3 | 172 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 178 |
| LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 3 | 180 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 191 |
| MethodArgumentCouldBeFinal | Parameter 'component' is not assigned and could be declared final | 3 | 201 |
| MissingOverride | The method 'release(Object)' is missing an @Override annotation. | 3 | 201–204 |
org/apache/fulcrum/testcontainer/avalon/logger/Log4J2Logger.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 44 |
| FieldNamingConventions | The final field name 'm_logger' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 44 |
| MissingOverride | The method 'debug(String)' is missing an @Override annotation. | 3 | 62–65 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'debug': the method is already in a final class | 3 | 62–65 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'debug': the method is already in a final class | 3 | 73–76 |
| MissingOverride | The method 'debug(String, Throwable)' is missing an @Override annotation. | 3 | 73–76 |
| MissingOverride | The method 'isDebugEnabled()' is missing an @Override annotation. | 3 | 83–86 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isDebugEnabled': the method is already in a final class | 3 | 83–86 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'info': the method is already in a final class | 3 | 93–96 |
| MissingOverride | The method 'info(String)' is missing an @Override annotation. | 3 | 93–96 |
| MissingOverride | The method 'info(String, Throwable)' is missing an @Override annotation. | 3 | 104–107 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'info': the method is already in a final class | 3 | 104–107 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isInfoEnabled': the method is already in a final class | 3 | 114–117 |
| MissingOverride | The method 'isInfoEnabled()' is missing an @Override annotation. | 3 | 114–117 |
| MissingOverride | The method 'warn(String)' is missing an @Override annotation. | 3 | 124–127 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'warn': the method is already in a final class | 3 | 124–127 |
| MissingOverride | The method 'warn(String, Throwable)' is missing an @Override annotation. | 3 | 135–138 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'warn': the method is already in a final class | 3 | 135–138 |
| MissingOverride | The method 'isWarnEnabled()' is missing an @Override annotation. | 3 | 145–148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isWarnEnabled': the method is already in a final class | 3 | 145–148 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'error': the method is already in a final class | 3 | 155–158 |
| MissingOverride | The method 'error(String)' is missing an @Override annotation. | 3 | 155–158 |
| MissingOverride | The method 'error(String, Throwable)' is missing an @Override annotation. | 3 | 166–169 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'error': the method is already in a final class | 3 | 166–169 |
| MissingOverride | The method 'isErrorEnabled()' is missing an @Override annotation. | 3 | 176–179 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isErrorEnabled': the method is already in a final class | 3 | 176–179 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'fatalError': the method is already in a final class | 3 | 186–189 |
| MissingOverride | The method 'fatalError(String)' is missing an @Override annotation. | 3 | 186–189 |
| MissingOverride | The method 'fatalError(String, Throwable)' is missing an @Override annotation. | 3 | 197–200 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'fatalError': the method is already in a final class | 3 | 197–200 |
| MissingOverride | The method 'isFatalErrorEnabled()' is missing an @Override annotation. | 3 | 207–210 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'isFatalErrorEnabled': the method is already in a final class | 3 | 207–210 |
| MissingOverride | The method 'getChildLogger(String)' is missing an @Override annotation. | 3 | 220–223 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'getChildLogger': the method is already in a final class | 3 | 220–223 |