FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 232 |
53 |
0 |
33 |
org.apache.fulcrum.security.torque.basic.TorqueAbstractBasicGroup
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.basic.TorqueAbstractBasicGroup.getUsers(), since all org.apache.fulcrum.security.util.UserSet<org.apache.fulcrum.security.entity.User> are instances of org.apache.fulcrum.security.util.UserSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
87 |
Medium |
org.apache.fulcrum.security.torque.basic.TorqueAbstractBasicUser
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.basic.TorqueAbstractBasicUser.getGroups(), since all org.apache.fulcrum.security.util.GroupSet<org.apache.fulcrum.security.entity.Group> are instances of org.apache.fulcrum.security.util.GroupSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
86 |
Medium |
org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicGroup
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicGroup.getRoles(), since all org.apache.fulcrum.security.util.RoleSet<org.apache.fulcrum.security.entity.Role> are instances of org.apache.fulcrum.security.util.RoleSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
177 |
Medium |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicGroup.getUsers(), since all org.apache.fulcrum.security.util.UserSet<org.apache.fulcrum.security.entity.User> are instances of org.apache.fulcrum.security.util.UserSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
112 |
Medium |
org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicPermission
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicPermission.getRoles(), since all org.apache.fulcrum.security.util.RoleSet<org.apache.fulcrum.security.entity.Role> are instances of org.apache.fulcrum.security.util.RoleSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
85 |
Medium |
org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicRole
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicRole.getGroups(), since all org.apache.fulcrum.security.util.GroupSet<org.apache.fulcrum.security.entity.Group> are instances of org.apache.fulcrum.security.util.GroupSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
121 |
Medium |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicRole.getPermissions(), since all org.apache.fulcrum.security.util.PermissionSet<org.apache.fulcrum.security.entity.Permission> are instances of org.apache.fulcrum.security.util.PermissionSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
147 |
Medium |
org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicUser
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.dynamic.TorqueAbstractDynamicUser.getGroups(), since all org.apache.fulcrum.security.util.GroupSet<org.apache.fulcrum.security.entity.Group> are instances of org.apache.fulcrum.security.util.GroupSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
133 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroup
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroup.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
678 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueBasicUser
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueBasicUser.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
709 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroup
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroup.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
761 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroup
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroup.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
1009 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRole
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRole.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
761 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermission
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermission.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
678 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRole
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRole.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
1009 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermission
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermission.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
761 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUser
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUser.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
1371 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegates
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegates.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
761 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroup
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroup.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
761 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroup
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroup.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
755 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermission
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermission.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
678 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRole
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRole.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
1086 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermission
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermission.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
761 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
910 |
Medium |
| Using .equals to compare two byte[]'s, (equivalent to ==) in org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser.setObjectdata(byte[]) |
CORRECTNESS |
EC_BAD_ARRAY_COMPARE |
283 |
Medium |
| Using .equals to compare two byte[]'s, (equivalent to ==) in org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser.valueEquals(TorqueTurbineUser) |
CORRECTNESS |
EC_BAD_ARRAY_COMPARE |
1224 |
Medium |
| org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser.getObjectdata() may expose internal representation by returning BaseTorqueTurbineUser.objectdata |
MALICIOUS_CODE |
EI_EXPOSE_REP |
273 |
Medium |
| org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser.setObjectdata(byte[]) may expose internal representation by storing an externally mutable object into BaseTorqueTurbineUser.objectdata |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
288 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRole
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRole.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
888 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to offset in org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeerImpl.doSelectJoinAllExceptTorqueTurbineGroup(Criteria, Connection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
910 |
Medium |
| Dead store to offset in org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeerImpl.doSelectJoinAllExceptTorqueTurbineRole(Criteria, Connection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
1014 |
Medium |
| Dead store to offset in org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeerImpl.doSelectJoinAllExceptTorqueTurbineUser(Criteria, Connection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
806 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTurbineGroup
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTurbineGroup.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
755 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTurbinePermission
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTurbinePermission.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
678 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTurbineRole
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTurbineRole.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
1086 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTurbineRolePermission
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTurbineRolePermission.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
761 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTurbineUser
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.fulcrum.security.torque.om.BaseTurbineUser.setPrimaryKey(String) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
910 |
Medium |
| Using .equals to compare two byte[]'s, (equivalent to ==) in org.apache.fulcrum.security.torque.om.BaseTurbineUser.setObjectdata(byte[]) |
CORRECTNESS |
EC_BAD_ARRAY_COMPARE |
283 |
Medium |
| Using .equals to compare two byte[]'s, (equivalent to ==) in org.apache.fulcrum.security.torque.om.BaseTurbineUser.valueEquals(TurbineUser) |
CORRECTNESS |
EC_BAD_ARRAY_COMPARE |
1224 |
Medium |
| org.apache.fulcrum.security.torque.om.BaseTurbineUser.getObjectdata() may expose internal representation by returning BaseTurbineUser.objectdata |
MALICIOUS_CODE |
EI_EXPOSE_REP |
273 |
Medium |
| org.apache.fulcrum.security.torque.om.BaseTurbineUser.setObjectdata(byte[]) may expose internal representation by storing an externally mutable object into BaseTurbineUser.objectdata |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
288 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRole
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of ok, which is known to be non-null in org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRole.hashCode() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
888 |
Medium |
org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to offset in org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeerImpl.doSelectJoinAllExceptTurbineGroup(Criteria, Connection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
910 |
Medium |
| Dead store to offset in org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeerImpl.doSelectJoinAllExceptTurbineRole(Criteria, Connection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
1014 |
Medium |
| Dead store to offset in org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeerImpl.doSelectJoinAllExceptTurbineUser(Criteria, Connection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
806 |
Medium |
org.apache.fulcrum.security.torque.om.TurbineGroup
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.apache.fulcrum.security.torque.om.TurbineGroup shadows the simple name of implemented interface org.apache.fulcrum.security.model.turbine.entity.TurbineGroup |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
14 |
Medium |
org.apache.fulcrum.security.torque.om.TurbinePermission
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.apache.fulcrum.security.torque.om.TurbinePermission shadows the simple name of implemented interface org.apache.fulcrum.security.model.turbine.entity.TurbinePermission |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
14 |
Medium |
org.apache.fulcrum.security.torque.om.TurbineRole
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.apache.fulcrum.security.torque.om.TurbineRole shadows the simple name of implemented interface org.apache.fulcrum.security.model.turbine.entity.TurbineRole |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
14 |
Medium |
org.apache.fulcrum.security.torque.om.TurbineUser
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.apache.fulcrum.security.torque.om.TurbineUser shadows the simple name of implemented interface org.apache.fulcrum.security.model.turbine.entity.TurbineUser |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
14 |
Medium |
org.apache.fulcrum.security.torque.turbine.DefaultAbstractTurbinePermission
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.turbine.DefaultAbstractTurbinePermission.getRoles(), since all org.apache.fulcrum.security.util.RoleSet<org.apache.fulcrum.security.entity.Role> are instances of org.apache.fulcrum.security.util.RoleSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
89 |
Medium |
org.apache.fulcrum.security.torque.turbine.DefaultAbstractTurbineRole
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.turbine.DefaultAbstractTurbineRole.getPermissions(), since all org.apache.fulcrum.security.util.PermissionSet<org.apache.fulcrum.security.entity.Permission> are instances of org.apache.fulcrum.security.util.PermissionSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
113 |
Medium |
org.apache.fulcrum.security.torque.turbine.FulcrumAbstractTurbinePermission
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.turbine.FulcrumAbstractTurbinePermission.getRoles(), since all org.apache.fulcrum.security.util.RoleSet<org.apache.fulcrum.security.entity.Role> are instances of org.apache.fulcrum.security.util.RoleSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
86 |
Medium |
org.apache.fulcrum.security.torque.turbine.FulcrumAbstractTurbineRole
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.fulcrum.security.torque.turbine.FulcrumAbstractTurbineRole.getPermissions(), since all org.apache.fulcrum.security.util.PermissionSet<org.apache.fulcrum.security.entity.Permission> are instances of org.apache.fulcrum.security.util.PermissionSet |
STYLE |
BC_VACUOUS_INSTANCEOF |
112 |
Medium |
