Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.38.0.

Violations By Priority

Priority 1

org/apache/fulcrum/yaafi/cli/Main.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setApplicationName' called during object construction 166168
ConstructorCallsOverridableMethod Overridable method 'getApplicationName' called during object construction 167
ConstructorCallsOverridableMethod Overridable method 'setApplicationHome' called during object construction 170172
ConstructorCallsOverridableMethod Overridable method 'getApplicationHome' called during object construction 171
ConstructorCallsOverridableMethod Overridable method 'setTempHome' called during object construction 174176
ConstructorCallsOverridableMethod Overridable method 'getTempHome' called during object construction 175
ConstructorCallsOverridableMethod Overridable method 'setContainerConfigValue' called during object construction 178180
ConstructorCallsOverridableMethod Overridable method 'getContainerConfigValue' called during object construction 179
ConstructorCallsOverridableMethod Overridable method 'setIsBlocking' called during object construction 182184
ConstructorCallsOverridableMethod Overridable method 'setIsBlocking' called during object construction 182184
ConstructorCallsOverridableMethod Overridable method 'setHasShutdownHook' called during object construction 186188
ConstructorCallsOverridableMethod Overridable method 'setHasShutdownHook' called during object construction 186188
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 262

org/apache/fulcrum/yaafi/framework/component/AvalonServiceComponentImpl.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 195
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 235
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 271
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 426
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 456
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 486
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 516
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 539
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 562
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 589

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolverBaseImpl.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 109

org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 850

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerConfiguration.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 668

org/apache/fulcrum/yaafi/framework/logger/Log4j2Logger.java

Rule Violation Line
FieldNamingConventions The final field name 'm_logger' doesn't match '[a-z][a-zA-Z0-9]*' 34

org/apache/fulcrum/yaafi/framework/reflection/Clazz.java

Rule Violation Line
ClassNamingConventions The utility class name 'Clazz' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 35174

org/apache/fulcrum/yaafi/framework/util/ConfigurationUtil.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 165
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 177

org/apache/fulcrum/yaafi/framework/util/InputStreamLocator.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 96
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 109

org/apache/fulcrum/yaafi/framework/util/ToStringBuilder.java

Rule Violation Line
AvoidUsingShortType Do not use the short type 117

org/apache/fulcrum/yaafi/framework/util/Validate.java

Rule Violation Line
ClassNamingConventions The utility class name 'Validate' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 45609

org/apache/fulcrum/yaafi/interceptor/jamon/JamonInterceptorServiceImpl.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 282

org/apache/fulcrum/yaafi/interceptor/javasimon/JavaSimonInterceptorServiceImpl.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 286

org/apache/fulcrum/yaafi/interceptor/util/StopWatch.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 260

org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java

Rule Violation Line
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 230

Priority 2

org/apache/fulcrum/yaafi/cli/Main.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 79
AvoidUsingVolatile Use of modifier volatile is not recommended. 94

org/apache/fulcrum/yaafi/framework/component/ServiceComponentImpl.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 55
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 58

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolverBaseImpl.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 47

org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 101
AvoidUsingVolatile Use of modifier volatile is not recommended. 128
AvoidUsingVolatile Use of modifier volatile is not recommended. 131

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerConfiguration.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 86

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerFactory.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 40
GuardLogStatement Logger calls should be surrounded by log level guards. 9496
GuardLogStatement Logger calls should be surrounded by log level guards. 102104
GuardLogStatement Logger calls should be surrounded by log level guards. 117120
SystemPrintln System.err.println is used 156

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorContextImpl.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 72

org/apache/fulcrum/yaafi/framework/reflection/Clazz.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'cls' 170

org/apache/fulcrum/yaafi/framework/util/ConfigurationUtil.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 6370
GuardLogStatement Logger calls should be surrounded by log level guards. 8895

org/apache/fulcrum/yaafi/framework/util/InputStreamLocator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 42

org/apache/fulcrum/yaafi/interceptor/performance/PerformanceInterceptorServiceImpl.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'args' 251

org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'object' 242

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationEntry.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 56

org/apache/fulcrum/yaafi/service/shutdown/ShutdownEntry.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 53

Priority 3

org/apache/fulcrum/yaafi/cli/Getopt.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 29
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 32
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 38
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 49
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 49
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 70
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 89
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 101
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 101
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 115
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 115
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 125
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 125
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 127
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 128
MethodArgumentCouldBeFinal Parameter 'index' is not assigned and could be declared final 137
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 148
LocalVariableCouldBeFinal Local variable 'strOption' could be declared final 150
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 158
MethodArgumentCouldBeFinal Parameter 'index' is not assigned and could be declared final 170
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 178185
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 180
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 184
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 199
LocalVariableCouldBeFinal Local variable 'value' could be declared final 201
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 206
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 221
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 221
LocalVariableCouldBeFinal Local variable 'index' could be declared final 223
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 228
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 239

org/apache/fulcrum/yaafi/cli/Main.java

Rule Violation Line
GodClass Possible God Class (WMC=52, ATFD=11, TCC=3.209%) 37640
TooManyMethods This class has too many methods, consider refactoring it. 38640
LongVariable Avoid excessively long variable names like APPLICATION_CONFIG 49
LongVariable Avoid excessively long variable names like APPLICATION_HASSHUTDOWNHOOK 52
LongVariable Avoid excessively long variable names like APPLICATION_ISBLOCKING 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
LongVariable Avoid excessively long variable names like containerConfigValue 67
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
AvoidFieldNameMatchingMethodName Field isBlocking has the same name as a method 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 76
AvoidFieldNameMatchingMethodName Field hasShutdownHook has the same name as a method 76
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 94
AvoidFieldNameMatchingMethodName Field isInitialized has the same name as a method 94
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 156
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 156
LocalVariableCouldBeFinal Local variable 'getopt' could be declared final 164
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 197
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 197
LocalVariableCouldBeFinal Local variable 'impl' could be declared final 201
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 207210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 224
MethodArgumentCouldBeFinal Parameter 'baseDir' is not assigned and could be declared final 224
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 240243
MissingOverride The method 'dispose()' is missing an @Override annotation. 240243
MissingOverride The method 'run()' is missing an @Override annotation. 251264
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 258263
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 260
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 262
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 292
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 305
MethodArgumentCouldBeFinal Parameter 'applicationHome' is not assigned and could be declared final 344
LongVariable Avoid excessively long variable names like containerConfigValue 360
MethodArgumentCouldBeFinal Parameter 'containerConfigValue' is not assigned and could be declared final 360
MethodArgumentCouldBeFinal Parameter 'isBlocking' is not assigned and could be declared final 376
MethodArgumentCouldBeFinal Parameter 'isBlocking' is not assigned and could be declared final 384
MethodArgumentCouldBeFinal Parameter 'isBlocking' is not assigned and could be declared final 392
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 394
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 394
MethodArgumentCouldBeFinal Parameter 'tempHome' is not assigned and could be declared final 408
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 424
MethodArgumentCouldBeFinal Parameter 'applicationName' is not assigned and could be declared final 440
MethodReturnsInternalArray Returning 'args' may expose an internal array. 450
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 455
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 455
MethodArgumentCouldBeFinal Parameter 'hasShutdownHook' is not assigned and could be declared final 471
MethodArgumentCouldBeFinal Parameter 'hasShutdownHook' is not assigned and could be declared final 479
MethodArgumentCouldBeFinal Parameter 'hasShutdownHook' is not assigned and could be declared final 487
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 489
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 489
MissingOverride The method 'toString()' is missing an @Override annotation. 495537
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 123 characters appended. 497
LocalVariableCouldBeFinal Local variable 'result' could be declared final 497
LocalVariableCouldBeFinal Local variable 'argsLine' could be declared final 498
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 500
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 500
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 500
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 502
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 502
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 503
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 503
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 504
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 504
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 514
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 518
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 519
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 519
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 521
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 521
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 522
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 522
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 523
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 523
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 524
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 524
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 525
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 525
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 526
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 526
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 527
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 527
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 528
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 528
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 529
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 529
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 530
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 530
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 531
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 531
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 532
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 532
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 533
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 533
MethodArgumentCouldBeFinal Parameter 'isInitialized' is not assigned and could be declared final 554
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 564
LocalVariableCouldBeFinal Local variable 'config' could be declared final 568
LocalVariableCouldBeFinal Local variable 'shutdown' could be declared final 584
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 585
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 586
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 614
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 628
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 634
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 636

org/apache/fulcrum/yaafi/cli/Shutdown.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 33
MethodArgumentCouldBeFinal Parameter 'disposable' is not assigned and could be declared final 39
MissingOverride The method 'run()' is missing an @Override annotation. 4751
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 50

org/apache/fulcrum/yaafi/framework/component/AvalonServiceComponentImpl.java

Rule Violation Line
CyclomaticComplexity The class 'AvalonServiceComponentImpl' has a total cyclomatic complexity of 89 (highest 9). 54593
TooManyMethods This class has too many methods, consider refactoring it. 56593
MethodArgumentCouldBeFinal Parameter 'roleEntry' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'parentLogger' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 65
MissingOverride The method 'incarnateInstance()' is missing an @Override annotation. 77140
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 77
LocalVariableCouldBeFinal Local variable 'isInterceptor' could be declared final 115117
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 119
LocalVariableCouldBeFinal Local variable 'proxyInstance' could be declared final 126132
MissingOverride The method 'reconfigure()' is missing an @Override annotation. 145198
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 145
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 155160
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 157
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 169174
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 171
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 180185
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 182
MissingOverride The method 'decommision()' is missing an @Override annotation. 204246
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 204
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 212216
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 214
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 220
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 231
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 233
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 235
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 239243
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 241
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 256
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 258
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 267272
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 269
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 271
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 281
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 283
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 294
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 298303
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 300
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 312
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 314
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 325
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 329334
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 331
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 344
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 346
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 357
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 361366
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 363
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 375
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 377
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 388
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 392397
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 394
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 405
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 407
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 416
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 418
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 422427
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 424
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 426
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 435
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 437
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 446
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 448
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 452457
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 454
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 456
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 465
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 467
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 476
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 478
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 482487
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 484
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 486
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 495
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 497
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 506
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 508
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 512517
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 514
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 516
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 526
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 535540
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 537
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 539
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 549
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 558563
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 560
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 562
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 572
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 576
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 585590
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 587
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 589

org/apache/fulcrum/yaafi/framework/component/ServiceComponentImpl.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 39401
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
LongVariable Avoid excessively long variable names like implementationClazz 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
MethodArgumentCouldBeFinal Parameter 'roleEntry' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'parentLogger' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 98
MissingOverride The method 'loadImplemtationClass(ClassLoader)' is missing an @Override annotation. 98128
UnusedAssignment The initializer for variable 'currClassLoader' is never used (overwritten on lines 105 and 109) 101
ConfusingTernary Avoid if (x != y) ..; else ..; 103110
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 109
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 121122
MissingOverride The method 'getInstance()' is missing an @Override annotation. 133143
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 134
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 136
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 148
MissingOverride The method 'incarnate()' is missing an @Override annotation. 148164
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 157163
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 159160
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 169
MissingOverride The method 'reconfigure()' is missing an @Override annotation. 169
MissingOverride The method 'decommision()' is missing an @Override annotation. 174178
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 174
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 176
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 177
MissingOverride The method 'dispose()' is missing an @Override annotation. 183195
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 185
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 186
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 187
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 188
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 189
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 190
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 191
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 192
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 193
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 194
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 200
MissingOverride The method 'setLogger(Logger)' is missing an @Override annotation. 200203
MissingOverride The method 'setContext(Context)' is missing an @Override annotation. 208211
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 208
MissingOverride The method 'setServiceManager(ServiceManager)' is missing an @Override annotation. 216219
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 216
MissingOverride The method 'setConfiguration(Configuration)' is missing an @Override annotation. 224227
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 224
MissingOverride The method 'setParameters(Parameters)' is missing an @Override annotation. 232235
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 232
MissingOverride The method 'getName()' is missing an @Override annotation. 252255
MissingOverride The method 'getRoleEntry()' is missing an @Override annotation. 260263
MissingOverride The method 'getShorthand()' is missing an @Override annotation. 324327
MissingOverride The method 'toString()' is missing an @Override annotation. 336343
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 338
ConfusingTernary Avoid if (x != y) ..; else ..; 350
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 369
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 377
MethodArgumentCouldBeFinal Parameter 'useProxy' is not assigned and could be declared final 386
ControlStatementBraces This statement should have braces 389
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 389
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 389
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 391
ControlStatementBraces This statement should have braces 391
MethodArgumentCouldBeFinal Parameter 'proxy' is not assigned and could be declared final 397

org/apache/fulcrum/yaafi/framework/component/ServiceComponentLifecycle.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 49
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 55
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 61
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 72

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolver.java

Rule Violation Line
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_PROPERTIES_VALUE 35
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 44

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolverBaseImpl.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 43203
AtLeastOneConstructor Each class should declare at least one constructor 43203
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
MissingOverride The method 'enableLogging(Logger)' is missing an @Override annotation. 5962
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 68
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 6871
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 77
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 7780
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 107
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 126
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 135
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 137
MethodArgumentCouldBeFinal Parameter 'properties' is not assigned and could be declared final 146
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 176
MethodArgumentCouldBeFinal Parameter 'fileLocation' is not assigned and could be declared final 176
LocalVariableCouldBeFinal Local variable 'result' could be declared final 178
ShortVariable Avoid variables with short names like is 179
CloseResource Ensure that resources like this InputStream object are closed after use 179
ConfusingTernary Avoid if (x != y) ..; else ..; 183192
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 187
UnusedAssignment The value assigned to variable 'is' is never used 187
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 196
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 198

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolverImpl.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3556
MethodArgumentCouldBeFinal Parameter 'defaults' is not assigned and could be declared final 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 41
MissingOverride The method 'resolve(Properties)' is missing an @Override annotation. 4155
LocalVariableCouldBeFinal Local variable 'location' could be declared final 43
LocalVariableCouldBeFinal Local variable 'result' could be declared final 44
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 51

org/apache/fulcrum/yaafi/framework/constant/AvalonFortressConstants.java

Rule Violation Line
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_FORTESS 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 38
LongVariable Avoid excessively long variable names like FORTRESS_COMPONENT_ID 38
LongVariable Avoid excessively long variable names like FORTRESS_COMPONENT_LOGGER 41
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 41
LongVariable Avoid excessively long variable names like FORTRESS_CONTEXT_ROOT 44
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 44
LongVariable Avoid excessively long variable names like FORTRESS_IMPL_WORKDIR 47
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 47

org/apache/fulcrum/yaafi/framework/constant/AvalonMerlinConstants.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 31
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_MERLIN 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 38
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 41
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 44
LongVariable Avoid excessively long variable names like URN_AVALON_PARTITION 47
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 47
LongVariable Avoid excessively long variable names like URN_AVALON_CLASSLOADER 50
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 50

org/apache/fulcrum/yaafi/framework/constant/AvalonPhoenixConstants.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 31
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_PHOENIX 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 38
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 41
LongVariable Avoid excessively long variable names like PHOENIX_BLOCK_NAME 41
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 44

org/apache/fulcrum/yaafi/framework/constant/AvalonYaafiConstants.java

Rule Violation Line
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_YAAFI 32
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 32
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 39
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 42
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 45
LongVariable Avoid excessively long variable names like URN_AVALON_PARTITION 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 51
LongVariable Avoid excessively long variable names like URN_AVALON_CLASSLOADER 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 58
LongVariable Avoid excessively long variable names like COMPONENT_APP_ROOT 58

org/apache/fulcrum/yaafi/framework/container/ServiceConstants.java

Rule Violation Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 33
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 36
LongVariable Avoid excessively long variable names like CONTAINERFLAVOUR_CONFIG_KEY 43
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 43
LongVariable Avoid excessively long variable names like CONTAINERCLAZZNAME_CONFIG_KEY 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 49
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_KEY 49
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 52
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_PROPERTIES_KEY 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 55
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_KEYS 55
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY 58
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 58
LongVariable Avoid excessively long variable names like COMPONENT_ISENCRYPTED_KEY 61
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 61
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 64
LongVariable Avoid excessively long variable names like COMPONENT_LOCATION_KEY 64
LongVariable Avoid excessively long variable names like DYNAMICPROXY_ENABLED_KEY 67
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 67
LongVariable Avoid excessively long variable names like INTERCEPTOR_LIST_KEY 70
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 70
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 73
LongVariable Avoid excessively long variable names like RECONFIGURATION_DELAY_KEY 76
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 76
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 79
LongVariable Avoid excessively long variable names like DISPOSAL_DELAY_KEY 79
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 82
LongVariable Avoid excessively long variable names like SERVICEMANAGER_LIST_KEY 82
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 85
LongVariable Avoid excessively long variable names like SERVICEMANAGER_KEY 85
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_VALUE 92
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 92
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 95
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_VALUE 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 98
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE 98
LongVariable Avoid excessively long variable names like COMPONENT_CONTAINERFLAVOUR_VALUE 101
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 101
LongVariable Avoid excessively long variable names like COMPONENT_ROLECONFIGFLAVOUR_VALUE 104
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 104

org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 11413
StdCyclomaticComplexity The class 'ServiceContainerImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 661413
GodClass Possible God Class (WMC=152, ATFD=87, TCC=0.950%) 661413
TooManyFields Too many fields 661413
TooManyMethods This class has too many methods, consider refactoring it. 661413
ExcessiveClassLength Avoid really long classes. 661413
CyclomaticComplexity The class 'ServiceContainerImpl' has a total cyclomatic complexity of 152 (highest 17). 661413
ModifiedCyclomaticComplexity The class 'ServiceContainerImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 661413
LongVariable Avoid excessively long variable names like DISPOSAL_DELAY_DEFAULT 68
LongVariable Avoid excessively long variable names like RECONFIGURATION_DELAY_DEFAULT 71
LongVariable Avoid excessively long variable names like componentRolesLocation 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 74
AvoidFieldNameMatchingMethodName Field isComponentRolesEncrypted has the same name as a method 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 77
LinguisticNaming Linguistics Antipattern - The field 'isComponentRolesEncrypted' indicates linguistically it is a boolean, but it is 'String' 77
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 77
LongVariable Avoid excessively long variable names like componentRolesFlavour 80
LongVariable Avoid excessively long variable names like componentConfigurationLocation 83
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 83
LinguisticNaming Linguistics Antipattern - The field 'isComponentConfigurationEncrypted' indicates linguistically it is a boolean, but it is 'String' 86
AvoidFieldNameMatchingMethodName Field isComponentConfigurationEncrypted has the same name as a method 86
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 86
LongVariable Avoid excessively long variable names like parametersLocation 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 89
AvoidFieldNameMatchingMethodName Field isParametersEncrypted has the same name as a method 92
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 92
LongVariable Avoid excessively long variable names like isParametersEncrypted 92
LinguisticNaming Linguistics Antipattern - The field 'isParametersEncrypted' indicates linguistically it is a boolean, but it is 'String' 92
LongVariable Avoid excessively long variable names like applicationRootDir 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 101
LongVariable Avoid excessively long variable names like parentServiceManager 104
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 104
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 110
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 110
ImmutableField Private field 'serviceMap' could be made final; it is only initialized in the declaration or constructor. 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 113
LongVariable Avoid excessively long variable names like serviceConfiguration 116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 119
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 122
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 125
AvoidFieldNameMatchingMethodName Field isAlreadyDisposed has the same name as a method 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 128
AvoidFieldNameMatchingMethodName Field isCurrentlyDisposing has the same name as a method 131
LongVariable Avoid excessively long variable names like isCurrentlyDisposing 131
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 131
LongVariable Avoid excessively long variable names like reconfigurationDelay 140
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 140
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 143
AvoidFieldNameMatchingMethodName Field hasDynamicProxies has the same name as a method 146
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 146
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 149
LongVariable Avoid excessively long variable names like defaultInterceptorServiceList 149
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 149
LongVariable Avoid excessively long variable names like fallbackServiceManagerList 152
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 152
LongVariable Avoid excessively long variable names like componentConfigurationPropertiesResolverConfig 157
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 157
AvoidDuplicateLiterals The String literal "false" appears 6 times in this file; the first occurrence is on line 176 176
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 183
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 184
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 189
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 190
MissingOverride The method 'enableLogging(Logger)' is missing an @Override annotation. 199202
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 199
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 207211
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 207
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 216
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 216218
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 223336
ExcessiveMethodLength Avoid really long methods. 223336
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 228229
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 233
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 237
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 242
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 252253
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 253
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 261
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 263
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 265
LongVariable Avoid excessively long variable names like currComponentRoles 270
LocalVariableCouldBeFinal Local variable 'currComponentRoles' could be declared final 270
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 273
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 273
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 278
LongVariable Avoid excessively long variable names like currComponentConfiguration 282
LocalVariableCouldBeFinal Local variable 'currComponentConfiguration' could be declared final 282
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 285
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 285
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 288
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 288
LocalVariableCouldBeFinal Local variable 'currParameters' could be declared final 296
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 299
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 299
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 301
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 301
LongVariable Avoid excessively long variable names like currInterceptorList 305
LocalVariableCouldBeFinal Local variable 'currInterceptorList' could be declared final 305
LocalVariableCouldBeFinal Local variable 'interceptorConfigList' could be declared final 307
LongVariable Avoid excessively long variable names like interceptorConfigList 307
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 307
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 309317
LocalVariableCouldBeFinal Local variable 'interceptorServiceName' could be declared final 310
LongVariable Avoid excessively long variable names like interceptorServiceName 310
LocalVariableCouldBeFinal Local variable 'currServiceManagerList' could be declared final 323
LongVariable Avoid excessively long variable names like currServiceManagerList 323
LongVariable Avoid excessively long variable names like serviceManagerConfigList 325
LocalVariableCouldBeFinal Local variable 'serviceManagerConfigList' could be declared final 325
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 325
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 327335
LocalVariableCouldBeFinal Local variable 'serviceManagerName' could be declared final 328
LongVariable Avoid excessively long variable names like serviceManagerName 328
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 341
MissingOverride The method 'parameterize(Parameters)' is missing an @Override annotation. 341343
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 348
MissingOverride The method 'initialize()' is missing an @Override annotation. 348417
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 362
LongVariable Avoid excessively long variable names like componentConfigurationProperties 372
LocalVariableCouldBeFinal Local variable 'componentConfigurationProperties' could be declared final 372
LocalVariableCouldBeFinal Local variable 'currServiceList' could be declared final 387
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 394
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 395
LongVariable Avoid excessively long variable names like currServiceManagerName 401
LocalVariableCouldBeFinal Local variable 'currServiceManagerName' could be declared final 401
UnnecessaryCast Avoid unnecessary casts 401
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 403
MissingOverride The method 'dispose()' is missing an @Override annotation. 424469
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 453
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 454
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 455
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 456
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 457
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 458
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 459
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 460
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 461
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 478
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 478524
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 478524
LongVariable Avoid excessively long variable names like componentConfigurationProperties 494
LocalVariableCouldBeFinal Local variable 'componentConfigurationProperties' could be declared final 494
LocalVariableCouldBeFinal Local variable 'serviceComponentConfiguration' could be declared final 504505
LongVariable Avoid excessively long variable names like serviceComponentConfiguration 504
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 510514
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 511
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 520
MissingOverride The method 'getRoleEntry(String)' is missing an @Override annotation. 533535
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 533535
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 533
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 540551
MissingOverride The method 'getRoleEntries()' is missing an @Override annotation. 540551
LocalVariableCouldBeFinal Local variable 'serviceList' could be declared final 542
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 543
UnnecessaryCast Avoid unnecessary casts 546
MethodArgumentCouldBeFinal Parameter 'names' is not assigned and could be declared final 556
MissingOverride The method 'reconfigure(String)' is missing an @Override annotation. 556570
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 556570
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 562569
MissingOverride The method 'hasService(String)' is missing an @Override annotation. 575598
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 575
AvoidDuplicateLiterals The String literal "name" appears 7 times in this file; the first occurrence is on line 576 576
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 578
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 581
IfStmtsMustUseBraces Avoid using if statements without curly braces 589590
ControlStatementBraces This statement should have braces 590
IfStmtsMustUseBraces Avoid using if statements without curly braces 594595
ControlStatementBraces This statement should have braces 595
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 610
ModifiedCyclomaticComplexity The method 'lookup' has a Modified Cyclomatic Complexity of 10. 610670
CyclomaticComplexity The method 'lookup(String)' has a cyclomatic complexity of 17. 610670
NPathComplexity The method 'lookup(String)' has an NPath complexity of 200, current threshold is 200 610670
StdCyclomaticComplexity The method 'lookup' has a Standard Cyclomatic Complexity of 10. 610670
MissingOverride The method 'lookup(String)' is missing an @Override annotation. 610670
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 613
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 614
LongVariable Avoid excessively long variable names like serviceManagerComponent 614
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 617
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 631
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 642
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 645649
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 646
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 656
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 664
MissingOverride The method 'release(Object)' is missing an @Override annotation. 675678
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 675
MissingOverride The method 'decommission(String)' is missing an @Override annotation. 683687
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 683687
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 683
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 685
MissingOverride The method 'getParameters()' is missing an @Override annotation. 692694
MissingOverride The method 'toString()' is missing an @Override annotation. 703719
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 704
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 737
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 739
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 746
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 749753
IdenticalCatchBranches 'catch' branch identical to 'ConfigurationException' branch 749753
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 750
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 763
LocalVariableCouldBeFinal Local variable 'result' could be declared final 765
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 768
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 782
LocalVariableCouldBeFinal Local variable 'result' could be declared final 784
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 785
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 795
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 795
LongVariable Avoid excessively long variable names like serviceManagerComponent 800
LocalVariableCouldBeFinal Local variable 'serviceManagerComponentName' could be declared final 803
UnnecessaryCast Avoid unnecessary casts 803
LongVariable Avoid excessively long variable names like serviceManagerComponentName 803
LocalVariableCouldBeFinal Local variable 'currServiceManager' could be declared final 807
LongVariable Avoid excessively long variable names like currServiceManager 807
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 809
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 810
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 812816
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 813814
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 830
LongVariable Avoid excessively long variable names like serviceManagerComponent 833
UnnecessaryCast Avoid unnecessary casts 836
LocalVariableCouldBeFinal Local variable 'serviceManagerComponentName' could be declared final 836
LongVariable Avoid excessively long variable names like serviceManagerComponentName 836
LongVariable Avoid excessively long variable names like currServiceManager 840
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 844
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 845
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 847
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 848
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 850
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 861
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 868
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 875
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 889
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 899
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 899
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 925
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 925
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 930931
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 931
LocalVariableCouldBeFinal Local variable 'roleEntry' could be declared final 933
LocalVariableCouldBeFinal Local variable 'componentFlavour' could be declared final 934
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 934
LongVariable Avoid excessively long variable names like serviceComponentContext 936
LocalVariableCouldBeFinal Local variable 'serviceComponentContext' could be declared final 936
LongVariable Avoid excessively long variable names like serviceComponentLogger 940
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 940
LocalVariableCouldBeFinal Local variable 'serviceComponentLogger' could be declared final 940
LongVariable Avoid excessively long variable names like serviceComponentConfiguration 942
LocalVariableCouldBeFinal Local variable 'serviceComponentConfiguration' could be declared final 942
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 942
LocalVariableCouldBeFinal Local variable 'serviceComponentParameters' could be declared final 944
LongVariable Avoid excessively long variable names like serviceComponentParameters 944
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 956
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 966
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 966
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 977
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 979
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 993
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 9981001
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 999
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 1009
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 1011
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 1021
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 10261029
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 1027
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 1050
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 1063
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 1063
LocalVariableCouldBeFinal Local variable 'result' could be declared final 1068
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 1068
LocalVariableCouldBeFinal Local variable 'roleConfigurationParser' could be declared final 1073
LongVariable Avoid excessively long variable names like roleConfigurationParser 1073
LocalVariableCouldBeFinal Local variable 'roleEntryList' could be declared final 1077
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1077
LongVariable Avoid excessively long variable names like defaultInterceptorList 1081
LocalVariableCouldBeFinal Local variable 'defaultInterceptorList' could be declared final 1081
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 10851106
LocalVariableCouldBeFinal Local variable 'roleEntry' could be declared final 1089
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1092
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1094
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 1097
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 11001105
ConfusingTernary Avoid if (x != y) ..; else ..; 1101
LongVariable Avoid excessively long variable names like serviceComponentName 1101
LocalVariableCouldBeFinal Local variable 'serviceComponentName' could be declared final 1101
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 1102
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 1119
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 1119
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 1119
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 1121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1122
CloseResource Ensure that resources like this InputStream object are closed after use 1122
ShortVariable Avoid variables with short names like is 1122
LocalVariableCouldBeFinal Local variable 'builder' could be declared final 1123
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1129
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 1130
LocalVariableCouldBeFinal Local variable 'className' could be declared final 11521153
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 1156
LocalVariableCouldBeFinal Local variable 'resolverClass' could be declared final 1156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1157
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1165
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 1166
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 1182
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 1182
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 1182
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 1183
ShortVariable Avoid variables with short names like is 1184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1184
CloseResource Ensure that resources like this InputStream object are closed after use 1184
LocalVariableCouldBeFinal Local variable 'props' could be declared final 1190
MethodArgumentCouldBeFinal Parameter 'dir' is not assigned and could be declared final 1216
MethodArgumentCouldBeFinal Parameter 'dir' is not assigned and could be declared final 1251
LinguisticNaming Linguistics Antipattern - The method 'isComponentConfigurationEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 12711273
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 1280
MethodArgumentCouldBeFinal Parameter 'isComponentConfigurationEncrypted' is not assigned and could be declared final 1280
LinguisticNaming Linguistics Antipattern - The method 'isComponentRolesEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 12871289
MethodArgumentCouldBeFinal Parameter 'isComponentRolesEncrypted' is not assigned and could be declared final 1294
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 1294
LinguisticNaming Linguistics Antipattern - The method 'isParametersEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 13011303
LongVariable Avoid excessively long variable names like isParametersEncrypted 1308
MethodArgumentCouldBeFinal Parameter 'isParametersEncrypted' is not assigned and could be declared final 1308
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 1320
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 1320
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 1320
ShortVariable Avoid variables with short names like is 1320
MethodArgumentCouldBeFinal Parameter 'containerFlavour' is not assigned and could be declared final 1334
MethodArgumentCouldBeFinal Parameter 'componentRolesFlavour' is not assigned and could be declared final 1348
LongVariable Avoid excessively long variable names like componentRolesFlavour 1348
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 1369
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 1377
ShortVariable Avoid variables with short names like is 1404
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 1404
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1408
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1409

org/apache/fulcrum/yaafi/framework/context/AvalonToYaafiContextMapper.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 43
ImmutableField Private field 'tempRootDir' could be made final; it is only initialized in the declaration or constructor. 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
ImmutableField Private field 'defaultContext' could be made final; it is only initialized in the declaration or constructor. 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
ImmutableField Private field 'classLoader' could be made final; it is only initialized in the declaration or constructor. 49
MethodArgumentCouldBeFinal Parameter 'tempRootDir' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 61
MethodArgumentCouldBeFinal Parameter 'from' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 90
LawOfDemeter Potential violation of Law of Demeter (static property access) 96
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 98
LawOfDemeter Potential violation of Law of Demeter (static property access) 101
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 103
LawOfDemeter Potential violation of Law of Demeter (static property access) 106
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 108
LawOfDemeter Potential violation of Law of Demeter (static property access) 110
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 116
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 128
LocalVariableCouldBeFinal Local variable 'result' could be declared final 131
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 133
LongVariable Avoid excessively long variable names like urnAvalonPartition 134
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 134
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 135
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 136
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 140
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 142
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 143
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 144
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 144
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 153
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 155
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 167
LocalVariableCouldBeFinal Local variable 'result' could be declared final 170
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 172
LongVariable Avoid excessively long variable names like urnAvalonPartition 172
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 173
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 174
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 180
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 181
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 182
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 182
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 186
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 186
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 199
LocalVariableCouldBeFinal Local variable 'result' could be declared final 202
LongVariable Avoid excessively long variable names like urnAvalonPartition 204
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 204
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 205
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 206
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 207
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 211
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 212
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 213
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 214
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 218
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 218

org/apache/fulcrum/yaafi/framework/context/YaafiToAvalonContextMapper.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
ImmutableField Private field 'urnAvalonName' could be made final; it is only initialized in the declaration or constructor. 42
ImmutableField Private field 'urnAvalonClassLoader' could be made final; it is only initialized in the declaration or constructor. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
LongVariable Avoid excessively long variable names like urnAvalonClassLoader 45
MethodArgumentCouldBeFinal Parameter 'urnAvalonClassLoader' is not assigned and could be declared final 53
LongVariable Avoid excessively long variable names like urnAvalonClassLoader 53
MethodArgumentCouldBeFinal Parameter 'urnAvalonName' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'to' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 86
ShortVariable Avoid variables with short names like to 86
LawOfDemeter Potential violation of Law of Demeter (static property access) 92
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 94
LawOfDemeter Potential violation of Law of Demeter (static property access) 97
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 99
LawOfDemeter Potential violation of Law of Demeter (static property access) 102
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 104
LawOfDemeter Potential violation of Law of Demeter (static property access) 106
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 112
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 124
LocalVariableCouldBeFinal Local variable 'result' could be declared final 127
LongVariable Avoid excessively long variable names like urnAvalonPartition 129
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 129
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 130
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 131
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 133
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 135
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 147
LocalVariableCouldBeFinal Local variable 'result' could be declared final 150
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 152
LongVariable Avoid excessively long variable names like urnAvalonPartition 152
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 153
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 154
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 155
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 157
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 159
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 160
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 173
LocalVariableCouldBeFinal Local variable 'result' could be declared final 176
LongVariable Avoid excessively long variable names like urnAvalonPartition 178
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 178
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 179
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 180
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 181
LocalVariableCouldBeFinal Local variable 'urnAvalonClossLoader' could be declared final 182
LongVariable Avoid excessively long variable names like urnAvalonClossLoader 182
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 186
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 187
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 188
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 200
LocalVariableCouldBeFinal Local variable 'result' could be declared final 203
LongVariable Avoid excessively long variable names like urnAvalonPartition 205
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 205
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 206
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 207
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 208
LongVariable Avoid excessively long variable names like urnAvalonClossLoader 209
LocalVariableCouldBeFinal Local variable 'urnAvalonClossLoader' could be declared final 209
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 211
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 212
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 213
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 214
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 215
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 216
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 224

org/apache/fulcrum/yaafi/framework/crypto/CryptoStreamFactory.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 35125
AvoidFieldNameMatchingTypeName It is somewhat confusing to have a field name matching the declaring class name 40
LongVariable Avoid excessively long variable names like cryptoStreamFactory 40
ShortVariable Avoid variables with short names like is 53
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 53
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 53
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 53
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 56
LiteralsFirstInComparisons Position literals first in String comparisons 56
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 59
LiteralsFirstInComparisons Position literals first in String comparisons 59
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 62
LiteralsFirstInComparisons Position literals first in String comparisons 62
LiteralsFirstInComparisons Position literals first in String comparisons 65
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 65
ShortVariable Avoid variables with short names like is 83
MethodArgumentCouldBeFinal Parameter 'factoryMethodName' is not assigned and could be declared final 83
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 83
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 83
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 84
LocalVariableCouldBeFinal Local variable 'args' could be declared final 85
LongVariable Avoid excessively long variable names like cryptoStreamFactory 86
LocalVariableCouldBeFinal Local variable 'cryptoStreamFactory' could be declared final 86
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 102116
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 102
LocalVariableCouldBeFinal Local variable 'clazzLoader' could be declared final 105
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 105
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 108
LocalVariableCouldBeFinal Local variable 'args' could be declared final 109
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 110
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 122

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerConfiguration.java

Rule Violation Line
TooManyFields Too many fields 60674
GodClass Possible God Class (WMC=58, ATFD=55, TCC=3.104%) 60674
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 62
LongVariable Avoid excessively long variable names like serviceContainerClazzName 62
LongVariable Avoid excessively long variable names like componentRolesLocation 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
AvoidFieldNameMatchingMethodName Field isComponentRolesEncrypted has the same name as a method 68
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 68
LinguisticNaming Linguistics Antipattern - The field 'isComponentRolesEncrypted' indicates linguistically it is a boolean, but it is 'String' 68
LongVariable Avoid excessively long variable names like componentConfigurationLocation 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 74
AvoidFieldNameMatchingMethodName Field isComponentConfigurationEncrypted has the same name as a method 74
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 74
LinguisticNaming Linguistics Antipattern - The field 'isComponentConfigurationEncrypted' indicates linguistically it is a boolean, but it is 'String' 74
LongVariable Avoid excessively long variable names like parametersLocation 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 80
LongVariable Avoid excessively long variable names like isParametersEncrypted 80
AvoidFieldNameMatchingMethodName Field isParametersEncrypted has the same name as a method 80
LinguisticNaming Linguistics Antipattern - The field 'isParametersEncrypted' indicates linguistically it is a boolean, but it is 'String' 80
LongVariable Avoid excessively long variable names like applicationRootDir 89
LongVariable Avoid excessively long variable names like componentClassLoader 95
LongVariable Avoid excessively long variable names like containerConfiguration 101
LongVariable Avoid excessively long variable names like parentServiceManager 104
LongVariable Avoid excessively long variable names like serviceManagerList 107
MethodArgumentCouldBeFinal Parameter 'logLevel' is not assigned and could be declared final 119
AvoidDuplicateLiterals The String literal "false" appears 4 times in this file; the first occurrence is on line 124 124
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 132
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 141
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 141
MethodArgumentCouldBeFinal Parameter 'hashtable' is not assigned and could be declared final 152
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 152
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 152
UnusedAssignment The initializer for variable 'name' is never used (overwritten on line 160) 155
UnusedAssignment The initializer for variable 'value' is never used (overwritten on line 161) 156
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 157
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 159
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 182
ExcessiveMethodLength Avoid really long methods. 211341
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 219) 212
ConfusingTernary Avoid if (x != y) ..; else ..; 214340
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 215
LocalVariableCouldBeFinal Local variable 'containerFlavourConfig' could be declared final 225226
LongVariable Avoid excessively long variable names like containerFlavourConfig 225
LocalVariableCouldBeFinal Local variable 'containerClazzNameConfig' could be declared final 236237
LongVariable Avoid excessively long variable names like containerClazzNameConfig 236
LocalVariableCouldBeFinal Local variable 'componentRolesConfig' could be declared final 250
LongVariable Avoid excessively long variable names like componentRolesConfig 250
LocalVariableCouldBeFinal Local variable 'componentRolesLocation' could be declared final 252253
LongVariable Avoid excessively long variable names like componentRolesLocation 252
LongVariable Avoid excessively long variable names like componentRolesIsEncrypted 257
LocalVariableCouldBeFinal Local variable 'componentRolesIsEncrypted' could be declared final 257258
LongVariable Avoid excessively long variable names like componentConfigurationConfig 274
LocalVariableCouldBeFinal Local variable 'componentConfigurationConfig' could be declared final 274275
LongVariable Avoid excessively long variable names like componentConfigurationLocation 277
LocalVariableCouldBeFinal Local variable 'componentConfigurationLocation' could be declared final 277278
LocalVariableCouldBeFinal Local variable 'componentConfigurationIsEncrypted' could be declared final 282283
LongVariable Avoid excessively long variable names like componentConfigurationIsEncrypted 282
LongVariable Avoid excessively long variable names like parameterConfigurationConfig 299
LocalVariableCouldBeFinal Local variable 'parameterConfigurationConfig' could be declared final 299300
LongVariable Avoid excessively long variable names like parameterConfigurationLocation 302
LocalVariableCouldBeFinal Local variable 'parameterConfigurationLocation' could be declared final 302303
LongVariable Avoid excessively long variable names like parameterConfigurationIsEncrypted 307
LocalVariableCouldBeFinal Local variable 'parameterConfigurationIsEncrypted' could be declared final 307308
LongVariable Avoid excessively long variable names like serviceManagerListConfig 324
LocalVariableCouldBeFinal Local variable 'serviceManagerListConfig' could be declared final 324325
LongVariable Avoid excessively long variable names like serviceManagerConfig 328
LocalVariableCouldBeFinal Local variable 'serviceManagerConfig' could be declared final 328329
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 328329
MethodArgumentCouldBeFinal Parameter 'componentConfigurationLocation' is not assigned and could be declared final 365
LongVariable Avoid excessively long variable names like componentConfigurationLocation 365
LongVariable Avoid excessively long variable names like componentRolesLocation 380
MethodArgumentCouldBeFinal Parameter 'componentRolesLocation' is not assigned and could be declared final 380
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 394
LinguisticNaming Linguistics Antipattern - The method 'isComponentConfigurationEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 405407
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 414
MethodArgumentCouldBeFinal Parameter 'isComponentConfigurationEncrypted' is not assigned and could be declared final 414
LinguisticNaming Linguistics Antipattern - The method 'isComponentRolesEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 421423
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 428
MethodArgumentCouldBeFinal Parameter 'isComponentRolesEncrypted' is not assigned and could be declared final 428
LinguisticNaming Linguistics Antipattern - The method 'isParametersEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 435437
LongVariable Avoid excessively long variable names like isParametersEncrypted 442
MethodArgumentCouldBeFinal Parameter 'isParametersEncrypted' is not assigned and could be declared final 442
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 457
MethodArgumentCouldBeFinal Parameter 'parametersLocation' is not assigned and could be declared final 471
LongVariable Avoid excessively long variable names like parametersLocation 471
LongVariable Avoid excessively long variable names like applicationRootDir 485
MethodArgumentCouldBeFinal Parameter 'applicationRootDir' is not assigned and could be declared final 485
PositionLiteralsFirstInComparisons Position literals first in String comparisons 488
LiteralsFirstInComparisons Position literals first in String comparisons 488
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 500
MethodArgumentCouldBeFinal Parameter 'tempRootDir' is not assigned and could be declared final 507
LongVariable Avoid excessively long variable names like componentClassLoader 522
MethodArgumentCouldBeFinal Parameter 'componentClassLoader' is not assigned and could be declared final 522
MethodArgumentCouldBeFinal Parameter 'containerFlavour' is not assigned and could be declared final 537
MethodArgumentCouldBeFinal Parameter 'containerConfiguration' is not assigned and could be declared final 551
LongVariable Avoid excessively long variable names like containerConfiguration 551
LongVariable Avoid excessively long variable names like parentServiceManager 572
MethodArgumentCouldBeFinal Parameter 'parentServiceManager' is not assigned and could be declared final 572
MethodReturnsInternalArray Returning 'serviceManagerList' may expose an internal array. 582
ArrayIsStoredDirectly The user-supplied array 'serviceManagerList' is stored directly. 591
MethodArgumentCouldBeFinal Parameter 'serviceManagerList' is not assigned and could be declared final 591
LongVariable Avoid excessively long variable names like serviceManagerList 591
IfStmtsMustUseBraces Avoid using if statements without curly braces 599600
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 599600
ControlStatementBraces This statement should have braces 600
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 600
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 613
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 627
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 627
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 638) 628
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 630
LocalVariableCouldBeFinal Local variable 'builder' could be declared final 632
CloseResource Ensure that resources like this InputStream object are closed after use 633
ShortVariable Avoid variables with short names like is 633
ConfusingTernary Avoid if (x != y) ..; else ..; 635649
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 640
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 641
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 643
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 646
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 659
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 659
MethodArgumentCouldBeFinal Parameter 'baseDir' is not assigned and could be declared final 659
ConfusingTernary Avoid if (x != y) ..; else ..; 661669

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerFactory.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 38184
MethodArgumentCouldBeFinal Parameter 'serviceManagerConfig' is not assigned and could be declared final 50
LongVariable Avoid excessively long variable names like serviceManagerConfig 50
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 51
LocalVariableCouldBeFinal Local variable 'context' could be declared final 54
MethodArgumentCouldBeFinal Parameter 'serviceManagerConfig' is not assigned and could be declared final 67
LongVariable Avoid excessively long variable names like serviceManagerConfig 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 67
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 68
UnusedAssignment The initializer for variable 'clazz' is never used (overwritten on line 98) 74
UnusedAssignment The initializer for variable 'configuration' is never used (overwritten on line 88) 75
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 106) 76
LawOfDemeter Potential violation of Law of Demeter (static property access) 9496
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98100
LawOfDemeter Potential violation of Law of Demeter (static property access) 102104
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 108
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (static property access) 111
LocalVariableCouldBeFinal Local variable 'serviceContainerLogger' could be declared final 115
LongVariable Avoid excessively long variable names like serviceContainerLogger 115
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 117120
MethodArgumentCouldBeFinal Parameter 'container' is not assigned and could be declared final 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 151
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 153159
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 155
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 157
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 168
LongVariable Avoid excessively long variable names like containerClazzNameConfig 170
LocalVariableCouldBeFinal Local variable 'containerClazzNameConfig' could be declared final 170172
ConfusingTernary Avoid if (x != y) ..; else ..; 174181
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 176

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorContextImpl.java

Rule Violation Line
LongVariable Avoid excessively long variable names like INVOCATIONDEPTH_KEY 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
ImmutableField Private field 'serviceName' could be made final; it is only initialized in the declaration or constructor. 51
ImmutableField Private field 'serviceShorthand' could be made final; it is only initialized in the declaration or constructor. 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
ImmutableField Private field 'serviceDelegate' could be made final; it is only initialized in the declaration or constructor. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 60
ImmutableField Private field 'args' could be made final; it is only initialized in the declaration or constructor. 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 66
ImmutableField Private field 'requestContext' could be made final; it is only initialized in the declaration or constructor. 66
RedundantFieldInitializer Avoid using redundant field initializer for 'invocationCounter' 72
ImmutableField Private field 'invocationId' could be made final; it is only initialized in the declaration or constructor. 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 75
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 87
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 87
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'serviceShorthand' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'serviceDelegate' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 87
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 100
MissingOverride The method 'getRequestContext()' is missing an @Override annotation. 106109
MissingOverride The method 'getServiceDelegate()' is missing an @Override annotation. 114117
MissingOverride The method 'getServiceName()' is missing an @Override annotation. 122125
MissingOverride The method 'getServiceShorthand()' is missing an @Override annotation. 130133
MissingOverride The method 'getArgs()' is missing an @Override annotation. 138141
MethodReturnsInternalArray Returning 'args' may expose an internal array. 140
MissingOverride The method 'getMethod()' is missing an @Override annotation. 146149
MissingOverride The method 'getThreadContext()' is missing an @Override annotation. 154157
MissingOverride The method 'hasTransactionId()' is missing an @Override annotation. 162165
ConfusingTernary Avoid if (x != y) ..; else ..; 164
MissingOverride The method 'getTransactionId()' is missing an @Override annotation. 170173
MethodArgumentCouldBeFinal Parameter 'transactionId' is not assigned and could be declared final 179
MissingOverride The method 'setTransactionId(Object)' is missing an @Override annotation. 179182
MissingOverride The method 'clearTransactionId()' is missing an @Override annotation. 187190
MissingOverride The method 'incrementInvocationDepth()' is missing an @Override annotation. 195208
LocalVariableCouldBeFinal Local variable 'invocationDepth' could be declared final 197
ConfusingTernary Avoid if (x != y) ..; else ..; 199207
LongVariable Avoid excessively long variable names like currInvocationDepth 201
MissingOverride The method 'decrementInvocationDepth()' is missing an @Override annotation. 213222
LocalVariableCouldBeFinal Local variable 'invocationDepth' could be declared final 215
LongVariable Avoid excessively long variable names like currInvocationDepth 219
MissingOverride The method 'getInvocationDepth()' is missing an @Override annotation. 228240
LocalVariableCouldBeFinal Local variable 'invocationDepth' could be declared final 230
ConfusingTernary Avoid if (x != y) ..; else ..; 232239
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 234
MissingOverride The method 'getInvocationId()' is missing an @Override annotation. 245248
MissingOverride The method 'toString()' is missing an @Override annotation. 253268
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 255

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorFactory.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 40127
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'serviceShorthand' is not assigned and could be declared final 54
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 55
LongVariable Avoid excessively long variable names like serviceInterceptorList 56
MethodArgumentCouldBeFinal Parameter 'serviceInterceptorList' is not assigned and could be declared final 56
MethodArgumentCouldBeFinal Parameter 'serviceDelegate' is not assigned and could be declared final 57
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 68
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 69
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 69
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 69
LocalVariableCouldBeFinal Local variable 'interfaceList' could be declared final 70
LongVariable Avoid excessively long variable names like avalonInterceptorServices 74
LocalVariableCouldBeFinal Local variable 'avalonInterceptorServices' could be declared final 7477
LocalVariableCouldBeFinal Local variable 'invocationHandler' could be declared final 7984
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 88
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 88
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 103
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 103
LongVariable Avoid excessively long variable names like interceptorServiceName 106
LocalVariableCouldBeFinal Local variable 'currService' could be declared final 112
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 120

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorInvocationHandler.java

Rule Violation Line
DataClass The class 'AvalonInterceptorInvocationHandler' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=5, WMC=21) 37261
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 40
ImmutableField Private field 'serviceName' could be made final; it is only initialized in the declaration or constructor. 40
ImmutableField Private field 'serviceShorthand' could be made final; it is only initialized in the declaration or constructor. 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
ImmutableField Private field 'serviceDelegate' could be made final; it is only initialized in the declaration or constructor. 46
LongVariable Avoid excessively long variable names like serviceInterceptorList 49
ImmutableField Private field 'serviceInterceptorList' could be made final; it is only initialized in the declaration or constructor. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
LongVariable Avoid excessively long variable names like transactionCounter 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'serviceShorthand' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'serviceDelegate' is not assigned and could be declared final 68
ArrayIsStoredDirectly The user-supplied array 'serviceInterceptorList' is stored directly. 69
MethodArgumentCouldBeFinal Parameter 'serviceInterceptorList' is not assigned and could be declared final 69
LongVariable Avoid excessively long variable names like serviceInterceptorList 69
MethodReturnsInternalArray Returning 'serviceInterceptorList' may expose an internal array. 95
MissingOverride The method 'toString()' is missing an @Override annotation. 125135
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 127
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 140
MethodArgumentCouldBeFinal Parameter 'proxy' is not assigned and could be declared final 140
MissingOverride The method 'invoke(Object, Method, Object)' is missing an @Override annotation. 140190
LocalVariableCouldBeFinal Local variable 'context' could be declared final 147153
LongVariable Avoid excessively long variable names like hasCreatedTransaction 157
LocalVariableCouldBeFinal Local variable 'hasCreatedTransaction' could be declared final 157
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 172176
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 197
LongVariable Avoid excessively long variable names like avalonInterceptorService 201
LocalVariableCouldBeFinal Local variable 'avalonInterceptorService' could be declared final 201
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 202
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 212
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 212
LocalVariableCouldBeFinal Local variable 'avalonInterceptorService' could be declared final 216
LongVariable Avoid excessively long variable names like avalonInterceptorService 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 217
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 227
ShortVariable Avoid variables with short names like t 227
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 227
LocalVariableCouldBeFinal Local variable 'avalonInterceptorService' could be declared final 231
LongVariable Avoid excessively long variable names like avalonInterceptorService 231
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 232
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 241
LongVariable Avoid excessively long variable names like currentTransactionId 243
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 256

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like avalonInterceptorContext 45
LongVariable Avoid excessively long variable names like avalonInterceptorContext 53
ShortVariable Avoid variables with short names like t 61
LongVariable Avoid excessively long variable names like avalonInterceptorContext 61

org/apache/fulcrum/yaafi/framework/logger/Log4j2Logger.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 34

org/apache/fulcrum/yaafi/framework/reflection/Clazz.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 36174
MethodArgumentCouldBeFinal Parameter 'clazzName' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 44
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 49
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'clazzName' is not assigned and could be declared final 64
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 81
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 81
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 86) 84
LocalVariableCouldBeFinal Local variable 'constructor' could be declared final 85
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 86
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 101
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 101
MethodArgumentCouldBeFinal Parameter 'methodName' is not assigned and could be declared final 101
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 101
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 106) 104
LocalVariableCouldBeFinal Local variable 'method' could be declared final 105
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 106
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'methodName' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 122
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 127) 125
LocalVariableCouldBeFinal Local variable 'method' could be declared final 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 127
CognitiveComplexity The method 'getAllInterfaces(Class)' has a cognitive complexity of 15, current threshold is 15 144173
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 148
LocalVariableCouldBeFinal Local variable 'list' could be declared final 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 150
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 153
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 154169
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 156
LocalVariableCouldBeFinal Local variable 'superInterfaces' could be declared final 160
LocalVariableCouldBeFinal Local variable 'it' could be declared final 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 161
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 161168
LocalVariableCouldBeFinal Local variable 'intface' could be declared final 163
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 164

org/apache/fulcrum/yaafi/framework/role/RoleConfigurationParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'parse': the method is declared in an interface type 4041

org/apache/fulcrum/yaafi/framework/role/RoleConfigurationParserImpl.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 39
ImmutableField Private field 'containerFlavour' could be made final; it is only initialized in the declaration or constructor. 39
MethodArgumentCouldBeFinal Parameter 'containerFlavour' is not assigned and could be declared final 46
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 58
MissingOverride The method 'parse(Configuration)' is missing an @Override annotation. 5875
AvoidDuplicateLiterals The String literal "roleConfiguration" appears 4 times in this file; the first occurrence is on line 59 59
LawOfDemeter Potential violation of Law of Demeter (static property access) 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 62
LawOfDemeter Potential violation of Law of Demeter (static property access) 65
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 66
LawOfDemeter Potential violation of Law of Demeter (static property access) 68
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 72
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 84
UnusedAssignment The initializer for variable 'clazzName' is never used (overwritten on line 104) 87
UnusedAssignment The initializer for variable 'name' is never used (overwritten on line 105) 88
UnusedAssignment The initializer for variable 'shorthand' is never used (overwritten on line 106) 89
UnusedAssignment The initializer for variable 'isEarlyInit' is never used (overwritten on line 107) 90
UnusedAssignment The initializer for variable 'description' is never used (overwritten on line 108) 91
UnusedAssignment The initializer for variable 'componentType' is never used (overwritten on line 109) 92
UnusedAssignment The initializer for variable 'componentFlavour' is never used (overwritten on line 110) 93
UnusedAssignment The initializer for variable 'hasProxy' is never used (overwritten on line 111) 94
UnusedAssignment The initializer for variable 'interceptorList' is never used (overwritten on line 116) 95
UnusedAssignment The initializer for variable 'logCategory' is never used (overwritten on line 112) 96
UnusedAssignment The initializer for variable 'roleEntry' is never used (overwritten on line 125) 97
LocalVariableCouldBeFinal Local variable 'list' could be declared final 99
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 103
LocalVariableCouldBeFinal Local variable 'interceptorConfigList' could be declared final 115
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 115
LongVariable Avoid excessively long variable names like interceptorConfigList 115
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 116
LocalVariableCouldBeFinal Local variable 'interceptorConfigEntry' could be declared final 118
LongVariable Avoid excessively long variable names like interceptorConfigEntry 118
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 125126
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 134
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 139

org/apache/fulcrum/yaafi/framework/role/RoleEntry.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setHasDynamicProxy': the method is declared in an interface type 74
UnnecessaryModifier Unnecessary modifier 'public' on method 'addInterceptors': the method is declared in an interface type 81

org/apache/fulcrum/yaafi/framework/role/RoleEntryImpl.java

Rule Violation Line
DataClass The class 'RoleEntryImpl' is suspected to be a Data Class (WOC=26.667%, NOPA=0, NOAM=10, WMC=19) 35241
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 37
ImmutableField Private field 'name' could be made final; it is only initialized in the declaration or constructor. 37
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 40
LongVariable Avoid excessively long variable names like implementationClazzName 40
ImmutableField Private field 'implementationClazzName' could be made final; it is only initialized in the declaration or constructor. 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 43
ImmutableField Private field 'shorthand' could be made final; it is only initialized in the declaration or constructor. 43
AvoidFieldNameMatchingMethodName Field isEarlyInit has the same name as a method 46
ImmutableField Private field 'isEarlyInit' could be made final; it is only initialized in the declaration or constructor. 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 46
ImmutableField Private field 'description' could be made final; it is only initialized in the declaration or constructor. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
ImmutableField Private field 'componentType' could be made final; it is only initialized in the declaration or constructor. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
ImmutableField Private field 'componentFlavour' could be made final; it is only initialized in the declaration or constructor. 57
AvoidFieldNameMatchingMethodName Field hasDynamicProxy has the same name as a method 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 63
ImmutableField Private field 'interceptorList' could be made final; it is only initialized in the declaration or constructor. 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
ImmutableField Private field 'logCategory' could be made final; it is only initialized in the declaration or constructor. 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 66
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'shorthand' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'defaultClass' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'description' is not assigned and could be declared final 85
ExcessiveParameterList Avoid long parameter lists. 8587
MethodArgumentCouldBeFinal Parameter 'earlyInit' is not assigned and could be declared final 85
MethodArgumentCouldBeFinal Parameter 'hasProxy' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'componentType' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 86
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 86
MethodArgumentCouldBeFinal Parameter 'componentFlavour' is not assigned and could be declared final 86
MethodArgumentCouldBeFinal Parameter 'logCategory' is not assigned and could be declared final 87
MissingOverride The method 'getComponentType()' is missing an @Override annotation. 111113
MissingOverride The method 'getDescription()' is missing an @Override annotation. 118120
MissingOverride The method 'getImplementationClazzName()' is missing an @Override annotation. 125127
MissingOverride The method 'isEarlyInit()' is missing an @Override annotation. 132134
MissingOverride The method 'getName()' is missing an @Override annotation. 139141
MissingOverride The method 'getShorthand()' is missing an @Override annotation. 146148
MissingOverride The method 'getComponentFlavour()' is missing an @Override annotation. 153155
MissingOverride The method 'hasDynamicProxy()' is missing an @Override annotation. 160162
MethodArgumentCouldBeFinal Parameter 'hasProxy' is not assigned and could be declared final 167
MissingOverride The method 'setHasDynamicProxy(boolean)' is missing an @Override annotation. 167169
MethodArgumentCouldBeFinal Parameter 'interceptorName' is not assigned and could be declared final 177
UnusedAssignment The initializer for variable 'currInterceptorName' is never used (overwritten on line 182) 178
LongVariable Avoid excessively long variable names like currInterceptorName 178
LocalVariableCouldBeFinal Local variable 'iterator' could be declared final 179
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 185
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 197
MissingOverride The method 'addInterceptors(Collection)' is missing an @Override annotation. 197208
LongVariable Avoid excessively long variable names like currInterceptorName 198
UnusedAssignment The initializer for variable 'currInterceptorName' is never used (overwritten on line 202) 198
LocalVariableCouldBeFinal Local variable 'iterator' could be declared final 199
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 204
MissingOverride The method 'getInterceptorList()' is missing an @Override annotation. 213215
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 214
MissingOverride The method 'getLogCategory()' is missing an @Override annotation. 220222
MissingOverride The method 'toString()' is missing an @Override annotation. 227240
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 228

org/apache/fulcrum/yaafi/framework/tls/ThreadLocalStorage.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'containsKey': the method is declared in an interface type 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'clear': the method is declared in an interface type 68

org/apache/fulcrum/yaafi/framework/tls/ThreadLocalStorageImpl.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 34101
ImmutableField Private field 'local' could be made final; it is only initialized in the declaration or constructor. 39
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 39
MissingOverride The method 'initialValue()' is missing an @Override annotation. 4860
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 56
LocalVariableCouldBeFinal Local variable 'map' could be declared final 56
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 56
LocalVariableCouldBeFinal Local variable 'map' could be declared final 71
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'map' 72
MissingOverride The method 'get(String)' is missing an @Override annotation. 7579
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 75
LocalVariableCouldBeFinal Local variable 'map' could be declared final 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 78
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 81
MissingOverride The method 'put(String, Object)' is missing an @Override annotation. 8185
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 81
LocalVariableCouldBeFinal Local variable 'map' could be declared final 83
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 87
MissingOverride The method 'containsKey(String)' is missing an @Override annotation. 8791
LocalVariableCouldBeFinal Local variable 'map' could be declared final 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 90
MissingOverride The method 'clear()' is missing an @Override annotation. 93100
LocalVariableCouldBeFinal Local variable 'map' could be declared final 95

org/apache/fulcrum/yaafi/framework/util/ConfigurationUtil.java

Rule Violation Line
ModifiedCyclomaticComplexity The class 'ConfigurationUtil' has a Modified Cyclomatic Complexity of 9 (Highest = 10). 33200
StdCyclomaticComplexity The class 'ConfigurationUtil' has a Standard Cyclomatic Complexity of 9 (Highest = 10). 33200
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 34200
MethodArgumentCouldBeFinal Parameter 'vars' is not assigned and could be declared final 46
LongVariable Avoid excessively long variable names like defaultConfiguration 46
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 46
MethodArgumentCouldBeFinal Parameter 'defaultConfiguration' is not assigned and could be declared final 46
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 48
LocalVariableCouldBeFinal Local variable 'oldValue' could be declared final 57
LocalVariableCouldBeFinal Local variable 'newValue' could be declared final 58
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 61
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 61
UnusedAssignment The initializer for variable 'attributeName' is never used (overwritten on line 81) 76
LocalVariableCouldBeFinal Local variable 'attributeNames' could be declared final 77
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 7997
LocalVariableCouldBeFinal Local variable 'oldAttributeValue' could be declared final 82
LocalVariableCouldBeFinal Local variable 'newAttributeValue' could be declared final 83
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 86
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 86
LocalVariableCouldBeFinal Local variable 'children' could be declared final 101
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 103106
CognitiveComplexity The method 'expand(String, Map)' has a cognitive complexity of 39, current threshold is 15 122199
ModifiedCyclomaticComplexity The method 'expand' has a Modified Cyclomatic Complexity of 10. 122199
CyclomaticComplexity The method 'expand(String, Map)' has a cyclomatic complexity of 12. 122199
MethodArgumentCouldBeFinal Parameter 'argStr' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'vars' is not assigned and could be declared final 122
StdCyclomaticComplexity The method 'expand' has a Standard Cyclomatic Complexity of 10. 122199
LocalVariableCouldBeFinal Local variable 'isLenient' could be declared final 125
LocalVariableCouldBeFinal Local variable 'argBuf' could be declared final 127
LocalVariableCouldBeFinal Local variable 'argStrLength' could be declared final 128
ShortVariable Avoid variables with short names like ch 132
UnusedAssignment The initializer for variable 'del' is never used (overwritten on line 139) 133
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 135195
SwitchDensity A high ratio of statements to labels in a switch statement. Consider refactoring. 135195
LocalVariableCouldBeFinal Local variable 'nameBuf' could be declared final 138
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 138
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 140
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 142
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 144
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 144
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 147
ConfusingTernary Avoid if (x != y) ..; else ..; 147150
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 148
ControlStatementBraces This statement should have braces 148
ControlStatementBraces This statement should have braces 150
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 150
LocalVariableCouldBeFinal Local variable 'value' could be declared final 155
ConfusingTernary Avoid if (x != y) ..; else ..; 157171
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 159
ConfusingTernary Avoid if (x != y) ..; else ..; 163170
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 169
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 175
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 181
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 186
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 193

org/apache/fulcrum/yaafi/framework/util/ExceptionUtils.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3156
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3740
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 49
LocalVariableCouldBeFinal Local variable 'sw' could be declared final 51
ShortVariable Avoid variables with short names like sw 51
LocalVariableCouldBeFinal Local variable 'pw' could be declared final 52
ShortVariable Avoid variables with short names like pw 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 54

org/apache/fulcrum/yaafi/framework/util/InputStreamLocator.java

Rule Violation Line
ModifiedCyclomaticComplexity The class 'InputStreamLocator' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 36152
StdCyclomaticComplexity The class 'InputStreamLocator' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 36152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 39
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 42
MethodArgumentCouldBeFinal Parameter 'rootDir' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 67
MethodArgumentCouldBeFinal Parameter 'rootDir' is not assigned and could be declared final 67
NPathComplexity The method 'locate(String)' has an NPath complexity of 1152, current threshold is 200 79143
StdCyclomaticComplexity The method 'locate' has a Standard Cyclomatic Complexity of 11. 79143
ModifiedCyclomaticComplexity The method 'locate' has a Modified Cyclomatic Complexity of 11. 79143
CognitiveComplexity The method 'locate(String)' has a cognitive complexity of 18, current threshold is 15 79143
CyclomaticComplexity The method 'locate(String)' has a cyclomatic complexity of 15. 79143
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 79
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 81
UnusedAssignment The initializer for variable 'baseName' is never used (overwritten on line 130) 84
UnusedAssignment The initializer for variable 'file' is never used (overwritten on lines 91 and 104) 85
ShortVariable Avoid variables with short names like is 86
AvoidDuplicateLiterals The String literal "Looking for " appears 4 times in this file; the first occurrence is on line 93 93
CloseResource 'is' is reassigned, but the original instance is not closed 109
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 116
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 118
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 129
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 129
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 132

org/apache/fulcrum/yaafi/framework/util/ToStringBuilder.java

Rule Violation Line
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 34
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 34
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 37
LongVariable Avoid excessively long variable names like INCLUDE_PACKAGE_PREFIX 41
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 57
IfStmtsMustUseBraces Avoid using if statements without curly braces 5960
ControlStatementBraces This statement should have braces 60
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 66
LocalVariableCouldBeFinal Local variable 'className' could be declared final 68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 76
LocalVariableCouldBeFinal Local variable 'lastdotx' could be declared final 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 78
MethodArgumentCouldBeFinal Parameter 'i' is not assigned and could be declared final 86
ShortVariable Avoid variables with short names like i 86
MissingOverride The method 'toString()' is missing an @Override annotation. 95105
IfStmtsMustUseBraces Avoid using if statements without curly braces 9798
ControlStatementBraces This statement should have braces 98
LocalVariableCouldBeFinal Local variable 'result' could be declared final 100
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 102
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 107
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 107
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 112
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 112
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 117
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 117
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 122
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 127
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 127
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 132
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 132
AssignmentInOperand Avoid assignments in operands 134
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 135
ControlStatementBraces This statement should have braces 135
ControlStatementBraces This statement should have braces 138
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 138

org/apache/fulcrum/yaafi/framework/util/Validate.java

Rule Violation Line
GodClass Possible God Class (WMC=76, ATFD=12, TCC=0.000%) 45609
TooManyMethods This class has too many methods, consider refactoring it. 46609
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 46609
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5052
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 78
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 78
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 80
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 106
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 106
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 106
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 108
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 135
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 135
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 137
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 164
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 164
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 166
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 190
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 192
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 215
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 215
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 236
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 259
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 259
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 280
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 303
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 303
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 305
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 324
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 326
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 348
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 348
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 350
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 369
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 371
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 392
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 392
IfStmtsMustUseBraces Avoid using if statements without curly braces 394395
ControlStatementBraces This statement should have braces 395
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 411
IfStmtsMustUseBraces Avoid using if statements without curly braces 413414
ControlStatementBraces This statement should have braces 414
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 437
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 437
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 440446
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 467
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 501
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 501
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 504510
LocalVariableCouldBeFinal Local variable 'it' could be declared final 504
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 530
ShortVariable Avoid variables with short names like i 533
LocalVariableCouldBeFinal Local variable 'it' could be declared final 534
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 534542
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 559
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 559
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 560
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 564570
LocalVariableCouldBeFinal Local variable 'it' could be declared final 564
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 566
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 593
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 593
ShortVariable Avoid variables with short names like i 597
LocalVariableCouldBeFinal Local variable 'it' could be declared final 598
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 598607
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 600

org/apache/fulcrum/yaafi/interceptor/baseservice/BaseInterceptorServiceImpl.java

Rule Violation Line
ImmutableField Private field 'serviceSet' could be made final; it is only initialized in the declaration or constructor. 51
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 54
AvoidFieldNameMatchingMethodName Field isEnabled has the same name as a method 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
LongVariable Avoid excessively long variable names like serviceApplicationDir 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 69
CallSuperInConstructor It is a good practice to call super() in a constructor 7982
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 81
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 87
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 8793
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 98
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 98131
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 103
LocalVariableCouldBeFinal Local variable 'serviceConfigList' could be declared final 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 115129
LocalVariableCouldBeFinal Local variable 'name' could be declared final 117
LocalVariableCouldBeFinal Local variable 'shorthand' could be declared final 118
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 136
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 136139
LongVariable Avoid excessively long variable names like avalonInterceptorContext 148
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 148
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 148151
ShortVariable Avoid variables with short names like t 156
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 156
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 156
LongVariable Avoid excessively long variable names like avalonInterceptorContext 156
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 156159
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 164
LongVariable Avoid excessively long variable names like avalonInterceptorContext 164
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 164167
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 164
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 187
LongVariable Avoid excessively long variable names like avalonInterceptorContext 187
ConfusingTernary Avoid if (x != y) ..; else ..; 189208
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 191
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 195
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 199
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 201208
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 203
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 258
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 262
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 273

org/apache/fulcrum/yaafi/interceptor/jamon/Jamon1PerformanceMonitorImpl.java

Rule Violation Line
ImmutableField Private field 'isActive' could be made final; it is only initialized in the declaration or constructor. 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 53
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 53
UnusedFormalParameter Avoid unused constructor parameters such as 'serviceName'. 53
MissingOverride The method 'start()' is missing an @Override annotation. 6169
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 65
LongVariable Avoid excessively long variable names like methodToStringBuilder 65
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 66
MissingOverride The method 'stop()' is missing an @Override annotation. 7480
MissingOverride The method 'stop(Throwable)' is missing an @Override annotation. 8588
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 85
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 93
MissingOverride The method 'createReport()' is missing an @Override annotation. 9396
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 95

org/apache/fulcrum/yaafi/interceptor/jamon/Jamon2PerformanceMonitorImpl.java

Rule Violation Line
ImmutableField Private field 'isActive' could be made final; it is only initialized in the declaration or constructor. 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 73
UnusedFormalParameter Avoid unused constructor parameters such as 'serviceName'. 73
MissingOverride The method 'start()' is missing an @Override annotation. 8295
LongVariable Avoid excessively long variable names like methodToStringBuilder 90
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 90
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 91
MissingOverride The method 'stop()' is missing an @Override annotation. 100108
LocalVariableCouldBeFinal Local variable 'duration' could be declared final 104
MissingOverride The method 'stop(Throwable)' is missing an @Override annotation. 113121
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 113
MissingOverride The method 'createReport()' is missing an @Override annotation. 129132
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 129
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 131
LocalVariableCouldBeFinal Local variable 'result' could be declared final 138
UseUnderscoresInNumericLiterals Number 10240 should separate every third digit with an underscore 150
UseUnderscoresInNumericLiterals Number 20480 should separate every third digit with an underscore 151

org/apache/fulcrum/yaafi/interceptor/jamon/JamonInterceptorServiceImpl.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 47299
AvoidFieldNameMatchingMethodName Field isJamonAvailable has the same name as a method 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
LongVariable Avoid excessively long variable names like nextReportTimestamp 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
LongVariable Avoid excessively long variable names like performanceMonitorClassName 64
LongVariable Avoid excessively long variable names like performanceMonitorClass 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 67
LongVariable Avoid excessively long variable names like MONITORFACTORY_CLASSNAME 70
LongVariable Avoid excessively long variable names like DEFAULT_PERFORMANCEMONITOR_CLASSNAME 73
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8284
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 89106
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 91
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 9495
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98
LocalVariableCouldBeFinal Local variable 'reportFileName' could be declared final 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105
MissingOverride The method 'initialize()' is missing an @Override annotation. 111142
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 111
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 112
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 112
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 115
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 118
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 122
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 125
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 129
LocalVariableCouldBeFinal Local variable 'testMonitor' could be declared final 132
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 134
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 147
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 147150
MissingOverride The method 'dispose()' is missing an @Override annotation. 155161
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 160
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 170182
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 170
LongVariable Avoid excessively long variable names like interceptorContext 170
LocalVariableCouldBeFinal Local variable 'serviceShortHand' could be declared final 174
LocalVariableCouldBeFinal Local variable 'serviceMethod' could be declared final 175
LocalVariableCouldBeFinal Local variable 'isEnabled' could be declared final 176
LocalVariableCouldBeFinal Local variable 'monitor' could be declared final 177178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 179
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 180
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 188
LongVariable Avoid excessively long variable names like interceptorContext 188
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 188194
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 188
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 191
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 192
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 200
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 200206
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 200
LongVariable Avoid excessively long variable names like interceptorContext 200
ShortVariable Avoid variables with short names like t 200
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 204
MissingOverride The method 'run()' is missing an @Override annotation. 213215
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 237
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 237
MethodArgumentCouldBeFinal Parameter 'isEnabled' is not assigned and could be declared final 238
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 242
LocalVariableCouldBeFinal Local variable 'args' could be declared final 243
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 245
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 246
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 247
LocalVariableCouldBeFinal Local variable 'currTimestamp' could be declared final 258
MethodArgumentCouldBeFinal Parameter 'reportFile' is not assigned and could be declared final 272
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 276296
ShortVariable Avoid variables with short names like w 282
CloseResource Ensure that resources like this FileOutputStream object are closed after use 282
LocalVariableCouldBeFinal Local variable 'w' could be declared final 282
LocalVariableCouldBeFinal Local variable 'monitor' could be declared final 285
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 286
LocalVariableCouldBeFinal Local variable 'report' could be declared final 286
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 289292
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 290

org/apache/fulcrum/yaafi/interceptor/jamon/JamonPerformanceMonitor.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 47

org/apache/fulcrum/yaafi/interceptor/javasimon/JavaSimon4PerformanceMonitorImpl.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 45
ImmutableField Private field 'isActive' could be made final; it is only initialized in the declaration or constructor. 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 48
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 51
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 60
UnusedFormalParameter Avoid unused constructor parameters such as 'serviceName'. 60
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 60
MissingOverride The method 'start()' is missing an @Override annotation. 6977
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 73
LocalVariableCouldBeFinal Local variable 'stopwatch' could be declared final 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
MissingOverride The method 'stop()' is missing an @Override annotation. 8288
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 93
MissingOverride The method 'stop(Throwable)' is missing an @Override annotation. 9399
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 104
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 104
LongVariable Avoid excessively long variable names like methodToStringBuilder 106
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107

org/apache/fulcrum/yaafi/interceptor/javasimon/JavaSimonInterceptorServiceImpl.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48304
LongVariable Avoid excessively long variable names like isJavaSimonAvailable 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
AvoidFieldNameMatchingMethodName Field isJavaSimonAvailable has the same name as a method 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
LongVariable Avoid excessively long variable names like nextReportTimestamp 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
LongVariable Avoid excessively long variable names like performanceMonitorClassName 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
LongVariable Avoid excessively long variable names like performanceMonitorClass 68
LongVariable Avoid excessively long variable names like MONITORFACTORY_CLASSNAME 71
LongVariable Avoid excessively long variable names like DEFAULT_PERFORMANCEMONITOR_CLASSNAME 74
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8385
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 90
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 90107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 92
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 9596
LocalVariableCouldBeFinal Local variable 'reportFileName' could be declared final 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 106
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 112
MissingOverride The method 'initialize()' is missing an @Override annotation. 112143
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 113
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 113
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 116
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 119
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 123
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 126
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 130
LocalVariableCouldBeFinal Local variable 'testMonitor' could be declared final 133
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 135
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 148
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 148151
MissingOverride The method 'dispose()' is missing an @Override annotation. 156162
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 161
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 171183
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 171
LongVariable Avoid excessively long variable names like interceptorContext 171
LocalVariableCouldBeFinal Local variable 'serviceShortHand' could be declared final 175
LocalVariableCouldBeFinal Local variable 'serviceMethod' could be declared final 176
LocalVariableCouldBeFinal Local variable 'isEnabled' could be declared final 177
LocalVariableCouldBeFinal Local variable 'monitor' could be declared final 178179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 180
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 181
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 189196
LongVariable Avoid excessively long variable names like interceptorContext 189
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 189
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 189
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 192193
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 194
LongVariable Avoid excessively long variable names like interceptorContext 202
ShortVariable Avoid variables with short names like t 202
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 202
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 202209
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 202
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 205206
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 207
MissingOverride The method 'run()' is missing an @Override annotation. 216218
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 241
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 241
MethodArgumentCouldBeFinal Parameter 'isEnabled' is not assigned and could be declared final 242
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 246
LocalVariableCouldBeFinal Local variable 'args' could be declared final 247
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 249
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 250
LocalVariableCouldBeFinal Local variable 'currTimestamp' could be declared final 262
MethodArgumentCouldBeFinal Parameter 'reportFile' is not assigned and could be declared final 276
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 280301
ShortVariable Avoid variables with short names like w 286
CloseResource Ensure that resources like this FileOutputStream object are closed after use 286
LocalVariableCouldBeFinal Local variable 'w' could be declared final 286
LocalVariableCouldBeFinal Local variable 'report' could be declared final 291
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 294297
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 295

org/apache/fulcrum/yaafi/interceptor/logging/LoggingInterceptorServiceImpl.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 45340
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
LongVariable Avoid excessively long variable names like toStringBuilderClassName 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
LongVariable Avoid excessively long variable names like monitorAllExceptions 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
LongVariable Avoid excessively long variable names like toStringBuilderClass 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 62
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 79
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 7986
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 8384
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 85
MissingOverride The method 'initialize()' is missing an @Override annotation. 91105
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 91
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 94
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 94
LongVariable Avoid excessively long variable names like interceptorToStringBuilder 102
LocalVariableCouldBeFinal Local variable 'interceptorToStringBuilder' could be declared final 102
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 110
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 110113
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 127
LongVariable Avoid excessively long variable names like interceptorContext 127
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 127133
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 128
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 129
LongVariable Avoid excessively long variable names like interceptorContext 138
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 138146
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 138
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 138
ShortVariable Avoid variables with short names like t 138
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 142
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 143
LongVariable Avoid excessively long variable names like interceptorContext 151
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 151
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 151158
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 151
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 152
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 153
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 154
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 155
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 169
LongVariable Avoid excessively long variable names like interceptorContext 169
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 172
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 181
LongVariable Avoid excessively long variable names like interceptorContext 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 182
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 226
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 230 and 234) 227
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 231
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 232
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 252
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 252
LongVariable Avoid excessively long variable names like avalonInterceptorContext 252
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 252
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 253
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 254
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 256
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 257
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 258
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 259
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 260
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 273
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 273
LongVariable Avoid excessively long variable names like avalonInterceptorContext 273
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 274
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 275
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 276
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 278
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 279
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 280
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 280
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 281
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 295
LongVariable Avoid excessively long variable names like interceptorContext 295
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 295
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 295
LocalVariableCouldBeFinal Local variable 'result' could be declared final 296
LocalVariableCouldBeFinal Local variable 'method' could be declared final 297
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 330) 299
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 300
LongVariable Avoid excessively long variable names like methodToStringBuilder 300
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 306
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 307
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 308
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 309
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 310
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 311
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 312
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 313
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 314
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 315
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 316
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 316
ConfusingTernary Avoid if (x != y) ..; else ..; 319323
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 325
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 332
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 334

org/apache/fulcrum/yaafi/interceptor/performance/PerformanceInterceptorServiceImpl.java

Rule Violation Line
ModifiedCyclomaticComplexity The class 'PerformanceInterceptorServiceImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 41268
StdCyclomaticComplexity The class 'PerformanceInterceptorServiceImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 41268
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 7383
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 76
LocalVariableCouldBeFinal Local variable 'tresholdConfiguration' could be declared final 77
LongVariable Avoid excessively long variable names like tresholdConfiguration 77
AvoidDuplicateLiterals The String literal "millis" appears 5 times in this file; the first occurrence is on line 78 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 79
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 82
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 8891
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 88
LongVariable Avoid excessively long variable names like interceptorContext 105
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 105
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 105109
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 119
ShortVariable Avoid variables with short names like t 119
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 119125
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 119
LongVariable Avoid excessively long variable names like interceptorContext 119
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 122
LongVariable Avoid excessively long variable names like interceptorContext 135
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 135
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 135141
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 135
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 137
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 138
LongVariable Avoid excessively long variable names like interceptorContext 152
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 152
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 155
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 164
LongVariable Avoid excessively long variable names like interceptorContext 164
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 165
LongVariable Avoid excessively long variable names like interceptorContext 175
ModifiedCyclomaticComplexity The method 'log' has a Modified Cyclomatic Complexity of 10. 175203
CognitiveComplexity The method 'log(int, AvalonInterceptorContext, StopWatch)' has a cognitive complexity of 17, current threshold is 15 175203
StdCyclomaticComplexity The method 'log' has a Standard Cyclomatic Complexity of 10. 175203
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 175
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 175
CyclomaticComplexity The method 'log(int, AvalonInterceptorContext, StopWatch)' has a cyclomatic complexity of 11. 175203
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 175
UnusedAssignment The initializer for variable 'msg' is never used (overwritten on lines 181, 186, 191, 196 and 200) 176
LocalVariableCouldBeFinal Local variable 'time' could be declared final 177
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 199
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 213
LongVariable Avoid excessively long variable names like interceptorContext 213
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 213
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 213
LocalVariableCouldBeFinal Local variable 'method' could be declared final 214
LocalVariableCouldBeFinal Local variable 'args' could be declared final 215
LongVariable Avoid excessively long variable names like methodToStringBuilder 216
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 216
LocalVariableCouldBeFinal Local variable 'result' could be declared final 217
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 219
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 220
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 221
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 222
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 223
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 224
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 225
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 226
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 227
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 228
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 229
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 229
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 230
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 231
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 232
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 233
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 234
LocalVariableCouldBeFinal Local variable 'result' could be declared final 247
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 255) 248
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 255
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 256
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 258

org/apache/fulcrum/yaafi/interceptor/util/ArgumentToStringBuilderImpl.java

Rule Violation Line
CyclomaticComplexity The class 'ArgumentToStringBuilderImpl' has a total cyclomatic complexity of 121 (highest 29). 351035
ExcessiveClassLength Avoid really long classes. 351035
ModifiedCyclomaticComplexity The class 'ArgumentToStringBuilderImpl' has a Modified Cyclomatic Complexity of 4 (Highest = 29). 351035
StdCyclomaticComplexity The class 'ArgumentToStringBuilderImpl' has a Standard Cyclomatic Complexity of 4 (Highest = 29). 351035
TooManyMethods This class has too many methods, consider refactoring it. 361035
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 99
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 99
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 114
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 114
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 114
MissingOverride The method 'setMaxArgLength(int)' is missing an @Override annotation. 125128
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 125
MissingOverride The method 'setTarget(Object)' is missing an @Override annotation. 133136
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 133
MissingOverride The method 'setMode(int)' is missing an @Override annotation. 141144
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 141
StdCyclomaticComplexity The method 'toString' has a Standard Cyclomatic Complexity of 16. 157277
CognitiveComplexity The method 'toString()' has a cognitive complexity of 16, current threshold is 15 157277
MissingOverride The method 'toString()' is missing an @Override annotation. 157277
ExcessiveMethodLength Avoid really long methods. 157277
NcssCount The method 'toString()' has a NCSS line count of 96. 157277
ModifiedCyclomaticComplexity The method 'toString' has a Modified Cyclomatic Complexity of 16. 157277
CyclomaticComplexity The method 'toString()' has a cyclomatic complexity of 16. 157277
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 270274
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 272
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 273
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 286
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 292 and 296) 288
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 308
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 310
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 329) 311
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 315
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 327
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 329
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 353
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 355
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 359
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 392
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 394
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 398
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 431
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 433
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 437
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 470
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 472
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 476
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 509
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 511
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 515
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 548
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 550
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 554
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 587
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 589
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 593
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 626
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 628
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 632
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 652
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 654
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 675
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 678
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 700) 679
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 683
LocalVariableCouldBeFinal Local variable 'iterator' could be declared final 691
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 697
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 700704
MethodArgumentCouldBeFinal Parameter 'dictionary' is not assigned and could be declared final 729
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 731
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 735
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 755
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 763, 785 and 789) 757
UnusedAssignment The initializer for variable 'temp' is never used (overwritten on line 767) 758
UnusedAssignment The initializer for variable 'className' is never used (overwritten on line 769) 759
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 770
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 774
LocalVariableCouldBeFinal Local variable 'hashCode' could be declared final 776
LocalVariableCouldBeFinal Local variable 'tempBuffer' could be declared final 777
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 778
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 779
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 780
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 781
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 782
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 800
ExcessiveMethodLength Avoid really long methods. 818946
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 818
ModifiedCyclomaticComplexity The method 'appendClassName' has a Modified Cyclomatic Complexity of 29. 818946
CognitiveComplexity The method 'appendClassName(Object)' has a cognitive complexity of 34, current threshold is 15 818946
NcssCount The method 'appendClassName(Object)' has a NCSS line count of 85. 818946
StdCyclomaticComplexity The method 'appendClassName' has a Standard Cyclomatic Complexity of 29. 818946
CyclomaticComplexity The method 'appendClassName(Object)' has a cyclomatic complexity of 29. 818946
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 820
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 829
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 932
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 936
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 938
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 938
ShortVariable Avoid variables with short names like ch 952
MethodArgumentCouldBeFinal Parameter 'ch' is not assigned and could be declared final 952
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 972
LocalVariableCouldBeFinal Local variable 'sw' could be declared final 974
ShortVariable Avoid variables with short names like sw 974
ShortVariable Avoid variables with short names like pw 975
LocalVariableCouldBeFinal Local variable 'pw' could be declared final 975
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 977
MethodArgumentCouldBeFinal Parameter 'source' is not assigned and could be declared final 984
LocalVariableCouldBeFinal Local variable 'formattedSource' could be declared final 986
MethodArgumentCouldBeFinal Parameter 'source' is not assigned and could be declared final 997
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 999
IfStmtsMustUseBraces Avoid using if statements without curly braces 10021003
ControlStatementBraces This statement should have braces 1003
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 1003
LocalVariableCouldBeFinal Local variable 'stringBuilder' could be declared final 1012

org/apache/fulcrum/yaafi/interceptor/util/DefaultToStringBuilderImpl.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 30
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 48
MissingOverride The method 'setTarget(Object)' is missing an @Override annotation. 5659
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 56
MissingOverride The method 'setMaxArgLength(int)' is missing an @Override annotation. 6467
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 64
MissingOverride The method 'setMode(int)' is missing an @Override annotation. 7275
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 72
MissingOverride The method 'toString()' is missing an @Override annotation. 80102
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 88, 92 and 98) 82
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 9599
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 97

org/apache/fulcrum/yaafi/interceptor/util/MethodToStringBuilderImpl.java

Rule Violation Line
LongVariable Avoid excessively long variable names like INCLUDE_RETURNTYPE 32
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 71
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 80
MissingOverride The method 'setMaxArgLength(int)' is missing an @Override annotation. 8083
MissingOverride The method 'setMode(int)' is missing an @Override annotation. 8891
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 88
MissingOverride The method 'setTarget(Object)' is missing an @Override annotation. 9699
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 96
MissingOverride The method 'toString()' is missing an @Override annotation. 104148
LocalVariableCouldBeFinal Local variable 'buffer' could be declared final 108
LocalVariableCouldBeFinal Local variable 'returnType' could be declared final 110
LocalVariableCouldBeFinal Local variable 'declaringClass' could be declared final 111
LocalVariableCouldBeFinal Local variable 'params' could be declared final 112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 116
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 118
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 124
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 125
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 126
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 136
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 140
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 142
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 144147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 146

org/apache/fulcrum/yaafi/interceptor/util/StopWatch.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 84
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 93
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 100102
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 254
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 256
MissingOverride The method 'toString()' is missing an @Override annotation. 284286

org/apache/fulcrum/yaafi/service/advice/AdviceServiceImpl.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 47225
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
LongVariable Avoid excessively long variable names like defaultInterceptorList 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 6264
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 62
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 6971
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 69
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 7682
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 76
LocalVariableCouldBeFinal Local variable 'interceptorConfigList' could be declared final 77
LongVariable Avoid excessively long variable names like interceptorConfigList 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 77
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 87
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 8789
MissingOverride The method 'advice(Object)' is missing an @Override annotation. 98101
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 98
AvoidDuplicateLiterals The String literal "object" appears 5 times in this file; the first occurrence is on line 99 99
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 109
MissingOverride The method 'advice(String, Object)' is missing an @Override annotation. 109112
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 109
MissingOverride The method 'advice(String, Object)' is missing an @Override annotation. 121125
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 121
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 123
LocalVariableCouldBeFinal Local variable 'className' could be declared final 123
MissingOverride The method 'advice(String, String, Object)' is missing an @Override annotation. 133136
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 133
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 133
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 133
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 145
MissingOverride The method 'isAdviced(Object)' is missing an @Override annotation. 145154
UnusedAssignment The initializer for variable 'invocationHandler' is never used (overwritten on line 149) 146
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 150
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 168
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 168
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 168
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 173
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 201) 173
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 174
LocalVariableCouldBeFinal Local variable 'clazzName' could be declared final 174
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 174
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 180
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 184
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 191
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 195
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 204
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 206

org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 42344
TooManyMethods This class has too many methods, consider refactoring it. 45344
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
LongVariable Avoid excessively long variable names like serviceConfiguration 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
LongVariable Avoid excessively long variable names like serviceApplicationDir 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
LongVariable Avoid excessively long variable names like servicePartitionName 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
LongVariable Avoid excessively long variable names like serviceClassLoader 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8083
CallSuperInConstructor It is a good practice to call super() in a constructor 8083
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 8896
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 88
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 101104
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 101
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 109112
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 109
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 117
MissingOverride The method 'parameterize(Parameters)' is missing an @Override annotation. 117120
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 125128
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 125
MissingOverride The method 'dispose()' is missing an @Override annotation. 133144
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 135
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 136
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 137
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 138
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 139
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 141
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 142
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 143
MissingOverride The method 'toString()' is missing an @Override annotation. 153203
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 202 characters appended. 155
LocalVariableCouldBeFinal Local variable 'result' could be declared final 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 157
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 157
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 157
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 159
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 159
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 159
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 161
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 162
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 163
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 163
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 163
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 165
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 166
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 167
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 167
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 167
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 169
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 170
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 171
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 171
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 171
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 173
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 174
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 175
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 175
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 175
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 177
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 178
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 179
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 181
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 182
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 183
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 183
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 183
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 185
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 186
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 187
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 187
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 187
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 189
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 190
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 191
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 191
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 191
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 193
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 194
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 195
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 195
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 195
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 197
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 198
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 200
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 210
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 220
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 228
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 230
UnusedAssignment The value assigned to variable 'object' is never used 242
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 242
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 251
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 255
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 268

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationEntry.java

Rule Violation Line
ImmutableField Private field 'location' could be made final; it is only initialized in the declaration or constructor. 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 44
ImmutableField Private field 'serviceList' could be made final; it is only initialized in the declaration or constructor. 44
ImmutableField Private field 'locator' could be made final; it is only initialized in the declaration or constructor. 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
AvoidFieldNameMatchingMethodName Field isFirstInvocation has the same name as a method 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
ImmutableField Private field 'logger' could be made final; it is only initialized in the declaration or constructor. 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
ArrayIsStoredDirectly The user-supplied array 'serviceList' is stored directly. 66
MethodArgumentCouldBeFinal Parameter 'applicationDir' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 66
ShortVariable Avoid variables with short names like is 79
UnusedAssignment The initializer for variable 'currDigest' is never used (overwritten on line 92) 80
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 82123
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 88
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 94
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 96
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 101
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 109
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 110
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 111
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 118
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 119
MethodReturnsInternalArray Returning 'serviceList' may expose an internal array. 131
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 165
ShortVariable Avoid variables with short names like is 165
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 165
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 174) 166
UnusedAssignment The initializer for variable 'content' is never used (overwritten on line 170) 167
LocalVariableCouldBeFinal Local variable 'sha1' could be declared final 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 174
MethodArgumentCouldBeFinal Parameter 'digest' is not assigned and could be declared final 182
MethodArgumentCouldBeFinal Parameter 'rhs' is not assigned and could be declared final 193
MethodArgumentCouldBeFinal Parameter 'lhs' is not assigned and could be declared final 193

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationServiceImpl.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
LongVariable Avoid excessively long variable names like reconfigurationEntryList 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
LongVariable Avoid excessively long variable names like serviceLifecycleManager 71
CallSuperInConstructor It is a good practice to call super() in a constructor 8082
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 87
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 8790
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 95
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 9597
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 102
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 102147
UnusedAssignment The initializer for variable 'services' is never used (overwritten on line 124) 112
UnusedAssignment The initializer for variable 'serviceEntries' is never used (overwritten on line 129) 113
LocalVariableCouldBeFinal Local variable 'entryList' could be declared final 114
UnusedAssignment The initializer for variable 'location' is never used (overwritten on line 123) 116
UnusedAssignment The initializer for variable 'serviceName' is never used (overwritten on line 133) 117
LongVariable Avoid excessively long variable names like reconfigurationEntry 119
UnusedAssignment The initializer for variable 'reconfigurationEntry' is never used (overwritten on line 138) 119
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 122
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 123
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 130
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 138139
MissingOverride The method 'initialize()' is missing an @Override annotation. 152163
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 152
IfStmtsMustUseBraces Avoid using if statements without curly braces 157159
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 157
ControlStatementBraces This statement should have braces 158159
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 162
MissingOverride The method 'start()' is missing an @Override annotation. 168171
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 168
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 176
MissingOverride The method 'stop()' is missing an @Override annotation. 176181
UseUnderscoresInNumericLiterals Number 10000 should separate every third digit with an underscore 180
MissingOverride The method 'dispose()' is missing an @Override annotation. 186192
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 188
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 189
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 190
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 191
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 197
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 197199
MissingOverride The method 'run()' is missing an @Override annotation. 211230
UnusedAssignment The initializer for variable 'list' is never used (overwritten on line 214) 212
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 213
LocalVariableCouldBeFinal Local variable 'reconfigurationEntry' could be declared final 216
LongVariable Avoid excessively long variable names like reconfigurationEntry 216
IfStmtsMustUseBraces Avoid using if statements without curly braces 217218
ControlStatementBraces This statement should have braces 218
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 224
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 225
LongVariable Avoid excessively long variable names like reconfigurationEntry 243
MethodArgumentCouldBeFinal Parameter 'reconfigurationEntry' is not assigned and could be declared final 243
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 243
CloseResource Ensure that resources like this InputStream object are closed after use 246
ShortVariable Avoid variables with short names like is 246
LocalVariableCouldBeFinal Local variable 'builder' could be declared final 247
LocalVariableCouldBeFinal Local variable 'configuration' could be declared final 248
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 249
UnusedAssignment The value assigned to variable 'is' is never used 250
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 250
LocalVariableCouldBeFinal Local variable 'serviceList' could be declared final 271
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 280282
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 287289
LongVariable Avoid excessively long variable names like reconfigurationEntryList 287
MethodArgumentCouldBeFinal Parameter 'reconfigurationEntryList' is not assigned and could be declared final 287

org/apache/fulcrum/yaafi/service/servicemanager/ServiceManagerServiceImpl.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 63
CallSuperInConstructor It is a good practice to call super() in a constructor 6871
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7679
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 85
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8591
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 100
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 100103
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 108
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 108111
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 116
MissingOverride The method 'parameterize(Parameters)' is missing an @Override annotation. 116119
MissingOverride The method 'dispose()' is missing an @Override annotation. 124130
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 126
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 129
MissingOverride The method 'hasService(String)' is missing an @Override annotation. 139142
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 139
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 147
MissingOverride The method 'lookup(String)' is missing an @Override annotation. 147150
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 155
MissingOverride The method 'release(Object)' is missing an @Override annotation. 155158
MissingOverride The method 'getServiceManager()' is missing an @Override annotation. 163166
MissingOverride The method 'getParameters()' is missing an @Override annotation. 171174
MissingOverride The method 'getContext()' is missing an @Override annotation. 179182
MissingOverride The method 'getAvalonLogger()' is missing an @Override annotation. 187190

org/apache/fulcrum/yaafi/service/shutdown/Shutdown.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 33
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 36
ImmutableField Private field 'useSystemExit' could be made final; it is only initialized in the declaration or constructor. 36
MethodArgumentCouldBeFinal Parameter 'useSystemExit' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'disposable' is not assigned and could be declared final 44
MissingOverride The method 'run()' is missing an @Override annotation. 5370
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 5962
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 61
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 64
DoNotTerminateVM System.exit() should not be used in J2EE/JEE apps 68
DoNotTerminateVM System.exit() should not be used in J2EE/JEE apps 68

org/apache/fulcrum/yaafi/service/shutdown/ShutdownEntry.java

Rule Violation Line
ImmutableField Private field 'location' could be made final; it is only initialized in the declaration or constructor. 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 47
ImmutableField Private field 'locator' could be made final; it is only initialized in the declaration or constructor. 47
AvoidFieldNameMatchingMethodName Field isFirstInvocation has the same name as a method 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
ImmutableField Private field 'logger' could be made final; it is only initialized in the declaration or constructor. 53
ImmutableField Private field 'useSystemExit' could be made final; it is only initialized in the declaration or constructor. 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
MethodArgumentCouldBeFinal Parameter 'useSystemExit' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 66
MethodArgumentCouldBeFinal Parameter 'applicationDir' is not assigned and could be declared final 66
ShortVariable Avoid variables with short names like is 79
UnusedAssignment The initializer for variable 'currDigest' is never used (overwritten on line 93) 80
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 82124
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 88
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 95
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 97
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 102
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 110
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 111
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 112
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 119
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 120
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 165
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 165
ShortVariable Avoid variables with short names like is 165
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 174) 166
UnusedAssignment The initializer for variable 'content' is never used (overwritten on line 170) 167
LocalVariableCouldBeFinal Local variable 'sha1' could be declared final 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 174
MethodArgumentCouldBeFinal Parameter 'digest' is not assigned and could be declared final 182
MethodArgumentCouldBeFinal Parameter 'lhs' is not assigned and could be declared final 189
MethodArgumentCouldBeFinal Parameter 'rhs' is not assigned and could be declared final 189

org/apache/fulcrum/yaafi/service/shutdown/ShutdownServiceImpl.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
CallSuperInConstructor It is a good practice to call super() in a constructor 7375
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 80
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 8082
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 87
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 8789
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 94
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 94114
ConfusingTernary Avoid if (x != y) ..; else ..; 101113
LocalVariableCouldBeFinal Local variable 'shutdownConfig' could be declared final 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 104
LongVariable Avoid excessively long variable names like shutdownEntryLocation 104
LocalVariableCouldBeFinal Local variable 'shutdownEntryLocation' could be declared final 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 107
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 111
MissingOverride The method 'initialize()' is missing an @Override annotation. 121134
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 121
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 127
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 128
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 133
MissingOverride The method 'start()' is missing an @Override annotation. 141144
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 141
MissingOverride The method 'stop()' is missing an @Override annotation. 149154
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 149
UseUnderscoresInNumericLiterals Number 10000 should separate every third digit with an underscore 153
MissingOverride The method 'dispose()' is missing an @Override annotation. 159164
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 161
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 162
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 163
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 169171
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 169
MissingOverride The method 'run()' is missing an @Override annotation. 180206
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 181
LocalVariableCouldBeFinal Local variable 'shutdown' could be declared final 198199
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 198199
LocalVariableCouldBeFinal Local variable 'shutdownThread' could be declared final 201
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 201
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 201
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 201
ConfusingTernary Avoid if (x != y) ..; else ..; 223

org/apache/fulcrum/yaafi/service/systemproperty/SystemPropertyServiceImpl.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 4144
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 4144
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 4980
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 49
UnusedAssignment The initializer for variable 'key' is never used (overwritten on line 58) 51
UnusedAssignment The initializer for variable 'value' is never used (overwritten on line 59) 52
UnusedAssignment The initializer for variable 'oldValue' is never used (overwritten on line 60) 53
LocalVariableCouldBeFinal Local variable 'systemProperties' could be declared final 54
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 5677
ConfusingTernary Avoid if (x != y) ..; else ..; 6273
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 85
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 8589

Priority 4

org/apache/fulcrum/yaafi/cli/Getopt.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 38
UselessParentheses Useless parentheses. 72

org/apache/fulcrum/yaafi/cli/Main.java

Rule Violation Line
ShortClassName Avoid short class names like Main 37640
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 156
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 455

org/apache/fulcrum/yaafi/framework/component/ServiceComponentImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 350

org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 556
UselessParentheses Useless parentheses. 1101

org/apache/fulcrum/yaafi/framework/container/ServiceLifecycleManager.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 67

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerConfiguration.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 591

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorContextImpl.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 87
UselessParentheses Useless parentheses. 164

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorFactory.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 103

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorInvocationHandler.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 69
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 140

org/apache/fulcrum/yaafi/framework/reflection/Clazz.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 81
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 101
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 122

org/apache/fulcrum/yaafi/framework/util/ConfigurationUtil.java

Rule Violation Line
UselessParentheses Useless parentheses. 105

org/apache/fulcrum/yaafi/framework/util/Validate.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 280
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 467

org/apache/fulcrum/yaafi/interceptor/performance/PerformanceInterceptorServiceImpl.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 246

org/apache/fulcrum/yaafi/interceptor/util/ArgumentToStringBuilderImpl.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 308
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 353
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 392
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 431
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 470
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 509
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 548
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 587

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationEntry.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 66

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationServiceImpl.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 287

org/apache/fulcrum/yaafi/service/shutdown/ShutdownServiceImpl.java

Rule Violation Line
UselessParentheses Useless parentheses. 223

Priority 5

org/apache/fulcrum/yaafi/cli/Getopt.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'strOption' (lines '150'-'163'). 150163

org/apache/fulcrum/yaafi/cli/Main.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'exitCode' (lines '199'-'209'). 199209

org/apache/fulcrum/yaafi/framework/component/AvalonServiceComponentImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'lastThrowable' (lines '147'-'159'). 147159
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'lastThrowable' (lines '159'-'173'). 159173
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'lastThrowable' (lines '173'-'184'). 173184

org/apache/fulcrum/yaafi/framework/component/ServiceComponentImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currClassLoader' (lines '101'-'109'). 101109
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currClassLoader' (lines '101'-'105'). 101105

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolverBaseImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '187'-'202'). 187202

org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'exceptionCounter' (lines '481'-'513'). 481513
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'exceptionCounter' (lines '513'-'513'). 513
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '613'-'628'). 613628
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '613'-'670'). 613670
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '638'-'670'). 638670
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '799'-'810'). 799810
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceComponent' (lines '1,069'-'1,097'). 10691097
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceComponent' (lines '1,069'-'1,109'). 10691109
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'defaultInterceptorList' (lines '1,081'-'1,109'). 10811109
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1,120'-'1,128'). 11201128
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'builder' (lines '1,123'-'1,139'). 11231139
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '1,128'-'1,139'). 11281139
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1,185'-'1,192'). 11851192

org/apache/fulcrum/yaafi/framework/crypto/CryptoStreamFactory.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'signature' (lines '84'-'94'). 8494
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'args' (lines '85'-'94'). 8594

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerConfiguration.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'name' (lines '155'-'160'). 155160
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'name' (lines '155'-'164'). 155164
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '156'-'161'). 156161
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '156'-'164'). 156164
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '212'-'341'). 212341
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '212'-'219'). 212219
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '628'-'638'). 628638
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '628'-'650'). 628650
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'builder' (lines '632'-'650'). 632650

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerFactory.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'clazz' (lines '74'-'98'). 7498
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'configuration' (lines '75'-'88'). 7588
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '76'-'106'). 76106
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '106'-'134'). 106134

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorFactory.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '107'-'116'). 107116
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '107'-'126'). 107126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '116'-'116'). 116
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '116'-'126'). 116126

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorInvocationHandler.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'hasCreatedTransaction' (lines '157'-'190'). 157190

org/apache/fulcrum/yaafi/framework/reflection/Clazz.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '84'-'86'). 8486
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '104'-'106'). 104106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '125'-'127'). 125127

org/apache/fulcrum/yaafi/framework/role/RoleConfigurationParserImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'clazzName' (lines '87'-'104'). 87104
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'clazzName' (lines '87'-'132'). 87132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'name' (lines '88'-'132'). 88132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'name' (lines '88'-'105'). 88105
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'shorthand' (lines '89'-'132'). 89132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'shorthand' (lines '89'-'106'). 89106
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isEarlyInit' (lines '90'-'132'). 90132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'isEarlyInit' (lines '90'-'107'). 90107
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'description' (lines '91'-'132'). 91132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'description' (lines '91'-'108'). 91108
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'componentType' (lines '92'-'109'). 92109
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'componentType' (lines '92'-'132'). 92132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'componentFlavour' (lines '93'-'132'). 93132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'componentFlavour' (lines '93'-'110'). 93110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasProxy' (lines '94'-'111'). 94111
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'hasProxy' (lines '94'-'132'). 94132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'interceptorList' (lines '95'-'132'). 95132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'interceptorList' (lines '95'-'116'). 95116
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'logCategory' (lines '96'-'112'). 96112
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'logCategory' (lines '96'-'132'). 96132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleEntry' (lines '97'-'132'). 97132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleEntry' (lines '97'-'125'). 97125
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '100'-'128'). 100128
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleIndex' (lines '102'-'132'). 102132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '128'-'128'). 128

org/apache/fulcrum/yaafi/framework/role/RoleEntryImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currInterceptorName' (lines '178'-'190'). 178190
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currInterceptorName' (lines '178'-'182'). 178182
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currInterceptorName' (lines '198'-'208'). 198208
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currInterceptorName' (lines '198'-'202'). 198202

org/apache/fulcrum/yaafi/framework/util/ConfigurationUtil.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'attributeName' (lines '76'-'107'). 76107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'attributeName' (lines '76'-'81'). 7681
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isLenient' (lines '125'-'199'). 125199
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'argBuf' (lines '127'-'199'). 127199
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'del' (lines '133'-'199'). 133199
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'del' (lines '133'-'139'). 133139
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'nameBuf' (lines '138'-'199'). 138199
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'cIdx' (lines '181'-'199'). 181199

org/apache/fulcrum/yaafi/framework/util/InputStreamLocator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'baseName' (lines '84'-'130'). 84130
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'baseName' (lines '84'-'143'). 84143
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'file' (lines '85'-'104'). 85104
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'file' (lines '85'-'143'). 85143
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'file' (lines '85'-'91'). 8591

org/apache/fulcrum/yaafi/framework/util/Validate.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '533'-'534'). 533534
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '533'-'543'). 533543
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '534'-'543'). 534543
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '534'-'534'). 534
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '597'-'598'). 597598
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '597'-'608'). 597608
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '598'-'608'). 598608
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '598'-'598'). 598

org/apache/fulcrum/yaafi/interceptor/jamon/JamonInterceptorServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '239'-'244'). 239244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'printWriter' (lines '273'-'283'). 273283
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'printWriter' (lines '273'-'298'). 273298

org/apache/fulcrum/yaafi/interceptor/javasimon/JavaSimonInterceptorServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '243'-'248'). 243248
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'printWriter' (lines '277'-'287'). 277287
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'printWriter' (lines '277'-'303'). 277303

org/apache/fulcrum/yaafi/interceptor/logging/LoggingInterceptorServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '227'-'230'). 227230
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '230'-'234'). 230234
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '299'-'330'). 299330
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '299'-'339'). 299339
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'args' (lines '303'-'339'). 303339

org/apache/fulcrum/yaafi/interceptor/performance/PerformanceInterceptorServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'181'). 176181
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'191'). 176191
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'msg' (lines '176'-'203'). 176203
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'200'). 176200
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'196'). 176196
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'186'). 176186
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '248'-'255'). 248255
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '248'-'266'). 248266

org/apache/fulcrum/yaafi/interceptor/util/ArgumentToStringBuilderImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '288'-'296'). 288296
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '288'-'292'). 288292
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '310'-'345'). 310345
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '311'-'345'). 311345
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '311'-'329'). 311329
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '355'-'384'). 355384
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '394'-'423'). 394423
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '433'-'462'). 433462
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '472'-'501'). 472501
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '511'-'540'). 511540
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '550'-'579'). 550579
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '589'-'618'). 589618
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '628'-'644'). 628644
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'index' (lines '677'-'721'). 677721
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '678'-'721'). 678721
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '679'-'700'). 679700
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '679'-'721'). 679721
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '731'-'747'). 731747
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '757'-'763'). 757763
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '757'-'789'). 757789
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '757'-'785'). 757785
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'temp' (lines '758'-'767'). 758767
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '758'-'794'). 758794
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'className' (lines '759'-'769'). 759769
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'className' (lines '759'-'794'). 759794
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'skipClassName' (lines '820'-'946'). 820946
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'skipClassName' (lines '820'-'929'). 820929
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'className' (lines '829'-'946'). 829946
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isTruncated' (lines '999'-'1,034'). 9991034
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'isTruncated' (lines '999'-'1,018'). 9991018

org/apache/fulcrum/yaafi/interceptor/util/DefaultToStringBuilderImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '82'-'92'). 8292
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '82'-'88'). 8288
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '88'-'98'). 8898
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '92'-'98'). 9298

org/apache/fulcrum/yaafi/interceptor/util/MethodToStringBuilderImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'returnType' (lines '110'-'148'). 110148

org/apache/fulcrum/yaafi/service/advice/AdviceServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'invocationHandler' (lines '146'-'149'). 146149
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'invocationHandler' (lines '146'-'154'). 146154
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '173'-'201'). 173201
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '173'-'210'). 173210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'clazzName' (lines '174'-'210'). 174210
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '201'-'210'). 201210

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationEntry.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '78'-'104'). 78104
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '79'-'85'). 7985
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currDigest' (lines '80'-'92'). 8092
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currDigest' (lines '80'-'125'). 80125
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '94'-'125'). 94125
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '166'-'174'). 166174
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'content' (lines '167'-'170'). 167170

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'services' (lines '112'-'147'). 112147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'services' (lines '112'-'124'). 112124
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceEntries' (lines '113'-'129'). 113129
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceEntries' (lines '113'-'147'). 113147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'location' (lines '116'-'123'). 116123
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'location' (lines '116'-'147'). 116147
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceName' (lines '117'-'147'). 117147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '117'-'133'). 117133
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceNameList' (lines '118'-'147'). 118147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceNameList' (lines '118'-'130'). 118130
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'reconfigurationEntry' (lines '119'-'138'). 119138
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'reconfigurationEntry' (lines '119'-'147'). 119147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'list' (lines '120'-'141'). 120141
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'listIndex' (lines '121'-'147'). 121147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceNameList' (lines '130'-'134'). 130134
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceNameList' (lines '134'-'134'). 134
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'list' (lines '141'-'141'). 141
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'list' (lines '212'-'230'). 212230
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'list' (lines '212'-'214'). 212214
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'configuration' (lines '248'-'275'). 248275
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '250'-'275'). 250275

org/apache/fulcrum/yaafi/service/shutdown/ShutdownEntry.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '78'-'105'). 78105
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '79'-'85'). 7985
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currDigest' (lines '80'-'126'). 80126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currDigest' (lines '80'-'93'). 8093
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '95'-'126'). 95126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '166'-'174'). 166174
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'content' (lines '167'-'170'). 167170

org/apache/fulcrum/yaafi/service/systemproperty/SystemPropertyServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '51'-'80'). 5180
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '51'-'58'). 5158
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '52'-'80'). 5280
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '52'-'59'). 5259
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'oldValue' (lines '53'-'80'). 5380
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'oldValue' (lines '53'-'60'). 5360

Files

org/apache/fulcrum/yaafi/cli/Getopt.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 29
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 32
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 38
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 38
MethodArgumentCouldBeFinal Parameter 'prefix' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 49
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 3 49
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 70
UselessParentheses Useless parentheses. 4 72
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 89
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 101
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 101
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 113
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 115
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 115
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 125
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 125
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 127
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 128
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 128
MethodArgumentCouldBeFinal Parameter 'index' is not assigned and could be declared final 3 137
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 148
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'strOption' (lines '150'-'163'). 5 150163
LocalVariableCouldBeFinal Local variable 'strOption' could be declared final 3 150
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 158
MethodArgumentCouldBeFinal Parameter 'index' is not assigned and could be declared final 3 170
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 178185
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 180
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 184
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 199
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 201
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 206
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 221
MethodArgumentCouldBeFinal Parameter 'option' is not assigned and could be declared final 3 221
LocalVariableCouldBeFinal Local variable 'index' could be declared final 3 223
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 228
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 239

org/apache/fulcrum/yaafi/cli/Main.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Main 4 37640
GodClass Possible God Class (WMC=52, ATFD=11, TCC=3.209%) 3 37640
TooManyMethods This class has too many methods, consider refactoring it. 3 38640
LongVariable Avoid excessively long variable names like APPLICATION_CONFIG 3 49
LongVariable Avoid excessively long variable names like APPLICATION_HASSHUTDOWNHOOK 3 52
LongVariable Avoid excessively long variable names like APPLICATION_ISBLOCKING 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
LongVariable Avoid excessively long variable names like containerConfigValue 3 67
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
AvoidFieldNameMatchingMethodName Field isBlocking has the same name as a method 3 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 76
AvoidFieldNameMatchingMethodName Field hasShutdownHook has the same name as a method 3 76
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 94
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 94
AvoidFieldNameMatchingMethodName Field isInitialized has the same name as a method 3 94
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 156
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 156
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 3 156
LocalVariableCouldBeFinal Local variable 'getopt' could be declared final 3 164
ConstructorCallsOverridableMethod Overridable method 'setApplicationName' called during object construction 1 166168
ConstructorCallsOverridableMethod Overridable method 'getApplicationName' called during object construction 1 167
ConstructorCallsOverridableMethod Overridable method 'setApplicationHome' called during object construction 1 170172
ConstructorCallsOverridableMethod Overridable method 'getApplicationHome' called during object construction 1 171
ConstructorCallsOverridableMethod Overridable method 'setTempHome' called during object construction 1 174176
ConstructorCallsOverridableMethod Overridable method 'getTempHome' called during object construction 1 175
ConstructorCallsOverridableMethod Overridable method 'setContainerConfigValue' called during object construction 1 178180
ConstructorCallsOverridableMethod Overridable method 'getContainerConfigValue' called during object construction 1 179
ConstructorCallsOverridableMethod Overridable method 'setIsBlocking' called during object construction 1 182184
ConstructorCallsOverridableMethod Overridable method 'setIsBlocking' called during object construction 1 182184
ConstructorCallsOverridableMethod Overridable method 'setHasShutdownHook' called during object construction 1 186188
ConstructorCallsOverridableMethod Overridable method 'setHasShutdownHook' called during object construction 1 186188
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 197
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 197
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'exitCode' (lines '199'-'209'). 5 199209
LocalVariableCouldBeFinal Local variable 'impl' could be declared final 3 201
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 207210
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 224
MethodArgumentCouldBeFinal Parameter 'baseDir' is not assigned and could be declared final 3 224
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 240243
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 240243
MissingOverride The method 'run()' is missing an @Override annotation. 3 251264
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 258263
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 260
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 262
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 262
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 3 292
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 3 305
MethodArgumentCouldBeFinal Parameter 'applicationHome' is not assigned and could be declared final 3 344
LongVariable Avoid excessively long variable names like containerConfigValue 3 360
MethodArgumentCouldBeFinal Parameter 'containerConfigValue' is not assigned and could be declared final 3 360
MethodArgumentCouldBeFinal Parameter 'isBlocking' is not assigned and could be declared final 3 376
MethodArgumentCouldBeFinal Parameter 'isBlocking' is not assigned and could be declared final 3 384
MethodArgumentCouldBeFinal Parameter 'isBlocking' is not assigned and could be declared final 3 392
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 394
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 394
MethodArgumentCouldBeFinal Parameter 'tempHome' is not assigned and could be declared final 3 408
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 424
MethodArgumentCouldBeFinal Parameter 'applicationName' is not assigned and could be declared final 3 440
MethodReturnsInternalArray Returning 'args' may expose an internal array. 3 450
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 455
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 3 455
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 455
MethodArgumentCouldBeFinal Parameter 'hasShutdownHook' is not assigned and could be declared final 3 471
MethodArgumentCouldBeFinal Parameter 'hasShutdownHook' is not assigned and could be declared final 3 479
MethodArgumentCouldBeFinal Parameter 'hasShutdownHook' is not assigned and could be declared final 3 487
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 489
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 489
MissingOverride The method 'toString()' is missing an @Override annotation. 3 495537
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 123 characters appended. 3 497
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 497
LocalVariableCouldBeFinal Local variable 'argsLine' could be declared final 3 498
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 500
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 500
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 500
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 502
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 502
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 503
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 503
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 504
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 504
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 514
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 518
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 519
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 519
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 521
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 521
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 522
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 522
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 523
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 523
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 524
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 524
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 525
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 525
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 526
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 526
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 527
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 527
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 528
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 528
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 529
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 529
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 530
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 530
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 531
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 531
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 532
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 532
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 533
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 533
MethodArgumentCouldBeFinal Parameter 'isInitialized' is not assigned and could be declared final 3 554
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 564
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 568
LocalVariableCouldBeFinal Local variable 'shutdown' could be declared final 3 584
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 585
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 586
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 614
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 628
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 634
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 636

org/apache/fulcrum/yaafi/cli/Shutdown.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 33
MethodArgumentCouldBeFinal Parameter 'disposable' is not assigned and could be declared final 3 39
MissingOverride The method 'run()' is missing an @Override annotation. 3 4751
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 50

org/apache/fulcrum/yaafi/framework/component/AvalonServiceComponentImpl.java

Rule Violation Priority Line
CyclomaticComplexity The class 'AvalonServiceComponentImpl' has a total cyclomatic complexity of 89 (highest 9). 3 54593
TooManyMethods This class has too many methods, consider refactoring it. 3 56593
MethodArgumentCouldBeFinal Parameter 'roleEntry' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'parentLogger' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 65
MissingOverride The method 'incarnateInstance()' is missing an @Override annotation. 3 77140
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 77
LocalVariableCouldBeFinal Local variable 'isInterceptor' could be declared final 3 115117
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 119
LocalVariableCouldBeFinal Local variable 'proxyInstance' could be declared final 3 126132
MissingOverride The method 'reconfigure()' is missing an @Override annotation. 3 145198
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'lastThrowable' (lines '147'-'159'). 5 147159
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 155160
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 157
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'lastThrowable' (lines '159'-'173'). 5 159173
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 169174
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 171
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'lastThrowable' (lines '173'-'184'). 5 173184
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 180185
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 182
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 195
MissingOverride The method 'decommision()' is missing an @Override annotation. 3 204246
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 204
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 212216
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 214
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 220
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 231
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 233
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 235
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 235
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 239243
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 241
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 256
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 258
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 267272
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 269
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 271
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 271
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 281
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 283
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 294
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 298303
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 300
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 312
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 314
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 325
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 329334
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 331
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 344
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 346
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 357
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 361366
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 363
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 3 375
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 377
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 388
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 392397
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 394
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 405
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 407
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 416
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 418
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 422427
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 424
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 426
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 426
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 435
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 437
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 446
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 448
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 452457
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 454
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 456
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 456
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 465
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 467
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 476
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 478
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 482487
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 484
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 486
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 486
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 495
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 497
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 506
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 508
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 512517
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 514
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 516
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 516
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 526
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 535540
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 537
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 539
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 539
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 549
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 558563
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 560
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 562
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 562
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 572
LocalVariableCouldBeFinal Local variable 'rawInstance' could be declared final 3 576
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 585590
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 587
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 589
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 589

org/apache/fulcrum/yaafi/framework/component/ServiceComponentImpl.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 39401
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
LongVariable Avoid excessively long variable names like implementationClazz 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 55
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
MethodArgumentCouldBeFinal Parameter 'roleEntry' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'parentLogger' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 3 98
MissingOverride The method 'loadImplemtationClass(ClassLoader)' is missing an @Override annotation. 3 98128
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currClassLoader' (lines '101'-'109'). 5 101109
UnusedAssignment The initializer for variable 'currClassLoader' is never used (overwritten on lines 105 and 109) 3 101
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currClassLoader' (lines '101'-'105'). 5 101105
ConfusingTernary Avoid if (x != y) ..; else ..; 3 103110
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 109
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 121122
MissingOverride The method 'getInstance()' is missing an @Override annotation. 3 133143
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 134
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 136
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 148
MissingOverride The method 'incarnate()' is missing an @Override annotation. 3 148164
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 157163
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 159160
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 169
MissingOverride The method 'reconfigure()' is missing an @Override annotation. 3 169
MissingOverride The method 'decommision()' is missing an @Override annotation. 3 174178
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 174
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 176
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 177
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 183195
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 185
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 186
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 187
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 188
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 189
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 190
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 191
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 192
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 193
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 194
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 200
MissingOverride The method 'setLogger(Logger)' is missing an @Override annotation. 3 200203
MissingOverride The method 'setContext(Context)' is missing an @Override annotation. 3 208211
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 208
MissingOverride The method 'setServiceManager(ServiceManager)' is missing an @Override annotation. 3 216219
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 216
MissingOverride The method 'setConfiguration(Configuration)' is missing an @Override annotation. 3 224227
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 224
MissingOverride The method 'setParameters(Parameters)' is missing an @Override annotation. 3 232235
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 3 232
MissingOverride The method 'getName()' is missing an @Override annotation. 3 252255
MissingOverride The method 'getRoleEntry()' is missing an @Override annotation. 3 260263
MissingOverride The method 'getShorthand()' is missing an @Override annotation. 3 324327
MissingOverride The method 'toString()' is missing an @Override annotation. 3 336343
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 3 338
UselessParentheses Useless parentheses. 4 350
ConfusingTernary Avoid if (x != y) ..; else ..; 3 350
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 369
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 377
MethodArgumentCouldBeFinal Parameter 'useProxy' is not assigned and could be declared final 3 386
ControlStatementBraces This statement should have braces 3 389
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 389
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 3 389
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 3 391
ControlStatementBraces This statement should have braces 3 391
MethodArgumentCouldBeFinal Parameter 'proxy' is not assigned and could be declared final 3 397

org/apache/fulcrum/yaafi/framework/component/ServiceComponentLifecycle.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 49
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 55
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 61
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 72

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolver.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_PROPERTIES_VALUE 3 35
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 44

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolverBaseImpl.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 43203
AtLeastOneConstructor Each class should declare at least one constructor 3 43203
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
MissingOverride The method 'enableLogging(Logger)' is missing an @Override annotation. 3 5962
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 68
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 6871
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 77
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 7780
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 107
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 109
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 126
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 135
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 3 137
MethodArgumentCouldBeFinal Parameter 'properties' is not assigned and could be declared final 3 146
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 176
MethodArgumentCouldBeFinal Parameter 'fileLocation' is not assigned and could be declared final 3 176
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 178
ShortVariable Avoid variables with short names like is 3 179
CloseResource Ensure that resources like this InputStream object are closed after use 3 179
ConfusingTernary Avoid if (x != y) ..; else ..; 3 183192
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '187'-'202'). 5 187202
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 187
UnusedAssignment The value assigned to variable 'is' is never used 3 187
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 196
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 198

org/apache/fulcrum/yaafi/framework/configuration/ComponentConfigurationPropertiesResolverImpl.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3556
MethodArgumentCouldBeFinal Parameter 'defaults' is not assigned and could be declared final 3 41
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 41
MissingOverride The method 'resolve(Properties)' is missing an @Override annotation. 3 4155
LocalVariableCouldBeFinal Local variable 'location' could be declared final 3 43
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 44
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 51

org/apache/fulcrum/yaafi/framework/constant/AvalonFortressConstants.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_FORTESS 3 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 38
LongVariable Avoid excessively long variable names like FORTRESS_COMPONENT_ID 3 38
LongVariable Avoid excessively long variable names like FORTRESS_COMPONENT_LOGGER 3 41
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 41
LongVariable Avoid excessively long variable names like FORTRESS_CONTEXT_ROOT 3 44
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 44
LongVariable Avoid excessively long variable names like FORTRESS_IMPL_WORKDIR 3 47
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 47

org/apache/fulcrum/yaafi/framework/constant/AvalonMerlinConstants.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 31
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_MERLIN 3 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 38
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 41
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 44
LongVariable Avoid excessively long variable names like URN_AVALON_PARTITION 3 47
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 47
LongVariable Avoid excessively long variable names like URN_AVALON_CLASSLOADER 3 50
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 50

org/apache/fulcrum/yaafi/framework/constant/AvalonPhoenixConstants.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 31
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_PHOENIX 3 31
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 38
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 41
LongVariable Avoid excessively long variable names like PHOENIX_BLOCK_NAME 3 41
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 44

org/apache/fulcrum/yaafi/framework/constant/AvalonYaafiConstants.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like AVALON_CONTAINER_YAAFI 3 32
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 32
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 39
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 42
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 45
LongVariable Avoid excessively long variable names like URN_AVALON_PARTITION 3 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 48
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 51
LongVariable Avoid excessively long variable names like URN_AVALON_CLASSLOADER 3 51
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 58
LongVariable Avoid excessively long variable names like COMPONENT_APP_ROOT 3 58

org/apache/fulcrum/yaafi/framework/container/ServiceConstants.java

Rule Violation Priority Line
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 33
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 36
LongVariable Avoid excessively long variable names like CONTAINERFLAVOUR_CONFIG_KEY 3 43
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 43
LongVariable Avoid excessively long variable names like CONTAINERCLAZZNAME_CONFIG_KEY 3 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 46
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 49
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_KEY 3 49
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 52
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_PROPERTIES_KEY 3 52
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 55
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_KEYS 3 55
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_KEY 3 58
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 58
LongVariable Avoid excessively long variable names like COMPONENT_ISENCRYPTED_KEY 3 61
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 61
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 64
LongVariable Avoid excessively long variable names like COMPONENT_LOCATION_KEY 3 64
LongVariable Avoid excessively long variable names like DYNAMICPROXY_ENABLED_KEY 3 67
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 67
LongVariable Avoid excessively long variable names like INTERCEPTOR_LIST_KEY 3 70
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 70
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 73
LongVariable Avoid excessively long variable names like RECONFIGURATION_DELAY_KEY 3 76
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 76
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 79
LongVariable Avoid excessively long variable names like DISPOSAL_DELAY_KEY 3 79
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 82
LongVariable Avoid excessively long variable names like SERVICEMANAGER_LIST_KEY 3 82
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 85
LongVariable Avoid excessively long variable names like SERVICEMANAGER_KEY 3 85
LongVariable Avoid excessively long variable names like COMPONENT_CONFIG_VALUE 3 92
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 92
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 95
LongVariable Avoid excessively long variable names like COMPONENT_ROLE_VALUE 3 95
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 98
LongVariable Avoid excessively long variable names like COMPONENT_PARAMETERS_VALUE 3 98
LongVariable Avoid excessively long variable names like COMPONENT_CONTAINERFLAVOUR_VALUE 3 101
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 101
LongVariable Avoid excessively long variable names like COMPONENT_ROLECONFIGFLAVOUR_VALUE 3 104
ConstantsInInterface Avoid constants in interfaces. Interfaces define types, constants are implementation details better placed in classes or enums. See Effective Java, item 19. 3 104

org/apache/fulcrum/yaafi/framework/container/ServiceContainerImpl.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 11413
StdCyclomaticComplexity The class 'ServiceContainerImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 3 661413
GodClass Possible God Class (WMC=152, ATFD=87, TCC=0.950%) 3 661413
TooManyFields Too many fields 3 661413
TooManyMethods This class has too many methods, consider refactoring it. 3 661413
ExcessiveClassLength Avoid really long classes. 3 661413
CyclomaticComplexity The class 'ServiceContainerImpl' has a total cyclomatic complexity of 152 (highest 17). 3 661413
ModifiedCyclomaticComplexity The class 'ServiceContainerImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 3 661413
LongVariable Avoid excessively long variable names like DISPOSAL_DELAY_DEFAULT 3 68
LongVariable Avoid excessively long variable names like RECONFIGURATION_DELAY_DEFAULT 3 71
LongVariable Avoid excessively long variable names like componentRolesLocation 3 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 74
AvoidFieldNameMatchingMethodName Field isComponentRolesEncrypted has the same name as a method 3 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 77
LinguisticNaming Linguistics Antipattern - The field 'isComponentRolesEncrypted' indicates linguistically it is a boolean, but it is 'String' 3 77
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 3 77
LongVariable Avoid excessively long variable names like componentRolesFlavour 3 80
LongVariable Avoid excessively long variable names like componentConfigurationLocation 3 83
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 83
LinguisticNaming Linguistics Antipattern - The field 'isComponentConfigurationEncrypted' indicates linguistically it is a boolean, but it is 'String' 3 86
AvoidFieldNameMatchingMethodName Field isComponentConfigurationEncrypted has the same name as a method 3 86
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 3 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 86
LongVariable Avoid excessively long variable names like parametersLocation 3 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 89
AvoidFieldNameMatchingMethodName Field isParametersEncrypted has the same name as a method 3 92
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 92
LongVariable Avoid excessively long variable names like isParametersEncrypted 3 92
LinguisticNaming Linguistics Antipattern - The field 'isParametersEncrypted' indicates linguistically it is a boolean, but it is 'String' 3 92
LongVariable Avoid excessively long variable names like applicationRootDir 3 95
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 101
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 101
LongVariable Avoid excessively long variable names like parentServiceManager 3 104
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 104
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 110
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 110
ImmutableField Private field 'serviceMap' could be made final; it is only initialized in the declaration or constructor. 3 110
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 113
LongVariable Avoid excessively long variable names like serviceConfiguration 3 116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 116
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 119
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 122
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 125
AvoidFieldNameMatchingMethodName Field isAlreadyDisposed has the same name as a method 3 128
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 128
AvoidFieldNameMatchingMethodName Field isCurrentlyDisposing has the same name as a method 3 131
LongVariable Avoid excessively long variable names like isCurrentlyDisposing 3 131
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 131
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 131
LongVariable Avoid excessively long variable names like reconfigurationDelay 3 140
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 140
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 143
AvoidFieldNameMatchingMethodName Field hasDynamicProxies has the same name as a method 3 146
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 146
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 149
LongVariable Avoid excessively long variable names like defaultInterceptorServiceList 3 149
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 149
LongVariable Avoid excessively long variable names like fallbackServiceManagerList 3 152
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 152
LongVariable Avoid excessively long variable names like componentConfigurationPropertiesResolverConfig 3 157
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 157
AvoidDuplicateLiterals The String literal "false" appears 6 times in this file; the first occurrence is on line 176 3 176
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 183
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 184
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 189
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 190
MissingOverride The method 'enableLogging(Logger)' is missing an @Override annotation. 3 199202
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 199
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 207211
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 207
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 216
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 3 216218
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 223336
ExcessiveMethodLength Avoid really long methods. 3 223336
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 223
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 228229
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 233
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 237
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 242
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 3 252253
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 253
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 261
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 263
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 265
LongVariable Avoid excessively long variable names like currComponentRoles 3 270
LocalVariableCouldBeFinal Local variable 'currComponentRoles' could be declared final 3 270
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 273
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 273
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 276
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 278
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 278
LongVariable Avoid excessively long variable names like currComponentConfiguration 3 282
LocalVariableCouldBeFinal Local variable 'currComponentConfiguration' could be declared final 3 282
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 285
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 285
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 288
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 288
LocalVariableCouldBeFinal Local variable 'currParameters' could be declared final 3 296
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 299
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 299
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 301
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 301
LongVariable Avoid excessively long variable names like currInterceptorList 3 305
LocalVariableCouldBeFinal Local variable 'currInterceptorList' could be declared final 3 305
LocalVariableCouldBeFinal Local variable 'interceptorConfigList' could be declared final 3 307
LongVariable Avoid excessively long variable names like interceptorConfigList 3 307
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 307
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 309317
LocalVariableCouldBeFinal Local variable 'interceptorServiceName' could be declared final 3 310
LongVariable Avoid excessively long variable names like interceptorServiceName 3 310
LocalVariableCouldBeFinal Local variable 'currServiceManagerList' could be declared final 3 323
LongVariable Avoid excessively long variable names like currServiceManagerList 3 323
LongVariable Avoid excessively long variable names like serviceManagerConfigList 3 325
LocalVariableCouldBeFinal Local variable 'serviceManagerConfigList' could be declared final 3 325
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 325
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 327335
LocalVariableCouldBeFinal Local variable 'serviceManagerName' could be declared final 3 328
LongVariable Avoid excessively long variable names like serviceManagerName 3 328
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 3 341
MissingOverride The method 'parameterize(Parameters)' is missing an @Override annotation. 3 341343
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 348
MissingOverride The method 'initialize()' is missing an @Override annotation. 3 348417
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 362
LongVariable Avoid excessively long variable names like componentConfigurationProperties 3 372
LocalVariableCouldBeFinal Local variable 'componentConfigurationProperties' could be declared final 3 372
LocalVariableCouldBeFinal Local variable 'currServiceList' could be declared final 3 387
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 3 394
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 395
LongVariable Avoid excessively long variable names like currServiceManagerName 3 401
LocalVariableCouldBeFinal Local variable 'currServiceManagerName' could be declared final 3 401
UnnecessaryCast Avoid unnecessary casts 3 401
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 403
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 424469
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 453
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 454
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 455
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 456
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 457
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 458
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 459
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 460
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 461
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 478
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 478524
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 478524
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'exceptionCounter' (lines '481'-'513'). 5 481513
LongVariable Avoid excessively long variable names like componentConfigurationProperties 3 494
LocalVariableCouldBeFinal Local variable 'componentConfigurationProperties' could be declared final 3 494
LocalVariableCouldBeFinal Local variable 'serviceComponentConfiguration' could be declared final 3 504505
LongVariable Avoid excessively long variable names like serviceComponentConfiguration 3 504
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 510514
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 511
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'exceptionCounter' (lines '513'-'513'). 5 513
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 520
MissingOverride The method 'getRoleEntry(String)' is missing an @Override annotation. 3 533535
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 533535
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 533
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 540551
MissingOverride The method 'getRoleEntries()' is missing an @Override annotation. 3 540551
LocalVariableCouldBeFinal Local variable 'serviceList' could be declared final 3 542
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 543
UnnecessaryCast Avoid unnecessary casts 3 546
MethodArgumentCouldBeFinal Parameter 'names' is not assigned and could be declared final 3 556
MissingOverride The method 'reconfigure(String)' is missing an @Override annotation. 3 556570
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 556
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 556570
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 562569
MissingOverride The method 'hasService(String)' is missing an @Override annotation. 3 575598
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 575
AvoidDuplicateLiterals The String literal "name" appears 7 times in this file; the first occurrence is on line 576 3 576
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 578
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 581
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 589590
ControlStatementBraces This statement should have braces 3 590
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 594595
ControlStatementBraces This statement should have braces 3 595
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 610
ModifiedCyclomaticComplexity The method 'lookup' has a Modified Cyclomatic Complexity of 10. 3 610670
CyclomaticComplexity The method 'lookup(String)' has a cyclomatic complexity of 17. 3 610670
NPathComplexity The method 'lookup(String)' has an NPath complexity of 200, current threshold is 200 3 610670
StdCyclomaticComplexity The method 'lookup' has a Standard Cyclomatic Complexity of 10. 3 610670
MissingOverride The method 'lookup(String)' is missing an @Override annotation. 3 610670
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 613
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '613'-'628'). 5 613628
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '613'-'670'). 5 613670
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 614
LongVariable Avoid excessively long variable names like serviceManagerComponent 3 614
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 617
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 631
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '638'-'670'). 5 638670
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 642
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 645649
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 646
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 656
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 664
MissingOverride The method 'release(Object)' is missing an @Override annotation. 3 675678
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 675
MissingOverride The method 'decommission(String)' is missing an @Override annotation. 3 683687
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 683687
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 683
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 3 685
MissingOverride The method 'getParameters()' is missing an @Override annotation. 3 692694
MissingOverride The method 'toString()' is missing an @Override annotation. 3 703719
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 3 704
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 737
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 3 739
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 746
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 749753
IdenticalCatchBranches 'catch' branch identical to 'ConfigurationException' branch 3 749753
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 750
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 763
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 765
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 768
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 782
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 784
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'result' 3 785
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 795
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 795
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '799'-'810'). 5 799810
LongVariable Avoid excessively long variable names like serviceManagerComponent 3 800
LocalVariableCouldBeFinal Local variable 'serviceManagerComponentName' could be declared final 3 803
UnnecessaryCast Avoid unnecessary casts 3 803
LongVariable Avoid excessively long variable names like serviceManagerComponentName 3 803
LocalVariableCouldBeFinal Local variable 'currServiceManager' could be declared final 3 807
LongVariable Avoid excessively long variable names like currServiceManager 3 807
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 809
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 810
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 3 812816
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 813814
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 830
LongVariable Avoid excessively long variable names like serviceManagerComponent 3 833
UnnecessaryCast Avoid unnecessary casts 3 836
LocalVariableCouldBeFinal Local variable 'serviceManagerComponentName' could be declared final 3 836
LongVariable Avoid excessively long variable names like serviceManagerComponentName 3 836
LongVariable Avoid excessively long variable names like currServiceManager 3 840
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 844
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 845
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 847
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 848
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 850
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 850
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 861
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 868
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 875
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 3 889
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 3 899
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 899
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 3 925
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 925
LocalVariableCouldBeFinal Local variable 'mapper' could be declared final 3 930931
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 931
LocalVariableCouldBeFinal Local variable 'roleEntry' could be declared final 3 933
LocalVariableCouldBeFinal Local variable 'componentFlavour' could be declared final 3 934
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 934
LongVariable Avoid excessively long variable names like serviceComponentContext 3 936
LocalVariableCouldBeFinal Local variable 'serviceComponentContext' could be declared final 3 936
LongVariable Avoid excessively long variable names like serviceComponentLogger 3 940
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 940
LocalVariableCouldBeFinal Local variable 'serviceComponentLogger' could be declared final 3 940
LongVariable Avoid excessively long variable names like serviceComponentConfiguration 3 942
LocalVariableCouldBeFinal Local variable 'serviceComponentConfiguration' could be declared final 3 942
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 942
LocalVariableCouldBeFinal Local variable 'serviceComponentParameters' could be declared final 3 944
LongVariable Avoid excessively long variable names like serviceComponentParameters 3 944
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 956
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 966
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 3 966
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 3 977
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 3 979
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 3 993
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 9981001
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 999
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 3 1009
LocalVariableCouldBeFinal Local variable 'serviceComponent' could be declared final 3 1011
MethodArgumentCouldBeFinal Parameter 'serviceComponent' is not assigned and could be declared final 3 1021
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 10261029
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 1027
MethodArgumentCouldBeFinal Parameter 'list' is not assigned and could be declared final 3 1050
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 3 1063
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 1063
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 1068
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 1068
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceComponent' (lines '1,069'-'1,097'). 5 10691097
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceComponent' (lines '1,069'-'1,109'). 5 10691109
LocalVariableCouldBeFinal Local variable 'roleConfigurationParser' could be declared final 3 1073
LongVariable Avoid excessively long variable names like roleConfigurationParser 3 1073
LocalVariableCouldBeFinal Local variable 'roleEntryList' could be declared final 3 1077
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1077
LongVariable Avoid excessively long variable names like defaultInterceptorList 3 1081
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'defaultInterceptorList' (lines '1,081'-'1,109'). 5 10811109
LocalVariableCouldBeFinal Local variable 'defaultInterceptorList' could be declared final 3 1081
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 10851106
LocalVariableCouldBeFinal Local variable 'roleEntry' could be declared final 3 1089
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1092
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1094
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 1097
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 11001105
ConfusingTernary Avoid if (x != y) ..; else ..; 3 1101
UselessParentheses Useless parentheses. 4 1101
LongVariable Avoid excessively long variable names like serviceComponentName 3 1101
LocalVariableCouldBeFinal Local variable 'serviceComponentName' could be declared final 3 1101
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 1102
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 3 1119
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 1119
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 1119
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1,120'-'1,128'). 5 11201128
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 3 1121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1122
CloseResource Ensure that resources like this InputStream object are closed after use 3 1122
ShortVariable Avoid variables with short names like is 3 1122
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'builder' (lines '1,123'-'1,139'). 5 11231139
LocalVariableCouldBeFinal Local variable 'builder' could be declared final 3 1123
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '1,128'-'1,139'). 5 11281139
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1129
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 1130
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 11521153
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 1156
LocalVariableCouldBeFinal Local variable 'resolverClass' could be declared final 3 1156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1157
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1165
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 1166
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 1182
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 3 1182
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 1182
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 3 1183
ShortVariable Avoid variables with short names like is 3 1184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1184
CloseResource Ensure that resources like this InputStream object are closed after use 3 1184
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1,185'-'1,192'). 5 11851192
LocalVariableCouldBeFinal Local variable 'props' could be declared final 3 1190
MethodArgumentCouldBeFinal Parameter 'dir' is not assigned and could be declared final 3 1216
MethodArgumentCouldBeFinal Parameter 'dir' is not assigned and could be declared final 3 1251
LinguisticNaming Linguistics Antipattern - The method 'isComponentConfigurationEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 3 12711273
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 3 1280
MethodArgumentCouldBeFinal Parameter 'isComponentConfigurationEncrypted' is not assigned and could be declared final 3 1280
LinguisticNaming Linguistics Antipattern - The method 'isComponentRolesEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 3 12871289
MethodArgumentCouldBeFinal Parameter 'isComponentRolesEncrypted' is not assigned and could be declared final 3 1294
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 3 1294
LinguisticNaming Linguistics Antipattern - The method 'isParametersEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 3 13011303
LongVariable Avoid excessively long variable names like isParametersEncrypted 3 1308
MethodArgumentCouldBeFinal Parameter 'isParametersEncrypted' is not assigned and could be declared final 3 1308
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 3 1320
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 1320
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 3 1320
ShortVariable Avoid variables with short names like is 3 1320
MethodArgumentCouldBeFinal Parameter 'containerFlavour' is not assigned and could be declared final 3 1334
MethodArgumentCouldBeFinal Parameter 'componentRolesFlavour' is not assigned and could be declared final 3 1348
LongVariable Avoid excessively long variable names like componentRolesFlavour 3 1348
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 1369
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 1377
ShortVariable Avoid variables with short names like is 3 1404
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 3 1404
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 1408
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1409

org/apache/fulcrum/yaafi/framework/container/ServiceLifecycleManager.java

Rule Violation Priority Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 67

org/apache/fulcrum/yaafi/framework/context/AvalonToYaafiContextMapper.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 43
ImmutableField Private field 'tempRootDir' could be made final; it is only initialized in the declaration or constructor. 3 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
ImmutableField Private field 'defaultContext' could be made final; it is only initialized in the declaration or constructor. 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
ImmutableField Private field 'classLoader' could be made final; it is only initialized in the declaration or constructor. 3 49
MethodArgumentCouldBeFinal Parameter 'tempRootDir' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 3 61
MethodArgumentCouldBeFinal Parameter 'from' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 90
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 96
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 98
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 101
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 103
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 106
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 108
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 110
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 116
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 128
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 131
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 3 133
LongVariable Avoid excessively long variable names like urnAvalonPartition 3 134
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 3 134
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 3 135
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 3 136
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 140
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 142
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 143
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 144
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 144
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 152
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 153
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 155
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 167
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 170
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 3 172
LongVariable Avoid excessively long variable names like urnAvalonPartition 3 172
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 3 173
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 3 174
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 180
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 181
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 182
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 182
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 186
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 186
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 199
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 202
LongVariable Avoid excessively long variable names like urnAvalonPartition 3 204
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 3 204
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 3 205
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 3 206
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 3 207
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 211
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 212
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 213
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 214
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 218
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 218

org/apache/fulcrum/yaafi/framework/context/YaafiToAvalonContextMapper.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
ImmutableField Private field 'urnAvalonName' could be made final; it is only initialized in the declaration or constructor. 3 42
ImmutableField Private field 'urnAvalonClassLoader' could be made final; it is only initialized in the declaration or constructor. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
LongVariable Avoid excessively long variable names like urnAvalonClassLoader 3 45
MethodArgumentCouldBeFinal Parameter 'urnAvalonClassLoader' is not assigned and could be declared final 3 53
LongVariable Avoid excessively long variable names like urnAvalonClassLoader 3 53
MethodArgumentCouldBeFinal Parameter 'urnAvalonName' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'to' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 86
ShortVariable Avoid variables with short names like to 3 86
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 92
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 94
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 97
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 99
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 102
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 104
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 106
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 112
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 124
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 127
LongVariable Avoid excessively long variable names like urnAvalonPartition 3 129
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 3 129
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 3 130
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 3 131
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 133
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 134
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 135
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 147
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 150
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 3 152
LongVariable Avoid excessively long variable names like urnAvalonPartition 3 152
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 3 153
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 3 154
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 3 155
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 157
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 159
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 160
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 173
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 176
LongVariable Avoid excessively long variable names like urnAvalonPartition 3 178
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 3 178
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 3 179
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 3 180
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 3 181
LocalVariableCouldBeFinal Local variable 'urnAvalonClossLoader' could be declared final 3 182
LongVariable Avoid excessively long variable names like urnAvalonClossLoader 3 182
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 186
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 187
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 188
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 200
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 203
LongVariable Avoid excessively long variable names like urnAvalonPartition 3 205
LocalVariableCouldBeFinal Local variable 'urnAvalonPartition' could be declared final 3 205
LocalVariableCouldBeFinal Local variable 'urnAvalonHome' could be declared final 3 206
LocalVariableCouldBeFinal Local variable 'urnAvalonTemp' could be declared final 3 207
LocalVariableCouldBeFinal Local variable 'urnAvalonName' could be declared final 3 208
LongVariable Avoid excessively long variable names like urnAvalonClossLoader 3 209
LocalVariableCouldBeFinal Local variable 'urnAvalonClossLoader' could be declared final 3 209
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 211
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 212
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 213
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 214
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 215
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 216
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 224

org/apache/fulcrum/yaafi/framework/crypto/CryptoStreamFactory.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 35125
AvoidFieldNameMatchingTypeName It is somewhat confusing to have a field name matching the declaring class name 3 40
LongVariable Avoid excessively long variable names like cryptoStreamFactory 3 40
ShortVariable Avoid variables with short names like is 3 53
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 3 53
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 53
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 3 53
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 56
LiteralsFirstInComparisons Position literals first in String comparisons 3 56
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 59
LiteralsFirstInComparisons Position literals first in String comparisons 3 59
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 62
LiteralsFirstInComparisons Position literals first in String comparisons 3 62
LiteralsFirstInComparisons Position literals first in String comparisons 3 65
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 65
ShortVariable Avoid variables with short names like is 3 83
MethodArgumentCouldBeFinal Parameter 'factoryMethodName' is not assigned and could be declared final 3 83
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 3 83
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 83
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'signature' (lines '84'-'94'). 5 8494
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 3 84
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'args' (lines '85'-'94'). 5 8594
LocalVariableCouldBeFinal Local variable 'args' could be declared final 3 85
LongVariable Avoid excessively long variable names like cryptoStreamFactory 3 86
LocalVariableCouldBeFinal Local variable 'cryptoStreamFactory' could be declared final 3 86
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 102116
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 102
LocalVariableCouldBeFinal Local variable 'clazzLoader' could be declared final 3 105
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 105
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 3 108
LocalVariableCouldBeFinal Local variable 'args' could be declared final 3 109
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 3 110
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 122

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerConfiguration.java

Rule Violation Priority Line
TooManyFields Too many fields 3 60674
GodClass Possible God Class (WMC=58, ATFD=55, TCC=3.104%) 3 60674
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 62
LongVariable Avoid excessively long variable names like serviceContainerClazzName 3 62
LongVariable Avoid excessively long variable names like componentRolesLocation 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
AvoidFieldNameMatchingMethodName Field isComponentRolesEncrypted has the same name as a method 3 68
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 3 68
LinguisticNaming Linguistics Antipattern - The field 'isComponentRolesEncrypted' indicates linguistically it is a boolean, but it is 'String' 3 68
LongVariable Avoid excessively long variable names like componentConfigurationLocation 3 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 74
AvoidFieldNameMatchingMethodName Field isComponentConfigurationEncrypted has the same name as a method 3 74
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 3 74
LinguisticNaming Linguistics Antipattern - The field 'isComponentConfigurationEncrypted' indicates linguistically it is a boolean, but it is 'String' 3 74
LongVariable Avoid excessively long variable names like parametersLocation 3 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 80
LongVariable Avoid excessively long variable names like isParametersEncrypted 3 80
AvoidFieldNameMatchingMethodName Field isParametersEncrypted has the same name as a method 3 80
LinguisticNaming Linguistics Antipattern - The field 'isParametersEncrypted' indicates linguistically it is a boolean, but it is 'String' 3 80
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 86
LongVariable Avoid excessively long variable names like applicationRootDir 3 89
LongVariable Avoid excessively long variable names like componentClassLoader 3 95
LongVariable Avoid excessively long variable names like containerConfiguration 3 101
LongVariable Avoid excessively long variable names like parentServiceManager 3 104
LongVariable Avoid excessively long variable names like serviceManagerList 3 107
MethodArgumentCouldBeFinal Parameter 'logLevel' is not assigned and could be declared final 3 119
AvoidDuplicateLiterals The String literal "false" appears 4 times in this file; the first occurrence is on line 124 3 124
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 132
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 141
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 141
MethodArgumentCouldBeFinal Parameter 'hashtable' is not assigned and could be declared final 3 152
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 152
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'name' (lines '155'-'160'). 5 155160
UnusedAssignment The initializer for variable 'name' is never used (overwritten on line 160) 3 155
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'name' (lines '155'-'164'). 5 155164
UnusedAssignment The initializer for variable 'value' is never used (overwritten on line 161) 3 156
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '156'-'161'). 5 156161
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '156'-'164'). 5 156164
LocalVariableCouldBeFinal Local variable 'keys' could be declared final 3 157
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 159
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 182
ExcessiveMethodLength Avoid really long methods. 3 211341
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 219) 3 212
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '212'-'341'). 5 212341
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '212'-'219'). 5 212219
ConfusingTernary Avoid if (x != y) ..; else ..; 3 214340
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 215
LocalVariableCouldBeFinal Local variable 'containerFlavourConfig' could be declared final 3 225226
LongVariable Avoid excessively long variable names like containerFlavourConfig 3 225
LocalVariableCouldBeFinal Local variable 'containerClazzNameConfig' could be declared final 3 236237
LongVariable Avoid excessively long variable names like containerClazzNameConfig 3 236
LocalVariableCouldBeFinal Local variable 'componentRolesConfig' could be declared final 3 250
LongVariable Avoid excessively long variable names like componentRolesConfig 3 250
LocalVariableCouldBeFinal Local variable 'componentRolesLocation' could be declared final 3 252253
LongVariable Avoid excessively long variable names like componentRolesLocation 3 252
LongVariable Avoid excessively long variable names like componentRolesIsEncrypted 3 257
LocalVariableCouldBeFinal Local variable 'componentRolesIsEncrypted' could be declared final 3 257258
LongVariable Avoid excessively long variable names like componentConfigurationConfig 3 274
LocalVariableCouldBeFinal Local variable 'componentConfigurationConfig' could be declared final 3 274275
LongVariable Avoid excessively long variable names like componentConfigurationLocation 3 277
LocalVariableCouldBeFinal Local variable 'componentConfigurationLocation' could be declared final 3 277278
LocalVariableCouldBeFinal Local variable 'componentConfigurationIsEncrypted' could be declared final 3 282283
LongVariable Avoid excessively long variable names like componentConfigurationIsEncrypted 3 282
LongVariable Avoid excessively long variable names like parameterConfigurationConfig 3 299
LocalVariableCouldBeFinal Local variable 'parameterConfigurationConfig' could be declared final 3 299300
LongVariable Avoid excessively long variable names like parameterConfigurationLocation 3 302
LocalVariableCouldBeFinal Local variable 'parameterConfigurationLocation' could be declared final 3 302303
LongVariable Avoid excessively long variable names like parameterConfigurationIsEncrypted 3 307
LocalVariableCouldBeFinal Local variable 'parameterConfigurationIsEncrypted' could be declared final 3 307308
LongVariable Avoid excessively long variable names like serviceManagerListConfig 3 324
LocalVariableCouldBeFinal Local variable 'serviceManagerListConfig' could be declared final 3 324325
LongVariable Avoid excessively long variable names like serviceManagerConfig 3 328
LocalVariableCouldBeFinal Local variable 'serviceManagerConfig' could be declared final 3 328329
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 328329
MethodArgumentCouldBeFinal Parameter 'componentConfigurationLocation' is not assigned and could be declared final 3 365
LongVariable Avoid excessively long variable names like componentConfigurationLocation 3 365
LongVariable Avoid excessively long variable names like componentRolesLocation 3 380
MethodArgumentCouldBeFinal Parameter 'componentRolesLocation' is not assigned and could be declared final 3 380
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 394
LinguisticNaming Linguistics Antipattern - The method 'isComponentConfigurationEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 3 405407
LongVariable Avoid excessively long variable names like isComponentConfigurationEncrypted 3 414
MethodArgumentCouldBeFinal Parameter 'isComponentConfigurationEncrypted' is not assigned and could be declared final 3 414
LinguisticNaming Linguistics Antipattern - The method 'isComponentRolesEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 3 421423
LongVariable Avoid excessively long variable names like isComponentRolesEncrypted 3 428
MethodArgumentCouldBeFinal Parameter 'isComponentRolesEncrypted' is not assigned and could be declared final 3 428
LinguisticNaming Linguistics Antipattern - The method 'isParametersEncrypted' indicates linguistically it returns a boolean, but it returns 'String' 3 435437
LongVariable Avoid excessively long variable names like isParametersEncrypted 3 442
MethodArgumentCouldBeFinal Parameter 'isParametersEncrypted' is not assigned and could be declared final 3 442
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 457
MethodArgumentCouldBeFinal Parameter 'parametersLocation' is not assigned and could be declared final 3 471
LongVariable Avoid excessively long variable names like parametersLocation 3 471
LongVariable Avoid excessively long variable names like applicationRootDir 3 485
MethodArgumentCouldBeFinal Parameter 'applicationRootDir' is not assigned and could be declared final 3 485
PositionLiteralsFirstInComparisons Position literals first in String comparisons 3 488
LiteralsFirstInComparisons Position literals first in String comparisons 3 488
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 500
MethodArgumentCouldBeFinal Parameter 'tempRootDir' is not assigned and could be declared final 3 507
LongVariable Avoid excessively long variable names like componentClassLoader 3 522
MethodArgumentCouldBeFinal Parameter 'componentClassLoader' is not assigned and could be declared final 3 522
MethodArgumentCouldBeFinal Parameter 'containerFlavour' is not assigned and could be declared final 3 537
MethodArgumentCouldBeFinal Parameter 'containerConfiguration' is not assigned and could be declared final 3 551
LongVariable Avoid excessively long variable names like containerConfiguration 3 551
LongVariable Avoid excessively long variable names like parentServiceManager 3 572
MethodArgumentCouldBeFinal Parameter 'parentServiceManager' is not assigned and could be declared final 3 572
MethodReturnsInternalArray Returning 'serviceManagerList' may expose an internal array. 3 582
ArrayIsStoredDirectly The user-supplied array 'serviceManagerList' is stored directly. 3 591
MethodArgumentCouldBeFinal Parameter 'serviceManagerList' is not assigned and could be declared final 3 591
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 591
LongVariable Avoid excessively long variable names like serviceManagerList 3 591
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 599600
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 599600
ControlStatementBraces This statement should have braces 3 600
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 600
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 613
MethodArgumentCouldBeFinal Parameter 'isEncrypted' is not assigned and could be declared final 3 627
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 627
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '628'-'638'). 5 628638
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 638) 3 628
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '628'-'650'). 5 628650
LocalVariableCouldBeFinal Local variable 'locator' could be declared final 3 630
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'builder' (lines '632'-'650'). 5 632650
LocalVariableCouldBeFinal Local variable 'builder' could be declared final 3 632
CloseResource Ensure that resources like this InputStream object are closed after use 3 633
ShortVariable Avoid variables with short names like is 3 633
ConfusingTernary Avoid if (x != y) ..; else ..; 3 635649
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 640
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 641
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 643
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 646
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 659
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 3 659
MethodArgumentCouldBeFinal Parameter 'baseDir' is not assigned and could be declared final 3 659
ConfusingTernary Avoid if (x != y) ..; else ..; 3 661669
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 668

org/apache/fulcrum/yaafi/framework/factory/ServiceContainerFactory.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 38184
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 40
MethodArgumentCouldBeFinal Parameter 'serviceManagerConfig' is not assigned and could be declared final 3 50
LongVariable Avoid excessively long variable names like serviceManagerConfig 3 50
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 51
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'serviceManagerConfig' is not assigned and could be declared final 3 67
LongVariable Avoid excessively long variable names like serviceManagerConfig 3 67
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 67
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 68
UnusedAssignment The initializer for variable 'clazz' is never used (overwritten on line 98) 3 74
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'clazz' (lines '74'-'98'). 5 7498
UnusedAssignment The initializer for variable 'configuration' is never used (overwritten on line 88) 3 75
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'configuration' (lines '75'-'88'). 5 7588
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '76'-'106'). 5 76106
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 106) 3 76
GuardLogStatement Logger calls should be surrounded by log level guards. 2 9496
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 9496
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98100
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98100
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 102104
GuardLogStatement Logger calls should be surrounded by log level guards. 2 102104
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '106'-'134'). 5 106134
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 108
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 111
LocalVariableCouldBeFinal Local variable 'serviceContainerLogger' could be declared final 3 115
LongVariable Avoid excessively long variable names like serviceContainerLogger 3 115
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 117120
GuardLogStatement Logger calls should be surrounded by log level guards. 2 117120
MethodArgumentCouldBeFinal Parameter 'container' is not assigned and could be declared final 3 142
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 151
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 153159
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 155
SystemPrintln System.err.println is used 2 156
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 157
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 168
LongVariable Avoid excessively long variable names like containerClazzNameConfig 3 170
LocalVariableCouldBeFinal Local variable 'containerClazzNameConfig' could be declared final 3 170172
ConfusingTernary Avoid if (x != y) ..; else ..; 3 174181
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 176

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorContextImpl.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like INVOCATIONDEPTH_KEY 3 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
ImmutableField Private field 'serviceName' could be made final; it is only initialized in the declaration or constructor. 3 51
ImmutableField Private field 'serviceShorthand' could be made final; it is only initialized in the declaration or constructor. 3 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
ImmutableField Private field 'serviceDelegate' could be made final; it is only initialized in the declaration or constructor. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 3 60
ImmutableField Private field 'args' could be made final; it is only initialized in the declaration or constructor. 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 66
ImmutableField Private field 'requestContext' could be made final; it is only initialized in the declaration or constructor. 3 66
RedundantFieldInitializer Avoid using redundant field initializer for 'invocationCounter' 3 72
AvoidUsingVolatile Use of modifier volatile is not recommended. 2 72
ImmutableField Private field 'invocationId' could be made final; it is only initialized in the declaration or constructor. 3 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 75
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 87
ArrayIsStoredDirectly The user-supplied array 'args' is stored directly. 3 87
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'serviceShorthand' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'serviceDelegate' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 87
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 87
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 100
MissingOverride The method 'getRequestContext()' is missing an @Override annotation. 3 106109
MissingOverride The method 'getServiceDelegate()' is missing an @Override annotation. 3 114117
MissingOverride The method 'getServiceName()' is missing an @Override annotation. 3 122125
MissingOverride The method 'getServiceShorthand()' is missing an @Override annotation. 3 130133
MissingOverride The method 'getArgs()' is missing an @Override annotation. 3 138141
MethodReturnsInternalArray Returning 'args' may expose an internal array. 3 140
MissingOverride The method 'getMethod()' is missing an @Override annotation. 3 146149
MissingOverride The method 'getThreadContext()' is missing an @Override annotation. 3 154157
MissingOverride The method 'hasTransactionId()' is missing an @Override annotation. 3 162165
UselessParentheses Useless parentheses. 4 164
ConfusingTernary Avoid if (x != y) ..; else ..; 3 164
MissingOverride The method 'getTransactionId()' is missing an @Override annotation. 3 170173
MethodArgumentCouldBeFinal Parameter 'transactionId' is not assigned and could be declared final 3 179
MissingOverride The method 'setTransactionId(Object)' is missing an @Override annotation. 3 179182
MissingOverride The method 'clearTransactionId()' is missing an @Override annotation. 3 187190
MissingOverride The method 'incrementInvocationDepth()' is missing an @Override annotation. 3 195208
LocalVariableCouldBeFinal Local variable 'invocationDepth' could be declared final 3 197
ConfusingTernary Avoid if (x != y) ..; else ..; 3 199207
LongVariable Avoid excessively long variable names like currInvocationDepth 3 201
MissingOverride The method 'decrementInvocationDepth()' is missing an @Override annotation. 3 213222
LocalVariableCouldBeFinal Local variable 'invocationDepth' could be declared final 3 215
LongVariable Avoid excessively long variable names like currInvocationDepth 3 219
MissingOverride The method 'getInvocationDepth()' is missing an @Override annotation. 3 228240
LocalVariableCouldBeFinal Local variable 'invocationDepth' could be declared final 3 230
ConfusingTernary Avoid if (x != y) ..; else ..; 3 232239
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 234
MissingOverride The method 'getInvocationId()' is missing an @Override annotation. 3 245248
MissingOverride The method 'toString()' is missing an @Override annotation. 3 253268
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 3 255

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorFactory.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 40127
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'serviceShorthand' is not assigned and could be declared final 3 54
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 55
LongVariable Avoid excessively long variable names like serviceInterceptorList 3 56
MethodArgumentCouldBeFinal Parameter 'serviceInterceptorList' is not assigned and could be declared final 3 56
MethodArgumentCouldBeFinal Parameter 'serviceDelegate' is not assigned and could be declared final 3 57
LocalVariableCouldBeFinal Local variable 'clazz' could be declared final 3 68
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 69
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 3 69
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 69
LocalVariableCouldBeFinal Local variable 'interfaceList' could be declared final 3 70
LongVariable Avoid excessively long variable names like avalonInterceptorServices 3 74
LocalVariableCouldBeFinal Local variable 'avalonInterceptorServices' could be declared final 3 7477
LocalVariableCouldBeFinal Local variable 'invocationHandler' could be declared final 3 7984
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 88
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 88
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 103
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 103
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 3 103
LongVariable Avoid excessively long variable names like interceptorServiceName 3 106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '107'-'116'). 5 107116
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '107'-'126'). 5 107126
LocalVariableCouldBeFinal Local variable 'currService' could be declared final 3 112
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '116'-'116'). 5 116
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '116'-'126'). 5 116126
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 120

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorInvocationHandler.java

Rule Violation Priority Line
DataClass The class 'AvalonInterceptorInvocationHandler' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=5, WMC=21) 3 37261
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 40
ImmutableField Private field 'serviceName' could be made final; it is only initialized in the declaration or constructor. 3 40
ImmutableField Private field 'serviceShorthand' could be made final; it is only initialized in the declaration or constructor. 3 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 43
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
ImmutableField Private field 'serviceDelegate' could be made final; it is only initialized in the declaration or constructor. 3 46
LongVariable Avoid excessively long variable names like serviceInterceptorList 3 49
ImmutableField Private field 'serviceInterceptorList' could be made final; it is only initialized in the declaration or constructor. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
LongVariable Avoid excessively long variable names like transactionCounter 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'serviceShorthand' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'serviceDelegate' is not assigned and could be declared final 3 68
ArrayIsStoredDirectly The user-supplied array 'serviceInterceptorList' is stored directly. 3 69
MethodArgumentCouldBeFinal Parameter 'serviceInterceptorList' is not assigned and could be declared final 3 69
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 69
LongVariable Avoid excessively long variable names like serviceInterceptorList 3 69
MethodReturnsInternalArray Returning 'serviceInterceptorList' may expose an internal array. 3 95
MissingOverride The method 'toString()' is missing an @Override annotation. 3 125135
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 3 127
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 140
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 140
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 140
MethodArgumentCouldBeFinal Parameter 'proxy' is not assigned and could be declared final 3 140
MissingOverride The method 'invoke(Object, Method, Object)' is missing an @Override annotation. 3 140190
LocalVariableCouldBeFinal Local variable 'context' could be declared final 3 147153
LongVariable Avoid excessively long variable names like hasCreatedTransaction 3 157
LocalVariableCouldBeFinal Local variable 'hasCreatedTransaction' could be declared final 3 157
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'hasCreatedTransaction' (lines '157'-'190'). 5 157190
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 172176
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 197
LongVariable Avoid excessively long variable names like avalonInterceptorService 3 201
LocalVariableCouldBeFinal Local variable 'avalonInterceptorService' could be declared final 3 201
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 202
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 3 212
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 212
LocalVariableCouldBeFinal Local variable 'avalonInterceptorService' could be declared final 3 216
LongVariable Avoid excessively long variable names like avalonInterceptorService 3 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 217
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 227
ShortVariable Avoid variables with short names like t 3 227
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 227
LocalVariableCouldBeFinal Local variable 'avalonInterceptorService' could be declared final 3 231
LongVariable Avoid excessively long variable names like avalonInterceptorService 3 231
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 232
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 241
LongVariable Avoid excessively long variable names like currentTransactionId 3 243
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 256

org/apache/fulcrum/yaafi/framework/interceptor/AvalonInterceptorService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 45
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 53
ShortVariable Avoid variables with short names like t 3 61
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 61

org/apache/fulcrum/yaafi/framework/logger/Log4j2Logger.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 34
FieldNamingConventions The final field name 'm_logger' doesn't match '[a-z][a-zA-Z0-9]*' 1 34

org/apache/fulcrum/yaafi/framework/reflection/Clazz.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Clazz' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 1 35174
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 36174
MethodArgumentCouldBeFinal Parameter 'clazzName' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 3 44
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 49
MethodArgumentCouldBeFinal Parameter 'classLoader' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'clazzName' is not assigned and could be declared final 3 64
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 81
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 3 81
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 81
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 81
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '84'-'86'). 5 8486
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 86) 3 84
LocalVariableCouldBeFinal Local variable 'constructor' could be declared final 3 85
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 86
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 101
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 101
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 3 101
MethodArgumentCouldBeFinal Parameter 'methodName' is not assigned and could be declared final 3 101
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 3 101
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 106) 3 104
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '104'-'106'). 5 104106
LocalVariableCouldBeFinal Local variable 'method' could be declared final 3 105
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 106
MethodArgumentCouldBeFinal Parameter 'args' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'signature' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'methodName' is not assigned and could be declared final 3 122
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 122
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 122
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 127) 3 125
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '125'-'127'). 5 125127
LocalVariableCouldBeFinal Local variable 'method' could be declared final 3 126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 127
CognitiveComplexity The method 'getAllInterfaces(Class)' has a cognitive complexity of 15, current threshold is 15 3 144173
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 148
LocalVariableCouldBeFinal Local variable 'list' could be declared final 3 150
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 150
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 3 153
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 154169
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 156
LocalVariableCouldBeFinal Local variable 'superInterfaces' could be declared final 3 160
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 161
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 161
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 161168
LocalVariableCouldBeFinal Local variable 'intface' could be declared final 3 163
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 164
AvoidReassigningParameters Avoid reassigning parameters such as 'cls' 2 170

org/apache/fulcrum/yaafi/framework/role/RoleConfigurationParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'parse': the method is declared in an interface type 3 4041

org/apache/fulcrum/yaafi/framework/role/RoleConfigurationParserImpl.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 39
ImmutableField Private field 'containerFlavour' could be made final; it is only initialized in the declaration or constructor. 3 39
MethodArgumentCouldBeFinal Parameter 'containerFlavour' is not assigned and could be declared final 3 46
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 3 58
MissingOverride The method 'parse(Configuration)' is missing an @Override annotation. 3 5875
AvoidDuplicateLiterals The String literal "roleConfiguration" appears 4 times in this file; the first occurrence is on line 59 3 59
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 61
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 62
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 65
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 66
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 68
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 72
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 3 84
UnusedAssignment The initializer for variable 'clazzName' is never used (overwritten on line 104) 3 87
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'clazzName' (lines '87'-'104'). 5 87104
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'clazzName' (lines '87'-'132'). 5 87132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'name' (lines '88'-'132'). 5 88132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'name' (lines '88'-'105'). 5 88105
UnusedAssignment The initializer for variable 'name' is never used (overwritten on line 105) 3 88
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'shorthand' (lines '89'-'132'). 5 89132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'shorthand' (lines '89'-'106'). 5 89106
UnusedAssignment The initializer for variable 'shorthand' is never used (overwritten on line 106) 3 89
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isEarlyInit' (lines '90'-'132'). 5 90132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'isEarlyInit' (lines '90'-'107'). 5 90107
UnusedAssignment The initializer for variable 'isEarlyInit' is never used (overwritten on line 107) 3 90
UnusedAssignment The initializer for variable 'description' is never used (overwritten on line 108) 3 91
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'description' (lines '91'-'132'). 5 91132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'description' (lines '91'-'108'). 5 91108
UnusedAssignment The initializer for variable 'componentType' is never used (overwritten on line 109) 3 92
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'componentType' (lines '92'-'109'). 5 92109
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'componentType' (lines '92'-'132'). 5 92132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'componentFlavour' (lines '93'-'132'). 5 93132
UnusedAssignment The initializer for variable 'componentFlavour' is never used (overwritten on line 110) 3 93
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'componentFlavour' (lines '93'-'110'). 5 93110
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasProxy' (lines '94'-'111'). 5 94111
UnusedAssignment The initializer for variable 'hasProxy' is never used (overwritten on line 111) 3 94
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'hasProxy' (lines '94'-'132'). 5 94132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'interceptorList' (lines '95'-'132'). 5 95132
UnusedAssignment The initializer for variable 'interceptorList' is never used (overwritten on line 116) 3 95
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'interceptorList' (lines '95'-'116'). 5 95116
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'logCategory' (lines '96'-'112'). 5 96112
UnusedAssignment The initializer for variable 'logCategory' is never used (overwritten on line 112) 3 96
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'logCategory' (lines '96'-'132'). 5 96132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleEntry' (lines '97'-'132'). 5 97132
UnusedAssignment The initializer for variable 'roleEntry' is never used (overwritten on line 125) 3 97
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'roleEntry' (lines '97'-'125'). 5 97125
LocalVariableCouldBeFinal Local variable 'list' could be declared final 3 99
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '100'-'128'). 5 100128
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'roleIndex' (lines '102'-'132'). 5 102132
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 103
LocalVariableCouldBeFinal Local variable 'interceptorConfigList' could be declared final 3 115
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 115
LongVariable Avoid excessively long variable names like interceptorConfigList 3 115
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 116
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 116
LocalVariableCouldBeFinal Local variable 'interceptorConfigEntry' could be declared final 3 118
LongVariable Avoid excessively long variable names like interceptorConfigEntry 3 118
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 125126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '128'-'128'). 5 128
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 3 134
MethodArgumentCouldBeFinal Parameter 'roleConfiguration' is not assigned and could be declared final 3 139

org/apache/fulcrum/yaafi/framework/role/RoleEntry.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setHasDynamicProxy': the method is declared in an interface type 3 74
UnnecessaryModifier Unnecessary modifier 'public' on method 'addInterceptors': the method is declared in an interface type 3 81

org/apache/fulcrum/yaafi/framework/role/RoleEntryImpl.java

Rule Violation Priority Line
DataClass The class 'RoleEntryImpl' is suspected to be a Data Class (WOC=26.667%, NOPA=0, NOAM=10, WMC=19) 3 35241
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 37
ImmutableField Private field 'name' could be made final; it is only initialized in the declaration or constructor. 3 37
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 40
LongVariable Avoid excessively long variable names like implementationClazzName 3 40
ImmutableField Private field 'implementationClazzName' could be made final; it is only initialized in the declaration or constructor. 3 40
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 43
ImmutableField Private field 'shorthand' could be made final; it is only initialized in the declaration or constructor. 3 43
AvoidFieldNameMatchingMethodName Field isEarlyInit has the same name as a method 3 46
ImmutableField Private field 'isEarlyInit' could be made final; it is only initialized in the declaration or constructor. 3 46
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 46
ImmutableField Private field 'description' could be made final; it is only initialized in the declaration or constructor. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
ImmutableField Private field 'componentType' could be made final; it is only initialized in the declaration or constructor. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
ImmutableField Private field 'componentFlavour' could be made final; it is only initialized in the declaration or constructor. 3 57
AvoidFieldNameMatchingMethodName Field hasDynamicProxy has the same name as a method 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 63
ImmutableField Private field 'interceptorList' could be made final; it is only initialized in the declaration or constructor. 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
ImmutableField Private field 'logCategory' could be made final; it is only initialized in the declaration or constructor. 3 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 66
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'shorthand' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'defaultClass' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'description' is not assigned and could be declared final 3 85
ExcessiveParameterList Avoid long parameter lists. 3 8587
MethodArgumentCouldBeFinal Parameter 'earlyInit' is not assigned and could be declared final 3 85
MethodArgumentCouldBeFinal Parameter 'hasProxy' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'componentType' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 3 86
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 3 86
MethodArgumentCouldBeFinal Parameter 'componentFlavour' is not assigned and could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'logCategory' is not assigned and could be declared final 3 87
MissingOverride The method 'getComponentType()' is missing an @Override annotation. 3 111113
MissingOverride The method 'getDescription()' is missing an @Override annotation. 3 118120
MissingOverride The method 'getImplementationClazzName()' is missing an @Override annotation. 3 125127
MissingOverride The method 'isEarlyInit()' is missing an @Override annotation. 3 132134
MissingOverride The method 'getName()' is missing an @Override annotation. 3 139141
MissingOverride The method 'getShorthand()' is missing an @Override annotation. 3 146148
MissingOverride The method 'getComponentFlavour()' is missing an @Override annotation. 3 153155
MissingOverride The method 'hasDynamicProxy()' is missing an @Override annotation. 3 160162
MethodArgumentCouldBeFinal Parameter 'hasProxy' is not assigned and could be declared final 3 167
MissingOverride The method 'setHasDynamicProxy(boolean)' is missing an @Override annotation. 3 167169
MethodArgumentCouldBeFinal Parameter 'interceptorName' is not assigned and could be declared final 3 177
UnusedAssignment The initializer for variable 'currInterceptorName' is never used (overwritten on line 182) 3 178
LongVariable Avoid excessively long variable names like currInterceptorName 3 178
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currInterceptorName' (lines '178'-'190'). 5 178190
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currInterceptorName' (lines '178'-'182'). 5 178182
LocalVariableCouldBeFinal Local variable 'iterator' could be declared final 3 179
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 185
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 197
MissingOverride The method 'addInterceptors(Collection)' is missing an @Override annotation. 3 197208
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currInterceptorName' (lines '198'-'208'). 5 198208
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currInterceptorName' (lines '198'-'202'). 5 198202
LongVariable Avoid excessively long variable names like currInterceptorName 3 198
UnusedAssignment The initializer for variable 'currInterceptorName' is never used (overwritten on line 202) 3 198
LocalVariableCouldBeFinal Local variable 'iterator' could be declared final 3 199
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 204
MissingOverride The method 'getInterceptorList()' is missing an @Override annotation. 3 213215
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 3 214
MissingOverride The method 'getLogCategory()' is missing an @Override annotation. 3 220222
MissingOverride The method 'toString()' is missing an @Override annotation. 3 227240
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 3 228

org/apache/fulcrum/yaafi/framework/tls/ThreadLocalStorage.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'get': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 3 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'containsKey': the method is declared in an interface type 3 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'clear': the method is declared in an interface type 3 68

org/apache/fulcrum/yaafi/framework/tls/ThreadLocalStorageImpl.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 34101
ImmutableField Private field 'local' could be made final; it is only initialized in the declaration or constructor. 3 39
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 39
MissingOverride The method 'initialValue()' is missing an @Override annotation. 3 4860
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 56
LocalVariableCouldBeFinal Local variable 'map' could be declared final 3 56
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 56
LocalVariableCouldBeFinal Local variable 'map' could be declared final 3 71
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'map' 3 72
MissingOverride The method 'get(String)' is missing an @Override annotation. 3 7579
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 75
LocalVariableCouldBeFinal Local variable 'map' could be declared final 3 77
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 78
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 81
MissingOverride The method 'put(String, Object)' is missing an @Override annotation. 3 8185
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 81
LocalVariableCouldBeFinal Local variable 'map' could be declared final 3 83
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 84
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 87
MissingOverride The method 'containsKey(String)' is missing an @Override annotation. 3 8791
LocalVariableCouldBeFinal Local variable 'map' could be declared final 3 89
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 90
MissingOverride The method 'clear()' is missing an @Override annotation. 3 93100
LocalVariableCouldBeFinal Local variable 'map' could be declared final 3 95

org/apache/fulcrum/yaafi/framework/util/ConfigurationUtil.java

Rule Violation Priority Line
ModifiedCyclomaticComplexity The class 'ConfigurationUtil' has a Modified Cyclomatic Complexity of 9 (Highest = 10). 3 33200
StdCyclomaticComplexity The class 'ConfigurationUtil' has a Standard Cyclomatic Complexity of 9 (Highest = 10). 3 33200
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 34200
MethodArgumentCouldBeFinal Parameter 'vars' is not assigned and could be declared final 3 46
LongVariable Avoid excessively long variable names like defaultConfiguration 3 46
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 46
MethodArgumentCouldBeFinal Parameter 'defaultConfiguration' is not assigned and could be declared final 3 46
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 48
LocalVariableCouldBeFinal Local variable 'oldValue' could be declared final 3 57
LocalVariableCouldBeFinal Local variable 'newValue' could be declared final 3 58
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 61
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 61
GuardLogStatement Logger calls should be surrounded by log level guards. 2 6370
UnusedAssignment The initializer for variable 'attributeName' is never used (overwritten on line 81) 3 76
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'attributeName' (lines '76'-'107'). 5 76107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'attributeName' (lines '76'-'81'). 5 7681
LocalVariableCouldBeFinal Local variable 'attributeNames' could be declared final 3 77
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 7997
LocalVariableCouldBeFinal Local variable 'oldAttributeValue' could be declared final 3 82
LocalVariableCouldBeFinal Local variable 'newAttributeValue' could be declared final 3 83
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 86
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 86
GuardLogStatement Logger calls should be surrounded by log level guards. 2 8895
LocalVariableCouldBeFinal Local variable 'children' could be declared final 3 101
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 103106
UselessParentheses Useless parentheses. 4 105
CognitiveComplexity The method 'expand(String, Map)' has a cognitive complexity of 39, current threshold is 15 3 122199
ModifiedCyclomaticComplexity The method 'expand' has a Modified Cyclomatic Complexity of 10. 3 122199
CyclomaticComplexity The method 'expand(String, Map)' has a cyclomatic complexity of 12. 3 122199
MethodArgumentCouldBeFinal Parameter 'argStr' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'vars' is not assigned and could be declared final 3 122
StdCyclomaticComplexity The method 'expand' has a Standard Cyclomatic Complexity of 10. 3 122199
LocalVariableCouldBeFinal Local variable 'isLenient' could be declared final 3 125
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isLenient' (lines '125'-'199'). 5 125199
LocalVariableCouldBeFinal Local variable 'argBuf' could be declared final 3 127
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'argBuf' (lines '127'-'199'). 5 127199
LocalVariableCouldBeFinal Local variable 'argStrLength' could be declared final 3 128
ShortVariable Avoid variables with short names like ch 3 132
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'del' (lines '133'-'199'). 5 133199
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'del' (lines '133'-'139'). 5 133139
UnusedAssignment The initializer for variable 'del' is never used (overwritten on line 139) 3 133
TooFewBranchesForASwitchStatement A switch with less than three branches is inefficient, use a if statement instead. 3 135195
SwitchDensity A high ratio of statements to labels in a switch statement. Consider refactoring. 3 135195
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'nameBuf' (lines '138'-'199'). 5 138199
LocalVariableCouldBeFinal Local variable 'nameBuf' could be declared final 3 138
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 138
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 140
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 3 142
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 3 144
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 3 144
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 147150
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 3 148
ControlStatementBraces This statement should have braces 3 148
ControlStatementBraces This statement should have braces 3 150
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 3 150
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 155
ConfusingTernary Avoid if (x != y) ..; else ..; 3 157171
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 159
ConfusingTernary Avoid if (x != y) ..; else ..; 3 163170
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 165
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 169
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 175
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 177
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 3 181
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'cIdx' (lines '181'-'199'). 5 181199
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 3 186
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'cIdx' 3 193

org/apache/fulcrum/yaafi/framework/util/ExceptionUtils.java

Rule Violation Priority Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 3156
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 3740
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 3 49
LocalVariableCouldBeFinal Local variable 'sw' could be declared final 3 51
ShortVariable Avoid variables with short names like sw 3 51
LocalVariableCouldBeFinal Local variable 'pw' could be declared final 3 52
ShortVariable Avoid variables with short names like pw 3 52
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 54

org/apache/fulcrum/yaafi/framework/util/InputStreamLocator.java

Rule Violation Priority Line
ModifiedCyclomaticComplexity The class 'InputStreamLocator' has a Modified Cyclomatic Complexity of 3 (Highest = 11). 3 36152
StdCyclomaticComplexity The class 'InputStreamLocator' has a Standard Cyclomatic Complexity of 3 (Highest = 11). 3 36152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 39
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 42
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 42
MethodArgumentCouldBeFinal Parameter 'rootDir' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 67
MethodArgumentCouldBeFinal Parameter 'rootDir' is not assigned and could be declared final 3 67
NPathComplexity The method 'locate(String)' has an NPath complexity of 1152, current threshold is 200 3 79143
StdCyclomaticComplexity The method 'locate' has a Standard Cyclomatic Complexity of 11. 3 79143
ModifiedCyclomaticComplexity The method 'locate' has a Modified Cyclomatic Complexity of 11. 3 79143
CognitiveComplexity The method 'locate(String)' has a cognitive complexity of 18, current threshold is 15 3 79143
CyclomaticComplexity The method 'locate(String)' has a cyclomatic complexity of 15. 3 79143
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 79
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 81
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'baseName' (lines '84'-'130'). 5 84130
UnusedAssignment The initializer for variable 'baseName' is never used (overwritten on line 130) 3 84
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'baseName' (lines '84'-'143'). 5 84143
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'file' (lines '85'-'104'). 5 85104
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'file' (lines '85'-'143'). 5 85143
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'file' (lines '85'-'91'). 5 8591
UnusedAssignment The initializer for variable 'file' is never used (overwritten on lines 91 and 104) 3 85
ShortVariable Avoid variables with short names like is 3 86
AvoidDuplicateLiterals The String literal "Looking for " appears 4 times in this file; the first occurrence is on line 93 3 93
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 96
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 109
CloseResource 'is' is reassigned, but the original instance is not closed 3 109
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 116
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 116
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 118
SimplifyStartsWith This call to String.startsWith can be rewritten using String.charAt(0) 3 129
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 129
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 132

org/apache/fulcrum/yaafi/framework/util/ToStringBuilder.java

Rule Violation Priority Line
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 34
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 34
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 36
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 37
LongVariable Avoid excessively long variable names like INCLUDE_PACKAGE_PREFIX 3 41
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 57
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 5960
ControlStatementBraces This statement should have braces 3 60
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 66
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 68
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 76
LocalVariableCouldBeFinal Local variable 'lastdotx' could be declared final 3 76
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 78
MethodArgumentCouldBeFinal Parameter 'i' is not assigned and could be declared final 3 86
ShortVariable Avoid variables with short names like i 3 86
MissingOverride The method 'toString()' is missing an @Override annotation. 3 95105
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 9798
ControlStatementBraces This statement should have braces 3 98
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 100
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 102
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 3 112
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 112
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 3 117
AvoidUsingShortType Do not use the short type 1 117
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 117
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 122
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 3 127
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 127
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 132
MethodArgumentCouldBeFinal Parameter 'attributeName' is not assigned and could be declared final 3 132
AssignmentInOperand Avoid assignments in operands 3 134
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 3 135
ControlStatementBraces This statement should have braces 3 135
ControlStatementBraces This statement should have braces 3 138
IfElseStmtsMustUseBraces Avoid using if...else statements without curly braces 3 138

org/apache/fulcrum/yaafi/framework/util/Validate.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Validate' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 1 45609
GodClass Possible God Class (WMC=76, ATFD=12, TCC=0.000%) 3 45609
TooManyMethods This class has too many methods, consider refactoring it. 3 46609
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 46609
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5052
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 3 78
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 78
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 80
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 106
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 3 106
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 106
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 108
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 3 135
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 137
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 164
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 3 164
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 166
MethodArgumentCouldBeFinal Parameter 'expression' is not assigned and could be declared final 3 190
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 192
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 215
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 215
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 236
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 259
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 259
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 280
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 280
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 303
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 303
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 305
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 324
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 326
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 348
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 3 348
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 350
MethodArgumentCouldBeFinal Parameter 'map' is not assigned and could be declared final 3 369
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 371
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 392
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 392
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 394395
ControlStatementBraces This statement should have braces 3 395
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 411
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 413414
ControlStatementBraces This statement should have braces 3 414
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 437
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 437
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 440446
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 467
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 467
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 501
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 501
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 504510
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 504
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 530
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '533'-'534'). 5 533534
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '533'-'543'). 5 533543
ShortVariable Avoid variables with short names like i 3 533
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 534
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '534'-'543'). 5 534543
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '534'-'534'). 5 534
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 534542
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 559
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 559
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 560
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 564570
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 564
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 566
MethodArgumentCouldBeFinal Parameter 'clazz' is not assigned and could be declared final 3 593
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 593
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '597'-'598'). 5 597598
ShortVariable Avoid variables with short names like i 3 597
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '597'-'608'). 5 597608
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '598'-'608'). 5 598608
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 598
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 598607
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '598'-'598'). 5 598
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 600

org/apache/fulcrum/yaafi/interceptor/baseservice/BaseInterceptorServiceImpl.java

Rule Violation Priority Line
ImmutableField Private field 'serviceSet' could be made final; it is only initialized in the declaration or constructor. 3 51
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 3 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 54
AvoidFieldNameMatchingMethodName Field isEnabled has the same name as a method 3 54
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
LongVariable Avoid excessively long variable names like serviceApplicationDir 3 63
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 66
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 69
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7982
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 81
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 87
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 8793
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 98
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 98131
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 103
LocalVariableCouldBeFinal Local variable 'serviceConfigList' could be declared final 3 107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 115129
LocalVariableCouldBeFinal Local variable 'name' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'shorthand' could be declared final 3 118
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 136
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 136139
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 148
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 3 148
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 3 148151
ShortVariable Avoid variables with short names like t 3 156
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 156
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 3 156
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 156
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 3 156159
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 3 164
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 164
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 3 164167
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 3 164
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 3 187
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 187
ConfusingTernary Avoid if (x != y) ..; else ..; 3 189208
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 191
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 195
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 199
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 201208
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 203
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 258
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 262
LooseCoupling Avoid using implementation types like 'HashSet'; use the interface instead 3 273

org/apache/fulcrum/yaafi/interceptor/jamon/Jamon1PerformanceMonitorImpl.java

Rule Violation Priority Line
ImmutableField Private field 'isActive' could be made final; it is only initialized in the declaration or constructor. 3 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 53
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 53
UnusedFormalParameter Avoid unused constructor parameters such as 'serviceName'. 3 53
MissingOverride The method 'start()' is missing an @Override annotation. 3 6169
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 3 65
LongVariable Avoid excessively long variable names like methodToStringBuilder 3 65
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 3 66
MissingOverride The method 'stop()' is missing an @Override annotation. 3 7480
MissingOverride The method 'stop(Throwable)' is missing an @Override annotation. 3 8588
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 3 85
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 93
MissingOverride The method 'createReport()' is missing an @Override annotation. 3 9396
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 95

org/apache/fulcrum/yaafi/interceptor/jamon/Jamon2PerformanceMonitorImpl.java

Rule Violation Priority Line
ImmutableField Private field 'isActive' could be made final; it is only initialized in the declaration or constructor. 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 3 73
UnusedFormalParameter Avoid unused constructor parameters such as 'serviceName'. 3 73
MissingOverride The method 'start()' is missing an @Override annotation. 3 8295
LongVariable Avoid excessively long variable names like methodToStringBuilder 3 90
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 3 90
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 3 91
MissingOverride The method 'stop()' is missing an @Override annotation. 3 100108
LocalVariableCouldBeFinal Local variable 'duration' could be declared final 3 104
MissingOverride The method 'stop(Throwable)' is missing an @Override annotation. 3 113121
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 3 113
MissingOverride The method 'createReport()' is missing an @Override annotation. 3 129132
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 129
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 131
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 138
UseUnderscoresInNumericLiterals Number 10240 should separate every third digit with an underscore 3 150
UseUnderscoresInNumericLiterals Number 20480 should separate every third digit with an underscore 3 151

org/apache/fulcrum/yaafi/interceptor/jamon/JamonInterceptorServiceImpl.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 47299
AvoidFieldNameMatchingMethodName Field isJamonAvailable has the same name as a method 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
LongVariable Avoid excessively long variable names like nextReportTimestamp 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
LongVariable Avoid excessively long variable names like performanceMonitorClassName 3 64
LongVariable Avoid excessively long variable names like performanceMonitorClass 3 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 67
LongVariable Avoid excessively long variable names like MONITORFACTORY_CLASSNAME 3 70
LongVariable Avoid excessively long variable names like DEFAULT_PERFORMANCEMONITOR_CLASSNAME 3 73
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 8284
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 89106
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 91
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 9495
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98
LocalVariableCouldBeFinal Local variable 'reportFileName' could be declared final 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105
MissingOverride The method 'initialize()' is missing an @Override annotation. 3 111142
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 111
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 3 112
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 112
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 115
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 118
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 122
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 125
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 129
LocalVariableCouldBeFinal Local variable 'testMonitor' could be declared final 3 132
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 134
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 147
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 147150
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 155161
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 160
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 3 170182
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 170
LongVariable Avoid excessively long variable names like interceptorContext 3 170
LocalVariableCouldBeFinal Local variable 'serviceShortHand' could be declared final 3 174
LocalVariableCouldBeFinal Local variable 'serviceMethod' could be declared final 3 175
LocalVariableCouldBeFinal Local variable 'isEnabled' could be declared final 3 176
LocalVariableCouldBeFinal Local variable 'monitor' could be declared final 3 177178
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 179
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 180
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 3 188
LongVariable Avoid excessively long variable names like interceptorContext 3 188
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 3 188194
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 188
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 191
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 192
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 200
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 3 200206
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 200
LongVariable Avoid excessively long variable names like interceptorContext 3 200
ShortVariable Avoid variables with short names like t 3 200
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 203
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 204
MissingOverride The method 'run()' is missing an @Override annotation. 3 213215
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 237
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 237
MethodArgumentCouldBeFinal Parameter 'isEnabled' is not assigned and could be declared final 3 238
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '239'-'244'). 5 239244
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 3 242
LocalVariableCouldBeFinal Local variable 'args' could be declared final 3 243
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 245
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 246
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 247
LocalVariableCouldBeFinal Local variable 'currTimestamp' could be declared final 3 258
MethodArgumentCouldBeFinal Parameter 'reportFile' is not assigned and could be declared final 3 272
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'printWriter' (lines '273'-'283'). 5 273283
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'printWriter' (lines '273'-'298'). 5 273298
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 3 276296
ShortVariable Avoid variables with short names like w 3 282
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 282
CloseResource Ensure that resources like this FileOutputStream object are closed after use 3 282
LocalVariableCouldBeFinal Local variable 'w' could be declared final 3 282
LocalVariableCouldBeFinal Local variable 'monitor' could be declared final 3 285
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 286
LocalVariableCouldBeFinal Local variable 'report' could be declared final 3 286
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 289292
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 290

org/apache/fulcrum/yaafi/interceptor/jamon/JamonPerformanceMonitor.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 47

org/apache/fulcrum/yaafi/interceptor/javasimon/JavaSimon4PerformanceMonitorImpl.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 45
ImmutableField Private field 'isActive' could be made final; it is only initialized in the declaration or constructor. 3 45
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 48
ImmutableField Private field 'method' could be made final; it is only initialized in the declaration or constructor. 3 48
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 51
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'isActive' is not assigned and could be declared final 3 60
UnusedFormalParameter Avoid unused constructor parameters such as 'serviceName'. 3 60
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 60
MissingOverride The method 'start()' is missing an @Override annotation. 3 6977
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 3 73
LocalVariableCouldBeFinal Local variable 'stopwatch' could be declared final 3 74
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
MissingOverride The method 'stop()' is missing an @Override annotation. 3 8288
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 3 93
MissingOverride The method 'stop(Throwable)' is missing an @Override annotation. 3 9399
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 104
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 104
LongVariable Avoid excessively long variable names like methodToStringBuilder 3 106
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 3 106
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107

org/apache/fulcrum/yaafi/interceptor/javasimon/JavaSimonInterceptorServiceImpl.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 48304
LongVariable Avoid excessively long variable names like isJavaSimonAvailable 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
AvoidFieldNameMatchingMethodName Field isJavaSimonAvailable has the same name as a method 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
LongVariable Avoid excessively long variable names like nextReportTimestamp 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
LongVariable Avoid excessively long variable names like performanceMonitorClassName 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
LongVariable Avoid excessively long variable names like performanceMonitorClass 3 68
LongVariable Avoid excessively long variable names like MONITORFACTORY_CLASSNAME 3 71
LongVariable Avoid excessively long variable names like DEFAULT_PERFORMANCEMONITOR_CLASSNAME 3 74
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 8385
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 90
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 90107
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 92
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 9596
LocalVariableCouldBeFinal Local variable 'reportFileName' could be declared final 3 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 99
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 106
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 112
MissingOverride The method 'initialize()' is missing an @Override annotation. 3 112143
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 3 113
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 113
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 116
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 119
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 123
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 126
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 130
LocalVariableCouldBeFinal Local variable 'testMonitor' could be declared final 3 133
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 135
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 148
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 148151
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 156162
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 161
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 3 171183
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 171
LongVariable Avoid excessively long variable names like interceptorContext 3 171
LocalVariableCouldBeFinal Local variable 'serviceShortHand' could be declared final 3 175
LocalVariableCouldBeFinal Local variable 'serviceMethod' could be declared final 3 176
LocalVariableCouldBeFinal Local variable 'isEnabled' could be declared final 3 177
LocalVariableCouldBeFinal Local variable 'monitor' could be declared final 3 178179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 180
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 181
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 3 189196
LongVariable Avoid excessively long variable names like interceptorContext 3 189
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 3 189
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 189
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 192193
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 194
LongVariable Avoid excessively long variable names like interceptorContext 3 202
ShortVariable Avoid variables with short names like t 3 202
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 202
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 3 202209
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 202
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 205206
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 207
MissingOverride The method 'run()' is missing an @Override annotation. 3 216218
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 241
MethodArgumentCouldBeFinal Parameter 'serviceName' is not assigned and could be declared final 3 241
MethodArgumentCouldBeFinal Parameter 'isEnabled' is not assigned and could be declared final 3 242
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '243'-'248'). 5 243248
LocalVariableCouldBeFinal Local variable 'signature' could be declared final 3 246
LocalVariableCouldBeFinal Local variable 'args' could be declared final 3 247
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 249
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 250
LocalVariableCouldBeFinal Local variable 'currTimestamp' could be declared final 3 262
MethodArgumentCouldBeFinal Parameter 'reportFile' is not assigned and could be declared final 3 276
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'printWriter' (lines '277'-'287'). 5 277287
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'printWriter' (lines '277'-'303'). 5 277303
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 3 280301
ShortVariable Avoid variables with short names like w 3 286
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 286
CloseResource Ensure that resources like this FileOutputStream object are closed after use 3 286
LocalVariableCouldBeFinal Local variable 'w' could be declared final 3 286
LocalVariableCouldBeFinal Local variable 'report' could be declared final 3 291
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 294297
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 295

org/apache/fulcrum/yaafi/interceptor/logging/LoggingInterceptorServiceImpl.java

Rule Violation Priority Line
TooManyMethods This class has too many methods, consider refactoring it. 3 45340
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
LongVariable Avoid excessively long variable names like toStringBuilderClassName 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
LongVariable Avoid excessively long variable names like monitorAllExceptions 3 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
LongVariable Avoid excessively long variable names like toStringBuilderClass 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 62
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 79
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 7986
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 8384
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 85
MissingOverride The method 'initialize()' is missing an @Override annotation. 3 91105
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 91
LocalVariableCouldBeFinal Local variable 'classLoader' could be declared final 3 94
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 3 94
LongVariable Avoid excessively long variable names like interceptorToStringBuilder 3 102
LocalVariableCouldBeFinal Local variable 'interceptorToStringBuilder' could be declared final 3 102
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 110
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 110113
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 127
LongVariable Avoid excessively long variable names like interceptorContext 3 127
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 3 127133
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 128
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 129
LongVariable Avoid excessively long variable names like interceptorContext 3 138
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 3 138146
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 138
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 138
ShortVariable Avoid variables with short names like t 3 138
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 3 141
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 142
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 143
LongVariable Avoid excessively long variable names like interceptorContext 3 151
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 3 151
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 3 151158
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 151
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 152
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 3 153
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 154
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 155
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 169
LongVariable Avoid excessively long variable names like interceptorContext 3 169
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 3 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 172
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 181
LongVariable Avoid excessively long variable names like interceptorContext 3 181
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 182
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 226
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '227'-'230'). 5 227230
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 230 and 234) 3 227
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '230'-'234'). 5 230234
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 231
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 232
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 3 252
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 3 252
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 252
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 3 252
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 3 253
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 3 254
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 256
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 257
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 258
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 259
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 260
MethodArgumentCouldBeFinal Parameter 'avalonInterceptorContext' is not assigned and could be declared final 3 273
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 3 273
LongVariable Avoid excessively long variable names like avalonInterceptorContext 3 273
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 3 274
LocalVariableCouldBeFinal Local variable 'methodSignature' could be declared final 3 275
LocalVariableCouldBeFinal Local variable 'toStringBuilder' could be declared final 3 276
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 278
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 279
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 280
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 280
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 281
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 295
LongVariable Avoid excessively long variable names like interceptorContext 3 295
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 3 295
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 295
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 296
LocalVariableCouldBeFinal Local variable 'method' could be declared final 3 297
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '299'-'330'). 5 299330
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '299'-'339'). 5 299339
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 330) 3 299
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 3 300
LongVariable Avoid excessively long variable names like methodToStringBuilder 3 300
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'args' (lines '303'-'339'). 5 303339
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 306
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 307
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 308
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 309
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 310
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 311
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 312
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 313
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 314
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 315
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 316
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 316
ConfusingTernary Avoid if (x != y) ..; else ..; 3 319323
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 325
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 332
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 334

org/apache/fulcrum/yaafi/interceptor/performance/PerformanceInterceptorServiceImpl.java

Rule Violation Priority Line
ModifiedCyclomaticComplexity The class 'PerformanceInterceptorServiceImpl' has a Modified Cyclomatic Complexity of 2 (Highest = 10). 3 41268
StdCyclomaticComplexity The class 'PerformanceInterceptorServiceImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 10). 3 41268
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 7383
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 73
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 76
LocalVariableCouldBeFinal Local variable 'tresholdConfiguration' could be declared final 3 77
LongVariable Avoid excessively long variable names like tresholdConfiguration 3 77
AvoidDuplicateLiterals The String literal "millis" appears 5 times in this file; the first occurrence is on line 78 3 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 78
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 78
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 79
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 79
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 80
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 81
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 81
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 82
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 8891
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 88
LongVariable Avoid excessively long variable names like interceptorContext 3 105
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 105
MissingOverride The method 'onEntry(AvalonInterceptorContext)' is missing an @Override annotation. 3 105109
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 119
ShortVariable Avoid variables with short names like t 3 119
MissingOverride The method 'onError(AvalonInterceptorContext, Throwable)' is missing an @Override annotation. 3 119125
MethodArgumentCouldBeFinal Parameter 't' is not assigned and could be declared final 3 119
LongVariable Avoid excessively long variable names like interceptorContext 3 119
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 3 121
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 122
LongVariable Avoid excessively long variable names like interceptorContext 3 135
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 135
MissingOverride The method 'onExit(AvalonInterceptorContext, Object)' is missing an @Override annotation. 3 135141
MethodArgumentCouldBeFinal Parameter 'result' is not assigned and could be declared final 3 135
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 3 137
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 138
LongVariable Avoid excessively long variable names like interceptorContext 3 152
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 152
LocalVariableCouldBeFinal Local variable 'stopWatch' could be declared final 3 153
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 155
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 164
LongVariable Avoid excessively long variable names like interceptorContext 3 164
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 165
LongVariable Avoid excessively long variable names like interceptorContext 3 175
ModifiedCyclomaticComplexity The method 'log' has a Modified Cyclomatic Complexity of 10. 3 175203
CognitiveComplexity The method 'log(int, AvalonInterceptorContext, StopWatch)' has a cognitive complexity of 17, current threshold is 15 3 175203
StdCyclomaticComplexity The method 'log' has a Standard Cyclomatic Complexity of 10. 3 175203
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 175
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 3 175
CyclomaticComplexity The method 'log(int, AvalonInterceptorContext, StopWatch)' has a cyclomatic complexity of 11. 3 175203
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 175
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'181'). 5 176181
UnusedAssignment The initializer for variable 'msg' is never used (overwritten on lines 181, 186, 191, 196 and 200) 3 176
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'191'). 5 176191
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'msg' (lines '176'-'203'). 5 176203
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'200'). 5 176200
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'196'). 5 176196
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'msg' (lines '176'-'186'). 5 176186
LocalVariableCouldBeFinal Local variable 'time' could be declared final 3 177
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 199
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 213
LongVariable Avoid excessively long variable names like interceptorContext 3 213
MethodArgumentCouldBeFinal Parameter 'stopWatch' is not assigned and could be declared final 3 213
MethodArgumentCouldBeFinal Parameter 'interceptorContext' is not assigned and could be declared final 3 213
LocalVariableCouldBeFinal Local variable 'method' could be declared final 3 214
LocalVariableCouldBeFinal Local variable 'args' could be declared final 3 215
LongVariable Avoid excessively long variable names like methodToStringBuilder 3 216
LocalVariableCouldBeFinal Local variable 'methodToStringBuilder' could be declared final 3 216
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 217
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 219
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 220
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 221
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 222
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 223
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 224
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 225
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 226
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 227
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 228
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 229
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 229
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 230
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 231
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 232
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 233
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 234
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 246
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 247
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '248'-'255'). 5 248255
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 255) 3 248
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '248'-'266'). 5 248266
AvoidReassigningParameters Avoid reassigning parameters such as 'args' 2 251
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 255
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 256
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 258

org/apache/fulcrum/yaafi/interceptor/util/ArgumentToStringBuilderImpl.java

Rule Violation Priority Line
CyclomaticComplexity The class 'ArgumentToStringBuilderImpl' has a total cyclomatic complexity of 121 (highest 29). 3 351035
ExcessiveClassLength Avoid really long classes. 3 351035
ModifiedCyclomaticComplexity The class 'ArgumentToStringBuilderImpl' has a Modified Cyclomatic Complexity of 4 (Highest = 29). 3 351035
StdCyclomaticComplexity The class 'ArgumentToStringBuilderImpl' has a Standard Cyclomatic Complexity of 4 (Highest = 29). 3 351035
TooManyMethods This class has too many methods, consider refactoring it. 3 361035
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 3 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 99
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 3 99
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 3 114
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 114
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 114
MissingOverride The method 'setMaxArgLength(int)' is missing an @Override annotation. 3 125128
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 3 125
MissingOverride The method 'setTarget(Object)' is missing an @Override annotation. 3 133136
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 133
MissingOverride The method 'setMode(int)' is missing an @Override annotation. 3 141144
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 141
StdCyclomaticComplexity The method 'toString' has a Standard Cyclomatic Complexity of 16. 3 157277
CognitiveComplexity The method 'toString()' has a cognitive complexity of 16, current threshold is 15 3 157277
MissingOverride The method 'toString()' is missing an @Override annotation. 3 157277
ExcessiveMethodLength Avoid really long methods. 3 157277
NcssCount The method 'toString()' has a NCSS line count of 96. 3 157277
ModifiedCyclomaticComplexity The method 'toString' has a Modified Cyclomatic Complexity of 16. 3 157277
CyclomaticComplexity The method 'toString()' has a cyclomatic complexity of 16. 3 157277
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 270274
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 272
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 273
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 3 286
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 292 and 296) 3 288
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '288'-'296'). 5 288296
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '288'-'292'). 5 288292
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 308
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 308
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 310
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '310'-'345'). 5 310345
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '311'-'345'). 5 311345
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '311'-'329'). 5 311329
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 329) 3 311
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 315
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 327
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 329
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 353
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 353
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 355
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '355'-'384'). 5 355384
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 359
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 392
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 392
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '394'-'423'). 5 394423
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 394
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 398
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 431
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 431
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '433'-'462'). 5 433462
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 433
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 437
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 470
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 470
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 472
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '472'-'501'). 5 472501
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 476
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 509
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 509
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 511
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '511'-'540'). 5 511540
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 515
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 548
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 548
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '550'-'579'). 5 550579
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 550
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 554
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 587
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 587
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '589'-'618'). 5 589618
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 589
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 593
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 626
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '628'-'644'). 5 628644
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 628
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 632
MethodArgumentCouldBeFinal Parameter 'array' is not assigned and could be declared final 3 652
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 654
MethodArgumentCouldBeFinal Parameter 'collection' is not assigned and could be declared final 3 675
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'index' (lines '677'-'721'). 5 677721
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 678
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '678'-'721'). 5 678721
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'toStringBuilder' (lines '679'-'700'). 5 679700
UnusedAssignment The initializer for variable 'toStringBuilder' is never used (overwritten on line 700) 3 679
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'toStringBuilder' (lines '679'-'721'). 5 679721
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 683
LocalVariableCouldBeFinal Local variable 'iterator' could be declared final 3 691
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 697
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 700704
MethodArgumentCouldBeFinal Parameter 'dictionary' is not assigned and could be declared final 3 729
LocalVariableCouldBeFinal Local variable 'temp' could be declared final 3 731
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '731'-'747'). 5 731747
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 735
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 755
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '757'-'763'). 5 757763
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '757'-'789'). 5 757789
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 763, 785 and 789) 3 757
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '757'-'785'). 5 757785
UnusedAssignment The initializer for variable 'temp' is never used (overwritten on line 767) 3 758
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'temp' (lines '758'-'767'). 5 758767
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'temp' (lines '758'-'794'). 5 758794
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'className' (lines '759'-'769'). 5 759769
UnusedAssignment The initializer for variable 'className' is never used (overwritten on line 769) 3 759
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'className' (lines '759'-'794'). 5 759794
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 770
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 774
LocalVariableCouldBeFinal Local variable 'hashCode' could be declared final 3 776
LocalVariableCouldBeFinal Local variable 'tempBuffer' could be declared final 3 777
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 778
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 779
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 780
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 781
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 782
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 800
ExcessiveMethodLength Avoid really long methods. 3 818946
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 818
ModifiedCyclomaticComplexity The method 'appendClassName' has a Modified Cyclomatic Complexity of 29. 3 818946
CognitiveComplexity The method 'appendClassName(Object)' has a cognitive complexity of 34, current threshold is 15 3 818946
NcssCount The method 'appendClassName(Object)' has a NCSS line count of 85. 3 818946
StdCyclomaticComplexity The method 'appendClassName' has a Standard Cyclomatic Complexity of 29. 3 818946
CyclomaticComplexity The method 'appendClassName(Object)' has a cyclomatic complexity of 29. 3 818946
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'skipClassName' (lines '820'-'946'). 5 820946
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 820
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'skipClassName' (lines '820'-'929'). 5 820929
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 829
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'className' (lines '829'-'946'). 5 829946
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 932
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 936
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 938
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 938
ShortVariable Avoid variables with short names like ch 3 952
MethodArgumentCouldBeFinal Parameter 'ch' is not assigned and could be declared final 3 952
MethodArgumentCouldBeFinal Parameter 'throwable' is not assigned and could be declared final 3 972
LocalVariableCouldBeFinal Local variable 'sw' could be declared final 3 974
ShortVariable Avoid variables with short names like sw 3 974
ShortVariable Avoid variables with short names like pw 3 975
LocalVariableCouldBeFinal Local variable 'pw' could be declared final 3 975
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 977
MethodArgumentCouldBeFinal Parameter 'source' is not assigned and could be declared final 3 984
LocalVariableCouldBeFinal Local variable 'formattedSource' could be declared final 3 986
MethodArgumentCouldBeFinal Parameter 'source' is not assigned and could be declared final 3 997
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isTruncated' (lines '999'-'1,034'). 5 9991034
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 999
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'isTruncated' (lines '999'-'1,018'). 5 9991018
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 10021003
ControlStatementBraces This statement should have braces 3 1003
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 1003
LocalVariableCouldBeFinal Local variable 'stringBuilder' could be declared final 3 1012

org/apache/fulcrum/yaafi/interceptor/util/DefaultToStringBuilderImpl.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 30
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 48
MissingOverride The method 'setTarget(Object)' is missing an @Override annotation. 3 5659
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 56
MissingOverride The method 'setMaxArgLength(int)' is missing an @Override annotation. 3 6467
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 3 64
MissingOverride The method 'setMode(int)' is missing an @Override annotation. 3 7275
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 72
MissingOverride The method 'toString()' is missing an @Override annotation. 3 80102
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '82'-'92'). 5 8292
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '82'-'88'). 5 8288
UnusedAssignment The initializer for variable 'result' is never used (overwritten on lines 88, 92 and 98) 3 82
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '88'-'98'). 5 8898
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '92'-'98'). 5 9298
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 9599
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 97

org/apache/fulcrum/yaafi/interceptor/util/MethodToStringBuilderImpl.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like INCLUDE_RETURNTYPE 3 32
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 38
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'method' is not assigned and could be declared final 3 71
MethodArgumentCouldBeFinal Parameter 'maxArgLength' is not assigned and could be declared final 3 80
MissingOverride The method 'setMaxArgLength(int)' is missing an @Override annotation. 3 8083
MissingOverride The method 'setMode(int)' is missing an @Override annotation. 3 8891
MethodArgumentCouldBeFinal Parameter 'mode' is not assigned and could be declared final 3 88
MissingOverride The method 'setTarget(Object)' is missing an @Override annotation. 3 9699
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 96
MissingOverride The method 'toString()' is missing an @Override annotation. 3 104148
LocalVariableCouldBeFinal Local variable 'buffer' could be declared final 3 108
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'returnType' (lines '110'-'148'). 5 110148
LocalVariableCouldBeFinal Local variable 'returnType' could be declared final 3 110
LocalVariableCouldBeFinal Local variable 'declaringClass' could be declared final 3 111
LocalVariableCouldBeFinal Local variable 'params' could be declared final 3 112
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 116
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 118
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 124
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 124
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 125
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 126
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 136
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 140
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 142
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 144147
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 146

org/apache/fulcrum/yaafi/interceptor/util/StopWatch.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 84
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 93
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 100102
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 254
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 256
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 260
MissingOverride The method 'toString()' is missing an @Override annotation. 3 284286

org/apache/fulcrum/yaafi/service/advice/AdviceServiceImpl.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 47225
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
LongVariable Avoid excessively long variable names like defaultInterceptorList 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 3 6264
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 62
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 6971
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 69
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 7682
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 76
LocalVariableCouldBeFinal Local variable 'interceptorConfigList' could be declared final 3 77
LongVariable Avoid excessively long variable names like interceptorConfigList 3 77
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 77
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 87
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 8789
MissingOverride The method 'advice(Object)' is missing an @Override annotation. 3 98101
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 98
AvoidDuplicateLiterals The String literal "object" appears 5 times in this file; the first occurrence is on line 99 3 99
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 109
MissingOverride The method 'advice(String, Object)' is missing an @Override annotation. 3 109112
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 109
MissingOverride The method 'advice(String, Object)' is missing an @Override annotation. 3 121125
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 3 121
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 123
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 123
MissingOverride The method 'advice(String, String, Object)' is missing an @Override annotation. 3 133136
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 3 133
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 133
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 133
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 145
MissingOverride The method 'isAdviced(Object)' is missing an @Override annotation. 3 145154
UnusedAssignment The initializer for variable 'invocationHandler' is never used (overwritten on line 149) 3 146
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'invocationHandler' (lines '146'-'149'). 5 146149
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'invocationHandler' (lines '146'-'154'). 5 146154
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 150
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 168
MethodArgumentCouldBeFinal Parameter 'interceptorList' is not assigned and could be declared final 3 168
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 168
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '173'-'201'). 5 173201
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 173
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '173'-'210'). 5 173210
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 201) 3 173
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 174
LocalVariableCouldBeFinal Local variable 'clazzName' could be declared final 3 174
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'clazzName' (lines '174'-'210'). 5 174210
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 174
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 180
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 184
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 191
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 195
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'result' (lines '201'-'210'). 5 201210
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 204
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 206

org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 42344
TooManyMethods This class has too many methods, consider refactoring it. 3 45344
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
LongVariable Avoid excessively long variable names like serviceConfiguration 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
LongVariable Avoid excessively long variable names like serviceApplicationDir 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
LongVariable Avoid excessively long variable names like servicePartitionName 3 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
LongVariable Avoid excessively long variable names like serviceClassLoader 3 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 8083
CallSuperInConstructor It is a good practice to call super() in a constructor 3 8083
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 8896
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 88
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 3 101104
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 101
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 109112
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 109
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 3 117
MissingOverride The method 'parameterize(Parameters)' is missing an @Override annotation. 3 117120
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 125128
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 125
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 133144
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 135
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 136
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 137
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 138
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 139
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 140
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 141
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 142
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 143
MissingOverride The method 'toString()' is missing an @Override annotation. 3 153203
InsufficientStringBufferDeclaration StringBuilder has been initialized with size 16, but has at least 202 characters appended. 3 155
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 155
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 157
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 157
InefficientStringBuffering Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 3 157
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 159
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 159
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 159
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 161
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 162
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 163
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 163
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 163
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 165
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 166
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 167
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 167
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 167
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 169
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 170
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 171
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 171
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 171
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 173
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 174
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 175
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 175
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 175
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 177
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 178
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 179
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 179
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 181
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 182
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 183
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 183
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 183
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 185
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 186
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 187
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 187
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 187
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 189
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 190
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 191
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 191
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 191
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 193
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 194
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 195
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 195
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 3 195
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 197
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 198
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 3 200
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 210
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 220
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 228
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 230
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 230
UnusedAssignment The value assigned to variable 'object' is never used 3 242
AvoidReassigningParameters Avoid reassigning parameters such as 'object' 2 242
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 242
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 3 251
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 255
MethodArgumentCouldBeFinal Parameter 'fileName' is not assigned and could be declared final 3 268

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationEntry.java

Rule Violation Priority Line
ImmutableField Private field 'location' could be made final; it is only initialized in the declaration or constructor. 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 44
ImmutableField Private field 'serviceList' could be made final; it is only initialized in the declaration or constructor. 3 44
ImmutableField Private field 'locator' could be made final; it is only initialized in the declaration or constructor. 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
AvoidFieldNameMatchingMethodName Field isFirstInvocation has the same name as a method 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
ImmutableField Private field 'logger' could be made final; it is only initialized in the declaration or constructor. 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 56
ArrayIsStoredDirectly The user-supplied array 'serviceList' is stored directly. 3 66
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 66
MethodArgumentCouldBeFinal Parameter 'applicationDir' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'serviceList' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 66
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '78'-'104'). 5 78104
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '79'-'85'). 5 7985
ShortVariable Avoid variables with short names like is 3 79
UnusedAssignment The initializer for variable 'currDigest' is never used (overwritten on line 92) 3 80
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currDigest' (lines '80'-'92'). 5 8092
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currDigest' (lines '80'-'125'). 5 80125
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 3 82123
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 88
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 94
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '94'-'125'). 5 94125
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 96
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 101
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 109
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 110
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 111
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 118
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 119
MethodReturnsInternalArray Returning 'serviceList' may expose an internal array. 3 131
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 3 165
ShortVariable Avoid variables with short names like is 3 165
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 165
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '166'-'174'). 5 166174
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 174) 3 166
UnusedAssignment The initializer for variable 'content' is never used (overwritten on line 170) 3 167
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'content' (lines '167'-'170'). 5 167170
LocalVariableCouldBeFinal Local variable 'sha1' could be declared final 3 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 174
MethodArgumentCouldBeFinal Parameter 'digest' is not assigned and could be declared final 3 182
MethodArgumentCouldBeFinal Parameter 'rhs' is not assigned and could be declared final 3 193
MethodArgumentCouldBeFinal Parameter 'lhs' is not assigned and could be declared final 3 193

org/apache/fulcrum/yaafi/service/reconfiguration/ReconfigurationServiceImpl.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 59
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
LongVariable Avoid excessively long variable names like reconfigurationEntryList 3 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
LongVariable Avoid excessively long variable names like serviceLifecycleManager 3 71
CallSuperInConstructor It is a good practice to call super() in a constructor 3 8082
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 3 87
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 3 8790
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 95
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 9597
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 102
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 102147
UnusedAssignment The initializer for variable 'services' is never used (overwritten on line 124) 3 112
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'services' (lines '112'-'147'). 5 112147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'services' (lines '112'-'124'). 5 112124
UnusedAssignment The initializer for variable 'serviceEntries' is never used (overwritten on line 129) 3 113
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceEntries' (lines '113'-'129'). 5 113129
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceEntries' (lines '113'-'147'). 5 113147
LocalVariableCouldBeFinal Local variable 'entryList' could be declared final 3 114
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'location' (lines '116'-'123'). 5 116123
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'location' (lines '116'-'147'). 5 116147
UnusedAssignment The initializer for variable 'location' is never used (overwritten on line 123) 3 116
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceName' (lines '117'-'147'). 5 117147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceName' (lines '117'-'133'). 5 117133
UnusedAssignment The initializer for variable 'serviceName' is never used (overwritten on line 133) 3 117
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'serviceNameList' (lines '118'-'147'). 5 118147
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceNameList' (lines '118'-'130'). 5 118130
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'reconfigurationEntry' (lines '119'-'138'). 5 119138
LongVariable Avoid excessively long variable names like reconfigurationEntry 3 119
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'reconfigurationEntry' (lines '119'-'147'). 5 119147
UnusedAssignment The initializer for variable 'reconfigurationEntry' is never used (overwritten on line 138) 3 119
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'list' (lines '120'-'141'). 5 120141
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'listIndex' (lines '121'-'147'). 5 121147
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 122
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 123
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceNameList' (lines '130'-'134'). 5 130134
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 130
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serviceNameList' (lines '134'-'134'). 5 134
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 138139
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'list' (lines '141'-'141'). 5 141
MissingOverride The method 'initialize()' is missing an @Override annotation. 3 152163
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 152
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 157159
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 157
ControlStatementBraces This statement should have braces 3 158159
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 162
MissingOverride The method 'start()' is missing an @Override annotation. 3 168171
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 168
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 176
MissingOverride The method 'stop()' is missing an @Override annotation. 3 176181
UseUnderscoresInNumericLiterals Number 10000 should separate every third digit with an underscore 3 180
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 186192
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 188
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 189
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 190
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 191
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 197
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 197199
MissingOverride The method 'run()' is missing an @Override annotation. 3 211230
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'list' (lines '212'-'230'). 5 212230
UnusedAssignment The initializer for variable 'list' is never used (overwritten on line 214) 3 212
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'list' (lines '212'-'214'). 5 212214
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 213
LocalVariableCouldBeFinal Local variable 'reconfigurationEntry' could be declared final 3 216
LongVariable Avoid excessively long variable names like reconfigurationEntry 3 216
IfStmtsMustUseBraces Avoid using if statements without curly braces 3 217218
ControlStatementBraces This statement should have braces 3 218
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 224
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 225
LongVariable Avoid excessively long variable names like reconfigurationEntry 3 243
MethodArgumentCouldBeFinal Parameter 'reconfigurationEntry' is not assigned and could be declared final 3 243
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 243
CloseResource Ensure that resources like this InputStream object are closed after use 3 246
ShortVariable Avoid variables with short names like is 3 246
LocalVariableCouldBeFinal Local variable 'builder' could be declared final 3 247
LocalVariableCouldBeFinal Local variable 'configuration' could be declared final 3 248
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'configuration' (lines '248'-'275'). 5 248275
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 249
UnusedAssignment The value assigned to variable 'is' is never used 3 250
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '250'-'275'). 5 250275
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 250
LocalVariableCouldBeFinal Local variable 'serviceList' could be declared final 3 271
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 280282
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 287289
LongVariable Avoid excessively long variable names like reconfigurationEntryList 3 287
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 287
MethodArgumentCouldBeFinal Parameter 'reconfigurationEntryList' is not assigned and could be declared final 3 287

org/apache/fulcrum/yaafi/service/servicemanager/ServiceManagerServiceImpl.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 57
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 60
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 63
CallSuperInConstructor It is a good practice to call super() in a constructor 3 6871
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 7679
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 3 85
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 3 8591
MethodArgumentCouldBeFinal Parameter 'serviceManager' is not assigned and could be declared final 3 100
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 3 100103
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 108
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 108111
MethodArgumentCouldBeFinal Parameter 'parameters' is not assigned and could be declared final 3 116
MissingOverride The method 'parameterize(Parameters)' is missing an @Override annotation. 3 116119
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 124130
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 126
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 129
MissingOverride The method 'hasService(String)' is missing an @Override annotation. 3 139142
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 139
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 147
MissingOverride The method 'lookup(String)' is missing an @Override annotation. 3 147150
MethodArgumentCouldBeFinal Parameter 'object' is not assigned and could be declared final 3 155
MissingOverride The method 'release(Object)' is missing an @Override annotation. 3 155158
MissingOverride The method 'getServiceManager()' is missing an @Override annotation. 3 163166
MissingOverride The method 'getParameters()' is missing an @Override annotation. 3 171174
MissingOverride The method 'getContext()' is missing an @Override annotation. 3 179182
MissingOverride The method 'getAvalonLogger()' is missing an @Override annotation. 3 187190

org/apache/fulcrum/yaafi/service/shutdown/Shutdown.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 33
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 36
ImmutableField Private field 'useSystemExit' could be made final; it is only initialized in the declaration or constructor. 3 36
MethodArgumentCouldBeFinal Parameter 'useSystemExit' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'disposable' is not assigned and could be declared final 3 44
MissingOverride The method 'run()' is missing an @Override annotation. 3 5370
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 3 5962
AvoidPrintStackTrace Avoid printStackTrace(); use a logger call instead. 3 61
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 64
DoNotTerminateVM System.exit() should not be used in J2EE/JEE apps 3 68
DoNotTerminateVM System.exit() should not be used in J2EE/JEE apps 3 68

org/apache/fulcrum/yaafi/service/shutdown/ShutdownEntry.java

Rule Violation Priority Line
ImmutableField Private field 'location' could be made final; it is only initialized in the declaration or constructor. 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 41
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 47
ImmutableField Private field 'locator' could be made final; it is only initialized in the declaration or constructor. 3 47
AvoidFieldNameMatchingMethodName Field isFirstInvocation has the same name as a method 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
ImmutableField Private field 'logger' could be made final; it is only initialized in the declaration or constructor. 3 53
ImmutableField Private field 'useSystemExit' could be made final; it is only initialized in the declaration or constructor. 3 56
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
MethodArgumentCouldBeFinal Parameter 'useSystemExit' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'location' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 66
MethodArgumentCouldBeFinal Parameter 'applicationDir' is not assigned and could be declared final 3 66
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '78'-'105'). 5 78105
ShortVariable Avoid variables with short names like is 3 79
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'is' (lines '79'-'85'). 5 7985
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'currDigest' (lines '80'-'126'). 5 80126
UnusedAssignment The initializer for variable 'currDigest' is never used (overwritten on line 93) 3 80
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'currDigest' (lines '80'-'93'). 5 8093
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 3 82124
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 88
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'is' (lines '95'-'126'). 5 95126
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 95
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 97
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 102
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 110
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 111
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 112
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 119
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 120
MethodArgumentCouldBeFinal Parameter 'is' is not assigned and could be declared final 3 165
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 165
ShortVariable Avoid variables with short names like is 3 165
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '166'-'174'). 5 166174
UnusedAssignment The initializer for variable 'result' is never used (overwritten on line 174) 3 166
UnusedAssignment The initializer for variable 'content' is never used (overwritten on line 170) 3 167
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'content' (lines '167'-'170'). 5 167170
LocalVariableCouldBeFinal Local variable 'sha1' could be declared final 3 172
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 173
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 174
MethodArgumentCouldBeFinal Parameter 'digest' is not assigned and could be declared final 3 182
MethodArgumentCouldBeFinal Parameter 'lhs' is not assigned and could be declared final 3 189
MethodArgumentCouldBeFinal Parameter 'rhs' is not assigned and could be declared final 3 189

org/apache/fulcrum/yaafi/service/shutdown/ShutdownServiceImpl.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 55
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 58
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 61
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
CallSuperInConstructor It is a good practice to call super() in a constructor 3 7375
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 3 80
MissingOverride The method 'service(ServiceManager)' is missing an @Override annotation. 3 8082
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 87
MissingOverride The method 'contextualize(Context)' is missing an @Override annotation. 3 8789
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 94
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 94114
ConfusingTernary Avoid if (x != y) ..; else ..; 3 101113
LocalVariableCouldBeFinal Local variable 'shutdownConfig' could be declared final 3 102
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 104
LongVariable Avoid excessively long variable names like shutdownEntryLocation 3 104
LocalVariableCouldBeFinal Local variable 'shutdownEntryLocation' could be declared final 3 104
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 107
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 111
MissingOverride The method 'initialize()' is missing an @Override annotation. 3 121134
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 121
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 127
LocalVariableCouldBeFinal Local variable 'msg' could be declared final 3 128
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 133
MissingOverride The method 'start()' is missing an @Override annotation. 3 141144
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 141
MissingOverride The method 'stop()' is missing an @Override annotation. 3 149154
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 149
UseUnderscoresInNumericLiterals Number 10000 should separate every third digit with an underscore 3 153
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 159164
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 161
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 162
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 163
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 169171
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 169
MissingOverride The method 'run()' is missing an @Override annotation. 3 180206
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 181
LocalVariableCouldBeFinal Local variable 'shutdown' could be declared final 3 198199
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 198199
LocalVariableCouldBeFinal Local variable 'shutdownThread' could be declared final 3 201
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 201
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 201
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 3 201
UselessParentheses Useless parentheses. 4 223
ConfusingTernary Avoid if (x != y) ..; else ..; 3 223

org/apache/fulcrum/yaafi/service/systemproperty/SystemPropertyServiceImpl.java

Rule Violation Priority Line
CallSuperInConstructor It is a good practice to call super() in a constructor 3 4144
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 4144
MissingOverride The method 'configure(Configuration)' is missing an @Override annotation. 3 4980
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 49
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '51'-'80'). 5 5180
UnusedAssignment The initializer for variable 'key' is never used (overwritten on line 58) 3 51
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '51'-'58'). 5 5158
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '52'-'80'). 5 5280
UnusedAssignment The initializer for variable 'value' is never used (overwritten on line 59) 3 52
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '52'-'59'). 5 5259
UnusedAssignment The initializer for variable 'oldValue' is never used (overwritten on line 60) 3 53
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'oldValue' (lines '53'-'80'). 5 5380
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'oldValue' (lines '53'-'60'). 5 5360
LocalVariableCouldBeFinal Local variable 'systemProperties' could be declared final 3 54
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 5677
ConfusingTernary Avoid if (x != y) ..; else ..; 3 6273
MethodArgumentCouldBeFinal Parameter 'configuration' is not assigned and could be declared final 3 85
MissingOverride The method 'reconfigure(Configuration)' is missing an @Override annotation. 3 8589