PMD Results
The following document contains the results of PMD 6.29.0.
Violations By Priority
Priority 1
org/apache/fulcrum/jce/crypto/CryptoParameters.java
Rule | Violation | Line |
---|---|---|
MethodNamingConventions | The static method name 'Salt' doesn't match '[a-z][a-zA-Z0-9]*' | 40–47 |
org/apache/fulcrum/jce/crypto/PasswordParameters.java
Rule | Violation | Line |
---|---|---|
MethodNamingConventions | The static method name 'DefaultPassword' doesn't match '[a-z][a-zA-Z0-9]*' | 37–44 |
MethodNamingConventions | The static method name 'Salt' doesn't match '[a-z][a-zA-Z0-9]*' | 49–54 |
org/apache/fulcrum/jce/crypto/SmartDecryptingInputStream.java
Rule | Violation | Line |
---|---|---|
ConstructorCallsOverridableMethod | Overridable method 'copy' called during object construction | 83 |
ConstructorCallsOverridableMethod | Overridable method 'copy' called during object construction | 102 |
org/apache/fulcrum/jce/crypto/StreamUtil.java
Rule | Violation | Line |
---|---|---|
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 72 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 122 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 128 |
org/apache/fulcrum/jce/crypto/cli/CLI.java
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'CLI' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' | 40–189 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 129 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 139 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 151 |
org/apache/fulcrum/jce/crypto/cli/CLI2.java
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The utility class name 'CLI2' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' | 71–386 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 218 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 242 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 248 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 258 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 293 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 343 |
org/apache/fulcrum/jce/crypto/extended/CryptoParametersJ8.java
Rule | Violation | Line |
---|---|---|
ClassNamingConventions | The enum name 'TYPES_IMPL' doesn't match '[A-Z][a-zA-Z0-9]*' | 64–97 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8Template.java
Rule | Violation | Line |
---|---|---|
VariableNamingConventions | Variables that are final and static should be all capitals, 'instances' is not all capitals. | 81 |
FieldNamingConventions | The constant name 'instances' doesn't match '[A-Z][A-Z_0-9]*' | 81 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 108 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 134 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 162 |
org/apache/fulcrum/jce/crypto/extended/CryptoUtilJ8.java
Rule | Violation | Line |
---|---|---|
VariableNamingConventions | Variables that are final and static should be all capitals, 'instances' is not all capitals. | 43 |
FieldNamingConventions | The constant name 'instances' doesn't match '[A-Z][A-Z_0-9]*' | 43 |
FieldNamingConventions | The constant name 'instancesWithExplicitParams' doesn't match '[A-Z][A-Z_0-9]*' | 46 |
VariableNamingConventions | Variables that are final and static should be all capitals, 'instancesWithExplicitParams' is not all capitals. | 46 |
Priority 2
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryImpl.java
Rule | Violation | Line |
---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 52–253 |
org/apache/fulcrum/jce/crypto/CryptoUtil.java
Rule | Violation | Line |
---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 42–294 |
org/apache/fulcrum/jce/crypto/PasswordFactory.java
Rule | Violation | Line |
---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 39–243 |
org/apache/fulcrum/jce/crypto/StreamUtil.java
Rule | Violation | Line |
---|---|---|
SystemPrintln | System.err.println is used | 186 |
org/apache/fulcrum/jce/crypto/cli/CLI.java
Rule | Violation | Line |
---|---|---|
SystemPrintln | System.out.println is used | 70 |
SystemPrintln | System.out.println is used | 79 |
SystemPrintln | System.out.println is used | 80 |
SystemPrintln | System.err.println is used | 110 |
SystemPrintln | System.out.println is used | 134 |
SystemPrintln | System.out.println is used | 146 |
SystemPrintln | System.out.println is used | 187 |
org/apache/fulcrum/jce/crypto/cli/CLI2.java
Rule | Violation | Line |
---|---|---|
SystemPrintln | System.out.println is used | 112 |
SystemPrintln | System.out.println is used | 119 |
SystemPrintln | System.out.println is used | 120 |
SystemPrintln | System.out.println is used | 121 |
SystemPrintln | System.out.println is used | 126 |
SystemPrintln | System.out.println is used | 130 |
SystemPrintln | System.out.println is used | 136 |
SystemPrintln | System.out.println is used | 143 |
SystemPrintln | System.out.println is used | 144 |
SystemPrintln | System.out.println is used | 148 |
SystemPrintln | System.out.println is used | 157 |
SystemPrintln | System.out.println is used | 160 |
SystemPrintln | System.out.println is used | 162 |
SystemPrintln | System.out.println is used | 164 |
SystemPrintln | System.out.println is used | 165 |
SystemPrintln | System.out.println is used | 166 |
SystemPrintln | System.out.println is used | 167 |
SystemPrintln | System.out.println is used | 168 |
SystemPrintln | System.out.println is used | 169 |
SystemPrintln | System.out.println is used | 170 |
SystemPrintln | System.out.println is used | 171 |
SystemPrintln | System.out.println is used | 172 |
SystemPrintln | System.out.println is used | 173 |
SystemPrintln | System.out.println is used | 174 |
SystemPrintln | System.err.println is used | 198 |
SystemPrintln | System.out.println is used | 223 |
SystemPrintln | System.out.println is used | 228 |
SystemPrintln | System.out.println is used | 253 |
SystemPrintln | System.err.println is used | 275 |
SystemPrintln | System.err.println is used | 278 |
SystemPrintln | System.err.println is used | 281 |
SystemPrintln | System.err.println is used | 283 |
SystemPrintln | System.err.println is used | 287 |
SystemPrintln | System.err.println is used | 298 |
SystemPrintln | System.err.println is used | 332 |
SystemPrintln | System.out.println is used | 348 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8Template.java
Rule | Violation | Line |
---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 46–340 |
org/apache/fulcrum/jce/crypto/extended/CryptoUtilJ8.java
Rule | Violation | Line |
---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 40–164 |
Priority 3
org/apache/fulcrum/jce/crypto/CryptoParameters.java
Rule | Violation | Line |
---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on method 'Salt': the method is declared in an interface type | 40–47 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 52 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactory.java
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like is | 45 |
ShortVariable | Avoid variables with short names like is | 59 |
ShortVariable | Avoid variables with short names like is | 70 |
ShortVariable | Avoid variables with short names like is | 82 |
ShortVariable | Avoid variables with short names like is | 96 |
ShortVariable | Avoid variables with short names like is | 111 |
ShortVariable | Avoid variables with short names like os | 122 |
ShortVariable | Avoid variables with short names like os | 134 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryImpl.java
Rule | Violation | Line |
---|---|---|
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 58 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 61 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 64 |
MethodArgumentCouldBeFinal | Parameter 'instance' is not assigned and could be declared final | 96 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 104–110 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 118 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 118–124 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 118 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 135 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 135 |
ShortVariable | Avoid variables with short names like is | 152 |
MissingOverride | The method 'getSmartInputStream(InputStream, char)' is missing an @Override annotation. | 152–164 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 152 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 152 |
MethodReturnsInternalArray | Returning 'salt' may expose an internal array. | 196 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 206 |
LocalVariableCouldBeFinal | Local variable 'algorithm' could be declared final | 210 |
LocalVariableCouldBeFinal | Local variable 'keySpec' could be declared final | 211 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 222 |
MethodArgumentCouldBeFinal | Parameter 'mode' is not assigned and could be declared final | 234 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 234 |
MissingOverride | The method 'createCipher(int, char)' is missing an @Override annotation. | 234–252 |
LocalVariableCouldBeFinal | Local variable 'paramSpec' could be declared final | 238 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 239 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 250 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryTemplate.java
Rule | Violation | Line |
---|---|---|
AbstractNaming | Abstract classes should be named AbstractXXX | 51–171 |
AtLeastOneConstructor | Each class should declare at least one constructor | 51–171 |
MethodArgumentCouldBeFinal | Parameter 'instance' is not assigned and could be declared final | 62 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 70 |
MissingOverride | The method 'getInputStream(InputStream, String)' is missing an @Override annotation. | 70–88 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 70 |
ShortVariable | Avoid variables with short names like is | 70 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 77, 81 and 85) | 73 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 93 |
ShortVariable | Avoid variables with short names like is | 93 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 93 |
MissingOverride | The method 'getInputStream(InputStream, String, char)' is missing an @Override annotation. | 93–111 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 93 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 100, 104 and 108) | 96 |
MissingOverride | The method 'getInputStream(InputStream)' is missing an @Override annotation. | 116–121 |
ShortVariable | Avoid variables with short names like is | 116 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 116 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 119 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 119 |
MissingOverride | The method 'getInputStream(InputStream, char)' is missing an @Override annotation. | 126–131 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 126 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 126 |
ShortVariable | Avoid variables with short names like is | 126 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 129 |
ShortVariable | Avoid variables with short names like is | 136 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 136 |
MissingOverride | The method 'getSmartInputStream(InputStream)' is missing an @Override annotation. | 136–143 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 141 |
ShortVariable | Avoid variables with short names like is | 148 |
MissingOverride | The method 'getSmartInputStream(InputStream, char)' is missing an @Override annotation. | 148–149 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 154 |
ShortVariable | Avoid variables with short names like os | 154 |
MissingOverride | The method 'getOutputStream(OutputStream)' is missing an @Override annotation. | 154–158 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 157 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 157 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 163 |
ShortVariable | Avoid variables with short names like os | 163 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 163 |
MissingOverride | The method 'getOutputStream(OutputStream, char)' is missing an @Override annotation. | 163–168 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 166 |
org/apache/fulcrum/jce/crypto/CryptoUtil.java
Rule | Violation | Line |
---|---|---|
TooManyMethods | This class has too many methods, consider refactoring it. | 42–294 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 48 |
LongVariable | Avoid excessively long variable names like cryptoStreamFactory | 48 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 55–61 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 77–83 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 77 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 77 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 89 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 89 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 103 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 103 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 103 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 118 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 118 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 118 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 118 |
ShortVariable | Avoid variables with short names like is | 120 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 120 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 120 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 121 |
ShortVariable | Avoid variables with short names like os | 121 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 121 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 122 |
LocalVariableCouldBeFinal | Local variable 'eos' could be declared final | 122 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 136 |
MethodArgumentCouldBeFinal | Parameter 'plainText' is not assigned and could be declared final | 136 |
MethodArgumentCouldBeFinal | Parameter 'plainText' is not assigned and could be declared final | 149 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 149 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 164 |
MethodArgumentCouldBeFinal | Parameter 'withClearCode' is not assigned and could be declared final | 164 |
MethodArgumentCouldBeFinal | Parameter 'plainText' is not assigned and could be declared final | 164 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 164 |
LocalVariableCouldBeFinal | Local variable 'baos' could be declared final | 166 |
LocalVariableCouldBeFinal | Local variable 'prefix' could be declared final | 168–170 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 183 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 183 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 183 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 201 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 201 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 215 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 215 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 230 |
MethodArgumentCouldBeFinal | Parameter 'withClearCode' is not assigned and could be declared final | 230 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 230 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 232 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 247 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 247 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 247 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 247 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 249 |
ShortVariable | Avoid variables with short names like is | 249 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 249 |
ShortVariable | Avoid variables with short names like os | 250 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 250 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 250 |
LocalVariableCouldBeFinal | Local variable 'dis' could be declared final | 251 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 251 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 266 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 266 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 266 |
LocalVariableCouldBeFinal | Local variable 'buffer' could be declared final | 268 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 269 |
ShortVariable | Avoid variables with short names like os | 283 |
ShortVariable | Avoid variables with short names like is | 283 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 283 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 283 |
org/apache/fulcrum/jce/crypto/HexConverter.java
Rule | Violation | Line |
---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 31–72 |
MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 38 |
MethodArgumentCouldBeFinal | Parameter 'sHex' is not assigned and could be declared final | 49 |
LocalVariableCouldBeFinal | Local variable 'len' could be declared final | 50 |
MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 64 |
LocalVariableCouldBeFinal | Local variable 'sbuf' could be declared final | 66 |
ControlStatementBraces | This statement should have braces | 67–68 |
ForLoopsMustUseBraces | Avoid using for statements without curly braces | 67–68 |
LocalVariableCouldBeFinal | Local variable 'b' could be declared final | 67 |
org/apache/fulcrum/jce/crypto/PasswordFactory.java
Rule | Violation | Line |
---|---|---|
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the algo field if you want a default access modifier | 44 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 44 |
DefaultPackage | Use explicit scoping instead of the default package private level | 44 |
DefaultPackage | Use explicit scoping instead of the default package private level | 46 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 46 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the count field if you want a default access modifier | 46 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 48 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 52 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 52 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 61–69 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 77 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 77–85 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 94 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 94 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 94–102 |
MethodArgumentCouldBeFinal | Parameter 'seed' is not assigned and could be declared final | 131 |
MethodArgumentCouldBeFinal | Parameter 'seed' is not assigned and could be declared final | 145 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 165 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 165 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 165 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on line 208) | 168 |
LocalVariableCouldBeFinal | Local variable 'sha1' could be declared final | 169 |
LocalVariableCouldBeFinal | Local variable 'passwordMask' could be declared final | 170 |
LocalVariableCouldBeFinal | Local variable 'temp' could be declared final | 171 |
UnusedAssignment | The initializer for variable 'digest' is never used (overwritten on line 183) | 172 |
LocalVariableCouldBeFinal | Local variable 'stringBuffer' could be declared final | 174 |
LocalVariableCouldBeFinal | Local variable 'long1' could be declared final | 194 |
LocalVariableCouldBeFinal | Local variable 'long2' could be declared final | 195 |
LocalVariableCouldBeFinal | Local variable 'long3' could be declared final | 196 |
LocalVariableCouldBeFinal | Local variable 'long4' could be declared final | 197 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 199 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 199 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 200 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 201 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 201 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 202 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 203 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 203 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 204 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 205 |
MethodArgumentCouldBeFinal | Parameter 'nOfs' is not assigned and could be declared final | 231 |
MethodArgumentCouldBeFinal | Parameter 'buf' is not assigned and could be declared final | 231 |
org/apache/fulcrum/jce/crypto/PasswordParameters.java
Rule | Violation | Line |
---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on method 'DefaultPassword': the method is declared in an interface type | 37–44 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'Salt': the method is declared in an interface type | 49–54 |
org/apache/fulcrum/jce/crypto/SmartDecryptingInputStream.java
Rule | Violation | Line |
---|---|---|
GodClass | Possible God Class (WMC=52, ATFD=12, TCC=0.000%) | 37–385 |
MethodArgumentCouldBeFinal | Parameter 'cryptoStreamFactory' is not assigned and could be declared final | 51 |
LongVariable | Avoid excessively long variable names like cryptoStreamFactory | 51 |
ShortVariable | Avoid variables with short names like is | 52 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 52 |
LongVariable | Avoid excessively long variable names like cryptoStreamFactory | 69 |
MethodArgumentCouldBeFinal | Parameter 'cryptoStreamFactory' is not assigned and could be declared final | 69 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 70 |
ShortVariable | Avoid variables with short names like is | 70 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 71 |
UnusedAssignment | The initializer for variable 'content' is never used (overwritten on line 85) | 76 |
UnusedAssignment | The initializer for variable 'plain' is never used (overwritten on line 86) | 77 |
LocalVariableCouldBeFinal | Local variable 'baosCipher' could be declared final | 81 |
LocalVariableCouldBeFinal | Local variable 'baosPlain' could be declared final | 82 |
SimplifyBooleanExpressions | Avoid unnecessary comparisons in boolean expressions | 88 |
UnusedAssignment | The initializer for variable 'cis' is never used (overwritten on lines 95 and 99) | 90 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 90 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 91 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 126 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 131 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 133–171 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 138 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 142 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 146 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 150 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 154 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 158–168 |
LocalVariableCouldBeFinal | Local variable 'ch' could be declared final | 162 |
ShortVariable | Avoid variables with short names like ch | 162 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 166 |
ShortVariable | Avoid variables with short names like is | 182 |
ShortVariable | Avoid variables with short names like os | 182 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 182 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 182 |
LocalVariableCouldBeFinal | Local variable 'buf' could be declared final | 185 |
ShortVariable | Avoid variables with short names like n | 186 |
UnusedAssignment | The initializer for variable 'n' is never used (overwritten on line 189) | 186 |
AssignmentInOperand | Avoid assignments in operands | 189 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 208 |
MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 208 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 212–218 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 228 |
LocalVariableCouldBeFinal | Local variable 'firstUnsigned' could be declared final | 232 |
LocalVariableCouldBeFinal | Local variable 'second' could be declared final | 233 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 234–242 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 237 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 252 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 254 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 256 |
LocalVariableCouldBeFinal | Local variable 'estimate' could be declared final | 263 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 267 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 282 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 284 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 286 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 289–299 |
LocalVariableCouldBeFinal | Local variable 'currEncoding' could be declared final | 291 |
AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 293 |
LocalVariableCouldBeFinal | Local variable 'temp' could be declared final | 293 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 297 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 311 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 313 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 315 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 321–331 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 326 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 342 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 344 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 346 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 352–365 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 360 |
ShortVariable | Avoid variables with short names like ch | 374 |
MethodArgumentCouldBeFinal | Parameter 'ch' is not assigned and could be declared final | 374 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 376–383 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 378 |
org/apache/fulcrum/jce/crypto/StreamUtil.java
Rule | Violation | Line |
---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 38–190 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 58 |
ShortVariable | Avoid variables with short names like is | 61 |
LocalVariableCouldBeFinal | Local variable 'content' could be declared final | 67 |
LocalVariableCouldBeFinal | Local variable 'content' could be declared final | 80 |
LocalVariableCouldBeFinal | Local variable 'content' could be declared final | 85 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 94 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 113 |
ShortVariable | Avoid variables with short names like os | 116 |
LocalVariableCouldBeFinal | Local variable 'currFile' could be declared final | 120 |
LocalVariableCouldBeFinal | Local variable 'currFile' could be declared final | 126 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 136 |
ShortVariable | Avoid variables with short names like is | 150 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 150 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 150 |
ShortVariable | Avoid variables with short names like os | 150 |
LocalVariableCouldBeFinal | Local variable 'buf' could be declared final | 153 |
UnusedAssignment | The initializer for variable 'n' is never used (overwritten on line 157) | 154 |
ShortVariable | Avoid variables with short names like n | 154 |
AssignmentInOperand | Avoid assignments in operands | 157 |
MethodArgumentCouldBeFinal | Parameter 'currFile' is not assigned and could be declared final | 177 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 179 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 181 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 183 |
org/apache/fulcrum/jce/crypto/algo/CryptoStreamGCMImpl.java
Rule | Violation | Line |
---|---|---|
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 64 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 82–88 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 82 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 99 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 99 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 102 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'key' | 103 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 119 |
MethodArgumentCouldBeFinal | Parameter 'mode' is not assigned and could be declared final | 119 |
ShortVariable | Avoid variables with short names like is | 119 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 119 |
LocalVariableCouldBeFinal | Local variable 'bos' could be declared final | 124 |
LocalVariableCouldBeFinal | Local variable 'input' could be declared final | 126 |
ShortVariable | Avoid variables with short names like iv | 130 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 134 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 136 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 138 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 139 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 140 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 147 |
LocalVariableCouldBeFinal | Local variable 'gcmParamSpec' could be declared final | 161 |
LocalVariableCouldBeFinal | Local variable 'gcmParamSpec' could be declared final | 171 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 180 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 184 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 185 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 185 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 185 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 185 |
LocalVariableCouldBeFinal | Local variable 'iv' could be declared final | 205 |
ShortVariable | Avoid variables with short names like iv | 205 |
org/apache/fulcrum/jce/crypto/algo/CryptoStreamPBEImpl.java
Rule | Violation | Line |
---|---|---|
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 69 |
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 71 |
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 76 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 94 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 107 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 107–114 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 107 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 125 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 125 |
LocalVariableCouldBeFinal | Local variable 'algorithm' could be declared final | 129 |
LocalVariableCouldBeFinal | Local variable 'keySpec' could be declared final | 131 |
LocalVariableCouldBeFinal | Local variable 'encodedTmp' could be declared final | 133 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 170 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 170 |
ShortVariable | Avoid variables with short names like is | 170 |
MethodArgumentCouldBeFinal | Parameter 'mode' is not assigned and could be declared final | 170 |
UnusedAssignment | The initializer for variable 'paramSpec' is never used (overwritten on lines 213 and 222) | 174 |
LocalVariableCouldBeFinal | Local variable 'bos' could be declared final | 176 |
LocalVariableCouldBeFinal | Local variable 'input' could be declared final | 178 |
ShortVariable | Avoid variables with short names like iv | 183 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 186 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 188 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 190 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 191 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 192 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 199 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 227 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 231 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 232 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 232 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 232 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 232 |
org/apache/fulcrum/jce/crypto/cli/CLI.java
Rule | Violation | Line |
---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 41–189 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 47 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 51 |
LocalVariableCouldBeFinal | Local variable 'operationMode' could be declared final | 57 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 59 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 59 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 59 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 63 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 63 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 63 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 68 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 88 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 89 |
LocalVariableCouldBeFinal | Local variable 'cipherMode' could be declared final | 91 |
LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 92 |
LocalVariableCouldBeFinal | Local variable 'sourceFile' could be declared final | 93 |
UnusedAssignment | The initializer for variable 'targetFile' is never used (overwritten on lines 98 and 102) | 94 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 96 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 103 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 107 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 107 |
MethodArgumentCouldBeFinal | Parameter 'sourceFile' is not assigned and could be declared final | 126 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 126 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 126 |
MethodArgumentCouldBeFinal | Parameter 'targetFile' is not assigned and could be declared final | 126 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 127 |
LocalVariableCouldBeFinal | Local variable 'baos' could be declared final | 130 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 132 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 132 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 135 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 138 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 139 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 139 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 144 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 144 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 147 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 150 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 151 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 151 |
LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 158 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 170 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 171 |
LocalVariableCouldBeFinal | Local variable 'cipherMode' could be declared final | 173 |
LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 174 |
LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 175 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 180 and 184) | 176 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 178 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 178 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 178 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 180 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 184 |
org/apache/fulcrum/jce/crypto/cli/CLI2.java
Rule | Violation | Line |
---|---|---|
GodClass | Possible God Class (WMC=52, ATFD=49, TCC=2.778%) | 71–386 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 71–386 |
DefaultPackage | Use explicit scoping instead of the default package private level | 74 |
RedundantFieldInitializer | Avoid using redundant field initializer for 'debug' | 74 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the debug field if you want a default access modifier | 74 |
CyclomaticComplexity | The method 'main(String)' has a cyclomatic complexity of 12. | 80–115 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 80 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 84 |
LocalVariableCouldBeFinal | Local variable 'operationMode' could be declared final | 86 |
LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 88 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 89 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 93 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 93 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 93 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 95 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 96 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 96 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 96 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 101 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 106 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 106 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 106 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 108 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 108 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 108 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 111 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 113 |
LocalVariableCouldBeFinal | Local variable 'cryptoUtilJ8' could be declared final | 118 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 120 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 120 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 121 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 121 |
LocalVariableCouldBeFinal | Local variable 'list' could be declared final | 124 |
LocalVariableCouldBeFinal | Local variable 'type' could be declared final | 125 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 127 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 128 |
LocalVariableCouldBeFinal | Local variable 'resultSet' could be declared final | 128 |
AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 128 |
LocalVariableCouldBeFinal | Local variable 'supportedAlgos' could be declared final | 135 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 141–146 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 141 |
LocalVariableCouldBeFinal | Local variable 'testcu' could be declared final | 142 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 183 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 183 |
LocalVariableCouldBeFinal | Local variable 'cipherMode' could be declared final | 184 |
LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 185 |
LocalVariableCouldBeFinal | Local variable 'sourceFile' could be declared final | 186 |
UnusedAssignment | The initializer for variable 'targetFile' is never used (overwritten on lines 190 and 192) | 187 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 189 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 193 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 195 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 195 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 196 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 196 |
MethodArgumentCouldBeFinal | Parameter 'sourceFile' is not assigned and could be declared final | 215 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 215 |
MethodArgumentCouldBeFinal | Parameter 'targetFile' is not assigned and could be declared final | 215 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 215 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 216 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 219 |
LocalVariableCouldBeFinal | Local variable 'baos' could be declared final | 219 |
LocalVariableCouldBeFinal | Local variable 'cryptoUtilJ8' could be declared final | 220 |
LocalVariableCouldBeFinal | Local variable 'stringBuffer' could be declared final | 231 |
ShortVariable | Avoid variables with short names like i | 232 |
AssignmentInOperand | Avoid assignments in operands | 233 |
LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 237 |
LocalVariableCouldBeFinal | Local variable 'buffer' could be declared final | 239 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 240 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 243 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 247 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 248 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 248 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 254 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 257 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 258 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 258 |
LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 263 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 269 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 269 |
LocalVariableCouldBeFinal | Local variable 'supportedTypes' could be declared final | 271 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 273 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 273 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 274 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 282 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 282 |
LocalVariableCouldBeFinal | Local variable 'matchedType' could be declared final | 282 |
LocalVariableCouldBeFinal | Local variable 'algoShortcut' could be declared final | 284–285 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 284 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 284–285 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 284–285 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 286 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 288 |
LocalVariableCouldBeFinal | Local variable 'crt' could be declared final | 297 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 299 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 300 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 311 |
CyclomaticComplexity | The method 'processString(String)' has a cyclomatic complexity of 10. | 311–351 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 311 |
AvoidFinalLocalVariable | Avoid using final local variables, turn them into fields | 312 |
AvoidFinalLocalVariable | Avoid using final local variables, turn them into fields | 313 |
AvoidFinalLocalVariable | Avoid using final local variables, turn them into fields | 314 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 316 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 325 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 327 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 329 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 329 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 330 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 330 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 337 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 339 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 341–349 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 344 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 364 |
MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 364 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 364 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 364 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 365–377 |
LocalVariableCouldBeFinal | Local variable 'cryptoUtilJ8' could be declared final | 366 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 370 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 372 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 374 |
LongVariable | Avoid excessively long variable names like HEXADECIMAL_PATTERN | 380 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 380 |
MethodArgumentCouldBeFinal | Parameter 'input' is not assigned and could be declared final | 382 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 384 |
org/apache/fulcrum/jce/crypto/extended/CryptoParametersJ8.java
Rule | Violation | Line |
---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on enum 'TYPES_IMPL': the enum is declared in an interface type | 64–97 |
UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'TYPES_IMPL(String)': enum constructors are implicitly private | 73–75 |
UnnecessaryModifier | Unnecessary modifier 'public' on enum 'TYPES': the enum is declared in an interface type | 104–128 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 125 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 126 |
UnnecessaryModifier | Unnecessary modifier 'public' on field 'CLEAR_CODE_DEFAULT': the field is declared in an interface type | 133 |
LongVariable | Avoid excessively long variable names like CLEAR_CODE_DEFAULT | 133 |
UnnecessaryModifier | Unnecessary modifier 'public' on field 'DEFAULT_TYPE': the field is declared in an interface type | 135 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSupportedAlgos': the method is declared in an interface type | 147–170 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 148 |
ShortVariable | Avoid variables with short names like p | 149 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 154–167 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 172–175 |
UnnecessaryModifier | Unnecessary modifiers 'public static' on field 'LISTS': the field is declared in an interface type | 172–175 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 177 |
UnnecessaryModifier | Unnecessary modifiers 'public static' on field 'PROVIDER_TYPES': the field is declared in an interface type | 177 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 187 |
LongVariable | Avoid excessively long variable names like defaultSupportedTypes | 188 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 192 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 198–203 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 198–203 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8.java
Rule | Violation | Line |
---|---|---|
ShortVariable | Avoid variables with short names like os | 47 |
ShortVariable | Avoid variables with short names like is | 47 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8Template.java
Rule | Violation | Line |
---|---|---|
AbstractNaming | Abstract classes should be named AbstractXXX | 46–340 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 67 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 76 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 78 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 81 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 85–87 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 103 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 107 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 108 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 122 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 133 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 134 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 150 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 150 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 150 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 160 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 161 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 162 |
MissingOverride | The method 'getSmartInputStream(InputStream)' is missing an @Override annotation. | 175–182 |
ShortVariable | Avoid variables with short names like is | 175 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 175 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 180 |
MissingOverride | The method 'getInputStream(InputStream, char)' is missing an @Override annotation. | 187–193 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 187 |
ShortVariable | Avoid variables with short names like is | 187 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 187 |
LocalVariableCouldBeFinal | Local variable 'decrypted' could be declared final | 190 |
LocalVariableCouldBeFinal | Local variable 'eis' could be declared final | 191 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'eis' | 192 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 198 |
ShortVariable | Avoid variables with short names like os | 198 |
ShortVariable | Avoid variables with short names like is | 198 |
MissingOverride | The method 'getOutputStream(InputStream, OutputStream, char)' is missing an @Override annotation. | 198–204 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 198 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 198 |
LocalVariableCouldBeFinal | Local variable 'encrypted' could be declared final | 200 |
LocalVariableCouldBeFinal | Local variable 'eis' could be declared final | 201 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 211 |
ShortVariable | Avoid variables with short names like is | 228 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 228 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 228 |
AvoidDuplicateLiterals | The String literal "not implemented" appears 6 times in this file; the first occurrence is on line 230 | 230 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 234 |
ShortVariable | Avoid variables with short names like is | 234 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 234 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 234 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 240 |
ShortVariable | Avoid variables with short names like is | 240 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 245 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 245 |
ShortVariable | Avoid variables with short names like is | 245 |
ShortVariable | Avoid variables with short names like os | 251 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 251 |
ShortVariable | Avoid variables with short names like os | 256 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 256 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 256 |
ShortVariable | Avoid variables with short names like is | 283 |
LocalVariableCouldBeFinal | Local variable 'salt' could be declared final | 300 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 312 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 320 |
MethodArgumentCouldBeFinal | Parameter 'providerName' is not assigned and could be declared final | 328 |
MissingOverride | The method 'getAlgorithm()' is missing an @Override annotation. | 332–334 |
MethodArgumentCouldBeFinal | Parameter 'algorithm' is not assigned and could be declared final | 336 |
org/apache/fulcrum/jce/crypto/extended/CryptoUtilJ8.java
Rule | Violation | Line |
---|---|---|
LongVariable | Avoid excessively long variable names like instancesWithExplicitParams | 46 |
LocalVariableCouldBeFinal | Local variable 'defaultType' could be declared final | 57 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 71 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 88 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 88 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 88 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 97–99 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 101 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 101–103 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 111 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 111 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 111 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 111–113 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 129 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 129 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 129 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 129 |
ShortVariable | Avoid variables with short names like is | 131 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 131 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 131 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 132 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 132 |
ShortVariable | Avoid variables with short names like os | 132 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 148 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 148 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 148 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 148 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 150 |
ShortVariable | Avoid variables with short names like is | 150 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 150 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 151 |
ShortVariable | Avoid variables with short names like os | 151 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 151 |
LocalVariableCouldBeFinal | Local variable 'dis' could be declared final | 152 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 152 |
Priority 4
org/apache/fulcrum/jce/crypto/CryptoStreamFactory.java
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 59 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 82 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 111 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 134 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryImpl.java
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 152 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 206 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 234 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryTemplate.java
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 93 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 126 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 148 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 163 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 169 |
org/apache/fulcrum/jce/crypto/CryptoUtil.java
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 103 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 118 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 136 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 149 |
UselessParentheses | Useless parentheses. | 168 |
UselessParentheses | Useless parentheses. | 168 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 183 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 201 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 215 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 247 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 266 |
org/apache/fulcrum/jce/crypto/PasswordFactory.java
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 145 |
org/apache/fulcrum/jce/crypto/SmartDecryptingInputStream.java
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 71 |
UselessParentheses | Useless parentheses. | 93 |
UselessParentheses | Useless parentheses. | 93 |
UselessParentheses | Useless parentheses. | 133 |
UselessParentheses | Useless parentheses. | 234 |
UselessParentheses | Useless parentheses. | 234 |
UselessParentheses | Useless parentheses. | 234 |
UselessParentheses | Useless parentheses. | 235 |
UselessParentheses | Useless parentheses. | 235 |
UselessParentheses | Useless parentheses. | 235 |
UselessParentheses | Useless parentheses. | 295 |
UselessParentheses | Useless parentheses. | 295 |
UselessParentheses | Useless parentheses. | 321 |
UselessParentheses | Useless parentheses. | 322 |
UselessParentheses | Useless parentheses. | 323 |
UselessParentheses | Useless parentheses. | 324 |
UselessParentheses | Useless parentheses. | 352 |
UselessParentheses | Useless parentheses. | 353 |
UselessParentheses | Useless parentheses. | 354 |
UselessParentheses | Useless parentheses. | 355 |
UselessParentheses | Useless parentheses. | 356 |
UselessParentheses | Useless parentheses. | 357 |
UselessParentheses | Useless parentheses. | 358 |
UselessParentheses | Useless parentheses. | 376 |
UselessParentheses | Useless parentheses. | 376 |
org/apache/fulcrum/jce/crypto/StreamUtil.java
Rule | Violation | Line |
---|---|---|
UselessParentheses | Useless parentheses. | 181 |
org/apache/fulcrum/jce/crypto/algo/CryptoStreamGCMImpl.java
Rule | Violation | Line |
---|---|---|
UselessParentheses | Useless parentheses. | 102 |
org/apache/fulcrum/jce/crypto/cli/CLI.java
Rule | Violation | Line |
---|---|---|
ShortClassName | Avoid short class names like CLI | 40–189 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 88 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 170 |
org/apache/fulcrum/jce/crypto/cli/CLI2.java
Rule | Violation | Line |
---|---|---|
ShortClassName | Avoid short class names like CLI2 | 71–386 |
UselessParentheses | Useless parentheses. | 132 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 183 |
UselessParentheses | Useless parentheses. | 297 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 311 |
org/apache/fulcrum/jce/crypto/extended/CryptoParametersJ8.java
Rule | Violation | Line |
---|---|---|
UselessParentheses | Useless parentheses. | 156 |
UselessParentheses | Useless parentheses. | 157 |
UselessParentheses | Useless parentheses. | 158–159 |
UselessParentheses | Useless parentheses. | 163 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8.java
Rule | Violation | Line |
---|---|---|
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 47 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8Template.java
Rule | Violation | Line |
---|---|---|
UselessParentheses | Useless parentheses. | 103 |
UselessParentheses | Useless parentheses. | 129 |
UselessParentheses | Useless parentheses. | 157 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 187 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 198 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 283 |
Priority 5
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryTemplate.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '73'-'77'). | 73–77 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '73'-'81'). | 73–81 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '73'-'85'). | 73–85 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '96'-'108'). | 96–108 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '96'-'104'). | 96–104 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '96'-'100'). | 96–100 |
org/apache/fulcrum/jce/crypto/HexConverter.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'data' (lines '51'-'53'). | 51–53 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'data' (lines '53'-'53'). | 53 |
org/apache/fulcrum/jce/crypto/PasswordFactory.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '168'-'208'). | 168–208 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'sha1' (lines '169'-'222'). | 169–222 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'digest' (lines '172'-'183'). | 172–183 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '208'-'212'). | 208–212 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '212'-'212'). | 212 |
org/apache/fulcrum/jce/crypto/SmartDecryptingInputStream.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'n' (lines '186'-'189'). | 186–189 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'n' (lines '189'-'200'). | 189–200 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '210'-'216'). | 210–216 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '216'-'216'). | 216 |
org/apache/fulcrum/jce/crypto/StreamUtil.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'n' (lines '154'-'157'). | 154–157 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'n' (lines '157'-'169'). | 157–169 |
org/apache/fulcrum/jce/crypto/algo/CryptoStreamGCMImpl.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'input' (lines '126'-'194'). | 126–194 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '128'-'139'). | 128–139 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '128'-'185'). | 128–185 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'salt' (lines '129'-'135'). | 129–135 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '130'-'170'). | 130–170 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'iv' (lines '130'-'194'). | 130–194 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '130'-'137'). | 130–137 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'key' (lines '147'-'194'). | 147–194 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '151'-'194'). | 151–194 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '155'-'194'). | 155–194 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '165'-'185'). | 165–185 |
org/apache/fulcrum/jce/crypto/algo/CryptoStreamPBEImpl.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'encodedTmp' (lines '133'-'155'). | 133–155 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'paramSpec' (lines '174'-'213'). | 174–213 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'paramSpec' (lines '174'-'240'). | 174–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'paramSpec' (lines '174'-'222'). | 174–222 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'input' (lines '178'-'240'). | 178–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '180'-'232'). | 180–232 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '180'-'191'). | 180–191 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'salt' (lines '182'-'187'). | 182–187 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'iv' (lines '183'-'240'). | 183–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '183'-'189'). | 183–189 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '183'-'228'). | 183–228 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'key' (lines '199'-'240'). | 199–240 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '203'-'240'). | 203–240 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '207'-'240'). | 207–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '217'-'232'). | 217–232 |
org/apache/fulcrum/jce/crypto/cli/CLI.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '94'-'102'). | 94–102 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '94'-'98'). | 94–98 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'baos' (lines '130'-'162'). | 130–162 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '176'-'184'). | 176–184 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '176'-'180'). | 176–180 |
org/apache/fulcrum/jce/crypto/cli/CLI2.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'msg' (lines '88'-'115'). | 88–115 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '187'-'190'). | 187–190 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '187'-'192'). | 187–192 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'baos' (lines '219'-'267'). | 219–267 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'i' (lines '233'-'267'). | 233–267 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'cryptoUtilJ8' (lines '270'-'288'). | 270–288 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'cryptoUtilJ8' (lines '270'-'276'). | 270–276 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '315'-'326'). | 315–326 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'targetFile' (lines '315'-'351'). | 315–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipherMode' (lines '317'-'351'). | 317–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'password' (lines '318'-'351'). | 318–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipherMode' (lines '322'-'351'). | 322–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'password' (lines '323'-'351'). | 323–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cryptoUtilJ8' (lines '366'-'378'). | 366–378 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '368'-'372'). | 368–372 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '368'-'370'). | 368–370 |
org/apache/fulcrum/jce/crypto/extended/CryptoParametersJ8.java
Rule | Violation | Line |
---|---|---|
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '187'-'190'). | 187–190 |
Files
org/apache/fulcrum/jce/crypto/CryptoParameters.java
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on method 'Salt': the method is declared in an interface type | 3 | 40–47 |
MethodNamingConventions | The static method name 'Salt' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 40–47 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 52 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactory.java
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like is | 3 | 45 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 59 |
ShortVariable | Avoid variables with short names like is | 3 | 59 |
ShortVariable | Avoid variables with short names like is | 3 | 70 |
ShortVariable | Avoid variables with short names like is | 3 | 82 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 82 |
ShortVariable | Avoid variables with short names like is | 3 | 96 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 111 |
ShortVariable | Avoid variables with short names like is | 3 | 111 |
ShortVariable | Avoid variables with short names like os | 3 | 122 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 134 |
ShortVariable | Avoid variables with short names like os | 3 | 134 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryImpl.java
Rule | Violation | Priority | Line |
---|---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 2 | 52–253 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 58 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 61 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 64 |
MethodArgumentCouldBeFinal | Parameter 'instance' is not assigned and could be declared final | 3 | 96 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 104–110 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 118 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 118–124 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 118 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 135 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 135 |
ShortVariable | Avoid variables with short names like is | 3 | 152 |
MissingOverride | The method 'getSmartInputStream(InputStream, char)' is missing an @Override annotation. | 3 | 152–164 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 152 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 152 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 152 |
MethodReturnsInternalArray | Returning 'salt' may expose an internal array. | 3 | 196 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 206 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 206 |
LocalVariableCouldBeFinal | Local variable 'algorithm' could be declared final | 3 | 210 |
LocalVariableCouldBeFinal | Local variable 'keySpec' could be declared final | 3 | 211 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 222 |
MethodArgumentCouldBeFinal | Parameter 'mode' is not assigned and could be declared final | 3 | 234 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 234 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 234 |
MissingOverride | The method 'createCipher(int, char)' is missing an @Override annotation. | 3 | 234–252 |
LocalVariableCouldBeFinal | Local variable 'paramSpec' could be declared final | 3 | 238 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 239 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 250 |
org/apache/fulcrum/jce/crypto/CryptoStreamFactoryTemplate.java
Rule | Violation | Priority | Line |
---|---|---|---|
AbstractNaming | Abstract classes should be named AbstractXXX | 3 | 51–171 |
AtLeastOneConstructor | Each class should declare at least one constructor | 3 | 51–171 |
MethodArgumentCouldBeFinal | Parameter 'instance' is not assigned and could be declared final | 3 | 62 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 3 | 70 |
MissingOverride | The method 'getInputStream(InputStream, String)' is missing an @Override annotation. | 3 | 70–88 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 70 |
ShortVariable | Avoid variables with short names like is | 3 | 70 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '73'-'77'). | 5 | 73–77 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 77, 81 and 85) | 3 | 73 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '73'-'81'). | 5 | 73–81 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '73'-'85'). | 5 | 73–85 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 93 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 93 |
ShortVariable | Avoid variables with short names like is | 3 | 93 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 93 |
MissingOverride | The method 'getInputStream(InputStream, String, char)' is missing an @Override annotation. | 3 | 93–111 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 3 | 93 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '96'-'108'). | 5 | 96–108 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '96'-'104'). | 5 | 96–104 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 100, 104 and 108) | 3 | 96 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '96'-'100'). | 5 | 96–100 |
MissingOverride | The method 'getInputStream(InputStream)' is missing an @Override annotation. | 3 | 116–121 |
ShortVariable | Avoid variables with short names like is | 3 | 116 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 116 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 119 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 3 | 119 |
MissingOverride | The method 'getInputStream(InputStream, char)' is missing an @Override annotation. | 3 | 126–131 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 126 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 126 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 126 |
ShortVariable | Avoid variables with short names like is | 3 | 126 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 3 | 129 |
ShortVariable | Avoid variables with short names like is | 3 | 136 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 136 |
MissingOverride | The method 'getSmartInputStream(InputStream)' is missing an @Override annotation. | 3 | 136–143 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 141 |
ShortVariable | Avoid variables with short names like is | 3 | 148 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 148 |
MissingOverride | The method 'getSmartInputStream(InputStream, char)' is missing an @Override annotation. | 3 | 148–149 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 154 |
ShortVariable | Avoid variables with short names like os | 3 | 154 |
MissingOverride | The method 'getOutputStream(OutputStream)' is missing an @Override annotation. | 3 | 154–158 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 3 | 157 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 157 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 163 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 163 |
ShortVariable | Avoid variables with short names like os | 3 | 163 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 163 |
MissingOverride | The method 'getOutputStream(OutputStream, char)' is missing an @Override annotation. | 3 | 163–168 |
LocalVariableCouldBeFinal | Local variable 'cipher' could be declared final | 3 | 166 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 169 |
org/apache/fulcrum/jce/crypto/CryptoUtil.java
Rule | Violation | Priority | Line |
---|---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 2 | 42–294 |
TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 42–294 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 48 |
LongVariable | Avoid excessively long variable names like cryptoStreamFactory | 3 | 48 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 55–61 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 77–83 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 77 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 77 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 89 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 89 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 103 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 3 | 103 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 103 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 3 | 103 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 3 | 118 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 3 | 118 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 118 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 118 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 118 |
ShortVariable | Avoid variables with short names like is | 3 | 120 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 3 | 120 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 3 | 120 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 3 | 121 |
ShortVariable | Avoid variables with short names like os | 3 | 121 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 3 | 121 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 3 | 122 |
LocalVariableCouldBeFinal | Local variable 'eos' could be declared final | 3 | 122 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 136 |
MethodArgumentCouldBeFinal | Parameter 'plainText' is not assigned and could be declared final | 3 | 136 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 136 |
MethodArgumentCouldBeFinal | Parameter 'plainText' is not assigned and could be declared final | 3 | 149 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 149 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 149 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 164 |
MethodArgumentCouldBeFinal | Parameter 'withClearCode' is not assigned and could be declared final | 3 | 164 |
MethodArgumentCouldBeFinal | Parameter 'plainText' is not assigned and could be declared final | 3 | 164 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 164 |
LocalVariableCouldBeFinal | Local variable 'baos' could be declared final | 3 | 166 |
LocalVariableCouldBeFinal | Local variable 'prefix' could be declared final | 3 | 168–170 |
UselessParentheses | Useless parentheses. | 4 | 168 |
UselessParentheses | Useless parentheses. | 4 | 168 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 183 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 3 | 183 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 3 | 183 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 183 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 201 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 3 | 201 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 201 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 215 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 3 | 215 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 215 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 230 |
MethodArgumentCouldBeFinal | Parameter 'withClearCode' is not assigned and could be declared final | 3 | 230 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 3 | 230 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 3 | 232 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 3 | 247 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 3 | 247 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 247 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 247 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 247 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 3 | 249 |
ShortVariable | Avoid variables with short names like is | 3 | 249 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 3 | 249 |
ShortVariable | Avoid variables with short names like os | 3 | 250 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 3 | 250 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 3 | 250 |
LocalVariableCouldBeFinal | Local variable 'dis' could be declared final | 3 | 251 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 3 | 251 |
MethodArgumentCouldBeFinal | Parameter 'cipherText' is not assigned and could be declared final | 3 | 266 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 266 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 266 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 266 |
LocalVariableCouldBeFinal | Local variable 'buffer' could be declared final | 3 | 268 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 3 | 269 |
ShortVariable | Avoid variables with short names like os | 3 | 283 |
ShortVariable | Avoid variables with short names like is | 3 | 283 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 283 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 283 |
org/apache/fulcrum/jce/crypto/HexConverter.java
Rule | Violation | Priority | Line |
---|---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 31–72 |
MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 38 |
MethodArgumentCouldBeFinal | Parameter 'sHex' is not assigned and could be declared final | 3 | 49 |
LocalVariableCouldBeFinal | Local variable 'len' could be declared final | 3 | 50 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'data' (lines '51'-'53'). | 5 | 51–53 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'data' (lines '53'-'53'). | 5 | 53 |
MethodArgumentCouldBeFinal | Parameter 'data' is not assigned and could be declared final | 3 | 64 |
LocalVariableCouldBeFinal | Local variable 'sbuf' could be declared final | 3 | 66 |
ControlStatementBraces | This statement should have braces | 3 | 67–68 |
ForLoopsMustUseBraces | Avoid using for statements without curly braces | 3 | 67–68 |
LocalVariableCouldBeFinal | Local variable 'b' could be declared final | 3 | 67 |
org/apache/fulcrum/jce/crypto/PasswordFactory.java
Rule | Violation | Priority | Line |
---|---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 2 | 39–243 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the algo field if you want a default access modifier | 3 | 44 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 44 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 44 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 46 |
BeanMembersShouldSerialize | Found non-transient, non-static member. Please mark as transient or provide accessors. | 3 | 46 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the count field if you want a default access modifier | 3 | 46 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 3 | 48 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 52 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 3 | 52 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 61–69 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 3 | 77 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 77–85 |
MethodArgumentCouldBeFinal | Parameter 'algo' is not assigned and could be declared final | 3 | 94 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 94 |
AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 94–102 |
MethodArgumentCouldBeFinal | Parameter 'seed' is not assigned and could be declared final | 3 | 131 |
MethodArgumentCouldBeFinal | Parameter 'seed' is not assigned and could be declared final | 3 | 145 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 145 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 165 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 165 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 165 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on line 208) | 3 | 168 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '168'-'208'). | 5 | 168–208 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'sha1' (lines '169'-'222'). | 5 | 169–222 |
LocalVariableCouldBeFinal | Local variable 'sha1' could be declared final | 3 | 169 |
LocalVariableCouldBeFinal | Local variable 'passwordMask' could be declared final | 3 | 170 |
LocalVariableCouldBeFinal | Local variable 'temp' could be declared final | 3 | 171 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'digest' (lines '172'-'183'). | 5 | 172–183 |
UnusedAssignment | The initializer for variable 'digest' is never used (overwritten on line 183) | 3 | 172 |
LocalVariableCouldBeFinal | Local variable 'stringBuffer' could be declared final | 3 | 174 |
LocalVariableCouldBeFinal | Local variable 'long1' could be declared final | 3 | 194 |
LocalVariableCouldBeFinal | Local variable 'long2' could be declared final | 3 | 195 |
LocalVariableCouldBeFinal | Local variable 'long3' could be declared final | 3 | 196 |
LocalVariableCouldBeFinal | Local variable 'long4' could be declared final | 3 | 197 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 199 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 199 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 200 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 201 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 201 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 202 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 203 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 203 |
ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 3 | 204 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 205 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '208'-'212'). | 5 | 208–212 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '212'-'212'). | 5 | 212 |
MethodArgumentCouldBeFinal | Parameter 'nOfs' is not assigned and could be declared final | 3 | 231 |
MethodArgumentCouldBeFinal | Parameter 'buf' is not assigned and could be declared final | 3 | 231 |
org/apache/fulcrum/jce/crypto/PasswordParameters.java
Rule | Violation | Priority | Line |
---|---|---|---|
MethodNamingConventions | The static method name 'DefaultPassword' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 37–44 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'DefaultPassword': the method is declared in an interface type | 3 | 37–44 |
MethodNamingConventions | The static method name 'Salt' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 49–54 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'Salt': the method is declared in an interface type | 3 | 49–54 |
org/apache/fulcrum/jce/crypto/SmartDecryptingInputStream.java
Rule | Violation | Priority | Line |
---|---|---|---|
GodClass | Possible God Class (WMC=52, ATFD=12, TCC=0.000%) | 3 | 37–385 |
MethodArgumentCouldBeFinal | Parameter 'cryptoStreamFactory' is not assigned and could be declared final | 3 | 51 |
LongVariable | Avoid excessively long variable names like cryptoStreamFactory | 3 | 51 |
ShortVariable | Avoid variables with short names like is | 3 | 52 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 52 |
LongVariable | Avoid excessively long variable names like cryptoStreamFactory | 3 | 69 |
MethodArgumentCouldBeFinal | Parameter 'cryptoStreamFactory' is not assigned and could be declared final | 3 | 69 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 70 |
ShortVariable | Avoid variables with short names like is | 3 | 70 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 71 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 71 |
UnusedAssignment | The initializer for variable 'content' is never used (overwritten on line 85) | 3 | 76 |
UnusedAssignment | The initializer for variable 'plain' is never used (overwritten on line 86) | 3 | 77 |
LocalVariableCouldBeFinal | Local variable 'baosCipher' could be declared final | 3 | 81 |
LocalVariableCouldBeFinal | Local variable 'baosPlain' could be declared final | 3 | 82 |
ConstructorCallsOverridableMethod | Overridable method 'copy' called during object construction | 1 | 83 |
SimplifyBooleanExpressions | Avoid unnecessary comparisons in boolean expressions | 3 | 88 |
UnusedAssignment | The initializer for variable 'cis' is never used (overwritten on lines 95 and 99) | 3 | 90 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 3 | 90 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 3 | 91 |
UselessParentheses | Useless parentheses. | 4 | 93 |
UselessParentheses | Useless parentheses. | 4 | 93 |
ConstructorCallsOverridableMethod | Overridable method 'copy' called during object construction | 1 | 102 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 126 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 131 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 133–171 |
UselessParentheses | Useless parentheses. | 4 | 133 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 138 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 142 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 146 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 150 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 154 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 158–168 |
LocalVariableCouldBeFinal | Local variable 'ch' could be declared final | 3 | 162 |
ShortVariable | Avoid variables with short names like ch | 3 | 162 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 166 |
ShortVariable | Avoid variables with short names like is | 3 | 182 |
ShortVariable | Avoid variables with short names like os | 3 | 182 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 182 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 182 |
LocalVariableCouldBeFinal | Local variable 'buf' could be declared final | 3 | 185 |
ShortVariable | Avoid variables with short names like n | 3 | 186 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'n' (lines '186'-'189'). | 5 | 186–189 |
UnusedAssignment | The initializer for variable 'n' is never used (overwritten on line 189) | 3 | 186 |
AssignmentInOperand | Avoid assignments in operands | 3 | 189 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'n' (lines '189'-'200'). | 5 | 189–200 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 208 |
MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 208 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '210'-'216'). | 5 | 210–216 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 212–218 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '216'-'216'). | 5 | 216 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 228 |
LocalVariableCouldBeFinal | Local variable 'firstUnsigned' could be declared final | 3 | 232 |
LocalVariableCouldBeFinal | Local variable 'second' could be declared final | 3 | 233 |
UselessParentheses | Useless parentheses. | 4 | 234 |
UselessParentheses | Useless parentheses. | 4 | 234 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 234–242 |
UselessParentheses | Useless parentheses. | 4 | 234 |
UselessParentheses | Useless parentheses. | 4 | 235 |
UselessParentheses | Useless parentheses. | 4 | 235 |
UselessParentheses | Useless parentheses. | 4 | 235 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 237 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 252 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 254 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 256 |
LocalVariableCouldBeFinal | Local variable 'estimate' could be declared final | 3 | 263 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 267 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 282 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 284 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 286 |
ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 289–299 |
LocalVariableCouldBeFinal | Local variable 'currEncoding' could be declared final | 3 | 291 |
AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 293 |
LocalVariableCouldBeFinal | Local variable 'temp' could be declared final | 3 | 293 |
UselessParentheses | Useless parentheses. | 4 | 295 |
UselessParentheses | Useless parentheses. | 4 | 295 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 297 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 311 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 313 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 315 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 321–331 |
UselessParentheses | Useless parentheses. | 4 | 321 |
UselessParentheses | Useless parentheses. | 4 | 322 |
UselessParentheses | Useless parentheses. | 4 | 323 |
UselessParentheses | Useless parentheses. | 4 | 324 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 326 |
MethodArgumentCouldBeFinal | Parameter 'content' is not assigned and could be declared final | 3 | 342 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 344 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 346 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 352–365 |
UselessParentheses | Useless parentheses. | 4 | 352 |
UselessParentheses | Useless parentheses. | 4 | 353 |
UselessParentheses | Useless parentheses. | 4 | 354 |
UselessParentheses | Useless parentheses. | 4 | 355 |
UselessParentheses | Useless parentheses. | 4 | 356 |
UselessParentheses | Useless parentheses. | 4 | 357 |
UselessParentheses | Useless parentheses. | 4 | 358 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 360 |
ShortVariable | Avoid variables with short names like ch | 3 | 374 |
MethodArgumentCouldBeFinal | Parameter 'ch' is not assigned and could be declared final | 3 | 374 |
UselessParentheses | Useless parentheses. | 4 | 376 |
SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 376–383 |
UselessParentheses | Useless parentheses. | 4 | 376 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 378 |
org/apache/fulcrum/jce/crypto/StreamUtil.java
Rule | Violation | Priority | Line |
---|---|---|---|
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 38–190 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 3 | 58 |
ShortVariable | Avoid variables with short names like is | 3 | 61 |
LocalVariableCouldBeFinal | Local variable 'content' could be declared final | 3 | 67 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 72 |
LocalVariableCouldBeFinal | Local variable 'content' could be declared final | 3 | 80 |
LocalVariableCouldBeFinal | Local variable 'content' could be declared final | 3 | 85 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 94 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 3 | 113 |
ShortVariable | Avoid variables with short names like os | 3 | 116 |
LocalVariableCouldBeFinal | Local variable 'currFile' could be declared final | 3 | 120 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 122 |
LocalVariableCouldBeFinal | Local variable 'currFile' could be declared final | 3 | 126 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 128 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 136 |
ShortVariable | Avoid variables with short names like is | 3 | 150 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 150 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 150 |
ShortVariable | Avoid variables with short names like os | 3 | 150 |
LocalVariableCouldBeFinal | Local variable 'buf' could be declared final | 3 | 153 |
UnusedAssignment | The initializer for variable 'n' is never used (overwritten on line 157) | 3 | 154 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'n' (lines '154'-'157'). | 5 | 154–157 |
ShortVariable | Avoid variables with short names like n | 3 | 154 |
AssignmentInOperand | Avoid assignments in operands | 3 | 157 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'n' (lines '157'-'169'). | 5 | 157–169 |
MethodArgumentCouldBeFinal | Parameter 'currFile' is not assigned and could be declared final | 3 | 177 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 3 | 179 |
UselessParentheses | Useless parentheses. | 4 | 181 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 181 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 3 | 183 |
SystemPrintln | System.err.println is used | 2 | 186 |
org/apache/fulcrum/jce/crypto/algo/CryptoStreamGCMImpl.java
Rule | Violation | Priority | Line |
---|---|---|---|
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 3 | 64 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 82–88 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 82 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 99 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 99 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 102 |
UselessParentheses | Useless parentheses. | 4 | 102 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'key' | 3 | 103 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 119 |
MethodArgumentCouldBeFinal | Parameter 'mode' is not assigned and could be declared final | 3 | 119 |
ShortVariable | Avoid variables with short names like is | 3 | 119 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 119 |
LocalVariableCouldBeFinal | Local variable 'bos' could be declared final | 3 | 124 |
LocalVariableCouldBeFinal | Local variable 'input' could be declared final | 3 | 126 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'input' (lines '126'-'194'). | 5 | 126–194 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '128'-'139'). | 5 | 128–139 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '128'-'185'). | 5 | 128–185 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'salt' (lines '129'-'135'). | 5 | 129–135 |
ShortVariable | Avoid variables with short names like iv | 3 | 130 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '130'-'170'). | 5 | 130–170 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'iv' (lines '130'-'194'). | 5 | 130–194 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '130'-'137'). | 5 | 130–137 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 3 | 134 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 136 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 138 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 139 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 140 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 147 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'key' (lines '147'-'194'). | 5 | 147–194 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '151'-'194'). | 5 | 151–194 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '155'-'194'). | 5 | 155–194 |
LocalVariableCouldBeFinal | Local variable 'gcmParamSpec' could be declared final | 3 | 161 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '165'-'185'). | 5 | 165–185 |
LocalVariableCouldBeFinal | Local variable 'gcmParamSpec' could be declared final | 3 | 171 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 180 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 3 | 184 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 185 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 185 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 185 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 185 |
LocalVariableCouldBeFinal | Local variable 'iv' could be declared final | 3 | 205 |
ShortVariable | Avoid variables with short names like iv | 3 | 205 |
org/apache/fulcrum/jce/crypto/algo/CryptoStreamPBEImpl.java
Rule | Violation | Priority | Line |
---|---|---|---|
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 3 | 69 |
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 3 | 71 |
AvoidProtectedFieldInFinalClass | Avoid protected fields in a final class. Change to private or package access. | 3 | 76 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 94 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 107 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 107–114 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 107 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 125 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 125 |
LocalVariableCouldBeFinal | Local variable 'algorithm' could be declared final | 3 | 129 |
LocalVariableCouldBeFinal | Local variable 'keySpec' could be declared final | 3 | 131 |
LocalVariableCouldBeFinal | Local variable 'encodedTmp' could be declared final | 3 | 133 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'encodedTmp' (lines '133'-'155'). | 5 | 133–155 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 170 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 170 |
ShortVariable | Avoid variables with short names like is | 3 | 170 |
MethodArgumentCouldBeFinal | Parameter 'mode' is not assigned and could be declared final | 3 | 170 |
UnusedAssignment | The initializer for variable 'paramSpec' is never used (overwritten on lines 213 and 222) | 3 | 174 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'paramSpec' (lines '174'-'213'). | 5 | 174–213 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'paramSpec' (lines '174'-'240'). | 5 | 174–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'paramSpec' (lines '174'-'222'). | 5 | 174–222 |
LocalVariableCouldBeFinal | Local variable 'bos' could be declared final | 3 | 176 |
LocalVariableCouldBeFinal | Local variable 'input' could be declared final | 3 | 178 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'input' (lines '178'-'240'). | 5 | 178–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '180'-'232'). | 5 | 180–232 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '180'-'191'). | 5 | 180–191 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'salt' (lines '182'-'187'). | 5 | 182–187 |
ShortVariable | Avoid variables with short names like iv | 3 | 183 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'iv' (lines '183'-'240'). | 5 | 183–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '183'-'189'). | 5 | 183–189 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'iv' (lines '183'-'228'). | 5 | 183–228 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 3 | 186 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 188 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 190 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 191 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 192 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'key' (lines '199'-'240'). | 5 | 199–240 |
LocalVariableCouldBeFinal | Local variable 'key' could be declared final | 3 | 199 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '203'-'240'). | 5 | 203–240 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipher' (lines '207'-'240'). | 5 | 207–240 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'ciphertext' (lines '217'-'232'). | 5 | 217–232 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 227 |
LocalVariableCouldBeFinal | Local variable 'byteBuffer' could be declared final | 3 | 231 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 232 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 232 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 232 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 232 |
org/apache/fulcrum/jce/crypto/cli/CLI.java
Rule | Violation | Priority | Line |
---|---|---|---|
ShortClassName | Avoid short class names like CLI | 4 | 40–189 |
ClassNamingConventions | The utility class name 'CLI' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' | 1 | 40–189 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 41–189 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 3 | 47 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 51 |
LocalVariableCouldBeFinal | Local variable 'operationMode' could be declared final | 3 | 57 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 59 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 59 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 59 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 63 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 63 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 63 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 68 |
SystemPrintln | System.out.println is used | 2 | 70 |
SystemPrintln | System.out.println is used | 2 | 79 |
SystemPrintln | System.out.println is used | 2 | 80 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 88 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 3 | 88 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 89 |
LocalVariableCouldBeFinal | Local variable 'cipherMode' could be declared final | 3 | 91 |
LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 3 | 92 |
LocalVariableCouldBeFinal | Local variable 'sourceFile' could be declared final | 3 | 93 |
UnusedAssignment | The initializer for variable 'targetFile' is never used (overwritten on lines 98 and 102) | 3 | 94 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '94'-'102'). | 5 | 94–102 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '94'-'98'). | 5 | 94–98 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 96 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 3 | 103 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 107 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 3 | 107 |
SystemPrintln | System.err.println is used | 2 | 110 |
MethodArgumentCouldBeFinal | Parameter 'sourceFile' is not assigned and could be declared final | 3 | 126 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 126 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 3 | 126 |
MethodArgumentCouldBeFinal | Parameter 'targetFile' is not assigned and could be declared final | 3 | 126 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 127 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 129 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'baos' (lines '130'-'162'). | 5 | 130–162 |
LocalVariableCouldBeFinal | Local variable 'baos' could be declared final | 3 | 130 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 132 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 132 |
SystemPrintln | System.out.println is used | 2 | 134 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 135 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 3 | 138 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 3 | 139 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 3 | 139 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 139 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 144 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 144 |
SystemPrintln | System.out.println is used | 2 | 146 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 147 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 3 | 150 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 3 | 151 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 3 | 151 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 151 |
LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 3 | 158 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 170 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 3 | 170 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 171 |
LocalVariableCouldBeFinal | Local variable 'cipherMode' could be declared final | 3 | 173 |
LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 3 | 174 |
LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 175 |
UnusedAssignment | The initializer for variable 'result' is never used (overwritten on lines 180 and 184) | 3 | 176 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '176'-'184'). | 5 | 176–184 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '176'-'180'). | 5 | 176–180 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 178 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 178 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 178 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 180 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 184 |
SystemPrintln | System.out.println is used | 2 | 187 |
org/apache/fulcrum/jce/crypto/cli/CLI2.java
Rule | Violation | Priority | Line |
---|---|---|---|
ClassNamingConventions | The utility class name 'CLI2' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' | 1 | 71–386 |
GodClass | Possible God Class (WMC=52, ATFD=49, TCC=2.778%) | 3 | 71–386 |
ShortClassName | Avoid short class names like CLI2 | 4 | 71–386 |
UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 71–386 |
DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 74 |
RedundantFieldInitializer | Avoid using redundant field initializer for 'debug' | 3 | 74 |
CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the debug field if you want a default access modifier | 3 | 74 |
CyclomaticComplexity | The method 'main(String)' has a cyclomatic complexity of 12. | 3 | 80–115 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 3 | 80 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 84 |
LocalVariableCouldBeFinal | Local variable 'operationMode' could be declared final | 3 | 86 |
LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 3 | 88 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'msg' (lines '88'-'115'). | 5 | 88–115 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 89 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 93 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 93 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 93 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 95 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 96 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 96 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 96 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 101 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 106 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 106 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 106 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 108 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 108 |
PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 108 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 111 |
SystemPrintln | System.out.println is used | 2 | 112 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 113 |
LocalVariableCouldBeFinal | Local variable 'cryptoUtilJ8' could be declared final | 3 | 118 |
SystemPrintln | System.out.println is used | 2 | 119 |
SystemPrintln | System.out.println is used | 2 | 120 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 120 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 120 |
SystemPrintln | System.out.println is used | 2 | 121 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 121 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 121 |
LocalVariableCouldBeFinal | Local variable 'list' could be declared final | 3 | 124 |
LocalVariableCouldBeFinal | Local variable 'type' could be declared final | 3 | 125 |
SystemPrintln | System.out.println is used | 2 | 126 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 127 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 128 |
LocalVariableCouldBeFinal | Local variable 'resultSet' could be declared final | 3 | 128 |
AvoidInstantiatingObjectsInLoops | Avoid instantiating new objects inside loops | 3 | 128 |
SystemPrintln | System.out.println is used | 2 | 130 |
UselessParentheses | Useless parentheses. | 4 | 132 |
LocalVariableCouldBeFinal | Local variable 'supportedAlgos' could be declared final | 3 | 135 |
SystemPrintln | System.out.println is used | 2 | 136 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 141–146 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 3 | 141 |
LocalVariableCouldBeFinal | Local variable 'testcu' could be declared final | 3 | 142 |
SystemPrintln | System.out.println is used | 2 | 143 |
SystemPrintln | System.out.println is used | 2 | 144 |
SystemPrintln | System.out.println is used | 2 | 148 |
SystemPrintln | System.out.println is used | 2 | 157 |
SystemPrintln | System.out.println is used | 2 | 160 |
SystemPrintln | System.out.println is used | 2 | 162 |
SystemPrintln | System.out.println is used | 2 | 164 |
SystemPrintln | System.out.println is used | 2 | 165 |
SystemPrintln | System.out.println is used | 2 | 166 |
SystemPrintln | System.out.println is used | 2 | 167 |
SystemPrintln | System.out.println is used | 2 | 168 |
SystemPrintln | System.out.println is used | 2 | 169 |
SystemPrintln | System.out.println is used | 2 | 170 |
SystemPrintln | System.out.println is used | 2 | 171 |
SystemPrintln | System.out.println is used | 2 | 172 |
SystemPrintln | System.out.println is used | 2 | 173 |
SystemPrintln | System.out.println is used | 2 | 174 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 3 | 183 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 183 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 183 |
LocalVariableCouldBeFinal | Local variable 'cipherMode' could be declared final | 3 | 184 |
LocalVariableCouldBeFinal | Local variable 'password' could be declared final | 3 | 185 |
LocalVariableCouldBeFinal | Local variable 'sourceFile' could be declared final | 3 | 186 |
UnusedAssignment | The initializer for variable 'targetFile' is never used (overwritten on lines 190 and 192) | 3 | 187 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '187'-'190'). | 5 | 187–190 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '187'-'192'). | 5 | 187–192 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 189 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 3 | 193 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 195 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 195 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 3 | 196 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 196 |
SystemPrintln | System.err.println is used | 2 | 198 |
MethodArgumentCouldBeFinal | Parameter 'sourceFile' is not assigned and could be declared final | 3 | 215 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 3 | 215 |
MethodArgumentCouldBeFinal | Parameter 'targetFile' is not assigned and could be declared final | 3 | 215 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 215 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 216 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 218 |
PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 219 |
LocalVariableCouldBeFinal | Local variable 'baos' could be declared final | 3 | 219 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'baos' (lines '219'-'267'). | 5 | 219–267 |
LocalVariableCouldBeFinal | Local variable 'cryptoUtilJ8' could be declared final | 3 | 220 |
SystemPrintln | System.out.println is used | 2 | 223 |
SystemPrintln | System.out.println is used | 2 | 228 |
LocalVariableCouldBeFinal | Local variable 'stringBuffer' could be declared final | 3 | 231 |
ShortVariable | Avoid variables with short names like i | 3 | 232 |
AssignmentInOperand | Avoid assignments in operands | 3 | 233 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'i' (lines '233'-'267'). | 5 | 233–267 |
LocalVariableCouldBeFinal | Local variable 'value' could be declared final | 3 | 237 |
LocalVariableCouldBeFinal | Local variable 'buffer' could be declared final | 3 | 239 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 240 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 242 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 243 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 3 | 247 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 248 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 3 | 248 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 3 | 248 |
SystemPrintln | System.out.println is used | 2 | 253 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 254 |
LocalVariableCouldBeFinal | Local variable 'bais' could be declared final | 3 | 257 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 258 |
CloseResource | Ensure that resources like this FileOutputStream object are closed after use | 3 | 258 |
LocalVariableCouldBeFinal | Local variable 'fos' could be declared final | 3 | 258 |
LocalVariableCouldBeFinal | Local variable 'msg' could be declared final | 3 | 263 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 3 | 269 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 269 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'cryptoUtilJ8' (lines '270'-'288'). | 5 | 270–288 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'cryptoUtilJ8' (lines '270'-'276'). | 5 | 270–276 |
LocalVariableCouldBeFinal | Local variable 'supportedTypes' could be declared final | 3 | 271 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 273 |
LiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 273 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 274 |
SystemPrintln | System.err.println is used | 2 | 275 |
SystemPrintln | System.err.println is used | 2 | 278 |
SystemPrintln | System.err.println is used | 2 | 281 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 282 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 282 |
LocalVariableCouldBeFinal | Local variable 'matchedType' could be declared final | 3 | 282 |
SystemPrintln | System.err.println is used | 2 | 283 |
LocalVariableCouldBeFinal | Local variable 'algoShortcut' could be declared final | 3 | 284–285 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 3 | 284 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 284–285 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 284–285 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 286 |
SystemPrintln | System.err.println is used | 2 | 287 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 288 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 293 |
UselessParentheses | Useless parentheses. | 4 | 297 |
LocalVariableCouldBeFinal | Local variable 'crt' could be declared final | 3 | 297 |
SystemPrintln | System.err.println is used | 2 | 298 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 299 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 300 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 311 |
CyclomaticComplexity | The method 'processString(String)' has a cyclomatic complexity of 10. | 3 | 311–351 |
MethodArgumentCouldBeFinal | Parameter 'args' is not assigned and could be declared final | 3 | 311 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 311 |
AvoidFinalLocalVariable | Avoid using final local variables, turn them into fields | 3 | 312 |
AvoidFinalLocalVariable | Avoid using final local variables, turn them into fields | 3 | 313 |
AvoidFinalLocalVariable | Avoid using final local variables, turn them into fields | 3 | 314 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'targetFile' (lines '315'-'326'). | 5 | 315–326 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'targetFile' (lines '315'-'351'). | 5 | 315–351 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 316 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipherMode' (lines '317'-'351'). | 5 | 317–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'password' (lines '318'-'351'). | 5 | 318–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cipherMode' (lines '322'-'351'). | 5 | 322–351 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'password' (lines '323'-'351'). | 5 | 323–351 |
AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 325 |
LocalVariableCouldBeFinal | Local variable 'parentFile' could be declared final | 3 | 327 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 329 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 329 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 330 |
LocalVariableCouldBeFinal | Local variable 'success' could be declared final | 3 | 330 |
SystemPrintln | System.err.println is used | 2 | 332 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 337 |
LocalVariableCouldBeFinal | Local variable 'result' could be declared final | 3 | 339 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 341–349 |
AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 1 | 343 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 344 |
SystemPrintln | System.out.println is used | 2 | 348 |
SignatureDeclareThrowsException | A method/constructor should not explicitly throw java.lang.Exception | 3 | 364 |
MethodArgumentCouldBeFinal | Parameter 'value' is not assigned and could be declared final | 3 | 364 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 364 |
MethodArgumentCouldBeFinal | Parameter 'cipherMode' is not assigned and could be declared final | 3 | 364 |
ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 365–377 |
DataflowAnomalyAnalysis | Found 'DU'-anomaly for variable 'cryptoUtilJ8' (lines '366'-'378'). | 5 | 366–378 |
LocalVariableCouldBeFinal | Local variable 'cryptoUtilJ8' could be declared final | 3 | 366 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '368'-'372'). | 5 | 368–372 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '368'-'370'). | 5 | 368–370 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 370 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 372 |
OnlyOneReturn | A method should have only one exit point, and that should be the last statement in the method | 3 | 374 |
LongVariable | Avoid excessively long variable names like HEXADECIMAL_PATTERN | 3 | 380 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 380 |
MethodArgumentCouldBeFinal | Parameter 'input' is not assigned and could be declared final | 3 | 382 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 384 |
org/apache/fulcrum/jce/crypto/extended/CryptoParametersJ8.java
Rule | Violation | Priority | Line |
---|---|---|---|
UnnecessaryModifier | Unnecessary modifier 'public' on enum 'TYPES_IMPL': the enum is declared in an interface type | 3 | 64–97 |
ClassNamingConventions | The enum name 'TYPES_IMPL' doesn't match '[A-Z][a-zA-Z0-9]*' | 1 | 64–97 |
UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'TYPES_IMPL(String)': enum constructors are implicitly private | 3 | 73–75 |
UnnecessaryModifier | Unnecessary modifier 'public' on enum 'TYPES': the enum is declared in an interface type | 3 | 104–128 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 3 | 125 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 3 | 126 |
UnnecessaryModifier | Unnecessary modifier 'public' on field 'CLEAR_CODE_DEFAULT': the field is declared in an interface type | 3 | 133 |
LongVariable | Avoid excessively long variable names like CLEAR_CODE_DEFAULT | 3 | 133 |
UnnecessaryModifier | Unnecessary modifier 'public' on field 'DEFAULT_TYPE': the field is declared in an interface type | 3 | 135 |
UnnecessaryModifier | Unnecessary modifier 'public' on method 'getSupportedAlgos': the method is declared in an interface type | 3 | 147–170 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 148 |
ShortVariable | Avoid variables with short names like p | 3 | 149 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 154–167 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 154–167 |
UselessParentheses | Useless parentheses. | 4 | 156 |
UselessParentheses | Useless parentheses. | 4 | 157 |
UselessParentheses | Useless parentheses. | 4 | 158–159 |
UselessParentheses | Useless parentheses. | 4 | 163 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 172–175 |
UnnecessaryModifier | Unnecessary modifiers 'public static' on field 'LISTS': the field is declared in an interface type | 3 | 172–175 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 177 |
UnnecessaryModifier | Unnecessary modifiers 'public static' on field 'PROVIDER_TYPES': the field is declared in an interface type | 3 | 177 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 187 |
DataflowAnomalyAnalysis | Found 'DD'-anomaly for variable 'result' (lines '187'-'190'). | 5 | 187–190 |
LongVariable | Avoid excessively long variable names like defaultSupportedTypes | 3 | 188 |
UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 192 |
LawOfDemeter | Potential violation of Law of Demeter (object not created locally) | 3 | 198–203 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 198–203 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8.java
Rule | Violation | Priority | Line |
---|---|---|---|
ShortVariable | Avoid variables with short names like os | 3 | 47 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 47 |
ShortVariable | Avoid variables with short names like is | 3 | 47 |
org/apache/fulcrum/jce/crypto/extended/CryptoStreamFactoryJ8Template.java
Rule | Violation | Priority | Line |
---|---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 2 | 46–340 |
AbstractNaming | Abstract classes should be named AbstractXXX | 3 | 46–340 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 67 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 76 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 78 |
VariableNamingConventions | Variables that are final and static should be all capitals, 'instances' is not all capitals. | 1 | 81 |
FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 81 |
FieldNamingConventions | The constant name 'instances' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 81 |
UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 3 | 85–87 |
UselessParentheses | Useless parentheses. | 4 | 103 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 3 | 103 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 107 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 108 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 108 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 122 |
UselessParentheses | Useless parentheses. | 4 | 129 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 133 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 134 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 134 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 150 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 150 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 150 |
UselessParentheses | Useless parentheses. | 4 | 157 |
AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 160 |
AvoidPrintStackTrace | Avoid printStackTrace(); use a logger call instead. | 3 | 161 |
AvoidThrowingRawExceptionTypes | Avoid throwing raw exception types. | 1 | 162 |
PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 162 |
MissingOverride | The method 'getSmartInputStream(InputStream)' is missing an @Override annotation. | 3 | 175–182 |
ShortVariable | Avoid variables with short names like is | 3 | 175 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 175 |
LawOfDemeter | Potential violation of Law of Demeter (method chain calls) | 3 | 180 |
MissingOverride | The method 'getInputStream(InputStream, char)' is missing an @Override annotation. | 3 | 187–193 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 187 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 187 |
ShortVariable | Avoid variables with short names like is | 3 | 187 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 187 |
LocalVariableCouldBeFinal | Local variable 'decrypted' could be declared final | 3 | 190 |
LocalVariableCouldBeFinal | Local variable 'eis' could be declared final | 3 | 191 |
UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'eis' | 3 | 192 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 198 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 198 |
ShortVariable | Avoid variables with short names like os | 3 | 198 |
ShortVariable | Avoid variables with short names like is | 3 | 198 |
MissingOverride | The method 'getOutputStream(InputStream, OutputStream, char)' is missing an @Override annotation. | 3 | 198–204 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 198 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 198 |
LocalVariableCouldBeFinal | Local variable 'encrypted' could be declared final | 3 | 200 |
LocalVariableCouldBeFinal | Local variable 'eis' could be declared final | 3 | 201 |
LawOfDemeter | Potential violation of Law of Demeter (static property access) | 3 | 211 |
ShortVariable | Avoid variables with short names like is | 3 | 228 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 3 | 228 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 228 |
AvoidDuplicateLiterals | The String literal "not implemented" appears 6 times in this file; the first occurrence is on line 230 | 3 | 230 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 234 |
ShortVariable | Avoid variables with short names like is | 3 | 234 |
MethodArgumentCouldBeFinal | Parameter 'decryptionMode' is not assigned and could be declared final | 3 | 234 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 234 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 240 |
ShortVariable | Avoid variables with short names like is | 3 | 240 |
MethodArgumentCouldBeFinal | Parameter 'is' is not assigned and could be declared final | 3 | 245 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 245 |
ShortVariable | Avoid variables with short names like is | 3 | 245 |
ShortVariable | Avoid variables with short names like os | 3 | 251 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 251 |
ShortVariable | Avoid variables with short names like os | 3 | 256 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 256 |
MethodArgumentCouldBeFinal | Parameter 'os' is not assigned and could be declared final | 3 | 256 |
UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 283 |
ShortVariable | Avoid variables with short names like is | 3 | 283 |
LocalVariableCouldBeFinal | Local variable 'salt' could be declared final | 3 | 300 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 312 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 320 |
MethodArgumentCouldBeFinal | Parameter 'providerName' is not assigned and could be declared final | 3 | 328 |
MissingOverride | The method 'getAlgorithm()' is missing an @Override annotation. | 3 | 332–334 |
MethodArgumentCouldBeFinal | Parameter 'algorithm' is not assigned and could be declared final | 3 | 336 |
org/apache/fulcrum/jce/crypto/extended/CryptoUtilJ8.java
Rule | Violation | Priority | Line |
---|---|---|---|
SingleMethodSingleton | Class contains multiple getInstance methods. Please review. | 2 | 40–164 |
VariableNamingConventions | Variables that are final and static should be all capitals, 'instances' is not all capitals. | 1 | 43 |
FieldNamingConventions | The constant name 'instances' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 43 |
FieldNamingConventions | The constant name 'instancesWithExplicitParams' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 46 |
VariableNamingConventions | Variables that are final and static should be all capitals, 'instancesWithExplicitParams' is not all capitals. | 1 | 46 |
LongVariable | Avoid excessively long variable names like instancesWithExplicitParams | 3 | 46 |
LocalVariableCouldBeFinal | Local variable 'defaultType' could be declared final | 3 | 57 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 71 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 88 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 88 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 88 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 97–99 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 101 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 101–103 |
MethodArgumentCouldBeFinal | Parameter 'type' is not assigned and could be declared final | 3 | 111 |
MethodArgumentCouldBeFinal | Parameter 'count' is not assigned and could be declared final | 3 | 111 |
MethodArgumentCouldBeFinal | Parameter 'salt' is not assigned and could be declared final | 3 | 111 |
CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 111–113 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 3 | 129 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 129 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 3 | 129 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 129 |
ShortVariable | Avoid variables with short names like is | 3 | 131 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 3 | 131 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 3 | 131 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 3 | 132 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 3 | 132 |
ShortVariable | Avoid variables with short names like os | 3 | 132 |
MethodArgumentCouldBeFinal | Parameter 'factory' is not assigned and could be declared final | 3 | 148 |
MethodArgumentCouldBeFinal | Parameter 'source' is not assigned and could be declared final | 3 | 148 |
MethodArgumentCouldBeFinal | Parameter 'target' is not assigned and could be declared final | 3 | 148 |
MethodArgumentCouldBeFinal | Parameter 'password' is not assigned and could be declared final | 3 | 148 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 3 | 150 |
ShortVariable | Avoid variables with short names like is | 3 | 150 |
LocalVariableCouldBeFinal | Local variable 'is' could be declared final | 3 | 150 |
CloseResource | Ensure that resources like this OutputStream object are closed after use | 3 | 151 |
ShortVariable | Avoid variables with short names like os | 3 | 151 |
LocalVariableCouldBeFinal | Local variable 'os' could be declared final | 3 | 151 |
LocalVariableCouldBeFinal | Local variable 'dis' could be declared final | 3 | 152 |
CloseResource | Ensure that resources like this InputStream object are closed after use | 3 | 152 |