PMD Results

The following document contains the results of PMD 6.29.0.

Violations By Priority

Priority 1

org/apache/fulcrum/parser/BaseValueParser.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setNumberFormat' called during object construction 133
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1497
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1504
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1565

org/apache/fulcrum/parser/CookieParser.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'seconds_age' doesn't match '[a-z][a-zA-Z0-9]*' 95
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'seconds_age' is not final. 95

Priority 2

org/apache/fulcrum/parser/BaseValueParser.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 81

org/apache/fulcrum/parser/DataStreamParser.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 90

Priority 3

org/apache/fulcrum/parser/BaseValueParser.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 11699
ExcessiveClassLength Avoid really long classes. 731699
CyclomaticComplexity The class 'BaseValueParser' has a total cyclomatic complexity of 209 (highest 25). 731699
GodClass Possible God Class (WMC=209, ATFD=104, TCC=1.197%) 731699
StdCyclomaticComplexity The class 'BaseValueParser' has a Standard Cyclomatic Complexity of 2 (Highest = 16). 731699
ModifiedCyclomaticComplexity The class 'BaseValueParser' has a Modified Cyclomatic Complexity of 2 (Highest = 16). 731699
TooManyMethods This class has too many methods, consider refactoring it. 761699
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 78
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 97
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 97
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 97
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 118
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 129
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 129
MethodArgumentCouldBeFinal Parameter 'parserService' is not assigned and could be declared final 142
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 152
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 180
ShortVariable Avoid variables with short names like s 208
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 208
ShortVariable Avoid variables with short names like l 226
MethodArgumentCouldBeFinal Parameter 'l' is not assigned and could be declared final 226
ShortVariable Avoid variables with short names like df 246
MethodArgumentCouldBeFinal Parameter 'df' is not assigned and could be declared final 246
ShortVariable Avoid variables with short names like nf 264
MethodArgumentCouldBeFinal Parameter 'nf' is not assigned and could be declared final 264
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 285
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 285
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 297
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 297
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 309
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 309
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 324
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 324
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 336
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 336
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 355
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 355
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 361367
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 379
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 393
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 407
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 442
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 457
LocalVariableCouldBeFinal Local variable 'value' could be declared final 460
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 483
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 483
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 485486
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 502
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 502
LocalVariableCouldBeFinal Local variable 'result' could be declared final 504
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 505
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 516
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 529
LocalVariableCouldBeFinal Local variable 'value' could be declared final 532
LocalVariableCouldBeFinal Local variable 'bool' could be declared final 542
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 545
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 565
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 584
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 584
LocalVariableCouldBeFinal Local variable 'result' could be declared final 586
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 598
LocalVariableCouldBeFinal Local variable 'value' could be declared final 601
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 620
LocalVariableCouldBeFinal Local variable 'value' could be declared final 623
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 627
LocalVariableCouldBeFinal Local variable 'number' could be declared final 628
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 637
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 639640
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 656
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 670
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 670
LocalVariableCouldBeFinal Local variable 'number' could be declared final 672
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 673
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 684
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 697
LocalVariableCouldBeFinal Local variable 'value' could be declared final 700
LocalVariableCouldBeFinal Local variable 'number' could be declared final 706
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 707
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 722
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 722
LocalVariableCouldBeFinal Local variable 'result' could be declared final 724
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 725
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 736
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 749
LocalVariableCouldBeFinal Local variable 'value' could be declared final 752
LocalVariableCouldBeFinal Local variable 'number' could be declared final 758
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 759
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 759
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 774
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 774
LocalVariableCouldBeFinal Local variable 'number' could be declared final 776
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 777
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 788
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 801
LocalVariableCouldBeFinal Local variable 'value' could be declared final 804
LocalVariableCouldBeFinal Local variable 'number' could be declared final 810
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 811
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 826
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 826
LocalVariableCouldBeFinal Local variable 'result' could be declared final 828
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 829
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 840
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 853
LocalVariableCouldBeFinal Local variable 'value' could be declared final 856
LocalVariableCouldBeFinal Local variable 'number' could be declared final 862
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 863
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 863
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 878
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 878
LocalVariableCouldBeFinal Local variable 'result' could be declared final 880
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 881
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 881
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 892
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 905
LocalVariableCouldBeFinal Local variable 'value' could be declared final 908
LocalVariableCouldBeFinal Local variable 'number' could be declared final 914
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 915
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 915
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 915
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 930
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 930
LocalVariableCouldBeFinal Local variable 'result' could be declared final 932
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 933
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 944
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 957
LocalVariableCouldBeFinal Local variable 'value' could be declared final 960
LocalVariableCouldBeFinal Local variable 'number' could be declared final 966
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 967
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 982
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 982
LocalVariableCouldBeFinal Local variable 'result' could be declared final 984
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 985
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 996
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1009
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1012
LocalVariableCouldBeFinal Local variable 'number' could be declared final 1018
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1019
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1019
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 1034
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1034
LocalVariableCouldBeFinal Local variable 'result' could be declared final 1036
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1037
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1048
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1061
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1064
LocalVariableCouldBeFinal Local variable 'number' could be declared final 1070
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1071
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1085
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1088
LocalVariableCouldBeFinal Local variable 'number' could be declared final 1094
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1095
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1095
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1109
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1123
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 1123
LocalVariableCouldBeFinal Local variable 'result' could be declared final 1125
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1126
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1138
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 1138
LocalVariableCouldBeFinal Local variable 'result' could be declared final 1140
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1141
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1152
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1167
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1171
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1188
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 1188
LocalVariableCouldBeFinal Local variable 'result' could be declared final 1190
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1191
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1202
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1215
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1217
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1234
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 1248
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1248
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1250
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 1263
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1263
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1279
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 1293
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1293
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1295
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1308
MethodArgumentCouldBeFinal Parameter 'values' is not assigned and could be declared final 1308
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1324
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1337
ShortVariable Avoid variables with short names like df 1353
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1353
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 1353
MethodArgumentCouldBeFinal Parameter 'df' is not assigned and could be declared final 1353
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1356
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1384
ShortVariable Avoid variables with short names like df 1398
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 1398
MethodArgumentCouldBeFinal Parameter 'df' is not assigned and could be declared final 1398
MethodArgumentCouldBeFinal Parameter 'bean' is not assigned and could be declared final 1412
LocalVariableCouldBeFinal Local variable 'beanClass' could be declared final 1414
LocalVariableCouldBeFinal Local variable 'props' could be declared final 14151416
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1416
LocalVariableCouldBeFinal Local variable 'pd' could be declared final 1418
LocalVariableCouldBeFinal Local variable 'propname' could be declared final 1420
LocalVariableCouldBeFinal Local variable 'setter' could be declared final 1421
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 1439
ShortVariable Avoid variables with short names like sb 1439
LocalVariableCouldBeFinal Local variable 'name' could be declared final 1440
LocalVariableCouldBeFinal Local variable 'params' could be declared final 1445
ModifiedCyclomaticComplexity The method 'setProperty' has a Modified Cyclomatic Complexity of 16. 14911572
MethodArgumentCouldBeFinal Parameter 'bean' is not assigned and could be declared final 1491
CyclomaticComplexity The method 'setProperty(Object, PropertyDescriptor)' has a cyclomatic complexity of 25. 14911572
StdCyclomaticComplexity The method 'setProperty' has a Standard Cyclomatic Complexity of 16. 14911572
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 1492
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 1493
LocalVariableCouldBeFinal Local variable 'setter' could be declared final 1501
LocalVariableCouldBeFinal Local variable 'propclass' could be declared final 1508
UnusedAssignment The initializer for variable 'arg' is never used (overwritten on lines 1513, 1517, 1521, 1525, 1529, 1533, 1537, 1541, 1545, 1549, 1553, 1557 and 1561) 1509
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 1571
LocalVariableCouldBeFinal Local variable 'key' could be declared final 1585
LocalVariableCouldBeFinal Local variable 'key' could be declared final 1602
LocalVariableCouldBeFinal Local variable 'value' could be declared final 1603
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 1609
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 1623
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 1623
MethodArgumentCouldBeFinal Parameter 'paramName' is not assigned and could be declared final 1642
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 1643
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 1643
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 16451647
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 1659
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 1675
MethodArgumentCouldBeFinal Parameter 'fold' is not assigned and could be declared final 1675
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 16931696
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 1693
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 1695

org/apache/fulcrum/parser/CSVParser.java

Rule Violation Line
ShortVariable Avoid variables with short names like in 61
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 61
ShortVariable Avoid variables with short names like in 73
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 73
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 73
ShortVariable Avoid variables with short names like in 87
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 87
MethodArgumentCouldBeFinal Parameter 'tokenizer' is not assigned and could be declared final 96
MissingOverride The method 'initTokenizer(StreamTokenizer)' is missing an @Override annotation. 96115

org/apache/fulcrum/parser/CookieParser.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'AGE_SESSION': the field is declared in an interface type 58
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'AGE_DELETE': the field is declared in an interface type 59

org/apache/fulcrum/parser/DataStreamParser.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 59299
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 90
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 101
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 101
ShortVariable Avoid variables with short names like in 101
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 102
EmptyCatchBlock Avoid empty catch blocks 115118
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 139
MissingOverride The method 'enableLogging(Logger)' is missing an @Override annotation. 139142
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 149
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 163
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 203
ShortVariable Avoid variables with short names like it 219
LocalVariableCouldBeFinal Local variable 'it' could be declared final 219
LocalVariableCouldBeFinal Local variable 'colname' could be declared final 228
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 228
LocalVariableCouldBeFinal Local variable 'colval' could be declared final 229
MissingOverride The method 'hasNext()' is missing an @Override annotation. 248262
MissingOverride The method 'next()' is missing an @Override annotation. 271287
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 272
UnusedAssignment The initializer for variable 'nextRow' is never used (overwritten on line 278) 274
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 283
MissingOverride The method 'remove()' is missing an @Override annotation. 294298
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 295

org/apache/fulcrum/parser/DefaultCookieParser.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7073
MissingOverride The method 'dispose()' is missing an @Override annotation. 7883
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 80
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 81
MissingOverride The method 'getRequest()' is missing an @Override annotation. 9093
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 102
MissingOverride The method 'setData(HttpServletRequest, HttpServletResponse)' is missing an @Override annotation. 102126
MethodArgumentCouldBeFinal Parameter 'response' is not assigned and could be declared final 103
LocalVariableCouldBeFinal Local variable 'enc' could be declared final 107
ConfusingTernary Avoid if (x != y) ..; else ..; 108
LocalVariableCouldBeFinal Local variable 'cookies' could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 113
LocalVariableCouldBeFinal Local variable 'cookie' could be declared final 115
LocalVariableCouldBeFinal Local variable 'name' could be declared final 117
LocalVariableCouldBeFinal Local variable 'value' could be declared final 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 119
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 132
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 132
MissingOverride The method 'set(String, String)' is missing an @Override annotation. 132135
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 143
MethodArgumentCouldBeFinal Parameter 'secondsAge' is not assigned and could be declared final 143
MissingOverride The method 'set(String, String, int)' is missing an @Override annotation. 143154
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 143
LocalVariableCouldBeFinal Local variable 'cookie' could be declared final 150
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 163
MissingOverride The method 'unset(String)' is missing an @Override annotation. 163166
MissingOverride The method 'isValid()' is missing an @Override annotation. 171178
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 173176
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 175

org/apache/fulcrum/parser/DefaultParameterParser.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'request' 71
RedundantFieldInitializer Avoid using redundant field initializer for 'uploadData' 76
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 101
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 112
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 113
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 150
CyclomaticComplexity The method 'setRequest(HttpServletRequest)' has a cyclomatic complexity of 10. 150205
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 154
LocalVariableCouldBeFinal Local variable 'contentType' could be declared final 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 162
LocalVariableCouldBeFinal Local variable 'parts' could be declared final 166
LocalVariableCouldBeFinal Local variable 'p' could be declared final 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 172
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 173
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 181
LocalVariableCouldBeFinal Local variable 'names' could be declared final 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 186
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 188
LocalVariableCouldBeFinal Local variable 'paramName' could be declared final 188
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 197
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 199
LocalVariableCouldBeFinal Local variable 'key' could be declared final 200
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 202
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 207
UnusedAssignment The initializer for variable 'paramValue' is never used (overwritten on line 228) 215
LocalVariableCouldBeFinal Local variable 'st' could be declared final 217218
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 229
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 237
EmptyCatchBlock Avoid empty catch blocks 237243
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 246
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 250
ConfusingTernary Avoid if (x != y) ..; else ..; 258265
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 260
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 264
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 269
ConfusingTernary Avoid if (x != y) ..; else ..; 273275
MethodArgumentCouldBeFinal Parameter 'uploadData' is not assigned and could be declared final 284
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 312
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 312
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 329
LocalVariableCouldBeFinal Local variable 'object' could be declared final 334
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 339
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 358
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 362
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 376379
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 376379
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 376379
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 376379
MethodArgumentCouldBeFinal Parameter 'part' is not assigned and could be declared final 387
LocalVariableCouldBeFinal Local variable 'regex' could be declared final 392
LocalVariableCouldBeFinal Local variable 'content' could be declared final 394
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 397
UnusedAssignment The initializer for variable 'fnTmp' is never used (overwritten on lines 404 and 411) 399
LocalVariableCouldBeFinal Local variable 'srcStr' could be declared final 400
LocalVariableCouldBeFinal Local variable 'regexMatcher' could be declared final 401
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 402
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 404
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 405
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 407
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 411
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 411
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 411
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 412
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 414
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 414

org/apache/fulcrum/parser/DefaultParserService.java

Rule Violation Line
GodClass Possible God Class (WMC=70, ATFD=80, TCC=16.667%) 58535
StdCyclomaticComplexity The class 'DefaultParserService' has a Standard Cyclomatic Complexity of 4 (Highest = 18). 58535
ModifiedCyclomaticComplexity The class 'DefaultParserService' has a Modified Cyclomatic Complexity of 3 (Highest = 18). 58535
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 79
RedundantFieldInitializer Avoid using redundant field initializer for 'fulcrumPoolService' 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 85
LongVariable Avoid excessively long variable names like fulcrumPoolService 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 90
LongVariable Avoid excessively long variable names like parameterParserPool 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 100
CallSuperInConstructor It is a good practice to call super() in a constructor 103105
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 107
CallSuperInConstructor It is a good practice to call super() in a constructor 107115
MethodArgumentCouldBeFinal Parameter 'encoding' is not assigned and could be declared final 130
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 144
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 158
MethodArgumentCouldBeFinal Parameter 'fold' is not assigned and could be declared final 173
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 173
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 177
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 191
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 197
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 203
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 240
MethodArgumentCouldBeFinal Parameter 'ppClass' is not assigned and could be declared final 262
CyclomaticComplexity The method 'getParser(Class)' has a cyclomatic complexity of 28. 262347
StdCyclomaticComplexity The method 'getParser' has a Standard Cyclomatic Complexity of 18. 262347
ModifiedCyclomaticComplexity The method 'getParser' has a Modified Cyclomatic Complexity of 18. 262347
ShortVariable Avoid variables with short names like vp 264
LocalVariableCouldBeFinal Local variable 'parserInstance' could be declared final 271
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 276
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 287
UnusedAssignment The value assigned to variable 'parserInstance' is never used 290
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 290
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 291
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 292
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 292
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 304
UnusedAssignment The value assigned to variable 'parserInstance' is never used 307
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 307
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 308
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 309
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 309
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 321
UnusedAssignment The value assigned to variable 'parserInstance' is never used 324
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 324
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 325
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 326
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 326
SimplifyConditional No need to check for null before an instanceof 331
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 338
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 343
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 359
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 368
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 372
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 377
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 384
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 396
ExcessiveMethodLength Avoid really long methods. 396515
StdCyclomaticComplexity The method 'configure' has a Standard Cyclomatic Complexity of 15. 396515
CyclomaticComplexity The method 'configure(Configuration)' has a cyclomatic complexity of 17. 396515
NcssCount The method 'configure(Configuration)' has a NCSS line count of 76. 396515
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 398
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 398
LawOfDemeter Potential violation of Law of Demeter (static property access) 398
LocalVariableCouldBeFinal Local variable 'foldString' could be declared final 398
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 398
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 402
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 408
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 412
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 417418
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 417418
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 417418
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 420
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 422
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 432
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 435
LocalVariableCouldBeFinal Local variable 'config' could be declared final 438
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 454
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 455
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 455
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 456
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 456
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 457
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 457
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 460
LocalVariableCouldBeFinal Local variable 'poolChildren' could be declared final 460
LocalVariableCouldBeFinal Local variable 'genObjPoolConfig' could be declared final 462
LocalVariableCouldBeFinal Local variable 'poolConf' could be declared final 465
LocalVariableCouldBeFinal Local variable 'defaultCapacity' could be declared final 469
LocalVariableCouldBeFinal Local variable 'maxWaitMillis' could be declared final 473
LocalVariableCouldBeFinal Local variable 'blockWhenExhausted' could be declared final 477
LongVariable Avoid excessively long variable names like blockWhenExhausted 477
LocalVariableCouldBeFinal Local variable 'maxIdle' could be declared final 481
LocalVariableCouldBeFinal Local variable 'minIdle' could be declared final 485
LocalVariableCouldBeFinal Local variable 'testOnReturn' could be declared final 489
LocalVariableCouldBeFinal Local variable 'testOnBorrow' could be declared final 493
LocalVariableCouldBeFinal Local variable 'testOnCreate' could be declared final 497
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 510
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 511
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 512
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 526

org/apache/fulcrum/parser/ParserService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT 43
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_KEY 46
LongVariable Avoid excessively long variable names like URL_CASE_FOLDING_KEY 49
LongVariable Avoid excessively long variable names like FULCRUM_POOL_DEFAULT 55
LongVariable Avoid excessively long variable names like DEFAULT_POOL_CAPACITY 78

org/apache/fulcrum/parser/StringValueParser.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 33110
MethodArgumentCouldBeFinal Parameter 'urlDecode' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'delim' is not assigned and could be declared final 44
ShortVariable Avoid variables with short names like s 44
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 45
LocalVariableCouldBeFinal Local variable 'delimChar' could be declared final 47
LocalVariableCouldBeFinal Local variable 'st' could be declared final 48
ShortVariable Avoid variables with short names like st 48
UnusedAssignment The initializer for variable 'pathPart' is never used (overwritten on line 67) 50
MethodArgumentCouldBeFinal Parameter 'pairDelim' is not assigned and could be declared final 77
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 77
MethodArgumentCouldBeFinal Parameter 'paramDelim' is not assigned and could be declared final 77
ShortVariable Avoid variables with short names like s 77
MethodArgumentCouldBeFinal Parameter 'urlDecode' is not assigned and could be declared final 78
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 79
LocalVariableCouldBeFinal Local variable 'delimChar' could be declared final 87
LocalVariableCouldBeFinal Local variable 'st' could be declared final 88
ShortVariable Avoid variables with short names like st 88
LocalVariableCouldBeFinal Local variable 'pair' could be declared final 92
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 94
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 103

org/apache/fulcrum/parser/TSVParser.java

Rule Violation Line
ShortVariable Avoid variables with short names like in 62
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 62
ShortVariable Avoid variables with short names like in 74
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 88
ShortVariable Avoid variables with short names like in 88
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 88
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 88
MissingOverride The method 'initTokenizer(StreamTokenizer)' is missing an @Override annotation. 99112
MethodArgumentCouldBeFinal Parameter 'tokenizer' is not assigned and could be declared final 99

org/apache/fulcrum/parser/ValueParser.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 1774
TooManyMethods This class has too many methods, consider refactoring it. 50773
LongVariable Avoid excessively long variable names like DEFAULT_CHARACTER_ENCODING 54
ShortVariable Avoid variables with short names like df 703
ShortVariable Avoid variables with short names like df 724
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 734

org/apache/fulcrum/parser/pool/BaseValueParserFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3475
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 51
MethodArgumentCouldBeFinal Parameter 'pooledObject' is not assigned and could be declared final 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 71

org/apache/fulcrum/parser/pool/BaseValueParserPool.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 41
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 55

org/apache/fulcrum/parser/pool/CookieParserFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3475
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 51
MethodArgumentCouldBeFinal Parameter 'pooledObject' is not assigned and could be declared final 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 62
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 71

org/apache/fulcrum/parser/pool/CookieParserPool.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 41
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 55

org/apache/fulcrum/parser/pool/DefaultParameterParserFactory.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3475
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 52
MethodArgumentCouldBeFinal Parameter 'pooledObject' is not assigned and could be declared final 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 63
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 72

org/apache/fulcrum/parser/pool/DefaultParameterParserPool.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 57

Priority 4

org/apache/fulcrum/parser/BaseValueParser.java

Rule Violation Line
UselessParentheses Useless parentheses. 505
UselessParentheses Useless parentheses. 587
UselessParentheses Useless parentheses. 673
UselessParentheses Useless parentheses. 707
UselessParentheses Useless parentheses. 725
UselessParentheses Useless parentheses. 759
UselessParentheses Useless parentheses. 777
UselessParentheses Useless parentheses. 811
UselessParentheses Useless parentheses. 829
UselessParentheses Useless parentheses. 863
UselessParentheses Useless parentheses. 881
UselessParentheses Useless parentheses. 915
UselessParentheses Useless parentheses. 933
UselessParentheses Useless parentheses. 967
UselessParentheses Useless parentheses. 985
UselessParentheses Useless parentheses. 1019
UselessParentheses Useless parentheses. 1037
UselessParentheses Useless parentheses. 1071
UselessParentheses Useless parentheses. 1095
UselessParentheses Useless parentheses. 1126
UselessParentheses Useless parentheses. 1141
UselessParentheses Useless parentheses. 1191
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 1583

org/apache/fulcrum/parser/ParserService.java

Rule Violation Line
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 137

org/apache/fulcrum/parser/ValueParser.java

Rule Violation Line
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 198
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 663
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 673

Priority 5

org/apache/fulcrum/parser/BaseValueParser.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '459'-'478'). 459478
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '459'-'471'). 459471
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '531'-'535'). 531535
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '535'-'539'). 535539
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '539'-'539'). 539
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '539'-'545'). 539545
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '545'-'539'). 545539
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '600'-'604'). 600604
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '604'-'607'). 604607
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '607'-'607'). 607
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '622'-'633'). 622633
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'number' (lines '628'-'646'). 628646
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '699'-'703'). 699703
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '703'-'707'). 703707
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '707'-'707'). 707
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '751'-'755'). 751755
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '755'-'759'). 755759
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '759'-'759'). 759
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '803'-'807'). 803807
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '807'-'811'). 807811
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '811'-'811'). 811
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '855'-'859'). 855859
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '859'-'863'). 859863
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '863'-'863'). 863
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '907'-'911'). 907911
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '911'-'915'). 911915
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '915'-'915'). 915
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '959'-'963'). 959963
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '963'-'967'). 963967
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '967'-'967'). 967
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.011'-'1.015'). 10111015
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.015'-'1.019'). 10151019
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.019'-'1.019'). 1019
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.063'-'1.067'). 10631067
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.067'-'1.071'). 10671071
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.071'-'1.071'). 1071
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.087'-'1.091'). 10871091
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.091'-'1.095'). 10911095
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.095'-'1.095'). 1095
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.170'-'1.174'). 11701174
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.355'-'1.363'). 13551363
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'arg' (lines '1.509'-'1.572'). 15091572
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.525'). 15091525
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.533'). 15091533
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.549'). 15091549
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.553'). 15091553
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.557'). 15091557
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.541'). 15091541
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.561'). 15091561
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.517'). 15091517
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.521'). 15091521
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.529'). 15091529
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.537'). 15091537
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.545'). 15091545
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.513'). 15091513

org/apache/fulcrum/parser/DataStreamParser.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'it' (lines '219'-'241'). 219241
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasNext' (lines '250'-'254'). 250254
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'nextRow' (lines '274'-'278'). 274278
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'nextRow' (lines '278'-'287'). 278287

org/apache/fulcrum/parser/DefaultParameterParser.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '213'-'244'). 213244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramName' (lines '214'-'223'). 214223
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramName' (lines '214'-'244'). 214244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramValue' (lines '215'-'228'). 215228
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramValue' (lines '215'-'244'). 215244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramName' (lines '223'-'223'). 223
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramName' (lines '223'-'244'). 223244
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '224'-'244'). 224244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramValue' (lines '228'-'228'). 228
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramValue' (lines '228'-'244'). 228244
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '233'-'244'). 233244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '333'-'337'). 333337
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'regex' (lines '392'-'418'). 392418
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fnTmp' (lines '399'-'411'). 399411
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fnTmp' (lines '399'-'404'). 399404

org/apache/fulcrum/parser/DefaultParserService.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'272'). 264272
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'300'). 264300
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'283'). 264283
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'317'). 264317
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'vp' (lines '272'-'347'). 272347
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'parserInstance' (lines '280'-'282'). 280282
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'parserInstance' (lines '290'-'347'). 290347

org/apache/fulcrum/parser/StringValueParser.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '49'-'75'). 4975
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'pathPart' (lines '50'-'75'). 5075
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pathPart' (lines '50'-'67'). 5067
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '51'-'62'). 5162
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '51'-'75'). 5175
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '62'-'75'). 6275
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '62'-'62'). 62
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '63'-'75'). 6375
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'pathPart' (lines '67'-'75'). 6775
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pathPart' (lines '67'-'67'). 67
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '72'-'75'). 7275
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '95'-'109'). 95109
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '95'-'95'). 95
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '100'-'109'). 100109
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '100'-'95'). 10095

Files

org/apache/fulcrum/parser/BaseValueParser.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 11699
ExcessiveClassLength Avoid really long classes. 3 731699
CyclomaticComplexity The class 'BaseValueParser' has a total cyclomatic complexity of 209 (highest 25). 3 731699
GodClass Possible God Class (WMC=209, ATFD=104, TCC=1.197%) 3 731699
StdCyclomaticComplexity The class 'BaseValueParser' has a Standard Cyclomatic Complexity of 2 (Highest = 16). 3 731699
ModifiedCyclomaticComplexity The class 'BaseValueParser' has a Modified Cyclomatic Complexity of 2 (Highest = 16). 3 731699
TooManyMethods This class has too many methods, consider refactoring it. 3 761699
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 78
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 97
LooseCoupling Avoid using implementation types like 'Hashtable'; use the interface instead 3 97
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 97
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 3 97
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 3 118
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 129
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 3 129
ConstructorCallsOverridableMethod Overridable method 'setNumberFormat' called during object construction 1 133
MethodArgumentCouldBeFinal Parameter 'parserService' is not assigned and could be declared final 3 142
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 152
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 3 180
ShortVariable Avoid variables with short names like s 3 208
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 208
ShortVariable Avoid variables with short names like l 3 226
MethodArgumentCouldBeFinal Parameter 'l' is not assigned and could be declared final 3 226
ShortVariable Avoid variables with short names like df 3 246
MethodArgumentCouldBeFinal Parameter 'df' is not assigned and could be declared final 3 246
ShortVariable Avoid variables with short names like nf 3 264
MethodArgumentCouldBeFinal Parameter 'nf' is not assigned and could be declared final 3 264
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 285
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 285
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 297
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 297
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 309
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 309
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 324
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 324
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 336
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 336
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 355
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 355
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 361367
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 379
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 393
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 407
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 442
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 457
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '459'-'478'). 5 459478
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '459'-'471'). 5 459471
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 460
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 483
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 483
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 485486
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 502
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 502
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 504
UselessParentheses Useless parentheses. 4 505
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 505
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 516
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 529
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '531'-'535'). 5 531535
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 532
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '535'-'539'). 5 535539
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '539'-'539'). 5 539
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '539'-'545'). 5 539545
LocalVariableCouldBeFinal Local variable 'bool' could be declared final 3 542
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 545
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '545'-'539'). 5 545539
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 565
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 584
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 584
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 586
UselessParentheses Useless parentheses. 4 587
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 598
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '600'-'604'). 5 600604
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 601
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '604'-'607'). 5 604607
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '607'-'607'). 5 607
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 620
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '622'-'633'). 5 622633
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 623
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 3 627
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 628
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'number' (lines '628'-'646'). 5 628646
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 637
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 639640
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 656
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 670
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 670
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 672
UselessParentheses Useless parentheses. 4 673
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 673
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 684
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 697
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '699'-'703'). 5 699703
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 700
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '703'-'707'). 5 703707
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 706
UselessParentheses Useless parentheses. 4 707
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '707'-'707'). 5 707
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 707
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 722
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 722
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 724
UselessParentheses Useless parentheses. 4 725
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 725
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 736
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 749
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '751'-'755'). 5 751755
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 752
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '755'-'759'). 5 755759
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 758
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 759
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 759
UselessParentheses Useless parentheses. 4 759
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '759'-'759'). 5 759
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 774
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 774
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 776
UselessParentheses Useless parentheses. 4 777
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 777
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 788
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 801
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '803'-'807'). 5 803807
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 804
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '807'-'811'). 5 807811
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 810
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 811
UselessParentheses Useless parentheses. 4 811
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '811'-'811'). 5 811
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 826
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 826
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 828
UselessParentheses Useless parentheses. 4 829
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 829
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 840
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 853
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '855'-'859'). 5 855859
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 856
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '859'-'863'). 5 859863
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 862
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 863
UselessParentheses Useless parentheses. 4 863
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 863
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '863'-'863'). 5 863
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 878
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 878
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 880
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 881
UselessParentheses Useless parentheses. 4 881
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 3 881
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 892
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 905
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '907'-'911'). 5 907911
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 908
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '911'-'915'). 5 911915
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 914
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 915
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '915'-'915'). 5 915
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 915
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 3 915
UselessParentheses Useless parentheses. 4 915
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 930
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 930
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 932
UselessParentheses Useless parentheses. 4 933
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 933
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 944
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 957
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '959'-'963'). 5 959963
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 960
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '963'-'967'). 5 963967
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 966
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '967'-'967'). 5 967
UselessParentheses Useless parentheses. 4 967
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 967
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 982
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 982
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 984
UselessParentheses Useless parentheses. 4 985
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 985
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 996
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1009
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.011'-'1.015'). 5 10111015
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1012
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.015'-'1.019'). 5 10151019
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 1018
UselessParentheses Useless parentheses. 4 1019
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1019
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1019
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.019'-'1.019'). 5 1019
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 1034
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1034
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 1036
UselessParentheses Useless parentheses. 4 1037
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1037
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1048
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1061
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.063'-'1.067'). 5 10631067
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1064
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.067'-'1.071'). 5 10671071
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 1070
UselessParentheses Useless parentheses. 4 1071
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.071'-'1.071'). 5 1071
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1071
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1085
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.087'-'1.091'). 5 10871091
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1088
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.091'-'1.095'). 5 10911095
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 1094
UselessParentheses Useless parentheses. 4 1095
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.095'-'1.095'). 5 1095
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1095
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1095
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1109
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1123
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 1123
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 1125
UselessParentheses Useless parentheses. 4 1126
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1126
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1138
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 1138
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 1140
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1141
UselessParentheses Useless parentheses. 4 1141
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1152
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1167
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.170'-'1.174'). 5 11701174
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1171
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1188
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 1188
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 1190
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1191
UselessParentheses Useless parentheses. 4 1191
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1202
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1215
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1217
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1234
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 1248
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1248
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1250
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 1263
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1263
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1279
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 1293
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1293
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1295
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1308
MethodArgumentCouldBeFinal Parameter 'values' is not assigned and could be declared final 3 1308
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1324
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1337
ShortVariable Avoid variables with short names like df 3 1353
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1353
MethodArgumentCouldBeFinal Parameter 'defaultValue' is not assigned and could be declared final 3 1353
MethodArgumentCouldBeFinal Parameter 'df' is not assigned and could be declared final 3 1353
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '1.355'-'1.363'). 5 13551363
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1356
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1384
ShortVariable Avoid variables with short names like df 3 1398
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 1398
MethodArgumentCouldBeFinal Parameter 'df' is not assigned and could be declared final 3 1398
MethodArgumentCouldBeFinal Parameter 'bean' is not assigned and could be declared final 3 1412
LocalVariableCouldBeFinal Local variable 'beanClass' could be declared final 3 1414
LocalVariableCouldBeFinal Local variable 'props' could be declared final 3 14151416
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1416
LocalVariableCouldBeFinal Local variable 'pd' could be declared final 3 1418
LocalVariableCouldBeFinal Local variable 'propname' could be declared final 3 1420
LocalVariableCouldBeFinal Local variable 'setter' could be declared final 3 1421
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 1439
ShortVariable Avoid variables with short names like sb 3 1439
LocalVariableCouldBeFinal Local variable 'name' could be declared final 3 1440
LocalVariableCouldBeFinal Local variable 'params' could be declared final 3 1445
ModifiedCyclomaticComplexity The method 'setProperty' has a Modified Cyclomatic Complexity of 16. 3 14911572
MethodArgumentCouldBeFinal Parameter 'bean' is not assigned and could be declared final 3 1491
CyclomaticComplexity The method 'setProperty(Object, PropertyDescriptor)' has a cyclomatic complexity of 25. 3 14911572
StdCyclomaticComplexity The method 'setProperty' has a Standard Cyclomatic Complexity of 16. 3 14911572
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 1492
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 1493
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 1497
LocalVariableCouldBeFinal Local variable 'setter' could be declared final 3 1501
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 1504
LocalVariableCouldBeFinal Local variable 'propclass' could be declared final 3 1508
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'arg' (lines '1.509'-'1.572'). 5 15091572
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.525'). 5 15091525
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.533'). 5 15091533
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.549'). 5 15091549
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.553'). 5 15091553
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.557'). 5 15091557
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.541'). 5 15091541
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.561'). 5 15091561
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.517'). 5 15091517
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.521'). 5 15091521
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.529'). 5 15091529
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.537'). 5 15091537
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.545'). 5 15091545
UnusedAssignment The initializer for variable 'arg' is never used (overwritten on lines 1513, 1517, 1521, 1525, 1529, 1533, 1537, 1541, 1545, 1549, 1553, 1557 and 1561) 3 1509
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'arg' (lines '1.509'-'1.513'). 5 15091513
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 1565
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 1571
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 1583
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 1585
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 1602
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 1603
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 1609
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 1623
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 3 1623
MethodArgumentCouldBeFinal Parameter 'paramName' is not assigned and could be declared final 3 1642
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 1643
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 1643
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 16451647
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 1659
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 1675
MethodArgumentCouldBeFinal Parameter 'fold' is not assigned and could be declared final 3 1675
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 16931696
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 1693
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 1695

org/apache/fulcrum/parser/CSVParser.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like in 3 61
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 3 61
ShortVariable Avoid variables with short names like in 3 73
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 3 73
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 3 73
ShortVariable Avoid variables with short names like in 3 87
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 3 87
MethodArgumentCouldBeFinal Parameter 'tokenizer' is not assigned and could be declared final 3 96
MissingOverride The method 'initTokenizer(StreamTokenizer)' is missing an @Override annotation. 3 96115

org/apache/fulcrum/parser/CookieParser.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'AGE_SESSION': the field is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'AGE_DELETE': the field is declared in an interface type 3 59
FormalParameterNamingConventions The method parameter name 'seconds_age' doesn't match '[a-z][a-zA-Z0-9]*' 1 95
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'seconds_age' is not final. 1 95

org/apache/fulcrum/parser/DataStreamParser.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 59299
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 90
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 90
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 3 101
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 3 101
ShortVariable Avoid variables with short names like in 3 101
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 3 102
EmptyCatchBlock Avoid empty catch blocks 3 115118
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 139
MissingOverride The method 'enableLogging(Logger)' is missing an @Override annotation. 3 139142
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 3 149
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 163
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 203
ShortVariable Avoid variables with short names like it 3 219
LocalVariableCouldBeFinal Local variable 'it' could be declared final 3 219
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'it' (lines '219'-'241'). 5 219241
LocalVariableCouldBeFinal Local variable 'colname' could be declared final 3 228
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 228
LocalVariableCouldBeFinal Local variable 'colval' could be declared final 3 229
MissingOverride The method 'hasNext()' is missing an @Override annotation. 3 248262
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'hasNext' (lines '250'-'254'). 5 250254
MissingOverride The method 'next()' is missing an @Override annotation. 3 271287
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 272
UnusedAssignment The initializer for variable 'nextRow' is never used (overwritten on line 278) 3 274
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'nextRow' (lines '274'-'278'). 5 274278
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'nextRow' (lines '278'-'287'). 5 278287
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 283
MissingOverride The method 'remove()' is missing an @Override annotation. 3 294298
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 295

org/apache/fulcrum/parser/DefaultCookieParser.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 64
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7073
MissingOverride The method 'dispose()' is missing an @Override annotation. 3 7883
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 80
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 81
MissingOverride The method 'getRequest()' is missing an @Override annotation. 3 9093
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 102
MissingOverride The method 'setData(HttpServletRequest, HttpServletResponse)' is missing an @Override annotation. 3 102126
MethodArgumentCouldBeFinal Parameter 'response' is not assigned and could be declared final 3 103
LocalVariableCouldBeFinal Local variable 'enc' could be declared final 3 107
ConfusingTernary Avoid if (x != y) ..; else ..; 3 108
LocalVariableCouldBeFinal Local variable 'cookies' could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 113
LocalVariableCouldBeFinal Local variable 'cookie' could be declared final 3 115
LocalVariableCouldBeFinal Local variable 'name' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 119
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 132
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 132
MissingOverride The method 'set(String, String)' is missing an @Override annotation. 3 132135
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 143
MethodArgumentCouldBeFinal Parameter 'secondsAge' is not assigned and could be declared final 3 143
MissingOverride The method 'set(String, String, int)' is missing an @Override annotation. 3 143154
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 143
LocalVariableCouldBeFinal Local variable 'cookie' could be declared final 3 150
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 163
MissingOverride The method 'unset(String)' is missing an @Override annotation. 3 163166
MissingOverride The method 'isValid()' is missing an @Override annotation. 3 171178
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 173176
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 175

org/apache/fulcrum/parser/DefaultParameterParser.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'request' 3 71
RedundantFieldInitializer Avoid using redundant field initializer for 'uploadData' 3 76
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 3 101
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 112
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 113
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 150
CyclomaticComplexity The method 'setRequest(HttpServletRequest)' has a cyclomatic complexity of 10. 3 150205
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 154
LocalVariableCouldBeFinal Local variable 'contentType' could be declared final 3 158
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 162
LocalVariableCouldBeFinal Local variable 'parts' could be declared final 3 166
LocalVariableCouldBeFinal Local variable 'p' could be declared final 3 170
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 172
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 173
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 174
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 181
LocalVariableCouldBeFinal Local variable 'names' could be declared final 3 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 186
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 188
LocalVariableCouldBeFinal Local variable 'paramName' could be declared final 3 188
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 197
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 199
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 200
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 202
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 207
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '213'-'244'). 5 213244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramName' (lines '214'-'223'). 5 214223
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramName' (lines '214'-'244'). 5 214244
UnusedAssignment The initializer for variable 'paramValue' is never used (overwritten on line 228) 3 215
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramValue' (lines '215'-'228'). 5 215228
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramValue' (lines '215'-'244'). 5 215244
LocalVariableCouldBeFinal Local variable 'st' could be declared final 3 217218
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramName' (lines '223'-'223'). 5 223
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramName' (lines '223'-'244'). 5 223244
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '224'-'244'). 5 224244
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'paramValue' (lines '228'-'228'). 5 228
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'paramValue' (lines '228'-'244'). 5 228244
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 229
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '233'-'244'). 5 233244
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 237
EmptyCatchBlock Avoid empty catch blocks 3 237243
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 246
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 250
ConfusingTernary Avoid if (x != y) ..; else ..; 3 258265
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 260
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 264
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 269
ConfusingTernary Avoid if (x != y) ..; else ..; 3 273275
MethodArgumentCouldBeFinal Parameter 'uploadData' is not assigned and could be declared final 3 284
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 312
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 312
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 329
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '333'-'337'). 5 333337
LocalVariableCouldBeFinal Local variable 'object' could be declared final 3 334
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 339
MethodArgumentCouldBeFinal Parameter 'name' is not assigned and could be declared final 3 358
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 362
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 376379
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 376379
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 376379
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 376379
MethodArgumentCouldBeFinal Parameter 'part' is not assigned and could be declared final 3 387
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'regex' (lines '392'-'418'). 5 392418
LocalVariableCouldBeFinal Local variable 'regex' could be declared final 3 392
LocalVariableCouldBeFinal Local variable 'content' could be declared final 3 394
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 397
UnusedAssignment The initializer for variable 'fnTmp' is never used (overwritten on lines 404 and 411) 3 399
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fnTmp' (lines '399'-'411'). 5 399411
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'fnTmp' (lines '399'-'404'). 5 399404
LocalVariableCouldBeFinal Local variable 'srcStr' could be declared final 3 400
LocalVariableCouldBeFinal Local variable 'regexMatcher' could be declared final 3 401
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 402
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 404
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 405
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 407
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 411
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 411
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 411
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 412
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 414
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 414

org/apache/fulcrum/parser/DefaultParserService.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=70, ATFD=80, TCC=16.667%) 3 58535
StdCyclomaticComplexity The class 'DefaultParserService' has a Standard Cyclomatic Complexity of 4 (Highest = 18). 3 58535
ModifiedCyclomaticComplexity The class 'DefaultParserService' has a Modified Cyclomatic Complexity of 3 (Highest = 18). 3 58535
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 79
RedundantFieldInitializer Avoid using redundant field initializer for 'fulcrumPoolService' 3 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 85
LongVariable Avoid excessively long variable names like fulcrumPoolService 3 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 90
LongVariable Avoid excessively long variable names like parameterParserPool 3 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 100
CallSuperInConstructor It is a good practice to call super() in a constructor 3 103105
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 107
CallSuperInConstructor It is a good practice to call super() in a constructor 3 107115
MethodArgumentCouldBeFinal Parameter 'encoding' is not assigned and could be declared final 3 130
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 144
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 158
MethodArgumentCouldBeFinal Parameter 'fold' is not assigned and could be declared final 3 173
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 173
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 177
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 191
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 197
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 203
MethodArgumentCouldBeFinal Parameter 'request' is not assigned and could be declared final 3 240
MethodArgumentCouldBeFinal Parameter 'ppClass' is not assigned and could be declared final 3 262
CyclomaticComplexity The method 'getParser(Class)' has a cyclomatic complexity of 28. 3 262347
StdCyclomaticComplexity The method 'getParser' has a Standard Cyclomatic Complexity of 18. 3 262347
ModifiedCyclomaticComplexity The method 'getParser' has a Modified Cyclomatic Complexity of 18. 3 262347
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'272'). 5 264272
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'300'). 5 264300
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'283'). 5 264283
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'vp' (lines '264'-'317'). 5 264317
ShortVariable Avoid variables with short names like vp 3 264
LocalVariableCouldBeFinal Local variable 'parserInstance' could be declared final 3 271
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'vp' (lines '272'-'347'). 5 272347
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 276
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'parserInstance' (lines '280'-'282'). 5 280282
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 287
UnusedAssignment The value assigned to variable 'parserInstance' is never used 3 290
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'parserInstance' (lines '290'-'347'). 5 290347
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 290
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 291
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 292
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 292
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 304
UnusedAssignment The value assigned to variable 'parserInstance' is never used 3 307
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 307
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 308
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 309
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 309
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 321
UnusedAssignment The value assigned to variable 'parserInstance' is never used 3 324
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 324
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 325
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 326
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 326
SimplifyConditional No need to check for null before an instanceof 3 331
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 338
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 343
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 3 359
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 368
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 372
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 377
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 384
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 396
ExcessiveMethodLength Avoid really long methods. 3 396515
StdCyclomaticComplexity The method 'configure' has a Standard Cyclomatic Complexity of 15. 3 396515
CyclomaticComplexity The method 'configure(Configuration)' has a cyclomatic complexity of 17. 3 396515
NcssCount The method 'configure(Configuration)' has a NCSS line count of 76. 3 396515
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 398
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 398
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 398
LocalVariableCouldBeFinal Local variable 'foldString' could be declared final 3 398
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 398
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 402
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 408
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 412
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 3 417418
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 417418
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 417418
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 420
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 422
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 432
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 435
LocalVariableCouldBeFinal Local variable 'config' could be declared final 3 438
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 454
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 455
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 455
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 456
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 456
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 457
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 457
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 460
LocalVariableCouldBeFinal Local variable 'poolChildren' could be declared final 3 460
LocalVariableCouldBeFinal Local variable 'genObjPoolConfig' could be declared final 3 462
LocalVariableCouldBeFinal Local variable 'poolConf' could be declared final 3 465
LocalVariableCouldBeFinal Local variable 'defaultCapacity' could be declared final 3 469
LocalVariableCouldBeFinal Local variable 'maxWaitMillis' could be declared final 3 473
LocalVariableCouldBeFinal Local variable 'blockWhenExhausted' could be declared final 3 477
LongVariable Avoid excessively long variable names like blockWhenExhausted 3 477
LocalVariableCouldBeFinal Local variable 'maxIdle' could be declared final 3 481
LocalVariableCouldBeFinal Local variable 'minIdle' could be declared final 3 485
LocalVariableCouldBeFinal Local variable 'testOnReturn' could be declared final 3 489
LocalVariableCouldBeFinal Local variable 'testOnBorrow' could be declared final 3 493
LocalVariableCouldBeFinal Local variable 'testOnCreate' could be declared final 3 497
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 510
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 511
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 512
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 3 526

org/apache/fulcrum/parser/ParserService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_DEFAULT 3 43
LongVariable Avoid excessively long variable names like PARAMETER_ENCODING_KEY 3 46
LongVariable Avoid excessively long variable names like URL_CASE_FOLDING_KEY 3 49
LongVariable Avoid excessively long variable names like FULCRUM_POOL_DEFAULT 3 55
LongVariable Avoid excessively long variable names like DEFAULT_POOL_CAPACITY 3 78
BooleanGetMethodName A getX() method which returns a boolean should be named isX() 4 137

org/apache/fulcrum/parser/StringValueParser.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 33110
MethodArgumentCouldBeFinal Parameter 'urlDecode' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'delim' is not assigned and could be declared final 3 44
ShortVariable Avoid variables with short names like s 3 44
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 44
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 45
LocalVariableCouldBeFinal Local variable 'delimChar' could be declared final 3 47
LocalVariableCouldBeFinal Local variable 'st' could be declared final 3 48
ShortVariable Avoid variables with short names like st 3 48
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '49'-'75'). 5 4975
UnusedAssignment The initializer for variable 'pathPart' is never used (overwritten on line 67) 3 50
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'pathPart' (lines '50'-'75'). 5 5075
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pathPart' (lines '50'-'67'). 5 5067
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '51'-'62'). 5 5162
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '51'-'75'). 5 5175
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'key' (lines '62'-'75'). 5 6275
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'key' (lines '62'-'62'). 5 62
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '63'-'75'). 5 6375
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'pathPart' (lines '67'-'75'). 5 6775
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pathPart' (lines '67'-'67'). 5 67
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'isNameTok' (lines '72'-'75'). 5 7275
MethodArgumentCouldBeFinal Parameter 'pairDelim' is not assigned and could be declared final 3 77
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 77
MethodArgumentCouldBeFinal Parameter 'paramDelim' is not assigned and could be declared final 3 77
ShortVariable Avoid variables with short names like s 3 77
MethodArgumentCouldBeFinal Parameter 'urlDecode' is not assigned and could be declared final 3 78
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 79
LocalVariableCouldBeFinal Local variable 'delimChar' could be declared final 3 87
LocalVariableCouldBeFinal Local variable 'st' could be declared final 3 88
ShortVariable Avoid variables with short names like st 3 88
LocalVariableCouldBeFinal Local variable 'pair' could be declared final 3 92
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 3 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 93
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 94
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '95'-'109'). 5 95109
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '95'-'95'). 5 95
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 95
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'value' (lines '100'-'109'). 5 100109
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'value' (lines '100'-'95'). 5 10095
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 103

org/apache/fulcrum/parser/TSVParser.java

Rule Violation Priority Line
ShortVariable Avoid variables with short names like in 3 62
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 3 62
ShortVariable Avoid variables with short names like in 3 74
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'in' is not assigned and could be declared final 3 88
ShortVariable Avoid variables with short names like in 3 88
MethodArgumentCouldBeFinal Parameter 'columnNames' is not assigned and could be declared final 3 88
MethodArgumentCouldBeFinal Parameter 'characterEncoding' is not assigned and could be declared final 3 88
MissingOverride The method 'initTokenizer(StreamTokenizer)' is missing an @Override annotation. 3 99112
MethodArgumentCouldBeFinal Parameter 'tokenizer' is not assigned and could be declared final 3 99

org/apache/fulcrum/parser/ValueParser.java

Rule Violation Priority Line
ExcessivePublicCount This class has a bunch of public methods and attributes 3 1774
TooManyMethods This class has too many methods, consider refactoring it. 3 50773
LongVariable Avoid excessively long variable names like DEFAULT_CHARACTER_ENCODING 3 54
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 198
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 663
UseVarargs Consider using varargs for methods or constructors which take an array the last parameter. 4 673
ShortVariable Avoid variables with short names like df 3 703
ShortVariable Avoid variables with short names like df 3 724
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 734

org/apache/fulcrum/parser/pool/BaseValueParserFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3475
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 51
MethodArgumentCouldBeFinal Parameter 'pooledObject' is not assigned and could be declared final 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 3 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 71

org/apache/fulcrum/parser/pool/BaseValueParserPool.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 41
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 55

org/apache/fulcrum/parser/pool/CookieParserFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3475
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 51
MethodArgumentCouldBeFinal Parameter 'pooledObject' is not assigned and could be declared final 3 60
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 62
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 3 69
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 71

org/apache/fulcrum/parser/pool/CookieParserPool.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 41
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 55

org/apache/fulcrum/parser/pool/DefaultParameterParserFactory.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3475
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 52
MethodArgumentCouldBeFinal Parameter 'pooledObject' is not assigned and could be declared final 3 61
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 63
MethodArgumentCouldBeFinal Parameter 'parser' is not assigned and could be declared final 3 70
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 72

org/apache/fulcrum/parser/pool/DefaultParameterParserPool.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'config' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'factory' is not assigned and could be declared final 3 57