Fulcrum Security Torque Implementation

PMD Results

The following document contains the results of PMD 6.29.0.

Violations By Priority

Priority 1

org/apache/fulcrum/security/torque/security/turbine/TorqueAbstractTurbineTurbineSecurityEntity.java

Rule	Violation	Line
FormalParameterNamingConventions	The method parameter name 'user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	57
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'user_group_role' is not final.	57
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'user_group_role' is not final.	105
FormalParameterNamingConventions	The method parameter name 'user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	105

org/apache/fulcrum/security/torque/turbine/TorqueTurbineModelManagerImpl.java

Rule	Violation	Line
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'new_user_group_role' is not final.	194
LocalVariableNamingConventions	The local variable name 'new_user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	194
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'user_group_role' is not final.	222
LocalVariableNamingConventions	The local variable name 'user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	222

Priority 2

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineUser.java

Rule	Violation	Line
AvoidReassigningParameters	Avoid reassigning parameters such as 'ugrs'	83

Priority 3

org/apache/fulcrum/security/torque/TorqueAbstractGroupManager.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	43–394
AtLeastOneConstructor	Each class should declare at least one constructor	43–394
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	56
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	60
ShortVariable	Avoid variables with short names like id	102
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	114–127
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	114
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	121
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	139
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	139–160
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	139
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	147
ShortVariable	Avoid variables with short names like g	147
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	148
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	149
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	151
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	171
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	171–181
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	193
CloseResource	Ensure that resources like this Connection object are closed after use	196
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	208
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	212
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	216
AvoidDuplicateLiterals	The String literal "Error retrieving group information" appears 4 times in this file; the first occurrence is on line 220	220
LocalVariableCouldBeFinal	Local variable 'groupSet' could be declared final	243
CloseResource	Ensure that resources like this Connection object are closed after use	244
LocalVariableCouldBeFinal	Local variable 'groups' could be declared final	251
LocalVariableCouldBeFinal	Local variable 'group' could be declared final	253
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	262
MethodArgumentCouldBeFinal	Parameter 'groupName' is not assigned and could be declared final	288
CloseResource	Ensure that resources like this Connection object are closed after use	292
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	301
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	311–312
ShortVariable	Avoid variables with short names like id	341
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	341
SimplifyConditional	No need to check for null before an instanceof	345
CloseResource	Ensure that resources like this Connection object are closed after use	347
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	359
MissingOverride	The method 'getLazyLoading()' is missing an @Override annotation.	385–388
MethodArgumentCouldBeFinal	Parameter 'lazyLoading' is not assigned and could be declared final	390
MissingOverride	The method 'setLazyLoading(Boolean)' is missing an @Override annotation.	390–393

org/apache/fulcrum/security/torque/TorqueAbstractPermissionManager.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	44–325
AbstractNaming	Abstract classes should be named AbstractXXX	44–325
UselessOverridingMethod	Overriding method merely calls super	55–58
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	55
ShortVariable	Avoid variables with short names like id	98
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	111–126
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	111
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	111
ShortVariable	Avoid variables with short names like p	117
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	117
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	118
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	119
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	120
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	137
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	137–149
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	160–168
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	160
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	163
LocalVariableCouldBeFinal	Local variable 'permissionSet' could be declared final	179
CloseResource	Ensure that resources like this Connection object are closed after use	180
LocalVariableCouldBeFinal	Local variable 'permissions' could be declared final	185
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	187
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	194
AvoidDuplicateLiterals	The String literal "Error retrieving permission information" appears 4 times in this file; the first occurrence is on line 196	196
MethodArgumentCouldBeFinal	Parameter 'permissionName' is not assigned and could be declared final	215
CloseResource	Ensure that resources like this Connection object are closed after use	218
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	226
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	232
ShortVariable	Avoid variables with short names like id	254
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	254
SimplifyConditional	No need to check for null before an instanceof	257
CloseResource	Ensure that resources like this Connection object are closed after use	258
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	269
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	296
CloseResource	Ensure that resources like this Connection object are closed after use	299
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	310
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	312
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	314

org/apache/fulcrum/security/torque/TorqueAbstractRoleManager.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	42–409
AtLeastOneConstructor	Each class should declare at least one constructor	42–409
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	55
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	59
ShortVariable	Avoid variables with short names like id	102
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	116
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	116–137
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	116
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	124
ShortVariable	Avoid variables with short names like r	124
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	125
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	126
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	128
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	148
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	148–160
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	154
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	171
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	171–188
MethodArgumentCouldBeFinal	Parameter 'roleName' is not assigned and could be declared final	199
CloseResource	Ensure that resources like this Connection object are closed after use	203
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	212
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	222
AvoidDuplicateLiterals	The String literal "Error retrieving role information" appears 4 times in this file; the first occurrence is on line 226	226
LocalVariableCouldBeFinal	Local variable 'roleSet' could be declared final	249
CloseResource	Ensure that resources like this Connection object are closed after use	250
LocalVariableCouldBeFinal	Local variable 'roles' could be declared final	256
LocalVariableCouldBeFinal	Local variable 'role' could be declared final	258
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	267
ShortVariable	Avoid variables with short names like id	296
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	296
SimplifyConditional	No need to check for null before an instanceof	300
CloseResource	Ensure that resources like this Connection object are closed after use	302
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	314
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	350
CloseResource	Ensure that resources like this Connection object are closed after use	353
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	365
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	369
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	373
MethodArgumentCouldBeFinal	Parameter 'lazyLoading' is not assigned and could be declared final	405

org/apache/fulcrum/security/torque/TorqueAbstractUserManager.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	43–320
AtLeastOneConstructor	Each class should declare at least one constructor	43–320
UselessOverridingMethod	Overriding method merely calls super	52–54
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	52
ShortVariable	Avoid variables with short names like id	96
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	108–114
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	108
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	125–134
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	125
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	127
ShortVariable	Avoid variables with short names like u	127
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	128
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	129
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	145–157
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	145
ShortVariable	Avoid variables with short names like u	148
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	148
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	149
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	150
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	151
MethodArgumentCouldBeFinal	Parameter 'userName' is not assigned and could be declared final	170
CloseResource	Ensure that resources like this Connection object are closed after use	173
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	181
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	187
MethodArgumentCouldBeFinal	Parameter 'userName' is not assigned and could be declared final	212
CloseResource	Ensure that resources like this Connection object are closed after use	214
UseLocaleWithCaseConversions	When doing a String.toLowerCase()/toUpperCase() call, use a Locale	219
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	225
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	227
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	229
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	250
LocalVariableCouldBeFinal	Local variable 'userSet' could be declared final	250
CloseResource	Ensure that resources like this Connection object are closed after use	251
LocalVariableCouldBeFinal	Local variable 'users' could be declared final	256
LocalVariableCouldBeFinal	Local variable 'user' could be declared final	258
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	266
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	288
ShortVariable	Avoid variables with short names like id	288
SimplifyConditional	No need to check for null before an instanceof	291
CloseResource	Ensure that resources like this Connection object are closed after use	292
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	303

org/apache/fulcrum/security/torque/basic/TorqueAbstractBasicGroup.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	42–215
AtLeastOneConstructor	Each class should declare at least one constructor	42–215
RedundantFieldInitializer	Avoid using redundant field initializer for 'userSet'	49
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	49
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	63
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	63
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	73
MissingOverride	The method 'addUser(User)' is missing an @Override annotation.	73–76
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	75
MissingOverride	The method 'getUsers()' is missing an @Override annotation.	81–93
MissingOverride	The method 'getUsersAsSet()' is missing an @Override annotation.	99–102
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	107
MissingOverride	The method 'removeUser(User)' is missing an @Override annotation.	107–110
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	109
MethodArgumentCouldBeFinal	Parameter 'userSet' is not assigned and could be declared final	115
MissingOverride	The method 'setUsers(UserSet)' is missing an @Override annotation.	115–125
ConfusingTernary	Avoid if (x != y) ..; else ..;	117–124
MissingOverride	The method 'setUsersAsSet(Set)' is missing an @Override annotation.	130–133
MethodArgumentCouldBeFinal	Parameter 'users' is not assigned and could be declared final	130
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	136
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	146
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	146
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	152–153
LocalVariableCouldBeFinal	Local variable 'tbug' could be declared final	155
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	169–196
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	169
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	173
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	179
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	181
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	181
ShortVariable	Avoid variables with short names like ug	181
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	192
MissingOverride	The method 'delete()' is missing an @Override annotation.	211–214

org/apache/fulcrum/security/torque/basic/TorqueAbstractBasicUser.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	42–215
AtLeastOneConstructor	Each class should declare at least one constructor	42–215
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	48
RedundantFieldInitializer	Avoid using redundant field initializer for 'groupSet'	48
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	62
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	62
MissingOverride	The method 'addGroup(Group)' is missing an @Override annotation.	72–75
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	72
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	74
MissingOverride	The method 'getGroups()' is missing an @Override annotation.	80–92
MissingOverride	The method 'getGroupsAsSet()' is missing an @Override annotation.	98–101
MissingOverride	The method 'removeGroup(Group)' is missing an @Override annotation.	106–109
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	106
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	108
MissingOverride	The method 'setGroups(GroupSet)' is missing an @Override annotation.	114–124
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	114
ConfusingTernary	Avoid if (x != y) ..; else ..;	116–123
MissingOverride	The method 'setGroupsAsSet(Set)' is missing an @Override annotation.	129–132
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	129
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	137
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	147
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	147
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	153
LocalVariableCouldBeFinal	Local variable 'tbug' could be declared final	155
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	169–196
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	169
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	173
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	179
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	181
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	181
ShortVariable	Avoid variables with short names like ug	181
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	192
MissingOverride	The method 'delete()' is missing an @Override annotation.	211–214

org/apache/fulcrum/security/torque/basic/TorqueBasicGroupManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	37–81
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	37–81
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	43
MissingOverride	The method 'doSelectAllGroups(Connection)' is missing an @Override annotation.	43–49
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	46
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	55–59
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	55
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	55
ShortVariable	Avoid variables with short names like id	55
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	65
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	65
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	65–80
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	68
LocalVariableCouldBeFinal	Local variable 't' could be declared final	73
ShortVariable	Avoid variables with short names like t	73

org/apache/fulcrum/security/torque/basic/TorqueBasicModelManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	41–216
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	41–216
CyclomaticComplexity	The method 'grant(User, Group)' has a cyclomatic complexity of 10.	53–99
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	53
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	53–99
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	53
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	55
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	55
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	56
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	56
CloseResource	Ensure that resources like this Connection object are closed after use	63
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	73
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	111
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	111–157
CyclomaticComplexity	The method 'revoke(User, Group)' has a cyclomatic complexity of 10.	111–157
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	111
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	113
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	113
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	114
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	114
CloseResource	Ensure that resources like this Connection object are closed after use	121
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	131
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	169–215
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	169
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	172
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	172
ShortVariable	Avoid variables with short names like u	176
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	176
LocalVariableCouldBeFinal	Local variable 'groups' could be declared final	179
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	179
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	179
LocalVariableCouldBeFinal	Local variable 'group' could be declared final	181
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	183
CloseResource	Ensure that resources like this Connection object are closed after use	186
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	195

org/apache/fulcrum/security/torque/basic/TorqueBasicUserManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	37–83
MissingOverride	The method 'doSelectAllUsers(Connection)' is missing an @Override annotation.	48–53
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	48
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	50
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	59–62
ShortVariable	Avoid variables with short names like id	59
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	59
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	68–82
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	70
LocalVariableCouldBeFinal	Local variable 't' could be declared final	75
ShortVariable	Avoid variables with short names like t	75

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicGroup.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	45–331
AbstractNaming	Abstract classes should be named AbstractXXX	45–331
RedundantFieldInitializer	Avoid using redundant field initializer for 'userSet'	52
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	52
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	55
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	55
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	69
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	69
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	88
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	88
MissingOverride	The method 'addUser(User)' is missing an @Override annotation.	98–101
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	98
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	100
MissingOverride	The method 'getUsers()' is missing an @Override annotation.	106–118
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	110
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	114
MissingOverride	The method 'getUsersAsSet()' is missing an @Override annotation.	124–127
MissingOverride	The method 'removeUser(User)' is missing an @Override annotation.	132–135
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	132
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	134
MethodArgumentCouldBeFinal	Parameter 'userSet' is not assigned and could be declared final	140
MissingOverride	The method 'setUsers(UserSet)' is missing an @Override annotation.	140–150
ConfusingTernary	Avoid if (x != y) ..; else ..;	142–149
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	148
MethodArgumentCouldBeFinal	Parameter 'users' is not assigned and could be declared final	155
MissingOverride	The method 'setUsersAsSet(Set)' is missing an @Override annotation.	155–158
MissingOverride	The method 'addRole(Role)' is missing an @Override annotation.	163–166
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	163
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	165
MissingOverride	The method 'getRoles()' is missing an @Override annotation.	171–183
MissingOverride	The method 'getRolesAsSet()' is missing an @Override annotation.	189–192
MissingOverride	The method 'removeRole(Role)' is missing an @Override annotation.	197–200
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	197
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	199
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	205
MissingOverride	The method 'setRoles(RoleSet)' is missing an @Override annotation.	205–215
ConfusingTernary	Avoid if (x != y) ..; else ..;	207–214
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	220
MissingOverride	The method 'setRolesAsSet(Set)' is missing an @Override annotation.	220–223
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	237
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	247
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	247
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	250
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	254
LocalVariableCouldBeFinal	Local variable 'tdug' could be declared final	256
LocalVariableCouldBeFinal	Local variable 'grouproles' could be declared final	263
LocalVariableCouldBeFinal	Local variable 'tdgr' could be declared final	265
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	278–322
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	278
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	282
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	288
ShortVariable	Avoid variables with short names like ug	290
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	290
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	290
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	299
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	305
ShortVariable	Avoid variables with short names like gr	307
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	307
LocalVariableCouldBeFinal	Local variable 'gr' could be declared final	307
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	318
MissingOverride	The method 'delete()' is missing an @Override annotation.	327–330

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicPermission.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	41–208
AbstractNaming	Abstract classes should be named AbstractXXX	41–208
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	47
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	47
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	61
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	61
MissingOverride	The method 'addRole(Role)' is missing an @Override annotation.	71–74
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	71
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	73
MissingOverride	The method 'getRoles()' is missing an @Override annotation.	79–91
MissingOverride	The method 'getRolesAsSet()' is missing an @Override annotation.	97–100
MissingOverride	The method 'removeRole(Role)' is missing an @Override annotation.	105–108
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	105
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	107
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	113
MissingOverride	The method 'setRoles(RoleSet)' is missing an @Override annotation.	113–123
ConfusingTernary	Avoid if (x != y) ..; else ..;	115–122
MissingOverride	The method 'setRolesAsSet(Set)' is missing an @Override annotation.	128–131
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	128
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	142
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	152
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	152
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	158
LocalVariableCouldBeFinal	Local variable 'tdrp' could be declared final	160
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	172
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	172–199
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	176
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	182
ShortVariable	Avoid variables with short names like rp	184
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	184
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	184
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	195
MissingOverride	The method 'delete()' is missing an @Override annotation.	204–207

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicRole.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	46–327
AbstractNaming	Abstract classes should be named AbstractXXX	46–327
RedundantFieldInitializer	Avoid using redundant field initializer for 'groupSet'	53
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	53
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	56
RedundantFieldInitializer	Avoid using redundant field initializer for 'permissionSet'	56
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	70
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	70
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	89
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	89
MissingOverride	The method 'addGroup(Group)' is missing an @Override annotation.	99–102
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	99
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	101
MissingOverride	The method 'addPermission(Permission)' is missing an @Override annotation.	107–110
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	107
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	109
MissingOverride	The method 'getGroups()' is missing an @Override annotation.	115–127
MissingOverride	The method 'getGroupsAsSet()' is missing an @Override annotation.	133–136
MissingOverride	The method 'getPermissions()' is missing an @Override annotation.	141–153
MissingOverride	The method 'getPermissionsAsSet()' is missing an @Override annotation.	159–162
MissingOverride	The method 'removeGroup(Group)' is missing an @Override annotation.	167–170
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	167
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	169
MissingOverride	The method 'removePermission(Permission)' is missing an @Override annotation.	175–178
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	175
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	177
MissingOverride	The method 'setGroups(GroupSet)' is missing an @Override annotation.	183–193
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	183
ConfusingTernary	Avoid if (x != y) ..; else ..;	185–192
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	198
MissingOverride	The method 'setGroupsAsSet(Set)' is missing an @Override annotation.	198–201
MethodArgumentCouldBeFinal	Parameter 'permissionSet' is not assigned and could be declared final	206
MissingOverride	The method 'setPermissions(PermissionSet)' is missing an @Override annotation.	206–216
ConfusingTernary	Avoid if (x != y) ..; else ..;	208–215
MethodArgumentCouldBeFinal	Parameter 'permissions' is not assigned and could be declared final	221
MissingOverride	The method 'setPermissionsAsSet(Set)' is missing an @Override annotation.	221–224
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	235
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	245
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	245
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	251
LocalVariableCouldBeFinal	Local variable 'tdrp' could be declared final	253
LocalVariableCouldBeFinal	Local variable 'grouproles' could be declared final	260
LocalVariableCouldBeFinal	Local variable 'tdgr' could be declared final	262
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	274
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	274–318
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	278
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	284
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	286
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	286
ShortVariable	Avoid variables with short names like rp	286
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	295
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	301
LocalVariableCouldBeFinal	Local variable 'gr' could be declared final	303
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	303
ShortVariable	Avoid variables with short names like gr	303
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	314
MissingOverride	The method 'delete()' is missing an @Override annotation.	323–326

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicUser.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	47–369
AtLeastOneConstructor	Each class should declare at least one constructor	47–369
RedundantFieldInitializer	Avoid using redundant field initializer for 'groupSet'	52
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	52
RedundantFieldInitializer	Avoid using redundant field initializer for 'delegators'	55
RedundantFieldInitializer	Avoid using redundant field initializer for 'delegatees'	58
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	72
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	73
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	91
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	91
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	109
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	109
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	121
MissingOverride	The method 'addGroup(Group)' is missing an @Override annotation.	121–123
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	122
MissingOverride	The method 'getGroups()' is missing an @Override annotation.	130–138
MissingOverride	The method 'getGroupsAsSet()' is missing an @Override annotation.	147–149
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	158
MissingOverride	The method 'removeGroup(Group)' is missing an @Override annotation.	158–160
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	159
MissingOverride	The method 'setGroups(GroupSet)' is missing an @Override annotation.	169–175
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	169
ConfusingTernary	Avoid if (x != y) ..; else ..;	170–174
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	184
MissingOverride	The method 'setGroupsAsSet(Set)' is missing an @Override annotation.	184–186
MissingOverride	The method 'getDelegatees()' is missing an @Override annotation.	195–201
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	197
MissingOverride	The method 'getDelegators()' is missing an @Override annotation.	210–216
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	212
MissingOverride	The method 'setDelegatees(Set)' is missing an @Override annotation.	225–231
MethodArgumentCouldBeFinal	Parameter 'delegatees' is not assigned and could be declared final	225
ConfusingTernary	Avoid if (x != y) ..; else ..;	226–230
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	227
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	229
MethodArgumentCouldBeFinal	Parameter 'delegates' is not assigned and could be declared final	240
MissingOverride	The method 'setDelegators(Set)' is missing an @Override annotation.	240–246
ConfusingTernary	Avoid if (x != y) ..; else ..;	241–245
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	242
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	244
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	263
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	272
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	272
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	278
LocalVariableCouldBeFinal	Local variable 'tdug' could be declared final	280
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	284
LocalVariableCouldBeFinal	Local variable 'delegatorlist' could be declared final	286–287
LocalVariableCouldBeFinal	Local variable 'tdud' could be declared final	289
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	293
LocalVariableCouldBeFinal	Local variable 'delegateelist' could be declared final	295–296
LocalVariableCouldBeFinal	Local variable 'tdud' could be declared final	298
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	310
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	310–361
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	312
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	318
ShortVariable	Avoid variables with short names like ug	319
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	319
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	319
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	327
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	333
ShortVariable	Avoid variables with short names like ud	334
LocalVariableCouldBeFinal	Local variable 'ud' could be declared final	334
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	334
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	342
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	348
ShortVariable	Avoid variables with short names like ud	349
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	349
LocalVariableCouldBeFinal	Local variable 'ud' could be declared final	349
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	358
MissingOverride	The method 'delete()' is missing an @Override annotation.	366–368

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicGroupManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	37–79
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	37–79
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	43
MissingOverride	The method 'doSelectAllGroups(Connection)' is missing an @Override annotation.	43–48
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	45
ShortVariable	Avoid variables with short names like id	54
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	54
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	54
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	54–57
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	63
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	63–78
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	63
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	65
LocalVariableCouldBeFinal	Local variable 'groups' could be declared final	70
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	72
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	77

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicModelManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	45–447
CyclomaticComplexity	The class 'TorqueDynamicModelManagerImpl' has a total cyclomatic complexity of 80 (highest 10).	45–447
GodClass	Possible God Class (WMC=80, ATFD=64, TCC=0.000%)	45–447
CyclomaticComplexity	The method 'revoke(Group, Role)' has a cyclomatic complexity of 10.	62–98
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	62–98
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	62
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	62
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	63
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	63
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	64
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	64
CloseResource	Ensure that resources like this Connection object are closed after use	70
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	79
AvoidDuplicateLiterals	The String literal "') failed" appears 8 times in this file; the first occurrence is on line 81	81
AvoidDuplicateLiterals	The String literal "', '" appears 8 times in this file; the first occurrence is on line 81	81
AvoidDuplicateLiterals	The String literal "Unknown group '" appears 4 times in this file; the first occurrence is on line 92	92
AvoidDuplicateLiterals	The String literal "Unknown role '" appears 4 times in this file; the first occurrence is on line 96	96
CyclomaticComplexity	The method 'grant(Role, Permission)' has a cyclomatic complexity of 10.	110–148
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	110–148
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	110
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	110
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	112
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	112
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	113
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	113
CloseResource	Ensure that resources like this Connection object are closed after use	119
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	128
CyclomaticComplexity	The method 'revoke(Role, Permission)' has a cyclomatic complexity of 10.	160–199
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	160
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	160
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	160–199
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	162
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	162
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	163
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	163
CloseResource	Ensure that resources like this Connection object are closed after use	169
EmptyStatementNotInLoop	An empty statement (semicolon) not part of a loop	173
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	179
CyclomaticComplexity	The method 'grant(User, Group)' has a cyclomatic complexity of 10.	213–249
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	213
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	213
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	213–249
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	214
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	214
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	215
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	215
CloseResource	Ensure that resources like this Connection object are closed after use	221
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	230
AvoidDuplicateLiterals	The String literal "Unknown user '" appears 6 times in this file; the first occurrence is on line 247	247
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	263
CyclomaticComplexity	The method 'revoke(User, Group)' has a cyclomatic complexity of 10.	263–299
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	263–299
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	263
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	264
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	264
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	265
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	265
CloseResource	Ensure that resources like this Connection object are closed after use	271
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	280
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	311
CyclomaticComplexity	The method 'grant(Group, Role)' has a cyclomatic complexity of 10.	311–347
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	311
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	311–347
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	312
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	312
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	313
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	313
CloseResource	Ensure that resources like this Connection object are closed after use	319
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	328
CyclomaticComplexity	The method 'addDelegate(User, User)' has a cyclomatic complexity of 10.	359–396
MethodArgumentCouldBeFinal	Parameter 'delegatee' is not assigned and could be declared final	359
MethodArgumentCouldBeFinal	Parameter 'delegator' is not assigned and could be declared final	359
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	359–396
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	361
LocalVariableCouldBeFinal	Local variable 'delegatorExists' could be declared final	361
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	362
LocalVariableCouldBeFinal	Local variable 'delegateeExists' could be declared final	362
CloseResource	Ensure that resources like this Connection object are closed after use	367
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	376
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	409–446
MethodArgumentCouldBeFinal	Parameter 'delegatee' is not assigned and could be declared final	409
MethodArgumentCouldBeFinal	Parameter 'delegator' is not assigned and could be declared final	409
CyclomaticComplexity	The method 'removeDelegate(User, User)' has a cyclomatic complexity of 10.	409–446
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	411
LocalVariableCouldBeFinal	Local variable 'delegatorExists' could be declared final	411
LocalVariableCouldBeFinal	Local variable 'delegateeExists' could be declared final	412
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	412
CloseResource	Ensure that resources like this Connection object are closed after use	417
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	426

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicPermissionManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	37–84
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	48
MissingOverride	The method 'doSelectAllPermissions(Connection)' is missing an @Override annotation.	48–53
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	50
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	59
ShortVariable	Avoid variables with short names like id	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	59–62
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	59
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	68–83
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	70
LocalVariableCouldBeFinal	Local variable 'permissions' could be declared final	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	77
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	82

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicRoleManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	37–84
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	48
MissingOverride	The method 'doSelectAllRoles(Connection)' is missing an @Override annotation.	48–53
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	50
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	59
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	59
ShortVariable	Avoid variables with short names like id	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	59–62
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	68–83
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	70
LocalVariableCouldBeFinal	Local variable 'roles' could be declared final	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	77
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	82

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicUserManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	37–84
MissingOverride	The method 'doSelectAllUsers(Connection)' is missing an @Override annotation.	48–53
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	48
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	50
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	59
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	59–62
ShortVariable	Avoid variables with short names like id	59
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	68–83
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	70
LocalVariableCouldBeFinal	Local variable 'users' could be declared final	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	77
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	82

org/apache/fulcrum/security/torque/om/TorqueBasicGroupPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueBasicUserGroupPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueBasicUserPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupRolePeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicPermissionPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePermissionPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicUserDelegatesPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicUserGroupPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueDynamicUserPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueTurbineGroupPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueTurbinePermissionPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermission.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	20–49
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	33
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	43

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermissionPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRole.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	20–59
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	33
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	43
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	53

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRolePeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRolePeerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	19–32
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	27
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	27

org/apache/fulcrum/security/torque/om/TorqueTurbineUserPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TurbineGroupPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TurbinePermissionPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TurbineRolePeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TurbineRolePermissionPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TurbineUserGroupRolePeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/om/TurbineUserPeer.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	13–17

org/apache/fulcrum/security/torque/peer/PeerManagable.java

Rule	Violation	Line
UnnecessaryModifier	Unnecessary modifiers 'public abstract' on method 'getPeerManager': the method is declared in an interface type	25
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getPeerInstance': the method is declared in an interface type	27
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getCustomPeer': the method is declared in an interface type	29
UnnecessaryModifier	Unnecessary modifier 'public' on method 'setCustomPeer': the method is declared in an interface type	30
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getPeerClassName': the method is declared in an interface type	32
UnnecessaryModifier	Unnecessary modifier 'public' on method 'setPeerClassName': the method is declared in an interface type	34

org/apache/fulcrum/security/torque/peer/PeerManager.java

Rule	Violation	Line
UnnecessaryModifier	Unnecessary modifiers 'public abstract' on method 'getPeerInstance': the method is declared in an interface type	52–53
UnnecessaryModifier	Unnecessary modifiers 'public abstract' on method 'getPeerInstance': the method is declared in an interface type	64

org/apache/fulcrum/security/torque/peer/PeerManagerDefaultImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	39–84
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	45
ImmutableField	Private field 'peers' could be made final; it is only initialized in the declaration or constructor.	45
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	45
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	51
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	61
MethodArgumentCouldBeFinal	Parameter 'peerInterface' is not assigned and could be declared final	61
MethodArgumentCouldBeFinal	Parameter 'className' is not assigned and could be declared final	61
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	64
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	65
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	69
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	69
LocalVariableCouldBeFinal	Local variable 'peer' could be declared final	69
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	70
AvoidCatchingThrowable	A catch statement should never catch throwable since it includes errors.	77–80

org/apache/fulcrum/security/torque/peer/TorqueTurbinePeer.java

Rule	Violation	Line
ShortVariable	Avoid variables with short names like pk	47

org/apache/fulcrum/security/torque/peer/TurbineRolePermissionPeerMapper.java

Rule	Violation	Line
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getTurbinePermission': the method is declared in an interface type	83–84

org/apache/fulcrum/security/torque/peer/managers/PeerGroupManager.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	35–110
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	35–110
DataClass	The class 'PeerGroupManager' is suspected to be a Data Class (WOC=22.222%, NOPA=0, NOAM=7, WMC=11)	35–110
AtLeastOneConstructor	Each class should declare at least one constructor	35–110
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	40
DefaultPackage	Use explicit scoping instead of the default package private level	40
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	41
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	49
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	53
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	62
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	82
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	93
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	105

org/apache/fulcrum/security/torque/peer/managers/PeerPermissionManager.java

Rule	Violation	Line
DataClass	The class 'PeerPermissionManager' is suspected to be a Data Class (WOC=22.222%, NOPA=0, NOAM=7, WMC=11)	34–110
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	34–110
AtLeastOneConstructor	Each class should declare at least one constructor	34–110
AbstractNaming	Abstract classes should be named AbstractXXX	34–110
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	39
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	40
DefaultPackage	Use explicit scoping instead of the default package private level	40
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	48
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	53
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	67
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	79
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	86
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	106

org/apache/fulcrum/security/torque/peer/managers/PeerRoleManager.java

Rule	Violation	Line
DataClass	The class 'PeerRoleManager' is suspected to be a Data Class (WOC=22.222%, NOPA=0, NOAM=7, WMC=11)	34–112
AbstractNaming	Abstract classes should be named AbstractXXX	34–112
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	34–112
AtLeastOneConstructor	Each class should declare at least one constructor	34–112
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	39
DefaultPackage	Use explicit scoping instead of the default package private level	40
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	40
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	48
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	53
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	63
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	83
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	95
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	107

org/apache/fulcrum/security/torque/peer/managers/PeerUserManager.java

Rule	Violation	Line
DataClass	The class 'PeerUserManager' is suspected to be a Data Class (WOC=21.429%, NOPA=0, NOAM=11, WMC=22)	35–175
AtLeastOneConstructor	Each class should declare at least one constructor	35–175
AbstractNaming	Abstract classes should be named AbstractXXX	35–175
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	48
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	49
DefaultPackage	Use explicit scoping instead of the default package private level	49
LongVariable	Avoid excessively long variable names like columnName4UserGroupRole	53
LongVariable	Avoid excessively long variable names like userGroupRolePeerClassName	55
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	61
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	66
LocalVariableCouldBeFinal	Local variable 'userGroupRoleConf' could be declared final	72
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	72
ForLoopCanBeForeach	This for loop can be replaced by a foreach loop	73–83
LocalVariableCouldBeFinal	Local variable 'configuration' could be declared final	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	76
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	76
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	77
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	94
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	98
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	118
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	133
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	145
LongVariable	Avoid excessively long variable names like userGroupRolePeerClassName	157
MethodArgumentCouldBeFinal	Parameter 'userGroupRolePeerClassName' is not assigned and could be declared final	157
MethodArgumentCouldBeFinal	Parameter 'columnName4UserGroupRole' is not assigned and could be declared final	169
LongVariable	Avoid excessively long variable names like columnName4UserGroupRole	169

org/apache/fulcrum/security/torque/security/TorqueAbstractSecurityEntity.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	33–148
AtLeastOneConstructor	Each class should declare at least one constructor	33–148
ShortVariable	Avoid variables with short names like id	52
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	115
ShortVariable	Avoid variables with short names like id	115
EmptyCatchBlock	Avoid empty catch blocks	121–124
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	140
UseLocaleWithCaseConversions	When doing a String.toLowerCase()/toUpperCase() call, use a Locale	144

org/apache/fulcrum/security/torque/security/turbine/TorqueAbstractTurbineTurbineSecurityEntity.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	35–131
AtLeastOneConstructor	Each class should declare at least one constructor	35–131
RedundantFieldInitializer	Avoid using redundant field initializer for 'userGroupRoleSet'	42
MissingOverride	The method 'addUserGroupRole(TurbineUserGroupRole)' is missing an @Override annotation.	47–50
MethodArgumentCouldBeFinal	Parameter 'userGroupRole' is not assigned and could be declared final	47
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	49
MethodArgumentCouldBeFinal	Parameter 'isLazilyLoaded' is not assigned and could be declared final	57
MethodArgumentCouldBeFinal	Parameter 'user_group_role' is not assigned and could be declared final	57
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	60
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	64
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	77
MissingOverride	The method 'getUserGroupRoleSet()' is missing an @Override annotation.	87–90
MissingOverride	The method 'removeUserGroupRole(TurbineUserGroupRole)' is missing an @Override annotation.	95–98
MethodArgumentCouldBeFinal	Parameter 'userGroupRole' is not assigned and could be declared final	95
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	97
MethodArgumentCouldBeFinal	Parameter 'isLazilyLoaded' is not assigned and could be declared final	105
MethodArgumentCouldBeFinal	Parameter 'user_group_role' is not assigned and could be declared final	105
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	108
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	112
MissingOverride	The method 'setUserGroupRoleSet(Set)' is missing an @Override annotation.	119–129
MethodArgumentCouldBeFinal	Parameter 'userGroupRoleSet' is not assigned and could be declared final	119
ConfusingTernary	Avoid if (x != y) ..; else ..;	121–128
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	127

org/apache/fulcrum/security/torque/security/turbine/TorqueAbstractTurbineTurbineSecurityEntityDefault.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	37–56
AtLeastOneConstructor	Each class should declare at least one constructor	37–56

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineGroup.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	42–178
AtLeastOneConstructor	Each class should declare at least one constructor	42–178
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	78
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	78
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	82
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	82
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	84
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	86
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	88
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	88
CloseResource	Ensure that resources like this Connection object are closed after use	109
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	117
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	140
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	144
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	145
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	147
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	153
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	155
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	155
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	156
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	157
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	158
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	164

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbinePermission.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	42–212
AtLeastOneConstructor	Each class should declare at least one constructor	42–212
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	49
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	49
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	63
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	63
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	74
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	76
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	111
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	113
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	120
ConfusingTernary	Avoid if (x != y) ..; else ..;	122–129
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	136
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	142
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	152
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	152
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	159
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	161
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	175
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	179
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	185
ShortVariable	Avoid variables with short names like rp	187
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	187
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	187
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	198

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineRole.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	47–305
AtLeastOneConstructor	Each class should declare at least one constructor	47–305
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	54
RedundantFieldInitializer	Avoid using redundant field initializer for 'permissionSet'	54
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	87
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	87
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	98
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	100
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	135
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	137
MethodArgumentCouldBeFinal	Parameter 'permissionSet' is not assigned and could be declared final	144
ConfusingTernary	Avoid if (x != y) ..; else ..;	146–153
MethodArgumentCouldBeFinal	Parameter 'permissions' is not assigned and could be declared final	160
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	166
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	177
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	177
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	183
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	185
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	191
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	191
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	193
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	195
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	197
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	197
CloseResource	Ensure that resources like this Connection object are closed after use	219
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	227
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	250
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	254
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	260
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	262
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	262
ShortVariable	Avoid variables with short names like rp	262

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineUser.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	45–199
AbstractNaming	Abstract classes should be named AbstractXXX	45–199
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	83
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	83
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	86
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	86
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	103
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	103
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	106
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	106
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	108
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	122
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	132
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	136
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	139
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	145
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	147
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	147
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	148
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	149
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	150
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	156
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	177
MethodArgumentCouldBeFinal	Parameter 'userGroupRoleSet' is not assigned and could be declared final	178
MethodArgumentCouldBeFinal	Parameter 'ugrs' is not assigned and could be declared final	179
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	183
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	185
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	185

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineGroup.java

Rule	Violation	Line
AbstractNaming	Abstract classes should be named AbstractXXX	42–173
AtLeastOneConstructor	Each class should declare at least one constructor	42–173
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	68
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	78
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	78
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	82
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	82
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	83
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	85
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	87
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	87
CloseResource	Ensure that resources like this Connection object are closed after use	105
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	113
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	135
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	139
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	142
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	148
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	150
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	150
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	151
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	152
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	153
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	159

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbinePermission.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	41–212
AbstractNaming	Abstract classes should be named AbstractXXX	41–212
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	48
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	48
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	62
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	62
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	72
MissingOverride	The method 'addRole(Role)' is missing an @Override annotation.	72–75
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	74
MissingOverride	The method 'getRoles()' is missing an @Override annotation.	80–92
MissingOverride	The method 'getRolesAsSet()' is missing an @Override annotation.	98–101
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	106
MissingOverride	The method 'removeRole(Role)' is missing an @Override annotation.	106–109
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	108
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	114
MissingOverride	The method 'setRoles(RoleSet)' is missing an @Override annotation.	114–124
ConfusingTernary	Avoid if (x != y) ..; else ..;	116–123
MissingOverride	The method 'setRolesAsSet(Set)' is missing an @Override annotation.	129–132
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	129
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	146
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	156
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	156
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	162
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	164
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	176
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	176–203
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	180
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	186
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	188
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	188
ShortVariable	Avoid variables with short names like rp	188
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	199
MissingOverride	The method 'delete()' is missing an @Override annotation.	208–211

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineRole.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	48–314
AbstractNaming	Abstract classes should be named AbstractXXX	48–314
RedundantFieldInitializer	Avoid using redundant field initializer for 'permissionSet'	54
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	54
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	69
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	69
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	86
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	87
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	99
MissingOverride	The method 'addPermission(Permission)' is missing an @Override annotation.	99–101
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	100
MissingOverride	The method 'getPermissions()' is missing an @Override annotation.	109–117
MissingOverride	The method 'getPermissionsAsSet()' is missing an @Override annotation.	126–128
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	137
MissingOverride	The method 'removePermission(Permission)' is missing an @Override annotation.	137–139
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	138
MethodArgumentCouldBeFinal	Parameter 'permissionSet' is not assigned and could be declared final	148
MissingOverride	The method 'setPermissions(PermissionSet)' is missing an @Override annotation.	148–154
ConfusingTernary	Avoid if (x != y) ..; else ..;	149–153
MethodArgumentCouldBeFinal	Parameter 'permissions' is not assigned and could be declared final	162
MissingOverride	The method 'setPermissionsAsSet(Set)' is missing an @Override annotation.	162–164
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	181
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	192
MissingOverride	The method 'retrieveAttachedObjects(Connection, Boolean)' is missing an @Override annotation.	192–222
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	192
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	196–197
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	199
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	204
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	204
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	206–207
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	209
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	210
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	210
CloseResource	Ensure that resources like this Connection object are closed after use	233
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	240
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	260–302
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	260
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	262
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	268
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	269
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	269
ShortVariable	Avoid variables with short names like rp	269
MissingOverride	The method 'delete()' is missing an @Override annotation.	311–313

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineUser.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	44–147
AbstractNaming	Abstract classes should be named AbstractXXX	44–147
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	61
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	61
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	72
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	82
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	82
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	86
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	86
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	87
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	89
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	91
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	91
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	108
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	112
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	115
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	121
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	123
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	123
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	124
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	125
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	126
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	132

org/apache/fulcrum/security/torque/turbine/TorqueTurbineGroupManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	43–167
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	55
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	57
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	62
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	63
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	63
ShortVariable	Avoid variables with short names like id	81
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	81
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	81
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	86
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	87
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	87
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	104
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	104
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	106
UnusedAssignment	The initializer for variable 'groups' is never used (overwritten on lines 117 and 125)	109
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	114
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	116
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	116
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	117
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	128
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	133
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	137
CloseResource	Ensure that resources like this Connection object are closed after use	138
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	148

org/apache/fulcrum/security/torque/turbine/TorqueTurbineModelManagerImpl.java

Rule	Violation	Line
GodClass	Possible God Class (WMC=76, ATFD=49, TCC=0.000%)	48–376
AtLeastOneConstructor	Each class should declare at least one constructor	48–376
TooManyMethods	This class has too many methods, consider refactoring it.	49–376
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	63
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	63
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	63–114
CyclomaticComplexity	The method 'grant(Role, Permission)' has a cyclomatic complexity of 12.	63–114
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	66
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	66
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	67
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	67
CloseResource	Ensure that resources like this Connection object are closed after use	78
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	88
AvoidDuplicateLiterals	The String literal "', '" appears 6 times in this file; the first occurrence is on line 92	92
AvoidDuplicateLiterals	The String literal "Unknown role '" appears 5 times in this file; the first occurrence is on line 107	107
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	125–164
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	125
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	125
CyclomaticComplexity	The method 'revoke(Role, Permission)' has a cyclomatic complexity of 11.	125–164
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	128
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	128
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	129
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	129
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	142
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	168
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	168
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	168
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	168–171
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	174
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	174
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	174
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	174–179
IfStmtsMustUseBraces	Avoid using if statements without curly braces	177–178
ControlStatementBraces	This statement should have braces	178
MethodArgumentCouldBeFinal	Parameter 'newRole' is not assigned and could be declared final	182
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	182
MethodArgumentCouldBeFinal	Parameter 'oldRole' is not assigned and could be declared final	182
LocalVariableCouldBeFinal	Local variable 'group' could be declared final	185
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	191
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	191
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	191
LocalVariableCouldBeFinal	Local variable 'new_user_group_role' could be declared final	194
LongVariable	Avoid excessively long variable names like new_user_group_role	194
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	218
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	218
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	218
CyclomaticComplexity	The method 'removeUserGroupRole(User, Role, Group)' has a cyclomatic complexity of 11.	218–253
LocalVariableCouldBeFinal	Local variable 'user_group_role' could be declared final	222
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	224
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	225
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	226
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	255
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	255
CyclomaticComplexity	The method 'checkExists(User, Group, Role)' has a cyclomatic complexity of 10.	255–281
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	255
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	257
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	257
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	258
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	258
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	259
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	259
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	263
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	283
CyclomaticComplexity	The method 'checkExists(User, Role, Role, Group)' has a cyclomatic complexity of 11.	283–308
MethodArgumentCouldBeFinal	Parameter 'oldRole' is not assigned and could be declared final	283
MethodArgumentCouldBeFinal	Parameter 'globalGroup' is not assigned and could be declared final	283
MethodArgumentCouldBeFinal	Parameter 'newRole' is not assigned and could be declared final	283
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	285
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	285
LocalVariableCouldBeFinal	Local variable 'oldRoleExists' could be declared final	286
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	286
LocalVariableCouldBeFinal	Local variable 'newRoleExists' could be declared final	287
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	287
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	291
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	310
MethodArgumentCouldBeFinal	Parameter 'newRole' is not assigned and could be declared final	310
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	310
MethodArgumentCouldBeFinal	Parameter 'privilege' is not assigned and could be declared final	310
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	310
LawOfDemeter	Potential violation of Law of Demeter (static property access)	327
MethodArgumentCouldBeFinal	Parameter 'privilege' is not assigned and could be declared final	336
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	336
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	336
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	336
MethodArgumentCouldBeFinal	Parameter 'logChars' is not assigned and could be declared final	342
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	342
CloseResource	Ensure that resources like this Connection object are closed after use	345
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	358
IdenticalCatchBranches	'catch' branch identical to 'TorqueException' branch	364–367
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	364

org/apache/fulcrum/security/torque/turbine/TorqueTurbinePermissionManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	38–131
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	50
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	52
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	57
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	58
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	58
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	76
ShortVariable	Avoid variables with short names like id	76
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	76
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	81
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	82
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	82
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	98
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	98
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	100
UnusedAssignment	The initializer for variable 'permissions' is never used (overwritten on lines 111 and 120)	105
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	109
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	110
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	110
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	111
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	123
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	128

org/apache/fulcrum/security/torque/turbine/TorqueTurbineRoleManagerImpl.java

Rule	Violation	Line
AtLeastOneConstructor	Each class should declare at least one constructor	38–127
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	49
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	51
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	56
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	58
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	58
ShortVariable	Avoid variables with short names like id	74
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	74
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	74
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	79
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	81
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	81
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	97
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	97
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	99
UnusedAssignment	The initializer for variable 'roles' is never used (overwritten on lines 110 and 118)	103
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	107
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	109
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	109
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	110
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	121
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	125

org/apache/fulcrum/security/torque/turbine/TorqueTurbineUserManagerImpl.java

Rule	Violation	Line
GodClass	Possible God Class (WMC=50, ATFD=12, TCC=0.000%)	47–373
AtLeastOneConstructor	Each class should declare at least one constructor	47–373
LocalVariableCouldBeFinal	Local variable 'anonUser' could be declared final	63
UnnecessaryLocalBeforeReturn	Consider simply returning the value vs storing it in local variable 'anonUser'	65
ShortVariable	Avoid variables with short names like u	77
MethodArgumentCouldBeFinal	Parameter 'u' is not assigned and could be declared final	77
LocalVariableCouldBeFinal	Local variable 'anon' could be declared final	81
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	84
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	87
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	89
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	100
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	102
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	107
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	108
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	108
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	124
ShortVariable	Avoid variables with short names like id	124
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	124
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	129
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	130
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	130
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	146
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	146
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	148
UnusedAssignment	The initializer for variable 'users' is never used (overwritten on lines 159 and 167)	153
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	157
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	158
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	158
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	159
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	171
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	176
MethodArgumentCouldBeFinal	Parameter 'userName' is not assigned and could be declared final	191
CloseResource	Ensure that resources like this Connection object are closed after use	194
UseLocaleWithCaseConversions	When doing a String.toLowerCase()/toUpperCase() call, use a Locale	200
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	206
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	210
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	214
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	241
LocalVariableCouldBeFinal	Local variable 'userSet' could be declared final	241
CloseResource	Ensure that resources like this Connection object are closed after use	242
LocalVariableCouldBeFinal	Local variable 'users' could be declared final	248
LocalVariableCouldBeFinal	Local variable 'user' could be declared final	250
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	259
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	288
ShortVariable	Avoid variables with short names like id	288
SimplifyConditional	No need to check for null before an instanceof	292
CloseResource	Ensure that resources like this Connection object are closed after use	294
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	306
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	339
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	339
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	345–346
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	347
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	349
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	349
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	350
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	350

Priority 4

org/apache/fulcrum/security/torque/TorqueAbstractGroupManager.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.util.EntityExistsException'	29

org/apache/fulcrum/security/torque/TorqueAbstractPermissionManager.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.util.EntityExistsException'	30

org/apache/fulcrum/security/torque/TorqueAbstractRoleManager.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.util.EntityExistsException'	29

org/apache/fulcrum/security/torque/om/TorqueBasicGroup.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueBasicGroupPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueBasicGroupPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueBasicUser.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueBasicUserGroup.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueBasicUserGroupPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueBasicUserGroupPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueBasicUserPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueBasicUserPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroup.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupRole.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupRolePeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupRolePeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicPermission.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicPermissionPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicPermissionPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRole.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePermission.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePermissionPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePermissionPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUser.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicUserDelegates.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegates' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicUserDelegatesPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegatesPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserDelegatesPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegatesPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserGroup.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueDynamicUserGroupPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserGroupPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineGroup.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueTurbineGroupPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineGroupPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbinePermission.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueTurbinePermissionPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbinePermissionPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRole.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermission.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	21

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermissionPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermissionPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineUser.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRole.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	21

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRolePeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRolePeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	20

org/apache/fulcrum/security/torque/om/TorqueTurbineUserPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TorqueTurbineUserPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineGroup.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TurbineGroupPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineGroupPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbinePermission.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbinePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TurbinePermissionPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbinePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbinePermissionPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbinePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineRole.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TurbineRolePeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineRolePeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineRolePermission.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TurbineRolePermissionPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineRolePermissionPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineUser.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TurbineUserGroupRole.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	15

org/apache/fulcrum/security/torque/om/TurbineUserGroupRolePeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineUserGroupRolePeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineUserPeer.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/om/TurbineUserPeerImpl.java

Rule	Violation	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	14

org/apache/fulcrum/security/torque/peer/Peer.java

Rule	Violation	Line
ShortClassName	Avoid short class names like Peer	28–31

org/apache/fulcrum/security/torque/peer/PeerManager.java

Rule	Violation	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.spi.AbstractEntityManager'	22

org/apache/fulcrum/security/torque/turbine/TorqueTurbineGroupManagerImpl.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	59
UselessParentheses	Useless parentheses.	83
UselessParentheses	Useless parentheses.	111

org/apache/fulcrum/security/torque/turbine/TorqueTurbinePermissionManagerImpl.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	54
UselessParentheses	Useless parentheses.	78
UselessParentheses	Useless parentheses.	106

org/apache/fulcrum/security/torque/turbine/TorqueTurbineRoleManagerImpl.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	53
UselessParentheses	Useless parentheses.	76
UselessParentheses	Useless parentheses.	104

org/apache/fulcrum/security/torque/turbine/TorqueTurbineUserManagerImpl.java

Rule	Violation	Line
UselessParentheses	Useless parentheses.	104
UselessParentheses	Useless parentheses.	126
UselessParentheses	Useless parentheses.	154

Priority 5

org/apache/fulcrum/security/torque/TorqueAbstractGroupManager.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'group' (lines '195'-'202').	195–202
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '196'-'200').	196–200
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '208'-'231').	208–231
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'groupSet' (lines '243'-'277').	243–277
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '244'-'249').	244–249
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '262'-'277').	262–277
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '290'-'303').	290–303
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '292'-'296').	292–296
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '301'-'327').	301–327
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '303'-'307').	303–307
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '307'-'327').	307–327
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '347'-'351').	347–351
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '359'-'383').	359–383

org/apache/fulcrum/security/torque/TorqueAbstractPermissionManager.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'permissionSet' (lines '179'-'204').	179–204
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '180'-'183').	180–183
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '194'-'204').	194–204
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '216'-'228').	216–228
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '218'-'221').	218–221
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '226'-'242').	226–242
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '228'-'230').	228–230
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '230'-'242').	230–242
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '258'-'261').	258–261
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '269'-'284').	269–284
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'permission' (lines '298'-'304').	298–304
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '299'-'302').	299–302
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '310'-'324').	310–324

org/apache/fulcrum/security/torque/TorqueAbstractRoleManager.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '201'-'214').	201–214
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '203'-'207').	203–207
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '212'-'237').	212–237
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '214'-'218').	214–218
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '218'-'237').	218–237
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'roleSet' (lines '249'-'282').	249–282
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '250'-'254').	250–254
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '267'-'282').	267–282
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '302'-'306').	302–306
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '314'-'338').	314–338
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'role' (lines '352'-'359').	352–359
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '353'-'357').	353–357
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '365'-'388').	365–388

org/apache/fulcrum/security/torque/TorqueAbstractUserManager.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '171'-'183').	171–183
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '173'-'176').	173–176
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '181'-'197').	181–197
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '183'-'185').	183–185
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '185'-'197').	185–197
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'user' (lines '213'-'219').	213–219
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '214'-'217').	214–217
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '225'-'239').	225–239
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'userSet' (lines '250'-'276').	250–276
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '251'-'254').	251–254
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '266'-'276').	266–276
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '292'-'295').	292–295
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '303'-'318').	303–318

org/apache/fulcrum/security/torque/basic/TorqueBasicModelManagerImpl.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '63'-'67').	63–67
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '73'-'99').	73–99
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '121'-'125').	121–125
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '131'-'157').	131–157
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '186'-'190').	186–190
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '195'-'215').	195–215

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicModelManagerImpl.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '70'-'73').	70–73
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '79'-'98').	79–98
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '119'-'122').	119–122
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '128'-'148').	128–148
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '169'-'172').	169–172
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '179'-'199').	179–199
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '221'-'224').	221–224
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '230'-'249').	230–249
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '271'-'274').	271–274
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '280'-'299').	280–299
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '319'-'322').	319–322
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '328'-'347').	328–347
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '367'-'370').	367–370
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '376'-'396').	376–396
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '417'-'420').	417–420
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '426'-'446').	426–446

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineGroup.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '109'-'112').	109–112
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '117'-'134').	117–134

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineRole.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '219'-'222').	219–222
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '227'-'243').	227–243

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineGroup.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '105'-'108').	105–108
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '113'-'129').	113–129

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineRole.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '233'-'235').	233–235
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '240'-'251').	240–251

org/apache/fulcrum/security/torque/turbine/TorqueTurbineGroupManagerImpl.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'groups' (lines '109'-'117').	109–117
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'groups' (lines '109'-'125').	109–125
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'groups' (lines '117'-'134').	117–134
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '138'-'165').	138–165
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '138'-'143').	138–143
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '148'-'165').	148–165

org/apache/fulcrum/security/torque/turbine/TorqueTurbineModelManagerImpl.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '78'-'82').	78–82
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '88'-'114').	88–114
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'ugrFound' (lines '221'-'228').	221–228
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'logChars' (lines '313'-'327').	313–327
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '345'-'349').	345–349
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '358'-'375').	358–375

org/apache/fulcrum/security/torque/turbine/TorqueTurbinePermissionManagerImpl.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'permissions' (lines '105'-'120').	105–120
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'permissions' (lines '105'-'111').	105–111
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'permissions' (lines '111'-'129').	111–129

org/apache/fulcrum/security/torque/turbine/TorqueTurbineRoleManagerImpl.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'roles' (lines '103'-'110').	103–110
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'roles' (lines '103'-'118').	103–118
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'roles' (lines '110'-'126').	110–126

org/apache/fulcrum/security/torque/turbine/TorqueTurbineUserManagerImpl.java

Rule	Violation	Line
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'users' (lines '153'-'167').	153–167
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'users' (lines '153'-'159').	153–159
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'users' (lines '159'-'177').	159–177
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'user' (lines '193'-'200').	193–200
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '194'-'198').	194–198
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '206'-'229').	206–229
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'userSet' (lines '241'-'274').	241–274
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '242'-'246').	242–246
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '259'-'274').	259–274
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '294'-'298').	294–298
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '306'-'330').	306–330
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'ugrs' (lines '350'-'371').	350–371

Files

org/apache/fulcrum/security/torque/TorqueAbstractGroupManager.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.util.EntityExistsException'	4	29
AbstractNaming	Abstract classes should be named AbstractXXX	3	43–394
AtLeastOneConstructor	Each class should declare at least one constructor	3	43–394
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	56
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	60
ShortVariable	Avoid variables with short names like id	3	102
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	114–127
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	114
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	121
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	139
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	139–160
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	139
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	3	147
ShortVariable	Avoid variables with short names like g	3	147
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	148
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	149
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	151
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	171
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	171–181
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	193
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'group' (lines '195'-'202').	5	195–202
CloseResource	Ensure that resources like this Connection object are closed after use	3	196
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '196'-'200').	5	196–200
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	208
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '208'-'231').	5	208–231
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	212
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	216
AvoidDuplicateLiterals	The String literal "Error retrieving group information" appears 4 times in this file; the first occurrence is on line 220	3	220
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'groupSet' (lines '243'-'277').	5	243–277
LocalVariableCouldBeFinal	Local variable 'groupSet' could be declared final	3	243
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '244'-'249').	5	244–249
CloseResource	Ensure that resources like this Connection object are closed after use	3	244
LocalVariableCouldBeFinal	Local variable 'groups' could be declared final	3	251
LocalVariableCouldBeFinal	Local variable 'group' could be declared final	3	253
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '262'-'277').	5	262–277
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	262
MethodArgumentCouldBeFinal	Parameter 'groupName' is not assigned and could be declared final	3	288
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '290'-'303').	5	290–303
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '292'-'296').	5	292–296
CloseResource	Ensure that resources like this Connection object are closed after use	3	292
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	301
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '301'-'327').	5	301–327
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '303'-'307').	5	303–307
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '307'-'327').	5	307–327
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	311–312
ShortVariable	Avoid variables with short names like id	3	341
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	341
SimplifyConditional	No need to check for null before an instanceof	3	345
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '347'-'351').	5	347–351
CloseResource	Ensure that resources like this Connection object are closed after use	3	347
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	359
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '359'-'383').	5	359–383
MissingOverride	The method 'getLazyLoading()' is missing an @Override annotation.	3	385–388
MethodArgumentCouldBeFinal	Parameter 'lazyLoading' is not assigned and could be declared final	3	390
MissingOverride	The method 'setLazyLoading(Boolean)' is missing an @Override annotation.	3	390–393

org/apache/fulcrum/security/torque/TorqueAbstractPermissionManager.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.util.EntityExistsException'	4	30
AtLeastOneConstructor	Each class should declare at least one constructor	3	44–325
AbstractNaming	Abstract classes should be named AbstractXXX	3	44–325
UselessOverridingMethod	Overriding method merely calls super	3	55–58
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	55
ShortVariable	Avoid variables with short names like id	3	98
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	111–126
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	111
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	111
ShortVariable	Avoid variables with short names like p	3	117
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	3	117
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	118
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	119
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	120
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	137
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	137–149
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	160–168
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	160
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	163
LocalVariableCouldBeFinal	Local variable 'permissionSet' could be declared final	3	179
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'permissionSet' (lines '179'-'204').	5	179–204
CloseResource	Ensure that resources like this Connection object are closed after use	3	180
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '180'-'183').	5	180–183
LocalVariableCouldBeFinal	Local variable 'permissions' could be declared final	3	185
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	3	187
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '194'-'204').	5	194–204
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	194
AvoidDuplicateLiterals	The String literal "Error retrieving permission information" appears 4 times in this file; the first occurrence is on line 196	3	196
MethodArgumentCouldBeFinal	Parameter 'permissionName' is not assigned and could be declared final	3	215
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '216'-'228').	5	216–228
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '218'-'221').	5	218–221
CloseResource	Ensure that resources like this Connection object are closed after use	3	218
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '226'-'242').	5	226–242
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	226
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '228'-'230').	5	228–230
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '230'-'242').	5	230–242
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	232
ShortVariable	Avoid variables with short names like id	3	254
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	254
SimplifyConditional	No need to check for null before an instanceof	3	257
CloseResource	Ensure that resources like this Connection object are closed after use	3	258
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '258'-'261').	5	258–261
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '269'-'284').	5	269–284
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	269
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	296
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'permission' (lines '298'-'304').	5	298–304
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '299'-'302').	5	299–302
CloseResource	Ensure that resources like this Connection object are closed after use	3	299
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	310
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '310'-'324').	5	310–324
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	312
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	314

org/apache/fulcrum/security/torque/TorqueAbstractRoleManager.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.util.EntityExistsException'	4	29
AbstractNaming	Abstract classes should be named AbstractXXX	3	42–409
AtLeastOneConstructor	Each class should declare at least one constructor	3	42–409
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	55
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	59
ShortVariable	Avoid variables with short names like id	3	102
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	116
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	116–137
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	116
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	3	124
ShortVariable	Avoid variables with short names like r	3	124
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	125
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	126
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	128
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	148
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	148–160
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	154
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	171
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	171–188
MethodArgumentCouldBeFinal	Parameter 'roleName' is not assigned and could be declared final	3	199
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '201'-'214').	5	201–214
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '203'-'207').	5	203–207
CloseResource	Ensure that resources like this Connection object are closed after use	3	203
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	212
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '212'-'237').	5	212–237
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '214'-'218').	5	214–218
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '218'-'237').	5	218–237
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	222
AvoidDuplicateLiterals	The String literal "Error retrieving role information" appears 4 times in this file; the first occurrence is on line 226	3	226
LocalVariableCouldBeFinal	Local variable 'roleSet' could be declared final	3	249
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'roleSet' (lines '249'-'282').	5	249–282
CloseResource	Ensure that resources like this Connection object are closed after use	3	250
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '250'-'254').	5	250–254
LocalVariableCouldBeFinal	Local variable 'roles' could be declared final	3	256
LocalVariableCouldBeFinal	Local variable 'role' could be declared final	3	258
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '267'-'282').	5	267–282
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	267
ShortVariable	Avoid variables with short names like id	3	296
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	296
SimplifyConditional	No need to check for null before an instanceof	3	300
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '302'-'306').	5	302–306
CloseResource	Ensure that resources like this Connection object are closed after use	3	302
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	314
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '314'-'338').	5	314–338
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	350
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'role' (lines '352'-'359').	5	352–359
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '353'-'357').	5	353–357
CloseResource	Ensure that resources like this Connection object are closed after use	3	353
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '365'-'388').	5	365–388
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	365
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	369
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	373
MethodArgumentCouldBeFinal	Parameter 'lazyLoading' is not assigned and could be declared final	3	405

org/apache/fulcrum/security/torque/TorqueAbstractUserManager.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	43–320
AtLeastOneConstructor	Each class should declare at least one constructor	3	43–320
UselessOverridingMethod	Overriding method merely calls super	3	52–54
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	52
ShortVariable	Avoid variables with short names like id	3	96
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	108–114
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	108
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	125–134
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	125
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	3	127
ShortVariable	Avoid variables with short names like u	3	127
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	128
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	129
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	145–157
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	145
ShortVariable	Avoid variables with short names like u	3	148
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	3	148
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	149
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	150
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	151
MethodArgumentCouldBeFinal	Parameter 'userName' is not assigned and could be declared final	3	170
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '171'-'183').	5	171–183
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '173'-'176').	5	173–176
CloseResource	Ensure that resources like this Connection object are closed after use	3	173
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '181'-'197').	5	181–197
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	181
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'exists' (lines '183'-'185').	5	183–185
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'exists' (lines '185'-'197').	5	185–197
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	187
MethodArgumentCouldBeFinal	Parameter 'userName' is not assigned and could be declared final	3	212
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'user' (lines '213'-'219').	5	213–219
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '214'-'217').	5	214–217
CloseResource	Ensure that resources like this Connection object are closed after use	3	214
UseLocaleWithCaseConversions	When doing a String.toLowerCase()/toUpperCase() call, use a Locale	3	219
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	225
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '225'-'239').	5	225–239
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	227
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	229
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'userSet' (lines '250'-'276').	5	250–276
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	250
LocalVariableCouldBeFinal	Local variable 'userSet' could be declared final	3	250
CloseResource	Ensure that resources like this Connection object are closed after use	3	251
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '251'-'254').	5	251–254
LocalVariableCouldBeFinal	Local variable 'users' could be declared final	3	256
LocalVariableCouldBeFinal	Local variable 'user' could be declared final	3	258
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '266'-'276').	5	266–276
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	266
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	288
ShortVariable	Avoid variables with short names like id	3	288
SimplifyConditional	No need to check for null before an instanceof	3	291
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '292'-'295').	5	292–295
CloseResource	Ensure that resources like this Connection object are closed after use	3	292
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	303
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '303'-'318').	5	303–318

org/apache/fulcrum/security/torque/basic/TorqueAbstractBasicGroup.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	42–215
AtLeastOneConstructor	Each class should declare at least one constructor	3	42–215
RedundantFieldInitializer	Avoid using redundant field initializer for 'userSet'	3	49
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	49
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	63
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	63
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	73
MissingOverride	The method 'addUser(User)' is missing an @Override annotation.	3	73–76
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	75
MissingOverride	The method 'getUsers()' is missing an @Override annotation.	3	81–93
MissingOverride	The method 'getUsersAsSet()' is missing an @Override annotation.	3	99–102
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	107
MissingOverride	The method 'removeUser(User)' is missing an @Override annotation.	3	107–110
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	109
MethodArgumentCouldBeFinal	Parameter 'userSet' is not assigned and could be declared final	3	115
MissingOverride	The method 'setUsers(UserSet)' is missing an @Override annotation.	3	115–125
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	117–124
MissingOverride	The method 'setUsersAsSet(Set)' is missing an @Override annotation.	3	130–133
MethodArgumentCouldBeFinal	Parameter 'users' is not assigned and could be declared final	3	130
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	136
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	146
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	146
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	3	152–153
LocalVariableCouldBeFinal	Local variable 'tbug' could be declared final	3	155
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	169–196
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	169
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	173
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	3	179
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	3	181
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	181
ShortVariable	Avoid variables with short names like ug	3	181
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	192
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	211–214

org/apache/fulcrum/security/torque/basic/TorqueAbstractBasicUser.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	42–215
AtLeastOneConstructor	Each class should declare at least one constructor	3	42–215
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	48
RedundantFieldInitializer	Avoid using redundant field initializer for 'groupSet'	3	48
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	62
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	62
MissingOverride	The method 'addGroup(Group)' is missing an @Override annotation.	3	72–75
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	72
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	74
MissingOverride	The method 'getGroups()' is missing an @Override annotation.	3	80–92
MissingOverride	The method 'getGroupsAsSet()' is missing an @Override annotation.	3	98–101
MissingOverride	The method 'removeGroup(Group)' is missing an @Override annotation.	3	106–109
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	106
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	108
MissingOverride	The method 'setGroups(GroupSet)' is missing an @Override annotation.	3	114–124
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	3	114
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	116–123
MissingOverride	The method 'setGroupsAsSet(Set)' is missing an @Override annotation.	3	129–132
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	3	129
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	137
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	147
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	147
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	3	153
LocalVariableCouldBeFinal	Local variable 'tbug' could be declared final	3	155
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	169–196
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	169
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	173
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	3	179
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	181
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	3	181
ShortVariable	Avoid variables with short names like ug	3	181
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	192
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	211–214

org/apache/fulcrum/security/torque/basic/TorqueBasicGroupManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	37–81
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	3	37–81
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	43
MissingOverride	The method 'doSelectAllGroups(Connection)' is missing an @Override annotation.	3	43–49
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	46
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	3	55–59
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	55
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	55
ShortVariable	Avoid variables with short names like id	3	55
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	65
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	65
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	3	65–80
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	68
LocalVariableCouldBeFinal	Local variable 't' could be declared final	3	73
ShortVariable	Avoid variables with short names like t	3	73

org/apache/fulcrum/security/torque/basic/TorqueBasicModelManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	41–216
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	3	41–216
CyclomaticComplexity	The method 'grant(User, Group)' has a cyclomatic complexity of 10.	3	53–99
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	53
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	53–99
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	53
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	3	55
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	55
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	3	56
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	56
CloseResource	Ensure that resources like this Connection object are closed after use	3	63
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '63'-'67').	5	63–67
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '73'-'99').	5	73–99
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	73
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	111
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	111–157
CyclomaticComplexity	The method 'revoke(User, Group)' has a cyclomatic complexity of 10.	3	111–157
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	111
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	3	113
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	113
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	3	114
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	114
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '121'-'125').	5	121–125
CloseResource	Ensure that resources like this Connection object are closed after use	3	121
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	131
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '131'-'157').	5	131–157
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	169–215
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	169
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	3	172
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	172
ShortVariable	Avoid variables with short names like u	3	176
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	3	176
LocalVariableCouldBeFinal	Local variable 'groups' could be declared final	3	179
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	179
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	179
LocalVariableCouldBeFinal	Local variable 'group' could be declared final	3	181
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	183
CloseResource	Ensure that resources like this Connection object are closed after use	3	186
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '186'-'190').	5	186–190
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '195'-'215').	5	195–215
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	195

org/apache/fulcrum/security/torque/basic/TorqueBasicUserManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	37–83
MissingOverride	The method 'doSelectAllUsers(Connection)' is missing an @Override annotation.	3	48–53
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	48
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	50
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	3	59–62
ShortVariable	Avoid variables with short names like id	3	59
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	59
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	3	68–82
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	70
LocalVariableCouldBeFinal	Local variable 't' could be declared final	3	75
ShortVariable	Avoid variables with short names like t	3	75

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicGroup.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	45–331
AbstractNaming	Abstract classes should be named AbstractXXX	3	45–331
RedundantFieldInitializer	Avoid using redundant field initializer for 'userSet'	3	52
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	52
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	55
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	3	55
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	69
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	69
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	88
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	88
MissingOverride	The method 'addUser(User)' is missing an @Override annotation.	3	98–101
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	98
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	100
MissingOverride	The method 'getUsers()' is missing an @Override annotation.	3	106–118
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	110
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	114
MissingOverride	The method 'getUsersAsSet()' is missing an @Override annotation.	3	124–127
MissingOverride	The method 'removeUser(User)' is missing an @Override annotation.	3	132–135
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	132
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	134
MethodArgumentCouldBeFinal	Parameter 'userSet' is not assigned and could be declared final	3	140
MissingOverride	The method 'setUsers(UserSet)' is missing an @Override annotation.	3	140–150
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	142–149
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	148
MethodArgumentCouldBeFinal	Parameter 'users' is not assigned and could be declared final	3	155
MissingOverride	The method 'setUsersAsSet(Set)' is missing an @Override annotation.	3	155–158
MissingOverride	The method 'addRole(Role)' is missing an @Override annotation.	3	163–166
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	163
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	165
MissingOverride	The method 'getRoles()' is missing an @Override annotation.	3	171–183
MissingOverride	The method 'getRolesAsSet()' is missing an @Override annotation.	3	189–192
MissingOverride	The method 'removeRole(Role)' is missing an @Override annotation.	3	197–200
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	197
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	199
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	3	205
MissingOverride	The method 'setRoles(RoleSet)' is missing an @Override annotation.	3	205–215
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	207–214
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	3	220
MissingOverride	The method 'setRolesAsSet(Set)' is missing an @Override annotation.	3	220–223
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	237
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	247
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	247
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	250
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	3	254
LocalVariableCouldBeFinal	Local variable 'tdug' could be declared final	3	256
LocalVariableCouldBeFinal	Local variable 'grouproles' could be declared final	3	263
LocalVariableCouldBeFinal	Local variable 'tdgr' could be declared final	3	265
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	278–322
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	278
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	282
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	3	288
ShortVariable	Avoid variables with short names like ug	3	290
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	3	290
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	290
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	299
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	3	305
ShortVariable	Avoid variables with short names like gr	3	307
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	307
LocalVariableCouldBeFinal	Local variable 'gr' could be declared final	3	307
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	318
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	327–330

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicPermission.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	41–208
AbstractNaming	Abstract classes should be named AbstractXXX	3	41–208
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	3	47
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	47
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	61
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	61
MissingOverride	The method 'addRole(Role)' is missing an @Override annotation.	3	71–74
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	71
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	73
MissingOverride	The method 'getRoles()' is missing an @Override annotation.	3	79–91
MissingOverride	The method 'getRolesAsSet()' is missing an @Override annotation.	3	97–100
MissingOverride	The method 'removeRole(Role)' is missing an @Override annotation.	3	105–108
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	105
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	107
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	3	113
MissingOverride	The method 'setRoles(RoleSet)' is missing an @Override annotation.	3	113–123
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	115–122
MissingOverride	The method 'setRolesAsSet(Set)' is missing an @Override annotation.	3	128–131
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	3	128
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	142
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	152
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	152
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	3	158
LocalVariableCouldBeFinal	Local variable 'tdrp' could be declared final	3	160
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	172
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	172–199
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	176
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	3	182
ShortVariable	Avoid variables with short names like rp	3	184
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	184
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	3	184
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	195
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	204–207

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicRole.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	46–327
AbstractNaming	Abstract classes should be named AbstractXXX	3	46–327
RedundantFieldInitializer	Avoid using redundant field initializer for 'groupSet'	3	53
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	53
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	56
RedundantFieldInitializer	Avoid using redundant field initializer for 'permissionSet'	3	56
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	70
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	70
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	89
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	89
MissingOverride	The method 'addGroup(Group)' is missing an @Override annotation.	3	99–102
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	99
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	101
MissingOverride	The method 'addPermission(Permission)' is missing an @Override annotation.	3	107–110
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	107
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	109
MissingOverride	The method 'getGroups()' is missing an @Override annotation.	3	115–127
MissingOverride	The method 'getGroupsAsSet()' is missing an @Override annotation.	3	133–136
MissingOverride	The method 'getPermissions()' is missing an @Override annotation.	3	141–153
MissingOverride	The method 'getPermissionsAsSet()' is missing an @Override annotation.	3	159–162
MissingOverride	The method 'removeGroup(Group)' is missing an @Override annotation.	3	167–170
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	167
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	169
MissingOverride	The method 'removePermission(Permission)' is missing an @Override annotation.	3	175–178
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	175
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	177
MissingOverride	The method 'setGroups(GroupSet)' is missing an @Override annotation.	3	183–193
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	3	183
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	185–192
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	3	198
MissingOverride	The method 'setGroupsAsSet(Set)' is missing an @Override annotation.	3	198–201
MethodArgumentCouldBeFinal	Parameter 'permissionSet' is not assigned and could be declared final	3	206
MissingOverride	The method 'setPermissions(PermissionSet)' is missing an @Override annotation.	3	206–216
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	208–215
MethodArgumentCouldBeFinal	Parameter 'permissions' is not assigned and could be declared final	3	221
MissingOverride	The method 'setPermissionsAsSet(Set)' is missing an @Override annotation.	3	221–224
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	235
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	245
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	245
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	3	251
LocalVariableCouldBeFinal	Local variable 'tdrp' could be declared final	3	253
LocalVariableCouldBeFinal	Local variable 'grouproles' could be declared final	3	260
LocalVariableCouldBeFinal	Local variable 'tdgr' could be declared final	3	262
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	274
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	274–318
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	278
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	3	284
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	286
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	3	286
ShortVariable	Avoid variables with short names like rp	3	286
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	295
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	3	301
LocalVariableCouldBeFinal	Local variable 'gr' could be declared final	3	303
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	303
ShortVariable	Avoid variables with short names like gr	3	303
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	314
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	323–326

org/apache/fulcrum/security/torque/dynamic/TorqueAbstractDynamicUser.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	47–369
AtLeastOneConstructor	Each class should declare at least one constructor	3	47–369
RedundantFieldInitializer	Avoid using redundant field initializer for 'groupSet'	3	52
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	52
RedundantFieldInitializer	Avoid using redundant field initializer for 'delegators'	3	55
RedundantFieldInitializer	Avoid using redundant field initializer for 'delegatees'	3	58
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	72
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	73
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	91
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	91
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	109
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	109
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	121
MissingOverride	The method 'addGroup(Group)' is missing an @Override annotation.	3	121–123
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	122
MissingOverride	The method 'getGroups()' is missing an @Override annotation.	3	130–138
MissingOverride	The method 'getGroupsAsSet()' is missing an @Override annotation.	3	147–149
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	158
MissingOverride	The method 'removeGroup(Group)' is missing an @Override annotation.	3	158–160
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	159
MissingOverride	The method 'setGroups(GroupSet)' is missing an @Override annotation.	3	169–175
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	3	169
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	170–174
MethodArgumentCouldBeFinal	Parameter 'groups' is not assigned and could be declared final	3	184
MissingOverride	The method 'setGroupsAsSet(Set)' is missing an @Override annotation.	3	184–186
MissingOverride	The method 'getDelegatees()' is missing an @Override annotation.	3	195–201
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	197
MissingOverride	The method 'getDelegators()' is missing an @Override annotation.	3	210–216
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	212
MissingOverride	The method 'setDelegatees(Set)' is missing an @Override annotation.	3	225–231
MethodArgumentCouldBeFinal	Parameter 'delegatees' is not assigned and could be declared final	3	225
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	226–230
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	227
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	229
MethodArgumentCouldBeFinal	Parameter 'delegates' is not assigned and could be declared final	3	240
MissingOverride	The method 'setDelegators(Set)' is missing an @Override annotation.	3	240–246
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	241–245
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	242
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	244
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	263
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	272
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	272
LocalVariableCouldBeFinal	Local variable 'usergroups' could be declared final	3	278
LocalVariableCouldBeFinal	Local variable 'tdug' could be declared final	3	280
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	284
LocalVariableCouldBeFinal	Local variable 'delegatorlist' could be declared final	3	286–287
LocalVariableCouldBeFinal	Local variable 'tdud' could be declared final	3	289
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	293
LocalVariableCouldBeFinal	Local variable 'delegateelist' could be declared final	3	295–296
LocalVariableCouldBeFinal	Local variable 'tdud' could be declared final	3	298
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	310
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	310–361
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	312
LocalVariableCouldBeFinal	Local variable 'g' could be declared final	3	318
ShortVariable	Avoid variables with short names like ug	3	319
LocalVariableCouldBeFinal	Local variable 'ug' could be declared final	3	319
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	319
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	327
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	3	333
ShortVariable	Avoid variables with short names like ud	3	334
LocalVariableCouldBeFinal	Local variable 'ud' could be declared final	3	334
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	334
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	342
LocalVariableCouldBeFinal	Local variable 'u' could be declared final	3	348
ShortVariable	Avoid variables with short names like ud	3	349
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	349
LocalVariableCouldBeFinal	Local variable 'ud' could be declared final	3	349
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	358
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	366–368

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicGroupManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	37–79
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	3	37–79
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	43
MissingOverride	The method 'doSelectAllGroups(Connection)' is missing an @Override annotation.	3	43–48
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	45
ShortVariable	Avoid variables with short names like id	3	54
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	54
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	54
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	3	54–57
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	63
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	3	63–78
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	63
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	65
LocalVariableCouldBeFinal	Local variable 'groups' could be declared final	3	70
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	72
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	77

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicModelManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	45–447
CyclomaticComplexity	The class 'TorqueDynamicModelManagerImpl' has a total cyclomatic complexity of 80 (highest 10).	3	45–447
GodClass	Possible God Class (WMC=80, ATFD=64, TCC=0.000%)	3	45–447
CyclomaticComplexity	The method 'revoke(Group, Role)' has a cyclomatic complexity of 10.	3	62–98
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	62–98
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	62
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	62
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	3	63
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	63
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	3	64
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	64
CloseResource	Ensure that resources like this Connection object are closed after use	3	70
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '70'-'73').	5	70–73
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '79'-'98').	5	79–98
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	79
AvoidDuplicateLiterals	The String literal "') failed" appears 8 times in this file; the first occurrence is on line 81	3	81
AvoidDuplicateLiterals	The String literal "', '" appears 8 times in this file; the first occurrence is on line 81	3	81
AvoidDuplicateLiterals	The String literal "Unknown group '" appears 4 times in this file; the first occurrence is on line 92	3	92
AvoidDuplicateLiterals	The String literal "Unknown role '" appears 4 times in this file; the first occurrence is on line 96	3	96
CyclomaticComplexity	The method 'grant(Role, Permission)' has a cyclomatic complexity of 10.	3	110–148
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	110–148
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	110
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	110
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	112
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	3	112
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	113
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	3	113
CloseResource	Ensure that resources like this Connection object are closed after use	3	119
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '119'-'122').	5	119–122
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '128'-'148').	5	128–148
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	128
CyclomaticComplexity	The method 'revoke(Role, Permission)' has a cyclomatic complexity of 10.	3	160–199
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	160
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	160
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	160–199
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	162
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	3	162
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	3	163
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	163
CloseResource	Ensure that resources like this Connection object are closed after use	3	169
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '169'-'172').	5	169–172
EmptyStatementNotInLoop	An empty statement (semicolon) not part of a loop	3	173
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '179'-'199').	5	179–199
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	179
CyclomaticComplexity	The method 'grant(User, Group)' has a cyclomatic complexity of 10.	3	213–249
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	213
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	213
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	213–249
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	3	214
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	214
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	3	215
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	215
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '221'-'224').	5	221–224
CloseResource	Ensure that resources like this Connection object are closed after use	3	221
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	230
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '230'-'249').	5	230–249
AvoidDuplicateLiterals	The String literal "Unknown user '" appears 6 times in this file; the first occurrence is on line 247	3	247
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	263
CyclomaticComplexity	The method 'revoke(User, Group)' has a cyclomatic complexity of 10.	3	263–299
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	263–299
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	263
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	264
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	3	264
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	3	265
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	265
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '271'-'274').	5	271–274
CloseResource	Ensure that resources like this Connection object are closed after use	3	271
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '280'-'299').	5	280–299
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	280
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	311
CyclomaticComplexity	The method 'grant(Group, Role)' has a cyclomatic complexity of 10.	3	311–347
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	311
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	311–347
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	312
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	3	312
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	3	313
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	313
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '319'-'322').	5	319–322
CloseResource	Ensure that resources like this Connection object are closed after use	3	319
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '328'-'347').	5	328–347
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	328
CyclomaticComplexity	The method 'addDelegate(User, User)' has a cyclomatic complexity of 10.	3	359–396
MethodArgumentCouldBeFinal	Parameter 'delegatee' is not assigned and could be declared final	3	359
MethodArgumentCouldBeFinal	Parameter 'delegator' is not assigned and could be declared final	3	359
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	359–396
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	361
LocalVariableCouldBeFinal	Local variable 'delegatorExists' could be declared final	3	361
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	362
LocalVariableCouldBeFinal	Local variable 'delegateeExists' could be declared final	3	362
CloseResource	Ensure that resources like this Connection object are closed after use	3	367
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '367'-'370').	5	367–370
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '376'-'396').	5	376–396
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	376
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	409–446
MethodArgumentCouldBeFinal	Parameter 'delegatee' is not assigned and could be declared final	3	409
MethodArgumentCouldBeFinal	Parameter 'delegator' is not assigned and could be declared final	3	409
CyclomaticComplexity	The method 'removeDelegate(User, User)' has a cyclomatic complexity of 10.	3	409–446
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	411
LocalVariableCouldBeFinal	Local variable 'delegatorExists' could be declared final	3	411
LocalVariableCouldBeFinal	Local variable 'delegateeExists' could be declared final	3	412
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	412
CloseResource	Ensure that resources like this Connection object are closed after use	3	417
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '417'-'420').	5	417–420
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	426
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '426'-'446').	5	426–446

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicPermissionManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	37–84
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	48
MissingOverride	The method 'doSelectAllPermissions(Connection)' is missing an @Override annotation.	3	48–53
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	50
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	59
ShortVariable	Avoid variables with short names like id	3	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	3	59–62
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	59
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	3	68–83
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	70
LocalVariableCouldBeFinal	Local variable 'permissions' could be declared final	3	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	77
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	82

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicRoleManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	37–84
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	48
MissingOverride	The method 'doSelectAllRoles(Connection)' is missing an @Override annotation.	3	48–53
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	50
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	59
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	59
ShortVariable	Avoid variables with short names like id	3	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	3	59–62
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	3	68–83
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	70
LocalVariableCouldBeFinal	Local variable 'roles' could be declared final	3	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	77
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	82

org/apache/fulcrum/security/torque/dynamic/TorqueDynamicUserManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	37–84
MissingOverride	The method 'doSelectAllUsers(Connection)' is missing an @Override annotation.	3	48–53
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	48
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	50
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	59
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	59
MissingOverride	The method 'doSelectById(Integer, Connection)' is missing an @Override annotation.	3	59–62
ShortVariable	Avoid variables with short names like id	3	59
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	68
MissingOverride	The method 'doSelectByName(String, Connection)' is missing an @Override annotation.	3	68–83
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	70
LocalVariableCouldBeFinal	Local variable 'users' could be declared final	3	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	77
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	82

org/apache/fulcrum/security/torque/om/TorqueBasicGroup.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueBasicGroupPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueBasicGroupPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueBasicUser.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueBasicUserGroup.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueBasicUserGroupPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueBasicUserGroupPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueBasicUserPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueBasicUserPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueBasicUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroup.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupRole.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupRolePeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicGroupRolePeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicGroupRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicPermission.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicPermissionPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicPermissionPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicPermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRole.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePermission.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePermissionPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicRolePermissionPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicRolePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUser.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicUserDelegates.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegates' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicUserDelegatesPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegatesPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserDelegatesPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserDelegatesPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserGroup.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueDynamicUserGroupPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserGroupPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueDynamicUserPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueDynamicUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineGroup.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueTurbineGroupPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineGroupPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbinePermission.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueTurbinePermissionPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbinePermissionPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbinePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRole.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermission.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	20–49
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	21
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	3	33
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	3	43

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermissionPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineRolePermissionPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineRolePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineUser.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRole.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	20–59
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	21
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	3	33
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	3	43
MethodArgumentCouldBeFinal	Parameter 'connection' is not assigned and could be declared final	3	53

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRolePeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineUserGroupRolePeerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	19–32
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserGroupRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	20
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	27
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	27

org/apache/fulcrum/security/torque/om/TorqueTurbineUserPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TorqueTurbineUserPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTorqueTurbineUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineGroup.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineGroup' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TurbineGroupPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineGroupPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineGroupPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineGroupPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbinePermission.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbinePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TurbinePermissionPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbinePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbinePermissionPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbinePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineRole.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TurbineRolePeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineRolePeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineRolePermission.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePermission' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TurbineRolePermissionPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePermissionPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineRolePermissionPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineRolePermissionPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineUser.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUser' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TurbineUserGroupRole.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRole' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	15

org/apache/fulcrum/security/torque/om/TurbineUserGroupRolePeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineUserGroupRolePeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserGroupRolePeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineUserPeer.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	13–17
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserPeer' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/om/TurbineUserPeerImpl.java

Rule	Violation	Priority	Line
UnnecessaryFullyQualifiedName	Unnecessary use of fully qualified name 'org.apache.fulcrum.security.torque.om.BaseTurbineUserPeerImpl' due to existing same package import 'org.apache.fulcrum.security.torque.om.*'	4	14

org/apache/fulcrum/security/torque/peer/Peer.java

Rule	Violation	Priority	Line
ShortClassName	Avoid short class names like Peer	4	28–31

org/apache/fulcrum/security/torque/peer/PeerManagable.java

Rule	Violation	Priority	Line
UnnecessaryModifier	Unnecessary modifiers 'public abstract' on method 'getPeerManager': the method is declared in an interface type	3	25
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getPeerInstance': the method is declared in an interface type	3	27
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getCustomPeer': the method is declared in an interface type	3	29
UnnecessaryModifier	Unnecessary modifier 'public' on method 'setCustomPeer': the method is declared in an interface type	3	30
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getPeerClassName': the method is declared in an interface type	3	32
UnnecessaryModifier	Unnecessary modifier 'public' on method 'setPeerClassName': the method is declared in an interface type	3	34

org/apache/fulcrum/security/torque/peer/PeerManager.java

Rule	Violation	Priority	Line
UnusedImports	Avoid unused imports such as 'org.apache.fulcrum.security.spi.AbstractEntityManager'	4	22
UnnecessaryModifier	Unnecessary modifiers 'public abstract' on method 'getPeerInstance': the method is declared in an interface type	3	52–53
UnnecessaryModifier	Unnecessary modifiers 'public abstract' on method 'getPeerInstance': the method is declared in an interface type	3	64

org/apache/fulcrum/security/torque/peer/PeerManagerDefaultImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	39–84
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	45
ImmutableField	Private field 'peers' could be made final; it is only initialized in the declaration or constructor.	3	45
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	45
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	3	51
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	3	61
MethodArgumentCouldBeFinal	Parameter 'peerInterface' is not assigned and could be declared final	3	61
MethodArgumentCouldBeFinal	Parameter 'className' is not assigned and could be declared final	3	61
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	64
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	65
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	69
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	69
LocalVariableCouldBeFinal	Local variable 'peer' could be declared final	3	69
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	70
AvoidCatchingThrowable	A catch statement should never catch throwable since it includes errors.	3	77–80

org/apache/fulcrum/security/torque/peer/TorqueTurbinePeer.java

Rule	Violation	Priority	Line
ShortVariable	Avoid variables with short names like pk	3	47

org/apache/fulcrum/security/torque/peer/TurbineRolePermissionPeerMapper.java

Rule	Violation	Priority	Line
UnnecessaryModifier	Unnecessary modifier 'public' on method 'getTurbinePermission': the method is declared in an interface type	3	83–84

org/apache/fulcrum/security/torque/peer/managers/PeerGroupManager.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	35–110
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	3	35–110
DataClass	The class 'PeerGroupManager' is suspected to be a Data Class (WOC=22.222%, NOPA=0, NOAM=7, WMC=11)	3	35–110
AtLeastOneConstructor	Each class should declare at least one constructor	3	35–110
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	3	40
DefaultPackage	Use explicit scoping instead of the default package private level	3	40
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	3	41
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	49
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	53
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	62
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	3	82
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	3	93
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	3	105

org/apache/fulcrum/security/torque/peer/managers/PeerPermissionManager.java

Rule	Violation	Priority	Line
DataClass	The class 'PeerPermissionManager' is suspected to be a Data Class (WOC=22.222%, NOPA=0, NOAM=7, WMC=11)	3	34–110
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	3	34–110
AtLeastOneConstructor	Each class should declare at least one constructor	3	34–110
AbstractNaming	Abstract classes should be named AbstractXXX	3	34–110
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	3	39
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	3	40
DefaultPackage	Use explicit scoping instead of the default package private level	3	40
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	48
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	53
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	3	67
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	3	79
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	86
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	3	106

org/apache/fulcrum/security/torque/peer/managers/PeerRoleManager.java

Rule	Violation	Priority	Line
DataClass	The class 'PeerRoleManager' is suspected to be a Data Class (WOC=22.222%, NOPA=0, NOAM=7, WMC=11)	3	34–112
AbstractNaming	Abstract classes should be named AbstractXXX	3	34–112
MissingSerialVersionUID	Classes implementing Serializable should set a serialVersionUID	3	34–112
AtLeastOneConstructor	Each class should declare at least one constructor	3	34–112
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	3	39
DefaultPackage	Use explicit scoping instead of the default package private level	3	40
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	3	40
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	48
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	53
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	63
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	3	83
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	3	95
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	3	107

org/apache/fulcrum/security/torque/peer/managers/PeerUserManager.java

Rule	Violation	Priority	Line
DataClass	The class 'PeerUserManager' is suspected to be a Data Class (WOC=21.429%, NOPA=0, NOAM=11, WMC=22)	3	35–175
AtLeastOneConstructor	Each class should declare at least one constructor	3	35–175
AbstractNaming	Abstract classes should be named AbstractXXX	3	35–175
LongVariable	Avoid excessively long variable names like PEER_CLASS_NAME_KEY	3	48
CommentDefaultAccessModifier	To avoid mistakes add a comment at the beginning of the peerManager field if you want a default access modifier	3	49
DefaultPackage	Use explicit scoping instead of the default package private level	3	49
LongVariable	Avoid excessively long variable names like columnName4UserGroupRole	3	53
LongVariable	Avoid excessively long variable names like userGroupRolePeerClassName	3	55
MethodArgumentCouldBeFinal	Parameter 'conf' is not assigned and could be declared final	3	61
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	66
LocalVariableCouldBeFinal	Local variable 'userGroupRoleConf' could be declared final	3	72
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	72
ForLoopCanBeForeach	This for loop can be replaced by a foreach loop	3	73–83
LocalVariableCouldBeFinal	Local variable 'configuration' could be declared final	3	75
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	76
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	76
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	77
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	94
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	98
MethodArgumentCouldBeFinal	Parameter 'columnName' is not assigned and could be declared final	3	118
MethodArgumentCouldBeFinal	Parameter 'customPeer' is not assigned and could be declared final	3	133
MethodArgumentCouldBeFinal	Parameter 'peerClassName' is not assigned and could be declared final	3	145
LongVariable	Avoid excessively long variable names like userGroupRolePeerClassName	3	157
MethodArgumentCouldBeFinal	Parameter 'userGroupRolePeerClassName' is not assigned and could be declared final	3	157
MethodArgumentCouldBeFinal	Parameter 'columnName4UserGroupRole' is not assigned and could be declared final	3	169
LongVariable	Avoid excessively long variable names like columnName4UserGroupRole	3	169

org/apache/fulcrum/security/torque/security/TorqueAbstractSecurityEntity.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	33–148
AtLeastOneConstructor	Each class should declare at least one constructor	3	33–148
ShortVariable	Avoid variables with short names like id	3	52
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	115
ShortVariable	Avoid variables with short names like id	3	115
EmptyCatchBlock	Avoid empty catch blocks	3	121–124
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	140
UseLocaleWithCaseConversions	When doing a String.toLowerCase()/toUpperCase() call, use a Locale	3	144

org/apache/fulcrum/security/torque/security/turbine/TorqueAbstractTurbineTurbineSecurityEntity.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	35–131
AtLeastOneConstructor	Each class should declare at least one constructor	3	35–131
RedundantFieldInitializer	Avoid using redundant field initializer for 'userGroupRoleSet'	3	42
MissingOverride	The method 'addUserGroupRole(TurbineUserGroupRole)' is missing an @Override annotation.	3	47–50
MethodArgumentCouldBeFinal	Parameter 'userGroupRole' is not assigned and could be declared final	3	47
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	49
FormalParameterNamingConventions	The method parameter name 'user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	1	57
MethodArgumentCouldBeFinal	Parameter 'isLazilyLoaded' is not assigned and could be declared final	3	57
MethodArgumentCouldBeFinal	Parameter 'user_group_role' is not assigned and could be declared final	3	57
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'user_group_role' is not final.	1	57
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	60
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	64
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	77
MissingOverride	The method 'getUserGroupRoleSet()' is missing an @Override annotation.	3	87–90
MissingOverride	The method 'removeUserGroupRole(TurbineUserGroupRole)' is missing an @Override annotation.	3	95–98
MethodArgumentCouldBeFinal	Parameter 'userGroupRole' is not assigned and could be declared final	3	95
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	97
MethodArgumentCouldBeFinal	Parameter 'isLazilyLoaded' is not assigned and could be declared final	3	105
MethodArgumentCouldBeFinal	Parameter 'user_group_role' is not assigned and could be declared final	3	105
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'user_group_role' is not final.	1	105
FormalParameterNamingConventions	The method parameter name 'user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	1	105
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	108
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	112
MissingOverride	The method 'setUserGroupRoleSet(Set)' is missing an @Override annotation.	3	119–129
MethodArgumentCouldBeFinal	Parameter 'userGroupRoleSet' is not assigned and could be declared final	3	119
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	121–128
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	127

org/apache/fulcrum/security/torque/security/turbine/TorqueAbstractTurbineTurbineSecurityEntityDefault.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	37–56
AtLeastOneConstructor	Each class should declare at least one constructor	3	37–56

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineGroup.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	42–178
AtLeastOneConstructor	Each class should declare at least one constructor	3	42–178
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	78
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	78
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	82
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	82
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	3	84
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	86
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	88
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	88
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '109'-'112').	5	109–112
CloseResource	Ensure that resources like this Connection object are closed after use	3	109
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	117
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '117'-'134').	5	117–134
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	140
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	144
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	145
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	147
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	153
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	155
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	155
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	156
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	157
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	158
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	164

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbinePermission.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	42–212
AtLeastOneConstructor	Each class should declare at least one constructor	3	42–212
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	49
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	3	49
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	63
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	63
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	74
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	76
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	111
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	113
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	3	120
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	122–129
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	3	136
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	142
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	152
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	152
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	3	159
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	3	161
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	175
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	179
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	3	185
ShortVariable	Avoid variables with short names like rp	3	187
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	187
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	3	187
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	198

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineRole.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	47–305
AtLeastOneConstructor	Each class should declare at least one constructor	3	47–305
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	54
RedundantFieldInitializer	Avoid using redundant field initializer for 'permissionSet'	3	54
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	87
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	87
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	98
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	100
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	135
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	137
MethodArgumentCouldBeFinal	Parameter 'permissionSet' is not assigned and could be declared final	3	144
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	146–153
MethodArgumentCouldBeFinal	Parameter 'permissions' is not assigned and could be declared final	3	160
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	166
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	177
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	177
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	3	183
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	3	185
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	191
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	191
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	3	193
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	195
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	197
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	197
CloseResource	Ensure that resources like this Connection object are closed after use	3	219
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '219'-'222').	5	219–222
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '227'-'243').	5	227–243
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	227
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	250
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	254
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	3	260
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	262
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	3	262
ShortVariable	Avoid variables with short names like rp	3	262

org/apache/fulcrum/security/torque/turbine/DefaultAbstractTurbineUser.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	45–199
AbstractNaming	Abstract classes should be named AbstractXXX	3	45–199
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	83
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	83
AvoidReassigningParameters	Avoid reassigning parameters such as 'ugrs'	2	83
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	86
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	86
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	103
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	103
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	106
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	106
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	3	108
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	122
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	132
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	136
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	139
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	145
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	147
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	147
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	148
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	149
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	150
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	156
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	177
MethodArgumentCouldBeFinal	Parameter 'userGroupRoleSet' is not assigned and could be declared final	3	178
MethodArgumentCouldBeFinal	Parameter 'ugrs' is not assigned and could be declared final	3	179
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	183
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	185
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	185

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineGroup.java

Rule	Violation	Priority	Line
AbstractNaming	Abstract classes should be named AbstractXXX	3	42–173
AtLeastOneConstructor	Each class should declare at least one constructor	3	42–173
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	60
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	68
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	78
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	78
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	82
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	82
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	3	83
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	85
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	87
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	87
CloseResource	Ensure that resources like this Connection object are closed after use	3	105
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '105'-'108').	5	105–108
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '113'-'129').	5	113–129
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	113
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	135
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	139
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	142
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	148
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	150
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	150
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	151
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	152
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	153
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	159

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbinePermission.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	41–212
AbstractNaming	Abstract classes should be named AbstractXXX	3	41–212
RedundantFieldInitializer	Avoid using redundant field initializer for 'roleSet'	3	48
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	48
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	62
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	62
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	72
MissingOverride	The method 'addRole(Role)' is missing an @Override annotation.	3	72–75
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	74
MissingOverride	The method 'getRoles()' is missing an @Override annotation.	3	80–92
MissingOverride	The method 'getRolesAsSet()' is missing an @Override annotation.	3	98–101
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	106
MissingOverride	The method 'removeRole(Role)' is missing an @Override annotation.	3	106–109
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	108
MethodArgumentCouldBeFinal	Parameter 'roleSet' is not assigned and could be declared final	3	114
MissingOverride	The method 'setRoles(RoleSet)' is missing an @Override annotation.	3	114–124
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	116–123
MissingOverride	The method 'setRolesAsSet(Set)' is missing an @Override annotation.	3	129–132
MethodArgumentCouldBeFinal	Parameter 'roles' is not assigned and could be declared final	3	129
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	146
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	156
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	156
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	3	162
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	3	164
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	176
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	176–203
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	180
LocalVariableCouldBeFinal	Local variable 'r' could be declared final	3	186
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	188
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	3	188
ShortVariable	Avoid variables with short names like rp	3	188
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	199
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	208–211

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineRole.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	48–314
AbstractNaming	Abstract classes should be named AbstractXXX	3	48–314
RedundantFieldInitializer	Avoid using redundant field initializer for 'permissionSet'	3	54
BeanMembersShouldSerialize	Found non-transient, non-static member. Please mark as transient or provide accessors.	3	54
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	69
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	69
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	86
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	87
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	99
MissingOverride	The method 'addPermission(Permission)' is missing an @Override annotation.	3	99–101
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	100
MissingOverride	The method 'getPermissions()' is missing an @Override annotation.	3	109–117
MissingOverride	The method 'getPermissionsAsSet()' is missing an @Override annotation.	3	126–128
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	137
MissingOverride	The method 'removePermission(Permission)' is missing an @Override annotation.	3	137–139
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	138
MethodArgumentCouldBeFinal	Parameter 'permissionSet' is not assigned and could be declared final	3	148
MissingOverride	The method 'setPermissions(PermissionSet)' is missing an @Override annotation.	3	148–154
ConfusingTernary	Avoid if (x != y) ..; else ..;	3	149–153
MethodArgumentCouldBeFinal	Parameter 'permissions' is not assigned and could be declared final	3	162
MissingOverride	The method 'setPermissionsAsSet(Set)' is missing an @Override annotation.	3	162–164
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	181
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	192
MissingOverride	The method 'retrieveAttachedObjects(Connection, Boolean)' is missing an @Override annotation.	3	192–222
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	192
LocalVariableCouldBeFinal	Local variable 'rolepermissions' could be declared final	3	196–197
LocalVariableCouldBeFinal	Local variable 'ttrp' could be declared final	3	199
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	204
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	204
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	3	206–207
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	209
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	210
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	210
CloseResource	Ensure that resources like this Connection object are closed after use	3	233
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '233'-'235').	5	233–235
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	240
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '240'-'251').	5	240–251
MissingOverride	The method 'update(Connection)' is missing an @Override annotation.	3	260–302
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	260
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	262
LocalVariableCouldBeFinal	Local variable 'p' could be declared final	3	268
LocalVariableCouldBeFinal	Local variable 'rp' could be declared final	3	269
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	269
ShortVariable	Avoid variables with short names like rp	3	269
MissingOverride	The method 'delete()' is missing an @Override annotation.	3	311–313

org/apache/fulcrum/security/torque/turbine/FulcrumAbstractTurbineUser.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	44–147
AbstractNaming	Abstract classes should be named AbstractXXX	3	44–147
MethodArgumentCouldBeFinal	Parameter 'criteria' is not assigned and could be declared final	3	61
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	61
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	72
MethodArgumentCouldBeFinal	Parameter 'lazy' is not assigned and could be declared final	3	82
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	82
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	86
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	86
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	3	87
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	89
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	91
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	91
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	108
LocalVariableCouldBeFinal	Local variable 'userGroupRoleSet' could be declared final	3	112
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	115
LocalVariableCouldBeFinal	Local variable 'ugr' could be declared final	3	121
AvoidInstantiatingObjectsInLoops	Avoid instantiating new objects inside loops	3	123
LocalVariableCouldBeFinal	Local variable 'ttugr' could be declared final	3	123
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	124
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	125
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	126
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	132

org/apache/fulcrum/security/torque/turbine/TorqueTurbineGroupManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	43–167
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	55
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	57
UselessParentheses	Useless parentheses.	4	59
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	62
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	63
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	63
ShortVariable	Avoid variables with short names like id	3	81
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	81
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	81
UselessParentheses	Useless parentheses.	4	83
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	86
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	87
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	87
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	104
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	104
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	106
UnusedAssignment	The initializer for variable 'groups' is never used (overwritten on lines 117 and 125)	3	109
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'groups' (lines '109'-'117').	5	109–117
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'groups' (lines '109'-'125').	5	109–125
UselessParentheses	Useless parentheses.	4	111
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	114
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	116
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	116
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'groups' (lines '117'-'134').	5	117–134
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	117
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	128
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	133
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	137
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '138'-'165').	5	138–165
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '138'-'143').	5	138–143
CloseResource	Ensure that resources like this Connection object are closed after use	3	138
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '148'-'165').	5	148–165
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	148

org/apache/fulcrum/security/torque/turbine/TorqueTurbineModelManagerImpl.java

Rule	Violation	Priority	Line
GodClass	Possible God Class (WMC=76, ATFD=49, TCC=0.000%)	3	48–376
AtLeastOneConstructor	Each class should declare at least one constructor	3	48–376
TooManyMethods	This class has too many methods, consider refactoring it.	3	49–376
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	63
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	63
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	63–114
CyclomaticComplexity	The method 'grant(Role, Permission)' has a cyclomatic complexity of 12.	3	63–114
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	66
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	3	66
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	67
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	3	67
CloseResource	Ensure that resources like this Connection object are closed after use	3	78
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '78'-'82').	5	78–82
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	88
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '88'-'114').	5	88–114
AvoidDuplicateLiterals	The String literal "', '" appears 6 times in this file; the first occurrence is on line 92	3	92
AvoidDuplicateLiterals	The String literal "Unknown role '" appears 5 times in this file; the first occurrence is on line 107	3	107
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	125–164
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	125
MethodArgumentCouldBeFinal	Parameter 'permission' is not assigned and could be declared final	3	125
CyclomaticComplexity	The method 'revoke(Role, Permission)' has a cyclomatic complexity of 11.	3	125–164
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	128
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	3	128
LocalVariableCouldBeFinal	Local variable 'permissionExists' could be declared final	3	129
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	129
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	142
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	168
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	168
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	168
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	168–171
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	174
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	174
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	174
AvoidSynchronizedAtMethodLevel	Use block level rather than method level synchronization	3	174–179
IfStmtsMustUseBraces	Avoid using if statements without curly braces	3	177–178
ControlStatementBraces	This statement should have braces	3	178
MethodArgumentCouldBeFinal	Parameter 'newRole' is not assigned and could be declared final	3	182
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	182
MethodArgumentCouldBeFinal	Parameter 'oldRole' is not assigned and could be declared final	3	182
LocalVariableCouldBeFinal	Local variable 'group' could be declared final	3	185
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	191
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	191
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	191
LocalVariableCouldBeFinal	Local variable 'new_user_group_role' could be declared final	3	194
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'new_user_group_role' is not final.	1	194
LocalVariableNamingConventions	The local variable name 'new_user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	1	194
LongVariable	Avoid excessively long variable names like new_user_group_role	3	194
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	218
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	218
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	218
CyclomaticComplexity	The method 'removeUserGroupRole(User, Role, Group)' has a cyclomatic complexity of 11.	3	218–253
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'ugrFound' (lines '221'-'228').	5	221–228
LocalVariableCouldBeFinal	Local variable 'user_group_role' could be declared final	3	222
VariableNamingConventions	Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'user_group_role' is not final.	1	222
LocalVariableNamingConventions	The local variable name 'user_group_role' doesn't match '[a-z][a-zA-Z0-9]*'	1	222
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	224
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	225
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	226
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	255
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	255
CyclomaticComplexity	The method 'checkExists(User, Group, Role)' has a cyclomatic complexity of 10.	3	255–281
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	255
LocalVariableCouldBeFinal	Local variable 'roleExists' could be declared final	3	257
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	257
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	3	258
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	258
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	259
LocalVariableCouldBeFinal	Local variable 'groupExists' could be declared final	3	259
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	263
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	283
CyclomaticComplexity	The method 'checkExists(User, Role, Role, Group)' has a cyclomatic complexity of 11.	3	283–308
MethodArgumentCouldBeFinal	Parameter 'oldRole' is not assigned and could be declared final	3	283
MethodArgumentCouldBeFinal	Parameter 'globalGroup' is not assigned and could be declared final	3	283
MethodArgumentCouldBeFinal	Parameter 'newRole' is not assigned and could be declared final	3	283
LocalVariableCouldBeFinal	Local variable 'userExists' could be declared final	3	285
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	285
LocalVariableCouldBeFinal	Local variable 'oldRoleExists' could be declared final	3	286
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	286
LocalVariableCouldBeFinal	Local variable 'newRoleExists' could be declared final	3	287
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	287
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	291
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	310
MethodArgumentCouldBeFinal	Parameter 'newRole' is not assigned and could be declared final	3	310
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	310
MethodArgumentCouldBeFinal	Parameter 'privilege' is not assigned and could be declared final	3	310
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	310
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'logChars' (lines '313'-'327').	5	313–327
LawOfDemeter	Potential violation of Law of Demeter (static property access)	3	327
MethodArgumentCouldBeFinal	Parameter 'privilege' is not assigned and could be declared final	3	336
MethodArgumentCouldBeFinal	Parameter 'role' is not assigned and could be declared final	3	336
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	336
MethodArgumentCouldBeFinal	Parameter 'group' is not assigned and could be declared final	3	336
MethodArgumentCouldBeFinal	Parameter 'logChars' is not assigned and could be declared final	3	342
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	342
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '345'-'349').	5	345–349
CloseResource	Ensure that resources like this Connection object are closed after use	3	345
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '358'-'375').	5	358–375
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	358
IdenticalCatchBranches	'catch' branch identical to 'TorqueException' branch	3	364–367
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	364

org/apache/fulcrum/security/torque/turbine/TorqueTurbinePermissionManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	38–131
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	50
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	52
UselessParentheses	Useless parentheses.	4	54
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	57
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	58
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	58
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	76
ShortVariable	Avoid variables with short names like id	3	76
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	76
UselessParentheses	Useless parentheses.	4	78
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	81
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	82
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	82
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	98
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	98
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	100
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'permissions' (lines '105'-'120').	5	105–120
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'permissions' (lines '105'-'111').	5	105–111
UnusedAssignment	The initializer for variable 'permissions' is never used (overwritten on lines 111 and 120)	3	105
UselessParentheses	Useless parentheses.	4	106
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	109
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	110
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	110
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	111
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'permissions' (lines '111'-'129').	5	111–129
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	123
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	128

org/apache/fulcrum/security/torque/turbine/TorqueTurbineRoleManagerImpl.java

Rule	Violation	Priority	Line
AtLeastOneConstructor	Each class should declare at least one constructor	3	38–127
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	49
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	51
UselessParentheses	Useless parentheses.	4	53
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	56
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	58
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	58
ShortVariable	Avoid variables with short names like id	3	74
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	74
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	74
UselessParentheses	Useless parentheses.	4	76
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	79
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	81
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	81
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	97
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	97
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	99
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'roles' (lines '103'-'110').	5	103–110
UnusedAssignment	The initializer for variable 'roles' is never used (overwritten on lines 110 and 118)	3	103
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'roles' (lines '103'-'118').	5	103–118
UselessParentheses	Useless parentheses.	4	104
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	107
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	109
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	109
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	110
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'roles' (lines '110'-'126').	5	110–126
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	121
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	125

org/apache/fulcrum/security/torque/turbine/TorqueTurbineUserManagerImpl.java

Rule	Violation	Priority	Line
GodClass	Possible God Class (WMC=50, ATFD=12, TCC=0.000%)	3	47–373
AtLeastOneConstructor	Each class should declare at least one constructor	3	47–373
LocalVariableCouldBeFinal	Local variable 'anonUser' could be declared final	3	63
UnnecessaryLocalBeforeReturn	Consider simply returning the value vs storing it in local variable 'anonUser'	3	65
ShortVariable	Avoid variables with short names like u	3	77
MethodArgumentCouldBeFinal	Parameter 'u' is not assigned and could be declared final	3	77
LocalVariableCouldBeFinal	Local variable 'anon' could be declared final	3	81
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	84
AvoidCatchingGenericException	Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block	3	87
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	89
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	100
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	102
UselessParentheses	Useless parentheses.	4	104
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	107
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	108
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	108
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	124
ShortVariable	Avoid variables with short names like id	3	124
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	124
UselessParentheses	Useless parentheses.	4	126
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	129
OnlyOneReturn	A method should have only one exit point, and that should be the last statement in the method	3	130
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	130
MethodArgumentCouldBeFinal	Parameter 'name' is not assigned and could be declared final	3	146
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	146
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	148
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'users' (lines '153'-'167').	5	153–167
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'users' (lines '153'-'159').	5	153–159
UnusedAssignment	The initializer for variable 'users' is never used (overwritten on lines 159 and 167)	3	153
UselessParentheses	Useless parentheses.	4	154
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	157
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	158
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	158
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	159
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'users' (lines '159'-'177').	5	159–177
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	171
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	176
MethodArgumentCouldBeFinal	Parameter 'userName' is not assigned and could be declared final	3	191
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'user' (lines '193'-'200').	5	193–200
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '194'-'198').	5	194–198
CloseResource	Ensure that resources like this Connection object are closed after use	3	194
UseLocaleWithCaseConversions	When doing a String.toLowerCase()/toUpperCase() call, use a Locale	3	200
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	206
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '206'-'229').	5	206–229
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	210
PreserveStackTrace	New exception is thrown in catch block, original stack trace may be lost	3	214
UseDiamondOperator	Explicit type arguments can be replaced by Diamond Operator	3	241
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'userSet' (lines '241'-'274').	5	241–274
LocalVariableCouldBeFinal	Local variable 'userSet' could be declared final	3	241
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '242'-'246').	5	242–246
CloseResource	Ensure that resources like this Connection object are closed after use	3	242
LocalVariableCouldBeFinal	Local variable 'users' could be declared final	3	248
LocalVariableCouldBeFinal	Local variable 'user' could be declared final	3	250
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	259
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '259'-'274').	5	259–274
MethodArgumentCouldBeFinal	Parameter 'id' is not assigned and could be declared final	3	288
ShortVariable	Avoid variables with short names like id	3	288
SimplifyConditional	No need to check for null before an instanceof	3	292
DataflowAnomalyAnalysis	Found 'DD'-anomaly for variable 'con' (lines '294'-'298').	5	294–298
CloseResource	Ensure that resources like this Connection object are closed after use	3	294
NullAssignment	Assigning an Object to null is a code smell. Consider refactoring.	3	306
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'con' (lines '306'-'330').	5	306–330
MethodArgumentCouldBeFinal	Parameter 'user' is not assigned and could be declared final	3	339
MethodArgumentCouldBeFinal	Parameter 'con' is not assigned and could be declared final	3	339
LocalVariableCouldBeFinal	Local variable 'peerInstance' could be declared final	3	345–346
LocalVariableCouldBeFinal	Local variable 'criteria' could be declared final	3	347
LawOfDemeter	Potential violation of Law of Demeter (method chain calls)	3	349
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	349
LocalVariableCouldBeFinal	Local variable 'ugrs' could be declared final	3	350
LawOfDemeter	Potential violation of Law of Demeter (object not created locally)	3	350
DataflowAnomalyAnalysis	Found 'DU'-anomaly for variable 'ugrs' (lines '350'-'371').	5	350–371