PMD Results

The following document contains the results of PMD 6.29.0.

Violations By Priority

Priority 1

org/apache/fulcrum/intake/IntakeServiceFacade.java

Rule Violation Line
ClassNamingConventions The utility class name 'IntakeServiceFacade' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 41182

org/apache/fulcrum/intake/IntakeServiceImpl.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 228
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 369
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 376
LocalVariableNamingConventions The local variable name 'READ_ERR' doesn't match '[a-z][a-zA-Z0-9]*' 751
VariableNamingConventions Variables should start with a lowercase character, 'READ_ERR' starts with uppercase character. 751
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'READ_ERR' is not final. 751
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 755
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 803

org/apache/fulcrum/intake/model/Field.java

Rule Violation Line
FieldNamingConventions The public constant name 'defaultValidatorPackage' doesn't match '[A-Z][A-Z_0-9]*' 64
VariableNamingConventions Variables that are final and static should be all capitals, 'defaultValidatorPackage' is not all capitals. 64
FieldNamingConventions The public constant name 'defaultFieldPackage' doesn't match '[A-Z][A-Z_0-9]*' 67
VariableNamingConventions Variables that are final and static should be all capitals, 'defaultFieldPackage' is not all capitals. 67
ConstructorCallsOverridableMethod Overridable method 'enableLogging' called during object construction 183
ConstructorCallsOverridableMethod Overridable method 'getDisplayName' called during object construction 199
ConstructorCallsOverridableMethod Overridable method 'getDisplayName' called during object construction 210
ConstructorCallsOverridableMethod Overridable method 'getDefaultValidator' called during object construction 217

org/apache/fulcrum/intake/validator/FieldReference.java

Rule Violation Line
LocalVariableNamingConventions The local variable name 'comp_true' doesn't match '[a-z][a-zA-Z0-9]*' 202
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'comp_true' is not final. 202

org/apache/fulcrum/intake/validator/FileValidator.java

Rule Violation Line
FieldNamingConventions The constant name 'charsetPattern' doesn't match '[A-Z][A-Z_0-9]*' 45
VariableNamingConventions Variables that are final and static should be all capitals, 'charsetPattern' is not all capitals. 45

Priority 2

org/apache/fulcrum/intake/model/BooleanField.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 163

org/apache/fulcrum/intake/model/Field.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 170
GuardLogStatement Logger calls should be surrounded by log level guards. 198200
GuardLogStatement Logger calls should be surrounded by log level guards. 209211
GuardLogStatement Logger calls should be surrounded by log level guards. 269273
GuardLogStatement Logger calls should be surrounded by log level guards. 281285
GuardLogStatement Logger calls should be surrounded by log level guards. 640
GuardLogStatement Logger calls should be surrounded by log level guards. 654
GuardLogStatement Logger calls should be surrounded by log level guards. 698
GuardLogStatement Logger calls should be surrounded by log level guards. 703
GuardLogStatement Logger calls should be surrounded by log level guards. 820821

org/apache/fulcrum/intake/model/FieldType.java

Rule Violation Line
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 4144
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 4952
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 5760
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 6568
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 7477
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 8285
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 9093
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 98101
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 115118
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 123126
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 131134

org/apache/fulcrum/intake/model/Group.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 72

org/apache/fulcrum/intake/model/XmlField.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 102

org/apache/fulcrum/intake/validator/DefaultValidator.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 75

org/apache/fulcrum/intake/validator/StringValidator.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 112113
GuardLogStatement Logger calls should be surrounded by log level guards. 153

Priority 3

org/apache/fulcrum/intake/IntakeError.java

Rule Violation Line
DoNotExtendJavaLangError Exceptions should not extend java.lang.Error 28
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 75

org/apache/fulcrum/intake/IntakeException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 75

org/apache/fulcrum/intake/IntakeRuntimeException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 62
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 75
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 75

org/apache/fulcrum/intake/IntakeService.java

Rule Violation Line
LongVariable Avoid excessively long variable names like SERIAL_XML_DEFAULT 69
LongVariable Avoid excessively long variable names like DEFAULT_POOL_CAPACITY 74

org/apache/fulcrum/intake/IntakeServiceFacade.java

Rule Violation Line
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 42182
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 71
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 84
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 108
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 120
MethodArgumentCouldBeFinal Parameter 'groupKey' is not assigned and could be declared final 130
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 132
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 146
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 148
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 162
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 162
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 164
MethodArgumentCouldBeFinal Parameter 'service' is not assigned and could be declared final 177

org/apache/fulcrum/intake/IntakeServiceImpl.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 1936
StdCyclomaticComplexity The class 'IntakeServiceImpl' has a Standard Cyclomatic Complexity of 5 (Highest = 16). 80936
CyclomaticComplexity The class 'IntakeServiceImpl' has a total cyclomatic complexity of 89 (highest 16). 80936
ModifiedCyclomaticComplexity The class 'IntakeServiceImpl' has a Modified Cyclomatic Complexity of 5 (Highest = 16). 80936
AtLeastOneConstructor Each class should declare at least one constructor 80936
GodClass Possible God Class (WMC=89, ATFD=52, TCC=28.571%) 80936
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 88
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 91
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 106
RedundantFieldInitializer Avoid using redundant field initializer for 'xmlPathes' 106
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 109
RedundantFieldInitializer Avoid using redundant field initializer for 'serialDataPath' 109
AtLeastOneConstructor Each class should declare at least one constructor 115131
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'parent' is not assigned and could be declared final 121
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 147
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 147
MethodArgumentCouldBeFinal Parameter 'appData' is not assigned and could be declared final 148
MethodArgumentCouldBeFinal Parameter 'checkKey' is not assigned and could be declared final 148
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 153
LocalVariableCouldBeFinal Local variable 'keyExists' could be declared final 156
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 161
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 173
LocalVariableCouldBeFinal Local variable 'field' could be declared final 174
LocalVariableCouldBeFinal Local variable 'className' could be declared final 176
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 179
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 180
CyclomaticComplexity The method 'loadSerialized(String, long)' has a cyclomatic complexity of 16. 196311
ExcessiveMethodLength Avoid really long methods. 196311
MethodArgumentCouldBeFinal Parameter 'serialDataPath' is not assigned and could be declared final 196
StdCyclomaticComplexity The method 'loadSerialized' has a Standard Cyclomatic Complexity of 16. 196311
NPathComplexity The method 'loadSerialized(String, long)' has an NPath complexity of 576, current threshold is 200 196311
MethodArgumentCouldBeFinal Parameter 'timeStamp' is not assigned and could be declared final 196
ModifiedCyclomaticComplexity The method 'loadSerialized' has a Modified Cyclomatic Complexity of 16. 196311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 198200
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 202
LocalVariableCouldBeFinal Local variable 'timer' could be declared final 202
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 206
LocalVariableCouldBeFinal Local variable 'serialDataFile' could be declared final 209
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 213
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 214
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 219
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 220
ShortVariable Avoid variables with short names like in 223
CloseResource Ensure that resources like this FileInputStream object are closed after use 228
LocalVariableCouldBeFinal Local variable 'fin' could be declared final 228
ShortVariable Avoid variables with short names like o 230
LocalVariableCouldBeFinal Local variable 'o' could be declared final 230
LocalVariableCouldBeFinal Local variable 'map' could be declared final 235
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 241
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 243
LocalVariableCouldBeFinal Local variable 'result' could be declared final 246
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 247
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 255
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 259
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 263
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 267
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 282
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 289
LocalVariableCouldBeFinal Local variable 'group' could be declared final 291
LocalVariableCouldBeFinal Local variable 'field' could be declared final 298
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 308
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 309
StdCyclomaticComplexity The method 'saveSerialized' has a Standard Cyclomatic Complexity of 11. 323420
ModifiedCyclomaticComplexity The method 'saveSerialized' has a Modified Cyclomatic Complexity of 11. 323420
CyclomaticComplexity The method 'saveSerialized(String, Map)' has a cyclomatic complexity of 11. 323420
MethodArgumentCouldBeFinal Parameter 'appDataElements' is not assigned and could be declared final 323
MethodArgumentCouldBeFinal Parameter 'serialDataPath' is not assigned and could be declared final 323
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 326328
LocalVariableCouldBeFinal Local variable 'timer' could be declared final 330
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 330
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 334
LocalVariableCouldBeFinal Local variable 'serialData' could be declared final 337
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 342
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 344
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 349
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 351
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 357359
ShortVariable Avoid variables with short names like in 364
LocalVariableCouldBeFinal Local variable 'fout' could be declared final 369
CloseResource Ensure that resources like this FileOutputStream object are closed after use 369
LocalVariableCouldBeFinal Local variable 'fin' could be declared final 376
CloseResource Ensure that resources like this FileInputStream object are closed after use 376
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 380
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 384386
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 390391
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 404
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 415
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 419
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 433
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 435
UnusedAssignment The initializer for variable 'group' is never used (overwritten on line 453) 435
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 437
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 437
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 453
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 455
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 472
LocalVariableCouldBeFinal Local variable 'groupName' could be declared final 476
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 477
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 489
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 491
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 508
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 510
CloseResource Ensure that resources like this KeyedObjectPool object are closed after use 518
LocalVariableCouldBeFinal Local variable 'kop' could be declared final 518
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 520
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 520
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 542
MethodArgumentCouldBeFinal Parameter 'groupKey' is not assigned and could be declared final 555
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 572
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 572
LocalVariableCouldBeFinal Local variable 'settersForClassName' could be declared final 575
LongVariable Avoid excessively long variable names like settersForClassName 575
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 583
LocalVariableCouldBeFinal Local variable 'pd' could be declared final 587588
ShortVariable Avoid variables with short names like pd 587
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 595597
LocalVariableCouldBeFinal Local variable 'gettersForClassName' could be declared final 604
LongVariable Avoid excessively long variable names like gettersForClassName 604
LocalVariableCouldBeFinal Local variable 'getter' could be declared final 608
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 611
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 631
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 631
LocalVariableCouldBeFinal Local variable 'gettersForClassName' could be declared final 634
LongVariable Avoid excessively long variable names like gettersForClassName 634
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 642
ShortVariable Avoid variables with short names like pd 646
UnusedAssignment The initializer for variable 'pd' is never used (overwritten on line 649) 646
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 654656
LocalVariableCouldBeFinal Local variable 'settersForClassName' could be declared final 663
LongVariable Avoid excessively long variable names like settersForClassName 663
LocalVariableCouldBeFinal Local variable 'setter' could be declared final 667
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 670
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 683
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 687
LocalVariableCouldBeFinal Local variable 'nameVal' could be declared final 695
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 696700
LocalVariableCouldBeFinal Local variable 'val' could be declared final 698
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 703
ConfusingTernary Avoid if (x != y) ..; else ..; 705712
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 705
LiteralsFirstInComparisons Position literals first in String comparisons 705
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 711
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 714
NcssCount The method 'initialize()' has a NCSS line count of 85. 725904
NPathComplexity The method 'initialize()' has an NPath complexity of 840, current threshold is 200 725904
ModifiedCyclomaticComplexity The method 'initialize' has a Modified Cyclomatic Complexity of 15. 725904
ExcessiveMethodLength Avoid really long methods. 725904
StdCyclomaticComplexity The method 'initialize' has a Standard Cyclomatic Complexity of 15. 725904
CyclomaticComplexity The method 'initialize()' has a cyclomatic complexity of 16. 725904
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 727
UnusedAssignment The initializer for variable 'appDataElements' is never used (overwritten on lines 774 and 795) 727
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 729
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 730
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 731
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 732
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 733
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 734
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 736
LocalVariableCouldBeFinal Local variable 'xmlFiles' could be declared final 736
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 740
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 740
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 740
LocalVariableCouldBeFinal Local variable 'xmlPath' could be declared final 742
LocalVariableCouldBeFinal Local variable 'xmlFile' could be declared final 745
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 745
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 747
LocalVariableCouldBeFinal Local variable 'READ_ERR' could be declared final 751752
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 754
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 760
LocalVariableCouldBeFinal Local variable 'serializedMap' could be declared final 769
ConfusingTernary Avoid if (x != y) ..; else ..; 771827
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 775
LocalVariableCouldBeFinal Local variable 'timer' could be declared final 779
LocalVariableCouldBeFinal Local variable 'jaxb' could be declared final 782
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 783
ShortVariable Avoid variables with short names like um 783
LocalVariableCouldBeFinal Local variable 'um' could be declared final 783
LocalVariableCouldBeFinal Local variable 'logEnabledListener' could be declared final 789
LongVariable Avoid excessively long variable names like logEnabledListener 789
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 790
LocalVariableCouldBeFinal Local variable 'schemaURL' could be declared final 792
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 792
LocalVariableCouldBeFinal Local variable 'schemaFactory' could be declared final 793
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 794
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 795
LocalVariableCouldBeFinal Local variable 'xmlFile' could be declared final 797
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 799
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 803
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 804
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 804
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 807
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 819
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 825
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 832
LocalVariableCouldBeFinal Local variable 'glist' could be declared final 839
LocalVariableCouldBeFinal Local variable 'groupPrefix' could be declared final 841
LocalVariableCouldBeFinal Local variable 'i' could be declared final 843
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 843
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 843
LocalVariableCouldBeFinal Local variable 'g' could be declared final 845
ShortVariable Avoid variables with short names like g 845
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 846
LocalVariableCouldBeFinal Local variable 'groupName' could be declared final 846
LongVariable Avoid excessively long variable names like registerUnqualified 848
LocalVariableCouldBeFinal Local variable 'registerUnqualified' could be declared final 848
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 852855
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 854
LocalVariableCouldBeFinal Local variable 'qualifiedName' could be declared final 860
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 860
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 872875
LocalVariableCouldBeFinal Local variable 'f' could be declared final 880
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 880
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 885
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 888889
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 889
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 891
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 891
LocalVariableCouldBeFinal Local variable 'poolConfig' could be declared final 891
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 897
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 900
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 902
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 916
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 918
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 932

org/apache/fulcrum/intake/Retrievable.java

Rule Violation Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 46

org/apache/fulcrum/intake/model/AppData.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 43204
DataClass The class 'AppData' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=6, WMC=17) 43204
MethodArgumentCouldBeFinal Parameter 'groups' is not assigned and could be declared final 79
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 92
LocalVariableCouldBeFinal Local variable 'groupPrefix' could be declared final 101
LocalVariableCouldBeFinal Local variable 'group' could be declared final 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 105
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 107
LocalVariableCouldBeFinal Local variable 'qualifiedGroupName' could be declared final 111
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 111
LongVariable Avoid excessively long variable names like qualifiedGroupName 111
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 119
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 144
ShortVariable Avoid variables with short names like v 144
MethodArgumentCouldBeFinal Parameter 'groupPrefix' is not assigned and could be declared final 182
LocalVariableCouldBeFinal Local variable 'result' could be declared final 194
LocalVariableCouldBeFinal Local variable 'group' could be declared final 197

org/apache/fulcrum/intake/model/BigDecimalField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 48
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 48
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 60
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 62
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 83

org/apache/fulcrum/intake/model/BooleanField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 130
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 159
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 161

org/apache/fulcrum/intake/model/DateStringField.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for 'df' 50
ShortVariable Avoid variables with short names like df 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 50
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 59
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 59
LocalVariableCouldBeFinal Local variable 'validator' could be declared final 64
SimplifyConditional No need to check for null before an instanceof 65
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 78
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 80
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 109
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 146
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 157
LocalVariableCouldBeFinal Local variable 'val' could be declared final 164
MethodArgumentCouldBeFinal Parameter 'dateString' is not assigned and could be declared final 185
UnusedAssignment The initializer for variable 'date' is never used (overwritten on lines 193 and 197) 188
LocalVariableCouldBeFinal Local variable 'validator' could be declared final 190
SimplifyConditional No need to check for null before an instanceof 191
UnusedAssignment The initializer for variable 's' is never used (overwritten on lines 215, 219, 223 and 227) 210
ShortVariable Avoid variables with short names like s 210
LocalVariableCouldBeFinal Local variable 'value' could be declared final 211
LocalVariableCouldBeFinal Local variable 'validator' could be declared final 212
SimplifyConditional No need to check for null before an instanceof 221

org/apache/fulcrum/intake/model/DoubleField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 56
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 58
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 77
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 79
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 104
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 132
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 138

org/apache/fulcrum/intake/model/Field.java

Rule Violation Line
GodClass Possible God Class (WMC=116, ATFD=37, TCC=9.991%) 521149
StdCyclomaticComplexity The class 'Field' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 521149
CyclomaticComplexity The class 'Field' has a total cyclomatic complexity of 116 (highest 13). 521149
AbstractNaming Abstract classes should be named AbstractXXX 521149
ExcessiveClassLength Avoid really long classes. 521149
ModifiedCyclomaticComplexity The class 'Field' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 521149
TooManyFields Too many fields 521149
TooManyMethods This class has too many methods, consider refactoring it. 531149
LongVariable Avoid excessively long variable names like VALUE_IF_ABSENT_KEY 61
LongVariable Avoid excessively long variable names like defaultValidatorPackage 64
LongVariable Avoid excessively long variable names like defaultFieldPackage 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 84
ImmutableField Private field 'mapToProperty' could be made final; it is only initialized in the declaration or constructor. 84
LongVariable Avoid excessively long variable names like validatorClassName 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 93
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 96
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 99
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 102
AvoidFieldNameMatchingMethodName Field isMultiValued has the same name as a method 102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 120
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 137
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 143
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 146
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 149
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 155
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 161
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 164
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 167
ImmutableField Private field 'ruleMap' could be made final; it is only initialized in the declaration or constructor. 167
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 181
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 181
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 196
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 207
LocalVariableCouldBeFinal Local variable 'reqRule' could be declared final 225
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 228
LocalVariableCouldBeFinal Local variable 'maxLengthRule' could be declared final 232
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 250
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 267
AvoidDuplicateLiterals The String literal " in group " appears 4 times in this file; the first occurrence is on line 270 270
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 279
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 303
ShortVariable Avoid variables with short names like pp 303
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 345
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 445
ShortVariable Avoid variables with short names like v 445
ShortVariable Avoid variables with short names like v 456
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 456
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 456
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 483
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 489
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 490
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 492
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 493
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 494
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 495
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 496
MethodArgumentCouldBeFinal Parameter 'newDisplayName' is not assigned and could be declared final 577
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 597
MethodArgumentCouldBeFinal Parameter 'setFlag' is not assigned and could be declared final 608
MethodArgumentCouldBeFinal Parameter 'validFlag' is not assigned and could be declared final 618
MethodArgumentCouldBeFinal Parameter 'validated' is not assigned and could be declared final 628
StdCyclomaticComplexity The method 'validate' has a Standard Cyclomatic Complexity of 11. 638716
CyclomaticComplexity The method 'validate()' has a cyclomatic complexity of 11. 638716
ModifiedCyclomaticComplexity The method 'validate' has a Modified Cyclomatic Complexity of 11. 638716
ShortVariable Avoid variables with short names like v 641
LocalVariableCouldBeFinal Local variable 'v' could be declared final 641
ConfusingTernary Avoid if (x != y) ..; else ..; 689710
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the setInitialValue method if you want a default access modifier 747750
DefaultPackage Use explicit scoping instead of the default package private level 747750
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 747
ConfusingTernary Avoid if (x != y) ..; else ..; 766773
DefaultPackage Use explicit scoping instead of the default package private level 784787
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the setTestValue method if you want a default access modifier 784787
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 784
ConfusingTernary Avoid if (x != y) ..; else ..; 843850
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 849
LocalVariableCouldBeFinal Local variable 'res' could be declared final 864
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 876
LinguisticNaming Linguistics Antipattern - The getter 'getProperty' should not return void linguistically 876900
LocalVariableCouldBeFinal Local variable 't' could be declared final 882
ShortVariable Avoid variables with short names like t 882
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 890894
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 895899
LinguisticNaming Linguistics Antipattern - The getter 'getDefault' should not return void linguistically 905908
CyclomaticComplexity The method 'setProperty(Object)' has a cyclomatic complexity of 13. 918984
ModifiedCyclomaticComplexity The method 'setProperty' has a Modified Cyclomatic Complexity of 11. 918984
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 918
StdCyclomaticComplexity The method 'setProperty' has a Standard Cyclomatic Complexity of 11. 918984
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 922
ConfusingTernary Avoid if (x != y) ..; else ..; 955967
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 974978
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 979983
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 996
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 996
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 997
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 997
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 998
ShortVariable Avoid variables with short names like e 998
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1003
LongVariable Avoid excessively long variable names like validatorClassName 1100
CyclomaticComplexity The method 'createValidator(String)' has a cyclomatic complexity of 10. 11001148
MethodArgumentCouldBeFinal Parameter 'validatorClassName' is not assigned and could be declared final 1100
ShortVariable Avoid variables with short names like v 1103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 1108
IdenticalCatchBranches 'catch' branch identical to 'InstantiationException' branch 11161121

org/apache/fulcrum/intake/model/FieldAdapter.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 3268
MethodArgumentCouldBeFinal Parameter 'xmlField' is not assigned and could be declared final 41
UnusedAssignment The initializer for variable 'field' is never used (overwritten on line 53) 43
LocalVariableCouldBeFinal Local variable 'type' could be declared final 44
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 49
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 63

org/apache/fulcrum/intake/model/FieldType.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 41
ShortVariable Avoid variables with short names like g 41
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 41
ShortVariable Avoid variables with short names like f 41
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 49
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 49
ShortVariable Avoid variables with short names like g 49
ShortVariable Avoid variables with short names like f 49
ShortVariable Avoid variables with short names like g 57
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 57
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 57
ShortVariable Avoid variables with short names like f 57
ShortVariable Avoid variables with short names like f 65
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 65
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 65
ShortVariable Avoid variables with short names like g 65
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 74
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 74
ShortVariable Avoid variables with short names like f 74
ShortVariable Avoid variables with short names like g 74
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 82
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 82
ShortVariable Avoid variables with short names like g 82
ShortVariable Avoid variables with short names like f 82
ShortVariable Avoid variables with short names like f 90
ShortVariable Avoid variables with short names like g 90
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 90
ShortVariable Avoid variables with short names like f 98
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 98
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 98
ShortVariable Avoid variables with short names like g 98
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 106
ShortVariable Avoid variables with short names like g 106
ShortVariable Avoid variables with short names like f 106
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 106
ShortVariable Avoid variables with short names like f 115
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 115
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 115
ShortVariable Avoid variables with short names like g 115
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 123
ShortVariable Avoid variables with short names like f 123
ShortVariable Avoid variables with short names like g 123
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 123
ShortVariable Avoid variables with short names like g 131
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 131
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 131
ShortVariable Avoid variables with short names like f 131
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 139
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 139
ShortVariable Avoid variables with short names like f 139
ShortVariable Avoid variables with short names like g 139
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 144
ConfusingTernary Avoid if (x != y) ..; else ..; 149179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 156
LocalVariableCouldBeFinal Local variable 'constructor' could be declared final 156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 158
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 167
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 194
ShortVariable Avoid variables with short names like g 218
ShortVariable Avoid variables with short names like f 218

org/apache/fulcrum/intake/model/FloatField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 56
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 58
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 77
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 79
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 104
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 132
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 138

org/apache/fulcrum/intake/model/Group.java

Rule Violation Line
CyclomaticComplexity The class 'Group' has a total cyclomatic complexity of 80 (highest 9). 59755
GodClass Possible God Class (WMC=80, ATFD=75, TCC=20.923%) 59755
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 85
ImmutableField Private field 'poolCapacity' could be made final; it is only initialized in the declaration or constructor. 91
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 91
LongVariable Avoid excessively long variable names like defaultMapToObject 97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 107
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 112
LooseCoupling Avoid using implementation types like 'LinkedList'; use the interface instead 117
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 123
ShortVariable Avoid variables with short names like pp 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 133
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 141
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 150
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 160
ShortVariable Avoid variables with short names like pp 160
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 174
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 174
ShortVariable Avoid variables with short names like pp 174
LocalVariableCouldBeFinal Local variable 'i' could be declared final 178
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 180
LocalVariableCouldBeFinal Local variable 'i' could be declared final 182
LocalVariableCouldBeFinal Local variable 'field' could be declared final 184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 187
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 199
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 206
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 216
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 217228
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 219220
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 223226
ShortVariable Avoid variables with short names like i 244
LocalVariableCouldBeFinal Local variable 'f' could be declared final 245
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 322
ShortVariable Avoid variables with short names like pp 322
LocalVariableCouldBeFinal Local variable 'oids' could be declared final 325
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 328
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 331
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 344
MethodArgumentCouldBeFinal Parameter 'inputFields' is not assigned and could be declared final 374
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 376
LocalVariableCouldBeFinal Local variable 'i' could be declared final 387
LocalVariableCouldBeFinal Local variable 'field' could be declared final 389
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 390
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 391
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 394
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 395
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 408
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 419
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 429
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 430441
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 432433
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 436439
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 458
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 463
EmptyCatchBlock Avoid empty catch blocks 472475
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 480
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 481499
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 483484
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 487497
EmptyCatchBlock Avoid empty catch blocks 493496
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 515
LinguisticNaming Linguistics Antipattern - The getter 'getProperties' should not return void linguistically 515547
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 521
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 531
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 532543
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 534535
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 538541
LocalVariableCouldBeFinal Local variable 'groups' could be declared final 557
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 561567
LocalVariableCouldBeFinal Local variable 'i' could be declared final 568
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 570
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 593
ShortVariable Avoid variables with short names like sb 593
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 604
ShortVariable Avoid variables with short names like sb 604
LocalVariableCouldBeFinal Local variable 'result' could be declared final 624
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 626
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 627
LocalVariableCouldBeFinal Local variable 'field' could be declared final 632
MethodArgumentCouldBeFinal Parameter 'parent' is not assigned and could be declared final 659
ShortVariable Avoid variables with short names like um 659
MethodArgumentCouldBeFinal Parameter 'um' is not assigned and could be declared final 659
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 664
LocalVariableCouldBeFinal Local variable 'field' could be declared final 666
LocalVariableCouldBeFinal Local variable 'mapToObjectFieldLists' could be declared final 671672
LongVariable Avoid excessively long variable names like mapToObjectFieldLists 671
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 671
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 672
LocalVariableCouldBeFinal Local variable 'field' could be declared final 675
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 686
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 686
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 694
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 696
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 699
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 699
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 708
CallSuperInConstructor It is a good practice to call super() in a constructor 710713
MethodArgumentCouldBeFinal Parameter 'appData' is not assigned and could be declared final 710
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 722
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 731
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 742
MethodArgumentCouldBeFinal Parameter 'pooledGroup' is not assigned and could be declared final 742
LocalVariableCouldBeFinal Local variable 'group' could be declared final 744
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 745
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 745
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 746
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 746
LawOfDemeter Potential violation of Law of Demeter (static property access) 747
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 747
LocalVariableCouldBeFinal Local variable 'i' could be declared final 747
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 747
LawOfDemeter Potential violation of Law of Demeter (static property access) 747
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 750
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 752

org/apache/fulcrum/intake/model/IntegerField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 131
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 137

org/apache/fulcrum/intake/model/LongField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 130
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 136

org/apache/fulcrum/intake/model/Rule.java

Rule Violation Line
AtLeastOneConstructor Each class should declare at least one constructor 41109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 55
LocalVariableCouldBeFinal Local variable 'result' could be declared final 91

org/apache/fulcrum/intake/model/ShortField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 131
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 137
LocalVariableCouldBeFinal Local variable 'value' could be declared final 145
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 153

org/apache/fulcrum/intake/model/StringField.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 47
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 70
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 84
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 97
ShortVariable Avoid variables with short names like ss 97
LocalVariableCouldBeFinal Local variable 'val' could be declared final 107
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 119
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 119
CyclomaticComplexity The method 'setRequired(boolean, String)' has a cyclomatic complexity of 10. 119159
ShortVariable Avoid variables with short names like v 119
ShortVariable Avoid variables with short names like ss 126
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 126
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 135142

org/apache/fulcrum/intake/model/UploadPartField.java

Rule Violation Line
StdCyclomaticComplexity The class 'UploadPartField' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 37228
ModifiedCyclomaticComplexity The class 'UploadPartField' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 37228
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 50
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 65
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 74
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 86
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 95
ShortVariable Avoid variables with short names like vp 120
MethodArgumentCouldBeFinal Parameter 'vp' is not assigned and could be declared final 120
CyclomaticComplexity The method 'validate()' has a cyclomatic complexity of 14. 146210
StdCyclomaticComplexity The method 'validate' has a Standard Cyclomatic Complexity of 12. 146210
ModifiedCyclomaticComplexity The method 'validate' has a Modified Cyclomatic Complexity of 12. 146210
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 148
ShortVariable Avoid variables with short names like pp 148
ShortVariable Avoid variables with short names like ss 151
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 151
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 161171
ShortVariable Avoid variables with short names like s 181
LocalVariableCouldBeFinal Local variable 's' could be declared final 181
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 182
ConfusingTernary Avoid if (x != y) ..; else ..; 187206
ShortVariable Avoid variables with short names like pp 218
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 218

org/apache/fulcrum/intake/model/XmlField.java

Rule Violation Line
DataClass The class 'XmlField' is suspected to be a Data Class (WOC=27.273%, NOPA=0, NOAM=15, WMC=38) 53408
TooManyFields Too many fields 53408
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 74
ImmutableField Private field 'type' could be made final; it is only initialized in the declaration or constructor. 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 77
RedundantFieldInitializer Avoid using redundant field initializer for 'multiValued' 77
ImmutableField Private field 'multiValued' could be made final; it is only initialized in the declaration or constructor. 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 83
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 92
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 98
ImmutableField Private field 'ruleMap' could be made final; it is only initialized in the declaration or constructor. 98
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 102
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 109
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 110
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 117
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 222
MethodArgumentCouldBeFinal Parameter 'rules' is not assigned and could be declared final 296
ShortVariable Avoid variables with short names like um 318
MethodArgumentCouldBeFinal Parameter 'parent' is not assigned and could be declared final 318
MethodArgumentCouldBeFinal Parameter 'um' is not assigned and could be declared final 318
LocalVariableCouldBeFinal Local variable 'rule' could be declared final 324
LocalVariableCouldBeFinal Local variable 'result' could be declared final 348
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 379
LocalVariableCouldBeFinal Local variable 'rule' could be declared final 386
MethodArgumentCouldBeFinal Parameter 'stream' is not assigned and could be declared final 397
MethodArgumentCouldBeFinal Parameter 'stream' is not assigned and could be declared final 403

org/apache/fulcrum/intake/validator/BigDecimalValidator.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 63
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 63
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 63
LocalVariableCouldBeFinal Local variable 'number' could be declared final 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 66
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 66

org/apache/fulcrum/intake/validator/BooleanValidator.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6972
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 83
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 96
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 108

org/apache/fulcrum/intake/validator/DateRangeValidator.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the fieldReferences field if you want a default access modifier 70
DefaultPackage Use explicit scoping instead of the default package private level 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 70
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the compareCallback field if you want a default access modifier 73
DefaultPackage Use explicit scoping instead of the default package private level 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 73
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7881
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 90
MethodArgumentCouldBeFinal Parameter 'refValue' is not assigned and could be declared final 107
MethodArgumentCouldBeFinal Parameter 'thisValue' is not assigned and could be declared final 107
MethodArgumentCouldBeFinal Parameter 'compare' is not assigned and could be declared final 107
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 134
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 136
LocalVariableCouldBeFinal Local variable 'key' could be declared final 138
LocalVariableCouldBeFinal Local variable 'constraint' could be declared final 139
LocalVariableCouldBeFinal Local variable 'compare' could be declared final 141
LocalVariableCouldBeFinal Local variable 'fieldref' could be declared final 146
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 146
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 149
MethodArgumentCouldBeFinal Parameter 'testField' is not assigned and could be declared final 170
LocalVariableCouldBeFinal Local variable 'thisGroup' could be declared final 175
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 179
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 181184
LocalVariableCouldBeFinal Local variable 'testValue' could be declared final 188
UnusedAssignment The initializer for variable 'testDate' is never used (overwritten on line 213) 209
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 220

org/apache/fulcrum/intake/validator/DateStringValidator.java

Rule Violation Line
LongVariable Avoid excessively long variable names like DEFAULT_DATE_MESSAGE 59
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormats' 63
UnusedAssignment The field initializer for 'dateFormats' is never used (overwritten on line 77) 63
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormatMessage' 66
RedundantFieldInitializer Avoid using redundant field initializer for 'flexible' 69
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 77
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 87
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 122
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 122
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 135
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 149
CyclomaticComplexity The method 'parse(String)' has a cyclomatic complexity of 11. 166221
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 166
ShortVariable Avoid variables with short names like s 166
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 169
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 176
EmptyCatchBlock Avoid empty catch blocks 187190
EmptyCatchBlock Avoid empty catch blocks 201204
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 210
MethodArgumentCouldBeFinal Parameter 'date' is not assigned and could be declared final 230
ShortVariable Avoid variables with short names like s 232
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 236
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 236
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 265
MethodArgumentCouldBeFinal Parameter 'formats' is not assigned and could be declared final 288
MethodArgumentCouldBeFinal Parameter 'flexible' is not assigned and could be declared final 308

org/apache/fulcrum/intake/validator/DefaultValidator.java

Rule Violation Line
AbstractNaming Abstract classes should be named AbstractXXX 50383
RedundantFieldInitializer Avoid using redundant field initializer for 'required' 54
RedundantFieldInitializer Avoid using redundant field initializer for 'requiredMessage' 57
RedundantFieldInitializer Avoid using redundant field initializer for 'minLength' 60
RedundantFieldInitializer Avoid using redundant field initializer for 'minLengthMessage' 63
RedundantFieldInitializer Avoid using redundant field initializer for 'maxLength' 66
RedundantFieldInitializer Avoid using redundant field initializer for 'maxLengthMessage' 69
RedundantFieldInitializer Avoid using redundant field initializer for 'errorMessage' 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 75
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8083
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 91
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 103
LocalVariableCouldBeFinal Local variable 'param' could be declared final 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 110
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 110
LocalVariableCouldBeFinal Local variable 'param' could be declared final 117
LocalVariableCouldBeFinal Local variable 'param' could be declared final 125
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 139
UnusedAssignment The initializer for variable 'valid' is never used (overwritten on lines 145 and 149) 141
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 163
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 168
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 170173
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 192
UnusedAssignment The initializer for variable 'valid' is never used (overwritten on lines 198 and 202) 194
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 216
CyclomaticComplexity The method 'assertValidity(String)' has a cyclomatic complexity of 12. 216239
MethodArgumentCouldBeFinal Parameter 'required' is not assigned and could be declared final 279
MethodArgumentCouldBeFinal Parameter 'requiredMessage' is not assigned and could be declared final 299
MethodArgumentCouldBeFinal Parameter 'minLength' is not assigned and could be declared final 319
MethodArgumentCouldBeFinal Parameter 'minLengthMessage' is not assigned and could be declared final 339
MethodArgumentCouldBeFinal Parameter 'maxLength' is not assigned and could be declared final 359
MethodArgumentCouldBeFinal Parameter 'maxLengthMessage' is not assigned and could be declared final 379

org/apache/fulcrum/intake/validator/DoubleValidator.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 61
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 61
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 61
LocalVariableCouldBeFinal Local variable 'number' could be declared final 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 64

org/apache/fulcrum/intake/validator/FieldReference.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Comparison': nested enums are implicitly static 64106
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Comparison(String)': enum constructors are implicitly private 8083
MethodArgumentCouldBeFinal Parameter 'text' is not assigned and could be declared final 80
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 91
LocalVariableCouldBeFinal Local variable 'c' could be declared final 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 99
RedundantFieldInitializer Avoid using redundant field initializer for 'compare' 109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 109
RedundantFieldInitializer Avoid using redundant field initializer for 'fieldName' 112
RedundantFieldInitializer Avoid using redundant field initializer for 'message' 115
MethodArgumentCouldBeFinal Parameter 'compare' is not assigned and could be declared final 136
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 152
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 168
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 179
MethodArgumentCouldBeFinal Parameter 'compareCallback' is not assigned and could be declared final 196
MethodArgumentCouldBeFinal Parameter 'fieldReferences' is not assigned and could be declared final 196
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 197
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 197
LocalVariableCouldBeFinal Local variable 'ref' could be declared final 200
LocalVariableCouldBeFinal Local variable 'refField' could be declared final 207
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 209
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 218
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 221
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 225
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 231
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 234

org/apache/fulcrum/intake/validator/FileValidator.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 5053
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 63
LocalVariableCouldBeFinal Local variable 'contentType' could be declared final 67
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 68
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 70
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 72
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 73
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 75
LocalVariableCouldBeFinal Local variable 'byteSize' could be declared final 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 90
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 103

org/apache/fulcrum/intake/validator/FloatValidator.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 61
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 61
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 61
LocalVariableCouldBeFinal Local variable 'number' could be declared final 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 64

org/apache/fulcrum/intake/validator/IntegerRangeValidator.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the fieldReferences field if you want a default access modifier 69
DefaultPackage Use explicit scoping instead of the default package private level 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 69
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the compareCallback field if you want a default access modifier 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 72
DefaultPackage Use explicit scoping instead of the default package private level 72
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7780
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 89
MethodArgumentCouldBeFinal Parameter 'refValue' is not assigned and could be declared final 106
MethodArgumentCouldBeFinal Parameter 'thisValue' is not assigned and could be declared final 106
MethodArgumentCouldBeFinal Parameter 'compare' is not assigned and could be declared final 106
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 133
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 135
LocalVariableCouldBeFinal Local variable 'key' could be declared final 137
LocalVariableCouldBeFinal Local variable 'constraint' could be declared final 138
LocalVariableCouldBeFinal Local variable 'compare' could be declared final 140
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 145
LocalVariableCouldBeFinal Local variable 'fieldref' could be declared final 145
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 148
LocalVariableCouldBeFinal Local variable 'thisGroup' could be declared final 174
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 175
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 179
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 181184
LocalVariableCouldBeFinal Local variable 'testValue' could be declared final 188
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 219

org/apache/fulcrum/intake/validator/IntegerValidator.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 60
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 60

org/apache/fulcrum/intake/validator/InvalidMaskException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 44
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 55
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 55

org/apache/fulcrum/intake/validator/LongValidator.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 60
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 60

org/apache/fulcrum/intake/validator/NumberValidator.java

Rule Violation Line
DataClass The class 'NumberValidator' is suspected to be a Data Class (WOC=21.429%, NOPA=0, NOAM=10, WMC=38) 52341
AbstractNaming Abstract classes should be named AbstractXXX 52341
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the minValueMessage field if you want a default access modifier 56
DefaultPackage Use explicit scoping instead of the default package private level 56
RedundantFieldInitializer Avoid using redundant field initializer for 'minValueMessage' 56
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the maxValueMessage field if you want a default access modifier 59
DefaultPackage Use explicit scoping instead of the default package private level 59
RedundantFieldInitializer Avoid using redundant field initializer for 'maxValueMessage' 59
RedundantFieldInitializer Avoid using redundant field initializer for 'invalidNumberMessage' 62
LongVariable Avoid excessively long variable names like invalidNumberMessage 62
DefaultPackage Use explicit scoping instead of the default package private level 62
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the invalidNumberMessage field if you want a default access modifier 62
RedundantFieldInitializer Avoid using redundant field initializer for 'minValue' 64
RedundantFieldInitializer Avoid using redundant field initializer for 'maxValue' 65
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7073
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 84
LocalVariableCouldBeFinal Local variable 'param' could be declared final 99
LocalVariableCouldBeFinal Local variable 'param' could be declared final 114
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 137
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 149
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 149
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 149
LocalVariableCouldBeFinal Local variable 'nf' could be declared final 151
ShortVariable Avoid variables with short names like nf 151
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 155
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 156
LocalVariableCouldBeFinal Local variable 'number' could be declared final 156
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 167
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 180
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 182
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 186
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 188191
CyclomaticComplexity The method 'assertValidity(String, Locale)' has a cyclomatic complexity of 11. 208236
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 208
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 208
UnusedAssignment The initializer for variable 'number' is never used (overwritten on line 217) 214
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 222
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 225
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 230
MethodArgumentCouldBeFinal Parameter 'minValueMessage' is not assigned and could be declared final 257
MethodArgumentCouldBeFinal Parameter 'maxValueMessage' is not assigned and could be declared final 277
MethodArgumentCouldBeFinal Parameter 'invalidNumberMessage' is not assigned and could be declared final 297
LongVariable Avoid excessively long variable names like invalidNumberMessage 297
MethodArgumentCouldBeFinal Parameter 'minValue' is not assigned and could be declared final 317
MethodArgumentCouldBeFinal Parameter 'maxValue' is not assigned and could be declared final 337

org/apache/fulcrum/intake/validator/ShortValidator.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 60
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 60
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 60

org/apache/fulcrum/intake/validator/StringValidator.java

Rule Violation Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 53
RedundantFieldInitializer Avoid using redundant field initializer for 'maskString' 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 56
RedundantFieldInitializer Avoid using redundant field initializer for 'maskPattern' 56
RedundantFieldInitializer Avoid using redundant field initializer for 'maskMessage' 59
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6467
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 78
LocalVariableCouldBeFinal Local variable 'constraint' could be declared final 83
LocalVariableCouldBeFinal Local variable 'param' could be declared final 86
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 102
LocalVariableCouldBeFinal Local variable 'patternMatch' could be declared final 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 110
MethodArgumentCouldBeFinal Parameter 'mask' is not assigned and could be declared final 143
LocalVariableCouldBeFinal Local variable 'maskOptions' could be declared final 149
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 177

org/apache/fulcrum/intake/validator/ValidationException.java

Rule Violation Line
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 45

org/apache/fulcrum/intake/validator/Validator.java

Rule Violation Line
LongVariable Avoid excessively long variable names like FLEXIBLE_RULE_NAME 34
LongVariable Avoid excessively long variable names like INVALID_NUMBER_RULE_NAME 40
LongVariable Avoid excessively long variable names like MAX_LENGTH_RULE_NAME 46
LongVariable Avoid excessively long variable names like MAX_VALUE_RULE_NAME 49
LongVariable Avoid excessively long variable names like MIN_LENGTH_RULE_NAME 52
LongVariable Avoid excessively long variable names like MIN_VALUE_RULE_NAME 55
LongVariable Avoid excessively long variable names like REQUIRED_RULE_NAME 58

Priority 4

org/apache/fulcrum/intake/model/Field.java

Rule Violation Line
UselessParentheses Useless parentheses. 1061
UselessParentheses Useless parentheses. 1073

org/apache/fulcrum/intake/model/Rule.java

Rule Violation Line
ShortClassName Avoid short class names like Rule 41109

Priority 5

org/apache/fulcrum/intake/IntakeServiceImpl.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timer' (lines '202'-'311'). 202311
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'in' (lines '223'-'229'). 223229
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serialData' (lines '224'-'236'). 224236
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serialData' (lines '236'-'259'). 236259
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serialData' (lines '259'-'267'). 259267
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timer' (lines '330'-'420'). 330420
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '435'-'460'). 435460
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'group' (lines '435'-'453'). 435453
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'appData' (lines '437'-'460'). 437460
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '453'-'460'). 453460
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pd' (lines '646'-'649'). 646649
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'appDataElements' (lines '727'-'774'). 727774
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'appDataElements' (lines '727'-'904'). 727904
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'xmlFiles' (lines '736'-'904'). 736904
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timeStamp' (lines '738'-'904'). 738904
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timeStamp' (lines '765'-'904'). 765904
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'dataFile' (lines '836'-'904'). 836904
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'groupPrefix' (lines '841'-'904'). 841904

org/apache/fulcrum/intake/model/AppData.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'groupPrefix' (lines '101'-'124'). 101124

org/apache/fulcrum/intake/model/BooleanField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '131'-'135'). 131135
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '135'-'135'). 135
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '156'-'159'). 156159

org/apache/fulcrum/intake/model/DateStringField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '147'-'152'). 147152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '152'-'157'). 152157
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '157'-'152'). 157152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'date' (lines '188'-'197'). 188197
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'date' (lines '188'-'193'). 188193
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'215'). 210215
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'219'). 210219
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'227'). 210227
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'223'). 210223
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'validator' (lines '212'-'230'). 212230

org/apache/fulcrum/intake/model/DoubleField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '133'-'137'). 133137
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '137'-'137'). 137

org/apache/fulcrum/intake/model/Field.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tmpGetter' (lines '258'-'265'). 258265
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tmpSetter' (lines '259'-'277'). 259277
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '813'-'816'). 813816
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '816'-'826'). 816826
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '841'-'849'). 841849
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '841'-'845'). 841845
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'v' (lines '1.107'-'1.148'). 11071148

org/apache/fulcrum/intake/model/FieldAdapter.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'field' (lines '43'-'57'). 4357
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'field' (lines '43'-'53'). 4353

org/apache/fulcrum/intake/model/FloatField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '133'-'137'). 133137
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '137'-'137'). 137

org/apache/fulcrum/intake/model/Group.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'nameList' (lines '243'-'247'). 243247
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '244'-'250'). 244250
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'nameList' (lines '247'-'247'). 247
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'objs' (lines '324'-'328'). 324328

org/apache/fulcrum/intake/model/IntegerField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '132'-'136'). 132136
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '136'-'136'). 136

org/apache/fulcrum/intake/model/LongField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '131'-'135'). 131135
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '135'-'135'). 135

org/apache/fulcrum/intake/model/ShortField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '132'-'136'). 132136
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '136'-'136'). 136

org/apache/fulcrum/intake/model/StringField.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'sval' (lines '98'-'101'). 98101
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'sval' (lines '101'-'101'). 101

org/apache/fulcrum/intake/validator/BooleanValidator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '111'-'127'). 111127
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '111'-'120'). 111120

org/apache/fulcrum/intake/validator/DateRangeValidator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'126'). 109126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'122'). 109122
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'114'). 109114
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'114'). 109114
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'118'). 109118
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'126'). 109126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'118'). 109118
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'122'). 109122
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'thisGroup' (lines '175'-'192'). 175192
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'testDate' (lines '209'-'213'). 209213
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'testDate' (lines '213'-'234'). 213234

org/apache/fulcrum/intake/validator/DateStringValidator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '100'-'100'). 100
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '100'-'124'). 100124
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'date' (lines '169'-'221'). 169221
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '232'-'237'). 232237

org/apache/fulcrum/intake/validator/DefaultValidator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '141'-'145'). 141145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '145'-'149'). 145149
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '194'-'198'). 194198
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '198'-'202'). 198202
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'retValue' (lines '250'-'254'). 250254

org/apache/fulcrum/intake/validator/FieldReference.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'comp_true' (lines '202'-'239'). 202239
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'comp_true' (lines '202'-'223'). 202223
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'comp_true' (lines '223'-'239'). 223239

org/apache/fulcrum/intake/validator/FileValidator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'charset' (lines '68'-'75'). 6875
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '68'-'107'). 68107
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '75'-'107'). 75107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'content' (lines '93'-'98'). 9398
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'content' (lines '93'-'107'). 93107
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'content' (lines '98'-'107'). 98107

org/apache/fulcrum/intake/validator/IntegerRangeValidator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'113'). 108113
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'121'). 108121
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'117'). 108117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'113'). 108113
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'117'). 108117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'121'). 108121
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'125'). 108125
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'125'). 108125
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'thisGroup' (lines '174'-'192'). 174192
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'locale' (lines '175'-'192'). 175192
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'testInt' (lines '214'-'233'). 214233

org/apache/fulcrum/intake/validator/NumberValidator.java

Rule Violation Line
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'number' (lines '156'-'169'). 156169
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'locale' (lines '182'-'197'). 182197
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'number' (lines '214'-'217'). 214217
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'number' (lines '217'-'236'). 217236

Files

org/apache/fulcrum/intake/IntakeError.java

Rule Violation Priority Line
DoNotExtendJavaLangError Exceptions should not extend java.lang.Error 3 28
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 75
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 75

org/apache/fulcrum/intake/IntakeException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 75
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 75

org/apache/fulcrum/intake/IntakeRuntimeException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 62
MethodArgumentCouldBeFinal Parameter 'nested' is not assigned and could be declared final 3 75
MethodArgumentCouldBeFinal Parameter 'msg' is not assigned and could be declared final 3 75

org/apache/fulcrum/intake/IntakeService.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like SERIAL_XML_DEFAULT 3 69
LongVariable Avoid excessively long variable names like DEFAULT_POOL_CAPACITY 3 74

org/apache/fulcrum/intake/IntakeServiceFacade.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'IntakeServiceFacade' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)' 1 41182
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 42182
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 65
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 71
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 3 82
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 84
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 96
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 98
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 108
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 118
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 120
MethodArgumentCouldBeFinal Parameter 'groupKey' is not assigned and could be declared final 3 130
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 132
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 146
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 3 146
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 148
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 3 162
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 162
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 164
MethodArgumentCouldBeFinal Parameter 'service' is not assigned and could be declared final 3 177

org/apache/fulcrum/intake/IntakeServiceImpl.java

Rule Violation Priority Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 3 1936
StdCyclomaticComplexity The class 'IntakeServiceImpl' has a Standard Cyclomatic Complexity of 5 (Highest = 16). 3 80936
CyclomaticComplexity The class 'IntakeServiceImpl' has a total cyclomatic complexity of 89 (highest 16). 3 80936
ModifiedCyclomaticComplexity The class 'IntakeServiceImpl' has a Modified Cyclomatic Complexity of 5 (Highest = 16). 3 80936
AtLeastOneConstructor Each class should declare at least one constructor 3 80936
GodClass Possible God Class (WMC=89, ATFD=52, TCC=28.571%) 3 80936
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 85
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 88
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 91
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 94
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 100
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 103
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 106
RedundantFieldInitializer Avoid using redundant field initializer for 'xmlPathes' 3 106
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 109
RedundantFieldInitializer Avoid using redundant field initializer for 'serialDataPath' 3 109
AtLeastOneConstructor Each class should declare at least one constructor 3 115131
MethodArgumentCouldBeFinal Parameter 'target' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'parent' is not assigned and could be declared final 3 121
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 147
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 147
MethodArgumentCouldBeFinal Parameter 'appData' is not assigned and could be declared final 3 148
MethodArgumentCouldBeFinal Parameter 'checkKey' is not assigned and could be declared final 3 148
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 153
LocalVariableCouldBeFinal Local variable 'keyExists' could be declared final 3 156
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 161
LocalVariableCouldBeFinal Local variable 'fields' could be declared final 3 173
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 174
LocalVariableCouldBeFinal Local variable 'className' could be declared final 3 176
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 179
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 180
CyclomaticComplexity The method 'loadSerialized(String, long)' has a cyclomatic complexity of 16. 3 196311
ExcessiveMethodLength Avoid really long methods. 3 196311
MethodArgumentCouldBeFinal Parameter 'serialDataPath' is not assigned and could be declared final 3 196
StdCyclomaticComplexity The method 'loadSerialized' has a Standard Cyclomatic Complexity of 16. 3 196311
NPathComplexity The method 'loadSerialized(String, long)' has an NPath complexity of 576, current threshold is 200 3 196311
MethodArgumentCouldBeFinal Parameter 'timeStamp' is not assigned and could be declared final 3 196
ModifiedCyclomaticComplexity The method 'loadSerialized' has a Modified Cyclomatic Complexity of 16. 3 196311
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 198200
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 202
LocalVariableCouldBeFinal Local variable 'timer' could be declared final 3 202
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timer' (lines '202'-'311'). 5 202311
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 206
LocalVariableCouldBeFinal Local variable 'serialDataFile' could be declared final 3 209
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 213
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 214
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 219
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 220
ShortVariable Avoid variables with short names like in 3 223
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'in' (lines '223'-'229'). 5 223229
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serialData' (lines '224'-'236'). 5 224236
CloseResource Ensure that resources like this FileInputStream object are closed after use 3 228
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 228
LocalVariableCouldBeFinal Local variable 'fin' could be declared final 3 228
ShortVariable Avoid variables with short names like o 3 230
LocalVariableCouldBeFinal Local variable 'o' could be declared final 3 230
LocalVariableCouldBeFinal Local variable 'map' could be declared final 3 235
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serialData' (lines '236'-'259'). 5 236259
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 241
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 243
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 246
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 247
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 249
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 255
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'serialData' (lines '259'-'267'). 5 259267
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 259
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 263
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 267
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 282
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 3 289
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 291
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 298
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 308
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 309
StdCyclomaticComplexity The method 'saveSerialized' has a Standard Cyclomatic Complexity of 11. 3 323420
ModifiedCyclomaticComplexity The method 'saveSerialized' has a Modified Cyclomatic Complexity of 11. 3 323420
CyclomaticComplexity The method 'saveSerialized(String, Map)' has a cyclomatic complexity of 11. 3 323420
MethodArgumentCouldBeFinal Parameter 'appDataElements' is not assigned and could be declared final 3 323
MethodArgumentCouldBeFinal Parameter 'serialDataPath' is not assigned and could be declared final 3 323
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 326328
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timer' (lines '330'-'420'). 5 330420
LocalVariableCouldBeFinal Local variable 'timer' could be declared final 3 330
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 330
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 334
LocalVariableCouldBeFinal Local variable 'serialData' could be declared final 3 337
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 342
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 344
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 349
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 351
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 357359
ShortVariable Avoid variables with short names like in 3 364
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 369
LocalVariableCouldBeFinal Local variable 'fout' could be declared final 3 369
CloseResource Ensure that resources like this FileOutputStream object are closed after use 3 369
LocalVariableCouldBeFinal Local variable 'fin' could be declared final 3 376
CloseResource Ensure that resources like this FileInputStream object are closed after use 3 376
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 376
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 380
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 384386
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 390391
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 404
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 415
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 419
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 433
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 435
UnusedAssignment The initializer for variable 'group' is never used (overwritten on line 453) 3 435
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '435'-'460'). 5 435460
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'group' (lines '435'-'453'). 5 435453
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 437
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 3 437
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'appData' (lines '437'-'460'). 5 437460
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 453
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'group' (lines '453'-'460'). 5 453460
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 455
MethodArgumentCouldBeFinal Parameter 'instance' is not assigned and could be declared final 3 472
LocalVariableCouldBeFinal Local variable 'groupName' could be declared final 3 476
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 3 477
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 489
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 491
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 508
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 3 510
CloseResource Ensure that resources like this KeyedObjectPool object are closed after use 3 518
LocalVariableCouldBeFinal Local variable 'kop' could be declared final 3 518
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 520
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 520
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 542
MethodArgumentCouldBeFinal Parameter 'groupKey' is not assigned and could be declared final 3 555
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 3 572
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 572
LocalVariableCouldBeFinal Local variable 'settersForClassName' could be declared final 3 575
LongVariable Avoid excessively long variable names like settersForClassName 3 575
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 583
LocalVariableCouldBeFinal Local variable 'pd' could be declared final 3 587588
ShortVariable Avoid variables with short names like pd 3 587
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 595597
LocalVariableCouldBeFinal Local variable 'gettersForClassName' could be declared final 3 604
LongVariable Avoid excessively long variable names like gettersForClassName 3 604
LocalVariableCouldBeFinal Local variable 'getter' could be declared final 3 608
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 611
MethodArgumentCouldBeFinal Parameter 'className' is not assigned and could be declared final 3 631
MethodArgumentCouldBeFinal Parameter 'propName' is not assigned and could be declared final 3 631
LocalVariableCouldBeFinal Local variable 'gettersForClassName' could be declared final 3 634
LongVariable Avoid excessively long variable names like gettersForClassName 3 634
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 642
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'pd' (lines '646'-'649'). 5 646649
ShortVariable Avoid variables with short names like pd 3 646
UnusedAssignment The initializer for variable 'pd' is never used (overwritten on line 649) 3 646
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 654656
LocalVariableCouldBeFinal Local variable 'settersForClassName' could be declared final 3 663
LongVariable Avoid excessively long variable names like settersForClassName 3 663
LocalVariableCouldBeFinal Local variable 'setter' could be declared final 3 667
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 670
MethodArgumentCouldBeFinal Parameter 'conf' is not assigned and could be declared final 3 683
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 687
LocalVariableCouldBeFinal Local variable 'nameVal' could be declared final 3 695
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 696700
LocalVariableCouldBeFinal Local variable 'val' could be declared final 3 698
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 703
ConfusingTernary Avoid if (x != y) ..; else ..; 3 705712
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 3 705
LiteralsFirstInComparisons Position literals first in String comparisons 3 705
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 711
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 714
NcssCount The method 'initialize()' has a NCSS line count of 85. 3 725904
NPathComplexity The method 'initialize()' has an NPath complexity of 840, current threshold is 200 3 725904
ModifiedCyclomaticComplexity The method 'initialize' has a Modified Cyclomatic Complexity of 15. 3 725904
ExcessiveMethodLength Avoid really long methods. 3 725904
StdCyclomaticComplexity The method 'initialize' has a Standard Cyclomatic Complexity of 15. 3 725904
CyclomaticComplexity The method 'initialize()' has a cyclomatic complexity of 16. 3 725904
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 727
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'appDataElements' (lines '727'-'774'). 5 727774
UnusedAssignment The initializer for variable 'appDataElements' is never used (overwritten on lines 774 and 795) 3 727
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'appDataElements' (lines '727'-'904'). 5 727904
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 729
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 730
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 731
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 732
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 733
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 734
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 736
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'xmlFiles' (lines '736'-'904'). 5 736904
LocalVariableCouldBeFinal Local variable 'xmlFiles' could be declared final 3 736
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timeStamp' (lines '738'-'904'). 5 738904
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 740
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 740
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 740
LocalVariableCouldBeFinal Local variable 'xmlPath' could be declared final 3 742
LocalVariableCouldBeFinal Local variable 'xmlFile' could be declared final 3 745
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 745
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 747
LocalVariableNamingConventions The local variable name 'READ_ERR' doesn't match '[a-z][a-zA-Z0-9]*' 1 751
LocalVariableCouldBeFinal Local variable 'READ_ERR' could be declared final 3 751752
VariableNamingConventions Variables should start with a lowercase character, 'READ_ERR' starts with uppercase character. 1 751
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'READ_ERR' is not final. 1 751
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 754
AvoidThrowingRawExceptionTypes Avoid throwing raw exception types. 1 755
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 760
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'timeStamp' (lines '765'-'904'). 5 765904
LocalVariableCouldBeFinal Local variable 'serializedMap' could be declared final 3 769
ConfusingTernary Avoid if (x != y) ..; else ..; 3 771827
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 775
LocalVariableCouldBeFinal Local variable 'timer' could be declared final 3 779
LocalVariableCouldBeFinal Local variable 'jaxb' could be declared final 3 782
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 783
ShortVariable Avoid variables with short names like um 3 783
LocalVariableCouldBeFinal Local variable 'um' could be declared final 3 783
LocalVariableCouldBeFinal Local variable 'logEnabledListener' could be declared final 3 789
LongVariable Avoid excessively long variable names like logEnabledListener 3 789
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 790
LocalVariableCouldBeFinal Local variable 'schemaURL' could be declared final 3 792
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 792
LocalVariableCouldBeFinal Local variable 'schemaFactory' could be declared final 3 793
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 794
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 795
LocalVariableCouldBeFinal Local variable 'xmlFile' could be declared final 3 797
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 799
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 1 803
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 803
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 804
LocalVariableCouldBeFinal Local variable 'appData' could be declared final 3 804
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 807
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 819
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 825
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 832
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'dataFile' (lines '836'-'904'). 5 836904
LocalVariableCouldBeFinal Local variable 'glist' could be declared final 3 839
LocalVariableCouldBeFinal Local variable 'groupPrefix' could be declared final 3 841
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'groupPrefix' (lines '841'-'904'). 5 841904
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 843
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 843
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 843
LocalVariableCouldBeFinal Local variable 'g' could be declared final 3 845
ShortVariable Avoid variables with short names like g 3 845
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 846
LocalVariableCouldBeFinal Local variable 'groupName' could be declared final 3 846
LongVariable Avoid excessively long variable names like registerUnqualified 3 848
LocalVariableCouldBeFinal Local variable 'registerUnqualified' could be declared final 3 848
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 852855
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 854
LocalVariableCouldBeFinal Local variable 'qualifiedName' could be declared final 3 860
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 860
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 872875
LocalVariableCouldBeFinal Local variable 'f' could be declared final 3 880
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 880
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 885
LocalVariableCouldBeFinal Local variable 'factory' could be declared final 3 888889
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 889
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 891
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 891
LocalVariableCouldBeFinal Local variable 'poolConfig' could be declared final 3 891
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 897
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 900
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 902
MethodArgumentCouldBeFinal Parameter 'context' is not assigned and could be declared final 3 916
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 918
MethodArgumentCouldBeFinal Parameter 'manager' is not assigned and could be declared final 3 932

org/apache/fulcrum/intake/Retrievable.java

Rule Violation Priority Line
SignatureDeclareThrowsException A method/constructor should not explicitly throw java.lang.Exception 3 46

org/apache/fulcrum/intake/model/AppData.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 43204
DataClass The class 'AppData' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=6, WMC=17) 3 43204
MethodArgumentCouldBeFinal Parameter 'groups' is not assigned and could be declared final 3 79
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 92
LocalVariableCouldBeFinal Local variable 'groupPrefix' could be declared final 3 101
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'groupPrefix' (lines '101'-'124'). 5 101124
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 103
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 105
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 107
LocalVariableCouldBeFinal Local variable 'qualifiedGroupName' could be declared final 3 111
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 111
LongVariable Avoid excessively long variable names like qualifiedGroupName 3 111
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 119
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 144
ShortVariable Avoid variables with short names like v 3 144
MethodArgumentCouldBeFinal Parameter 'groupPrefix' is not assigned and could be declared final 3 182
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 194
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 197

org/apache/fulcrum/intake/model/BigDecimalField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 48
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 48
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 60
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 62
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 83

org/apache/fulcrum/intake/model/BooleanField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 3 130
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '131'-'135'). 5 131135
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '135'-'135'). 5 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '156'-'159'). 5 156159
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 159
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 161
GuardLogStatement Logger calls should be surrounded by log level guards. 2 163

org/apache/fulcrum/intake/model/DateStringField.java

Rule Violation Priority Line
RedundantFieldInitializer Avoid using redundant field initializer for 'df' 3 50
ShortVariable Avoid variables with short names like df 3 50
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 50
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 59
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 59
LocalVariableCouldBeFinal Local variable 'validator' could be declared final 3 64
SimplifyConditional No need to check for null before an instanceof 3 65
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 78
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 80
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 107
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 109
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 3 146
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '147'-'152'). 5 147152
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '152'-'157'). 5 152157
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 157
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '157'-'152'). 5 157152
LocalVariableCouldBeFinal Local variable 'val' could be declared final 3 164
MethodArgumentCouldBeFinal Parameter 'dateString' is not assigned and could be declared final 3 185
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'date' (lines '188'-'197'). 5 188197
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'date' (lines '188'-'193'). 5 188193
UnusedAssignment The initializer for variable 'date' is never used (overwritten on lines 193 and 197) 3 188
LocalVariableCouldBeFinal Local variable 'validator' could be declared final 3 190
SimplifyConditional No need to check for null before an instanceof 3 191
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'215'). 5 210215
UnusedAssignment The initializer for variable 's' is never used (overwritten on lines 215, 219, 223 and 227) 3 210
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'219'). 5 210219
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'227'). 5 210227
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '210'-'223'). 5 210223
ShortVariable Avoid variables with short names like s 3 210
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 211
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'validator' (lines '212'-'230'). 5 212230
LocalVariableCouldBeFinal Local variable 'validator' could be declared final 3 212
SimplifyConditional No need to check for null before an instanceof 3 221

org/apache/fulcrum/intake/model/DoubleField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 56
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 58
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 77
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 79
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 104
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 3 132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '133'-'137'). 5 133137
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '137'-'137'). 5 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 138

org/apache/fulcrum/intake/model/Field.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=116, ATFD=37, TCC=9.991%) 3 521149
StdCyclomaticComplexity The class 'Field' has a Standard Cyclomatic Complexity of 2 (Highest = 11). 3 521149
CyclomaticComplexity The class 'Field' has a total cyclomatic complexity of 116 (highest 13). 3 521149
AbstractNaming Abstract classes should be named AbstractXXX 3 521149
ExcessiveClassLength Avoid really long classes. 3 521149
ModifiedCyclomaticComplexity The class 'Field' has a Modified Cyclomatic Complexity of 2 (Highest = 11). 3 521149
TooManyFields Too many fields 3 521149
TooManyMethods This class has too many methods, consider refactoring it. 3 531149
LongVariable Avoid excessively long variable names like VALUE_IF_ABSENT_KEY 3 61
LongVariable Avoid excessively long variable names like defaultValidatorPackage 3 64
FieldNamingConventions The public constant name 'defaultValidatorPackage' doesn't match '[A-Z][A-Z_0-9]*' 1 64
VariableNamingConventions Variables that are final and static should be all capitals, 'defaultValidatorPackage' is not all capitals. 1 64
FieldNamingConventions The public constant name 'defaultFieldPackage' doesn't match '[A-Z][A-Z_0-9]*' 1 67
VariableNamingConventions Variables that are final and static should be all capitals, 'defaultFieldPackage' is not all capitals. 1 67
LongVariable Avoid excessively long variable names like defaultFieldPackage 3 67
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 81
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 84
ImmutableField Private field 'mapToProperty' could be made final; it is only initialized in the declaration or constructor. 3 84
LongVariable Avoid excessively long variable names like validatorClassName 3 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 87
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 93
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 96
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 99
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 102
AvoidFieldNameMatchingMethodName Field isMultiValued has the same name as a method 3 102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 108
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 120
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 125
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 137
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 143
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 146
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 149
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 152
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 155
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 161
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 164
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 167
ImmutableField Private field 'ruleMap' could be made final; it is only initialized in the declaration or constructor. 3 167
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 170
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 181
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 181
ConstructorCallsOverridableMethod Overridable method 'enableLogging' called during object construction 1 183
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 196
GuardLogStatement Logger calls should be surrounded by log level guards. 2 198200
ConstructorCallsOverridableMethod Overridable method 'getDisplayName' called during object construction 1 199
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 207
GuardLogStatement Logger calls should be surrounded by log level guards. 2 209211
ConstructorCallsOverridableMethod Overridable method 'getDisplayName' called during object construction 1 210
ConstructorCallsOverridableMethod Overridable method 'getDefaultValidator' called during object construction 1 217
LocalVariableCouldBeFinal Local variable 'reqRule' could be declared final 3 225
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 228
LocalVariableCouldBeFinal Local variable 'maxLengthRule' could be declared final 3 232
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 248
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 250
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tmpGetter' (lines '258'-'265'). 5 258265
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'tmpSetter' (lines '259'-'277'). 5 259277
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 267
GuardLogStatement Logger calls should be surrounded by log level guards. 2 269273
AvoidDuplicateLiterals The String literal " in group " appears 4 times in this file; the first occurrence is on line 270 3 270
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 279
GuardLogStatement Logger calls should be surrounded by log level guards. 2 281285
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 303
ShortVariable Avoid variables with short names like pp 3 303
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 345
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 445
ShortVariable Avoid variables with short names like v 3 445
ShortVariable Avoid variables with short names like v 3 456
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 456
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 456
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 483
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 489
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 490
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 492
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 493
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 494
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 495
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 496
MethodArgumentCouldBeFinal Parameter 'newDisplayName' is not assigned and could be declared final 3 577
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 597
MethodArgumentCouldBeFinal Parameter 'setFlag' is not assigned and could be declared final 3 608
MethodArgumentCouldBeFinal Parameter 'validFlag' is not assigned and could be declared final 3 618
MethodArgumentCouldBeFinal Parameter 'validated' is not assigned and could be declared final 3 628
StdCyclomaticComplexity The method 'validate' has a Standard Cyclomatic Complexity of 11. 3 638716
CyclomaticComplexity The method 'validate()' has a cyclomatic complexity of 11. 3 638716
ModifiedCyclomaticComplexity The method 'validate' has a Modified Cyclomatic Complexity of 11. 3 638716
GuardLogStatement Logger calls should be surrounded by log level guards. 2 640
ShortVariable Avoid variables with short names like v 3 641
LocalVariableCouldBeFinal Local variable 'v' could be declared final 3 641
GuardLogStatement Logger calls should be surrounded by log level guards. 2 654
ConfusingTernary Avoid if (x != y) ..; else ..; 3 689710
GuardLogStatement Logger calls should be surrounded by log level guards. 2 698
GuardLogStatement Logger calls should be surrounded by log level guards. 2 703
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the setInitialValue method if you want a default access modifier 3 747750
DefaultPackage Use explicit scoping instead of the default package private level 3 747750
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 747
ConfusingTernary Avoid if (x != y) ..; else ..; 3 766773
DefaultPackage Use explicit scoping instead of the default package private level 3 784787
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the setTestValue method if you want a default access modifier 3 784787
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 784
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '813'-'816'). 5 813816
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'val' (lines '816'-'826'). 5 816826
GuardLogStatement Logger calls should be surrounded by log level guards. 2 820821
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '841'-'849'). 5 841849
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'res' (lines '841'-'845'). 5 841845
ConfusingTernary Avoid if (x != y) ..; else ..; 3 843850
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 849
LocalVariableCouldBeFinal Local variable 'res' could be declared final 3 864
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 876
LinguisticNaming Linguistics Antipattern - The getter 'getProperty' should not return void linguistically 3 876900
LocalVariableCouldBeFinal Local variable 't' could be declared final 3 882
ShortVariable Avoid variables with short names like t 3 882
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 890894
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 895899
LinguisticNaming Linguistics Antipattern - The getter 'getDefault' should not return void linguistically 3 905908
CyclomaticComplexity The method 'setProperty(Object)' has a cyclomatic complexity of 13. 3 918984
ModifiedCyclomaticComplexity The method 'setProperty' has a Modified Cyclomatic Complexity of 11. 3 918984
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 918
StdCyclomaticComplexity The method 'setProperty' has a Standard Cyclomatic Complexity of 11. 3 918984
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 922
ConfusingTernary Avoid if (x != y) ..; else ..; 3 955967
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 974978
IdenticalCatchBranches 'catch' branch identical to 'IllegalAccessException' branch 3 979983
MethodArgumentCouldBeFinal Parameter 'type' is not assigned and could be declared final 3 996
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 996
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 997
MethodArgumentCouldBeFinal Parameter 'groupName' is not assigned and could be declared final 3 997
MethodArgumentCouldBeFinal Parameter 'e' is not assigned and could be declared final 3 998
ShortVariable Avoid variables with short names like e 3 998
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1003
UselessParentheses Useless parentheses. 4 1061
UselessParentheses Useless parentheses. 4 1073
LongVariable Avoid excessively long variable names like validatorClassName 3 1100
CyclomaticComplexity The method 'createValidator(String)' has a cyclomatic complexity of 10. 3 11001148
MethodArgumentCouldBeFinal Parameter 'validatorClassName' is not assigned and could be declared final 3 1100
ShortVariable Avoid variables with short names like v 3 1103
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'v' (lines '1.107'-'1.148'). 5 11071148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 1108
IdenticalCatchBranches 'catch' branch identical to 'InstantiationException' branch 3 11161121

org/apache/fulcrum/intake/model/FieldAdapter.java

Rule Violation Priority Line
AtLeastOneConstructor Each class should declare at least one constructor 3 3268
MethodArgumentCouldBeFinal Parameter 'xmlField' is not assigned and could be declared final 3 41
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'field' (lines '43'-'57'). 5 4357
UnusedAssignment The initializer for variable 'field' is never used (overwritten on line 53) 3 43
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'field' (lines '43'-'53'). 5 4353
LocalVariableCouldBeFinal Local variable 'type' could be declared final 3 44
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 49
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 63

org/apache/fulcrum/intake/model/FieldType.java

Rule Violation Priority Line
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 4144
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 41
ShortVariable Avoid variables with short names like g 3 41
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 41
ShortVariable Avoid variables with short names like f 3 41
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 49
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 49
ShortVariable Avoid variables with short names like g 3 49
ShortVariable Avoid variables with short names like f 3 49
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 4952
ShortVariable Avoid variables with short names like g 3 57
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 5760
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 57
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 57
ShortVariable Avoid variables with short names like f 3 57
ShortVariable Avoid variables with short names like f 3 65
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 65
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 65
ShortVariable Avoid variables with short names like g 3 65
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 6568
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 74
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 74
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 7477
ShortVariable Avoid variables with short names like f 3 74
ShortVariable Avoid variables with short names like g 3 74
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 8285
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 82
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 82
ShortVariable Avoid variables with short names like g 3 82
ShortVariable Avoid variables with short names like f 3 82
ShortVariable Avoid variables with short names like f 3 90
ShortVariable Avoid variables with short names like g 3 90
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 90
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 9093
ShortVariable Avoid variables with short names like f 3 98
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 98
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 98101
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 98
ShortVariable Avoid variables with short names like g 3 98
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 106
ShortVariable Avoid variables with short names like g 3 106
ShortVariable Avoid variables with short names like f 3 106
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 106
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 115118
ShortVariable Avoid variables with short names like f 3 115
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 115
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 115
ShortVariable Avoid variables with short names like g 3 115
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 123
ShortVariable Avoid variables with short names like f 3 123
ShortVariable Avoid variables with short names like g 3 123
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 123126
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 123
SingletonClassReturningNewInstance getInstance method always creates a new object and hence does not comply to Singleton Design Pattern behaviour. Please review 2 131134
ShortVariable Avoid variables with short names like g 3 131
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 131
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 131
ShortVariable Avoid variables with short names like f 3 131
MethodArgumentCouldBeFinal Parameter 'g' is not assigned and could be declared final 3 139
MethodArgumentCouldBeFinal Parameter 'f' is not assigned and could be declared final 3 139
ShortVariable Avoid variables with short names like f 3 139
ShortVariable Avoid variables with short names like g 3 139
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 144
ConfusingTernary Avoid if (x != y) ..; else ..; 3 149179
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 156
LocalVariableCouldBeFinal Local variable 'constructor' could be declared final 3 156
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 158
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 167
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 194
ShortVariable Avoid variables with short names like g 3 218
ShortVariable Avoid variables with short names like f 3 218

org/apache/fulcrum/intake/model/FloatField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 56
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 58
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 77
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 79
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 104
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 3 132
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '133'-'137'). 5 133137
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '137'-'137'). 5 137
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 138

org/apache/fulcrum/intake/model/Group.java

Rule Violation Priority Line
CyclomaticComplexity The class 'Group' has a total cyclomatic complexity of 80 (highest 9). 3 59755
GodClass Possible God Class (WMC=80, ATFD=75, TCC=20.923%) 3 59755
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 79
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 85
ImmutableField Private field 'poolCapacity' could be made final; it is only initialized in the declaration or constructor. 3 91
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 91
LongVariable Avoid excessively long variable names like defaultMapToObject 3 97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 97
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 107
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 112
LooseCoupling Avoid using implementation types like 'LinkedList'; use the interface instead 3 117
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 123
ShortVariable Avoid variables with short names like pp 3 128
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 133
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 141
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 148
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 150
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 160
ShortVariable Avoid variables with short names like pp 3 160
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 174
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 174
ShortVariable Avoid variables with short names like pp 3 174
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 178
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 180
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 182
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 184
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 185
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 187
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 199
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 3 206
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 3 216
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 217228
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 3 219220
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 223226
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'nameList' (lines '243'-'247'). 5 243247
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '244'-'250'). 5 244250
ShortVariable Avoid variables with short names like i 3 244
LocalVariableCouldBeFinal Local variable 'f' could be declared final 3 245
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'nameList' (lines '247'-'247'). 5 247
MethodArgumentCouldBeFinal Parameter 'pp' is not assigned and could be declared final 3 322
ShortVariable Avoid variables with short names like pp 3 322
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'objs' (lines '324'-'328'). 5 324328
LocalVariableCouldBeFinal Local variable 'oids' could be declared final 3 325
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 328
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 331
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 344
MethodArgumentCouldBeFinal Parameter 'inputFields' is not assigned and could be declared final 3 374
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 376
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 387
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 389
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 390
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 391
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 394
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 395
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 408
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 3 419
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 3 429
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 430441
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 3 432433
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 436439
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 458
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 3 463
EmptyCatchBlock Avoid empty catch blocks 3 472475
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 3 480
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 481499
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 3 483484
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 487497
EmptyCatchBlock Avoid empty catch blocks 3 493496
MethodArgumentCouldBeFinal Parameter 'obj' is not assigned and could be declared final 3 515
LinguisticNaming Linguistics Antipattern - The getter 'getProperties' should not return void linguistically 3 515547
LocalVariableCouldBeFinal Local variable 'flds' could be declared final 3 521
LocalVariableCouldBeFinal Local variable 'interfaces' could be declared final 3 531
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 532543
LocalVariableCouldBeFinal Local variable 'interfaceFields' could be declared final 3 534535
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 538541
LocalVariableCouldBeFinal Local variable 'groups' could be declared final 3 557
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 561567
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 568
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 570
LocalVariableCouldBeFinal Local variable 'sb' could be declared final 3 593
ShortVariable Avoid variables with short names like sb 3 593
MethodArgumentCouldBeFinal Parameter 'sb' is not assigned and could be declared final 3 604
ShortVariable Avoid variables with short names like sb 3 604
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 624
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 626
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 3 627
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 632
MethodArgumentCouldBeFinal Parameter 'parent' is not assigned and could be declared final 3 659
ShortVariable Avoid variables with short names like um 3 659
MethodArgumentCouldBeFinal Parameter 'um' is not assigned and could be declared final 3 659
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 664
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 666
LocalVariableCouldBeFinal Local variable 'mapToObjectFieldLists' could be declared final 3 671672
LongVariable Avoid excessively long variable names like mapToObjectFieldLists 3 671
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 671
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 672
LocalVariableCouldBeFinal Local variable 'field' could be declared final 3 675
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 686
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 686
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 694
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 696
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 699
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 699
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 708
CallSuperInConstructor It is a good practice to call super() in a constructor 3 710713
MethodArgumentCouldBeFinal Parameter 'appData' is not assigned and could be declared final 3 710
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 722
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 731
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 742
MethodArgumentCouldBeFinal Parameter 'pooledGroup' is not assigned and could be declared final 3 742
LocalVariableCouldBeFinal Local variable 'group' could be declared final 3 744
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 745
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 745
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 746
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 746
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 747
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 747
LocalVariableCouldBeFinal Local variable 'i' could be declared final 3 747
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 747
LawOfDemeter Potential violation of Law of Demeter (static property access) 3 747
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 750
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 752

org/apache/fulcrum/intake/model/IntegerField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 3 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '132'-'136'). 5 132136
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '136'-'136'). 5 136
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 137

org/apache/fulcrum/intake/model/LongField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 3 130
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '131'-'135'). 5 131135
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '135'-'135'). 5 135
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 136

org/apache/fulcrum/intake/model/Rule.java

Rule Violation Priority Line
ShortClassName Avoid short class names like Rule 4 41109
AtLeastOneConstructor Each class should declare at least one constructor 3 41109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 49
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 52
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 55
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 91

org/apache/fulcrum/intake/model/ShortField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 43
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 55
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 57
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 76
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 78
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 103
LocalVariableCouldBeFinal Local variable 'inputs' could be declared final 3 131
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '132'-'136'). 5 132136
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'values' (lines '136'-'136'). 5 136
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 137
LocalVariableCouldBeFinal Local variable 'value' could be declared final 3 145
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 153

org/apache/fulcrum/intake/model/StringField.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 47
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 70
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 84
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 3 97
ShortVariable Avoid variables with short names like ss 3 97
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'sval' (lines '98'-'101'). 5 98101
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'sval' (lines '101'-'101'). 5 101
LocalVariableCouldBeFinal Local variable 'val' could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 119
MethodArgumentCouldBeFinal Parameter 'v' is not assigned and could be declared final 3 119
CyclomaticComplexity The method 'setRequired(boolean, String)' has a cyclomatic complexity of 10. 3 119159
ShortVariable Avoid variables with short names like v 3 119
ShortVariable Avoid variables with short names like ss 3 126
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 3 126
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 135142

org/apache/fulcrum/intake/model/UploadPartField.java

Rule Violation Priority Line
StdCyclomaticComplexity The class 'UploadPartField' has a Standard Cyclomatic Complexity of 3 (Highest = 12). 3 37228
ModifiedCyclomaticComplexity The class 'UploadPartField' has a Modified Cyclomatic Complexity of 3 (Highest = 12). 3 37228
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 50
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 65
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 74
MethodArgumentCouldBeFinal Parameter 'prop' is not assigned and could be declared final 3 86
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 95
ShortVariable Avoid variables with short names like vp 3 120
MethodArgumentCouldBeFinal Parameter 'vp' is not assigned and could be declared final 3 120
CyclomaticComplexity The method 'validate()' has a cyclomatic complexity of 14. 3 146210
StdCyclomaticComplexity The method 'validate' has a Standard Cyclomatic Complexity of 12. 3 146210
ModifiedCyclomaticComplexity The method 'validate' has a Modified Cyclomatic Complexity of 12. 3 146210
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 148
ShortVariable Avoid variables with short names like pp 3 148
ShortVariable Avoid variables with short names like ss 3 151
LocalVariableCouldBeFinal Local variable 'ss' could be declared final 3 151
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 161171
ShortVariable Avoid variables with short names like s 3 181
LocalVariableCouldBeFinal Local variable 's' could be declared final 3 181
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 182
ConfusingTernary Avoid if (x != y) ..; else ..; 3 187206
ShortVariable Avoid variables with short names like pp 3 218
LocalVariableCouldBeFinal Local variable 'pp' could be declared final 3 218

org/apache/fulcrum/intake/model/XmlField.java

Rule Violation Priority Line
DataClass The class 'XmlField' is suspected to be a Data Class (WOC=27.273%, NOPA=0, NOAM=15, WMC=38) 3 53408
TooManyFields Too many fields 3 53408
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 62
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 65
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 68
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 71
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 74
ImmutableField Private field 'type' could be made final; it is only initialized in the declaration or constructor. 3 74
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 77
RedundantFieldInitializer Avoid using redundant field initializer for 'multiValued' 3 77
ImmutableField Private field 'multiValued' could be made final; it is only initialized in the declaration or constructor. 3 77
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 80
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 83
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 86
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 89
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 92
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 95
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 98
ImmutableField Private field 'ruleMap' could be made final; it is only initialized in the declaration or constructor. 3 98
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 100
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 102
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 102
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 109
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 110
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 117
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 222
MethodArgumentCouldBeFinal Parameter 'rules' is not assigned and could be declared final 3 296
ShortVariable Avoid variables with short names like um 3 318
MethodArgumentCouldBeFinal Parameter 'parent' is not assigned and could be declared final 3 318
MethodArgumentCouldBeFinal Parameter 'um' is not assigned and could be declared final 3 318
LocalVariableCouldBeFinal Local variable 'rule' could be declared final 3 324
LocalVariableCouldBeFinal Local variable 'result' could be declared final 3 348
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 3 379
LocalVariableCouldBeFinal Local variable 'rule' could be declared final 3 386
MethodArgumentCouldBeFinal Parameter 'stream' is not assigned and could be declared final 3 397
MethodArgumentCouldBeFinal Parameter 'stream' is not assigned and could be declared final 3 403

org/apache/fulcrum/intake/validator/BigDecimalValidator.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 63
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 63
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 63
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 65
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 66
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 3 66

org/apache/fulcrum/intake/validator/BooleanValidator.java

Rule Violation Priority Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 6972
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 3 83
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 96
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 108
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '111'-'127'). 5 111127
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '111'-'120'). 5 111120

org/apache/fulcrum/intake/validator/DateRangeValidator.java

Rule Violation Priority Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the fieldReferences field if you want a default access modifier 3 70
DefaultPackage Use explicit scoping instead of the default package private level 3 70
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 70
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the compareCallback field if you want a default access modifier 3 73
DefaultPackage Use explicit scoping instead of the default package private level 3 73
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 73
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7881
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 3 90
MethodArgumentCouldBeFinal Parameter 'refValue' is not assigned and could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'thisValue' is not assigned and could be declared final 3 107
MethodArgumentCouldBeFinal Parameter 'compare' is not assigned and could be declared final 3 107
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'126'). 5 109126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'122'). 5 109122
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'114'). 5 109114
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'114'). 5 109114
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'118'). 5 109118
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'126'). 5 109126
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'118'). 5 109118
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '109'-'122'). 5 109122
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 134
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 136
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 138
LocalVariableCouldBeFinal Local variable 'constraint' could be declared final 3 139
LocalVariableCouldBeFinal Local variable 'compare' could be declared final 3 141
LocalVariableCouldBeFinal Local variable 'fieldref' could be declared final 3 146
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 146
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 149
MethodArgumentCouldBeFinal Parameter 'testField' is not assigned and could be declared final 3 170
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'thisGroup' (lines '175'-'192'). 5 175192
LocalVariableCouldBeFinal Local variable 'thisGroup' could be declared final 3 175
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 3 179
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 181184
LocalVariableCouldBeFinal Local variable 'testValue' could be declared final 3 188
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'testDate' (lines '209'-'213'). 5 209213
UnusedAssignment The initializer for variable 'testDate' is never used (overwritten on line 213) 3 209
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'testDate' (lines '213'-'234'). 5 213234
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 220

org/apache/fulcrum/intake/validator/DateStringValidator.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like DEFAULT_DATE_MESSAGE 3 59
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormats' 3 63
UnusedAssignment The field initializer for 'dateFormats' is never used (overwritten on line 77) 3 63
RedundantFieldInitializer Avoid using redundant field initializer for 'dateFormatMessage' 3 66
RedundantFieldInitializer Avoid using redundant field initializer for 'flexible' 3 69
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 77
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 3 87
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'i' (lines '100'-'100'). 5 100
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'i' (lines '100'-'124'). 5 100124
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 122
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 122
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 3 135
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 149
CyclomaticComplexity The method 'parse(String)' has a cyclomatic complexity of 11. 3 166221
MethodArgumentCouldBeFinal Parameter 's' is not assigned and could be declared final 3 166
ShortVariable Avoid variables with short names like s 3 166
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'date' (lines '169'-'221'). 5 169221
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 169
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 3 176
EmptyCatchBlock Avoid empty catch blocks 3 187190
EmptyCatchBlock Avoid empty catch blocks 3 201204
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 210
MethodArgumentCouldBeFinal Parameter 'date' is not assigned and could be declared final 3 230
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 's' (lines '232'-'237'). 5 232237
ShortVariable Avoid variables with short names like s 3 232
LocalVariableCouldBeFinal Local variable 'sdf' could be declared final 3 236
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 3 236
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 265
MethodArgumentCouldBeFinal Parameter 'formats' is not assigned and could be declared final 3 288
MethodArgumentCouldBeFinal Parameter 'flexible' is not assigned and could be declared final 3 308

org/apache/fulcrum/intake/validator/DefaultValidator.java

Rule Violation Priority Line
AbstractNaming Abstract classes should be named AbstractXXX 3 50383
RedundantFieldInitializer Avoid using redundant field initializer for 'required' 3 54
RedundantFieldInitializer Avoid using redundant field initializer for 'requiredMessage' 3 57
RedundantFieldInitializer Avoid using redundant field initializer for 'minLength' 3 60
RedundantFieldInitializer Avoid using redundant field initializer for 'minLengthMessage' 3 63
RedundantFieldInitializer Avoid using redundant field initializer for 'maxLength' 3 66
RedundantFieldInitializer Avoid using redundant field initializer for 'maxLengthMessage' 3 69
RedundantFieldInitializer Avoid using redundant field initializer for 'errorMessage' 3 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 72
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 2 75
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 75
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 8083
MethodArgumentCouldBeFinal Parameter 'logger' is not assigned and could be declared final 3 89
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 91
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 3 103
LocalVariableCouldBeFinal Local variable 'param' could be declared final 3 109
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 110
UnnecessaryWrapperObjectCreation Unnecessary wrapper object creation 3 110
LocalVariableCouldBeFinal Local variable 'param' could be declared final 3 117
LocalVariableCouldBeFinal Local variable 'param' could be declared final 3 125
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 139
UnusedAssignment The initializer for variable 'valid' is never used (overwritten on lines 145 and 149) 3 141
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '141'-'145'). 5 141145
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '145'-'149'). 5 145149
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 163
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 3 168
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 170173
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 3 192
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '194'-'198'). 5 194198
UnusedAssignment The initializer for variable 'valid' is never used (overwritten on lines 198 and 202) 3 194
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'valid' (lines '198'-'202'). 5 198202
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 3 216
CyclomaticComplexity The method 'assertValidity(String)' has a cyclomatic complexity of 12. 3 216239
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'retValue' (lines '250'-'254'). 5 250254
MethodArgumentCouldBeFinal Parameter 'required' is not assigned and could be declared final 3 279
MethodArgumentCouldBeFinal Parameter 'requiredMessage' is not assigned and could be declared final 3 299
MethodArgumentCouldBeFinal Parameter 'minLength' is not assigned and could be declared final 3 319
MethodArgumentCouldBeFinal Parameter 'minLengthMessage' is not assigned and could be declared final 3 339
MethodArgumentCouldBeFinal Parameter 'maxLength' is not assigned and could be declared final 3 359
MethodArgumentCouldBeFinal Parameter 'maxLengthMessage' is not assigned and could be declared final 3 379

org/apache/fulcrum/intake/validator/DoubleValidator.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 61
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 61
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 61
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 64

org/apache/fulcrum/intake/validator/FieldReference.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on enum 'Comparison': nested enums are implicitly static 3 64106
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'Comparison(String)': enum constructors are implicitly private 3 8083
MethodArgumentCouldBeFinal Parameter 'text' is not assigned and could be declared final 3 80
MethodArgumentCouldBeFinal Parameter 'string' is not assigned and could be declared final 3 91
LocalVariableCouldBeFinal Local variable 'c' could be declared final 3 95
OnlyOneReturn A method should have only one exit point, and that should be the last statement in the method 3 99
RedundantFieldInitializer Avoid using redundant field initializer for 'compare' 3 109
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 109
RedundantFieldInitializer Avoid using redundant field initializer for 'fieldName' 3 112
RedundantFieldInitializer Avoid using redundant field initializer for 'message' 3 115
MethodArgumentCouldBeFinal Parameter 'compare' is not assigned and could be declared final 3 136
MethodArgumentCouldBeFinal Parameter 'fieldName' is not assigned and could be declared final 3 152
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 168
MethodArgumentCouldBeFinal Parameter 'key' is not assigned and could be declared final 3 179
MethodArgumentCouldBeFinal Parameter 'compareCallback' is not assigned and could be declared final 3 196
MethodArgumentCouldBeFinal Parameter 'fieldReferences' is not assigned and could be declared final 3 196
MethodArgumentCouldBeFinal Parameter 'group' is not assigned and could be declared final 3 197
MethodArgumentCouldBeFinal Parameter 'value' is not assigned and could be declared final 3 197
LocalVariableCouldBeFinal Local variable 'ref' could be declared final 3 200
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'comp_true' (lines '202'-'239'). 5 202239
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'comp_true' (lines '202'-'223'). 5 202223
LocalVariableNamingConventions The local variable name 'comp_true' doesn't match '[a-z][a-zA-Z0-9]*' 1 202
VariableNamingConventions Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'comp_true' is not final. 1 202
LocalVariableCouldBeFinal Local variable 'refField' could be declared final 3 207
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 209
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 216
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 218
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 221
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'comp_true' (lines '223'-'239'). 5 223239
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 225
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 231
SimplifyBooleanExpressions Avoid unnecessary comparisons in boolean expressions 3 234

org/apache/fulcrum/intake/validator/FileValidator.java

Rule Violation Priority Line
FieldNamingConventions The constant name 'charsetPattern' doesn't match '[A-Z][A-Z_0-9]*' 1 45
VariableNamingConventions Variables that are final and static should be all capitals, 'charsetPattern' is not all capitals. 1 45
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 5053
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 3 63
LocalVariableCouldBeFinal Local variable 'contentType' could be declared final 3 67
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'charset' (lines '68'-'75'). 5 6875
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 68
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '68'-'107'). 5 68107
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 70
LocalVariableCouldBeFinal Local variable 'matcher' could be declared final 3 72
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 73
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'charset' (lines '75'-'107'). 5 75107
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 75
LocalVariableCouldBeFinal Local variable 'byteSize' could be declared final 3 81
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 90
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'content' (lines '93'-'98'). 5 9398
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'content' (lines '93'-'107'). 5 93107
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'content' (lines '98'-'107'). 5 98107
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 103

org/apache/fulcrum/intake/validator/FloatValidator.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 61
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 61
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 61
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 63
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 64

org/apache/fulcrum/intake/validator/IntegerRangeValidator.java

Rule Violation Priority Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the fieldReferences field if you want a default access modifier 3 69
DefaultPackage Use explicit scoping instead of the default package private level 3 69
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 69
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the compareCallback field if you want a default access modifier 3 72
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 72
DefaultPackage Use explicit scoping instead of the default package private level 3 72
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7780
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 3 89
MethodArgumentCouldBeFinal Parameter 'refValue' is not assigned and could be declared final 3 106
MethodArgumentCouldBeFinal Parameter 'thisValue' is not assigned and could be declared final 3 106
MethodArgumentCouldBeFinal Parameter 'compare' is not assigned and could be declared final 3 106
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'113'). 5 108113
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'121'). 5 108121
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'117'). 5 108117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'113'). 5 108113
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'117'). 5 108117
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'121'). 5 108121
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'125'). 5 108125
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'result' (lines '108'-'125'). 5 108125
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 133
LocalVariableCouldBeFinal Local variable 'entry' could be declared final 3 135
LocalVariableCouldBeFinal Local variable 'key' could be declared final 3 137
LocalVariableCouldBeFinal Local variable 'constraint' could be declared final 3 138
LocalVariableCouldBeFinal Local variable 'compare' could be declared final 3 140
AvoidInstantiatingObjectsInLoops Avoid instantiating new objects inside loops 3 145
LocalVariableCouldBeFinal Local variable 'fieldref' could be declared final 3 145
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 147
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 148
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'thisGroup' (lines '174'-'192'). 5 174192
LocalVariableCouldBeFinal Local variable 'thisGroup' could be declared final 3 174
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 3 175
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'locale' (lines '175'-'192'). 5 175192
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 3 179
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 181184
LocalVariableCouldBeFinal Local variable 'testValue' could be declared final 3 188
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'testInt' (lines '214'-'233'). 5 214233
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 219

org/apache/fulcrum/intake/validator/IntegerValidator.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 60
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 60

org/apache/fulcrum/intake/validator/InvalidMaskException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 44
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 55
MethodArgumentCouldBeFinal Parameter 'cause' is not assigned and could be declared final 3 55

org/apache/fulcrum/intake/validator/LongValidator.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 60
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 60

org/apache/fulcrum/intake/validator/NumberValidator.java

Rule Violation Priority Line
DataClass The class 'NumberValidator' is suspected to be a Data Class (WOC=21.429%, NOPA=0, NOAM=10, WMC=38) 3 52341
AbstractNaming Abstract classes should be named AbstractXXX 3 52341
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the minValueMessage field if you want a default access modifier 3 56
DefaultPackage Use explicit scoping instead of the default package private level 3 56
RedundantFieldInitializer Avoid using redundant field initializer for 'minValueMessage' 3 56
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the maxValueMessage field if you want a default access modifier 3 59
DefaultPackage Use explicit scoping instead of the default package private level 3 59
RedundantFieldInitializer Avoid using redundant field initializer for 'maxValueMessage' 3 59
RedundantFieldInitializer Avoid using redundant field initializer for 'invalidNumberMessage' 3 62
LongVariable Avoid excessively long variable names like invalidNumberMessage 3 62
DefaultPackage Use explicit scoping instead of the default package private level 3 62
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the invalidNumberMessage field if you want a default access modifier 3 62
RedundantFieldInitializer Avoid using redundant field initializer for 'minValue' 3 64
RedundantFieldInitializer Avoid using redundant field initializer for 'maxValue' 3 65
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 7073
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 3 84
LocalVariableCouldBeFinal Local variable 'param' could be declared final 3 99
LocalVariableCouldBeFinal Local variable 'param' could be declared final 3 114
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 137
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 149
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 149
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 149
LocalVariableCouldBeFinal Local variable 'nf' could be declared final 3 151
ShortVariable Avoid variables with short names like nf 3 151
LocalVariableCouldBeFinal Local variable 'pos' could be declared final 3 155
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 156
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'number' (lines '156'-'169'). 5 156169
LocalVariableCouldBeFinal Local variable 'number' could be declared final 3 156
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 167
MethodArgumentCouldBeFinal Parameter 'field' is not assigned and could be declared final 3 180
LocalVariableCouldBeFinal Local variable 'locale' could be declared final 3 182
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'locale' (lines '182'-'197'). 5 182197
LocalVariableCouldBeFinal Local variable 'stringValues' could be declared final 3 186
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 188191
CyclomaticComplexity The method 'assertValidity(String, Locale)' has a cyclomatic complexity of 11. 3 208236
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 3 208
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 208
DataflowAnomalyAnalysis Found 'DD'-anomaly for variable 'number' (lines '214'-'217'). 5 214217
UnusedAssignment The initializer for variable 'number' is never used (overwritten on line 217) 3 214
DataflowAnomalyAnalysis Found 'DU'-anomaly for variable 'number' (lines '217'-'236'). 5 217236
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 3 222
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 225
LawOfDemeter Potential violation of Law of Demeter (object not created locally) 3 230
MethodArgumentCouldBeFinal Parameter 'minValueMessage' is not assigned and could be declared final 3 257
MethodArgumentCouldBeFinal Parameter 'maxValueMessage' is not assigned and could be declared final 3 277
MethodArgumentCouldBeFinal Parameter 'invalidNumberMessage' is not assigned and could be declared final 3 297
LongVariable Avoid excessively long variable names like invalidNumberMessage 3 297
MethodArgumentCouldBeFinal Parameter 'minValue' is not assigned and could be declared final 3 317
MethodArgumentCouldBeFinal Parameter 'maxValue' is not assigned and could be declared final 3 337

org/apache/fulcrum/intake/validator/ShortValidator.java

Rule Violation Priority Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 3 60
MethodArgumentCouldBeFinal Parameter 'stringValue' is not assigned and could be declared final 3 60
MethodArgumentCouldBeFinal Parameter 'locale' is not assigned and could be declared final 3 60

org/apache/fulcrum/intake/validator/StringValidator.java

Rule Violation Priority Line
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 53
RedundantFieldInitializer Avoid using redundant field initializer for 'maskString' 3 53
BeanMembersShouldSerialize Found non-transient, non-static member. Please mark as transient or provide accessors. 3 56
RedundantFieldInitializer Avoid using redundant field initializer for 'maskPattern' 3 56
RedundantFieldInitializer Avoid using redundant field initializer for 'maskMessage' 3 59
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 3 6467
MethodArgumentCouldBeFinal Parameter 'paramMap' is not assigned and could be declared final 3 78
LocalVariableCouldBeFinal Local variable 'constraint' could be declared final 3 83
LocalVariableCouldBeFinal Local variable 'param' could be declared final 3 86
MethodArgumentCouldBeFinal Parameter 'testValue' is not assigned and could be declared final 3 102
LocalVariableCouldBeFinal Local variable 'patternMatch' could be declared final 3 110
LawOfDemeter Potential violation of Law of Demeter (method chain calls) 3 110
GuardLogStatement Logger calls should be surrounded by log level guards. 2 112113
MethodArgumentCouldBeFinal Parameter 'mask' is not assigned and could be declared final 3 143
LocalVariableCouldBeFinal Local variable 'maskOptions' could be declared final 3 149
GuardLogStatement Logger calls should be surrounded by log level guards. 2 153
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 177

org/apache/fulcrum/intake/validator/ValidationException.java

Rule Violation Priority Line
MethodArgumentCouldBeFinal Parameter 'message' is not assigned and could be declared final 3 45

org/apache/fulcrum/intake/validator/Validator.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like FLEXIBLE_RULE_NAME 3 34
LongVariable Avoid excessively long variable names like INVALID_NUMBER_RULE_NAME 3 40
LongVariable Avoid excessively long variable names like MAX_LENGTH_RULE_NAME 3 46
LongVariable Avoid excessively long variable names like MAX_VALUE_RULE_NAME 3 49
LongVariable Avoid excessively long variable names like MIN_LENGTH_RULE_NAME 3 52
LongVariable Avoid excessively long variable names like MIN_VALUE_RULE_NAME 3 55
LongVariable Avoid excessively long variable names like REQUIRED_RULE_NAME 3 58